Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Andrew Lunn
> > Hi Andrew, > > > > We're waiting for the DPIO driver (which we depend on) to be moved > > out of staging first, it's currently under review: > > https://lkml.org/lkml/2018/3/27/1086 > > That's stalled on my side right now as the merge window is open and I > can't do any new stuff until after

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread gregkh
ule...@nxp.com>; Razvan Stefanescu > > <razvan.stefane...@nxp.com>; Roy Pledge <roy.ple...@nxp.com>; > > Networking <netdev@vger.kernel.org> > > Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support > > > > On Thu, Apr 05, 2018

RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Ruxandra Ioana Ciocoi Radulescu
t;ioana.cior...@nxp.com>; gregkh > <gre...@linuxfoundation.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radule...@nxp.com>; Razvan Stefanescu > <razvan.stefane...@nxp.com>; Roy Pledge <roy.ple...@nxp.com>; > N

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Andrew Lunn
On Thu, Apr 05, 2018 at 02:43:29PM +, Laurentiu Tudor wrote: > Hi Andrew, > > On 04/05/2018 03:48 PM, Andrew Lunn wrote: > >>> Hi Laurentiu > >>> > >>> So i can use switchdev without it? I can modprobe the switchdev > >>> driver, all the physical interfaces will appear, and i can use ip addr

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Laurentiu Tudor
Hi Andrew, On 04/05/2018 03:48 PM, Andrew Lunn wrote: >>> Hi Laurentiu >>> >>> So i can use switchdev without it? I can modprobe the switchdev >>> driver, all the physical interfaces will appear, and i can use ip addr >>> add etc. I do not need to use a user space tool at all in order to use >>>

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread gregkh
On Thu, Apr 05, 2018 at 02:09:47PM +, Laurentiu Tudor wrote: > Hi Greg, > > On 04/05/2018 03:30 PM, gregkh wrote: > > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > >> Hello, > >> > >> My 2c below. > >> > >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: > I hear you. It

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Laurentiu Tudor
Hi Greg, On 04/05/2018 03:30 PM, gregkh wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: I hear you. It is more complicated this way...having all these individual objects vs just a

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Andrew Lunn
> > Hi Laurentiu > > > > So i can use switchdev without it? I can modprobe the switchdev > > driver, all the physical interfaces will appear, and i can use ip addr > > add etc. I do not need to use a user space tool at all in order to use > > the network functionality? > > Absolutely! Great.

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread gregkh
On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > Hello, > > My 2c below. > > On 04/04/2018 03:42 PM, Andrew Lunn wrote: > >> I hear you. It is more complicated this way...having all these individual > >> objects vs just a single "bundle" of them that represents a NIC. But, >

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Laurentiu Tudor
On 04/05/2018 02:47 PM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: I hear you. It is more complicated this way...having all these individual objects vs just a

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Andrew Lunn
On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > Hello, > > My 2c below. > > On 04/04/2018 03:42 PM, Andrew Lunn wrote: > >> I hear you. It is more complicated this way...having all these individual > >> objects vs just a single "bundle" of them that represents a NIC. But, >

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-05 Thread Laurentiu Tudor
Hello, My 2c below. On 04/04/2018 03:42 PM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-04 Thread Stuart Yoder
On Wed, Apr 4, 2018 at 7:42 AM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-04 Thread Andrew Lunn
> I hear you. It is more complicated this way...having all these individual > objects vs just a single "bundle" of them that represents a NIC. But, that's > the way the DPAA2 hardware is, and we're implementing kernel support for > the hardware as it is. Hi Stuart I see we are not making any

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Stuart Yoder
On Tue, Apr 3, 2018 at 8:05 PM, Andrew Lunn wrote: >> Suppose you want to create and assign a network interface to a KVM >> virtual machine, you would do something like the following using >> a user space tool like restool: >>-create a new (empty) dprc object >>-create a

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Andrew Lunn
> Suppose you want to create and assign a network interface to a KVM > virtual machine, you would do something like the following using > a user space tool like restool: >-create a new (empty) dprc object >-create a new dpni and assign it to the dprc >-create a new dpio and assign it

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Stuart Yoder
On Wed, Mar 28, 2018 at 10:43 AM, Arnd Bergmann wrote: > On Wed, Mar 28, 2018 at 4:27 PM, Ioana Ciornei wrote: >> Hi, >> >>> >>> Hi Ioana, >>> >>> So this driver is a direct passthrough to your hardware for passing fixed- >>> length command/response pairs.

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Andrew Lunn
On Tue, Apr 03, 2018 at 11:12:52AM +, Razvan Stefanescu wrote: > DPAA2 offers several object-based abstractions for modeling network > related devices (interfaces, L2 Ethernet switch) or accelerators > (DPSECI - crypto and DPDCEI - compression), the latter not up-streamed yet. > They are

RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Razvan Stefanescu
r > <laurentiu.tu...@nxp.com>; Linux Kernel Mailing List ker...@vger.kernel.org>; Stuart Yoder <stuyo...@gmail.com>; Ruxandra > Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com>; Razvan Stefanescu > <razvan.stefane...@nxp.com>; Roy Pledge <roy.ple...@nxp.co

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-02 Thread Andrew Lunn
Hi Ioana > The commands listed above are for creating/destroying DPAA2 objects > in Management Complex and not for runtime configuration where > standard userspace tools are used. Please can you explain why this is not just plumbing inside a switchdev driver? The hardware has a number of

RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-02 Thread Ioana Ciornei
> > > I'm still not convinced either way (high-level or low-level > > interface), but I think this needs to be discussed with the networking > > maintainers. Given the examples on the github page you linked to, the > > high-level user space commands based on these ioctls > > > >ls-addni #

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-03-28 Thread Andrew Lunn
> I'm still not convinced either way (high-level or low-level > interface), but I think > this needs to be discussed with the networking maintainers. Given the examples > on the github page you linked to, the high-level user space commands > based on these ioctls > >ls-addni # adds a

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-03-28 Thread Arnd Bergmann
On Wed, Mar 28, 2018 at 4:27 PM, Ioana Ciornei wrote: > Hi, > >> >> Hi Ioana, >> >> So this driver is a direct passthrough to your hardware for passing fixed- >> length command/response pairs. Have you considered using a higher-level >> interface instead? >> >> Can you list