Re: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-22 Thread Leon Romanovsky
On Wed, Sep 21, 2016 at 02:15:39PM +, Amrani, Ram wrote: > > > include/uapi/rdma/providers/qedr-abi.h | 35 + > > > > Please be aware that the last version for ABI header files doesn't have > > "provider" > > name in directory path (include/uapi/rdma/qedr-abi.h) > > OK. Note that I was

RE: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-22 Thread Amrani, Ram
> > Do you have a git tree? > We don't have a publicly accessible git tree.

Re: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-21 Thread Jason Gunthorpe
On Wed, Sep 21, 2016 at 02:23:46PM +, Amrani, Ram wrote: > > Ugh, each patch keeps adding to this? > > The logic in the patch series is to have each patch contain only > what is necessary for the specific functionality it adds. This made > it harder on us to prepare but, IMHO, easier for the

RE: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-21 Thread Amrani, Ram
> > include/uapi/rdma/providers/qedr-abi.h | 35 + > > Please be aware that the last version for ABI header files doesn't have > "provider" > name in directory path (include/uapi/rdma/qedr-abi.h) OK. Note that I was using https://www.spinics.net/lists/linux-rdma/msg40414.html that dates

RE: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-21 Thread Amrani, Ram
> Ugh, each patch keeps adding to this? The logic in the patch series is to have each patch contain only what is necessary for the specific functionality it adds. This made it harder on us to prepare but, IMHO, easier for the reviewer. If you'd like to have this file in one chunk, I can do this.

Re: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-20 Thread Leon Romanovsky
On Tue, Sep 20, 2016 at 01:35:58PM +0300, Ram Amrani wrote: > From: Ram amrani > > Add support for Queue Pair verbs which adds, deletes, > modifies and queries Queue Pairs. > > Signed-off-by: Rajesh Borundia > Signed-off-by: Ram Amrani

Re: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-20 Thread Jason Gunthorpe
On Tue, Sep 20, 2016 at 01:35:58PM +0300, Ram Amrani wrote: > +++ b/include/uapi/rdma/providers/qedr-abi.h > @@ -43,4 +43,39 @@ struct qedr_create_cq_uresp { > u16 icid; > }; Ugh, each patch keeps adding to this? > +struct qedr_create_qp_ureq { > + u32 qp_handle_hi; > + u32