Re: [net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

2017-06-21 Thread Gal Pressman
>> +u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0}; > How big is that? > > Allocating large on-stack buffers is even worse. Both PPCNT and MPCNT registers are 252 bytes. I don't see a problem allocating them on the stack.

RE: [net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

2017-06-20 Thread David Laight
From: Saeed Mahameed > Sent: 15 June 2017 22:43 > Allocating buffers on the heap every 200ms is something we should avoid, > let's use buffers located on the stack instead. ... > + u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0}; How big is that? Allocating large on-stack buffers is even worse. One