Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Zefir Kurtisi
On 11/29/2016 07:35 PM, Nikita Yushchenko wrote: > Fec driver uses Rx buffers of 2k, but programs hardware to limit > incoming frames to 1522 bytes. This raises issues when FEC device > is used with DSA (since DSA tag can make frame larger), and also > disallows manual sending and receiving larger

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Andy Duan
From: Nikita Yushchenko Sent: Wednesday, November 30, 2016 2:35 AM >To: David S. Miller ; Andy Duan >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Andy Duan
Eric Nelson <e...@nelint.com>; Philippe >Reynes <trem...@gmail.com>; Johannes Berg <johan...@sipsolutions.net>; >netdev@vger.kernel.org >Cc: Chris Healy <cphe...@gmail.com>; Fabio Estevam ><fabio.este...@nxp.com>; linux-ker...@vger.kernel.org >S

Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Toshiaki Makita
On 2016/11/30 15:36, Nikita Yushchenko wrote: >> But I think it is not necessary since the driver don't support jumbo frame. > > Hardcoded 1522 raises two separate issues. > > (1) When DSA is in use, frames processed by FEC chip contain DSA tag and > thus can be larger than hardcoded limit of

Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Nikita Yushchenko
> But I think it is not necessary since the driver don't support jumbo frame. Hardcoded 1522 raises two separate issues. (1) When DSA is in use, frames processed by FEC chip contain DSA tag and thus can be larger than hardcoded limit of 1522. This issue is not FEC-specific, any driver that