On Tue, Aug 04, 2015 at 09:15:13AM +, David Laight wrote:
You've introduced a memory leak if skb_clone() fails.
No I have not.
nskb = skb_clone(skb, GFP_ATOMIC);
if (!nskb)
- return -ENOMEM;
+ return ERR_PTR(-ENOMEM);
Here the original skb is still
David Laight david.lai...@aculab.com wrote:
In that case, what happens to the receive queue when skb_clone()
takes a copy of the skb - freeing the original one?
The new skb is inserted into the recv queue and replacing the
existing skb.
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home
From: Herbert Xu
Sent: 04 August 2015 10:21
On Tue, Aug 04, 2015 at 09:15:13AM +, David Laight wrote:
You've introduced a memory leak if skb_clone() fails.
No I have not.
nskb = skb_clone(skb, GFP_ATOMIC);
if (!nskb)
- return -ENOMEM;
+ return
From: Herbert Xu
Sent: 04 August 2015 08:43
Brenden Blanco bbla...@plumgrid.com wrote:
[ 318.244596] BUG: unable to handle kernel NULL pointer dereference
at 008e
[ 318.245182] IP: [81455e7c] __skb_recv_datagram+0xbc/0x5a0
Replying to myself, and adding commit
