On 12/08/2018 12:14 PM, Ilias Apalodimas wrote:
> On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote:
>>>
>>> I want to make sure you guys thought about splice() stuff, and
>>> skb_try_coalesce(), and GRO, and skb cloning, and ...
>>
>> Thanks for the pointers. To Ilias,
On Sat, Dec 08, 2018 at 10:14:47PM +0200, Ilias Apalodimas wrote:
> On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote:
> > >
> > > I want to make sure you guys thought about splice() stuff, and
> > > skb_try_coalesce(), and GRO, and skb cloning, and ...
> >
> > Thanks for
> That is not how XDP works. XDP must run on the "master" physical driver
> interface, as the "slave" interface is a virtual DSA interface. I did
> mention DSA because I'm handling that on the EspressoBin implementation.
Hi Jesper
It is going to be interesting to see how you do that.
As a
On Sat, 8 Dec 2018 19:43:38 +0100
Björn Töpel wrote:
> Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer :
> >
> > On Fri, 7 Dec 2018 15:01:55 +0100
> > Björn Töpel wrote:
> >
> > > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer
> > > :
> > > >
> > > > On Fri, 7 Dec
On Sat, 8 Dec 2018 17:55:05 +0100
Andrew Lunn wrote:
> On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote:
> > On Fri, 7 Dec 2018 13:21:08 -0800
> > Alexei Starovoitov wrote:
> >
> > > for production I suspect the users would want
> > > an easy way to stay safe when
driver writer doesn't go through the
'proper' path, i.e allocate buffers and use build_skb, you end up having to
rewrite dma/memory management for the nornal stack. So it's more than
'shoe-horning' XDP, it's re-writing and re-testing the whole thing.
The API also offers dma mapping capabilities (configurab
From: Willem de Bruijn
Date: Sat, 8 Dec 2018 06:22:46 -0500
> From: Willem de Bruijn
>
> extra_uref is used in __ip(6)_append_data only if uarg is set.
>
> Smatch sees that the variable is passed to sock_zerocopy_put_abort.
> This function accesses it only when uarg is set, but smatch cannot
From: Ilias Apalodimas
Date: Sat, 8 Dec 2018 16:57:28 +0200
> The patchset speeds up the mvneta driver on the default network
> stack. The only change that was needed was to adapt the driver to
> using the page_pool API. The speed improvements we are seeing on
> specific workloads (i.e 256b <
On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote:
> >
> > I want to make sure you guys thought about splice() stuff, and
> > skb_try_coalesce(), and GRO, and skb cloning, and ...
>
> Thanks for the pointers. To Ilias, we need to double check skb_try_coalesce()
> code path,
On Sat, 8 Dec 2018 11:26:56 -0800
Eric Dumazet wrote:
> On 12/08/2018 06:57 AM, Ilias Apalodimas wrote:
> > Hi Eric,
> This patch is changing struct sk_buff, and is thus per-definition
> controversial.
>
> Place a new member 'mem_info' of type struct xdp_mem_info, just
From: Jesper Dangaard Brouer
Date: Sat, 8 Dec 2018 12:36:10 +0100
> The annoying part is actually that depending on the kernel config
> options CONFIG_XFRM, CONFIG_NF_CONNTRACK and CONFIG_BRIDGE_NETFILTER,
> whether there is a cache-line split, where mem_info gets moved into the
> next
On 12/08/2018 06:57 AM, Ilias Apalodimas wrote:
> Hi Eric,
This patch is changing struct sk_buff, and is thus per-definition
controversial.
Place a new member 'mem_info' of type struct xdp_mem_info, just after
members (flags) head_frag and pfmemalloc, And not in
Den lör 8 dec. 2018 kl 16:12 skrev Jesper Dangaard Brouer :
>
> On Fri, 7 Dec 2018 13:21:08 -0800
> Alexei Starovoitov wrote:
>
> > for production I suspect the users would want
> > an easy way to stay safe when they're playing with AF_XDP.
> > So another builtin program that redirects ssh and
Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer :
>
> On Fri, 7 Dec 2018 15:01:55 +0100
> Björn Töpel wrote:
>
> > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer
> > :
> > >
> > > On Fri, 7 Dec 2018 12:44:24 +0100
> > > Björn Töpel wrote:
> > >
> > > > The rationale behind
Le 12/7/18 à 8:25 PM, Marek Vasut a écrit :
> On 12/08/2018 01:52 AM, tristram...@microchip.com wrote:
>>> - padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
>>> + padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb-
len;
>>
>> The requirement is the tail tag should
Thu, Dec 06, 2018 at 11:40:01PM CET, pa...@netfilter.org wrote:
>This is a preparation patch to reuse the existing TC flower codebase
>from ethtool_rx_flow_spec.
>
>This patch is merely moving the core ethtool_rx_flow_spec parser after
>tc flower offload driver code so we can skip a few forward
Thu, Dec 06, 2018 at 11:40:00PM CET, pa...@netfilter.org wrote:
>Update this driver to use the flow_rule infrastructure, hence we can use
>the same code to populate hardware IR from ethtool_rx_flow and the
>cls_flower interfaces.
>
>Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
> I got other concerns on the patchset though. Like how much memory is
> it 'ok' to keep mapped keeping in mind we are using the streaming
> DMA API. Are we going to affect anyone else negatively by doing so ?
For mvneta, you can expect the target to have between 512Mbyte to
3G. You can take a
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit :
> Soon to be mainlined is an x86 platform with a Marvell switch, and a
> bit-banging MDIO bus. In order to make this work, the phy_mask of the
> MDIO bus needs to be set to prevent scanning for PHYs, and the
> phy_ignore_ta_mask needs to be set because
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit :
> The Marvell 6390 Ethernet switch family does not perform MDIO
> turnaround correctly. Many hardware MDIO bus masters don't care about
> this, but the bitbangging implementation in Linux does by default. Add
> phy_ignore_ta_mask to the platform data so
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit :
> It is sometimes necessary to instantiate a bit-banging MDIO bus as a
> platform device, without the aid of device tree.
>
> When device tree is being used, the bus is not scanned for devices,
> only those devices which are in device tree are probed.
On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote:
> On Fri, 7 Dec 2018 13:21:08 -0800
> Alexei Starovoitov wrote:
>
> > for production I suspect the users would want
> > an easy way to stay safe when they're playing with AF_XDP.
> > So another builtin program that redirects
On Fri, 7 Dec 2018 13:21:08 -0800
Alexei Starovoitov wrote:
> for production I suspect the users would want
> an easy way to stay safe when they're playing with AF_XDP.
> So another builtin program that redirects ssh and ping traffic
> back to the kernel would be a nice addition.
Are you saying
Hi Eric,
> >> This patch is changing struct sk_buff, and is thus per-definition
> >> controversial.
> >>
> >> Place a new member 'mem_info' of type struct xdp_mem_info, just after
> >> members (flags) head_frag and pfmemalloc, And not in between
> >> headers_start/end to ensure skb_copy() and
On Fri, 7 Dec 2018 15:01:55 +0100
Björn Töpel wrote:
> Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer :
> >
> > On Fri, 7 Dec 2018 12:44:24 +0100
> > Björn Töpel wrote:
> >
> > > The rationale behind attach is performance and ease of use. Many XDP
> > > socket users just need a
On Sat, 8 Dec 2018 04:29:17 -0800
Eric Dumazet wrote:
> On 12/08/2018 01:57 AM, Florian Westphal wrote:
> > Jesper Dangaard Brouer wrote:
> >> From: Ilias Apalodimas
> >>
> >> This patch is changing struct sk_buff, and is thus per-definition
> >> controversial.
> >>
> >> Place a new member
Thu, Dec 06, 2018 at 11:39:59PM CET, pa...@netfilter.org wrote:
>This patch adds a function to translate the ethtool_rx_flow_spec
>structure to the flow_rule representation.
>
>This allows us to reuse code from the driver side given that both flower
>and ethtool_rx_flow interfaces use the same
Thu, Dec 06, 2018 at 11:39:58PM CET, pa...@netfilter.org wrote:
>These actions need to be added to support the ethtool_rx_flow interface.
>The queue action includes a field to specify the RSS context, that is
>set via FLOW_RSS flow type flag and the rss_context field in struct
>ethtool_rxnfc, plus
Thu, Dec 06, 2018 at 11:39:56PM CET, pa...@netfilter.org wrote:
>This patch updates drivers to use the new flow action infrastructure.
>
>Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
Thu, Dec 06, 2018 at 11:39:57PM CET, pa...@netfilter.org wrote:
>Now that drivers have been converted to use the flow action
>infrastructure, remove this field from the tc_cls_flower_offload
>structure.
>
>Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
Thu, Dec 06, 2018 at 11:39:55PM CET, pa...@netfilter.org wrote:
>This patch provides the flow_stats structure that acts as container for
>tc_cls_flower_offload, then we can use to restore the statistics on the
>existing TC actions. Hence, tcf_exts_stats_update() is not used from
>drivers anymore.
On 12/08/2018 04:29 AM, Eric Dumazet wrote:
>
> But I do not get why the patch is needed.
>
> Adding extra cost for each skb destruction is costly.
>
> I though XDP was all about _not_ having skbs.
>
> Please let's do not slow down the non XDP stack only to make XDP more
> appealing.
>
On 12/08/2018 01:57 AM, Florian Westphal wrote:
> Jesper Dangaard Brouer wrote:
>> From: Ilias Apalodimas
>>
>> This patch is changing struct sk_buff, and is thus per-definition
>> controversial.
>>
>> Place a new member 'mem_info' of type struct xdp_mem_info, just after
>> members (flags)
> +static int ksz8795_valid_dyn_entry(struct ksz_device *dev, u8 *data)
> +{
> + int timeout = 100;
> +
> + do {
> + ksz_read8(dev, REG_IND_DATA_CHECK, data);
> + timeout--;
> + } while ((*data & DYNAMIC_MAC_TABLE_NOT_READY) && timeout);
readx_poll_timeout()?
On Sat, 8 Dec 2018 10:57:58 +0100
Florian Westphal wrote:
> Jesper Dangaard Brouer wrote:
> > From: Ilias Apalodimas
> >
> > This patch is changing struct sk_buff, and is thus per-definition
> > controversial.
> >
> > Place a new member 'mem_info' of type struct xdp_mem_info, just after
> >
On Fri, Dec 07, 2018 at 07:18:43PM +0100, Marek Vasut wrote:
> From: Tristram Ha
>
> Factor out common code from the tag_ksz , so that the code can be used
> with other KSZ family switches which use differenly sized tags.
I prefer this implementation over what Tristram recently submitted. It
is
> +static void ksz9477_phy_setup(struct ksz_device *dev, int port,
> + struct phy_device *phy)
> +{
> + if (port < dev->phy_port_cnt) {
> + /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
> + * disable flow control when rate
> This actually is an individual patch, it doesn't depend on anything.
> Or do you mean a series with the DT documentation change ?
Yes, i mean together with the DT documentation change. Those two
belong together, they are one functional change.
Part of this is also to do with scalability. It
On Sat, Dec 08, 2018 at 05:23:25AM +0100, Marek Vasut wrote:
> On 12/08/2018 01:13 AM, tristram...@microchip.com wrote:
> >> Do you have a git tree with all the KSZ patches based on -next
> >> somewhere, so I don't have to look for them in random MLs ?
> >
> > I just sent it this Monday and the
Hi:
Seems there are only 6 patches of the patch set in patchwork
https://patchwork.ozlabs.org/project/netdev/list/?submitter=70569
https://patchwork.ozlabs.org/project/netdev/list/?series=80389
Anyone can help to check why patch 7/7 is missing?
Thanks
Qi
> -Original Message-
> From:
Jesper Dangaard Brouer wrote:
> From: Ilias Apalodimas
>
> This patch is changing struct sk_buff, and is thus per-definition
> controversial.
>
> Place a new member 'mem_info' of type struct xdp_mem_info, just after
> members (flags) head_frag and pfmemalloc, And not in between
>
Den fre 7 dec. 2018 kl 22:21 skrev Alexei Starovoitov
:
>
> On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote:
> > From: Björn Töpel
> >
> > Hi!
> >
> > This patch set adds support for a new XDP socket bind option,
> > XDP_ATTACH.
> >
> > The rationale behind attach is performance and
Thu, Dec 06, 2018 at 11:39:54PM CET, pa...@netfilter.org wrote:
>This patch implements a new function to translate from native TC action
>to the new flow_action representation. Moreover, this patch also updates
>cls_flower to use this new function.
>
>Signed-off-by: Pablo Neira Ayuso
Acked-by:
Thu, Dec 06, 2018 at 11:39:53PM CET, pa...@netfilter.org wrote:
>This new infrastructure defines the nic actions that you can perform
>from existing network drivers. This infrastructure allows us to avoid a
>direct dependency with the native software TC action representation.
>
>Signed-off-by:
Thu, Dec 06, 2018 at 11:39:52PM CET, pa...@netfilter.org wrote:
>This patch adds pedit_headers_action structure to store the result of
>parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to
>populate the mlx5e hardware intermediate representation once all actions
>have been parsed.
>
Thu, Dec 06, 2018 at 11:39:51PM CET, pa...@netfilter.org wrote:
>This patch wraps the dissector key and mask - that flower uses to
>represent the matching side - around the flow_match structure.
>
>To avoid a follow up patch that would edit the same LoCs in the drivers,
>this patch also wraps this
On Fri, Dec 07, 2018 at 11:06:55PM -0800, David Miller wrote:
> This isn't going to work on 32-bit platforms where dma_addr_t is a u64,
> because the page private is unsigned long.
>
> Grep for PHY_ADDR_T_64BIT under arch/ to see the vast majority of the
> cases where this happens, then
On Fri, Dec 07, 2018 at 11:15:14PM -0800, David Miller wrote:
> From: Jesper Dangaard Brouer
> Date: Fri, 07 Dec 2018 00:25:47 +0100
>
> > @@ -744,6 +745,10 @@ struct sk_buff {
> > head_frag:1,
> > xmit_more:1,
> >
From: Jesper Dangaard Brouer
Date: Fri, 07 Dec 2018 00:25:47 +0100
> @@ -744,6 +745,10 @@ struct sk_buff {
> head_frag:1,
> xmit_more:1,
> pfmemalloc:1;
> + /* TODO: Future idea, extend mem_info with
From: Jesper Dangaard Brouer
Date: Fri, 07 Dec 2018 00:25:32 +0100
> From: Ilias Apalodimas
>
> Add helper functions for retreiving dma_addr_t stored in page_private and
> unmapping dma addresses, mapped via the page_pool API.
>
> Signed-off-by: Ilias Apalodimas
> Signed-off-by: Jesper
From: Benjamin Herrenschmidt
Date: Fri, 07 Dec 2018 15:05:04 +1100
> This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9.
>
> This commit is completely bogus. The STACR register has two formats, old
> and new, depending on the version of the IP block used. There's a pair of
>
From: Maciej Żenczykowski
Date: Fri, 7 Dec 2018 16:46:36 -0800
>> This doesn't apply to the current net tree.
>>
>> Also "net-udp: " is a weird subsystem prefix, just use "udp: ".
>>
>> Thank you.
>
> Interesting... this patch was on top of net-next/master, and it still
> rebases cleanly on
On 12/08/2018 12:46 AM, David Miller wrote:
> From: Marek Vasut
> Date: Fri, 7 Dec 2018 23:59:58 +0100
>
>> On 12/07/2018 11:24 PM, Andrew Lunn wrote:
>>> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
Add code to handle optional reset GPIO in the KSZ switch driver. The switch
On 12/08/2018 01:52 AM, tristram...@microchip.com wrote:
>> -padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
>> +padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb-
>>> len;
>
> The requirement is the tail tag should be at the end of frame before FCS.
> When the
On 12/08/2018 01:13 AM, tristram...@microchip.com wrote:
>> Do you have a git tree with all the KSZ patches based on -next
>> somewhere, so I don't have to look for them in random MLs ?
>
> I just sent it this Monday and the subject for that patch is
> "[PATCH RFC 6/6] net: dsa: microchip: Add
> - padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
> + padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb-
> >len;
The requirement is the tail tag should be at the end of frame before FCS.
When the length is less than 60 the MAC controller will pad the frame to
> This doesn't apply to the current net tree.
>
> Also "net-udp: " is a weird subsystem prefix, just use "udp: ".
>
> Thank you.
Interesting... this patch was on top of net-next/master, and it still
rebases cleanly on current net-next/master.
Would you like it on net/master instead? It indeed
From: Lucas Bates
Date: Thu, 6 Dec 2018 17:42:23 -0500
> Patch 1 adds a timeout feature for any command tdc launches in a subshell.
> This prevents tdc from hanging indefinitely.
>
> Patches 2-4 introduce a new method for tracking and generating test case
> results, and implements it across
From: Stefano Brivio
Date: Thu, 6 Dec 2018 19:30:35 +0100
> Patch 1/2 fixes a slab out-of-bounds occurring with short SCTP packets over
> IPv4 over L2TP over IPv6 on a configuration with relatively low HEADER_MAX.
>
> Patch 2/2 makes sure we avoid writing before the allocated buffer in
>
From: Eric Dumazet
Date: Thu, 6 Dec 2018 09:58:24 -0800
> tcp_tso_should_defer() can return true in three different cases :
>
> 1) We are cwnd-limited
> 2) We are rwnd-limited
> 3) We are application limited.
>
> Neal pointed out that my recent fix went too far, since
> it assumed that if
From: Maciej Żenczykowski
Date: Wed, 5 Dec 2018 12:59:17 -0800
> From: Maciej Żenczykowski
>
> During udp socket lookup cpu match should be lowest priority,
> hence it should increase score by only 1.
>
> The next priority is delivering v4 to v4 sockets, and v6 to v6 sockets.
> The v6 code
> Do you have a git tree with all the KSZ patches based on -next
> somewhere, so I don't have to look for them in random MLs ?
I just sent it this Monday and the subject for that patch is
"[PATCH RFC 6/6] net: dsa: microchip: Add switch offload forwarding support."
From: yupeng
Date: Wed, 5 Dec 2018 18:56:28 -0800
> after set SO_DONTROUTE to 1, the IP layer should not route packets if
> the dest IP address is not in link scope. But if the socket has cached
> the dst_entry, such packets would be routed until the sk_dst_cache
> expires. So we should clean
> > I think if you do this without setting offload_fwd_mark you will
> > receive duplicate frame.
>
> I don't think it will, at least not in the normal case. The hardware
> should know the egress port, so there is no need to forward a copy to
> the CPU. The only time it should forward to the CPU
From: David Ahern
Date: Fri, 7 Dec 2018 12:24:57 -0800
> From: David Ahern
>
> The existing garbage collection algorithm has a number of problems:
...
> This patch addresses these problems as follows:
>
> 1. Use of a separate list_head to track entries that can be garbage
>collected
> >> If two ports are in the same bridge and in forwarding state, the packets
> >> must be able to pass between them in both directions. The current code
> >> only configures this bridge membership for a port newly added to the
> >> bridge, but does not update all the other ports. Thus, ingress
From: Marek Vasut
Date: Fri, 7 Dec 2018 23:59:58 +0100
> On 12/07/2018 11:24 PM, Andrew Lunn wrote:
>> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
>>> Add code to handle optional reset GPIO in the KSZ switch driver. The switch
>>> has a reset GPIO line which can be controlled by
From: Eric Dumazet
Date: Fri, 7 Dec 2018 15:03:04 -0800
> On 12/07/2018 02:24 PM, David Ahern wrote:
>> On 12/7/18 3:20 PM, Eric Dumazet wrote:
>>
>> /* --- cacheline 3 boundary (192 bytes) --- */
>> struct hh_cachehh; /* 19248 */
>>
>> ...
>>
>> but does
On 12/07/2018 02:24 PM, David Ahern wrote:
> On 12/7/18 3:20 PM, Eric Dumazet wrote:
>>
>>
>> On 12/07/2018 01:49 PM, David Ahern wrote:
>>> From: David Ahern
>>>
>>> Similar to routes and rules, add protocol attribute to neighbor entries
>>> for easier tracking of how each was created.
>>>
On 12/07/2018 11:24 PM, Andrew Lunn wrote:
> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
>> Add code to handle optional reset GPIO in the KSZ switch driver. The switch
>> has a reset GPIO line which can be controlled by the CPU, so make sure it is
>> configured correctly in such
On 12/7/18 3:20 PM, Eric Dumazet wrote:
>
>
> On 12/07/2018 01:49 PM, David Ahern wrote:
>> From: David Ahern
>>
>> Similar to routes and rules, add protocol attribute to neighbor entries
>> for easier tracking of how each was created.
>>
>> Signed-off-by: David Ahern
>> ---
>>
On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
> Add code to handle optional reset GPIO in the KSZ switch driver. The switch
> has a reset GPIO line which can be controlled by the CPU, so make sure it is
> configured correctly in such setups.
Hi Marek
Please make this a patch
On 12/07/2018 01:49 PM, David Ahern wrote:
> From: David Ahern
>
> Similar to routes and rules, add protocol attribute to neighbor entries
> for easier tracking of how each was created.
>
> Signed-off-by: David Ahern
> ---
> include/net/neighbour.h| 2 ++
>
On 12/07/2018 08:55 PM, Andrew Lunn wrote:
>> +dev->reset_gpio = -1;
>> +reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0,
>> + _gpio_flags);
>> +if (reset_gpio >= 0) {
>> +flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ?
On Wed, Dec 05, 2018 at 08:40:47PM -0800, Stanislav Fomichev wrote:
> We are returning thoff from the flow dissector, not the nhoff. Pass
> thoff along with nhoff to the bpf program (initially thoff == nhoff)
> and expect flow dissector amend/return thoff, not nhoff.
>
> This avoids confusion,
On Wed, Dec 05, 2018 at 01:52:29PM -0500, Jiong Wang wrote:
> BPF_ALU | BPF_ARSH | BPF_* were rejected by commit: 7891a87efc71
> ("bpf: arsh is not supported in 32 bit alu thus reject it"). As explained
> in the commit message, this is due to there is no complete support for them
> on interpreter
On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote:
> From: Björn Töpel
>
> Hi!
>
> This patch set adds support for a new XDP socket bind option,
> XDP_ATTACH.
>
> The rationale behind attach is performance and ease of use. Many XDP
> socket users just need a simple way of
On 12/4/18 3:14 AM, Shalom Toledo wrote:
> Patch #1 add string to uint conversion support for generic parameters.
> Patch #2 add string to uint support for 'fw_load_policy' generic parameter
>
> Shalom Toledo (2):
> devlink: Add string to uint{8,16,32} conversion for generic parameters
>
Every patch series should have a header posting with Subject of
the form "[PATCH 0/N] ..." explaining what the series does at
a high level, how it does it, and why it does it that way.
* Russell King - ARM Linux [181207 19:27]:
> You mentioned that edge mode didn't work as well as level mode on
> duovero smsc controller, I think this may help to solve the same
> issue but for edge IRQs - we need a mask_ack_irq function to avoid
> acking while the edge interrupt is masked. Let
From: Igor Russkikh
Date: Fri, 7 Dec 2018 14:00:09 +
> In this patchset few bugs related to RSS are fixed and RSS table and
> hash key configuration is added.
>
> We also do increase max number of HW rings upto 8.
>
> v2: removed extra arg check
Series applied.
On 12/7/18 9:26 AM, Andrew Lunn wrote:
>> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs?
>
> I think it makes sense to allow a fixed phy carrier to be changed from
> user space. However, i don't think you can easily plumb that to
> .ndo_change_carrier(), since that is a
On Fri, Dec 07, 2018 at 08:04:26AM +0200, Leon Romanovsky wrote:
> On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote:
> > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky
> > >
> > > >From Danit,
> > >
> > > Packet based credit mode is an
g and I will not able to re-
post soon.
> ld: net/ipv6/ip6_offload.o: in function `ipv6_gro_receive':
> ip6_offload.c:(.text+0xda2): undefined reference to `udp6_gro_receive'
> ld: ip6_offload.c:(.text+0xdb6): undefined reference to `udp6_gro_receive'
> ld: net/ipv6/ip6_offload.
From: Shmulik Ladkani
Date: Fri, 7 Dec 2018 09:50:17 +0200
> In 'seg6_output', stack variable 'struct flowi6 fl6' was missing
> initialization.
>
> Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and
> injection with lwtunnels")
> Signed-off-by: Shmulik Ladkani
Applied and
> I think if you do this without setting offload_fwd_mark you will
> receive duplicate frame.
I don't think it will, at least not in the normal case. The hardware
should know the egress port, so there is no need to forward a copy to
the CPU. The only time it should forward to the CPU is when the
On 12/07/2018 08:37 PM, tristram...@microchip.com wrote:
>> If two ports are in the same bridge and in forwarding state, the packets
>> must be able to pass between them in both directions. The current code
>> only configures this bridge membership for a port newly added to the
>> bridge, but does
> + dev->reset_gpio = -1;
> + reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0,
> + _gpio_flags);
> + if (reset_gpio >= 0) {
> + flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ?
> + GPIOF_ACTIVE_LOW :
On 12/6/18 8:59 PM, David Miller wrote:
> But why do you need the on_gc_list boolean state? f
mental blockage.
v2 coming up.
On 12/7/18 11:37 AM, tristram...@microchip.com wrote:
>> If two ports are in the same bridge and in forwarding state, the packets
>> must be able to pass between them in both directions. The current code
>> only configures this bridge membership for a port newly added to the
>> bridge, but does
> If two ports are in the same bridge and in forwarding state, the packets
> must be able to pass between them in both directions. The current code
> only configures this bridge membership for a port newly added to the
> bridge, but does not update all the other ports. Thus, ingress packets
> on
On Fri, Dec 07, 2018 at 11:03:12AM -0800, Tony Lindgren wrote:
> * Tony Lindgren [181207 18:14]:
> > Hi,
> >
> > * Russell King - ARM Linux [181207 18:01]:
> > > Hi Tony,
> > >
> > > You know most of what's been going on from IRC, but here's the patch
> > > which gets me:
> > >
> > > 1)
* Tony Lindgren [181207 18:14]:
> Hi,
>
> * Russell King - ARM Linux [181207 18:01]:
> > Hi Tony,
> >
> > You know most of what's been going on from IRC, but here's the patch
> > which gets me:
> >
> > 1) working interrupts for networking
> > 2) solves the stuck-wakeup problem
> >
> > It
n() has to
> > be called
> >
> > The explanation of additional 3 steps from another email makes sense to me.
> >
> > Can you take a look why it helps default (llvm alu64) case too ?
> > bpf_overlay.o 3096/2898
>
> It is embarrassing that I am n
Hi,
* Russell King - ARM Linux [181207 18:01]:
> Hi Tony,
>
> You know most of what's been going on from IRC, but here's the patch
> which gets me:
>
> 1) working interrupts for networking
> 2) solves the stuck-wakeup problem
>
> It also contains some of the debug bits I added.
This is
> -Original Message-
> From: Ilias Apalodimas
> Sent: Friday, December 7, 2018 7:52 PM
> To: Ioana Ciocoi Radulescu
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
>
>
Hi Tony,
You know most of what's been going on from IRC, but here's the patch
which gets me:
1) working interrupts for networking
2) solves the stuck-wakeup problem
It also contains some of the debug bits I added.
I think what this means is that we should strip out ec0daae685b2
("gpio: omap:
Hi Ioana,
> > > >
> > I only did a quick grep around the driver so i might be missing something,
> > but i can only see allocations via napi_alloc_frag(). XDP requires pages
> > (either a single page per packet or a driver that does the page management
> > of
> > its own and fits 2 frames in a
> -Original Message-
> From: Ilias Apalodimas
> Sent: Friday, December 7, 2018 7:20 PM
> To: Ioana Ciocoi Radulescu
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
>
> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs?
I think it makes sense to allow a fixed phy carrier to be changed from
user space. However, i don't think you can easily plumb that to
.ndo_change_carrier(), since that is a MAC feature. You need to change
the
1 - 100 of 145660 matches
Mail list logo
