Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Johannes Berg
On Thu, 2016-01-28 at 19:54 -0600, Larry Finger wrote: >  > I have been running an RTL8821AE since kernel 3.18 without hitting > this problem > using a TRENDnet AC1750 dual-band AP. The UniFi may be doing > something that the > driver is not expecting. Are you quite sure you're actually using

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Johannes Berg
On Fri, 2016-01-29 at 10:12 -0600, Larry Finger wrote: >  > Upon further inspection, my log has the line "rtl8821ae :02:00.0 > wlp2s0: disabling HT/VHT due to WEP/TKIP use". I need to fix that > first. > Likely TKIP; enable only WPA2 (CCMP) on the AP. johannes

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Larry Finger
On 01/29/2016 10:15 AM, Johannes Berg wrote: On Fri, 2016-01-29 at 10:12 -0600, Larry Finger wrote: Upon further inspection, my log has the line "rtl8821ae :02:00.0 wlp2s0: disabling HT/VHT due to WEP/TKIP use". I need to fix that first. Likely TKIP; enable only WPA2 (CCMP) on the AP.

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Larry Finger
Linus, Attached is a trial patch that fixes the problem on my system. As I told Johannes earlier, my AP was not configured to use VHT, thus I did not see the problem. The test patch that Johannes sent earlier was close. The section needed to add VHT rates is: ---

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Linus Torvalds
On Fri, Jan 29, 2016 at 9:54 AM, Larry Finger wrote: > > The test patch that Johannes sent earlier was close. The section needed to > add VHT rates is: Hmm. This looks pretty much exactly like what I already tried (I had fixed Johannes' patch to use "vht_cap" already,

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Linus Torvalds
On Fri, Jan 29, 2016 at 11:42 AM, Larry Finger wrote: > > Thanks for testing. > > Upon reflection, it really should check the other WIRELESS_MODE_AC_x bits. > Johannes' patch was indeed correct. I just retested with this incremental (and whitespace-damaged) patch:

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-29 Thread Larry Finger
On 01/29/2016 12:39 PM, Linus Torvalds wrote: On Fri, Jan 29, 2016 at 9:54 AM, Larry Finger wrote: The test patch that Johannes sent earlier was close. The section needed to add VHT rates is: Hmm. This looks pretty much exactly like what I already tried (I had

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 4:13 AM, Johannes Berg wrote: > On Wed, 2016-01-27 at 21:34 -0800, Linus Torvalds wrote: > >> .. except now I upgraded the nearest access point, and now wireless >> on that machine no longer works. > > Can you describe the upgrade a bit more,

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 1:44 PM, Linus Torvalds wrote: > > I will try Johannes' suggestion on that machine to see if it makes a > difference Well, it "makes a difference" in the sense that the warning goes away. But it doesn't make things work. In fact, it might be

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Johannes Berg
On Thu, 2016-01-28 at 14:04 -0800, Linus Torvalds wrote: >  > Well, it "makes a difference" in the sense that the warning goes > away. > But it doesn't make things work. In fact, it might be making things > worse. Heh, ok. > Because with that patch, the wireless still authenticates and >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 2:12 PM, Johannes Berg wrote: > > Your best workaround may just be to ignore VHT for now - clearly it's > broken so using "just" HT (which is likely not that much of a penalty > anyway since you're apparently not using 80 MHz) will be much

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
Adding the RTL people to the cc, and leaving the whole thing quoted at the bottom.. I will try Johannes' suggestion on that machine to see if it makes a difference, but somebody who knows the rtlwifi rate control code should take a double- or triple-look at this. Please? Some googling shows that

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Johannes Berg
On Thu, 2016-01-28 at 11:01 -0800, Linus Torvalds wrote: >  > I used to have the basic original UniFi UAP. I've replaced them with > the newer "AC Lite" version: > > https://www.ubnt.com/unifi/unifi-ap-ac-lite/ > > so it's a fairly big jump from a 2.4GHz-only network to a dual-band > one. >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Johannes Berg
On Wed, 2016-01-27 at 21:34 -0800, Linus Torvalds wrote: > .. except now I upgraded the nearest access point, and now wireless > on that machine no longer works. Can you describe the upgrade a bit more, just for background? > Or rather, it actually *does* work in the sense that it >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 5:54 PM, Larry Finger wrote: > > I have been running an RTL8821AE since kernel 3.18 without hitting this > problem using a TRENDnet AC1750 dual-band AP. The UniFi may be doing > something that the driver is not expecting. I've had issues with

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Larry Finger
On 01/28/2016 05:01 PM, Linus Torvalds wrote: On Thu, Jan 28, 2016 at 2:12 PM, Johannes Berg wrote: Your best workaround may just be to ignore VHT for now - clearly it's broken so using "just" HT (which is likely not that much of a penalty anyway since you're

WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-27 Thread Linus Torvalds
Hmm. So my daughter has a little Gigabyte Brix that has rtl8821ae wireless in it. Yeah, nasty, I know, but it has actually worked reasonably well. .. except now I upgraded the nearest access point, and now wireless on that machine no longer works. Or rather, it actually *does* work in the sense