Re: gro: Make GRO aware of lightweight tunnels.

2016-02-10 Thread Jesse Gross
@davemloft.net> > > CommitDate: Wed Jan 20 18:48:38 2016 -0800 > > > > gro: Make GRO aware of lightweight tunnels. > > Coverity just started complaining about this commit. > > > diff --git a/include/net/dst_metadata.h b/include/net/dst_metadata.h > >

Re: gro: Make GRO aware of lightweight tunnels.

2016-02-08 Thread Dave Jones
:refs/heads/master > Author: Jesse Gross <je...@kernel.org> > AuthorDate: Wed Jan 20 17:59:49 2016 -0800 > Committer: David S. Miller <da...@davemloft.net> > CommitDate: Wed Jan 20 18:48:38 2016 -0800 > > gro: Make GRO aware of lightweight tunn

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread David Miller
From: Jesse Gross Date: Wed, 20 Jan 2016 17:59:49 -0800 > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: >> GRO is currently not aware of tunnel metadata generated by lightweight >> tunnels and stored in the dst. This leads to two possible problems: >> * Incorrectly

[PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
GRO is currently not aware of tunnel metadata generated by lightweight tunnels and stored in the dst. This leads to two possible problems: * Incorrectly merging two frames that have different metadata. * Leaking of allocated metadata from merged frames. This avoids those problems by comparing

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:47 -0800, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available.

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Thomas Graf
On 01/20/16 at 05:47pm, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available. However, GRO

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 6:31 PM, Thomas Graf wrote: > On 01/20/16 at 05:47pm, Jesse Gross wrote: >> Just to merge the two threads together, all of protocols that would be >> affected by this also have "normal" GRO handlers that will run when >> the packet is first received. There's

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Thomas Graf
On 01/20/16 at 05:59pm, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata from merged

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:59 -0800, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata

[PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
GRO is currently not aware of tunnel metadata generated by lightweight tunnels and stored in the dst. This leads to two possible problems: * Incorrectly merging two frames that have different metadata. * Leaking of allocated metadata from merged frames. This avoids those problems by comparing

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata