Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread David Miller
From: Dave Jones Date: Fri, 2 Sep 2016 14:39:50 -0400 > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Dave Jones
On Tue, Sep 06, 2016 at 10:52:43AM -0700, Eric Dumazet wrote: > > > @@ -126,8 +126,10 @@ static int ping_v6_sendmsg(struct sock *sk, struct > > > msghdr *msg, size_t len) > > > rt = (struct rt6_info *) dst; > > > > > > np = inet6_sk(sk); > > > -if (!np) > > > -

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 10:36 -0700, Martin KaFai Lau wrote: > On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > > Neither the failure or success paths of ping_v6_sendmsg release > > the dst it acquires. This leads to a flood of warnings from > > "net/core/dst.c:288 dst_release" on

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Martin KaFai Lau
On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

ipv6: release dst in ping_v6_sendmsg

2016-09-02 Thread Dave Jones
Neither the failure or success paths of ping_v6_sendmsg release the dst it acquires. This leads to a flood of warnings from "net/core/dst.c:288 dst_release" on older kernels that don't have 8bf4ada2e21378816b28205427ee6b0e1ca4c5f1 backported. That patch optimistically hoped this had been fixed