Re: mwifiex: Make mwifiex_dbg a function, reduce object size

2015-09-29 Thread Kalle Valo
> The mwifiex_dbg macro has two tests that could be consolidated > into a function reducing overall object size ~10KB (~4%). > > So convert the macro into a function. > > $ size drivers/net/wireless/mwifiex/built-in.o* (x86-64 defconfig) >text data bss dec hex filename

RE: [PATCH] mwifiex: Make mwifiex_dbg a function, reduce object size

2015-09-01 Thread David Laight
From: Joe Perches > Sent: 31 August 2015 18:47 > > The mwifiex_dbg macro has two tests that could be consolidated > into a function reducing overall object size ~10KB (~4%). > > So convert the macro into a function. This looks like it will slow things down somewhat. Maybe inline the tests and

Re: [PATCH] mwifiex: Make mwifiex_dbg a function, reduce object size

2015-09-01 Thread Joe Perches
On Tue, 2015-09-01 at 15:09 +, David Laight wrote: > From: Joe Perches > > Sent: 31 August 2015 18:47 > > > > The mwifiex_dbg macro has two tests that could be consolidated > > into a function reducing overall object size ~10KB (~4%). > > > > So convert the macro into a function. > > This

[PATCH] mwifiex: Make mwifiex_dbg a function, reduce object size

2015-08-31 Thread Joe Perches
The mwifiex_dbg macro has two tests that could be consolidated into a function reducing overall object size ~10KB (~4%). So convert the macro into a function. $ size drivers/net/wireless/mwifiex/built-in.o* (x86-64 defconfig) textdata bss dec hex filename 2331028628