Re: re iproute2 - don't return error on success fix

2018-10-09 Thread Or Gerlitz
On Mon, Oct 8, 2018 at 3:41 PM Phil Sutter wrote: > > $ ./tc/tc filter add dev enp33s0f0 protocol ip parent : flower > > skip_sw ip_flags firstfrag action drop && echo "success" || echo > > "failed" > > RTNETLINK answers: Operation not supported > > success > > Interestingly, your output

Re: re iproute2 - don't return error on success fix

2018-10-08 Thread Phil Sutter
Hi Or, On Tue, Oct 02, 2018 at 03:21:18PM +0300, Or Gerlitz wrote: > On Thu, Sep 27, 2018 at 3:53 PM Phil Sutter wrote: [...] > > Hmm, I can't reproduce this. My HEAD is at the commit you mentioned: > > > > | % sudo ./tc/tc filter add dev d0 protocol ip parent : flower skip_sw > > ip_flags

Re: re iproute2 - don't return error on success fix

2018-10-02 Thread Or Gerlitz
On Thu, Sep 27, 2018 at 3:53 PM Phil Sutter wrote: > On Thu, Sep 27, 2018 at 03:22:41PM +0300, Or Gerlitz wrote: > > Something is still broken also after commit b45e300 "libnetlink: don't > > return error on success" - when error is returned, the error code is > > success.. > > > > $ tc filter

Re: re iproute2 - don't return error on success fix

2018-09-28 Thread Or Gerlitz
On Thu, Sep 27, 2018 at 3:53 PM Phil Sutter wrote: > Hmm, I can't reproduce this. My HEAD is at the commit you mentioned: > > | % sudo ./tc/tc filter add dev d0 protocol ip parent : flower skip_sw > ip_flags nofirstfrag action drop > | RTNETLINK answers: Operation not supported > | We have

Re: re iproute2 - don't return error on success fix

2018-09-27 Thread Phil Sutter
Hi, On Thu, Sep 27, 2018 at 03:22:41PM +0300, Or Gerlitz wrote: > Something is still broken also after commit b45e300 "libnetlink: don't > return error on success" - when error is returned, the error code is > success.. > > $ tc filter add dev enp33s0f0 protocol ip parent : flower skip_sw >

Re: re iproute2 - don't return error on success fix

2018-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2018 15:22:41 +0300 Or Gerlitz wrote: > Something is still broken also after commit b45e300 "libnetlink: don't > return error on success" - when error is returned, the error code is > success.. > > $ tc filter add dev enp33s0f0 protocol ip parent : flower skip_sw > ip_flags

re iproute2 - don't return error on success fix

2018-09-27 Thread Or Gerlitz
Something is still broken also after commit b45e300 "libnetlink: don't return error on success" - when error is returned, the error code is success.. $ tc filter add dev enp33s0f0 protocol ip parent : flower skip_sw ip_flags nofirstfrag action drop && echo "success" || echo "failed"