Here is a corrected patch.
Signed-off-by: John Heffner [EMAIL PROTECTED]
-static u32 tcp_usrtt(const struct sk_buff *skb)
+static u32 tcp_usrtt(struct timeval *tv)
{
- struct timeval tv, now;
+ struct timeval now;
do_gettimeofday(now);
- skb_get_timestamp(skb, tv);
Sigh. Here's one that's not corrupted. And for the record:
This changes the microsecond RTT sampling so that samples are taken in
the same way that RTT samples are taken for the RTO calculator: on the
last segment acknowledged, and only when the segment hasn't been
retransmitted.
On Thu, 28 Sep 2006 13:47:28 +0100
John Heffner [EMAIL PROTECTED] wrote:
Sigh. Here's one that's not corrupted. And for the record:
This changes the microsecond RTT sampling so that samples are taken in
the same way that RTT samples are taken for the RTO calculator: on the
last
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 28 Sep 2006 09:36:50 -0700
On Thu, 28 Sep 2006 13:47:28 +0100
John Heffner [EMAIL PROTECTED] wrote:
Sigh. Here's one that's not corrupted. And for the record:
This changes the microsecond RTT sampling so that samples are taken
Okay, this patch is junk (never trust compile-tested code). Will send
something better soon.
-John
John Heffner wrote:
About commit 2d2abbab63f6726a147ae61ada39bf2c9ee0db9a:
It looks like this patch bypassed the enforcement of Karn's algorithm in
tcp_ack_no_tstamp() for the purposes of
Simplify the code that comuputes microsecond rtt estimate used
by TCP Vegas. Move the callback out of the RTT sampler and into
the end of the ack cleanup.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- net-2.6.orig/net/ipv4/tcp_input.c
+++ net-2.6/net/ipv4/tcp_input.c
@@ -548,10 +548,9
From: [EMAIL PROTECTED]
Date: Thu, 10 Nov 2005 15:15:09 -0800
Simplify the code that comuputes microsecond rtt estimate used
by TCP Vegas. Move the callback out of the RTT sampler and into
the end of the ack cleanup.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Nice cleanup, applied.
