Re: tg3 timeouts with 2.6.17-rc6
On Fri, 2006-06-16 at 20:37 -0700, Michael Chan wrote: David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Fri, 16 Jun 2006 18:27:32 -0700 In the meantime, I wonder if we should disable TSO by default on the 5780 chip for 2.6.17. Sounds reasonable. Would we disable it for all chips that set TG3_FLG2_5780_CLASS or a specific variant? Yes, let's disable it for all TG3_FLG2_5780_CLASS chips for now until we figure out what's going on. David, Here's the patch if you haven't already made one: [TG3]: Disable TSO by default on 5780 class chips. Disable TSO by default on 5780, 5714, and 5715 chips for now while we investigate the reported tx timeouts by Juergen Kreileder. Thanks to Juergen for reporting the problem. Update version to 3.60. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 862c226..607d87e 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -69,8 +69,8 @@ #define DRV_MODULE_NAMEtg3 #define PFX DRV_MODULE_NAME: -#define DRV_MODULE_VERSION 3.59 -#define DRV_MODULE_RELDATE June 8, 2006 +#define DRV_MODULE_VERSION 3.60 +#define DRV_MODULE_RELDATE June 17, 2006 #define TG3_DEF_MAC_MODE 0 #define TG3_DEF_RX_MODE0 @@ -11385,7 +11385,11 @@ static int __devinit tg3_init_one(struct * Firmware TSO on older chips gives lower performance, so it * is off by default, but can be enabled using ethtool. */ - if (tp-tg3_flags2 TG3_FLG2_HW_TSO) + /* Disable TSO by default on all 5780 class chips because +* of reported tx timeouts. +*/ + if ((tp-tg3_flags2 TG3_FLG2_HW_TSO) + !(tp-tg3_flags2 TG3_FLG2_5780_CLASS)) dev-features |= NETIF_F_TSO; #endif - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
From: Michael Chan [EMAIL PROTECTED] Date: Sat, 17 Jun 2006 11:23:28 -0700 David, Here's the patch if you haven't already made one: [TG3]: Disable TSO by default on 5780 class chips. Sorry, I didn't get a chance to push this into 2.6.17 in time. I will push it into the first 2.6.17.x -stable release. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
tg3 timeouts with 2.6.17-rc6
Hi, I'm seeing frequent network timeouts on my PowerMac G5 Quad with 2.6.17-rc6. The timeouts are easily reproducible with moderate network traffic, e.g. by using bittorrent. , | NETDEV WATCHDOG: lan0: transmit timed out | tg3: lan0: transmit timed out, resetting | tg3: tg3_stop_block timed out, ofs=2c00 enable_bit=2 | tg3: tg3_stop_block timed out, ofs=1400 enable_bit=2 | tg3: lan0: Link is down. | [...] | tg3: lan0: Link is up at 1000 Mbps, full duplex. | tg3: lan0: Flow control is on for TX and on for RX. ` Juergen -- Juergen Kreileder, Blackdown Java-Linux Team http://blog.blackdown.de/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
Juergen Kreileder I'm seeing frequent network timeouts on my PowerMac G5 Quad with 2.6.17-rc6. The timeouts are easily reproducible with moderate network traffic, e.g. by using bittorrent. Did this use to work with an older kernel or older tg3 driver? If yes, what version? Please also provide the full tg3 probing output during modprobe and ifconfig up. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
Michael Chan [EMAIL PROTECTED] writes: Juergen Kreileder I'm seeing frequent network timeouts on my PowerMac G5 Quad with 2.6.17-rc6. The timeouts are easily reproducible with moderate network traffic, e.g. by using bittorrent. Did this use to work with an older kernel or older tg3 driver? If yes, what version? Works fine with 2.6.16 and earlier. Please also provide the full tg3 probing output during modprobe and ifconfig up. Thanks. , | tg3.c:v3.58 (May 22, 2006) | eth0: Tigon3 [partno(BCM95780) rev 8003 PHY(5780)] (PCIX:133MHz:64-bit) 10/100/1000BaseT Ethernet 00:14:51:66:ff:b2 | eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[1] | eth0: dma_rwctrl[76144000] dma_mask[40-bit] | eth1: Tigon3 [partno(BCM95780) rev 8003 PHY(5780)] (PCIX:133MHz:64-bit) 10/100/1000BaseT Ethernet 00:14:51:66:ff:b3 | eth1: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[1] | eth1: dma_rwctrl[76144000] dma_mask[40-bit] | [...] | tg3: lan0: Link is up at 1000 Mbps, full duplex. | tg3: lan0: Flow control is on for TX and on for RX. ` eth0 and eth1 get renamed to lan0 and lan1 by udev. eth0/lan0 is connected to a Gigabit switch eth1/lan1 is not connected. Both interface are controlled by ifplugd (using SIOCETHTOOL for link beat detection). Let me know if you need more debugging output. Juergen -- Juergen Kreileder, Blackdown Java-Linux Team http://blog.blackdown.de/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
Michael Chan [EMAIL PROTECTED] writes: On Fri, 2006-06-16 at 23:20 +0200, Juergen Kreileder wrote: Michael Chan [EMAIL PROTECTED] writes: Did this use to work with an older kernel or older tg3 driver? If yes, what version? Works fine with 2.6.16 and earlier. Please also provide the full tg3 probing output during modprobe and ifconfig up. Thanks. Looking at the patch history since 2.6.16, the only patch that could have an impact is the one that enables TSO by default. Please try turning TSO off to see if it makes a difference: ethtool -K eth0 tso off Seems to work fine with TSO disabled. Juergen -- Juergen Kreileder, Blackdown Java-Linux Team http://blog.blackdown.de/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
On Sat, 2006-06-17 at 02:05 +0200, Juergen Kreileder wrote: Michael Chan [EMAIL PROTECTED] writes: Please try turning TSO off to see if it makes a difference: ethtool -K eth0 tso off Seems to work fine with TSO disabled. Thanks for the information. We'll look into it. If possible, please send me (using private email) an ethereal trace of a sample of the packets sent by the tg3 chip right before the NETDEV_WATCHDOG timeout. In the meantime, I wonder if we should disable TSO by default on the 5780 chip for 2.6.17. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 16 Jun 2006 18:27:32 -0700 In the meantime, I wonder if we should disable TSO by default on the 5780 chip for 2.6.17. Sounds reasonable. Would we disable it for all chips that set TG3_FLG2_5780_CLASS or a specific variant? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 timeouts with 2.6.17-rc6
David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Fri, 16 Jun 2006 18:27:32 -0700 In the meantime, I wonder if we should disable TSO by default on the 5780 chip for 2.6.17. Sounds reasonable. Would we disable it for all chips that set TG3_FLG2_5780_CLASS or a specific variant? Yes, let's disable it for all TG3_FLG2_5780_CLASS chips for now until we figure out what's going on. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
