Re: netdev broken?

2015-06-25 Thread Phil Sutter
On Thu, Jun 25, 2015 at 07:12:07AM -0400, Jamal Hadi Salim wrote: Trying to catchup with email and i am noticing my last received email was on the 21st. Anyone else having problems (feel like i am asking the question if you cant hear me please raise your hand ;-). I received your mail. If you

[PATCH v2] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-24 Thread Phil Sutter
for iproute2 to enable the additional information in 'ss -e'. Signed-off-by: Phil Sutter p...@nwl.cc --- Changes since v1: - Commit message corrected. - Patch based on current net-next.git. - Eric's superior solution implemented. --- include/uapi/linux/inet_diag.h | 3 ++- net/ipv4/inet_diag.c

[PATCH iproute2] ss: print value of IPV6_V6ONLY socket option if set

2015-06-24 Thread Phil Sutter
If available and set, print 'v6only:1' for AF_INET6 sockets upon request of extended information. For IPv6 sockets bound to in6addr_any, this is the only way to determine if they will also accept IPv4 requests or not. Signed-off-by: Phil Sutter p...@nwl.cc --- Depends on unapplied patch 'ss

[PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-19 Thread Phil Sutter
For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is exported to userspace. It indicates whether an unbound socket listens on IPv4 as well as IPv6. Since the socket is natively IPv6, it is not listed by e.g. 'netstat -l -4'. Signed-off-by: Phil Sutter p...@nwl.cc --- This patch

Re: [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-20 Thread Phil Sutter
On Fri, Jun 19, 2015 at 06:52:00AM -0700, Eric Dumazet wrote: On Fri, 2015-06-19 at 14:15 +0200, Phil Sutter wrote: For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is exported to userspace. It indicates whether an unbound socket listens on IPv4 as well as IPv6. What

Re: netstat and dual stack sockets

2015-06-15 Thread Phil Sutter
HGN! On Mon, Jun 15, 2015 at 11:36:54PM +0200, Hagen Paul Pfeifer wrote: On 15 June 2015 at 22:54, Phil Sutter p...@nwl.cc wrote: As I see it, a user has no way of detecting the listening socket in this address family: it does not show in /proc/net/{tcp,udp} nor do 'netstat', 'ss

netstat and dual stack sockets

2015-06-15 Thread Phil Sutter
Hi, A socket listening on any AF_INET6 address will receive IPv4 traffic as well, as long as it does not set IPV6_V6ONLY (or sysctl net.ipv6.bindv6only is set). Apache APR e.g. explicitly disables IPV6_V6ONLY for listening sockets. As I see it, a user has no way of detecting the listening socket

[PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
not explicitly tested. Fixes: eddee5ba (rhashtable: Fix walker behaviour during rehash) Signed-off-by: Phil Sutter p...@nwl.cc --- lib/rhashtable.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a60a6d3..e36b94b 100644 --- a/lib

[PATCH v2] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
not explicitly tested. Fixes: eddee5ba (rhashtable: Fix walker behaviour during rehash) Signed-off-by: Phil Sutter p...@nwl.cc --- Changes since v1: - Use simplified solution suggested by Herbert Xu. --- lib/rhashtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib

Re: [PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
On Mon, Jul 06, 2015 at 09:30:40PM +0800, Herbert Xu wrote: On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote: diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a60a6d3..e36b94b 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -585,6 +585,7 @@ void

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-12 Thread Phil Sutter
On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: On Tue, Aug 11, 2015 at 06:23:35PM +0200, Phil Sutter wrote: I have an unfinished solution in the oven, but being kept busy with other things for now. The action plan is as follows: 1) Introduce IFF_NO_QUEUE

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-13 Thread Phil Sutter
On Thu, Aug 13, 2015 at 03:10:33PM +0200, Jesper Dangaard Brouer wrote: On Thu, 13 Aug 2015 03:13:40 +0200 Phil Sutter p...@nwl.cc wrote: On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: In general 'changing the default' may be an acceptable thing

[PATCH 05/21] net: nlmon: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Daniel Borkmann dbork...@redhat.com --- drivers/net/nlmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c index 34924df..7b7c70e 100644 --- a/drivers/net/nlmon.c +++ b/drivers/net/nlmon.c

[PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards

2015-08-18 Thread Phil Sutter
This series converts in-tree users away from the old and deprecated 'tx_queue_len = 0' idiom, adds a warning to notify out-of-tree driver maintainers that there is need for action on their behalf and finally drops any workarounds in scheduling algorithm implementations. Phil Sutter (21): net

[PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-18 Thread Phil Sutter
get a chance to adjust their code before we finally get rid of any special handling of tx_queue_len == 0. Signed-off-by: Phil Sutter p...@nwl.cc --- net/core/dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 4870c35..b1f3f48 100644 --- a/net/core

[PATCH 09/21] net: bridge: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Stephen Hemminger step...@networkplumber.org --- net/bridge/br_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 0aa8f5c..6ed2feb 100644 --- a/net/bridge/br_device.c +++ b

[PATCH 12/21] net: ipvlan: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Mahesh Bandewar mahe...@google.com --- drivers/net/ipvlan/ipvlan_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 20b58bd..a9268db 100644 --- a/drivers

[PATCH 11/21] net: bonding: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jay Vosburgh j.vosbu...@gmail.com Cc: Veaceslav Falico vfal...@gmail.com Cc: Andy Gospodarek go...@cumulusnetworks.com --- drivers/net/bonding/bond_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding

[PATCH 14/21] net: hostap: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jouni Malinen j...@w1.fi --- drivers/net/wireless/hostap/hostap_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/hostap/hostap_main.c b/drivers/net/wireless/hostap/hostap_main.c index 01de1a3..80d4228

[PATCH 06/21] net: team: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jiri Pirko j...@resnulli.us --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index daa054b..651d35e 100644 --- a/drivers/net/team/team.c +++ b/drivers/net

[PATCH 04/21] net: loopback: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- drivers/net/loopback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index c76283c..dc7d970 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -165,10 +165,9

[PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johannes Berg johan...@sipsolutions.net --- drivers/net/wireless/mac80211_hwsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 99e873d..a1dbcb2

[PATCH 03/21] net: geneve: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: John W. Linville linvi...@tuxdriver.com --- drivers/net/geneve.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 78d49d1..897e1a3 100644 --- a/drivers/net/geneve.c +++ b/drivers/net

Re: [PATCH] net: rtnetlink: be more strict when setting MAC address

2015-08-17 Thread Phil Sutter
On Mon, Aug 17, 2015 at 02:09:33PM -0700, David Miller wrote: From: Phil Sutter p...@nwl.cc Date: Mon, 17 Aug 2015 23:06:47 +0200 Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure the passed argument length matches dev-addr_len exactly. This fixes dubious

[PATCH 16/21] net: batman-adv: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Marek Lindner mareklind...@neomailbox.ch Cc: Simon Wunderlich s...@simonwunderlich.de Cc: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/soft

[PATCH 18/21] net: caif: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Dmitry Tarnyagin dmitry.tarnya...@lockless.no --- drivers/net/caif/caif_hsi.c| 2 +- drivers/net/caif/caif_serial.c | 2 +- drivers/net/caif/caif_spi.c| 2 +- drivers/net/wan/hdlc_fr.c | 2 +- net/caif/caif_dev.c| 2 +- 5 files

[PATCH 01/21] net: veth: enable noqueue operation by default

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Pavel Emelyanov xe...@openvz.org --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 343592c..0ef4a5a 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -306,6 +306,7 @@ static

[PATCH 02/21] net: dummy: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- drivers/net/dummy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index 49adbf1..815eb94 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c @@ -144,10 +144,9 @@ static void

[PATCH 08/21] net: 8021q: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Patrick McHardy ka...@trash.net --- net/8021q/vlan_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 01d7ba8..fded865 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c

[PATCH 13/21] net: dsa: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Lennert Buytenhek buyt...@wantstofly.org --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 373ff31..cce9738 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1147,7

[PATCH 19/21] staging: wilc1000: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johnny Kim johnny@atmel.com Cc: Rachel Kim rachel@atmel.com Cc: Dean Lee dean@atmel.com Cc: Chris Park chris.p...@atmel.com --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 21/21] net: sched: drop all special handling of tx_queue_len == 0

2015-08-18 Thread Phil Sutter
-by: Phil Sutter p...@nwl.cc Cc: Jamal Hadi Salim j...@mojatatu.com --- net/sched/sch_fifo.c | 2 +- net/sched/sch_gred.c | 8 +++- net/sched/sch_htb.c | 6 ++ net/sched/sch_plug.c | 8 ++-- net/sched/sch_sfb.c | 2 +- 5 files changed, 9 insertions(+), 17 deletions(-) diff --git

[PATCH 17/21] net: hsr: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Arvid Brodin arvid.bro...@alten.se --- net/hsr/hsr_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index 44d2746..35a9788 100644 --- a/net/hsr/hsr_device.c +++ b/net/hsr

[PATCH 10/21] net: 6lowpan: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Alexander Aring alex.ar...@gmail.com --- net/ieee802154/6lowpan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c index f20a387..d7fb995 100644 --- a/net/ieee802154

[PATCH 07/21] net: vxlan: convert to using IFF_NO_QUEUE

2015-08-18 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc Cc: Stephen Hemminger step...@networkplumber.org --- drivers/net/vxlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 06c0731..ad51dac 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-18 Thread Phil Sutter
On Tue, Aug 18, 2015 at 07:47:28AM -0700, Eric Dumazet wrote: On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: Due to the introduction of IFF_NO_QUEUE, there is a better way for drivers to indicate that no qdisc should be attached by default. Though, the old convention can't be dropped

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
Hi, On Tue, Aug 18, 2015 at 07:47:28AM -0700, Eric Dumazet wrote: On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: Due to the introduction of IFF_NO_QUEUE, there is a better way for drivers to indicate that no qdisc should be attached by default. Though, the old convention can't

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote: [...] I'll start implementing the above immediately, but would appreciate to hear your comments on it meanwhile. I wonder especially what makes the difference between pfifo and pfifo_fast and why the latter can't be selected

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 01:33:40PM -0700, Eric Dumazet wrote: On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: lpaa5:~# tc qd sh dev eth1 qdisc mq 0: root qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum

[net-next PATCH 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-21 Thread Phil Sutter
. It could be worked around by droping the extra check for noqueue in transition_one_qdisc(), maybe with unintended side-effects. Signed-off-by: Phil Sutter p...@nwl.cc --- net/sched/sch_api.c | 2 +- net/sched/sch_generic.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[net-next PATCH 1/3] net: sched: make noqueue_qdisc non-static

2015-08-21 Thread Phil Sutter
This needs to be referenced from within net/sched/sched_api.c later. Signed-off-by: Phil Sutter p...@nwl.cc --- include/net/sch_generic.h | 1 + net/sched/sch_generic.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h

[net-next PATCH 0/3] net: sched: allow switching qdisc to noqueue intuitively

2015-08-21 Thread Phil Sutter
, the kernel won't fall back to the default but to noqueue instead. Phil Sutter (3): net: sched: make noqueue_qdisc non-static net: sched: allocate a handle to default qdiscs net: sched: fall back to noqueue when removing root qdisc include/net/sch_generic.h | 2 ++ net/sched/sch_api.c

[net-next PATCH 2/3] net: sched: allocate a handle to default qdiscs

2015-08-21 Thread Phil Sutter
Since tc_get_qdisc() does not allow to remove a qdisc with zero handle, a handle needs to be allocated to default qdiscs (currently pfifo_fast or mq) in order to allow removing them. Signed-off-by: Phil Sutter p...@nwl.cc --- include/net/sch_generic.h | 1 + net/sched/sch_api.c | 3

Re: [net-next PATCH 2/3] net: sched: allocate a handle to default qdiscs

2015-08-21 Thread Phil Sutter
On Fri, Aug 21, 2015 at 09:14:58AM -0700, Eric Dumazet wrote: [...] diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 1fb65f9..ab614ee 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -634,6 +634,11 @@ struct Qdisc *qdisc_create_dflt(struct

[net-next PATCH v2 0/3] net: sched: allow switching qdisc to noqueue intuitively

2015-08-21 Thread Phil Sutter
, the kernel won't fall back to the default but to noqueue instead. Changes since v1: - Leave qdisc_create_dflt() alone as it is used in sch_htb.c as well. Instead allocate the handle in attach_default_qdiscs() and attach_one_default_qdisc(). Phil Sutter (3): net: sched: make noqueue_qdisc non

[net-next PATCH v2 1/3] net: sched: make noqueue_qdisc non-static

2015-08-21 Thread Phil Sutter
This needs to be referenced from within net/sched/sched_api.c later. Signed-off-by: Phil Sutter p...@nwl.cc --- include/net/sch_generic.h | 1 + net/sched/sch_generic.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h

[net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-21 Thread Phil Sutter
. It could be worked around by droping the extra check for noqueue in transition_one_qdisc(), maybe with unintended side-effects. Signed-off-by: Phil Sutter p...@nwl.cc --- net/sched/sch_api.c | 2 +- net/sched/sch_generic.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[net-next PATCH v2 2/3] net: sched: allocate a handle to default qdiscs

2015-08-21 Thread Phil Sutter
Since tc_get_qdisc() does not allow to remove a qdisc with zero handle, a handle needs to be allocated to default qdiscs (currently pfifo_fast or mq) in order to allow removing them. Signed-off-by: Phil Sutter p...@nwl.cc --- include/net/sch_generic.h | 1 + net/sched/sch_api.c | 3

[iproute PATCH] lib/namespace: fix fd leakage in non-error case

2015-08-18 Thread Phil Sutter
be dropped, and the fd leak in non-error case is fixed as well. Fixes: 5950ba9 (lib/namespace: don't leak fd in error case) Signed-off-by: Phil Sutter p...@nwl.cc --- lib/namespace.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/namespace.c b/lib

[iproute PATCH] ip-address.8.in: fix BNF syntax error

2015-08-18 Thread Phil Sutter
The previous man page fixup introduced a syntax error due to missing opening bracket, which might crash some humanoid BNF parsers. Fixes: 4e972d5 (ip-address: fix and extend documentation) Signed-off-by: Phil Sutter p...@nwl.cc --- man/man8/ip-address.8.in | 2 +- 1 file changed, 1 insertion

Re: [PATCH] rhashtable-test: extend to test concurrency

2015-08-16 Thread Phil Sutter
On Sun, Aug 16, 2015 at 08:12:35PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: After having tested insertion, lookup, table walk and removal, spawn a number of threads running operations on the same rhashtable. Each of them will: [..] + if (down_interruptible

[PATCH] net: rtnetlink: be more strict when setting MAC address

2015-08-17 Thread Phil Sutter
and the kernel sets eth0's MAC address to the leading six octets of the passed argument. Signed-off-by: Phil Sutter p...@nwl.cc --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 788ceed..1d61cd1 100644

[net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -48,6 +48,18 @@ config

[net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces

2015-07-29 Thread Phil Sutter
Dangaard Brouer (1): veth: don't assign a qdisc to veth Phil Sutter (2): net: make default tx_queue_len configurable net: sched: set tx_queue_len to default when changing noqueue device's qdisc drivers/net/veth.c | 1 + net/Kconfig | 12 net/ethernet/eth.c | 2

[net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
. The drawback of this patch is that the noqueue state won't be restored after a user has removed the custom qdisc, as the information about whether this is legitimate for the given device is lost. Signed-off-by: Phil Sutter p...@nwl.cc --- net/sched/sch_api.c | 4 1 file changed, 4 insertions

[net-next PATCH 3/3] veth: don't assign a qdisc to veth

2015-07-29 Thread Phil Sutter
tx_queue_len to zero. Reported-by: Mrunal Patel mpa...@redhat.com Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com Signed-off-by: Phil Sutter p...@nwl.cc --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index c8186ff..6b3d822 100644

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: Phil Sutter p...@nwl.cc wrote: [...] +config DEFAULT_TX_QUEUE_LEN + prompt Default TX queue length (in packets) if EXPERT + int + default 1000# Ethernet wants good queues + help + Set the default value

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:10:45PM +0200, Eric Dumazet wrote: On Wed, 2015-07-29 at 22:51 +0200, Phil Sutter wrote: [...] diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index f06aa01..79b8900 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1315,6 +1315,10 @@ graft

[iproute PATCH] misc/ss: don't imply -a when -A was specified

2015-08-07 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- misc/ss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/misc/ss.c b/misc/ss.c index bba7009..2f34962 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3669,6 +3669,8 @@ int main(int argc, char *argv[]) char *p, *p1

[PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client

2015-08-09 Thread Phil Sutter
This is the identical fix as netfilter: ipt_SYNPROXY: fix sending window update to client but for the IPv6 variant which obviously suffers from the same issue. Signed-off-by: Phil Sutter p...@nwl.cc --- Changes since v1: - Adjust for v2 changes of first patch. --- net/ipv6/netfilter

[PATCH v2 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference

2015-08-09 Thread Phil Sutter
This happens when networking namespaces are enabled. Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Phil Sutter p...@nwl.cc --- Changes since v1: - Moved snet param to first place. - Constify snet param. --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 18 ++ 1 file changed

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-11 Thread Phil Sutter
On Tue, Aug 11, 2015 at 05:48:07PM +0200, Jesper Dangaard Brouer wrote: On Wed, 29 Jul 2015 14:37:31 -0700 (PDT) David Miller da...@davemloft.net wrote: [...] Which is that there are devices (virtual or whatever) which don't want a qdisc attached no matter what. Flag those devices as

[iproute PATCH] ip-link: fix minor typo in manpage

2015-08-11 Thread Phil Sutter
Change '-human-readble' to '-human-readable'. Signed-off-by: Phil Sutter p...@nwl.cc --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index c123fcc..1c312af 100644 --- a/man/man8/ip-link.8.in +++ b/man

[PATCH 2/6] misc/ss: avoid NULL pointer dereference

2015-08-06 Thread Phil Sutter
This was working before, but only if realloc a) succeeded and b) did not move the buffer to a different location. ''**buf = **new_buf' then writes the value of *new_buf's first field into that of *buf. Signed-off-by: Phil Sutter p...@nwl.cc --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 5/6] lib/namespace: don't leak fd in error case

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- lib/namespace.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/namespace.c b/lib/namespace.c index a61feb6..8197165 100644 --- a/lib/namespace.c +++ b/lib/namespace.c @@ -58,32 +58,35 @@ int netns_switch(char *name

[PATCH 1/6] ip/ipnetns: prevent potential string buffer overflow

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- ip/ipnetns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 3b704a4..32b0f51 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -178,7 +178,8 @@ static int netns_map_add(int nsid, char *name

[PATCH 4/6] misc/ss: add missing fclose() calls

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- misc/ss.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index e77655a..0c7c6d7 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3025,6 +3025,7 @@ static int packet_show_line(char *buf, const struct filter *f

[PATCH 6/6] misc/ss: fix memory leak in user_ent_hash_build()

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- misc/ss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 0c7c6d7..bba7009 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -483,8 +483,10 @@ static void user_ent_hash_build(void) sprintf(name

[PATCH 3/6] misc/ss: simplify buffer realloc, fix checking realloc failure

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter p...@nwl.cc --- misc/ss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index af5a3c2..e77655a 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -550,7 +550,7 @@ static int find_entry(unsigned ino, char **buf, int type

[PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference

2015-08-06 Thread Phil Sutter
This happens when networking namespaces are enabled. Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Phil Sutter p...@nwl.cc --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/ipv6/netfilter

[PATCH 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client

2015-08-06 Thread Phil Sutter
This is the identical fix as netfilter: ipt_SYNPROXY: fix sending window update to client but for the IPv6 variant which obviously suffers from the same issue. Signed-off-by: Phil Sutter p...@nwl.cc --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 2/2] net: sch_generic: react upon IFF_NO_QUEUE flag

2015-08-13 Thread Phil Sutter
Handle IFF_NO_QUEUE as alternative to tx_queue_len being zero. Signed-off-by: Phil Sutter p...@nwl.cc --- net/sched/sch_generic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 6efca30..942fea8 100644 --- a/net

[PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Phil Sutter
in qdiscs and caveats in userspace unnecessary. Upon upstream acceptance, this series will be followed up by a set of patches converting device drivers, adding a warning so out-of-tree driver authors get aware of this change and dropping all special handling of tx_queue_len in net/sched/. Phil Sutter

[PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE

2015-08-13 Thread Phil Sutter
This private net_device flag can be set by drivers to inform that a device runs fine without a qdisc attached. This was formerly done by setting tx_queue_len to zero. Signed-off-by: Phil Sutter p...@nwl.cc --- include/linux/netdevice.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-14 Thread Phil Sutter
On Thu, Aug 13, 2015 at 12:11:57PM -0700, Stephen Hemminger wrote: On Thu, 13 Aug 2015 20:40:37 +0200 Jesper Dangaard Brouer bro...@redhat.com wrote: On Thu, 13 Aug 2015 10:49:50 -0700 Stephen Hemminger step...@networkplumber.org wrote: On Thu, 13 Aug 2015 19:01:05 +0200 Phil

[PATCH] rhashtable-test: extend to test concurrency

2015-08-14 Thread Phil Sutter
a second on my local VM with two cores. Running 200 threads took about four seconds. If slow systems suffer too much from this though, the default could be lowered or even set to zero so this extended test does not run at all by default. Signed-off-by: Phil Sutter p...@nwl.cc --- lib

ip6t_SYNPROXY crashes kernel

2015-07-27 Thread Phil Sutter
Hi, When synproxy_send_server_ack() calls synproxy_send_tcp(), it passes NULL as third parameter (struct nf_conntrack *nfct). And the first thing synproxy_send_tcp() does, is dereference it: | struct net *net = nf_ct_net((struct nf_conn *)nfct); I could not find a commit leading to this

[PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client

2015-07-27 Thread Phil Sutter
). Signed-off-by: Phil Sutter p...@nwl.cc --- net/ipv4/netfilter/ipt_SYNPROXY.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ipt_SYNPROXY.c b/net/ipv4/netfilter/ipt_SYNPROXY.c index fe8cc18..95ea633e 100644 --- a/net/ipv4/netfilter/ipt_SYNPROXY.c +++ b/net

Re: Sending IPv6 packets broken in net-next

2015-07-16 Thread Phil Sutter
On Thu, Jul 16, 2015 at 12:20:46AM +0200, Phil Sutter wrote: Commit 9131f3d (ipv6: Do not iterate over all interfaces when finding source address on specific interface) breaks local output of IPv6 packets. Here is a simple reproducer: I just noticed, a patch fixing the issue has already been

[PATCH net-next] net/ipv6: update flowi6_oif in ip6_dst_lookup_flow if not set

2015-07-15 Thread Phil Sutter
e.g. ip6_datagram_connect(), rawv6_sendmsg() or tcp_v6_connect(). (UDP was not tested for.) In summary, this patch fixes policy matching on outgoing interface for locally generated packets. Signed-off-by: Phil Sutter p...@nwl.cc --- net/ipv6/ip6_output.c | 2 ++ 1 file changed, 2 insertions

Sending IPv6 packets broken in net-next

2015-07-15 Thread Phil Sutter
Hi, Commit 9131f3d (ipv6: Do not iterate over all interfaces when finding source address on specific interface) breaks local output of IPv6 packets. Here is a simple reproducer: 8 - ip link add eth6 type veth peer name eth7 ip netns add test ip link set eth7 netns test ip netns exec

Re: 4.1 regression in resizable hashtable tests

2015-07-17 Thread Phil Sutter
mismatch ^^^ I do see count mismatches as well due to the design of the walker which restarts and thus sees certain entries multiple times. Do you have this commit as well? Author: Phil Sutter p...@nwl.cc Date: Mon Jul 6 15:51:20 2015 +0200 rhashtable: fix for resize events during

Re: 4.1 regression in resizable hashtable tests

2015-07-17 Thread Phil Sutter
On Fri, Jul 17, 2015 at 12:26:36PM +0200, Phil Sutter wrote: On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote: On 07/02/15 at 10:09pm, Meelis Roos wrote: [ 33.425061] Running rhashtable test nelem=8, max_size=65536, shrinking=0 [ 33.425154] Test 00: [ 33.534470

[iproute RFC PATCH 1/9] tc: add a man page for basic filter

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf <tg...@suug.ch> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-basic.8 | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 man/man8/tc-basic.8 diff --git a/man/man8/tc-basic.8 b/man/man8/tc-basic.8 new file mode

[iproute RFC PATCH 3/9] tc: add a man page for flow filter

2015-10-23 Thread Phil Sutter
Cc: Patrick McHardy <ka...@trash.net> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-flow.8 | 265 + 1 file changed, 265 insertions(+) create mode 100644 man/man8/tc-flow.8 diff --git a/man/man8/tc-flow.8 b/man/man8/t

[iproute RFC PATCH 6/9] tc: add a man page for route filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-route.8 | 74 + 1 file changed, 74 insertions(+) create mode 100644 man/man8/tc-route.8 diff --git a/man/man8/tc-route.8 b/man/man

[iproute RFC PATCH 5/9] tc: add a man page for fw filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-fw.8 | 66 1 file changed, 66 insertions(+) create mode 100644 man/man8/tc-fw.8 diff --git a/man/man8/tc-fw.8 b/man/man8/tc-f

[iproute RFC PATCH 8/9] tc: add a man page for u32 filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-u32.8 | 663 ++ 1 file changed, 663 insertions(+) create mode 100644 man/man8/tc-u32.8 diff --git a/man/man8/tc-u32.8 b/man/man8/

[iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Phil Sutter
by explaining to me how that filter is supposed to work. In turn I could serve you with stupid^Wunqualified questions and ultimately tc-rsvp.8 which you would then have to proof-read as well. Phil Sutter (9): tc: add a man page for basic filter tc: add a man page for cgroup filter tc: add a man page

[iproute RFC PATCH 4/9] tc: add a man page for flower filter

2015-10-23 Thread Phil Sutter
Cc: Jiri Pirko <j...@resnulli.us> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-flower.8 | 113 +++ 1 file changed, 113 insertions(+) create mode 100644 man/man8/tc-flower.8 diff --git a/man/man8/tc-flower.8 b/man/man8/tc-

[iproute RFC PATCH 7/9] tc: add a man page for tcindex filter

2015-10-23 Thread Phil Sutter
Cc: Werner Almesberger <wer...@almesberger.net> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-tcindex.8 | 58 +++ 1 file changed, 58 insertions(+) create mode 100644 man/man8/tc-tcindex.8 diff --git a/man/man8/tc-tcindex.8 b

[iproute RFC PATCH 2/9] tc: add a man page for cgroup filter

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf <tg...@suug.ch> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-cgroup.8 | 80 1 file changed, 80 insertions(+) create mode 100644 man/man8/tc-cgroup.8 diff --git a/man/man8/tc-cgroup.8 b/man/man8/tc-cgrou

[iproute PATCH] tc: improve filter help texts a bit

2015-10-23 Thread Phil Sutter
This fixes a few syntax errors and changes route filter help text to use classid instead of flowid to be consistent with other filters' help texts. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/f_flower.c | 4 ++-- tc/f_route.c | 2 +- tc/f_rsvp.c | 2 +- 3 files changed, 4 insertions

[iproute PATCH] tc: u32 filter coding style cleanup

2015-10-23 Thread Phil Sutter
Add missing spaces around operators to increase readability. Aside from that, make "preference" match a real synonym for "tos" and "dsfield" as it's effect was identical to them. Signed-off-by: Phil Sutter <

[iproute RFC PATCH 9/9] tc: ship filter man pages and refer to them in tc.8

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf <tg...@suug.ch> Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Cc: Jiri Pirko <j...@resnulli.us> Cc: Patrick McHardy <ka...@trash.net> Cc: Werner Almesberger <wer...@almesberger.net> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/Makefi

Re: [PATCH v7 05/10] ss: replaced old output with new generic output mechanisms

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:03PM +0200, Matthias Tafelmeier wrote: > This patch just adds the -j and --json flag to ss. Also it ensures proper > stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. > > Moreover, this patch prevents human readable headers to be printed. >

Re: [PATCH v7 07/10] ss: symmetrical subhandler output extension example

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:05PM +0200, Matthias Tafelmeier wrote: > This small sized patch shall convey the locations which have to be > changed for a symmetrical output extension. Symmetrical means in this > context all existing semantically related handlers in the diverse > formatters (for hr

Re: [PATCH v7 08/10] ss: symmetrical formatter extension example

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:06PM +0200, Matthias Tafelmeier wrote: > This commit shall show shortly where to place changes when one wants to > extend an ss output formatter with a new handler (format print > procedure). The extension is done symmetrically. That means, every up to > now existing

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-27 Thread Phil Sutter
On Tue, Oct 27, 2015 at 06:47:53AM -0700, David Miller wrote: > > Please do not quote an entire large patch in a reply just to common on > one particular section of the change. > > Instead, trim it to just the necessary context. OK, I'll make sure to remember this. Better don't read my other

Re: [PATCH v7 06/10] ss: renaming and export of current_filter

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:04PM +0200, Matthias Tafelmeier wrote: > Exported current_filter as ss_current_filter, because in > the fmt handlers, I need that piece of info to resolve out issues of json. This patch should come before the patches using the new name. > Signed-off-by: Matthias

  1   2   3   4   5   6   7   8   9   10   >