Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-15 Thread Martin KaFai Lau
On Tue, Nov 14, 2017 at 01:59:03PM -0800, Shaohua Li wrote: > On Tue, Nov 14, 2017 at 11:13:10AM -0800, Tom Herbert wrote: > > On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote: > > > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote: > > >> On Fri, Aug 18, 2017 at

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-14 Thread Shaohua Li
On Tue, Nov 14, 2017 at 11:13:10AM -0800, Tom Herbert wrote: > On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote: > > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote: > >> On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote: > >> > From: Martin

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-14 Thread Tom Herbert
On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote: > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote: >> On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote: >> > From: Martin KaFai Lau >> > Date: Fri, 18 Aug 2017 13:51:36 -0700

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-14 Thread Shaohua Li
On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote: > On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote: > > From: Martin KaFai Lau > > Date: Fri, 18 Aug 2017 13:51:36 -0700 > > > >> It seems like that middle box specifically drops TCP_RST if it > >>

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-08 Thread Martin KaFai Lau
On Wed, Nov 08, 2017 at 12:01:53PM -0800, Tom Herbert wrote: > On Wed, Nov 8, 2017 at 9:44 AM, Tom Herbert wrote: > >> > > We're now seeing several router vendors recommending people to not use > > flow labels for ECMP hashing. This is precisely because when a flow > > label

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-08 Thread Tom Herbert
On Wed, Nov 8, 2017 at 9:44 AM, Tom Herbert wrote: > On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote: >> From: Martin KaFai Lau >> Date: Fri, 18 Aug 2017 13:51:36 -0700 >> >>> It seems like that middle box specifically drops TCP_RST

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-11-08 Thread Tom Herbert
On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote: > From: Martin KaFai Lau > Date: Fri, 18 Aug 2017 13:51:36 -0700 > >> It seems like that middle box specifically drops TCP_RST if it >> does not know anything about this flow. Since the flowlabel of the

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-18 Thread David Miller
From: Martin KaFai Lau Date: Fri, 18 Aug 2017 13:51:36 -0700 > It seems like that middle box specifically drops TCP_RST if it > does not know anything about this flow. Since the flowlabel of the TCP_RST > (sent in TW state) is always different, it always lands to a different

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-18 Thread Martin KaFai Lau
On Fri, Aug 18, 2017 at 07:50:03AM -0700, Tom Herbert wrote: > > We had been using the auto_flowlabels=1 (i.e. essentially enable flowlabel) > > mainly because we want to take the benefit of dst_negative_advice() when > > tcp_write_timeout() happens. > > > > During our test, our system handles

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-18 Thread Tom Herbert
> We had been using the auto_flowlabels=1 (i.e. essentially enable flowlabel) > mainly because we want to take the benefit of dst_negative_advice() when > tcp_write_timeout() happens. > > During our test, our system handles quite well with changing flowlabel. > The only exception we have hit is

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-17 Thread Martin KaFai Lau
On Tue, Aug 15, 2017 at 05:15:46PM -0700, Tom Herbert wrote: > On Tue, Aug 15, 2017 at 3:42 PM, Shaohua Li wrote: > > On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: > >> On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: > >> > On Fri, Aug 11, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-17 Thread Tom Herbert
On Thu, Aug 17, 2017 at 10:26 AM, Shaohua Li wrote: > On Tue, Aug 15, 2017 at 05:15:46PM -0700, Tom Herbert wrote: >> On Tue, Aug 15, 2017 at 3:42 PM, Shaohua Li wrote: >> > On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: >> >> On Mon, Aug 14, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-17 Thread Shaohua Li
On Tue, Aug 15, 2017 at 05:15:46PM -0700, Tom Herbert wrote: > On Tue, Aug 15, 2017 at 3:42 PM, Shaohua Li wrote: > > On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: > >> On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: > >> > On Fri, Aug 11, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-15 Thread Tom Herbert
On Tue, Aug 15, 2017 at 3:42 PM, Shaohua Li wrote: > On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: >> On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: >> > On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: >> >> On Thu, Aug 10, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-15 Thread Shaohua Li
On Tue, Aug 15, 2017 at 07:08:31AM -0700, Tom Herbert wrote: > On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: > > On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: > >> On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > >> > On Thu, Aug 10,

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-15 Thread Tom Herbert
On Mon, Aug 14, 2017 at 7:52 PM, Shaohua Li wrote: > On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: >> On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: >> > On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: >> >> On Thu, Aug 10, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-14 Thread Shaohua Li
On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: > On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > > On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: > >> On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > >> > On Wed, Aug 09,

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-11 Thread Tom Herbert
On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: >> On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: >> > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: >> >> On Mon, Jul 31, 2017

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-10 Thread Shaohua Li
On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: > On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: > >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > >> > From: Shaohua Li

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-10 Thread Tom Herbert
On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: >> > From: Shaohua Li >> > >> > Please see below tcpdump output: >> >

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-10 Thread Shaohua Li
On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: > On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > > From: Shaohua Li > > > > Please see below tcpdump output: > > 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) > > payload

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-09 Thread David Miller
From: Shaohua Li Date: Wed, 9 Aug 2017 07:59:53 -0700 > Could you please look at the patches? If you actually looked in patchwork, the state of your patches is "changes requested". This means that you were given feedback asking to change something about your patches, which

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-09 Thread Tom Herbert
On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > From: Shaohua Li > > Please see below tcpdump output: > 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: >

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-09 Thread Shaohua Li
On Mon, Jul 31, 2017 at 03:19:21PM -0700, Shaohua Li wrote: > From: Shaohua Li > > Please see below tcpdump output: > 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: > Flags