Hi Jiri,
I have just verified that this locking scheme is indeed correct. So you
can add
Signed-off-by: Jiri Kosina [EMAIL PROTECTED]
if you wish to, and submit the patch to Andrew.
I guess I don't get sent networking patches any more?
:-)
Well, this is
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 16 May 2007 14:57:00 -0700
Add more comments to describe our version of tcp_slow_start().
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied, thanks Stephen.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
From: Toralf Förster [EMAIL PROTECTED]
Date: Wed, 16 May 2007 22:18:44 +0200
net/built-in.o: In function `tcp_yeah_init':
tcp_yeah.c:(.text+0x526f8): undefined reference to `tcp_vegas_init'
net/built-in.o: In function `tcp_yeah_pkts_acked':
tcp_yeah.c:(.text+0x52756): undefined reference to
On Wed, 16 May 2007 13:54:43 +0800
Matthew Lee [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote:
hi Alan,
I just wondering why it could get 3 sockaddr_in(s) for eth0(status is up,
type EN10MB), others are down.
It was generated by findalldevstest.c in libpcap cvs repository, with some
On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote:
index 49be393..830d851 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)
E1000_WRITE_REG(adapter-hw, CTRL, ctrl);
}
The function ipxrtr_route_packet() takes a 'len' argument of type
size_t. However, its prototype in af_ipx.c incorrectly suggests that the
corresponding argument is of type 'int' instead.
Discovered by building with --combine and letting the compiler see it
all at once.
Signed-off-by: David
Julian Anastasov wrote:
If icmp_send is changed to use inet_addr_type() then ICMP will leave
with saddr != VIP and that is not nice.
...
I'm not familiar with the IPVS terms, but as far as I understand,
it is _not_ going to return RTN_LOCAL, so we get the desired
behaviour of selecting a local
Good Day!
There is a problem in fs_enet driver. When restart function is called
the multicast settings do not restore. This patch fixes this bug.
Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED]
---
diff -purN linux-2.6.21-clean/drivers/net/fs_enet/mac-fcc.c
On May 17, 2007, at 4:01 AM, Christoph Hellwig wrote:
On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote:
index 49be393..830d851 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)
hi All,
Resending the patches.
Regards,
Mithlesh Thukral
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
NetXen: Fix for driver on System-p
This patch will fix a ping issue on system-p
Signed-off by: Milan Bag [EMAIL PROTECTED]
Signed-off by: Adhiraj Joshi [EMAIL PROTECTED]
Signed-by: Mithlesh Thukral [EMAIL PROTECTED]
---
drivers/net/netxen/netxen_nic_init.c |2 +-
1 files changed, 1
NetXen: Changes related to registers and their access routines
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by:
On Tue, May 15, 2007 at 08:41:48PM +0900, Hirokazu Takahashi wrote:
@@ -924,7 +926,9 @@ cbq_dequeue_prio(struct Qdisc *sch, int
cl-xstats.borrows += skb-len;
#endif
}
- q-tx_len = skb-len;
+
Hi,
It was suggested on lkml that we move the non-VFS layers of the 9P2000
protocol from fs/9p to net/9p making 9p usable for things other than
the VFS subsystem.
Can you please pull the patchset from
git://git.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ and review and
ack/reject it.
Thanks,
Julian Anastasov wrote:
To summarize, what can help is a flag (eg. RT_ANYSRC) to
ip_route_output* that all special users can provide to skip the
check, for example:
- RTCF_LOCAL packets in icmp_send() can avoid the check
- NAT can avoid the check (ip_route_me_harder can be
Janusz Krzysztofik wrote:
Julian Anastasov wrote:
If icmp_send is changed to use inet_addr_type() then ICMP will leave
with saddr != VIP and that is not nice.
...
I'm not familiar with the IPVS terms, but as far as I understand,
it is _not_ going to return RTN_LOCAL, so we get the desired
Patrick McHardy wrote:
BUG: unable to handle kernel NULL pointer dereference at virtual address
00a8
[...]
EIP is at inet_select_addr+0x4/0x9f
Call Trace:
[f8b97046] reject+0x0/0x4ae [ipt_REJECT]
[c05fd0b6] icmp_send+0x14d/0x39b
A REJECT target in the output chain will trigger this in
Hello Hideaki, hello David,
since 2.6.21 the new case NETDEV_REGISTER has been added to the big
'switch' in addrconf_notify().
But within this case NETDEV_REGISTER-code no check about valid ipv6
networking hardware is done, as it is done in NETDEV_UP, NETDEV_CHANGE
and others.
Please
Sorry. I had a problem with my mailer that disrupted the patch ...
--
Hello Hideaki, hello David,
since 2.6.21 the new case NETDEV_REGISTER has been added to the big
'switch' in addrconf_notify().
But within this case NETDEV_REGISTER-code no check about valid ipv6
On Thu, 17 May 2007 06:59:21 -0700 [EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=8491
Summary: OOPS triggered by ip(8) deconfiguring a network
interface
Kernel Version: 2.6.22-rc1
Status: NEW
Severity: high
From: Hong Liu [EMAIL PROTECTED]
We forget to free all the fragments when defraging them into one packet.
Signed-off-by: Hong Liu [EMAIL PROTECTED]
Signed-off-by: John W. Linville [EMAIL PROTECTED]
---
net/mac80211/ieee80211.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
From: Zhu Yi [EMAIL PROTECTED]
Some APs have strict checking between associate and reassociate. In
a case when an AP is restarted during a connection, it denies the
mac80211 reassoc request since this is a new association for the AP.
To fix this problem, we need to check the status code against
On Thu, May 17, 2007 at 10:49:45AM +1000, Benjamin Herrenschmidt wrote:
I do not know why sk_buff-head would be null, or
would be set in a racy kind of way, or why the rt patches
would cause this. But the evidence implicates that.
Would it be possible that a locking bug in spidernet
In article [EMAIL PROTECTED] (at Thu, 17 May 2007 18:53:03 +0200), Oliver
Hartkopp [EMAIL PROTECTED] says:
+static int ipv6_hwtype(struct net_device *dev)
+{
+if ((dev-type == ARPHRD_ETHER) ||
+(dev-type == ARPHRD_LOOPBACK) ||
+#if defined(CONFIG_IPV6_SIT) ||
I tried building TCP YeAH into my kernel with TCP Vegas as a module and
the build failed because TCP YeAH depends on Vegas. This patch makes
Kconfig aware of the YeAH dependency on Vegas.
---
net/ipv4/Kconfig |1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/net/ipv4/Kconfig
Hello,
the build with the attached .config failed, make ends with:
...
AS arch/i386/lib/semaphore.o
CC arch/i386/lib/strstr.o
CC arch/i386/lib/usercopy.o
AR arch/i386/lib/lib.a
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC
Update ipconfig to enable users to specify multiple devices on the kernel
commandline
ip= option. This allows for up-to 4 devices to be specified, with devices
separated by
a '/' character. For example, to limit autoconfig requests to eth0 and eth2:
ip=:eth0/eth2:DHCP
This is
YOSHIFUJI Hideaki / 吉藤英明 schrieb:
In article [EMAIL PROTECTED] (at Thu, 17 May 2007 18:53:03 +0200), Oliver Hartkopp
[EMAIL PROTECTED] says:
+static int ipv6_hwtype(struct net_device *dev)
+{
+if ((dev-type == ARPHRD_ETHER) ||
+(dev-type == ARPHRD_LOOPBACK) ||
+#if
From: Toralf Förster [EMAIL PROTECTED]
Date: Thu, 17 May 2007 21:06:24 +0200
Hello,
the build with the attached .config failed, make ends with:
...
AS arch/i386/lib/semaphore.o
CC arch/i386/lib/strstr.o
CC arch/i386/lib/usercopy.o
AR arch/i386/lib/lib.a
From: Brandon Philips [EMAIL PROTECTED]
Date: Thu, 17 May 2007 11:54:29 -0700
I tried building TCP YeAH into my kernel with TCP Vegas as a module and
the build failed because TCP YeAH depends on Vegas. This patch makes
Kconfig aware of the YeAH dependency on Vegas.
I fixed this and posted
From: Patrick McHardy [EMAIL PROTECTED]
Date: Thu, 17 May 2007 18:40:28 +0200
In any case some better solution than the current one needs to be
found, allowing users to send spoofed packets is far worse than
using a non-desired source address for ICMP packets.
Agreed, but it only occurs if
Wen Xiong wrote:
Here there are not hardware issue on both Intel or PPC. The patch is to
work around a loop hold on early version of PCI SGI spec.
The later PCI Sgi have spec have corrected it. We can just implement it
for PPC only. Other vendor may have the same issue.
If it is not a
YOSHIFUJI Hideaki / 吉藤英明 wrote:
Please remove #if, or please provide for other
dependencies as well (e.g., CONFIG_IPV6_TUNNEL etc.)
Otherwise, I would agree.
Yep - you were right. It looks better like this as ARPHRD_SIT is defined
in if_arp.h in any CONFIG_* case ...
Best regards tnx,
Kok, Auke wrote:
Jeff Garzik wrote:
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c
b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int
Chuck Ebbert wrote:
Kok, Auke wrote:
Jeff Garzik wrote:
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c
b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int
On Thu, 2007-05-17 at 17:04 -0400, Jeff Garzik wrote:
Wen Xiong wrote:
Here there are not hardware issue on both Intel or PPC. The patch is to
work around a loop hold on early version of PCI SGI spec.
The later PCI Sgi have spec have corrected it. We can just implement it
for PPC
Kok, Auke wrote:
for now. If MSI is breaking with a 10gig adapter I think people
appreciate the error.
No, that is same invalid reasoning discussed earlier in this thread.
ixgb needs patching for this problem too.
Jeff
-
To unsubscribe from this list: send the line unsubscribe
As mentioned in http://bugzilla.kernel.org/show_bug.cgi?id=5015
The helptext implies that this is on by default.
This may be true on some distros (Fedora/RHEL have it enabled
in /etc/sysctl.conf), but the kernel defaults to it off.
Signed-off-by: Dave Jones [EMAIL PROTECTED]
diff --git
From: Dave Jones [EMAIL PROTECTED]
Date: Thu, 17 May 2007 17:58:19 -0400
As mentioned in http://bugzilla.kernel.org/show_bug.cgi?id=5015
The helptext implies that this is on by default.
This may be true on some distros (Fedora/RHEL have it enabled
in /etc/sysctl.conf), but the kernel defaults
Rolf Eike Beer [EMAIL PROTECTED] :
[R8169] Add endianess annotations to [RT]xDesc
Thanks, I queue it.
--
Ueimor
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik wrote:
Kok, Auke wrote:
for now. If MSI is breaking with a 10gig adapter I think people
appreciate the error.
No, that is same invalid reasoning discussed earlier in this thread.
ixgb needs patching for this problem too.
OK then... A patch that does the exact same for ixgb as
From: Auke Kok [EMAIL PROTECTED]
pci_enable_msi calls can fail for normal operational reasons. Driver
should not print an error message in that case. Fix a leak that leaves
msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI
ifdefs alltogether
Signed-off-by: Auke Kok [EMAIL
On Thu, 17 May 2007 18:48:12 +0800
David Woodhouse [EMAIL PROTECTED] wrote:
The function ipxrtr_route_packet() takes a 'len' argument of type
size_t. However, its prototype in af_ipx.c incorrectly suggests that the
corresponding argument is of type 'int' instead.
Discovered by building with
On Wed, May 16, 2007 at 05:41:01PM -0700, David Miller wrote:
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Wed, 16 May 2007 19:18:02 -0500
Since this is a long email; let me put a summary up front:
I think the RT/premption patches are exposing some sort
of race in the ip header handling
This patch modifies TIPC's socket API to utilize existing
generic routines to indicate unsupported operations, rather
than adding similar TIPC-specific routines.
Signed-off-by: Allan Stephens [EMAIL PROTECTED]
Signed-off-by: Jon Paul Maloy [EMAIL PROTECTED]
---
net/tipc/socket.c | 55
This patch simplifies TIPC's Ethernet receive routine to take
advantage of information already present in each incoming sk_buff
indicating whether the packet was explicitly sent to the interface,
has been broadcast to all interfaces, or was picked up because the
interface is in promiscous mode.
This patch enhances TIPC's stream socket send routine so that
it avoids transmitting data in chunks that require fragmentation
and reassembly, thereby improving performance at both the
sending and receiving ends of the connection.
The maximum packet size hint that records MTU info allows
the
Stephen Hemminger wrote:
The problems with Gigabyte motherboards are system configuration dependent.
Since it works fine for some users, it doesn't make sense to deprive
them.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
applied 1-6, but I'm watching this change closely. This area of
Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: linux-2.6/Documentation/networking/netdevices.txt
===
--- linux-2.6.orig/Documentation/networking/netdevices.txt 2007-01-04
19:38:05.0
Eugene Surovegin wrote:
Fix Section mismatch warnings
Signed-off-by: Eugene Surovegin [EMAIL PROTECTED]
---
drivers/net/ibm_emac/ibm_emac_mal.c |3 +--
drivers/net/ibm_emac/ibm_emac_mal.h |3 +--
drivers/net/ibm_emac/ibm_emac_rgmii.c |2 +-
Scott Wood wrote:
The hardware must not see that is given ownership of a buffer until it is
completely written, and when the driver receives ownership of a buffer,
it must ensure that any other reads to the buffer reflect its final
state. Thus, I/O barriers are added where required.
Without
Linas Vepstas wrote:
From: Christoph Hellwig [EMAIL PROTECTED]
Spidernet was the driver I original did all the node-aware netdevice
allocation for, but after a year it still hasn't hit mainline.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Mithlesh Thukral wrote:
NetXen: Fix for driver on System-p
This patch will fix a ping issue on system-p
Signed-off by: Milan Bag [EMAIL PROTECTED]
Signed-off by: Adhiraj Joshi [EMAIL PROTECTED]
Signed-by: Mithlesh Thukral [EMAIL PROTECTED]
---
drivers/net/netxen/netxen_nic_init.c |2 +-
1
Auke Kok wrote:
From: Auke Kok [EMAIL PROTECTED]
pci_enable_msi calls can fail for normal operational reasons. Driver
should not print an error message in that case. Fix a leak that leaves
msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI
ifdefs alltogether
Signed-off-by: Auke
Auke Kok wrote:
pci_enable_msi failure is a normal event so we should not print any error.
Going over the code I spotted a missing pci_disable_msi() leak when irq
allocation fails. The whole code also needed a cleanup, so I combined the
two different calls to pci_request_irq into a single call
Auke Kok wrote:
Our 82571 (first PCI-E hardware) causes P-Series hardware to throw
issues. Disabling PCI-E completion timeouts in our NIC resolves
the issue.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Cc: Wen Xiong [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c | 10 ++
1 files
Mithlesh Thukral wrote:
NetXen: Changes related to registers and their access routines
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi
Compiling 2.6.22-rc1 with gcc-3.2.3 for i486 fails with:
gcc -m32 -Wp,-MD,net/core/.skbuff.o.d -nostdinc -isystem
/home/mikpe/pkgs/linux-x86/gnu/lib/gcc-lib/i486-pc-linux-gnu/3.2.3/include
-D__KERNEL__ -Iinclude -include include/linux/autoconf.h -Wall -Wundef
-Wstrict-prototypes
Hello,
On Thu, 17 May 2007, Patrick McHardy wrote:
saddr = iph-daddr;
if (!(rt-rt_flags RTCF_LOCAL)) {
if (sysctl_icmp_errors_use_inbound_ifaddr)
saddr = inet_select_addr(skb_in-dev, 0, RT_SCOPE_LINK);
else
saddr = 0;
On Thu, May 17, 2007 at 06:40:28PM +0200, Patrick McHardy wrote:
Actually thats exactly the case that my patch handles. Why does it
matter which source address the ICMP packet uses, as long as its
routed properly?
Agreed.
In any case some better solution than the current one needs to be
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
Documentation/networking/netdevices.txt |2 +-
drivers/net/e1000/e1000.h |4 +-
drivers/net/e1000/e1000_main.c
On Thu, 2007-05-17 at 15:27 -0700, Andrew Morton wrote:
Lovely. So it was actually generating wrong code on all
sizeof(size_t)!=sizeof(int) architectures.
I was trying to work out which architectures would actually be affected.
Probably not many. If it's in a register it probably doesn't
Kim Phillips wrote:
On Tue, 15 May 2007 17:45:19 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Kim Phillips wrote:
It was agreed that phy-connection-type was a better name for
the interface-type property, so this patch renames it.
Also, the max-speed property name was determined too generic,
Can you resend against the latest kernel (2.6.22-rc1)?
And what does Intel think?
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
@@ -924,7 +926,9 @@ cbq_dequeue_prio(struct Qdisc *sch, int
cl-xstats.borrows += skb-len;
#endif
}
- q-tx_len = skb-len;
+ q-tx_segs = skb_shinfo(skb)-gso_segs ? :
+
From: David Woodhouse [EMAIL PROTECTED]
Date: Fri, 18 May 2007 09:48:32 +0800
On Thu, 2007-05-17 at 15:27 -0700, Andrew Morton wrote:
If only we could find some way in which all callers of a function as
well as its definition can see the same declaration?
Well, building with --combine
Jeff Garzik wrote:
Can you resend against the latest kernel (2.6.22-rc1)?
And what does Intel think?
I'm expecting at least a reply from Milton as the patch was sent to him. I
haven't yet tested it but will certainly do so. At first glance it looks OK, and
I'll try to put it under my
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce initialization code.
Rough plan:
1. Introduce inline accessors so protocols don't dereference dev-XXX directly.
2. Fix
Stephen Hemminger wrote:
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce initialization code.
Rough plan:
1. Introduce inline accessors so protocols don't
Mark Huth [EMAIL PROTECTED] wrote:
This patch provides a performance optimization in the pfkey_add path.
Prior versions have a serious performance problem when adding a large
number of SAs to a node. For example, if a backup node needs to be
loaded with the SAs previously held by a failed
From: Ben Greear [EMAIL PROTECTED]
Date: Thu, 17 May 2007 21:23:16 -0700
Vlan code uses several of the methods, so I'm not sure how it will save
any memory
Feeling particularly dense today?
Only one copy of the ops will be needed for all vlan devices:
static const struct netdev_ops
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 17 May 2007 21:07:37 -0700
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce initialization code.
Rough plan:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 18 May 2007 00:54:13 -0400
Stephen Hemminger wrote:
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce
Stephen Hemminger wrote:
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce initialization code.
It will also add an additional deref to every operation, right?
At Thu, 17 May 2007 18:52:47 -0500, Linas Vepstas wrote:
The stack trace from Owa-san showed a null pointer deref at
ip_hdr(skb)-protocol for an skb passed in via hard_start_xmit()
I dunno, memory corruption?
It turns out that there was a mistake in my report, sorry.
The error occurs on
On Thu, 17 May 2007 22:05:29 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 18 May 2007 00:54:13 -0400
Stephen Hemminger wrote:
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'.
76 matches
Mail list logo
