Re: [PATCH][NET_SCHED] Update htb rate when stats are polled.

2007-05-30 Thread Patrick McHardy
Ranjit Manomohan wrote: On 5/26/07, Patrick McHardy [EMAIL PROTECTED] wrote: You can use this patch as a base. It needs a bit more work (for example the CONFIG_NET_SCHED_ESTIMATOR ifdefs are unnecessary, but I've added them to remind me to clean this up in all schedulers), but it works well

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Ilpo Järvinen
On Tue, 29 May 2007, Stephen Hemminger wrote: On Tue, 29 May 2007 20:23:45 +0200 Lior Dotan [EMAIL PROTECTED] wrote: NTP was not running. I'm not sure what do you mean by fixing the -1. The trace shows that vegas_cong_avoid() is called with -1, and the only way it can happen is from

[8139CP]: Fix VLAN unregistration

2007-05-30 Thread Patrick McHardy
Fix 8139cp disabling VLAN completely once the first vid is unregistered. Compile-tested only since I don't own one of these cards. [8139CP]: Fix VLAN unregistration 8139cp disables VLAN completely when the first VID is unregistered. It should instead disable VLAN when the group is unregistered

[PATCH] net: fix comparisons of unsigned 0

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared 0 or = 0. Signed-off-by: Bill Nottingham [EMAIL PROTECTED] --- 8021q/vlan.c |3 +-- dccp/probe.c |2 +- ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |3

[PATCH] drivers/net: fix comparisons of unsigned 0

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared 0 or = 0. Signed-off-by: Bill Nottingham [EMAIL PROTECTED] --- mlx4/qp.c |3 +-- netxen/netxen_nic_niu.c |6 +++--- tulip/de2104x.c |1 - 3 files changed, 4 insertions(+), 6 deletions(-)

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-30 Thread Milton Miller
On May 29, 2007, at 10:58 AM, David Acker wrote: Ok, I finally got some time to code this out and study it and Ihave some questions. Milton Miller wrote: We add two flags to struct rx: one says this packet is EL, and one says it is or was size 0. We create a function,

[PATCH] merge dst_discard in out into one, removed a duplicate function

2007-05-30 Thread Rankle_
On 5/28/07, Jan Engelhardt [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Uhm, just replace every invocation of dst_discard_in/_out() directly by dst_discard ... don't add macros for that. merge dst_discard in out into one, this removed a duplicate function. Signed-off-by: Denis Cheng

[PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

2007-05-30 Thread Ilpo Järvinen
On Tue, 29 May 2007, Ilpo Järvinen wrote: [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) The code used to ignore GSO completely, passing either way too small or zero pkts_acked when GSO skb or part of it got ACKed. In addition, there is no need to calculate the

[RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Patrick McHardy
One good thing about ESFQ is the more flexible flow classification, but I don't like the concept of having a set of selectable hash functions very much. These patches change SFQ to allow attaching external classifiers and add a new flow classifier that allows to classify flows based on an

[RFC NET_SCHED 01/02]: sch_sfq: add support for external classifiers

2007-05-30 Thread Patrick McHardy
[NET_SCHED]: sch_sfq: add support for external classifiers Add support for external classifiers to allow using different flow hash functions similar to ESFQ. As long as no classifier is attached the built-in hash is used as before. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit

[RFC NET_SCHED 02/02]: Add flow classifier

2007-05-30 Thread Patrick McHardy
[NET_SCHED]: Add flow classifier Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit e98a4dd4f6cef4d46f180dee2e91e7f359a854c3 tree f56ea6da8115c5ee9fbc30421f9c4e392a8c55a7 parent 666e402224e5ca36af0b5a07d424b9c092bce91e author Patrick McHardy [EMAIL PROTECTED] Wed, 30 May 2007 11:22:49

[RFC IPROUTE]: Add flow classifier support

2007-05-30 Thread Patrick McHardy
The iproute patch for the flow classifier. [IPROUTE]: Add flow classifier support Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit f338e298616e6680dc1ea3b1c61cf59a72bf0801 tree 857fc47789b2bf45e354c8c63f1ef78526b38ca5 parent b16621cafd599499fdbaa79236266d72a53106bb author Patrick

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-30 Thread KOVACS Krisztian
Hi, On Friday 18 May 2007 11:05, David Miller wrote: From: Julian Anastasov [EMAIL PROTECTED] Date: Fri, 18 May 2007 11:40:54 +0300 (EEST) On Thu, 17 May 2007, Patrick McHardy wrote: In any case some better solution than the current one needs to be found, allowing users to send

[PATCH 2.6.22-rc3] ehea: Fixed multi queue RX bug

2007-05-30 Thread Thomas Klein
Must access the respective queue's dummy netdev instead of the port's netdev. Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index 602872d..e85a933 100644 --- a/drivers/net/ehea/ehea.h +++ b/drivers/net/ehea/ehea.h @@ -39,7 +39,7

Re: b44: regression in 2.6.22 (resend)

2007-05-30 Thread Michael Buesch
On Tuesday 29 May 2007 23:36:51 Gary Zambrano wrote: On Tue, 2007-05-29 at 18:39 -0400, Jeff Garzik wrote: We check for 0x because that is often how a fault is indicated, when the memory location is read during or immediately after hotplug (or if the PCI bus is truly faulty).

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Michael Buesch
On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: proposed change. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-29 19:46:12.37698 -0700 @@ -1227,7 +1227,14 @@ int i;

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Andy Furniss
Patrick McHardy wrote: One good thing about ESFQ is the more flexible flow classification, but I don't like the concept of having a set of selectable hash functions very much. These patches change SFQ to allow attaching external classifiers and add a new flow classifier that allows to classify

Re: [PCNET32] Lock solid with netconsole

2007-05-30 Thread Francois Romieu
Emmanuel Fusté [EMAIL PROTECTED] : [..] Could this bug fix from Stephen Hemminger be another track to follow ? http://marc.info/?l=linux-netdevm=118048588011069w=2 If you think so, I could give it a try whitout applying the spin_lock_irqsave patch. You can apply it too but Stephen's patch

[PATCH] ethtool: new ID to decode the registers of the 8101E (realtek)

2007-05-30 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Rolf Eike Beer [EMAIL PROTECTED] --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/realtek.c b/realtek.c index 8daba69..c56b3f5 100644 --- a/realtek.c +++ b/realtek.c @@ -46,6 +46,7 @@ static struct

Re: Problem with atl1 and msi in kernel 2.6.22-rc3

2007-05-30 Thread Jay Cliburn
On Wed, 30 May 2007 02:00:25 +0200 Jose Alberto Reguero [EMAIL PROTECTED] wrote: I have problems with a M2V motherboard and atl1 driver with msi and kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems. I must add in drivers/pci/quirks.c (line 1723):

[patch 6/7] CAN: Add maintainer entries

2007-05-30 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index:

[patch 0/7] CAN: Add new PF_CAN protocol family, update

2007-05-30 Thread Urs Thuermann
Hello Dave, this is the second post of the patch series that adds the PF_CAN protocol family for the Controller Area Network. Due to some feedback on the netdev-list and own reviews we have changed the following: * reduced RCU callback overhead when deleting receiver lists (thx to feedback

[patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- drivers/net/Makefile |1

[patch 3/7] CAN: Add raw protocol

2007-05-30 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/raw.h | 31 ++ net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 703

[patch 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-05-30 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- include/linux/if_arp.h |1 +

[patch 4/7] CAN: Add broadcast manager (bcm) protocol

2007-05-30 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 28 net/can/Makefile|3 net/can/bcm.c | 1671

[patch 7/7] CAN: Add documentation

2007-05-30 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-Off-By: Oliver Hartkopp [EMAIL PROTECTED] Signed-Off-By: Urs Thuermann [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 635 ++ 2 files

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2007-05-30 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit c420bc9f09a0926b708c3edb27eacba434a4f4ba: Linus Torvalds (1): Linux 2.6.22-rc3 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Akinobu Mita (2):

Re: [PATCH 1/7] sky2: dont set bogus bit in PHY register

2007-05-30 Thread Jeff Garzik
Stephen Hemminger wrote: This code inherited from the sk98lin driver is incorrect on the Yukon2. The GPHY_CTRL register values are specific to the internal PHY of the chip and the values used were leftovers. Driver was setting bit 13 which is now the INT polarity for the PHY! Signed-off-by:

Re: [PATCH] defxx: Fix the handling of ioremap() failures

2007-05-30 Thread Jeff Garzik
Maciej W. Rozycki wrote: If ioremap_nocache() is unfortunate enough to fail, the error code is not set correctly leading to a false success from dfx_register(). This change fixes the problem. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] applied - To unsubscribe from this list:

Re: [PATCH 5/7] sky2: enable IRQ on duplex renegotiation

2007-05-30 Thread Jeff Garzik
Stephen Hemminger wrote: Don't want IRQ on FIFO error because there is nothing useful to do with it. But do want IRQ on duplex change. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 6/7] sky2: enable clocks before probe

2007-05-30 Thread Jeff Garzik
Stephen Hemminger wrote: Some chips need to have internal clocks enabled (via PCI config) before the PCI space is readable. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 102 ++--- drivers/net/sky2.h | 19

Re: [PATCH 4/7] sky2: PHY page register fixes

2007-05-30 Thread Jeff Garzik
Stephen Hemminger wrote: Several of the PHY registers are multiplexed; access to register must be proceeded by setting page register. The driver setup is safer if this is done before the access rather than depending on the last value. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] NAK

Re: [PATCH 2.6.22-rc3] ehea: Fixed multi queue RX bug

2007-05-30 Thread Jeff Garzik
Thomas Klein wrote: Must access the respective queue's dummy netdev instead of the port's netdev. Signed-off-by: Thomas Klein [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-30 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit d7ea3be56adc95b17351221fd95e78115f3b01f4: Brandon Craig Rhodes (1): hostap: Allocate enough tailroom for TKIP are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git

Re: Please pull 'libertas' branch of wireless-2.6

2007-05-30 Thread Jeff Garzik
John W. Linville wrote: Lots of stuff here...probably best for 2.6.23... Is this best for Linux users... or just easy for developers? Won't putting off all these fixes until 2.6.23 leave the driver released in 2.6.22 in shoddy shape? libertas is upstream now, so we cannot pretend that the

Re: [PATCH 6/7] sky2: enable clocks before probe

2007-05-30 Thread Stephen Hemminger
Jeff Garzik wrote: Stephen Hemminger wrote: Some chips need to have internal clocks enabled (via PCI config) before the PCI space is readable. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 102 ++---

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread jamal
On Wed, 2007-30-05 at 11:40 +0200, Patrick McHardy wrote: One good thing about ESFQ is the more flexible flow classification, but I don't like the concept of having a set of selectable hash functions very much. In the spirit of SFQ it is probably ok to do that; i.e iirc, the idea for

[git patches] net driver fixes

2007-05-30 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/defxx.c |1 + drivers/net/e1000/e1000_main.c |9 +++-

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
features = features (dev_features BOND_INTERSECT_FEATURES); On 5/30/07, Michael Buesch [EMAIL PROTECTED] wrote: On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: proposed change. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
corrected diff. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-30 08:18:24.018322000 -0700 @@ -1227,7 +1227,14 @@ int i; bond_for_each_slave(bond, slave, i) { - features =

Re: Please pull 'libertas' branch of wireless-2.6

2007-05-30 Thread Dan Williams
On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote: John W. Linville wrote: Lots of stuff here...probably best for 2.6.23... Is this best for Linux users... or just easy for developers? Won't putting off all these fixes until 2.6.23 leave the driver released in 2.6.22 in shoddy shape?

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Patrick McHardy
jamal wrote: On Wed, 2007-30-05 at 11:40 +0200, Patrick McHardy wrote: One good thing about ESFQ is the more flexible flow classification, but I don't like the concept of having a set of selectable hash functions very much. In the spirit of SFQ it is probably ok to do that; [..] So if

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Patrick McHardy
Andy Furniss wrote: Patrick McHardy wrote: It currently does not support perturbation, I didn't want to move this into the classifier, so I need to think about a way to handle it within SFQ. Cool, but isn't this going to show the same collision problems that the pre jhash esfq saw?

[RFC] IPV6 checksum offloading in network devices

2007-05-30 Thread Stephen Hemminger
Here is a proposed change to address hardware that can do IPV6 checksum offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3 are like this for some revisions, and upcoming Marvell 88e8071 is similar. --- a/drivers/net/bnx2.c2007-05-30 08:26:18.0 -0700 +++

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-30 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: Look at the function argument... Yes, it's void *. But my point is that C requires the ?: to evaluate to some specific type, so if you have different types on each side of the : the compiler can be legitimately upset. The fact that the whole thing gets cast to void * is

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread jamal
On Wed, 2007-30-05 at 17:27 +0200, Patrick McHardy wrote: jamal wrote: Sure. The thing I don't like about the predefined hash functions is that its unflexible. agreed. skb-prio as a selector. I think if you removed that it should be fine. I don't think thats a problem, it needs to

Re: [RFC] IPV6 checksum offloading in network devices

2007-05-30 Thread Patrick McHardy
Stephen Hemminger wrote: Here is a proposed change to address hardware that can do IPV6 checksum offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3 are like this for some revisions, and upcoming Marvell 88e8071 is similar. --- a/include/linux/netdevice.h

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Patrick McHardy
jamal wrote: On Wed, 2007-30-05 at 17:27 +0200, Patrick McHardy wrote: Another alternative is to create a brand new FQ qdisc and leave the classification to the classifiers. I created a new classifier to leave classification to the classifiers .. Not sure exactly why I would need a new qdisc

[RFC] qdisc_run de inline.

2007-05-30 Thread Stephen Hemminger
It isn't worth inlining qdisc_run, into two parts. The code is cleaner (and smaller) to just have it as one routine. --- a/include/net/pkt_sched.h 2007-05-02 12:26:34.0 -0700 +++ b/include/net/pkt_sched.h 2007-05-30 09:12:22.0 -0700 @@ -80,14 +80,7 @@ extern struct

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread jamal
On Wed, 2007-30-05 at 18:23 +0200, Patrick McHardy wrote: I think exposing SFQ's queues as classes is a good thing, it allows you to do whatever classification you want. In fact I'm probably going to add patch on top to also dump them to userspace. Yes, that would be useful. What remains

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Stephen Hemminger
On Tue, 29 May 2007 17:41:45 -0700 Laurent Chavey [EMAIL PROTECTED] wrote: kernel version = 2.6.20.1 file drivers/net/bonding/bonding_main.c function bond_compute_features() --- Given a system with two different NIC. One driver sets dev-features |= NETIF_F_HW_CSUM

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 10:49:54 +0300 (EEST) Ilpo Järvinen [EMAIL PROTECTED] wrote: On Tue, 29 May 2007, Stephen Hemminger wrote: On Tue, 29 May 2007 20:23:45 +0200 Lior Dotan [EMAIL PROTECTED] wrote: NTP was not running. I'm not sure what do you mean by fixing the -1. The trace

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Patrick McHardy
jamal wrote: On Wed, 2007-30-05 at 18:23 +0200, Patrick McHardy wrote: My classifier seperates them entirely. The only thing it keeps in SFQ is the old classifier for compatibility, besides that its exactly what you say. It should be easily possible to remove it entirely and use my classifier

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread Andy Furniss
Patrick McHardy wrote: My classifier uses jhash, Ahh that's OK - I thought it still used the old sfq hash, which collided alot with a low number of consecutive addresses. Andy. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
should we then move/integrate that code as part of the bonding driver ? On 5/30/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Tue, 29 May 2007 17:41:45 -0700 Laurent Chavey [EMAIL PROTECTED] wrote: kernel version = 2.6.20.1 file drivers/net/bonding/bonding_main.c function

[PATCH 2.6.22 0/5]

2007-05-30 Thread Divy Le Ray
Hi Jeff, I'm submitting a set of bug fixes for inclusion in 2.6.22. The patches are built against Linus'git tree. Here is a brief description: - Fix skb-dev dereference in, - Fix netpoll handler, - Fix link status detection for direct XAUI adapters, - Work around potential hang on MTU change, -

[PATCH 1/5] cxgb3 - fix skb-dev dereference

2007-05-30 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] eth_type_trans() now sets skb-dev. References to skb-dev should happen after it is called. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/sge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/5] cxgb3 - fix netpoll hanlder

2007-05-30 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 16 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 13 insertions(+), 4

[PATCH 3/5] cxgb3 - Fix direct XAUI support

2007-05-30 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Check all lanes for link status on direct XAUI cards. Don't assume that direct XAUI always uses XGMAC 1. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/ael1002.c | 10 -- drivers/net/cxgb3/regs.h|2 ++ 2 files changed,

[PATCH 4/5] cxgb3 - Stop mac RX when changing MTU

2007-05-30 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Rx traffic needs to be halted when the MTU is changed to avoid a potential chip hang. Reset/restore MAC filters around a MTU change. Also fix the pause frames high materwark setting. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h

[PATCH 5/5] cxgb3 - MAC watchdog update

2007-05-30 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Fix variables initialization and usage in the MAC watchdog. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/xgmac.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git

Re: [RFC NET_SCHED 00/02]: Flexible SFQ flow classification

2007-05-30 Thread jamal
On Wed, 2007-30-05 at 18:55 +0200, Patrick McHardy wrote: I could do that, but I'm perfectly happy with the qdisc part of SFQ. Without the classifier SFQ is of course simply a FQ qdisc, all it cares about is serving queues equally. Sure. You are writting the code - your call. cheers, jamal

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Patrick McHardy
Urs Thuermann wrote: +static int numdev = 4; /* default number of virtual CAN interfaces */ +module_param(numdev, int, S_IRUGO); +MODULE_PARM_DESC(numdev, Number of virtual CAN devices); I have a set of patches coming up that introduce a rtnetlink API for adding/modifying/deleting software

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 09:58:38 -0700 Laurent Chavey [EMAIL PROTECTED] wrote: should we then move/integrate that code as part of the bonding driver ? On 5/30/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Tue, 29 May 2007 17:41:45 -0700 Laurent Chavey [EMAIL PROTECTED] wrote:

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Stephen Hemminger
In addition to Patrick's comments. + +static void vcan_init(struct net_device *dev) +{ + DBG(dev %s\n, dev-name); + + ether_setup(dev); Do really want to do this? - you set different flags/type after this. - do you really want change_mtu to call eth_change_mtu Better off to

Re: [PATCH 6/7] sky2: enable clocks before probe

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 09:56:18 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: Some chips need to have internal clocks enabled (via PCI config) before the PCI space is readable. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 102

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Andrew Morton
On Tue, 29 May 2007 11:01:13 -0700 Venki Pallipadi [EMAIL PROTECTED] wrote: round_jiffies for net dev watchdog timer. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c ===

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 10:59:36 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 29 May 2007 11:01:13 -0700 Venki Pallipadi [EMAIL PROTECTED] wrote: round_jiffies for net dev watchdog timer. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index:

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Oliver Hartkopp
Patrick McHardy wrote: I have a set of patches coming up that introduce a rtnetlink API for adding/modifying/deleting software network devices. I would prefer if you could switch this driver over instead of doing the create N devices during loading that many current drivers do, leaving you

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Patrick McHardy
Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c 2007-05-24 11:16:03.0 -0700 +++ linux-2.6.22-rc-mm/net/sched/sch_generic.c 2007-05-25

[PATCH 2.6.22-rc2] xfrm BEET interfamily support

2007-05-30 Thread Joakim Koskela
Hi, Here is the patch for the net-2.6 (22-rc2) BEET (Bound End-to-End Tunnel) mode implementation to support ipv4/ipv6 interfamily addressing, as specified by the ietf draft found at: http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-07.txt The previous implementation required

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Ilpo Järvinen
On Wed, 30 May 2007, Stephen Hemminger wrote: On Wed, 30 May 2007 10:49:54 +0300 (EEST) Ilpo Järvinen [EMAIL PROTECTED] wrote: I think the code did a right thing before your api merge, since it called rtt callback only if FLAG_RETRANS_DATA_ACKED was not set (and pkts_acked always),

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Oliver Hartkopp
Stephen Hemminger wrote: In addition to Patrick's comments. + +static void vcan_init(struct net_device *dev) +{ +DBG(dev %s\n, dev-name); + +ether_setup(dev); Do really want to do this? - you set different flags/type after this. - do you really want change_mtu to

[PATCH 0/4] mac80211 fixes for 2.6.22

2007-05-30 Thread John W. Linville
Some bug fixes that should be applied to 2.6.22: mac80211: fail back to use associate from reassociate mac80211: fix memory leak when defrag fragments mac80211: always set carrier status on open mac80211: avoid null ptr deref in ieee80211_ibss_add_sta These are also

[PATCH 2/4] mac80211: fix memory leak when defrag fragments

2007-05-30 Thread John W. Linville
From: Hong Liu [EMAIL PROTECTED] We forget to free all the fragments when defraging them into one packet. Signed-off-by: Hong Liu [EMAIL PROTECTED] Signed-off-by: John W. Linville [EMAIL PROTECTED] --- net/mac80211/ieee80211.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

[PATCH 3/4] mac80211: always set carrier status on open

2007-05-30 Thread John W. Linville
From: Michael Wu [EMAIL PROTECTED] ieee80211_open should always set the carrier status since we may have set it to off before. Signed-off-by: Michael Wu [EMAIL PROTECTED] Signed-off-by: John W. Linville [EMAIL PROTECTED] --- net/mac80211/ieee80211.c |2 ++ 1 files changed, 2 insertions(+),

[PATCH 1/4] mac80211: fail back to use associate from reassociate

2007-05-30 Thread John W. Linville
From: Zhu Yi [EMAIL PROTECTED] Some APs have strict checking between associate and reassociate. In a case when an AP is restarted during a connection, it denies the mac80211 reassoc request since this is a new association for the AP. To fix this problem, we need to check the status code against

[PATCH 4/4] mac80211: avoid null ptr deref in ieee80211_ibss_add_sta

2007-05-30 Thread John W. Linville
From: John W. Linville [EMAIL PROTECTED] avoid sdata null pointer dereference in ieee80211_ibss_add_sta. Signed-off-by: John W. Linville [EMAIL PROTECTED] --- net/mac80211/ieee80211_sta.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/mac80211/ieee80211_sta.c

[PATCH 0/3] myri10ge updates for 2.6.22

2007-05-30 Thread Brice Goglin
Hi Jeff, Here's a small patchset for myri10ge in 2.6.22: 1) report link up/down in standard ethtool way 2) limit the number of recoveries 3) update driver version Please apply. Thanks! Brice - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 20:57:33 +0200 Oliver Hartkopp [EMAIL PROTECTED] wrote: Does 'unneeded' belong to always the last line of the quoted code snippet? They are all places where you assign zero (or NULL) to something that is already initialized to zero by alloc_netdev. -- Stephen

[PATCH 1/3] myri10ge: report link up/down in standard ethtool way

2007-05-30 Thread Brice Goglin
Report link up/down in standard ethtool way Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c |1 + 1 file changed, 1 insertion(+) Index: linux-rc/drivers/net/myri10ge/myri10ge.c === ---

[PATCH 2/3] myri10ge: limit the number of recoveries

2007-05-30 Thread Brice Goglin
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default. It enables detection of defective NICs immediately since these memory parity errors are expected to happen very rarely (less than once per century*NIC). However, a defective NIC (very rare, fortunately) can see such an

[PATCH 3/3] myri10ge: update driver version

2007-05-30 Thread Brice Goglin
Update driver version to 1.3.1-1.245. Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-rc/drivers/net/myri10ge/myri10ge.c ===

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Patrick McHardy
Oliver Hartkopp wrote: Patrick McHardy wrote: I have a set of patches coming up that introduce a rtnetlink API for adding/modifying/deleting software network devices. I would prefer if you could switch this driver over instead of doing the create N devices during loading that many current

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Venki Pallipadi
On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote: Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Oliver Hartkopp
Stephen Hemminger wrote: On Wed, 30 May 2007 20:57:33 +0200 Oliver Hartkopp [EMAIL PROTECTED] wrote: Does 'unneeded' belong to always the last line of the quoted code snippet? They are all places where you assign zero (or NULL) to something that is already initialized to zero by

[PATCH 1/2] bridge: reduce frequency of forwarding cleanup timer in bridge

2007-05-30 Thread Stephen Hemminger
The bridge cleanup timer is fired 10 times a second for timers that are at least 15 seconds ahead in time and that are not critical to be cleaned asap. This patch calculates the next time to run the timer as the minimum of all timers or a minimum based on the current state. Signed-off-by: Baruch

[PATCH 2/2] bridge: round off STP perodic timers

2007-05-30 Thread Stephen Hemminger
Peroidic STP timers don't have to be exact. The hold timer runs at 1HZ, and the hello timer normally runs at 2HZ; save power by aligning it them to next second. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/bridge/br_stp.c |3 ++- net/bridge/br_stp_timer.c |2 +- 2

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Patrick McHardy
Venki Pallipadi wrote: On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote: It seems wasteful to add per-packet overhead for tx timeouts, which should be an exception. Do drivers really care about the exact timeout value? Compared to a packet transmission time its incredibly long

netlink-based qdisc monitor?

2007-05-30 Thread Jason Lunz
I recall mention of a tool that could dynamically monitor kernel packet queues in linux using netlink, but I can't remember a unique enough name for good googling. Does this sound familiar to anyone? iirc it was written by Thomas Graf? Jason - To unsubscribe from this list: send the line

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Oliver Hartkopp
Patrick McHardy wrote: (..) Qdiscs might change skb-cb. Maybe use skb-sk? The loopback functionality in CAN is a bit tricky (maybe you can take a look into the Documentation patch [7/7] at chapter 3.2 and 4.1.4). The problem is, that we need a per socket(!) option that enables the

RE: [PATCH] Avoid switch on long long in s2io driver

2007-05-30 Thread Ramkrishna Vepa
Patch looks good. Yes, please add a comment as to reason for cast. Ram -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Michael Buesch Sent: Saturday, May 26, 2007 10:04 AM To: Andreas Schwab Cc: netdev@vger.kernel.org Subject: Re: [PATCH] Avoid

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-30 Thread Patrick McHardy
Oliver Hartkopp wrote: Patrick McHardy wrote: skb-sk should work here as well since you detect these frames before queueing to the receiving socket. Hm - this would indeed be much nicer than using skb-cb. I think we just had some concerns to use skb-sk for our own functionality, as

Re: [PATCH 2.6.22 0/5] cxgb3 - bug fixes

2007-05-30 Thread Divy Le Ray
Divy Le Ray wrote: Hi Jeff, I'm submitting a set of bug fixes for inclusion in 2.6.22. The patches are built against Linus'git tree. The mail title was incomplete. sorry about that. Cheers, Divy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 12:55:51 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c

Re: [RFC] IPV6 checksum offloading in network devices

2007-05-30 Thread Stephen Hemminger
This is better. There is still a possiblity when a device allows IPV6 and not IPV4 checksumming, that the checksum will be done in the fixup code in dev_queue_xmit. The existing model for checksum offload does not correctly handle devices that can offload IPV4 and IPV6 only. The NETIF_F_HW_CSUM

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Venki Pallipadi
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === ---

REGRESSION: panic on e1000 driver

2007-05-30 Thread Doug Chapman
All, I reported this a few weeks ago and it was fixed but it appears the offending code was again re-submitted. This causes a panic on HP Integrity servers and from what I hear many other platforms using e1000 as well. My original report was via kernel.org BZ:

  1   2   >