Re: [PATCH 2.6.24 1/1] sch_htb: fix too many events situation

2008-02-18 Thread Martin Devera
up to single jiffy interval and then delay remainder to other jiffy. Signed-off-by: Martin Devera [EMAIL PROTECTED] I think we would be wise to use something other than loops_per_jiffy. Depending upon the loop calibration method used by a particular architecture it can me one of many

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 15:21:48 +0100 On linux-2.6.25-rc1 x86_64 : offsetof(struct dst_entry, lastuse)=0xb0 offsetof(struct dst_entry, __refcnt)=0xb8 offsetof(struct dst_entry, __use)=0xbc

Re: [PATCH 2.6.24 1/1] sch_htb: fix too many events situation

2008-02-18 Thread David Miller
From: Martin Devera [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 09:03:52 +0100 aha, ok, I'm not so informed about crossplatform issues. I was also thining about looking at jiffies value and stop once it is startjiffy+2, but with NO_HZ introduction, are jiffies still incremented ? There should

[PATCH resend] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-18 Thread Christian Borntraeger
Am Montag, 11. Februar 2008 schrieb Anthony Liguori: The reset support is in Linus's tree so we should try to push it for -rc2. You are right. My repository was borked. will push it to Jeff Garzik. Thanks Jeff can you schedule this fix into your network driver updates? Thanks --- With the

e1000: Question about polling

2008-02-18 Thread Badalian Vyacheslav
Hello all. Interesting think: Have PC that do NAT. Bandwidth about 600 mbs. Have 4 CPU (2xCoRe 2 DUO HT OFF 3.2 HZ). irqbalance in kernel is off. nat2 ~ # cat /proc/irq/217/smp_affinity 0001 nat2 ~ # cat /proc/irq/218/smp_affinity 0003 Load SI on CPU0 and CPU1 is about 90% Good...

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-18 Thread Jan-Bernd Themann
switching to proper mail client... Dave Hansen [EMAIL PROTECTED] wrote on 15.02.2008 17:55:38: I've been thinking about that, and I don't think you really *need* to keep a comprehensive map like that. When the memory is in a particular configuration (range of memory present along with

Re: [PATCH 2.6.24 1/1] sch_htb: fix too many events situation

2008-02-18 Thread Martin Devera
David Miller wrote: From: Martin Devera [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 09:03:52 +0100 aha, ok, I'm not so informed about crossplatform issues. I was also thining about looking at jiffies value and stop once it is startjiffy+2, but with NO_HZ introduction, are jiffies still

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
On Mon, 18 Feb 2008 16:12:38 +0800 Zhang, Yanmin [EMAIL PROTECTED] wrote: On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 15:21:48 +0100 On linux-2.6.25-rc1 x86_64 : offsetof(struct dst_entry, lastuse)=0xb0

Re: [PATCH 2.6.24 1/1] sch_htb: fix too many events situation

2008-02-18 Thread David Miller
From: Martin Devera [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 11:08:09 +0100 Like max_jiff = jiffies+2; /* not +1 at we could be at +0. now */ while (jiffiesmax_jiff) do_hard_potentionaly_long_work(); if (more_work) schedule_to_next_jiffie(); This will keep event queue work load under

[PATCH][IBMVETH]: Use single_open instead of manual manipulations.

2008-02-18 Thread Pavel Emelyanov
The code opening proc entry for each device makes the same thing, as the single_open does, so remove the unneeded code. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 57772be..bb31e09 100644 --- a/drivers/net/ibmveth.c +++

[PATCH][IPV6]: Use BUG_ON instead of if + BUG in fib6_del_route.

2008-02-18 Thread Pavel Emelyanov
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index f93407c..bab72b6 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -1151,7 +1151,7 @@ static void fib6_del_route(struct fib6_node *fn, struct rt6_info **rtp,

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-18 Thread Andrew Morton
On Sun, 17 Feb 2008 00:54:08 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: [Try this again, except this time I'll force the attachment as inline text!] Hi, I have managed to boot 2.6.24.1 on this machine, with the NMI watchdog enabled, by using the acpi=noirq option. (There does

Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...

2008-02-18 Thread Andrew Morton
On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov [EMAIL PROTECTED] wrote: ... and possibly reboot/poweroff (it flows by too fast to be legible). [ 8803.850634] ACPI: Preparing to enter system sleep state S3 [ 8803.853141] Suspending console(s) [ 8805.287505] serial 00:09: disabled [

Re: [2.6.25-rc2, 2.6.24-rc8] page allocation failure...

2008-02-18 Thread Andrew Morton
On Sun, 17 Feb 2008 13:20:59 + Daniel J Blueman [EMAIL PROTECTED] wrote: I'm still hitting this with e1000e on 2.6.25-rc2, 10 times again. It's clearly non-fatal, but then do we expect it to occur? Daniel --- [dmesg] [ 1250.822786] swapper: page allocation failure. order:3,

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-18 Thread Chris Rankin
--- Andrew Morton [EMAIL PROTECTED] wrote: sysfs: duplicate filename 'bridge' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 1, comm: swapper Not tainted 2.6.24.1 #1 [c0105020] show_trace_log_lvl+0x1a/0x2f [c0105990] show_trace+0x12/0x14 [c010613d]

[patch 1/1] claw: make use of DIV_ROUND_UP

2008-02-18 Thread Ursula Braun
From: Julia Lawall [EMAIL PROTECTED] The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- drivers/s390/net/claw.c | 39 ++- 1 file changed, 18

[patch 0/1] s390: claw - More use DIV_ROUND_UP

2008-02-18 Thread Ursula Braun
-- Jeff, this patch is intended for 2.6.25. It makes use of the DIV_ROUND_UP function as proposed by Julia Lawall. Regards, Ursula Braun -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

ipv6 debugging

2008-02-18 Thread Ferenc Wagner
Hi, I'm kindly asking for some debugging tips with the following problem: a machine is running Linux 2.6.24.2, several 802.1q VLAN-s over active/backup bonding over two physical interfaces. Everything is allright, except for after a reboot, there's no IPv6, while IPv4 works. The router's ARP(6)

Re: [PATCH 2.6.24-mm1] error compiling net driver NE2000/NE1000

2008-02-18 Thread Pierre Peiffer
Hi, I don't know if I have to warn on this or not, but as I didn't find any discussion, it's probably better to mention it: the compiling error reported below (or here: http://lkml.org/lkml/2008/2/4/173 ) does not seem to be corrected in 2.6.25-rc2.mm1... So, I don't know if a fix is

Re: [2.6 patch] remove include/linux/netfilter_ipv4/ipt_SAME.h

2008-02-18 Thread Patrick McHardy
Adrian Bunk wrote: This patch removes the no longer used include/linux/netfilter_ipv4/ipt_SAME.h We kept it around because old iptables binaries need it to build. The kernel no longer supports it, but people might still wish to use a distributor-built iptables binary with old kernels. It will

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Patrick McHardy
Joe Perches wrote: On Fri, 2008-02-15 at 02:58 -0800, David Miller wrote: From: Bruno Randolf [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 19:48:05 +0900 is there any chance to include a macro like this for printing mac addresses? its advantage is that it can be used without the need to declare

Re: ipv6 debugging

2008-02-18 Thread Jorge Boncompte [DTI2]
This sounds to me like the same problem that I was having with OSPF, I think ARP(6) uses multicast ethernet address too. Can you try if the patch below, that I sent Patrick McHardy some days ago, fixes your problem? Regards, Jorge --- Hi Patrick, Commit

protocol 0300 is buggy spam in dmesg when injectingcapturing on same interface

2008-02-18 Thread Pekka Pietikainen
When playing with some L2 level fuzzing I started getting lots of protocol 0300 is buggy, dev eth3 spew in dmesg. That interface is also capturing the traffic that's being sent, that's probably why the dev_queue_xmit_nit codepath is getting called in the first place. Tested on

Re: [PATCH 1/3] fib_trie: move statistics to debugfs

2008-02-18 Thread Stephen Hemminger
On Sun, 17 Feb 2008 22:26:55 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 11:58:06 -0800 Don't want /proc/net/fib_trie and /proc/net/fib_triestat to become permanent kernel space ABI issues, so move to the safer

Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-02-18 Thread Ondrej Zary
On Monday 18 February 2008 04:21:11 Grant Grundler wrote: On Wed, Jan 30, 2008 at 09:23:06PM +0100, Ondrej Zary wrote: On Saturday 26 January 2008 21:58:10 Ondrej Zary wrote: Hello, I was having problems with these FreedomLine cards with Linux before but tested it thoroughly today.

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-18 Thread Stephen Hemminger
On Mon, 18 Feb 2008 05:00:49 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 17 Feb 2008 00:54:08 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: [Try this again, except this time I'll force the attachment as inline text!] Hi, I have managed to boot 2.6.24.1 on this

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Valdis . Kletnieks
On Mon, 18 Feb 2008 16:12:38 +0800, Zhang, Yanmin said: I also think __refcnt is the key. I did a new testing by adding 2 unsigned long pading before lastuse, so the 3 members are moved to next cache line. The performance is recovered. How about below patch? Almost all performance is

Re: [PATHCH 1/16] ServerEngines 10Gb NIC driver

2008-02-18 Thread Subbu Seetharaman
Thanks for all comments. I had run checkpatch and corrected all errors excepting a few errors about some macros and the warning about the typedefs. The mail client I used to send the patch folded lines at arbitrary points introduced several trailing white space. This was also the reason for

Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...

2008-02-18 Thread Andrey Borzenkov
On Monday 18 February 2008, Andrew Morton wrote: On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov [EMAIL PROTECTED] wrote: ... and possibly reboot/poweroff (it flows by too fast to be legible). [ 8803.850634] ACPI: Preparing to enter system sleep state S3 [ 8803.853141] Suspending

[PATCH] tlan: add static to function definitions

2008-02-18 Thread Harvey Harrison
The forward declarations were already marked static, make the definitions be static as well. Fixes the sparse warnings as well. drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not declared. Should it be static? drivers/net/tlan.c:1435:5: warning: symbol 'TLan_HandleTxEOF'

keyboard dead with 45b5035

2008-02-18 Thread Pierre Ossman
The patch [RTNETLINK]: Send a single notification on device state changes. kills (at least) the keyboard here. Everything seems to work fine in single user mode, but when init starts spawning of logins, the keyboard goes bye-bye. Even the power button is ignored. :/ I've tried just creating

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Joe Perches
On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote: @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) pr_debug(%s: about to send skb: %p to dev: %s\n, __FUNCTION__, skb, skb-dev-name); - pr_debug( MAC_FMT

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-18 Thread Chris Rankin
--- Stephen Hemminger [EMAIL PROTECTED] wrote: sysfs: duplicate filename 'bridge' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 1, comm: swapper Not tainted 2.6.24.1 #1 [c0105020] show_trace_log_lvl+0x1a/0x2f [c0105990] show_trace+0x12/0x14 [c010613d]

Re: keyboard dead with 45b5035

2008-02-18 Thread Rafael J. Wysocki
On Monday, 18 of February 2008, Pierre Ossman wrote: The patch [RTNETLINK]: Send a single notification on device state changes. kills (at least) the keyboard here. Everything seems to work fine in single user mode, but when init starts spawning of logins, the keyboard goes bye-bye. Even the

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-18 Thread Stephen Hemminger
On Mon, 18 Feb 2008 19:42:25 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: --- Stephen Hemminger [EMAIL PROTECTED] wrote: sysfs: duplicate filename 'bridge' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 1, comm: swapper Not tainted 2.6.24.1 #1

[PATCH 1/1] sis190: read the mac address from the eeprom first

2008-02-18 Thread Francois Romieu
Reading a serie of zero from the cmos sram area do not work well with is_valid_ether_addr(). Let's read the mac address from the eeprom first as it seems more reliable. Fix for http://bugzilla.kernel.org/show_bug.cgi?id=9831 Signed-off-by: Francois Romieu [EMAIL PROTECTED] ---

Re: keyboard dead with 45b5035

2008-02-18 Thread Pierre Ossman
On Mon, 18 Feb 2008 20:50:01 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Monday, 18 of February 2008, Pierre Ossman wrote: The patch [RTNETLINK]: Send a single notification on device state changes. kills (at least) the keyboard here. Everything seems to work fine in single user

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 16:19:40 +0100 Joe Perches wrote: We specifically removed this sort of thing, please don't add it back. Why? We converted the entire tree over the print_mac(), and since the MAC_FMT

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 16:19:40 +0100 Joe Perches wrote: On Fri, 2008-02-15 at 02:58 -0800, David Miller wrote: From: Bruno Randolf [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 19:48:05 +0900 is there any chance to include a macro like this for

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Patrick McHardy
Joe Perches wrote: On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote: @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) pr_debug(%s: about to send skb: %p to dev: %s\n, __FUNCTION__, skb, skb-dev-name); -

Re: ipv6 debugging

2008-02-18 Thread Ferenc Wagner
Jorge Boncompte [DTI2] [EMAIL PROTECTED] writes: Ferenc Wagner [EMAIL PROTECTED] writes: I'm kindly asking for some debugging tips with the following problem: a machine is running Linux 2.6.24.2, several 802.1q VLAN-s over active/backup bonding over two physical interfaces. Everything is

[PATCH] net: fix kernel-doc warnings in header files

2008-02-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add missing structure kernel-doc descriptions to sock.h skbuff.h to fix kernel-doc warnings. (I think that Stephen H. sent a similar patch, but I can't find it. I just want to kill the warnings, with either patch.) Signed-off-by: Randy Dunlap [EMAIL

[PATCH][IPROUTE] tc filters usage fixes

2008-02-18 Thread Jarek Poplawski
A few usage description fixes of tc filters for some minimal consistency (FILTER_KIND because of QDISC_KIND). Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] --- tc/f_basic.c |4 ++-- tc/f_rsvp.c|2 +- tc/f_u32.c |2 +- tc/tc_filter.c |6 +++--- 4 files changed, 7

Re: [PATCH 1/3] Support arbitrary initial TCP timestamps

2008-02-18 Thread Glenn Griffin
Adding yet another member to the already bloated tcp_sock structure to implement this is too high a cost. Yes, I was worried that would be deemed too high of a cost, but it was the most efficient way I could think to accomplish what I wanted. I would instead prefer that there be some global

TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-18 Thread Tony Battersby
I am experiencing network data corruption with a 3Com 3C996B-T NIC (Broadcom NetXtreme BCM5701; driver tg3.ko). I have identified the following patch as the trigger: commit fb93134dfc2a6e6fbedc7c270a31da03fce88db9 Author: Herbert Xu [EMAIL PROTECTED] Date: Wed Nov 14 15:45:21 2007 -0800

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-18 Thread Jarek Poplawski
On Mon, Feb 18, 2008 at 10:09:24PM +, James Chapman wrote: Jarek Poplawski wrote: Hi, It seems, this nice report is still uncomplete: could you check if there could have been something more yet? Unfortunately the ISP's syslog stops. But I've been able to borrow two Quad Xeon boxes and

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-18 Thread Glenn Griffin
I've posted a series of patches that I believe address Andi's concerns about syncookies not supporting valuable tcp options (primarily SACK, and window scaling). The premise being if the client support tcp timestamps we can encode the additional tcp options in the initial timestamp we send back

Re: [PATCH][IPROUTE] tc filters usage fixes

2008-02-18 Thread Jarek Poplawski
Jarek Poplawski wrote, On 02/18/2008 11:10 PM: A few usage description fixes of tc filters for some minimal consistency (FILTER_KIND because of QDISC_KIND). Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] Don't apply: I've sent 2nd version of this patch. Sorry, Jarek P. -- To

[PATCH v2.6.25] gianfar: don't pass NULL dev ptr to DMA ops

2008-02-18 Thread Andy Fleming
From: Becky Bruce [EMAIL PROTECTED] Change all dma op invocations in gianfar.c to actually pass in the device pointer. Currently, the value is ignored, but it will be used going forward as we implement archdata for 32-bit powerpc. Signed-off-by: Becky Bruce [EMAIL PROTECTED] Acked-by: Andy

[PATCH v2][IPROUTE] tc filters usage fixes

2008-02-18 Thread Jarek Poplawski
CLASSID := X:Y:Z == X:Y in f_basic is changed here and no change for f_u32 (it has both CLASSID and FILTERID mentioned). - (take 2) A few usage description fixes of tc filters for some minimal consistency (FILTER_KIND because of QDISC_KIND). Signed-off-by: Jarek Poplawski

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-18 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 16:32:00 -0800 On Mon, 2008-02-18 at 17:41 -0500, Tony Battersby wrote: I am experiencing network data corruption with a 3Com 3C996B-T NIC (Broadcom NetXtreme BCM5701; driver tg3.ko). I have identified the following patch as the

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 16:43:05 -0800 (PST) I think we can fix this easily by using __attribute_const_ on the print_mac() declaration. Let me play with that. Actually it seems the 'pure' attribute is more important here. Although it's not semantically a

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-18 Thread Michael Chan
On Mon, 2008-02-18 at 16:35 -0800, David Miller wrote: One consequence of Herbert's change is that the chip will see a different datastream. The initial skb-data linear area will be smaller, and the transition to the fragmented area of pages will be quicker. I see. Perhaps when we get to

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Joe Perches
On Mon, 2008-02-18 at 16:50 -0800, David Miller wrote: Actually it seems the 'pure' attribute is more important here. Although it's not semantically a perfect match, what we need to tell the compiler is basically that: 1) the return value depends upon the inputs 2) if the input is not

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-18 Thread Michael Chan
On Mon, 2008-02-18 at 17:41 -0500, Tony Battersby wrote: I am experiencing network data corruption with a 3Com 3C996B-T NIC (Broadcom NetXtreme BCM5701; driver tg3.ko). I have identified the following patch as the trigger: Assuming this problem is unique to the 5701, I'm not sure how it is

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 22:17:27 +0100 The way pr_debug is implemented it still results in two function calls per packet since the compiler doesn't know that it doesn't have visible side-effects besides modifying the (unused) buffer. I confirmed this

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread Philip Craig
Joe Perches wrote: Perhaps it's more sensible to go back to #ifdef DEBUG #define pr_debug(fmt, arg...) do {} while (0) #endif and give up the printf argument verification I think argument verification is important. Can you keep it like this: #ifdef DEBUG #define pr_debug(fmt, arg...)

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: On Mon, 18 Feb 2008 16:12:38 +0800 Zhang, Yanmin [EMAIL PROTECTED] wrote: On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 15:21:48 +0100 On linux-2.6.25-rc1

Re: [Bugme-new] [Bug 9920] New: kernel panic when using ebtables redirect target

2008-02-18 Thread Joonwoo Park
On Fri, Feb 08, 2008 at 05:59:42PM -0800, Andrew Morton wrote: On Fri, 8 Feb 2008 17:40:20 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9920 Summary: kernel panic when using ebtables redirect target Product: Networking

Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

2008-02-18 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 17:03:32 -0800 Does this need to be done for all function calls declared with __attribute__((format(printf, x, y))) { return 0; } ie: pr_debug, dev_dbg, dev_vdbg? No, I don't think so. We're adding the tag to teach the compiler

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-18 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 22:09:24 + Here's a new version of the patch. The patch avoids disabling irqs and fixes the sk_dst_get() usage that DaveM mentioned. But even with this patch, lockdep still complains if hundreds of ppp sessions are inserted into

Re: [PATCH 1/2] bluetooth : put hci dev after del conn

2008-02-18 Thread David Miller
From: Dave Young [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 15:55:55 +0800 Move hci_dev_put to del_conn to avoid hci dev going away before hci conn. This looks correct so I have applied it. Signed-off-by: Dave Young [EMAIL PROTECTED] Please remove the extraneous space at the end of your

Re: [PATCH 2/2] bluetooth : do not move child device other than rfcomm

2008-02-18 Thread David Miller
From: Dave Young [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 15:58:05 +0800 hci conn child devices other than rfcomm tty should not be moved here. This is my lost, thanks for Barnaby's reporting and testing. Signed-off-by: Dave Young [EMAIL PROTECTED] Applied, thanks Dave. -- To unsubscribe

Re: [PATCH] [IPV6]: dst_entry leak in ip4ip6_err. (resend)

2008-02-18 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 11:59:38 +0300 The result of the ip_route_output is not assigned to skb. This means that - it is leaked - possible OOPS below dereferrencing skb-dst - no ICMP message for this case Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]

Re: [PATCH][IPV6]: Use BUG_ON instead of if + BUG in fib6_del_route.

2008-02-18 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 15:50:11 +0300 Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied, thanks Pavel. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net: fix kernel-doc warnings in header files

2008-02-18 Thread David Miller
From: Randy Dunlap [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 13:26:47 -0800 From: Randy Dunlap [EMAIL PROTECTED] Add missing structure kernel-doc descriptions to sock.h skbuff.h to fix kernel-doc warnings. (I think that Stephen H. sent a similar patch, but I can't find it. I just want to

Re: [Bugme-new] [Bug 9920] New: kernel panic when using ebtables redirect target

2008-02-18 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 19 Feb 2008 11:53:24 +0900 [PATCH] netfilter: fix incorrect use of skb_make_writable http://bugzilla.kernel.org/show_bug.cgi?id=9920 The function skb_make_writable returns true or false. Signed-off-by: Joonwoo Park [EMAIL PROTECTED] I'll

[PATCH] bonding: simplify code and get rid of warning

2008-02-18 Thread Stephen Hemminger
Get rid of warning and simplify code that looks up vlan tag. No need to get tag, then copy it. Also no need for a local status variable. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- Patch against current 2.6.25 version. --- a/drivers/net/bonding/bond_alb.c2008-02-18

Re: [PATCH] cls_u32 u32_classify()

2008-02-18 Thread David Miller
From: Dzianis Kahanovich [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 11:16:30 -0200 Currently fine u32 hashkey ... at ... not work with relative offsets. There are simpliest fix to use eat. So the question is whether 'sel' is defined to be calculated before all offsets and EAT operations are

Re: keyboard dead with 45b5035

2008-02-18 Thread Pierre Ossman
On Mon, 18 Feb 2008 21:50:12 +0100 Pierre Ossman [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 20:50:01 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Monday, 18 of February 2008, Pierre Ossman wrote: The patch [RTNETLINK]: Send a single notification on device state changes.

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, Zhang, Yanmin said: I also think __refcnt is the key. I did a new testing by adding 2 unsigned long pading before lastuse, so the 3 members are moved to next cache line. The performance is

[PATCH 10/17 net-2.6.26] [NETNS]: Process ip_rt_redirect in the correct namespace.

2008-02-18 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 525787b..44708ab 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1132,10 +1132,12 @@ void

[PATCH 12/17 net-2.6.26] [NETNS]: Process /proc/net/rt_cache inside a namespace.

2008-02-18 Thread Denis V. Lunev
Show routing cache for a particular namespace only. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 67df872..c11e6bf 100644 --- a/net/ipv4/route.c +++

[PATCH 13/17 net-2.6.26] [NETNS]: Register /proc/net/rt_cache for each namespace.

2008-02-18 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index c11e6bf..5f67eba 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -545,7 +545,7 @@

[PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-18 Thread Denis V. Lunev
Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/core/neighbour.c

[PATCH 9/17 net-2.6.26] [NETNS]: DST cleanup routines should be called inside namespace.

2008-02-18 Thread Denis V. Lunev
Device inside the namespace can be started and downed. So, active routing cache should be cleaned up on device stop. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/dst.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/core/dst.c b/net/core/dst.c index

[PATCH 11/17 net-2.6.26] [IPV4]: rt_cache_get_next should take rt_genid into account.

2008-02-18 Thread Denis V. Lunev
In the other case /proc/net/rt_cache will look inconsistent in respect to genid. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Acked-by: Alexey Kuznetsov [EMAIL PROTECTED] --- net/ipv4/route.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH 7/17 net-2.6.26] [NETNS]: Disable multicaststing configuration inside non-initial namespace.

2008-02-18 Thread Denis V. Lunev
Do not calls hooks from device notifiers and disallow configuration from ioctl/netlink layer. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/igmp.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/net/ipv4/igmp.c

[PATCH 14/17 net-2.6.26] [NETNS]: Process devinet ioctl in the correct namespace.

2008-02-18 Thread Denis V. Lunev
Add namespace parameter to devinet_ioctl and locate device inside it for state changes. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/linux/inetdevice.h |2 +- net/ipv4/af_inet.c |7 --- net/ipv4/devinet.c |6 +++--- net/ipv4/ipconfig.c|2

[PATCH 4/17 net-2.6.26] [NETNS]: Disable inetaddr notifiers in namespaces other than initial.

2008-02-18 Thread Denis V. Lunev
ip_fib_init is kept enabled. It is already namespace-aware. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |3 +++ drivers/net/via-velocity.c |3 +++ drivers/s390/net/qeth_main.c|3 +++ net/sctp/protocol.c |3 +++ 4 files

[PATCH 8/17 net-2.6.26] [NETNS]: Enable inetdev_event notifier.

2008-02-18 Thread Denis V. Lunev
After all these preparations it is time to enable main IPv4 device initialization routine inside namespace. It is safe do this now. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/ipv4/devinet.c

[PATCH 16/17 net-2.6.26] [NETNS]: Enable IPv4 address manipulations inside namespace.

2008-02-18 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index f7e78b7..aa23d10 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -446,9 +446,6 @@

[PATCH 17/17 net-2.6.26] [NETNS]: Process inet_select_addr inside a namespace.

2008-02-18 Thread Denis V. Lunev
The context is available from a network device passed in. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index aa23d10..033670d 100644 ---

[PATCH 15/17 net-2.6.26] [NETNS]: Enable all routing manipulation via netlink inside namespace.

2008-02-18 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 5f67eba..79e2e8a 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2702,9 +2702,6 @@ static

[PATCH 5/17 net-2.6.26] [NETNS]: Register neighbour table parameters in the correct namespace.

2008-02-18 Thread Denis V. Lunev
neigh_sysctl_register should register sysctl entries inside correct namespace to avoid naming conflict. Typical example is a loopback. Entries for it present in all namespaces. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/neighbour.c |

[PATCH 3/17 net-2.6.26] [NETFILTER]: Consolidate masq_inet_event and masq_device_event.

2008-02-18 Thread Denis V. Lunev
They do exactly the same job. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/net/ipv4/netfilter/ipt_MASQUERADE.c b/net/ipv4/netfilter/ipt_MASQUERADE.c index

[PATCH 2/17 net-2.6.26] [IPV4]: Remove check for ifa-ifa_dev != NULL.

2008-02-18 Thread Denis V. Lunev
This is a callback registered to inet address notifier chain. The check is useless as: - ifa-ifa_dev is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/atm/clip.c |4 1 files changed, 0 insertions(+), 4

[PATCH 1/17 net-2.6.26] [IPV4]: Remove ifa != NULL check.

2008-02-18 Thread Denis V. Lunev
This is a callback registered to inet address notifier chain. The check is useless as: - ifa is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- drivers/net/via-velocity.c | 22 ++ 1 files changed, 10

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, Zhang, Yanmin said: I also think __refcnt is the key. I did a new testing by adding 2 unsigned long pading before lastuse, so the 3 members are moved to next cache line. The

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: On Mon, 18 Feb 2008 16:12:38 +0800 Zhang, Yanmin [EMAIL PROTECTED] wrote: On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 15:21:48 +0100 On

[PATCH 0/17] Finish IPv4 infrastructure namespacing.

2008-02-18 Thread Denis V. Lunev
This set finally allows to manipulate with network devices inside a namespace and allows to configure them [via netlink]. 'route' is not yet supported (but prepared to) as it requires a socket. Additionally, better routing cache support is added. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]