Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Andrew Lunn
On Wed, Apr 22, 2015 at 04:14:33PM +, Jan Kaisrlik wrote: 2015-04-21 17:51 GMT+00:00 Florian Fainelli f.faine...@gmail.com: On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i

Re: [PATCH v2 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: V2: - don't treat loopback interfaces specially by enabling mpls by default These changes make mpls not be enabled by default on all interfaces when in use for security, along with ensuring that a label not valid as an outgoing label can be

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Wed, 22 Apr 2015, Arnd Bergmann wrote: On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: On Tue, 21 Apr 2015, Thomas Gleixner wrote: So we could save one translation step if we implement new syscalls which have a scalar nsec interface instead of the timespec/timeval cruft

Re: [PATCH net-next] be2net: log link status

2015-04-22 Thread Joe Perches
On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote: The driver unlike other drivers does not log link state changes. [] diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c [] @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Jan Kaisrlik
2015-04-21 17:51 GMT+00:00 Florian Fainelli f.faine...@gmail.com: On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i would suggest adding a netlink binding to DSA, and place the

Re: [PATCH v2 2/3] mpls: Per-device enabling of packet input

2015-04-22 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: An MPLS network is a single trust domain where the edges must be in control of what labels make their way into the core. The simplest way of ensuring this is for the edge device to always impose the labels, and not allow forward labeled traffic

Re: [PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label

2015-04-22 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: The reserved implicit-NULL label isn't allowed to appear in the label stack for packets, so make it an error for the control plane to specify it as an outgoing label. Reviewed-by: Eric W. Biederman ebied...@xmission.com Suggested-by: Eric W.

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Ivan Vecera
On 04/22/2015 04:07 PM, Joe Perches wrote: On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: The driver unlike other drivers does not log link state changes. Why add all the speed stuff, why not add a query instead? I think it'd be simpler to add a line like: status =

Re: [PATCH] tcp: set SOCK_NOSPACE under memory presure

2015-04-22 Thread Jason Baron
On 04/21/2015 05:33 PM, David Miller wrote: From: Jason Baron jba...@akamai.com Date: Mon, 20 Apr 2015 20:05:13 + (GMT) Under tcp memory pressure, calling epoll_wait() in edge triggered mode after -EAGAIN, can result in an indefinite hang in epoll_wait(), even when there is suffcient

[PATCH v2] altera tse: add support for fixed-links.

2015-04-22 Thread Andreas Oetken
From: Andreas Oetken ennoerlan...@gmail.com Add support for fixed-links in configurations without PHY. (e.g. connection to a switch, SGMII point to point, SFPs) Check: Documentation/devicetree/bindings/net/fixed-link.txt. Signed-off-by: Andreas Oetken ennoerlan...@gmail.com ---

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: I've started a list of affected syscalls at https://docs.google.com/spreadsheets/d/1HCYwHXxs48TsTb6IGUduNjQnmfRvMPzCN6T_0YiQwis/edit?usp=sharing Still adding more calls and description, let me know if you want edit permissions.

[PATCH net-next] be2net: log link status

2015-04-22 Thread Ivan Vecera
The driver unlike other drivers does not log link state changes. Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com --- drivers/net/ethernet/emulex/benet/be_main.c |

[PATCH net-next v2] be2net: log link status

2015-04-22 Thread Ivan Vecera
The driver unlike other drivers does not log link state changes. v2: added current link speed to log message Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com ---

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Joe Perches
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: The driver unlike other drivers does not log link state changes. Why add all the speed stuff, why not add a query instead? I think it'd be simpler to add a line like: status = be_cmd_link_status_query(adapter, speed, status, 0);

Re: [PATCH v2 1/3] mpls: Per-device MPLS state

2015-04-22 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: Add per-device MPLS state to supported interfaces. Use the presence of this state in mpls_route_add to determine that this is a supported interface. Use the presence of mpls_dev to drop packets that arrived on an unsupported interface -

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Richard Cochran
On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, getitimer, setitimer: all deprecated = wontfix If adjtimex is deprecated, what will replace it? It is really important for ntp. Thanks, Richard -- To unsubscribe

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Luc Van Oostenryck
On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: ... select, old_selct, pselect6: deprecated Small, copypaste error here for pselect6. Luc -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com build_skb() should look at the page pfmemalloc status. If set, this means page allocator allocated this page in the expectation it would help to free other pages. Networking stack can do that only if skb-pfmemalloc is also set. Also, we must refrain using

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 17:14:47 Luc Van Oostenryck wrote: On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: ... select, old_selct, pselect6: deprecated Small, copypaste error here for pselect6. Right, that should

Re: [PATCH 0/6] crypto: Make all AEAD users include aead.h

2015-04-22 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Wed, 22 Apr 2015 15:04:55 +0800 This series adds inclusions of aead.h to all AEAD users including AEAD implementors (where it's internal/aead.h). This is necessary because I'll be adding an updated AEAD interface and that will live in aead.h

[PATCH] ip6_gre: use netdev_alloc_pcpu_stats()

2015-04-22 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com The code there just open-codes the same, so use the provided macro instead. Signed-off-by: Johannes Berg johannes.b...@intel.com --- net/ipv6/ip6_gre.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/ipv6/ip6_gre.c

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: MITSUHIRO KIMURA mitsuhiro.kimura...@renesas.com Date: Wed, 22 Apr 2015 05:04:13 + Hello Sergei. (2015/04/15 6:37:28), Sergei Shtylyov wrote: + if (!ravb_tx_free(ndev, q)) { + netif_warn(priv, tx_queued, ndev, TX FD exhausted.\n); +

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 16:54:32 Richard Cochran wrote: On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, getitimer, setitimer: all deprecated = wontfix If adjtimex is deprecated, what will replace it? It is

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
On 22/04/15 03:22, Shengzhou Liu wrote: RTL8211F needs to enalbe TXDLY for RGMII during phy initialization, so move it to rtl8211f_config for early initialization. Signed-off-by: Shengzhou Liu shengzhou@freescale.com cc: Joe Hershberger joe.hershber...@gmail.com ---

[PATCH] net: mdio-gpio: support access that may sleep

2015-04-22 Thread Vivien Didelot
Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not use IRQ handler, it is safe to use the _cansleep suffixed gpio accessors. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com

[Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- drivers/net/ethernet/intel/igb/igb_main.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Patch net] ixgbe: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Patch net] fm10k: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Patch net] ixgbevf: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 +++- 1 file changed, 3

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 21 Apr 2015 18:32:24 -0700 From: Eric Dumazet eduma...@google.com Using sk_stream_alloc_skb() in tcp_send_fin() is dangerous in case a huge process is killed by OOM, and tcp_mem[2] is hit. To be able to free memory we need to make

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 11:39:27 -0700 Note that in the unlikely case skb can not be allocated, if an already transmitted packet is in the write queue, we also can OR the FIN flag on it, and rely on normal rtx to deliver this FIN later. I'll cook a

Re: [PATCH net 0/2 v2] rhashtable rehashing fixes

2015-04-22 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Wed, 22 Apr 2015 09:41:44 +0200 Some rhashtable rehashing bugs found while testing with the next rhashtable self-test queued up for the next devel cycle: https://github.com/tgraf/net-next/commits/rht v2: - Moved schedule_work() call into

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 14:15 -0400, David Miller wrote: Wrt. longer term solutions, I would even be OK at this point aborting the connection altogether if the skb allocation fails period. Not just if TIF_MEMDIE is set. That endless loop has been nothing but trouble. Agreed. Note that in

Re: [PATCH net] bnx2x: Prevent inner-reload while VFs exist

2015-04-22 Thread David Miller
From: Yuval Mintz yuval.mi...@qlogic.com Date: Wed, 22 Apr 2015 12:47:32 +0300 On some feature changes, driver employes an inner-reload flow where it resets the function and re-configures it with the new required set of parameters. Such a flow proves fatal to any VF since those were not

Re: [PATCH v2 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 22 Apr 2015 11:47:10 -0500 Robert Shearman rshea...@brocade.com writes: V2: - don't treat loopback interfaces specially by enabling mpls by default These changes make mpls not be enabled by default on all interfaces when in

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 14:50 -0400, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 11:39:27 -0700 Note that in the unlikely case skb can not be allocated, if an already transmitted packet is in the write queue, we also can OR the FIN flag on it, and

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 07:33:36 -0700 Also, we must refrain using high order pages from the pfmemalloc reserve, so __page_frag_refill() must also use __GFP_NOMEMALLOC for them. Under memory pressure, using order-0 pages is probably the best strategy.

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 10:45 AM, Cong Wang wrote: The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- drivers/net/ethernet/intel/igb/igb_main.c |

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 12:12:20 -0700 On Wed, 2015-04-22 at 14:50 -0400, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 11:39:27 -0700 Note that in the unlikely case skb can not be allocated, if an already

Re: [PATCH] ip6_gre: use netdev_alloc_pcpu_stats()

2015-04-22 Thread David Miller
From: Johannes Berg johan...@sipsolutions.net Date: Wed, 22 Apr 2015 16:56:16 +0200 From: Johannes Berg johannes.b...@intel.com The code there just open-codes the same, so use the provided macro instead. Signed-off-by: Johannes Berg johannes.b...@intel.com Applied, thanks Johannes. -- To

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among

[PATCH] xfrm: fix the return code when xfrm_*_register_afinfo failed

2015-04-22 Thread roy . qing . li
From: Li RongQing roy.qing...@gmail.com If xfrm_*_register_afinfo failed since xfrm_*_afinfo[afinfo-family] had the value, return the -EEXIST, not -ENOBUFS Signed-off-by: Li RongQing roy.qing...@gmail.com --- net/xfrm/xfrm_input.c | 2 +- net/xfrm/xfrm_policy.c | 2 +- net/xfrm/xfrm_state.c |

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 04:23 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 02:56 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:33 PM, Cong Wang wrote:

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Alexei Starovoitov
On 4/22/15 4:39 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 3:22 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 10:02 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. Get rid

CCM/GCM implementation defect

2015-04-22 Thread Herbert Xu
Hi: It looks like our IPsec implementations of CCM and GCM are buggy in that they don't include the IV in the authentication calculation. This definitely breaks interoperability with anyone who implements them correctly. The fact that there have been no reports on this probably means that

Re: CCM/GCM implementation defect

2015-04-22 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Thu, 23 Apr 2015 11:26:20 +0800 In order to fix this without breaking backwards compatibility, my plan is to introduce new templates such as rfc4106v2 which implement the RFC correctly. The existing templates will be retained so that current

RE: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread shengzhou....@freescale.com
-Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, April 23, 2015 12:57 AM To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com Subject: Re: [PATCH] net/phy: refactor RTL8211F initialization On 22/04/15 03:22, Shengzhou

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 23 Apr 2015 00:38:56 +0300 On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 23 Apr 2015 01:34:32 +0300 Sigh... I'm seeing no way out of that then, only copying. :-( What exactly is the device's restriction? Any reasonable modern chip allows one of two things. Either it allows arbitrary alignment

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 02:56 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:33 PM, Cong Wang wrote: First, make sure you don't miss the TSIP case

Re: [RFC 1/3] tc: fix return values of ingress qdisc

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:04 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 9:59 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: ingress qdisc should return NET_XMIT_* values just like all other qdiscs. XMIT already means

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
Hello. On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit.

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 10:02 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. Get rid of redundant checks in all qdiscs. Instead do it once. The current code can be easily extended, while your code not.

[PATCH] net/macb: Factor out one-time assignment from loop

2015-04-22 Thread Ben Shelton
In 02c958dd3 (net/macb: add TX multiqueue support for gem), the initialization of tx_head and tx_tail in macb_init_rings() was moved inside the loop that iterates over each element in the ring. Since tx_head and tx_tail only need to be assigned once, move them back out of the loop.

Re: [PATCH] net/macb: Factor out one-time assignment from loop

2015-04-22 Thread David Miller
From: Ben Shelton ben.shel...@ni.com Date: Wed, 22 Apr 2015 17:28:54 -0500 In 02c958dd3 (net/macb: add TX multiqueue support for gem), the initialization of tx_head and tx_tail in macb_init_rings() was moved inside the loop that iterates over each element in the ring. Since tx_head and

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 01:33 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:14 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 10:45 AM, Cong Wang wrote: The

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Wed, 22 Apr 2015 23:46:52 +0300 Hello. On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/23/2015 01:41 AM, David Miller wrote: Sigh... I'm seeing no way out of that then, only copying. :-( What exactly is the device's restriction? The frame data must be aligned on 32-bit boundary. Any reasonable modern chip allows one of two things. Either it allows

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:22 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 10:02 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. Get rid of redundant checks in all qdiscs.

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Wed, 22 Apr 2015 23:30:02 +0300 Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields...

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit. But

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:33 PM, Cong Wang wrote: First, make sure you don't miss the TSIP case right above: The frag starting pointer and its size are advanced by: skb_frag_size_sub(frag, IGB_TS_HDR_LEN); ... va +=

Re: [RFC 1/3] tc: fix return values of ingress qdisc

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 9:59 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: ingress qdisc should return NET_XMIT_* values just like all other qdiscs. XMIT already means egress... may be then it should be renamed as well. from

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/23/2015 01:18 AM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit.

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 02:56 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:33 PM, Cong Wang wrote: First, make sure you don't miss the TSIP case right above: The frag starting pointer and its size are advanced by:

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Florian Fainelli
On 14/04/15 14:37, Sergei Shtylyov wrote: +/* Wait for stopping the hardware TX process */ +ravb_wait(ndev, TCCR, TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3, + 0); + +ravb_wait(ndev, CSR, CSR_TPO0 | CSR_TPO1 | CSR_TPO2 | CSR_TPO3, 0); + +/* Stop the

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
Le 22/04/2015 20:53, shengzhou@freescale.com a écrit : -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, April 23, 2015 12:57 AM To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com Subject: Re: [PATCH] net/phy: refactor

RE: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread shengzhou....@freescale.com
-Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, April 23, 2015 12:39 PM To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com Subject: Re: [PATCH] net/phy: refactor RTL8211F initialization Le 22/04/2015 20:53,

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among different qdiscs I don't think qdisc_drop_bypass() is more readable than without

Need help: Firmware(RT2870.bin) loading failed on backports/stable/v3.14 - (Firmware copied at /lib/firmware)

2015-04-22 Thread s prasad
Hi All, I am working on a project, in which need to enable wireless support. My system have following configuration: ARMv7 Processor(DLINK 868L router) Linux-2.6 Have taken package from https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.14/;. Am able to compile and load modules

[PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

2015-04-22 Thread David Gibson
AFAIK the PAPR document which defines the virtual device interface used by the ibmveth driver doesn't specify a specific maximum MTU. So, in the ibmveth driver, the maximum allowed MTU is determined by the maximum allocated buffer size of 64k (corresponding to one page in the common case) minus

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 10:45 AM, Cong Wang wrote: The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by:

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 15:35 -0400, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 07:33:36 -0700 Also, we must refrain using high order pages from the pfmemalloc reserve, so __page_frag_refill() must also use __GFP_NOMEMALLOC for them. Under memory

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 01:14 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 10:45 AM, Cong Wang wrote: The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 13:20:48 -0700 On Wed, 2015-04-22 at 15:35 -0400, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 22 Apr 2015 07:33:36 -0700 Also, we must refrain using high order pages from the pfmemalloc reserve,

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
Hello. On 04/22/2015 06:36 PM, David Miller wrote: + if (!ravb_tx_free(ndev, q)) { + netif_warn(priv, tx_queued, ndev, TX FD exhausted.\n); + netif_stop_queue(ndev); + spin_unlock_irqrestore(priv-lock, flags); +

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 01:14 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck alexander.du...@gmail.com wrote: On 04/22/2015 10:45 AM, Cong Wang wrote: The second parameter of eth_get_headlen() is

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 22 Apr 2015 07:07:54 -0700 On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: @@ -658,10 +659,18 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status) adapter-flags |= BE_FLAGS_LINK_STATUS_INIT; } -

Re: [PATCH][net-next] vxlan: remove the unnecessary codes

2015-04-22 Thread David Miller
From: roy.qing...@gmail.com Date: Wed, 22 Apr 2015 15:49:10 +0800 From: Li RongQing roy.qing...@gmail.com The return value of vxlan_fdb_replace always is greater than or equal to 0 Signed-off-by: Li RongQing roy.qing...@gmail.com Applied. -- To unsubscribe from this list: send the line

[PATCH 1/6] crypto: arm64/aes-ce-ccm - Include crypto/internal/aead.h

2015-04-22 Thread Herbert Xu
All implementers of AEAD should include crypto/internal/aead.h instead of include/linux/crypto.h. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- arch/arm64/crypto/aes-ce-ccm-glue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 6/6] mac802154: Include crypto/aead.h

2015-04-22 Thread Herbert Xu
All users of AEAD should include crypto/aead.h instead of include/linux/crypto.h. This patch also removes a bogus inclusion of algapi.h which should only be used by algorithm/driver implementors and not crypto users. Instead linux/crypto.h is added which is necessary because mac802154 also uses

[PATCH 3/6] crypto: tcrypt - Include crypto/aead.h

2015-04-22 Thread Herbert Xu
All users of AEAD should include crypto/aead.h instead of include/linux/crypto.h. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/tcrypt.c |1 + 1 file changed, 1 insertion(+) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 22cdd61..2bff613 100644 ---

[PATCH 2/6] crypto: algif_aead - Include crypto/aead.h

2015-04-22 Thread Herbert Xu
All users of AEAD should include crypto/aead.h instead of include/linux/crypto.h. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/algif_aead.c |1 + 1 file changed, 1 insertion(+) diff --git a/crypto/algif_aead.c b/crypto/algif_aead.c index 00a6fe1..53702e9 100644 ---

[PATCH 5/6] mac80211: Include crypto/aead.h

2015-04-22 Thread Herbert Xu
All users of AEAD should include crypto/aead.h instead of include/linux/crypto.h. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/mac80211/aes_ccm.c |3 +-- net/mac80211/aes_gcm.c |3 +-- net/mac80211/aes_gmac.c |2 +- 3 files changed, 3 insertions(+), 5 deletions(-)

[PATCH 4/6] crypto: testmgr - Include crypto/aead.h

2015-04-22 Thread Herbert Xu
All users of AEAD should include crypto/aead.h instead of include/linux/crypto.h. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/testmgr.c |1 + 1 file changed, 1 insertion(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 18b7d49..d463978 100644 ---

Re: [RFC PATCH 2/3] net/dsa: Allow probing dsa from usbnet

2015-04-22 Thread rajeev kumar
On Tue, Apr 21, 2015 at 6:56 PM, Jan Kaisrlik kaisr...@fel.cvut.cz wrote: From: Jan Kaisrlik ja.kaisr...@gmail.com This patch adds a function which helps to connect net device to DSA switch based on mii_bus and netdev. The switch parameters of the switch are configured in

Re: [PATCH] neighbour.c: Avoid GC directly after state change

2015-04-22 Thread Ulf Samuelsson
On 04/21/2015 05:58 AM, YOSHIFUJI Hideaki wrote: Ulf Samuelsson wrote: How many neighbors do you want to maintain? I guess you have to increase the number of gc_thresh1. The current use cases have up to 2048 entries. This is expected to grow in the future. The 3.4 kernel used in the system

[PATCH net 2/2] rhashtable: Do not schedule more than one rehash if we can't grow further

2015-04-22 Thread Thomas Graf
The current code currently only stops inserting rehashes into the chain when no resizes are currently scheduled. As long as resizes are scheduled and while inserting above the utilization watermark, more and more rehashes will be scheduled. This lead to a perfect DoS storm with thousands of

[PATCH net 1/2] rhashtable: Schedule async resize when sync realloc fails

2015-04-22 Thread Thomas Graf
When rhashtable_insert_rehash() fails with ENOMEM, this indicates that we can't allocate the necessary memory in the current context but the limits as set by the user would still allow to grow. Thus attempt an async resize in the background where we can allocate using GFP_KERNEL which is more

Re: [PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread Herbert Xu
On Wed, Apr 22, 2015 at 03:53:34PM +0800, roy.qing...@gmail.com wrote: From: Li RongQing roy.qing...@gmail.com If the walk from input is not empty, the following loop should start from the walk-next, since walk is list header, and the last policy in previours loop is connected walk tailor by

[PATCH v2 iproute2 1/3] tc: fix compilation warning on 32bits arch

2015-04-22 Thread Nicolas Dichtel
The warning was: m_simple.c: In function ‘parse_simple’: m_simple.c:142:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘size_t’ [-Wformat] Useful to be able to compile with -Werror. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: use %zu

[PATCH 0/6] crypto: Make all AEAD users include aead.h

2015-04-22 Thread Herbert Xu
Hi: This series adds inclusions of aead.h to all AEAD users including AEAD implementors (where it's internal/aead.h). This is necessary because I'll be adding an updated AEAD interface and that will live in aead.h instead of crypto.h. Dave, if it's OK with you I'd like to push the last two

Re: [Patch net] igb: fix a typo in igb_reset_q_vector()

2015-04-22 Thread Jeff Kirsher
On Tue, 2015-04-21 at 21:35 -0700, Cong Wang wrote: On Tue, Apr 21, 2015 at 5:29 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Wed, 2015-04-22 at 09:26 +0900, Toshiaki Makita wrote: Hi Cong Wang, I have already sent a patch to intel's tree.

Re: [PATCH v3] ethernet: myri10ge: use arch_phys_wc_add()

2015-04-22 Thread Hyong-Youb Kim
On Tue, Apr 21, 2015 at 01:09:45PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com This driver already uses ioremap_wc() on the same range so when write-combining is available that will be used instead. [...] Signed-off-by: Luis R. Rodriguez mcg...@suse.com Tested

[PATCH net 0/2 v2] rhashtable rehashing fixes

2015-04-22 Thread Thomas Graf
Some rhashtable rehashing bugs found while testing with the next rhashtable self-test queued up for the next devel cycle: https://github.com/tgraf/net-next/commits/rht v2: - Moved schedule_work() call into rhashtable_insert_rehash() Thomas Graf (2): rhashtable: Schedule async resize when

[PATCH] xfrm: remove the xfrm_queue_purge definition

2015-04-22 Thread roy . qing . li
From: Li RongQing roy.qing...@gmail.com The task of xfrm_queue_purge is same as skb_queue_purge, so remove it Signed-off-by: Li RongQing roy.qing...@gmail.com --- net/xfrm/xfrm_policy.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/net/xfrm/xfrm_policy.c

[PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread roy . qing . li
From: Li RongQing roy.qing...@gmail.com If the walk from input is not empty, the following loop should start from the walk-next, since walk is list header, and the last policy in previours loop is connected walk tailor by list_move_tail() Fixes: 12a169e7d8f(ipsec: Put dumpers on the dump list)

Re: [PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread Li RongQing
On Wed, Apr 22, 2015 at 3:57 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Signed-off-by: Li RongQing roy.qing...@gmail.com This is not a bug fix but an optimisation. The walker entries are all marked as dead and will be skipped by the loop. However, I don't see anything wrong with this

[PATCH v2 iproute2 2/3] libnamespaces: fix warning about syscall()

2015-04-22 Thread Nicolas Dichtel
The warning was: In file included from namespace.c:14:0: ../include/namespace.h: In function ‘setns’: ../include/namespace.h:37:2: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration] Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com ---

[PATCH v2 iproute2 3/3] mroute: remove invalid check against NLM_F_MULTI

2015-04-22 Thread Nicolas Dichtel
This flag is only for the netlink protocol (multi-part messages), no reason to reject messages without it. Note that this flag was removed by the following kernel patches (v3.14) 65886f439ab0 ipmr: fix mfc notification flags f518338b1603 ip6mr: fix mfc notification flags Signed-off-by: Nicolas

  1   2   >