Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-08 Thread Martin KaFai Lau
On Fri, Jun 05, 2015 at 06:11:33PM -0700, Eric Dumazet wrote: On Fri, 2015-06-05 at 17:46 -0700, Martin KaFai Lau wrote: The problem is caught by this WARN_ON(len skb-len) in tcp_fragment(): [810510ca] warn_slowpath_null+0x1a/0x20 [8160ec90] tcp_fragment+0x2a0/0x2b0

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread David Ahern
On 6/8/15 12:35 PM, Shrijeet Mukherjee wrote: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 019fcef..27a333c 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -283,6 +283,12 @@ config NLMON diagnostics, etc. This is mostly intended for developers or support

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
On Mo, 2015-06-08 at 21:58 +0200, Hannes Frederic Sowa wrote: Hi Shrijeet, On Mo, 2015-06-08 at 11:35 -0700, Shrijeet Mukherjee wrote: From: Shrijeet Mukherjee s...@cumulusnetworks.com Incoming frames for IP protocol stacks need the IIF to be changed from the actual interface to the

[PATCH net-next] net: phy: bcm7xxx: update workaround to fix 100BaseT corner cases

2015-06-08 Thread Florian Fainelli
Update the AFE_TX_CONFIG value to solve marginal rise/fall issues observed when the link is operating in 100BaseT. This workaround applies to GPHY revisions D0, E0 and newer. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/bcm7xxx.c | 7 +-- 1 file changed, 5

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-08 Thread Eric Dumazet
On Mon, 2015-06-08 at 10:58 -0700, Martin KaFai Lau wrote: It seems the invariant does not hold at this point also. Should the invariant fix be something for net-next? or Would you like to post a patch for it? This patch definitely can target net-next, it is not a new regression. Once fully

[RFC net-next 1/3] Symbol preparation for VRF driver

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee s...@cumulusnetworks.com This change is needed for the following VRF driver which creates a routing domain and allows applications to bind to the domain. No active code path changes. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com --- net/ipv4/fib_frontend.c

Re: [PATCH net] ipv6: fix possible use after free of dev stats

2015-06-08 Thread David Miller
From: Robert Shearman rshea...@brocade.com Date: Fri, 5 Jun 2015 18:51:54 +0100 The memory pointed to by idev-stats.icmpv6msgdev, idev-stats.icmpv6dev and idev-stats.ipv6 can each be used in an RCU read context without taking a reference on idev. For example, through IP6_*_STATS_* calls in

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
Hi Shrijeet, On Mo, 2015-06-08 at 11:35 -0700, Shrijeet Mukherjee wrote: From: Shrijeet Mukherjee s...@cumulusnetworks.com Incoming frames for IP protocol stacks need the IIF to be changed from the actual interface to the VRF device. This allows the IIF rule to be used to select tables (or

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-08 Thread David Ahern
On 6/8/15 12:35 PM, Shrijeet Mukherjee wrote: 5. Debugging is built-in as tcpdump and counters on the VRF device works as is. Is the intent that something like this tcpdump -i vrf0 can be used to see vrf traffic? vrf_handle_frame only bumps counters; it does not switch skb-dev to the

[PATCH] atm: use msecs_to_jiffies for conversions

2015-06-08 Thread Nicholas Mc Guire
API compliance scanning with coccinelle flagged: ./drivers/atm/iphase.c:2621:4-20: WARNING: timeout (50) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which does not seem intended. Fixed up by converting the constant to jiffies

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-08 Thread Florian Fainelli
On 08/06/15 07:04, Dan Murphy wrote: Florian Thanks for the re-review On 06/03/2015 09:47 PM, Florian Fainelli wrote: Le 06/02/15 07:34, Dan Murphy a écrit : Add support for the TI dp83867 Gigabit ethernet phy device. The DP83867 is a robust, low power, fully featured Physical Layer

[RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee s...@cumulusnetworks.com This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes

[RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee s...@cumulusnetworks.com Incoming frames for IP protocol stacks need the IIF to be changed from the actual interface to the VRF device. This allows the IIF rule to be used to select tables (or do regular PBR) This change selects the iif to be the VRF device if it exists

[PATCH net] net: bcmgenet: power on MII block for all MII modes

2015-06-08 Thread Florian Fainelli
The RGMII block is currently only powered on when using RGMII or RGMII_NO_ID, which is not correct when using the GENET interface in MII or Reverse MII modes. We always need to power on the RGMII interface for this block to properly work, regardless of the MII mode in which we operate. Fixes:

Re: [PATCH net] net: bcmgenet: power on MII block for all MII modes

2015-06-08 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Mon, 8 Jun 2015 10:47:57 -0700 The RGMII block is currently only powered on when using RGMII or RGMII_NO_ID, which is not correct when using the GENET interface in MII or Reverse MII modes. We always need to power on the RGMII interface for

Re: [PATCH v3] ipv6: Fix protocol resubmission

2015-06-08 Thread David Miller
From: Josh Hunt joh...@akamai.com Date: Mon, 8 Jun 2015 12:00:59 -0400 UDP encapsulation is broken on IPv6. This is because the logic to resubmit the nexthdr is inverted, checking for a ret value 0 instead of 0. Also, the resubmit label is in the wrong position since we already get the

Re: [PATCH net-next] net: replace last open coded skb_orphan_frags with function call

2015-06-08 Thread David Miller
From: Willem de Bruijn will...@google.com Date: Mon, 8 Jun 2015 11:53:08 -0400 From: Willem de Bruijn will...@google.com Commit 70008aa50e92 (skbuff: convert to skb_orphan_frags) replaced open coded tests of SKBTX_DEV_ZEROCOPY and skb_copy_ubufs with calls to helper function

[PATCH] net: phy: dp83867: Fix device tree entries

2015-06-08 Thread Dan Murphy
Fix the device tree entries to modify the '_' to '-'. Also changes the names of the internal delay properties from -int- to -internal- as the -int- appeared as a keyword. Signed-off-by: Dan Murphy dmur...@ti.com --- v1 - Fixed device tree entries and added data sheet reference per

[PATCH v2 net-next 2/2] tcp: add CDG congestion control

2015-06-08 Thread Kenneth Klette Jonassen
CAIA Delay-Gradient (CDG) is a TCP congestion control that modifies the TCP sender in order to [1]: o Use the delay gradient as a congestion signal. o Back off with an average probability that is independent of the RTT. o Coexist with flows that use loss-based congestion control, i.e.,

[PATCH v2 net-next 1/2] tcp: export tcp_enter_cwr()

2015-06-08 Thread Kenneth Klette Jonassen
Upcoming tcp_cdg uses tcp_enter_cwr() to initiate PRR. Export this function so that CDG can be compiled as a module. Cc: Eric Dumazet eduma...@google.com Cc: Yuchung Cheng ych...@google.com Cc: Stephen Hemminger step...@networkplumber.org Cc: Neal Cardwell ncardw...@google.com Cc: David Hayes

[RFC iproute2] Add the ability to create a VRF device and specify it's table binding.

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee s...@cumulusnetworks.com Modified from the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com --- include/linux/if_link.h |8 ip/Makefile |2 +- ip/iplink_vrf.c | 93

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-08 Thread Shrijeet Mukherjee
Good catch, as you know I used to have the device getting modified in the RX path and that made it all work generic ip_rcv will need a fix to make RX visible to tcpdump, but yes, that is the goal. On Mon, Jun 8, 2015 at 12:13 PM, David Ahern dsah...@gmail.com wrote: On 6/8/15 12:35 PM, Shrijeet

Contact us estonia_organizat...@yahoo.cl

2015-06-08 Thread fax
Good day, We are Christian organization, we give out laon to those who are in need, contact us via email at estonia_orgnizat...@yahoo.cl contact email estonia_organizat...@yahoo.cl This message was sent using IMP, the Internet

Re: [PATCH] net: phy: dp83867: Fix device tree entries

2015-06-08 Thread Florian Fainelli
On 08/06/15 12:30, Dan Murphy wrote: Fix the device tree entries to modify the '_' to '-'. Also changes the names of the internal delay properties from -int- to -internal- as the -int- appeared as a keyword. Signed-off-by: Dan Murphy dmur...@ti.com Reviewed-by: Florian Fainelli

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-08 Thread Hannes Frederic Sowa
On Mon, Jun 8, 2015, at 21:13, David Ahern wrote: On 6/8/15 12:35 PM, Shrijeet Mukherjee wrote: 5. Debugging is built-in as tcpdump and counters on the VRF device works as is. Is the intent that something like this tcpdump -i vrf0 can be used to see vrf traffic?

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

2015-06-08 Thread Samuel Ortiz
Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;}

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Tue, 09 Jun 2015 01:41:12 +0300 On 06/09/2015 01:19 AM, David Miller wrote: It's completely implemented in software, you don't need to do anything other than properly invoke napi_gro_receive(). Not even set NETIF_F_GRO?

Re: [PATCH] net: phy: dp83867: Fix device tree entries

2015-06-08 Thread David Miller
From: Dan Murphy dmur...@ti.com Date: Mon, 8 Jun 2015 14:30:55 -0500 Fix the device tree entries to modify the '_' to '-'. Also changes the names of the internal delay properties from -int- to -internal- as the -int- appeared as a keyword. Signed-off-by: Dan Murphy dmur...@ti.com --- v1

Re: [PATCH] atm: use msecs_to_jiffies for conversions

2015-06-08 Thread David Miller
From: Nicholas Mc Guire hof...@osadl.org Date: Mon, 8 Jun 2015 21:16:28 +0200 API compliance scanning with coccinelle flagged: ./drivers/atm/iphase.c:2621:4-20: WARNING: timeout (50) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
On Mon, Jun 8, 2015, at 22:22, Shrijeet Mukherjee wrote: On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: Hi Shrijeet, From an architectural level I think the output path looks good. For the input path I would also to propose my (I think) more

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Sergei Shtylyov
On 06/09/2015 01:19 AM, David Miller wrote: Furthermore, you should pass the NAPI context into ravb_rx() and use I guess I should have one NAPI context per RX queue? Yes. Thanks, done. it so that you can invoke napi_gro_receive() on all of the packets and therefore support GRO.

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: Hi Shrijeet, From an architectural level I think the output path looks good. For the input path I would also to propose my (I think) more flexible solution: For rx layer I want to also propose my try:

Re: [RFC 00/10] NFS: add AF_VSOCK support to NFS client

2015-06-08 Thread J. Bruce Fields
On Thu, Jun 04, 2015 at 05:45:43PM +0100, Stefan Hajnoczi wrote: This patch series enables AF_VSOCK address family support in the NFS client. Please use the https://github.com/stefanha/linux.git vsock-nfs branch, which contains the dependencies for this series. The AF_VSOCK address family

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Sergei Shtylyov
Hello. On 06/04/2015 06:12 AM, David Miller wrote: + /* Received network control queue */ + if (ris0 RIS0_FRF1) { + ravb_write(ndev, ~RIS0_FRF1, RIS0); + /* Timestamp of network control packets that is based +

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread David Miller
From: Hannes Frederic Sowa han...@stressinduktion.org Date: Tue, 09 Jun 2015 00:13:08 +0200 It is easy to move the rt_table_id to net_device and use the same one for IPv6. This would force people to build symmetric routing configurations. I was striving for maximum flexibility first but I

Re: [PATCH WIP RFC 0/3] mpls: support for ler

2015-06-08 Thread Thomas Graf
On 06/08/15 at 08:17am, roopa wrote: ack, that sounds intuitive. With RTA_ENCAP and the mpls examples i was using it looks something like the below for (1) ip route add 10.1.1.0/30 encap mpls 200 via 10.1.1.1 dev eth0 The tunnel dst is parsed and understood by the light weight tunnel

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
On Mon, Jun 8, 2015 at 1:33 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Mon, Jun 8, 2015, at 22:22, Shrijeet Mukherjee wrote: On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: Hi Shrijeet, This let's incoming and arp requests use

Re: [PATCH net-next] net: phy: bcm7xxx: update workaround to fix 100BaseT corner cases

2015-06-08 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Mon, 8 Jun 2015 11:05:20 -0700 Update the AFE_TX_CONFIG value to solve marginal rise/fall issues observed when the link is operating in 100BaseT. This workaround applies to GPHY revisions D0, E0 and newer. Signed-off-by: Florian Fainelli

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread David Miller
From: Hannes Frederic Sowa han...@stressinduktion.org Date: Mon, 08 Jun 2015 21:58:37 +0200 +static inline u32 ipv4_idev_rt_table(const struct net_device *dev) +{ + u32 table_id; + + rcu_read_lock(); + table_id = __in_dev_get_rcu(dev)-rt_table_id; +

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
On Tue, Jun 9, 2015, at 00:05, David Miller wrote: From: Hannes Frederic Sowa han...@stressinduktion.org Date: Mon, 08 Jun 2015 21:58:37 +0200 +static inline u32 ipv4_idev_rt_table(const struct net_device *dev) +{ + u32 table_id; + + rcu_read_lock(); + table_id =

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Tue, 09 Jun 2015 00:44:16 +0300 On 06/04/2015 06:12 AM, David Miller wrote: Furthermore, you should pass the NAPI context into ravb_rx() and use I guess I should have one NAPI context per RX queue? Yes. it so that you

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread Hannes Frederic Sowa
Hi, On Mo, 2015-06-08 at 11:35 -0700, Shrijeet Mukherjee wrote: From: Shrijeet Mukherjee s...@cumulusnetworks.com This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-08 Thread Jason Gunthorpe
On Mon, Jun 08, 2015 at 10:52:34AM +0300, Haggai Eran wrote: On 04/06/2015 19:40, Jason Gunthorpe wrote: Discussion idea: Can we actually use the netstack to process the RDMA-CM packets? It looks like the netstack wants a skb to do this mid-layer work, so rdma-cm would have to synthesize a

net-next: Panic in switchdev_port_attr_set_work+0x50/0x60

2015-06-08 Thread Brenden Blanco
Hi netdev! I am running a net-next kernel, compiled this morning, git hash of 6508060232ee78200a2258aefeeb148ce9ed1526. The distro is Arch linux latest. The issue is reproducible 100% of the time. I create a new Libvirt VM with some default options, no storage (i.e. 1 core, 1GB ram, PXE boot, 1

[GIT] Networking

2015-06-08 Thread David Miller
1) Fix stack allocation in s390 BPF JIT, from Michael Holzheu. 2) Disable LRO on openvswitch paths, from Jiri Benc. 3) UDP early demux doesn't handle multicast group membership properly, fix from Shawn Bohrer. 4) Fix TX queue hang due to incorrect handling of mixed sized fragments and

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Eric Dumazet
On Mon, 2015-06-08 at 15:43 -0700, David Miller wrote: From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Tue, 09 Jun 2015 01:41:12 +0300 On 06/09/2015 01:19 AM, David Miller wrote: It's completely implemented in software, you don't need to do anything other than properly

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread David Ahern
On 6/8/15 1:58 PM, Hannes Frederic Sowa wrote: Hi Shrijeet, On Mo, 2015-06-08 at 11:35 -0700, Shrijeet Mukherjee wrote: From: Shrijeet Mukherjee s...@cumulusnetworks.com Incoming frames for IP protocol stacks need the IIF to be changed from the actual interface to the VRF device. This allows

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread David Ahern
On 6/8/15 1:58 PM, Hannes Frederic Sowa wrote: For rx layer I want to also propose my try: [PATCH net-next RFC] net: ipv4: arp: strong end system model semantics by per-interface local table override I applied only the first 2 patches from Shrijeet and then tried to apply your patch; it

Re: [PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-08 Thread Pravin Shelar
On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert thomasfherb...@gmail.com wrote: Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. This patch needs to be merged with earlier patch since it is part of qinq

[PATCH net-next] s390/bpf: implement bpf_tail_call() helper

2015-06-08 Thread Alexei Starovoitov
From: Michael Holzheu holz...@linux.vnet.ibm.com bpf_tail_call() arguments: - ctx..: Context pointer - jmp_table: One of BPF_MAP_TYPE_PROG_ARRAY maps used as the jump table - index: Index in the jump table In this implementation s390x JIT does stack unwinding and jumps into the

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
Hi, On Tue, Jun 9, 2015, at 03:03, David Ahern wrote: On 6/8/15 1:58 PM, Hannes Frederic Sowa wrote: For rx layer I want to also propose my try: [PATCH net-next RFC] net: ipv4: arp: strong end system model semantics by per-interface local table override I applied only the first 2

Re: [PATCH v2 net-next 2/2] tcp: add CDG congestion control

2015-06-08 Thread Yuchung Cheng
On Mon, Jun 8, 2015 at 10:43 AM, Kenneth Klette Jonassen kenne...@ifi.uio.no wrote: CAIA Delay-Gradient (CDG) is a TCP congestion control that modifies the TCP sender in order to [1]: o Use the delay gradient as a congestion signal. o Back off with an average probability that is

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Hannes Frederic Sowa
On Tue, Jun 9, 2015, at 00:44, Shrijeet Mukherjee wrote: On Mon, Jun 8, 2015 at 1:33 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Mon, Jun 8, 2015, at 22:22, Shrijeet Mukherjee wrote: On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote:

Re: [PATCH] fib_trie: coding style: Use pointer after check

2015-06-08 Thread David Miller
From: Firo Yang fir...@gmail.com Date: Mon, 8 Jun 2015 11:54:51 +0800 As Alexander Duyck pointed out that: struct tnode { ... struct key_vector kv[1]; } The kv[1] member of struct tnode is an arry that refernced by a null pointer will not crash the system, like this:

Re: [PATCH V2] wan: dscc4: use msecs_to_jiffies for conversions

2015-06-08 Thread David Miller
From: Nicholas Mc Guire hof...@osadl.org Date: Sun, 7 Jun 2015 12:35:46 +0200 API compliance scanning with coccinelle flagged: ./drivers/net/wan/dscc4.c:1036:1-33: WARNING: timeout (10) seems HZ dependent ./drivers/net/wan/dscc4.c:554:2-34: WARNING: timeout (10) seems HZ

Re: [PATCH] cosa: use msecs_to_jiffies for conversions

2015-06-08 Thread David Miller
From: Nicholas Mc Guire der.h...@hofr.at Date: Sun, 7 Jun 2015 10:25:58 +0200 for the dscc4 case Im not sure - that seems to have gone in in 2.4 and that had HZ configurable. The cosa case was checked again 2.2.26 (no config HZ) and the timeout there was 30 - 300ms. I think that this is

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-08 Thread Haggai Eran
On 04/06/2015 19:40, Jason Gunthorpe wrote: Discussion idea: Can we actually use the netstack to process the RDMA-CM packets? It looks like the netstack wants a skb to do this mid-layer work, so rdma-cm would have to synthesize a skb for the CM packets and pass it through netdev to apply all

Re: [PATCH v4 0/3] net/phy: micrel: Center FLP timing at 16ms

2015-06-08 Thread David Miller
From: Jaeden Amero jaeden.am...@ni.com Date: Fri, 5 Jun 2015 18:00:23 -0500 In v2, we add an additional cleanup commit to make an array of strings static const and to improve const correctness generally. We also no longer unnecessarily initialize the result variable in

[RFC PATCH] cdc_ncm: support moving the NDP part of the frame to the end of NCM package

2015-06-08 Thread Enrico Mioso
The NCM specification as per http://www.usb.org/developers/docs/devclass_docs/NCM10_012011.zip does not define a fixed position for different frame parts. The NCM header is effectively the head of a list of NDPs (NCM datagram pointers), each of them pointing to a set of ethernet frames. In

Re: [RFC PATCH] cdc_ncm: support moving the NDP part of the frame to the end of NCM package

2015-06-08 Thread Oliver Neukum
On Mon, 2015-06-08 at 12:44 +0200, Enrico Mioso wrote: The NCM specification as per http://www.usb.org/developers/docs/devclass_docs/NCM10_012011.zip does not define a fixed position for different frame parts. The NCM header is effectively the head of a list of NDPs (NCM datagram pointers),

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Jesper Dangaard Brouer
On Mon, 8 Jun 2015 04:39:38 -0500 (CDT) Christoph Lameter c...@linux.com wrote: On Mon, 8 Jun 2015, Jesper Dangaard Brouer wrote: My real question is if disabling local interrupts is enough to avoid this? Yes the initial release of slub used interrupt disable in the fast paths. Thanks

Re: kmalloc panic

2015-06-08 Thread Johannes Berg
On Sat, 2015-06-06 at 19:10 -0400, Toan Pham wrote: I am experiencing a similar issue on another system (at91sam9n12) that uses Redpine Signal Wireless Driver 1.1.0. I do not know the root cause yet, but it may be related to the Redpine Signals driver. Will update this mailing list if the

Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any

2015-06-08 Thread Nicolas Dichtel
Le 04/06/2015 14:01, Thadeu Lima de Souza Cascardo a écrit : If a tunnel is created with a local address, you can't change it to any. # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl 64 # ip tunnel show tunl1 tunl1: ip/ip remote 10.16.42.37 local 10.16.42.214

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Christoph Lameter
On Mon, 8 Jun 2015, Jesper Dangaard Brouer wrote: My real question is if disabling local interrupts is enough to avoid this? Yes the initial release of slub used interrupt disable in the fast paths. And, does local irq disabling also stop preemption? Of course. -- To unsubscribe from this

Re: [5/9] wl1251: drop unneeded goto

2015-06-08 Thread Kalle Valo
From: Julia Lawall julia.law...@lip6.fr Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier l; @@ -if (...) goto l;

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Jesper Dangaard Brouer
On Thu, 04 Jun 2015 19:37:57 -0700 Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-06-04 at 12:31 +0200, Jesper Dangaard Brouer wrote: This patch improves performance of SLUB allocator fastpath with 38% by avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels.

[PATCH v3] ARM: pxa: ssp: remove unnessary free for devm_xxx

2015-06-08 Thread Firo Yang
A Coccinelle warning. It's not necessary to free memory allocated with devm_xxx and using these free functions maybe lead to a double free that will corrupt the resource subsys. So, I just remove them. Signed-off-by: Firo Yang fir...@gmail.com --- In [PATCH] ARM: pxa: ssp: remove unnessary free

Re: [PATCH v3] ARM: pxa: ssp: remove unnessary free for devm_xxx

2015-06-08 Thread Firo Yang
Sorry, please, ignore this patch. I send it to the wrong receiver. On Mon, Jun 08, 2015 at 05:37:10PM +0800, Firo Yang wrote: A Coccinelle warning. It's not necessary to free memory allocated with devm_xxx and using these free functions maybe lead to a double free that will corrupt the resource

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-08 Thread Dan Murphy
Florian Thanks for the re-review On 06/03/2015 09:47 PM, Florian Fainelli wrote: Le 06/02/15 07:34, Dan Murphy a écrit : Add support for the TI dp83867 Gigabit ethernet phy device. The DP83867 is a robust, low power, fully featured Physical Layer transceiver with integrated PMD sublayers

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
On Fri, Jun 05, 2015 at 02:08:05PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we break the lock inversion between netns_sctp-addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can

Re: [PATCH WIP RFC 0/3] mpls: support for ler

2015-06-08 Thread Thomas Graf
On 06/05/15 at 07:54pm, roopa wrote: On 6/5/15, 8:26 AM, Robert Shearman wrote: It isn't clear to me what the strategy here is for dealing with tunnel encaps that aren't bound to an interface. Thomas, I presume you would prefer not to force the user to keep track of changes to the output

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch,

Re: [PATCH net-next 2/2] tcp: add CDG congestion control

2015-06-08 Thread Kenneth Klette Jonassen
On Sat, Jun 6, 2015 at 7:01 PM, Yuchung Cheng ych...@google.com wrote: On Fri, Jun 5, 2015 at 1:23 PM, Kenneth Klette Jonassen kenne...@ifi.uio.no wrote: nice patch. I would like to review it more thoroughly but I have some quick comments. given that cdg didn't include hystart. it'd be nice

Re: [PATCH WIP RFC 0/3] mpls: support for ler

2015-06-08 Thread roopa
On 6/8/15, 5:33 AM, Thomas Graf wrote: Yes, the information used to determine the encapsulation and the route used to select the outgoing interface might be coming from different components. A simple and typical example is if you are running quagga to for your underlay which determines which

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015,

Re: [PATCH net] ipv6: fix possible use after free of dev stats

2015-06-08 Thread Hannes Frederic Sowa
On Fr, 2015-06-05 at 18:51 +0100, Robert Shearman wrote: The memory pointed to by idev-stats.icmpv6msgdev, idev-stats.icmpv6dev and idev-stats.ipv6 can each be used in an RCU read context without taking a reference on idev. For example, through IP6_*_STATS_* calls in ip6_rcv. These memory

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Hannes Frederic Sowa
Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we break the lock inversion between netns_sctp-addr_wq_lock and

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: From: Marcelo

Re: [PATCH net-next] net: replace last open coded skb_orphan_frags with function call

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 11:53:08AM -0400, Willem de Bruijn wrote: From: Willem de Bruijn will...@google.com Commit 70008aa50e92 (skbuff: convert to skb_orphan_frags) replaced open coded tests of SKBTX_DEV_ZEROCOPY and skb_copy_ubufs with calls to helper function skb_orphan_frags. Apply that

Re: [PATCH v3] ipv6: Fix protocol resubmission

2015-06-08 Thread Tom Herbert
On Mon, Jun 8, 2015 at 9:00 AM, Josh Hunt joh...@akamai.com wrote: UDP encapsulation is broken on IPv6. This is because the logic to resubmit the nexthdr is inverted, checking for a ret value 0 instead of 0. Also, the resubmit label is in the wrong position since we already get the nexthdr

[PATCH net-next] net: replace last open coded skb_orphan_frags with function call

2015-06-08 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Commit 70008aa50e92 (skbuff: convert to skb_orphan_frags) replaced open coded tests of SKBTX_DEV_ZEROCOPY and skb_copy_ubufs with calls to helper function skb_orphan_frags. Apply that to the last remaining open coded site. Signed-off-by: Willem de Bruijn

[PATCH v3] ipv6: Fix protocol resubmission

2015-06-08 Thread Josh Hunt
UDP encapsulation is broken on IPv6. This is because the logic to resubmit the nexthdr is inverted, checking for a ret value 0 instead of 0. Also, the resubmit label is in the wrong position since we already get the nexthdr value when performing decapsulation. In addition the skb pull is no