Re: [PATCH v2 1/3] net: mvneta: introduce compatible string marvell,armada-xp-neta

2015-06-29 Thread Gregory CLEMENT
Hi Simon, On 17/06/2015 15:19, Simon Guinot wrote: The mvneta driver supports the Ethernet IP found in the Armada 370, XP, 380 and 385 SoCs. Since at least one more hardware feature is available for the Armada XP SoCs then a way to identify them is needed. This patch introduces a new

Re: [PATCH] sock: honor GFP_ATOMIC when allocating send skbs

2015-06-29 Thread Eric Dumazet
On Mon, 2015-06-29 at 15:06 +0200, Jason A. Donenfeld wrote: Some sockets set sock-sk-sk_allocation = GFP_ATOMIC. In spite of this, functions that call sock_alloc_send_skb will then call sock_alloc_send_pskb, which very often results in sleeping. Since the intention of callers setting

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string marvell, armada-xp-neta

2015-06-29 Thread Gregory CLEMENT
Hi Jason, Simon, On 25/06/2015 15:20, Jason Cooper wrote: On Thu, Jun 25, 2015 at 11:13:23AM +0200, Simon Guinot wrote: On Fri, Jun 19, 2015 at 02:32:53PM +0200, Simon Guinot wrote: On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote: On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory

Re: [PATCH v2 2/3] ARM: mvebu: update Ethernet compatible string for Armada XP

2015-06-29 Thread Gregory CLEMENT
Hi Simon, This patch updates the Ethernet DT nodes for Armada XP SoCs with the compatible string marvell,armada-xp-neta. Signed-off-by: Simon Guinot simon.gui...@sequanux.org Cc: sta...@vger.kernel.org # v3.8+ Acked-by: Gregory CLEMENT gregory.clem...@free-electrons.com Thanks, Gregory

Re: [PATCH] sock: honor GFP_ATOMIC when allocating send skbs

2015-06-29 Thread Jason A. Donenfeld
Hi Eric, Thanks for your feedback on this. The precise problem is a BUG in the scheduler code when sleep is called from atomic context, due to having to wait on that allocation. This is triggered by a module I'm writing. I'm probably doing something I shouldn't... I'm calling udp_sendmsg from

[PATCH] sock: honor GFP_ATOMIC when allocating send skbs

2015-06-29 Thread Jason A. Donenfeld
Some sockets set sock-sk-sk_allocation = GFP_ATOMIC. In spite of this, functions that call sock_alloc_send_skb will then call sock_alloc_send_pskb, which very often results in sleeping. Since the intention of callers setting sk_allocation = GFP_ATOMIC might be to be able to send from atomic

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
Hi Tejun, On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo t...@kernel.org wrote: --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2196,6 +2227,7 @@ out: */ void console_unlock(void) { + static char ext_text[CONSOLE_EXT_LOG_MAX]; Can you please a) make this feature

Re: [PATCH RFC] tun, macvtap: higher order allocations for skbs

2015-06-29 Thread Jason Wang
On 06/29/2015 12:50 PM, Jason Wang wrote: On 06/18/2015 06:20 PM, Michael S. Tsirkin wrote: Needs more testing. Anyone see anything wrong with this? Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- 2 files changed, 2

Re: [PATCH RFC] net/unix: SO_REUSEPORT for AF_UNIX

2015-06-29 Thread Conrad Hoffmann
Hi, On 06/29/2015 06:05 AM, Alex Gartrell wrote: On Sun, Jun 28, 2015 at 2:52 AM, Conrad Hoffmann c...@bitfehler.net wrote: Support the SO_REUSEPORT option for AF_UNIX (aka AF_LOCAL) sockets. Note that unlike the IP implementations, the semantics for AF_UNIX sockets are those of the original

[net-next]vmxnet3: Bump up driver version number

2015-06-29 Thread Shreyas Bhatewara
Bump up the driver version number to reflect the changes done to work with vmxnet3 adapter version 2 Signed-off-by: Shreyas N Bhatewara sbhatew...@vmware.com --- diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index e9f1075..2652245 100644 ---

Re: [PATCH RFC net-next] vxlan: GRO support at tunnel layer

2015-06-29 Thread Rick Jones
On 06/28/2015 10:20 AM, Ramu Ramamurthy wrote: Rick, in your test, are you seeing gro becoming effective on the vxlan interface with the 82599ES nic ? (ie, tcpdump on the vxlan interface shows larger frames than the mtu of that interface, and kernel trace shows vxlan_gro_receive() being hit)

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
Hi Tejun, On Mon, Jun 29, 2015 at 5:28 PM, Tejun Heo t...@kernel.org wrote: On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo t...@kernel.org wrote: --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2196,6 +2227,7

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: netconsole itself is optional modular. I'm not sure making further splits is called for, especially given the use cases. It could be a hidden option, selected by its users (e.g. netconsole). Hmmm... what do you mean?

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
Hello, On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo t...@kernel.org wrote: --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2196,6 +2227,7 @@ out: */ void console_unlock(void) { + static char

Re: [PATCH RFC net-next] vxlan: GRO support at tunnel layer

2015-06-29 Thread Rick Jones
On 06/28/2015 02:31 PM, Tom Herbert wrote: You're comparing apples to oranges. Please test the patch in your environment I posted and report results. Please also test with multiple connections, single connection performance can be misleading and does not really reflect what real production

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread josh
On Mon, Jun 29, 2015 at 11:49:14AM -0400, Tejun Heo wrote: On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: netconsole itself is optional modular. I'm not sure making further splits is called for, especially given the use cases. It could be a hidden option,

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Geert Uytterhoeven
On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo t...@kernel.org wrote: On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: netconsole itself is optional modular. I'm not sure making further splits is called for, especially given the use cases. It could be a hidden option,

Unable to unregister netdevice after netfilter: bridge: forward IPv6 fragmented packets

2015-06-29 Thread Julien Grall
Hi, I tried to run the latest Linux tree (4a10a91756ef381bced7b88cfb9232f660b92d93) as DOM0 Xen. After destroying a guest using network, I got the following lines in the DOM0 kernel log: unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1 The bisector pointed the problem

Re: [PATCH resend] sctp: Fix race between OOTB responce and route removal

2015-06-29 Thread David Miller
From: Alexander Sverdlin alexander.sverd...@nokia.com Date: Mon, 29 Jun 2015 10:41:03 +0200 There is NULL pointer dereference possible during statistics update if the route used for OOTB responce is removed at unfortunate time. If the route exists when we receive OOTB packet and we finally

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread josh
On Mon, Jun 29, 2015 at 12:13:55PM -0400, Tejun Heo wrote: On Mon, Jun 29, 2015 at 06:11:40PM +0200, Geert Uytterhoeven wrote: On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo t...@kernel.org wrote: On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: netconsole itself is

Re: [PATCH 3/3] printk: implement support for extended console drivers

2015-06-29 Thread Tejun Heo
On Mon, Jun 29, 2015 at 06:11:40PM +0200, Geert Uytterhoeven wrote: On Mon, Jun 29, 2015 at 5:49 PM, Tejun Heo t...@kernel.org wrote: On Mon, Jun 29, 2015 at 05:47:49PM +0200, Geert Uytterhoeven wrote: netconsole itself is optional modular. I'm not sure making further splits is called

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

2015-06-29 Thread David Miller
From: Tom Lendacky thomas.lenda...@amd.com Date: Mon, 29 Jun 2015 11:22:12 -0500 When allocating Rx related buffers, alloc_pages is called using an order number that is decreased until successful. A system under stress can experience failures during this allocation process resulting in a

Re: [net-next]vmxnet3: Bump up driver version number

2015-06-29 Thread David Miller
From: Shreyas Bhatewara sbhatew...@vmware.com Date: Mon, 29 Jun 2015 04:14:43 -0700 (PDT) Subject: [net-next]vmxnet3: Bump up driver version number From: Shreyas Bhatewara sbhatew...@vmware.com To: netdev@vger.kernel.org cc: pv-driv...@vmware.com Date: Mon, 29 Jun 2015 04:14:43 -0700

Re: [PATCH] net-Liquidio: Delete unnecessary checks before the function call vfree

2015-06-29 Thread David Miller
From: SF Markus Elfring elfr...@users.sourceforge.net Date: Mon, 29 Jun 2015 12:48:16 +0200 From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 29 Jun 2015 12:22:24 +0200 The vfree() function performs also input parameter validation. Thus the test around the call is not needed.

[PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

2015-06-29 Thread Tom Lendacky
When allocating Rx related buffers, alloc_pages is called using an order number that is decreased until successful. A system under stress can experience failures during this allocation process resulting in a warning being issued. This message can be of concern to end users even though the failure

[PATCH] netfilter: nf_nat: Fix possible null dereference

2015-06-29 Thread subashab
Fix an issue where __nf_ct_ext_find() could return null to nat in nf_nat_masquerade_ipv4() and could be dereferenced. This was detected by static analysis software. Signed-off-by: Subash Abhinov Kasiviswanathan subas...@codeaurora.org --- net/ipv4/netfilter/nf_nat_masquerade_ipv4.c | 2 ++ 1

Re: [Pv-drivers] [net-next]vmxnet3: Bump up driver version number

2015-06-29 Thread Thomas Hellstrom
On 06/29/2015 01:14 PM, Shreyas Bhatewara wrote: Bump up the driver version number to reflect the changes done to work with vmxnet3 adapter version 2 Signed-off-by: Shreyas N Bhatewara sbhatew...@vmware.com Reviewed-by: Thomas Hellstrom thellst...@vmware.com --- diff --git

Re: [PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h

2015-06-29 Thread Pablo Neira Ayuso
On Thu, Jun 25, 2015 at 11:12:06PM -0400, Stephen Hemminger wrote: This fixes breakage to iproute2 build with recent kernel headers caused by: commit a263653ed798216c0069922d7b5237ca49436007 Author: Pablo Neira Ayuso pa...@netfilter.org Date: Wed Jun 17 10:28:27 2015 -0500

Re: Unable to unregister netdevice after netfilter: bridge: forward IPv6 fragmented packets

2015-06-29 Thread Florian Westphal
Julien Grall julien.gr...@citrix.com wrote: Hi, I tried to run the latest Linux tree (4a10a91756ef381bced7b88cfb9232f660b92d93) as DOM0 Xen. After destroying a guest using network, I got the following lines in the DOM0 kernel log: unregister_netdevice: waiting for vif1.0 to become free.

Re: [PATCH] net: icplus: fix typo in constant name

2015-06-29 Thread David Miller
From: Nik Nyby niko...@gnu.org Date: Mon, 29 Jun 2015 18:40:08 -0400 This fixes a typo in the IPG_FRAMETOOLONGERRORS constant. Signed-off-by: Nik Nyby niko...@gnu.org Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

2015-06-29 Thread Tom Lendacky
On 06/29/2015 11:27 AM, David Miller wrote: From: Tom Lendacky thomas.lenda...@amd.com Date: Mon, 29 Jun 2015 11:22:12 -0500 When allocating Rx related buffers, alloc_pages is called using an order number that is decreased until successful. A system under stress can experience failures during

[PATCH] net: icplus: fix typo in constant name

2015-06-29 Thread Nik Nyby
This fixes a typo in the IPG_FRAMETOOLONGERRORS constant. Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/net/ethernet/icplus/ipg.c | 2 +- drivers/net/ethernet/icplus/ipg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/icplus/ipg.c

[PATCH] sis900: Trivial: Fix typos in enums

2015-06-29 Thread Nik Nyby
reigster - register Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/net/ethernet/sis/sis900.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.h b/drivers/net/ethernet/sis/sis900.h index 1341f33..7d430d3 100644 ---

Re: [PATCH] stmmac: Trivial: fix typo in constant name

2015-06-29 Thread David Miller
From: Nik Nyby niko...@gnu.org Date: Mon, 29 Jun 2015 15:39:27 -0400 This fixes a typo in the MMC_RX_CRC_ERROR constant. Signed-off-by: Nik Nyby niko...@gnu.org Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH RFC net-next] vxlan: GRO support at tunnel layer

2015-06-29 Thread Rick Jones
I went ahead and put the patched kernel on both systems. I was getting mixed results - in one direction, results in the 8Gbit/s range, in the other in the 7 Gbit/s. I noticed that interrupts were going to different CPUs so I started playing with IRQ assignments, and bound all interrupts of

Re: [PATCH net] net: do not process device backlog during unregistration

2015-06-29 Thread Julian Anastasov
Hello, On Sun, 28 Jun 2015, Eric W. Biederman wrote: Julian Anastasov j...@ssi.bg writes: commit 381c759d9916 (ipv4: Avoid crashing in ip_error) fixes a problem where processed packet comes from device with destroyed inetdev (dev-ip_ptr). This is not expected because

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

2015-06-29 Thread David Miller
From: Tom Lendacky thomas.lenda...@amd.com Date: Mon, 29 Jun 2015 16:47:55 -0500 On 06/29/2015 11:27 AM, David Miller wrote: From: Tom Lendacky thomas.lenda...@amd.com Date: Mon, 29 Jun 2015 11:22:12 -0500 When allocating Rx related buffers, alloc_pages is called using an order number that

Re: [PATCH] sis900: Trivial: Fix typos in enums

2015-06-29 Thread David Miller
From: Nik Nyby niko...@gnu.org Date: Mon, 29 Jun 2015 15:49:43 -0400 reigster - register Signed-off-by: Nik Nyby niko...@gnu.org Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] - vxlan: gro not effective for intel 82599

2015-06-29 Thread Ramu Ramamurthy
On 2015-06-28 14:17, Tom Herbert wrote: On Sun, Jun 28, 2015 at 1:19 PM, Or Gerlitz gerlitz...@gmail.com wrote: On Fri, Jun 26, 2015 at 10:59 PM, Tom Herbert t...@herbertland.com wrote: [...] Looks like GRO was never implemented for vxlan tunnels. The driver is simply calling netif_rx instead

Re: [PATCH 1/2] clocksource: Kconfig: replace USE_OF with OF

2015-06-29 Thread Daniel Lezcano
On 06/17/2015 01:42 PM, Antonio Borneo wrote: USE_OF is used as intermediate Kconfig option by few arch's (ARM, MIPS, Xtensa); in all these cases it implies setting option OF too. Replace the only instance of USE_OF in clocksource with OF. Signed-off-by: Antonio Borneo borneo.anto...@gmail.com

[PATCH] build: must honor pkg-config flags for libmnl

2015-06-29 Thread Jan Engelhardt
The build otherwise fails if libmnl does not directly live in a standard search path. --- tipc/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tipc/Makefile b/tipc/Makefile index 4bda8c5..d4637f8 100644 --- a/tipc/Makefile +++ b/tipc/Makefile @@ -5,8 +5,11 @@

[PATCH resend] sctp: Fix race between OOTB responce and route removal

2015-06-29 Thread Alexander Sverdlin
There is NULL pointer dereference possible during statistics update if the route used for OOTB responce is removed at unfortunate time. If the route exists when we receive OOTB packet and we finally jump into sctp_packet_transmit() to send ABORT, but in the meantime route is removed under our

[PATCH iproute2] include: add copy of tipc.h

2015-06-29 Thread Michal Kubecek
Copy of kernel include/uapi/linux/tipc.h is needed to build on systems with pre-3.16 kernel headers. Signed-off-by: Michal Kubecek mkube...@suse.cz --- include/linux/tipc.h | 232 +++ 1 file changed, 232 insertions(+) create mode 100644

Re: [PATCH 3.10.y 0/2] ipv6: avoid soft lockups in fib6_run_gc()

2015-06-29 Thread Greg KH
On Wed, Jun 10, 2015 at 01:40:42PM +0300, Konstantin Khlebnikov wrote: Two patches from 3.11 which are missing in 3.10.y I've just seen livelock in 3.10.69+ where all cpus are stuck in fib6_run_gc() As David doesn't queue up network patches for 3.10-stable anymore (and I don't blame him),

[PATCH v2 net] api: fix compatibility of linux/in.h with netinet/in.h

2015-06-29 Thread Stephen Hemminger
u This fixes breakage to iproute2 build with recent kernel headers caused by: commit a263653ed798216c0069922d7b5237ca49436007 Author: Pablo Neira Ayuso pa...@netfilter.org Date: Wed Jun 17 10:28:27 2015 -0500 netfilter: don't pull include/linux/netfilter.h from netns headers The

Re: [PATCH RFC net-next] vxlan: GRO support at tunnel layer

2015-06-29 Thread Jesse Gross
On Mon, Jun 29, 2015 at 1:04 PM, Rick Jones rick.jon...@hp.com wrote: PS FWIW, if I shift from using just the linux native vxlan to a mostly full set of OpenStack compute node plumbing - two OVS bridges and a linux bridge and associated plumbing with a vxlan tunnel defined in OVS, but nothing

Caller or callee setting skb-network_header?

2015-06-29 Thread Linus Lüssing
Hi, For an .ndo_start_xmit handler, can the callee rely on the caller setting the skb network header? Or should the callee set it before performing any skb_network_header()/ip_hdr()/ipv6_hdr()/... calls? Cheers, Linus PS: Currently looking at batman-adv's ndo_start_xmit handler interface_tx(),

Re: [PATCH v2 net] api: fix compatibility of linux/in.h with netinet/in.h

2015-06-29 Thread David Miller
From: Stephen Hemminger step...@networkplumber.org Date: Mon, 29 Jun 2015 14:57:48 -1000 u This fixes breakage to iproute2 build with recent kernel headers caused by: commit a263653ed798216c0069922d7b5237ca49436007 Author: Pablo Neira Ayuso pa...@netfilter.org Date: Wed Jun 17

Hello

2015-06-29 Thread brian . girling
Am writing you regarding a deceased clients of ours that shares the same surname as yours. Please reply to siegelsanth...@hotmail.com for more info. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v4.2-rc1] printk: make extended printk support conditional on netconsole

2015-06-29 Thread Tejun Heo
6fe29354befe (printk: implement support for extended console drivers) implemented extended printk support for extended netconsole. The code added was miniscule but it added static 8k buffer unconditionally unnecessarily bloating the kernel for cases where extended netconsole is not used. This

Re: [PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h

2015-06-29 Thread Stephen Hemminger
On Mon, 29 Jun 2015 20:07:20 +0200 Pablo Neira Ayuso pa...@netfilter.org wrote: On Thu, Jun 25, 2015 at 11:12:06PM -0400, Stephen Hemminger wrote: This fixes breakage to iproute2 build with recent kernel headers caused by: commit a263653ed798216c0069922d7b5237ca49436007 Author:

Re: [PATCH net] net: bcmgenet: power on MII block for all MII modes

2015-06-29 Thread Florian Fainelli
On 28/06/15 20:27, David Miller wrote: From: Florian Fainelli f.faine...@gmail.com Date: Fri, 26 Jun 2015 10:38:31 -0700 The RGMII block is currently only powered on when using RGMII or RGMII_NO_ID, which is not correct when using the GENET interface in MII or Reverse MII modes. We always

Re: [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, and vlan parsing

2015-06-29 Thread Pravin Shelar
On Tue, Jun 23, 2015 at 11:26 AM, Thomas F Herbert thomasfherb...@gmail.com wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged

Re: [PATCH RFC net-next] vxlan: GRO support at tunnel layer

2015-06-29 Thread Eric Dumazet
On Mon, 2015-06-29 at 13:04 -0700, Rick Jones wrote: PS FWIW, if I shift from using just the linux native vxlan to a mostly full set of OpenStack compute node plumbing - two OVS bridges and a linux bridge and associated plumbing with a vxlan tunnel defined in OVS, but nothing above the

[PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])

2015-06-29 Thread Maninder Singh
Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0]) Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Yogesh Narayan Gaur yn.g...@samsung.com --- drivers/net/ethernet/intel/igb/e1000_phy.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] stmmac: Trivial: fix typo in constant name

2015-06-29 Thread Nik Nyby
This fixes a typo in the MMC_RX_CRC_ERROR constant. Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c