Re: [PATCH iproute2 2/3] ip-link: fix and extend documentation

2015-08-13 Thread vkochan
On Wed, Aug 12, 2015 at 10:04:07PM +0200, Pavel Šimerda wrote: From: Pavel Šimerda psime...@redhat.com * Add `can` to list of supported link types * Document `addrgenmode` * Document `link-netnsid` * Document VLAN link type * Improve VXLAN link type documentation - Fix VXLAN

[PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-13 Thread Martin KaFai Lau
This patch series fixes a potential deadlock when creating a pcpu rt. It happens when dst_alloc() decided to run gc. Something like this: read_lock(table-tb6_lock); ip6_rt_pcpu_alloc() = dst_alloc() = ip6_dst_gc() = write_lock(table-tb6_lock); /* oops */ Patch 1 and 2 are some prep works. Patch

[PATCH RFC net 3/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-13 Thread Martin KaFai Lau
rt6_make_pcpu_route() is called under read_lock(table-tb6_lock). rt6_make_pcpu_route() calls ip6_rt_pcpu_alloc(rt) which then calls dst_alloc(). dst_alloc() _may_ call ip6_dst_gc() which takes the write_lock(tabl-tb6_lock). A visualized version: read_lock(table-tb6_lock); rt6_make_pcpu_route();

[PATCH RFC net 2/3] ipv6: Add rt6_make_pcpu_route()

2015-08-13 Thread Martin KaFai Lau
It is a prep work for the potential deadlock. The current rt6_get_pcpu_route() will also create a pcpu rt if one does not exist. This patch moves the pcpu rt creation logic into another function, rt6_make_pcpu_route(). Signed-off-by: Martin KaFai Lau ka...@fb.com CC: Hannes Frederic Sowa

[PATCH RFC net 1/3] ipv6: Remove un-used argument from ip6_dst_alloc()

2015-08-13 Thread Martin KaFai Lau
After 4b32b5ad31a6 (ipv6: Stop rt6_info from using inet_peer's metrics), ip6_dst_alloc() does not need the 'table' argument. This patch cleans it up. Signed-off-by: Martin KaFai Lau ka...@fb.com CC: Hannes Frederic Sowa han...@stressinduktion.org --- net/ipv6/route.c | 21 +

[PATCH 2/2] mac80211: use DECLARE_EWMA

2015-08-13 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com Instead of using the out-of-line average calculation, use the new DECLARE_EWMA() macro to declare a signal EWMA, and use that. This actually *reduces* the code size slightly (on x86-64) while also reducing the station info size by 80 bytes.

[PATCH iproute2] ip-link: remove unnecessary return

2015-08-13 Thread Zhang Shengju
Remove unnecessary retrun, because invarg() exit. Signed-off-by: Zhang Shengju zhangshen...@cmss.chinamobile.com --- ip/iplink_bridge.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c index

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: Add ACPI bindings for the smsc911x driver. Convert the DT specific calls to nonspecific device* calls, This allows the driver to work with both ACPI and DT configurations. Ethernet should now work when using ACPI on ARM Juno.

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-13 Thread Hanjun Guo
On 08/12/2015 11:36 PM, David Daney wrote: On 08/12/2015 08:23 AM, Catalin Marinas wrote: On Tue, Aug 11, 2015 at 01:04:55PM -0700, David Daney wrote: On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney ddaney.c...@gmail.com Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1:

Re: [PATCH v2 11/11] net: rfkill: Allow compile test of GPIO consumers if !GPIOLIB

2015-08-13 Thread Johannes Berg
On Sun, 2015-08-02 at 11:09 +0200, Geert Uytterhoeven wrote: The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the

Re: Problem with fragmented packets on tun/tap interface

2015-08-13 Thread Prashant Upadhyaya
On Fri, Jul 31, 2015 at 4:51 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Fri, 2015-07-31 at 16:42 +0530, Prashant Upadhyaya wrote: On Fri, Jul 31, 2015 at 1:26 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Fri, 2015-07-31 at 12:30 +0530, Prashant Upadhyaya wrote: The delays work

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-13 Thread Siva Reddy (Siva) Kallam
On 8/12/2015 6:02 PM, Douglas Miller wrote: Oh, I had missed the extra if condition on tg3_test_link(). So external_lb is not a true superset of offline. So you are not surprised by the (about) 20 second link down period after this test? If this is expected (albeit undocumented) behavior we

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Vlastimil Babka
On 08/13/2015 10:58 AM, mho...@kernel.org wrote: From: Michal Hocko mho...@suse.com The patch c48a11c7ad26 (netvm: propagate page-pfmemalloc to skb) added the checks for page-pfmemalloc to __skb_fill_page_desc(): if (page-pfmemalloc !page-mapping) skb-pfmemalloc =

[PATCH iproute2] ip-link: enhance prompt message

2015-08-13 Thread Zhang Shengju
Enhance promtp message for 'spoofchk' and 'query_rss' flag, and fix a typo. Signed-off-by: Zhang Shengju zhangshen...@cmss.chinamobile.com --- ip/iplink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ip/iplink.c b/ip/iplink.c index 1836889..520f750 100644 ---

[PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread mhocko
From: Michal Hocko mho...@suse.com The patch c48a11c7ad26 (netvm: propagate page-pfmemalloc to skb) added the checks for page-pfmemalloc to __skb_fill_page_desc(): if (page-pfmemalloc !page-mapping) skb-pfmemalloc = true; It assumes page-mapping == NULL implies that

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Lorenzo Pieralisi
On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: Add ACPI bindings for the smsc911x driver. Convert the DT specific calls to nonspecific device* calls, This allows the driver to work with both ACPI and DT

[PATCH 1/2] average: provide macro to create static EWMA

2015-08-13 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com Having the EWMA parameters stored in the runtime struct imposes memory requirements for the constant values that could just be inlined in the code. This particularly makes sense if there are a lot of such structs, for example in mac80211 in the station

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Michal Hocko
On Thu 13-08-15 11:13:04, Vlastimil Babka wrote: On 08/13/2015 10:58 AM, mho...@kernel.org wrote: From: Michal Hocko mho...@suse.com The patch c48a11c7ad26 (netvm: propagate page-pfmemalloc to skb) added the checks for page-pfmemalloc to __skb_fill_page_desc(): if

Re: [net-next PATCH 2/3] ARM: dts: dra7: update cpsw compatible

2015-08-13 Thread Tony Lindgren
* Mugunthan V N mugunthan...@ti.com [150812 02:56]: CPSW driver has been updated with compatibles for enabling errata workarounds. So updating cpsw compatibles. Signed-off-by: Mugunthan V N mugunthan...@ti.com Please feel free to merge this one via net tree once the changes are reviewed:

Re: [net-next PATCH 3/3] ARM: dts: am33xx: update cpsw compatible

2015-08-13 Thread Tony Lindgren
* Mugunthan V N mugunthan...@ti.com [150812 02:56]: CPSW driver has been updated with compatibles for enabling errata workarounds. So updating cpsw compatibles. Signed-off-by: Mugunthan V N mugunthan...@ti.com This too: Acked-by: Tony Lindgren t...@atomide.com ---

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Mel Gorman
On Thu, Aug 13, 2015 at 10:58:54AM +0200, mho...@kernel.org wrote: From: Michal Hocko mho...@suse.com The patch c48a11c7ad26 (netvm: propagate page-pfmemalloc to skb) added the checks for page-pfmemalloc to __skb_fill_page_desc(): if (page-pfmemalloc !page-mapping)

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-13 Thread Johannes Berg
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: +static const char *rfkill_types[NUM_RFKILL_TYPES] = { + [RFKILL_TYPE_WLAN] = wlan, + [RFKILL_TYPE_BLUETOOTH] = bluetooth, + [RFKILL_TYPE_UWB] = ultrawideband, + [RFKILL_TYPE_WIMAX] = wimax, +

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
On Thu, Aug 13, 2015 at 10:01:17AM +0100, Lorenzo Pieralisi wrote: On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: Add ACPI bindings for the smsc911x driver. Convert the DT specific calls to nonspecific device*

Re: [Cluster-devel] [PATCH 4/6] dlm: use sctp 1-to-1 API

2015-08-13 Thread Steven Whitehouse
Hi, On 12/08/15 17:42, Marcelo Ricardo Leitner wrote: Em 12-08-2015 12:33, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 12 August 2015 14:16 Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11 August 2015 23:22 DLM is using 1-to-many API but in a

[PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Andy Whitcroft
When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into account that the 0th entry is the header. This leads us to

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Lorenzo Pieralisi
On Thu, Aug 13, 2015 at 10:38:38AM +0100, Graeme Gregory wrote: On Thu, Aug 13, 2015 at 10:01:17AM +0100, Lorenzo Pieralisi wrote: On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: Add ACPI bindings for the

[GIT] Networking

2015-08-13 Thread David Miller
1) Workaround hw bug when acquiring PCI bos ownership of iwlwifi devices, from Emmanuel Grumbach. 2) Falling back to vmalloc in conntrack should not emit a warning, from Pablo Neira Ayuso. 3) Fix NULL deref when rtlwifi driver is used as an AP, from Luis Felipe Dominguez Vega. 4)

Re: [PATCH 1/2] Add a matching set of device_ functions for determining mac/phy

2015-08-13 Thread Robin Murphy
Hi Jeremy, On 12/08/15 23:06, Jeremy Linton wrote: [...] +static void *device_get_mac_addr(struct device *dev, +const char *name, char *addr, +int alen) +{ + int ret = device_property_read_u8_array(dev, name, addr, alen); + +

Re: [Cluster-devel] [PATCH 4/6] dlm: use sctp 1-to-1 API

2015-08-13 Thread Marcelo Ricardo Leitner
Em 13-08-2015 06:37, Steven Whitehouse escreveu: Hi, On 12/08/15 17:42, Marcelo Ricardo Leitner wrote: Em 12-08-2015 12:33, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 12 August 2015 14:16 Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11

Re: ath9k_htc: drv_init: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-13 Thread Heikki Krogerus
Hi, On Thu, Aug 13, 2015 at 11:27:46AM +0200, Johannes Berg wrote: On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: +static const char *rfkill_types[NUM_RFKILL_TYPES] = { + [RFKILL_TYPE_WLAN] = wlan, + [RFKILL_TYPE_BLUETOOTH] = bluetooth, + [RFKILL_TYPE_UWB]

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-08-13 Thread Johannes Berg
On Thu, 2015-07-30 at 08:55 +0300, Emmanuel Grumbach wrote: On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui zhonghui...@linux.intel.com wrote: Enable wiphy device to suspend/resume asynchronously. This can improve system suspend/resume speed. How will that impact the timing with

[PATCH net] ppp: fix device unregistration upon netns deletion

2015-08-13 Thread Guillaume Nault
PPP devices may get automatically unregistered when their network namespace is getting removed. This happens if the ppp control plane daemon (e.g. pppd) exits while it is the last user of this namespace. This leads to several races: * ppp_exit_net() may destroy the per namespace idr

Re: [PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-08-13 Thread Johannes Berg
On Tue, 2015-07-28 at 10:30 +0200, Adrien Schildknecht wrote: At the last iteration of the loop, j may equal zero and thus tp_list[j - 1] causes an invalid read. Changed the logic of the loop so that j - 1 is always = 0. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Applied, I

Re: [V2] rtlwifi: misspelled code and comments corrected.

2015-08-13 Thread Kalle Valo
Signed-off-by: Cheolhyun Park pch851...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ath9k_htc: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage

[PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common bug of LAN87xx family of PHY chips. * The lan87xx_read_status() was

Re: [2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-08-13 Thread Kalle Valo
There's already a generic implementation so use that instead. Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-13 Thread Douglas Miller
Very interesting. I was running a RHEL 7.1 kernel 3.10.0-229.ael7b.ppc64le (PowerPC). tg3 version 3.137, firmware 5719-v1.24i, but unknown what patches were added to either of our modules. We will investigate the environment more, under the assumption that we should not be required to insert

Re: [PATCH] mac80211_hwsim: unregister genetlink family properly

2015-08-13 Thread Johannes Berg
On Fri, 2015-08-07 at 16:54 +0800, Su Kang Yin wrote: During hwsim_init_netlink(), we should call genl_unregister_family() if failed on netlink_register_notifier() since the genetlink is already registered. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe netdev

[PATCH net-next 2/2] ppp: implement x-netns support

2015-08-13 Thread Guillaume Nault
Let packets move from one netns to the other at PPP encapsulation and decapsulation time. PPP units and channels remain in the netns in which they were originally created. Only the net_device may move to a different namespace. Cross netns handling is thus transparent to lower PPP layers (PPPoE,

[PATCH net-next 1/2] ppp: fix device unregistration upon netns deletion

2015-08-13 Thread Guillaume Nault
PPP devices may get automatically unregistered when their network namespace is getting removed. This happens if the ppp control plane daemon (e.g. pppd) exits while it is the last user of this namespace. This leads to several races: * ppp_exit_net() may destroy the per namespace idr

[PATCH net-next 0/2] ppp: implement x-netns support

2015-08-13 Thread Guillaume Nault
This series allows PPP devices to reside in a different netns from the PPP unit/channels. Packets only cross netns boundaries when they're transmitted between the net_device and the PPP unit (units and channels always remain in their creation namespace). So only PPP units need to handle cross

Re: ath9k_htc: wmi: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage

Re: ath9k: match wait_for_completion_timeout return type

2015-08-13 Thread Kalle Valo
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-13 Thread Jesper Dangaard Brouer
On Thu, 13 Aug 2015 03:13:40 +0200 Phil Sutter p...@nwl.cc wrote: On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: In general 'changing the default' may be an acceptable thing, but then it needs to strongly justified. How much performance does it bring? A quick test

[PATCH net] gianfar: Restore link state settings after MAC reset

2015-08-13 Thread Claudiu Manoil
There are some MAC registers that need to be kept in sync with the link state parameters, see adjust_link(). However, after a MAC soft reset default values for these registers are assumed. In some cases (excepting if down/ if up for example) adjust_link() does not see that these values were reset

Re: [PATCH net-next 0/3] mpls: multipath support

2015-08-13 Thread Robert Shearman
On 13/08/15 03:07, roopa wrote: On 8/12/15, 10:30 AM, Robert Shearman wrote: On 11/08/15 22:45, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com This patch series adds multipath support to mpls routes. resembles ipv4 multipath support. The multipath route nexthop selection

Re: [PATCH net-next 1/3] mpls: move mpls_route nexthop fields to a new nhlfe struct

2015-08-13 Thread Robert Shearman
On 13/08/15 04:16, roopa wrote: On 8/12/15, 12:15 PM, Robert Shearman wrote: On 11/08/15 22:45, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com moves mpls_route nexthop fields to a new mpls_nhlfe struct. mpls_nhlfe represents a mpls nexthop label forwarding entry. It prepares

Re: Problem with fragmented packets on tun/tap interface

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 12:52 +0530, Prashant Upadhyaya wrote: Hi, I think I have a clue to the root cause of my issue, but I do not know a solution. Let me describe what I think is the problem. Fragmented packets enter into the kernel through eth0 and the kernel starts assembling them.

Re: [PATCH 1/2] Add a matching set of device_ functions for determining mac/phy

2015-08-13 Thread Jeremy Linton
Hello Robin, On 08/13/2015 06:57 AM, Robin Murphy wrote: +static void *device_get_mac_addr(struct device *dev, +const char *name, char *addr, +int alen) +{ + int ret = device_property_read_u8_array(dev, name, addr, alen); + +

[PATCH net-next v2 1/2] net: track link status of ipv6 nexthops

2015-08-13 Thread Andy Gospodarek
Add support to track current link status of ipv6 nexthops to match recent changes that added support for ipv4 nexthops. This takes a simple approach to track linkdown status for next-hops and simply checks the dev for the dst entry and sets proper flags that to be used in the netlink message.

[PATCH net-next v2 2/2] net: ipv6 sysctl option to ignore routes when nexthop link is down

2015-08-13 Thread Andy Gospodarek
Like the ipv4 patch with a similar title, this adds a sysctl to allow the user to change routing behavior based on whether or not the interface associated with the nexthop was an up or down link. The default setting preserves the current behavior, but anyone that enables it will notice that

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Philip Downey
Hi David Thanks for taking the time to review and comment. This is my first upstream request so please forgive any ignorance on my part. I have added a new proposed commit wording below with a view to agreeing the content before resubmitting the patch. I hope it is sufficient to address your

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote: Given that this apparently isn't the first case of this localhost issue, I wonder if network code should just clear skb-pfmemalloc during send (or maybe just send over localhost). That would be probably easier than distinguish the

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-13 Thread Phil Sutter
On Thu, Aug 13, 2015 at 03:10:33PM +0200, Jesper Dangaard Brouer wrote: On Thu, 13 Aug 2015 03:13:40 +0200 Phil Sutter p...@nwl.cc wrote: On Tue, Aug 11, 2015 at 06:13:49PM -0700, Alexei Starovoitov wrote: In general 'changing the default' may be an acceptable thing, but then it

Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote: When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Philip Downey
Hi Andrew IGMP snooping is designed to prevent hosts on a local network from receiving traffic for a multicast group they have not explicitly joined. Link-Local multicast traffic should not have an IGMP client since it is reserved for routing protocols. One would expect that IGMP snooping

[PATCH net-next 3/7] net: dsa: mv88e6xxx: add VLAN Get Next support

2015-08-13 Thread Vivien Didelot
Implement the port_pvid_get and vlan_getnext driver functions required to dump VLAN entries from the hardware, with the VTU Get Next operation. Some functions and structure will be shared with STU operations, since their table format are similar (e.g. STU data entries are accessible with the same

[PATCH net-next 4/7] net: dsa: mv88e6xxx: add VLAN support to FDB dump

2015-08-13 Thread Vivien Didelot
Add an helper function to read the next valid VLAN entry for a given port. It is used in the VID to FID conversion function to retrieve the forwarding database assigned to a given VLAN port. Finally update the FDB getnext operation to iterate on the next valid port VLAN when the end of the

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: Hi Andrew IGMP snooping is designed to prevent hosts on a local network from receiving traffic for a multicast group they have not explicitly joined. Link-Local multicast traffic should not have an IGMP client since it is

[PATCH 2/2] net: sch_generic: react upon IFF_NO_QUEUE flag

2015-08-13 Thread Phil Sutter
Handle IFF_NO_QUEUE as alternative to tx_queue_len being zero. Signed-off-by: Phil Sutter p...@nwl.cc --- net/sched/sch_generic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 6efca30..942fea8 100644 ---

[PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Phil Sutter
This series adds a new private net_device flag indicating that a device may (and probably should) be used without a queueing discipline attached to it. This is already common practice for many virtual device types like e.g. loopback, VLAN (802.1Q) or bridges (802.1D). The reason for this is that

[PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE

2015-08-13 Thread Phil Sutter
This private net_device flag can be set by drivers to inform that a device runs fine without a qdisc attached. This was formerly done by setting tx_queue_len to zero. Signed-off-by: Phil Sutter p...@nwl.cc --- include/linux/netdevice.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH net-next 7/7] net: dsa: mv88e6xxx: use port 802.1Q mode Secure

2015-08-13 Thread Vivien Didelot
This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6xxx.c | 14 +++--- drivers/net/dsa/mv88e6xxx.h | 5

[PATCH net-next 6/7] net: dsa: mv88e6xxx: add VLAN Load support

2015-08-13 Thread Vivien Didelot
Implement port_pvid_set and port_vlan_add to add new entries in the VLAN hardware table, and join ports to them. The patch also implement the STU Get Next and Load Purge operations, since it is required to have a valid STU entry for at least all VLANs. Each VLAN has its own forwarding database,

[PATCH net-next 1/7] net: dsa: add support for switchdev VLAN objects

2015-08-13 Thread Vivien Didelot
Add new functions in DSA drivers to access hardware VLAN entries through SWITCHDEV_OBJ_PORT_VLAN objects: - port_pvid_get() and vlan_getnext() to dump a VLAN - port_vlan_del() to exclude a port from a VLAN - port_pvid_set() and port_vlan_add() to join a port to a VLAN The DSA infrastructure

[PATCH] net: allow sleeping when modifying store_rps_map

2015-08-13 Thread Sasha Levin
Commit 10e4ea751 (net: Fix race condition in store_rps_map) has moved the manipulation of the rps_needed jump label under a spinlock. Since changing the state of a jump label may sleep this is incorrect and causes warnings during runtime. Make rps_map_lock a mutex to allow sleeping under it.

[PATCH 6/6] ethernet/s2io: advertise what hw supports in vlan_features

2015-08-13 Thread Jarod Wilson
For some reason, the s2io driver has never filled in vlan_features. If that's fully intentional, then this patch should be dropped. If its not, then this patch is necessary to maintain some functionality of slave s2io devices in a bonding group. Without this, the presence of a s2io device in a

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Joe Perches
On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common bug of

[PATCH 2/6] ethernet/bnx2x: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a bnx2x device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Ariel Elior

[PATCH 5/6] ethernet/qlcnic: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a qlcnic device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Shahed Shaikh

[PATCH net-next 2/7] net: dsa: mv88e6xxx: flush VTU and STU entries

2015-08-13 Thread Vivien Didelot
Implement the VTU Flush operation (which also flushes the STU), so that warm boots won't preserved old entries. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6xxx.c | 34 ++ drivers/net/dsa/mv88e6xxx.h | 2 ++ 2 files

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear Joe, On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Stephen Hemminger
On Thu, 13 Aug 2015 19:01:05 +0200 Phil Sutter p...@nwl.cc wrote: Up to now, drivers being aware of the above applying to them set dev-tx_queue_len to zero to indicate no qdisc should be attached to the interface they drive and the kernel reacts upon this by assigning the noop qdisc instead

[PATCH 4/6] ethernet/netxen: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a netxen device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Manish Chopra

[PATCH 3/6] ethernet/ixgbe: advertise LRO support in vlan_features

2015-08-13 Thread Jarod Wilson
Without this, the presence of a ixgbe device in a bond will not trigger LRO support to be enabled at the bond level, even while it is enabled on the slave itself. This change becomes necessary when NETIF_F_LRO is added to netdev_features.h's NETIF_F_ONE_FOR_ALL. CC: Jeff Kirsher

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Thadeu Lima de Souza Cascardo
On Thu, Aug 13, 2015 at 07:01:37PM +0200, Andrew Lunn wrote: On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: Hi Andrew IGMP snooping is designed to prevent hosts on a local network from receiving traffic for a multicast group they have not explicitly joined. Link-Local

[PATCH net-next 0/3] net: Identifier Locator Addressing - Part I

2015-08-13 Thread Tom Herbert
This patch set provides rudimentary support for Identifier Locator Addressing or ILA. The basic concept of ILA is that we split an IPv6 address into a 64 bit locator and 64 bit identifier. The identifier is the identity of an entity in communication (who), and the locator expresses the location of

[PATCH net-next 1/3] lwt: Add support to redirect dst.input

2015-08-13 Thread Tom Herbert
This patch adds the capability to redirect dst input in the same way that dst output is redirected by LWT. Also, save the original dst.input and and dst.out when setting up lwtunnel redirection. These can be called by the client as a pass- through. Signed-off-by: Tom Herbert t...@herbertland.com

[PATCH net-next 3/3] net: Identifier Locator Addressing module

2015-08-13 Thread Tom Herbert
Adding new module name ila. This implements ILA translation. Light weight tunnel redirection is used to perform the translation in the data path. This is configured by the ip -6 route command using the encap ila locator option, where locator is the value to set in destination locator of the

[PATCH net-next 2/3] net: Add inet_proto_csum_replace_by_diff utility function

2015-08-13 Thread Tom Herbert
This function updates a checksum field value and skb-csum based on a value which is the difference between the old and new checksum. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/checksum.h | 2 ++ net/core/utils.c | 13 + 2 files changed, 15 insertions(+)

[PATCH net-next 5/7] net: dsa: mv88e6xxx: add VLAN Purge support

2015-08-13 Thread Vivien Didelot
Add support for the VTU Load Purge operation and implement the port_vlan_del driver function to remove a port from a VLAN entry, and delete the VLAN if the given port was its last member. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6352.c | 1 +

[PATCH net-next 0/7] net: dsa: mv88e6xxx: add hardware VLAN support

2015-08-13 Thread Vivien Didelot
Hi All, This patchset brings support to access hardware VLAN entries in DSA and mv88e6xxx, through switchdev VLAN objects. In the following example, ports swp[0-2] belong to bridge br0, and ports swp[3-4] belong to bridge br1. Here's an example of what can be achieved after this patchset: #

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 13 Aug 2015 10:15:15 -0700 On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote: On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy

Re: [PATCH] net: allow sleeping when modifying store_rps_map

2015-08-13 Thread Tom Herbert
On Thu, Aug 13, 2015 at 11:03 AM, Sasha Levin sasha.le...@oracle.com wrote: Commit 10e4ea751 (net: Fix race condition in store_rps_map) has moved the manipulation of the rps_needed jump label under a spinlock. Since changing the state of a jump label may sleep this is incorrect and causes

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Joe Perches
On Thu, 2015-08-13 at 20:11 +0300, Igor Plyatov wrote: On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-13 Thread Jesper Dangaard Brouer
On Thu, 13 Aug 2015 10:49:50 -0700 Stephen Hemminger step...@networkplumber.org wrote: On Thu, 13 Aug 2015 19:01:05 +0200 Phil Sutter p...@nwl.cc wrote: Up to now, drivers being aware of the above applying to them set dev-tx_queue_len to zero to indicate no qdisc should be attached to the

[PATCH 0/6] bonding: only advertise LRO if underlying hardware can LRO

2015-08-13 Thread Jarod Wilson
At present, you can create a bond, containing only underlying slaves that do not support LRO, and the bond will happily claim to support LRO, and allow LRO to be toggled on and off by ethtool. While things actually do function fine in the scenario, and this is merely cosmetic, its a bit misleading

Re: [PATCH net-next v2 1/2] tcp: don't extend RTO on failed loss probe attempts

2015-08-13 Thread Eric Dumazet
On Wed, 2015-08-12 at 11:18 -0700, Yuchung Cheng wrote: If TLP was unable to send a probe, it extended the RTO to now + icsk_rto. But extending the RTO makes little sense if no TLP probe went out. With this commit, instead of extending the RTO we re-arm it relative to the transmit time of the

[PATCH 1/6] net/bonding: enable LRO if one device supports it

2015-08-13 Thread Jarod Wilson
Currently, all bonding devices come up, and claim to have LRO support, which ethtool will let you toggle on and off, even if none of the underlying hardware devices actually support it. While the bonding driver takes precautions for slaves that don't support all features, this is at least a little

Re: [PATCHv3 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-13 Thread Pravin Shelar
On Wed, Aug 12, 2015 at 4:41 PM, Joe Stringer joestrin...@nicira.com wrote: On 12 August 2015 at 16:00, Pravin Shelar pshe...@nicira.com wrote: On Tue, Aug 11, 2015 at 3:59 PM, Joe Stringer joestrin...@nicira.com wrote: From: Justin Pettit jpet...@nicira.com Allow matching and setting the

[PATCH net] inet: fix potential deadlock in reqsk_queue_unlink()

2015-08-13 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com When replacing del_timer() with del_timer_sync(), I introduced a deadlock condition : reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop() inet_csk_reqsk_queue_drop() can be called from many contexts, one being the timer handler itself

Re: [PATCH 0/2] Enable smsc911x for use with ACPI

2015-08-13 Thread David Miller
From: Jeremy Linton jeremy.lin...@arm.com Date: Wed, 12 Aug 2015 17:06:25 -0500 This set of patches enables the front Ethernet port on the ARM Juno development platform when used with an ACPI enabled kernel. These patches covert the of_property* calls in the driver to the DT/ACPI agnostic

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear David and Joe, thank you for patch review! Please look at email with subject [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging Best wishes. -- Igor Plyatov From: Joe Perches j...@perches.com Date: Thu, 13 Aug 2015 10:15:15 -0700 On Thu,

Re: kernel warning in tcp_fragment

2015-08-13 Thread Jovi Zhangwei
Hi, On Wed, Aug 12, 2015 at 8:45 PM, Martin KaFai Lau ka...@fb.com wrote: On Mon, Aug 10, 2015 at 02:35:37PM -0400, Neal Cardwell wrote: On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei j...@cloudflare.com wrote: Ping? We saw a lot of this warnings in our production system. It would be

[PATCH] net/fsl: simplify Kconfig dependency list for fsl networking

2015-08-13 Thread Stuart Yoder
make the list of Kconfig dependencies for Freescale networking more general. Simplify to supported architectures: ARM, ARM64, PPC, M68K Signed-off-by: Stuart Yoder stuart.yo...@freescale.com --- drivers/net/ethernet/freescale/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

Re: [PATCH net-next 5/6] geneve: Consolidate Geneve functionality in single module.

2015-08-13 Thread Pravin Shelar
On Thu, Aug 13, 2015 at 2:24 PM, Jesse Gross je...@nicira.com wrote: On Wed, Aug 12, 2015 at 4:33 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross je...@nicira.com wrote: The farther I go in the series, the more that I hope that we can avoid the use of

Re: [PATCH net-next v2 0/2] minor tail loss probe improvements

2015-08-13 Thread David Miller
From: Yuchung Cheng ych...@google.com Date: Wed, 12 Aug 2015 11:18:17 -0700 This patch series enhance the tail loss probe (TLP) on some error conditions. When TLP fails to send a probe, it will no longer extend the RTO. When it fails to send a new packet because of receiver window limit,

Re: [PATCH] Revert net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 14:21 -0700, Calvin Owens wrote: Commit 8133534c760d4083 (net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN) modified four sysctls to enforce that the values written to them are not less than SOCK_MIN_{RCV,SND}BUF. ... This reverts commit

  1   2   >