[PATCH] ip: find correct route for socket which is not bound to a device

For multi-cast, we should find valid route(thus get the meaniful pmtu) for the package on the socket which is not bound to a device(sk_bound_dev_if being 0) too. >From man page of socket(7) SO_BINDTODEVICE Bind this socket to a particular device like “eth0”, as

[PATCH v2 net-next 0/2] bpf: performance improvements

v1->v2: dropped redundant iff_up check in patch 2 At plumbers we discussed different options on how to get rid of skb_clone from bpf_clone_redirect(), the patch 2 implements the best option. Patch 1 adds 'integrated exts' to cls_bpf to improve performance by combining simple actions into bpf

[PATCH v2 net-next 2/2] bpf: add bpf_redirect() helper

Existing bpf_clone_redirect() helper clones skb before redirecting it to RX or TX of destination netdev. Introduce bpf_redirect() helper that does that without cloning. Benchmarked with two hosts using 10G ixgbe NICs. One host is doing line rate pktgen. Another host is configured as: $ tc qdisc

[PATCH v2 net-next 1/2] cls_bpf: introduce integrated actions

From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classid and action. For backwards compatibility reasons enable this feature under TCA_BPF_FLAG_ACT_DIRECT flag. Then more interesting

[PATCH v2 1/1] eventfd: implementation of EFD_MASK flag

From: Martin Sustrik When implementing network protocols in user space, one has to implement fake file descriptors to represent the sockets for the protocol. Polling on such fake file descriptors is a problem (poll/select/epoll accept only true file descriptors) and forces

[PATCH v2 0/1] Generalize poll events from eventfd

Using eventfd user space can generate POLLIN/POLLOUT events but some applications may want to generate POLLPRI/POLLERR events as well. This patch submission aims to generalize the events generated by an eventfd. This is a resubmission of a patch from Feb 2013[1]. The original discussion trailed

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

>>Do you have a bond in your system ?. Yes, Indeed. Removing the bond fix the problem. I'll try your patch today. Thanks ! Alexandre - Mail original - De: "roopa" À: "aderumier" Cc: "netdev" , "Scott Feldman"

Re: [PATCH v2 net-next 2/2] bpf: add bpf_redirect() helper

On 15-09-15 11:05 PM, Alexei Starovoitov wrote: > Existing bpf_clone_redirect() helper clones skb before redirecting > it to RX or TX of destination netdev. > Introduce bpf_redirect() helper that does that without cloning. > > Benchmarked with two hosts using 10G ixgbe NICs. > One host is doing

Re: bnx2x - occasional high packet loss (on LAN)

On Wed, Sep 16, 2015 at 08:15:41AM +, Ariel Elior wrote: > Hi Nikola, > Please provide dmesg output from your system. > Thanks, > Ariel Hello Ariel, here it is: http://nik.lbox.cz/download/dmesg.txt BR nik > -- - Ing. Nikola CIPRICH LinuxBox.cz,

[PATCH v4] add stealth mode

Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. Signed-off-by: Matteo Croce

Re: [PATCH v2 1/1] eventfd: implementation of EFD_MASK flag

On 2015-09-16 08:27, Damian Hobson-Garcia wrote: From: Martin Sustrik When implementing network protocols in user space, one has to implement fake file descriptors to represent the sockets for the protocol. Polling on such fake file descriptors is a problem

Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

On Wed, Sep 09, 2015 at 09:14:42AM -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote: > > The stmmac driver use lots of pr_xxx functions to print information. > > This is bad since we cannot know which device logs the information. > > (moreover if two stmmac

Re: [PATCH] net: smc91x: convert pxa dma to dmaengine

David Miller writes: > From: Robert Jarzmik > Date: Thu, 10 Sep 2015 21:26:04 +0200 > >> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >> slave driver. This makes this driver a bit more PXA agnostic. >> >> The driver was

request for stable inclusion

Hi Dave, Commit 9293267 "net/mlx4_core: Capping number of requested MSIXs to MAX_MSIX" fixes a bug under which the driver doesn't really starts over a machine with > 32 cores. The bug was introduced in 4.2-rc1 but the fix missed 4.2 -- could you please push it to 4.2 -stable? If you

vhost: build failure

Hi, While crosscompiling the kernel for openrisc with allmodconfig the build failed with the error: drivers/vhost/vhost.c: In function 'vhost_vring_ioctl': drivers/vhost/vhost.c:818:3: error: call to '__compiletime_assert_818' declared with attribute error: BUILD_BUG_ON failed: __alignof__

Re: NFS/TCP/IPv6 acting strangely in 4.2

Hi, On Wed, Sep 16, 2015 at 06:53:57AM +, Damien Thébault wrote: > On Fri, 2015-09-11 at 12:38 +0100, Russell King - ARM Linux wrote: > > I have a recent Marvell Armada 388 board here which uses the mvneta > > driver. I'm seeing some weird effects with NFS with it acting as a > > client. >

Re: vhost: build failure

On Wed, Sep 16, 2015 at 01:50:08PM +0530, Sudip Mukherjee wrote: > Hi, > While crosscompiling the kernel for openrisc with allmodconfig the build > failed with the error: > drivers/vhost/vhost.c: In function 'vhost_vring_ioctl': > drivers/vhost/vhost.c:818:3: error: call to

[linux-next] oops in ip_route_input_noref

Hi, 4.3.0-rc1-next-20150916 oops after removal of rndis usb device ... 8146c052: 00 8146c053: 0f b6 55 8a movzbl -0x76(%rbp),%edx 8146c057: 49 8b bf e8 01 00 00mov0x1e8(%r15),%rdi 8146c05e: 45 89 d1mov

Re: NFS/TCP/IPv6 acting strangely in 4.2

Hi Damien, On mer., sept. 16 2015, Damien Thébault wrote: > On Fri, 2015-09-11 at 12:38 +0100, Russell King - ARM Linux wrote: >> I have a recent Marvell Armada 388 board here which uses the mvneta >> driver. I'm seeing some weird effects with NFS with it acting as

Re: [PATCH v2 1/1] eventfd: implementation of EFD_MASK flag

Hi Martin, On 2015-09-16 3:51 PM, Martin Sustrik wrote: > On 2015-09-16 08:27, Damian Hobson-Garcia wrote: >> >> Additionally, to provide a way to associate user-space state with eventfd >> object, it allows to attach user-space data to the file descriptor. > > The above paragraph is a leftover

Re: [PATCH] net: Fix vti use case with oif in dst lookups

On Tue, Sep 15, 2015 at 03:10:50PM -0700, David Ahern wrote: > Steffen reported that the recent change to add oif to dst lookups breaks > the VTI use case. The problem is that with the oif set in the flow struct > the comparison to the nh_oif is triggered. Fix by splitting the > FLOWI_FLAG_VRFSRC

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

David Miller writes: > From: Robert Jarzmik > Date: Sat, 12 Sep 2015 13:45:22 +0200 > >> Instead of using directly the OS timer through direct register access, >> use the standard sched_clock(), which will end up in OSCR reading >> anyway. >> >>

Re: vhost: build failure

On Wed, Sep 16, 2015 at 11:36:45AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 01:50:08PM +0530, Sudip Mukherjee wrote: > > Hi, > > While crosscompiling the kernel for openrisc with allmodconfig the build > > failed with the error: > > drivers/vhost/vhost.c: In function

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Fri, 2015-09-11 at 12:38 +0100, Russell King - ARM Linux wrote: > I have a recent Marvell Armada 388 board here which uses the mvneta > driver. I'm seeing some weird effects with NFS with it acting as a > client. Hello, I'm upgrading a Marvelle Armada 370 board using the mvneta driver from

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Wed, 2015-09-16 at 09:15 +0200, Gregory CLEMENT wrote: > > Since it worked fine on 4.0 I bisected until I found commit > > a84e32894191cfcbffa54180d78d7d4654d56c20 "net: mvneta: fix > > refilling > > for Rx DMA buffers". > > > > If I revert this commit, everything seems to get back to normal.

RE: bnx2x - occasional high packet loss (on LAN)

Hi Nikola, Please provide dmesg output from your system. Thanks, Ariel > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Nikola Ciprich > Sent: Tuesday, September 15, 2015 7:17 AM > To: netdev > Cc:

Re: xfrm4_garbage_collect reaching limit

On Mon, Sep 14, 2015 at 11:14:59PM -0400, Dan Streetman wrote: > On Fri, Sep 11, 2015 at 5:48 AM, Steffen Klassert > wrote: > > > >> Possibly the > >> default value of xfrm4_gc_thresh could be set proportional to > >> num_online_cpus(), but that doesn't help when

[RESEND PATCH] net: ks8851: Export OF module alias information

Drivers needs to export the OF id table and this be built into the module or udev won't have the necessary information to autoload the driver module when the device is registered via OF. Signed-off-by: Javier Martinez Canillas --- drivers/net/ethernet/micrel/ks8851.c |

Re: [PATCH] solos-pci: Increase headroom on received packets

On Wed, 2015-09-16 at 11:25 +0100, David Woodhouse wrote: > A comment in include/linux/skbuff.h says that: > > * Various parts of the networking layer expect at least 32 bytes of > * headroom, you should not reduce this. > > This was demonstrated by a panic when handling fragmented IPv6

Re: [PATCH v4] add stealth mode

Matteo Croce wrote: > Add option to disable any reply not related to a listening socket, > like RST/ACK for TCP and ICMP Port-Unreachable for UDP. > Also disables ICMP replies to echo request and timestamp. > The stealth mode can be enabled selectively for a single interface.

Re: [linux-next] oops in ip_route_input_noref

On 2015-09-16 11:24, Sergey Senozhatsky wrote: > Hi, > > 4.3.0-rc1-next-20150916 > > oops after removal of rndis usb device > > ... > 8146c052: 00 > 8146c053: 0f b6 55 8a movzbl -0x76(%rbp),%edx > 8146c057:

Re: [ANNOUNCE] libnftnl 1.0.4 release

On Wednesday 2015-09-16 13:50, Pablo Neira Ayuso wrote: >The Netfilter project proudly presents: > >libnftnl 1.0.4 $ git diff libnftnl-1.0.3..libnftnl-1.0.4 src/libnftnl.map diff --git a/src/libnftnl.map b/src/libnftnl.map index be7b998..14ec88c 100644 --- a/src/libnftnl.map +++

Re: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation

Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

On Tue, Sep 15, 2015 at 10:36:41PM -0400, Vlad Yasevich wrote: > On 09/15/2015 02:17 PM, Phil Sutter wrote: > > On Tue, Sep 15, 2015 at 11:11:53AM -0400, Vlad Yasevich wrote: > >> On 09/14/2015 04:06 PM, Phil Sutter wrote: > >>> On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: >

Re: [PATCH v4] add stealth mode

On Wed, 2015-09-16 at 11:54 +0200, Matteo Croce wrote: > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c > index 93898e0..fe62ae0 100644 > --- a/net/ipv4/tcp_ipv4.c > +++ b/net/ipv4/tcp_ipv4.c > @@ -77,6 +77,7 @@ > #include > > #include > +#include > #include > #include >

[PATCH v8 0/4] can: Allwinner A10/A20 CAN Controller support - Summary

Hi, please find attached the next version of my patch set. I have taken all remarks from Maxime Ripard into the new version Please review, test and report bugs if exists. The patchset applies to all recent Kernel versions (4.x, next etc.). [PATCH v8 1/4] Device Tree Binding Documentation

[PATCH v8 3/4] can: Allwinner A10/A20 CAN Controller support - Defconfig

Defconfig sunxi for Allwinner A10/A20 CAN driver Signed-off-by: Gerhard Bertelsmann --- arch/arm/configs/sunxi_defconfig | 2 + 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig

[PATCH v8 2/4] can: Allwinner A10/A20 CAN Controller support - Defconfig

Defconfig multi_v7 for Allwinner A10/A20 CAN driver Signed-off-by: Gerhard Bertelsmann --- arch/arm/configs/multi_v7_defconfig| 1 + 1 file changed, 1 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig

[PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings

Devicetree bindings for Allwinner A10/A20 CAN Signed-off-by: Gerhard Bertelsmann --- .../devicetree/bindings/net/can/sun4i_can.txt | 38 + 1 files changed, 389 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt

Re: [PATCH] solos-pci: Increase headroom on received packets

On Wed, 2015-09-16 at 03:53 -0700, Eric Dumazet wrote: > You should use netdev_alloc_skb() : This helper is better for rx skbs, > as it allows for better packing of frames in GRO or TCP stack. OK, thanks. I don't have a netdev (this is an ATM device) but I can use dev_alloc_skb(). > Also

Re: IPv6 routing/fragmentation panic

On Wed, 2015-09-16 at 01:48 +0200, Florian Westphal wrote: > > What I don't understand is why you see this with fragmented ipv6 > packets only (and not with all ipv6 forwarded skbs). > > Something like this copy-pastry from ip_finish_output2 should fix it: That works; thanks. Tested-by: David

Re: [PATCH v4] add stealth mode

On 09/16/2015 11:54 AM, Matteo Croce wrote: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface.

[PATCH] solos-pci: Increase headroom on received packets

A comment in include/linux/skbuff.h says that: * Various parts of the networking layer expect at least 32 bytes of * headroom, you should not reduce this. This was demonstrated by a panic when handling fragmented IPv6 packets: http://marc.info/?l=linux-netdev=144236093519172=2 It's not

[PATCH v2] solos-pci: Increase headroom on received packets

A comment in include/linux/skbuff.h says that: * Various parts of the networking layer expect at least 32 bytes of * headroom, you should not reduce this. This was demonstrated by a panic when handling fragmented IPv6 packets: http://marc.info/?l=linux-netdev=144236093519172=2 It's not

Re: [PATCH v2 net] net/mlx4_en: really allow to change RSS key

On Wed, Sep 16, 2015 at 4:29 AM, Eric Dumazet wrote: > From: Eric Dumazet > > When changing rss key, we do not want to overwrite user provided key > by the one provided by netdev_rss_key_fill(), which is the host random > key generated at boot time. >

[ANNOUNCE] libnftnl 1.0.4 release

Hi! The Netfilter project proudly presents: libnftnl 1.0.4 libnftnl is a userspace library providing a low-level netlink programming interface (API) to the in-kernel nf_tables subsystem. The library libnftnl has been previously known as libnftables. This library is currently used by the

Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

[PATCH v8 4/4] can: Allwinner A10/A20 CAN Controller support - Kernel module

Kernel module for Allwinner A10/A20 CAN Signed-off-by: Gerhard Bertelsmann --- drivers/net/can/Kconfig| 10 + drivers/net/can/Makefile | 1 + drivers/net/can/sun4i_can.c| 857

Re: [PATCH RFC] solos-pci: Fix BUG() with shared skb

On Tue, September 15, 2015 20:10, David Woodhouse wrote: > On Wed, 2013-09-04 at 21:41 +0100, David Woodhouse wrote: >> +++ b/drivers/atm/solos-pci.c >> @@ -1145,19 +1145,19 @@ static int psend(struct atm_vcc *vcc, struct sk_buff >> *skb) >> +> > if (skb_headroom(skb) < sizeof(*header)) { >> +>

Experiences with slub bulk use-case for network stack

Hint, this leads up to discussing if current bulk *ALLOC* API need to be changed... Alex and I have been working hard on practical use-case for SLAB bulking (mostly slUb), in the network stack. Here is a summary of what we have learned so far. Bulk free'ing SKBs during TX completion is a big

Re: [PATCH v4] add stealth mode

On 09/16/2015 12:45 PM, Matteo Croce wrote: 2015-09-16 12:26 GMT+02:00 Daniel Borkmann : On 09/16/2015 11:54 AM, Matteo Croce wrote: Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables

[PATCH net] bna: check for dma mapping errors

Check for DMA mapping errors, recover from them and register them in ethtool stats like other errors. Cc: Rasesh Mody Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c| 2 ++ drivers/net/ethernet/brocade/bna/bna_types.h

Re: IPv6 routing/fragmentation panic

David Woodhouse wrote: > On Wed, 2015-09-16 at 01:48 +0200, Florian Westphal wrote: > > > > What I don't understand is why you see this with fragmented ipv6 > > packets only (and not with all ipv6 forwarded skbs). > > > > Something like this copy-pastry from

Re: [linux-next] oops in ip_route_input_noref

On 2015-09-16 15:07, David Ahern wrote: > On 9/16/15 5:50 AM, Richard Alpe wrote: >> On 2015-09-16 11:24, Sergey Senozhatsky wrote: >>> Hi, >>> >>> 4.3.0-rc1-next-20150916 >>> >>> oops after removal of rndis usb device > > Hi Sergey: &g

Re: [linux-next] oops in ip_route_input_noref

On 2015-09-16 15:53, Richard Alpe wrote: > On 2015-09-16 15:07, David Ahern wrote: >> On 9/16/15 5:50 AM, Richard Alpe wrote: >>> On 2015-09-16 11:24, Sergey Senozhatsky wrote: >>>> Hi, >>>> >>>> 4.3.0-rc1-next-20150916 >>&g

Re: IPv6 routing/fragmentation panic

On Wed, 2015-09-16 at 15:27 +0200, Florian Westphal wrote: > @@ -599,7 +600,7 @@ int ip6_fragment(struct sock *sk, struct sk_buff > *skb, > /* Correct geometry. */ > if (frag->len > mtu || > ((frag->len & 7) && frag->next)

Re: [linux-next] oops in ip_route_input_noref

On 9/16/15 5:50 AM, Richard Alpe wrote: On 2015-09-16 11:24, Sergey Senozhatsky wrote: Hi, 4.3.0-rc1-next-20150916 oops after removal of rndis usb device Hi Sergey: Is this with KVM or baremetal? -8<- thanks for the analysis addr2line -e vmlinux -i 0x8146c0b1 net/i

Re: [PATCH] ARCNET: fix hard_header_len limit

On Wed, Aug 05, 2015 at 05:34:51PM +0200, Michael Grzeschik wrote: > On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > > From: Michael Grzeschik > > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > > > The commit <9c7077622dd9> ("packet: make packet_snd fail

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On Thu, Aug 27, 2015 at 08:40:29AM +0200, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Thu, 27 Aug 2015 08:27:04 +0200 > > > >> I'm not saying it is not possible, it certainly is. But I think that > >> for

Re: [linux-next] oops in ip_route_input_noref

On 9/16/15 3:24 AM, Sergey Senozhatsky wrote: Hi, 4.3.0-rc1-next-20150916 oops after removal of rndis usb device Sergey: Can you send me the oops output? Thanks, David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [linux-next] oops in ip_route_input_noref

On 9/16/15 7:53 AM, Richard Alpe wrote: I to get an Oops in ip_route_input_noref(). It happens occasionally during bootup. KVM environment using virtio driver. Let me know if you need any additional info or if you want me to try to bisect it. Starting network... ... [0.877040] BUG: unable

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: > From: kbuild test robot > Date: Wed, 16 Sep 2015 03:57:11 +0800 > > > All error/warnings (new ones prefixed by >>): > > > >In file included from drivers/usb/gadget/function/u_ether.h:20, > >

Re: IPv6 routing/fragmentation panic

On Wed, 2015-09-16 at 15:27 +0200, Florian Westphal wrote: > > David, could you test this? I'd do an official patch submission > then. Compiles. Doesn't fix the problem. -- dwmw2 smime.p7s Description: S/MIME cryptographic signature

Re: [linux-next] oops in ip_route_input_noref

On 9/16/15 7:59 AM, Richard Alpe wrote: Sorry about that kvm cmdline was a copy-paste error. Here's the right one using virtio. I was just about to respond to that as well... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [linux-next] oops in ip_route_input_noref

On 2015-09-16 15:57, David Ahern wrote: > On 9/16/15 7:53 AM, Richard Alpe wrote: I to get an Oops in ip_route_input_noref(). It happens occasionally during bootup. KVM environment using virtio driver. Let me know if you need any additional info or if you want me to try

Re: [PATCH 2/2] airo: Implement netif_carrier_on/off

Hello. On 9/15/2015 6:18 PM, Ondrej Zary wrote: Add calls to netif_carrier_on and netif_carrier_off Signed-off-by: Ondrej Zary --- drivers/net/wireless/airo.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [linux-next] oops in ip_route_input_noref

le to handle kernel NULL pointer dereference at virtual address 0007 pgd = c0004000 [0007] *pgd= Internal error: Oops: 1 [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.3.0-rc1-next-20150916-dirty #96 Hardware name: Freescale i.MX25 (Device Tree Support) tas

Re: [linux-next] oops in ip_route_input_noref

On 9/16/15 9:00 AM, Fabio Estevam wrote: On Wed, Sep 16, 2015 at 6:24 AM, Sergey Senozhatsky wrote: added by b7503e0cdb5dbec5d201aa69dc14679b5ae8 net: Add FIB table id to rtable Add the FIB table id to rtable to make the information available

[PATCH net] ipv6: ip6_fragment: fix headroom tests and skb leak

David Woodhouse reports skb_under_panic when we try to push ethernet header to fragmented ipv6 skbs: skbuff: skb_under_panic: text:c1277f1e len:1294 put:14 head:dec98000 data:dec97ffc tail:0xdec9850a end:0xdec98f40 dev:br-lan [..] ip6_finish_output2+0x196/0x4da David further debugged this:

[PATCH net-next] net: Initialize table in fib result

Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard: [0.877040] BUG: unable to handle kernel NULL pointer dereference at 0056 [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 [0.877597] PGD 3fa14067 PUD 3fa6e067 PMD 0 [0.877597]

Re: Experiences with slub bulk use-case for network stack

On Wed, 16 Sep 2015, Jesper Dangaard Brouer wrote: > > Hint, this leads up to discussing if current bulk *ALLOC* API need to > be changed... > > Alex and I have been working hard on practical use-case for SLAB > bulking (mostly slUb), in the network stack. Here is a summary of > what we have

[PATCH RFC 0/3] Allow postponed netfilter handling for socket matches

I'm re-addressing the issue of matching socket meta information for non-established sockets that has been discussed a while ago: http://article.gmane.org/gmane.comp.security.firewalls.netfilter.devel/56877 Being able to reliably match on net_cls cgroup ids is crucial in order to build a

[PATCH RFC 2/3] netfilter: nft_meta: mark skbs for postponed filter processing

When the cgroup matching code in nft_meta is called without a socket to look at, it currently bails out and lets the packet pass. This is bad, because the reason for skb->sk being NULL is simply that the packet was directed to a socket that hasn't been looked up yet by early demux. This patch

[PATCH RFC 3/3] net: tcp_ipv4: re-run netfilter chains for marked skbs

When an skb has been marked for later re-iteration through netfilter, do that after __inet_lookup_skb() has been called. This allows packets sent to unconnected sockets to be filtered reliably. Note that this will never happen for subsequent packets in the same stream, as skb->sk will be set due

Re: [PATCH net-next] net: Initialize table in fib result

On 09/16/2015 05:38 PM, David Ahern wrote: > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: > > [0.877040] BUG: unable to handle kernel NULL pointer dereference at > 0056 > [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 > [

[PATCH RFC 1/3] netfilter: add socket to struct nft_pktinfo

The high-level netfilter hook API already enables users to pass a socket, but that information is lost when the chains are walked. In order to let internal eval callbacks use the passed filter rather than skb->sk, add a pointer of type 'struct sock' to 'struct nft_pktinfo' and set that field via

Re: IPv6 routing/fragmentation panic

David Woodhouse wrote: > > if (frag->len > mtu || > > ((frag->len & 7) && frag->next) || > > - skb_headroom(frag) < hlen) > > + skb_headroom(frag) < (hlen + hroom)) > >

[PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate memory allocation in the packet send path") introduced skb headroom request for Hyper-V netvsc driver: max_needed_headroom = sizeof(struct hv_netvsc_packet) + sizeof(struct rndis_message)

[PATCH iproute2] man ip-link: Fix wording in VLAN reorder_hdr explanation

From: Vadim Kochan Signed-off-by: Vadim Kochan --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 1896eb6..4928249 100644 --- a/man/man8/ip-link.8.in +++

Re: [PATCH] man ip-link: Add more explanation about vlan reordering

On Wed, Aug 26, 2015 at 04:27:48PM +0100, Jeremy Harris wrote: > On 17/08/15 20:22, Vadim Kochan wrote: > > +.BR reorder_hdr " is " on > > +then VLAN header will be not inserted immediately but only before passing > > to the > > +physical device (if this device does not support VLAN offloading),

Re: [PATCH net-next] net: Initialize table in fib result

On 9/16/15 9:56 AM, Nikolay Aleksandrov wrote: Just to have it documented: I don't think we need the second NULLing, but it doesn't hurt. I think we do. After the second one there is a goto to local_input which uses res.table. The second goto is reachable 'if !IN_DEV_FORWARD(in_dev)' in

Re: [PATCH net-next] net: Initialize table in fib result

On Wed, Sep 16, 2015 at 12:38 PM, David Ahern wrote: > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > Fixes: b7503e0cdb5d ("net: Add FIB table id to rtable") > Reported-by:

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, September 16, 2015 11:50 AM > To: netdev@vger.kernel.org > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > KY Srinivasan ; Haiyang Zhang >

[PATCH net-next v2] net: Initialize table in fib result

Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard: [0.877040] BUG: unable to handle kernel NULL pointer dereference at 0056 [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 [0.877597] PGD 3fa14067 PUD 3fa6e067 PMD 0 [0.877597]

Re: [PATCH net-next v2] net: Initialize table in fib result

On 09/16/2015 06:16 PM, David Ahern wrote: > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: > > [0.877040] BUG: unable to handle kernel NULL pointer dereference at > 0056 > [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 > [

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

From: Haiyang Zhang > Sent: 16 September 2015 17:09 > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Wednesday, September 16, 2015 11:50 AM > > To: netdev@vger.kernel.org > > Cc: David S. Miller ; linux-ker...@vger.kernel.org; >

[PATCH v2] atm: deal with setting entry before mkip was called

If we didn't call ATMARP_MKIP before ATMARP_ENCAP the VCC descriptor is non-existant and we'll end up dereferencing a NULL ptr: [1033173.491930] kasan: GPF could be caused by NULL-ptr deref or user memory accessirq event stamp: 123386 [1033173.493678] general protection fault: [#1] PREEMPT

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Wednesday, September 16, 2015 9:25 AM > To: Haiyang Zhang ; Vitaly Kuznetsov > ; netdev@vger.kernel.org > Cc: David S. Miller ;

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

From: Fengguang Wu Date: Wed, 16 Sep 2015 21:06:58 +0800 > On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: >> From: kbuild test robot >> Date: Wed, 16 Sep 2015 03:57:11 +0800 >> >> > All error/warnings (new ones prefixed by >>): >>

[PATCH net-next] net: fix cdc-phonet.c dependency and build error

org> --- drivers/net/usb/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20150916.orig/drivers/net/usb/Kconfig +++ linux-next-20150916/drivers/net/usb/Kconfig @@ -541,7 +541,7 @@ config USB_NET_INT51X1 config USB_CDC_PHONET tristate "CDC Phonet s

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

From: David Laight Date: Wed, 16 Sep 2015 16:25:03 + > Am I right in thinking this is adding an extra 96 unused bytes to the front > of almost all skb just so that hyper-v can make its link level header > contiguous with whatever follows (IP header ?). > > Doesn't

Re: [PATCH RFC 0/3] Allow postponed netfilter handling for socket matches

Daniel Mack wrote: > I'm re-addressing the issue of matching socket meta information for > non-established sockets that has been discussed a while ago: > > http://article.gmane.org/gmane.comp.security.firewalls.netfilter.devel/56877 > > Being able to reliably match on

Re: [PATCH] net: qdisc: enhance default_qdisc documentation

On Tue, Sep 15, 2015 at 1:33 AM, Phil Sutter wrote: > Aside from some lingual cleanup, point out which interfaces are not or > partly covered by this setting. > > Signed-off-by: Phil Sutter Acked-by: Cong Wang It also worth to explain what the

[PATCH net-next v2] xen-netfront: always set num queues if possible

If netfront connects with two (or more) queues and then reconnects with only one queue it fails to delete or rewrite the multi-queue-num-queues key and netback will try to use the wrong number of queues. Always write the num-queues field if the backend has multi-queue support. Signed-off-by:

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

On 09/16/2015 10:55 AM, KY Srinivasan wrote: -Original Message- From: David Laight [mailto:david.lai...@aculab.com] Sent: Wednesday, September 16, 2015 9:25 AM To: Haiyang Zhang ; Vitaly Kuznetsov ; netdev@vger.kernel.org Cc: David S. Miller

[PATCH net 5/6] lan78xx: Create lan78xx_get_mdix_status() and lan78xx_set_mdix_status() for MDIX control.

Create lan78xx_get_mdix_status() and lan78xx_set_mdix_status() for MDIX control. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 90 +++ 1 file changed, 52 insertions(+), 38 deletions(-) diff --git

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

On 09/16/2015 03:57 PM, KY Srinivasan wrote: -Original Message- From: Alexander Duyck [mailto:alexander.du...@gmail.com] Sent: Wednesday, September 16, 2015 2:39 PM To: KY Srinivasan ; David Laight ; Haiyang Zhang ;

Re: [PATCH net-next v2] net: Initialize table in fib result

On 16/09/15 09:16, David Ahern wrote: > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > As Nikolay pointed out the second initialization is not required to fix > the oops, but rather to fix a related

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, September 16, 2015 2:39 PM > To: KY Srinivasan ; David Laight > ; Haiyang Zhang ; > Vitaly Kuznetsov

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, September 16, 2015 4:49 PM > To: KY Srinivasan ; David Laight > ; Haiyang Zhang ; > Vitaly Kuznetsov

  1   2   >