Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

On Fri, 2015-11-06 at 22:02 +0100, Daniel Borkmann wrote: > In tpacket_fill_skb() commit c1aad275b029 ("packet: set transport > header before doing xmit") and later on 40893fd0fd4e ("net: switch > to use skb_probe_transport_header()") was probing for a transport > header on the skb from a ring

Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put()

From: SF Markus Elfring Date: Sat, 7 Nov 2015 15:15:24 +0100 > From: Markus Elfring > Date: Sat, 7 Nov 2015 15:10:29 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the

[PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"

From: Markus Elfring Date: Sat, 7 Nov 2015 16:30:34 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re:netdev在?“(AD)

netdev 欢迎加入爱奇艺vip分享QQ群：5650047 每天发放好几波爱奇艺vip会员，看蜀山战纪，灵魂摆渡2等热门大片不要钱！限时开放！验证码511

[PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put()

From: Markus Elfring Date: Sat, 7 Nov 2015 15:10:29 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] packet: Allow packets with only a header (but no payload)

On 2015-07-31 00:15, Martin Blumenstingl wrote: > On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn wrote: >> Martin, to return to your initial statement that PPPoE PADI packets can >> have a zero payload: the PPPoE RFC states that PADI packets "MUST >> contain exactly one TAG

[PATCH] tcp: use kmalloc() than kmalloc_array().

Commit 095dc8e0c3686d58 ("tcp: fix/cleanup inet_ehash_locks_alloc()") silently changed from kmalloc() to kmalloc_array(). The latter has overflow check whereas the former doesn't have. If nblocks * locksz might overflow, we need to do like - if (!hashinfo->ehash_locks && nblocks > SIZE_MAX /

[PATCH] man: Syntax and warning fixes

--- man/man8/tc-bpf.8 | 2 +- man/man8/tipc-bearer.8| 4 ++-- man/man8/tipc-link.8 | 6 +++--- man/man8/tipc-media.8 | 4 ++-- man/man8/tipc-nametable.8 | 4 ++-- man/man8/tipc-node.8 | 4 ++-- man/man8/tipc-socket.8| 4 ++-- 7 files changed, 14 insertions(+), 14

[PATCH 2/2] man: Spelling fixes

Signed-off-by: Ville Skyttä --- man/man8/bridge.8 | 2 +- man/man8/ifcfg.8 | 2 +- man/man8/lnstat.8 | 2 +- man/man8/tc-bpf.8 | 2 +- man/man8/tc-cbq-details.8 | 2 +- man/man8/tc-mqprio.8 | 2 +- man/man8/tc.8 | 2 +- 7

[PATCH 1/2] man: Syntax and warning fixes

Fix syntax issues and warnings highlighted by `man --warnings=w' from man-db 2.7.1. Signed-off-by: Ville Skyttä --- man/man8/tc-bpf.8 | 2 +- man/man8/tipc-bearer.8| 4 ++-- man/man8/tipc-link.8 | 6 +++--- man/man8/tipc-media.8 | 4 ++--

Re: [PATCH] man: Syntax and warning fixes

On Sat, Nov 7, 2015 at 11:47 AM, Albino B Neto wrote: > 2015-11-07 7:44 GMT-02:00 Ville Skyttä : >> --- >> man/man8/tc-bpf.8 | 2 +- >> man/man8/tipc-bearer.8| 4 ++-- >> man/man8/tipc-link.8 | 6 +++--- >> man/man8/tipc-media.8 | 4 ++-- >>

Re: [PATCH] man: Syntax and warning fixes

2015-11-07 7:44 GMT-02:00 Ville Skyttä : > --- > man/man8/tc-bpf.8 | 2 +- > man/man8/tipc-bearer.8| 4 ++-- > man/man8/tipc-link.8 | 6 +++--- > man/man8/tipc-media.8 | 4 ++-- > man/man8/tipc-nametable.8 | 4 ++-- > man/man8/tipc-node.8 | 4 ++-- >

[PATCH] man: Spelling fixes

--- man/man8/bridge.8 | 2 +- man/man8/ifcfg.8 | 2 +- man/man8/lnstat.8 | 2 +- man/man8/tc-bpf.8 | 2 +- man/man8/tc-cbq-details.8 | 2 +- man/man8/tc-mqprio.8 | 2 +- man/man8/tc.8 | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH] man: Syntax and warning fixes

On 11/7/15 2:55 AM, Ville Skyttä wrote: On Sat, Nov 7, 2015 at 11:47 AM, Albino B Neto wrote: 2015-11-07 7:44 GMT-02:00 Ville Skyttä : --- man/man8/tc-bpf.8 | 2 +- man/man8/tipc-bearer.8| 4 ++-- man/man8/tipc-link.8 | 6 +++---

Re: [PATCH] tcp: use kmalloc() than kmalloc_array().

From: Tetsuo Handa Date: Sun, 8 Nov 2015 00:58:50 +0900 > Tetsuo Handa wrote: >> Commit 095dc8e0c3686d58 ("tcp: fix/cleanup inet_ehash_locks_alloc()") >> silently changed from kmalloc() to kmalloc_array(). The latter has >> overflow check whereas the former

Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"

From: SF Markus Elfring Date: Sat, 7 Nov 2015 16:34:48 +0100 > From: Markus Elfring > Date: Sat, 7 Nov 2015 16:30:34 +0100 > > The of_node_put() function tests whether its argument is NULL > and then returns immediately. > Thus the

Re: [PATCH] fjes: Delete an unnecessary check before the function call "vfree"

From: SF Markus Elfring Date: Fri, 6 Nov 2015 09:39:23 +0100 > From: Markus Elfring > Date: Fri, 6 Nov 2015 09:30:29 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

From: Eric Dumazet Date: Sat, 07 Nov 2015 04:42:56 -0800 > The if (!packet_use_direct_xmit(po)) test looks dubious. > > Setting transport header has nothing to do with bypassing qdisc ? > > This might lead to hard to debug problems, for drivers expecting > transport

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

On Sat, 2015-11-07 at 10:53 -0800, Eric Dumazet wrote: > Well, imagine following scenario (a real one, as I use it all of time, > thus how I discovered all trafgen traffic ends up on one slave only) > > Even if qdisc is bypassed on the bond0, the current handling does not > prevent going to the

Re: linux-next network throughput performance regression

On Fri, 2015-11-06 at 14:30 -0700, David Ahern wrote: > On 11/6/15 2:18 PM, Simon Xiao wrote: > > The .config file used to build linux-next kernel is attached to this mail. > > Thanks. > > Failed to notice this on the first response; my brain filled in. Why > linux-next tree? Can you try

[PATCH v2] drivers: net: xgene: fix RGMII 10/100Mb mode

This patch fixes the RGMII 10/100M mode by reprogramming the clock. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen --- v2: Address v1 review comments - targeting bug fix patch to "net" tree v1: Initial revision ---

Re: linux-next network throughput performance regression

On Sat, 2015-11-07 at 11:35 -0800, Eric Dumazet wrote: > On Fri, 2015-11-06 at 14:30 -0700, David Ahern wrote: > > On 11/6/15 2:18 PM, Simon Xiao wrote: > > > The .config file used to build linux-next kernel is attached to this mail. > > > > Thanks. > > > > Failed to notice this on the first

Re: 4.3.0 r8169: "rtl_counters_cond == 1 (loop: 1000, delay: 10)." log spam

Sverd Johnsen : > related: > > https://bugzilla.kernel.org/show_bug.cgi?id=107421 Let's start with yours. > https://bugzilla.kernel.org/show_bug.cgi?id=104351 > > 4.3.0 smp x86_64 > > [4.384336] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded > [

Re: GSO with udp_tunnel_xmit_skb

> I suppose this is about UFO. > > Specifically -- let's say I have a list of 500 skbs, which have their > data in place but don't yet have an IP or UDP header etc. I want to > send out these out using udp_tunnel_xmit_skb. Right now, if I just > send them all out, one after another, they don't

Re: [PATCH] decnet: remove macro-local declarations

On Sat, 7 Nov 2015, David Miller wrote: > From: Julia Lawall > Date: Fri, 6 Nov 2015 11:57:34 +0100 (CET) > > >> > Would it be preferable to remove the macro entirely and inline the for > >> > loop header? > >> > >> Could you show me an example of how this would look

Re: [PATCH] tcp: use kmalloc() than kmalloc_array().

On Sun, 2015-11-08 at 00:50 +0900, Tetsuo Handa wrote: > Commit 095dc8e0c3686d58 ("tcp: fix/cleanup inet_ehash_locks_alloc()") > silently changed from kmalloc() to kmalloc_array(). The latter has > overflow check whereas the former doesn't have. > > If nblocks * locksz might overflow, we need to

Re: [PATCH] tcp: use kmalloc() than kmalloc_array().

Tetsuo Handa wrote: > Commit 095dc8e0c3686d58 ("tcp: fix/cleanup inet_ehash_locks_alloc()") > silently changed from kmalloc() to kmalloc_array(). The latter has > overflow check whereas the former doesn't have. > > If nblocks * locksz might overflow, we need to do like > > - if

Re: [PATCH net] net/qlcnic: fix mac address restore in bond mode 5/6

From: Jarod Wilson Date: Fri, 6 Nov 2015 09:25:31 -0500 > The bonding driver saves a copy of slaves' original mac address and then > assigns whatever mac as needed to the slave, depending on mode. In at > least modes 5 and 6 (balance-tlb, balance-alb), it often ends up being

Re: [PATCH] decnet: remove macro-local declarations

From: Julia Lawall Date: Fri, 6 Nov 2015 11:57:34 +0100 (CET) >> > Would it be preferable to remove the macro entirely and inline the for >> > loop header? >> >> Could you show me an example of how this would look exactly? > > One possible solution is below. I moved the

Re: [PATCH] inet: delay address promotion check until last request in message

From: Julian Anastasov Date: Sat, 7 Nov 2015 01:49:25 +0200 (EET) > On Fri, 6 Nov 2015, Neil Horman wrote: > >> The solution is to recognize that its pointless to promote an address to be a >> new primary, if there is a possibility that it will just be removed in the >> near >>

Re: [PATCH net] bonding: fix panic on non-ARPHRD_ETHER enslave failure

From: Jay Vosburgh Date: Fri, 06 Nov 2015 17:23:23 -0800 > > Since commit 7d5cd2ce529b, when bond_enslave fails on devices that > are not ARPHRD_ETHER, if needed, it resets the bonding device back to > ARPHRD_ETHER by calling ether_setup. > >

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

On Sat, 2015-11-07 at 13:35 -0500, David Miller wrote: > From: Eric Dumazet > Date: Sat, 07 Nov 2015 04:42:56 -0800 > > > The if (!packet_use_direct_xmit(po)) test looks dubious. > > > > Setting transport header has nothing to do with bypassing qdisc ? > > > > This

Re: [PATCH] tcp: use kmalloc() than kmalloc_array().

From: Eric Dumazet Date: Sat, 07 Nov 2015 10:50:07 -0800 > I do not feel we should go back to kmalloc() just because > vmalloc_array() does not exist yet. Agreed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: GSO with udp_tunnel_xmit_skb

Hi Maciej, Thanks for your reply. Some interesting things to consider here... See inline below. On Sat, Nov 7, 2015 at 6:19 PM, Maciej Żenczykowski wrote: > > UFO will never collapse multiple (UDP) packets. > > It would be incorrect to do so, since UDP has to maintain

Re: GSO with udp_tunnel_xmit_skb

> What I was thinking about is this: My driver receives a super-packet. > By calling skb_gso_segment(), I'm given a list of equal sized packets > (of gso_size each), except for the last one which is either the same > size or smaller than the rest. Let's say calling skb_gso_segment() > gives me a

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

On 11/07/2015 08:06 PM, Eric Dumazet wrote: On Sat, 2015-11-07 at 10:53 -0800, Eric Dumazet wrote: Well, imagine following scenario (a real one, as I use it all of time, thus how I discovered all trafgen traffic ends up on one slave only) Even if qdisc is bypassed on the bond0, the current

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

From: Eric Dumazet Date: Sat, 07 Nov 2015 10:53:50 -0800 > Well, imagine following scenario (a real one, as I use it all of > time, thus how I discovered all trafgen traffic ends up on one slave > only) > > Even if qdisc is bypassed on the bond0, the current handling

Re: [PATCH] bpf: doc: correct arch list for supported eBPF JIT

On 11/07/2015 06:38 AM, Yang Shi wrote: aarch64 and s390x support eBPF JIT too, correct document to reflect this and avoid any confusion. Signed-off-by: Yang Shi Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line "unsubscribe

Re: AF_PACKET mmap() v4...

On Thu, Nov 05, 2015 at 10:39:15AM +0100, Daniel Borkmann wrote: > On 11/05/2015 10:07 AM, Arnd Bergmann wrote: > >On Thursday 05 November 2015 00:04:14 David Miller wrote: > >>As part of fixing y2038 problems, Arnd is going to have to make a new > >>version fo the AF_PACKET mmap() tpacker

Re: [PATCH] bpf: doc: correct arch list for supported eBPF JIT

On Fri, Nov 06, 2015 at 09:38:58PM -0800, Yang Shi wrote: > aarch64 and s390x support eBPF JIT too, correct document to reflect this and > avoid any confusion. > > Signed-off-by: Yang Shi Thanks Acked-by: Alexei Starovoitov -- To unsubscribe from this

Re: [PATCH] arm64: bpf: fix JIT stack setup

On Fri, Nov 06, 2015 at 09:36:17PM -0800, Yang Shi wrote: > ARM64 JIT used FP (x29) as eBPF fp register, but FP is subjected to > change during function call so it may cause the BPF prog stack base address > change too. Whenever, it pointed to the bottom of BPF prog stack instead of > the top. >

Re: AF_PACKET mmap() v4...

On 15-11-07 06:19 PM, Alexei Starovoitov wrote: > On Thu, Nov 05, 2015 at 10:39:15AM +0100, Daniel Borkmann wrote: >> On 11/05/2015 10:07 AM, Arnd Bergmann wrote: >>> On Thursday 05 November 2015 00:04:14 David Miller wrote: As part of fixing y2038 problems, Arnd is going to have to make a

Re: [PATCH] tcp: use kmalloc() than kmalloc_array().

David Miller wrote: > From: Eric Dumazet > Date: Sat, 07 Nov 2015 10:50:07 -0800 > > > I do not feel we should go back to kmalloc() just because > > vmalloc_array() does not exist yet. > > Agreed. > Please change as you like. I was thinking to introduce a helper that