[PATCH net-next 1/9] net: ipmr: move the tbl id check in ipmr_new_table

From: Nikolay Aleksandrov Move the table id check in ipmr_new_table and make it return error pointer. We need this change for the upcoming netlink table manipulation support in order to avoid code duplication and a race condition. Signed-off-by: Nikolay Aleksandrov

[PATCH net-next 6/9] net: ipmr: drop an instance of CONFIG_IP_MROUTE_MULTIPLE_TABLES

From: Nikolay Aleksandrov Trivial replace of ifdef with IS_BUILTIN(). Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c

[PATCH net-next 3/9] net: ipmr: remove some pimsm ifdefs and simplify

From: Nikolay Aleksandrov Add the helper pimsm_enabled() which replaces the old CONFIG_IP_PIMSM define and is used to check if any version of PIM-SM has been enabled. Use a single if defined(CONFIG_IP_PIMSM_V1) || defined(CONFIG_IP_PIMSM_V2) for the pim-sm shared

yet another uninterruptable hang in sendfile

Hello, On commit 8005c49d9aea74d382f474ce11afbbc7d7130bec (Nov 15). The program is: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include int main() { long r0 = syscall(SYS_socket, 0x10ul, 0x2ul, 0x0ul, 0, 0, 0); long r1 =

Re: [PATCH net-next 7/9] net: ipmr: remove SLAB_PANIC

On 11/21/2015 03:23 PM, Eric Dumazet wrote: > On Sat, 2015-11-21 at 14:01 +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> It's not necessary to panic upon allocation failure, returning an error >> at that point is okay because user-space won't be

[PATCH net-next v2 5/9] net: ipmr: make ip_mroute_getsockopt more understandable

From: Nikolay Aleksandrov Use a switch to determine if optname is correct and set val accordingly. This produces a much more straight-forward and readable code. Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 28

[PATCH net-next v2 1/9] net: ipmr: move the tbl id check in ipmr_new_table

From: Nikolay Aleksandrov Move the table id check in ipmr_new_table and make it return error pointer. We need this change for the upcoming netlink table manipulation support in order to avoid code duplication and a race condition. Signed-off-by: Nikolay Aleksandrov

[PATCH net-next v2 3/9] net: ipmr: remove some pimsm ifdefs and simplify

From: Nikolay Aleksandrov Add the helper pimsm_enabled() which replaces the old CONFIG_IP_PIMSM define and is used to check if any version of PIM-SM has been enabled. Use a single if defined(CONFIG_IP_PIMSM_V1) || defined(CONFIG_IP_PIMSM_V2) for the pim-sm shared

[PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements

From: Nikolay Aleksandrov Hi, Since I'll have to work with ipmr, I decided to clean it up and do some minor improvements. Functionally there're almost no changes except the SLAB_PANIC removal. Most of the patches just re-design some functions to be clearer and more

[PATCH 2/2 iptables] libxt_cgroup: add support for cgroup2 path matching

This patch updates xt_cgroup so that it supports revision 1 interface which includes cgroup2 path based matching. v3: Folded into xt_cgroup as a new revision interface as suggested by Pablo. v2: cgroup2_match->userspacesize and ->save and man page updated as per Jan. Signed-off-by:

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

Tejun Heo wrote: > This patch implements xt_cgroup path match which matches cgroup2 > membership of the associated socket. The match is recursive and > invertible. > > For rationales on introducing another cgroup based match, please refer > to a preceding commit "sock, cgroup:

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/20/2015 10:53 PM, Arend van Spriel wrote: > On 11/19/2015 08:48 AM, Kalle Valo wrote: >> Hauke Mehrtens writes: >> >>> On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles

[PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions

libxt_cgroup will grow cgroup2 path based match. Postfix existing symbols with _v0 and prepare for multi revision registration. While at it, rename O_CGROUP to O_CLASSID and fwid to classid. Signed-off-by: Tejun Heo Cc: Daniel Borkmann Cc: Jan Engelhardt

[PATCH 1/9] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it

cgroup_is_descendant() currently walks up the hierarchy and compares each ancestor to the cgroup in question. While enough for cgroup core usages, this can't be used in hot paths to test cgroup membership. This patch adds cgroup->ancestor_ids[] which records the IDs of all ancestors including

[PATCH 3/9] cgroup: implement cgroup_get_from_path() and expose cgroup_put()

Implement cgroup_get_from_path() using kernfs_walk_and_get() which obtains a default hierarchy cgroup from its path. This will be used to allow cgroup path based matching from outside cgroup proper - e.g. networking and perf. v2: Add EXPORT_SYMBOL_GPL(cgroup_get_from_path). Signed-off-by: Tejun

[PATCH 5/9] netprio_cgroup: limit the maximum css->id to USHRT_MAX

netprio builds per-netdev contiguous priomap array which is indexed by css->id. The array is allocated using kzalloc() effectively limiting the maximum ID supported to some thousand range. This patch caps the maximum supported css->id to USHRT_MAX which should be way above what is actually

[PATCH 4/9] cgroups: Allow dynamically changing net_classid

From: Nina Schiff The classid of a process is changed either when a process is moved to or from a cgroup or when the net_cls.classid file is updated. Previously net_cls only supported propogating these changes to the cgroup's related sockets when a process was added or removed

[PATCH 7/9] sock, cgroup: add sock->sk_cgroup

In cgroup v1, dealing with cgroup membership was difficult because the number of membership associations was unbound. As a result, cgroup v1 grew several controllers whose primary purpose is either tagging membership or pull in configuration knobs from other subsystems so that cgroup membership

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

Oops, made a copy & paste error on Neil Horman's address. Sorry, Neil. The thread can be found at http://lkml.kernel.org/g/1448122441-9335-1-git-send-email...@kernel.org Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH net-next 4/9] net: ipmr: fix code and comment style

From: Nikolay Aleksandrov Trivial code and comment style fixes, also removed some extra newlines, spaces and tabs. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/mroute.h | 59 ++ net/ipv4/ipmr.c

[PATCH net-next 9/9] net: ipmr: factor out common vif init code

From: Nikolay Aleksandrov Factor out common vif init code used in both tunnel and pimreg initialization and create ipmr_init_vif_indev() function. Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 40

[PATCH net-next 7/9] net: ipmr: remove SLAB_PANIC

From: Nikolay Aleksandrov It's not necessary to panic upon allocation failure, returning an error at that point is okay because user-space won't be able to use any of the ops since they didn't get registered and the default table is null. Signed-off-by: Nikolay

[PATCH net-next 2/9] net: ipmr: always define mroute_reg_vif_num

From: Nikolay Aleksandrov Before mroute_reg_vif_num was defined only if any of the CONFIG_PIMSM_ options were set, but that's not really necessary as the size of the struct is the same in both cases (checked with pahole, both cases size is 3256 bytes) and we can

[PATCH net-next 5/9] net: ipmr: make ip_mroute_getsockopt more understandable

From: Nikolay Aleksandrov Use a switch to determine if optname is correct and set val accordingly. This produces a much more straight-forward and readable code. Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 28

[PATCH net-next 8/9] net: ipmr: rearrange and cleanup setsockopt

From: Nikolay Aleksandrov Take rtnl in the beginning unconditionally as most options already need it (one exception - MRT_DONE, see the comment inside), make the lock/unlock places central and move out the switch() local variables. Signed-off-by: Nikolay Aleksandrov

[PATCH net-next 0/9] net: ipmr: cleanups and minor improvements

From: Nikolay Aleksandrov Hi, Since I'll have to work with ipmr, I decided to clean it up and do some minor improvements. Functionally there're almost no changes except the SLAB_PANIC removal. Most of the patches just re-design some functions to be clearer and more

[PATCH net] vrf: fix double free and memory corruption on register_netdevice failure

From: Nikolay Aleksandrov When vrf's ->newlink is called, if register_netdevice() fails then it does free_netdev(), but that's also done by rtnl_newlink() so a second free happens and memory gets corrupted, to reproduce execute the following line a couple of times (1

Re: [PATCH net-next 7/9] net: ipmr: remove SLAB_PANIC

On Sat, 2015-11-21 at 14:01 +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > It's not necessary to panic upon allocation failure, returning an error > at that point is okay because user-space won't be able to use any of the > ops since they didn't

[PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

Hello, This is v3 of the xt_cgroup2 patchset. Changes from the last take are * Folded cgroup2 path matching into xt_cgroup as a new revision rather than a separate xt_cgroup2 match as suggested by Pablo. * Refreshed on top of Nina's net_cls dynamic config update fix patch. I included the

[PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

This patch implements xt_cgroup path match which matches cgroup2 membership of the associated socket. The match is recursive and invertible. For rationales on introducing another cgroup based match, please refer to a preceding commit "sock, cgroup: add sock->sk_cgroup". v3: Folded into

[PATCH 6/9] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct

Introduce sock->sk_cgrp_data which is a struct sock_cgroup_data. ->sk_cgroup_prioidx and ->sk_classid are moved into it. The struct and its accessors are defined in cgroup-defs.h. This is to prepare for overloading the fields with a cgroup pointer. This patch mostly performs equivalent

[PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions

xt_cgroup will grow cgroup2 path based match. Postfix existing symbols with _v0 and prepare for multi revision registration. Signed-off-by: Tejun Heo Cc: Daniel Borkmann Cc: Daniel Wagner CC: Neil Horman

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

Hello, On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote: > > +struct xt_cgroup_info_v1 { > > + __u8has_path; > > + __u8has_classid; > > + __u8invert_path; > > + __u8invert_classid; > > + charpath[PATH_MAX]; > >

[PATCH] net: atm: constify in_cache_ops and eg_cache_ops structures

The in_cache_ops and eg_cache_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- net/atm/mpc.h |4 ++-- net/atm/mpoa_caches.c |4 ++-- 2 files changed, 4 insertions(+), 4

[PATCH net-next v2 7/9] net: ipmr: drop ip_mr_init() mrt_cachep null check as we'll panic if it fails

From: Nikolay Aleksandrov It's not necessary to check for null as SLAB_PANIC is used and we'll panic if the alloc fails, so just drop it. Signed-off-by: Nikolay Aleksandrov --- v2: new patch, keep SLAB_PANIC and drop the unnecessary

[PATCH net-next v2 9/9] net: ipmr: factor out common vif init code

From: Nikolay Aleksandrov Factor out common vif init code used in both tunnel and pimreg initialization and create ipmr_init_vif_indev() function. Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 40

[PATCH net-next v2 4/9] net: ipmr: fix code and comment style

From: Nikolay Aleksandrov Trivial code and comment style fixes, also removed some extra newlines, spaces and tabs. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/mroute.h | 59 ++ net/ipv4/ipmr.c

[PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num

From: Nikolay Aleksandrov Before mroute_reg_vif_num was defined only if any of the CONFIG_PIMSM_ options were set, but that's not really necessary as the size of the struct is the same in both cases (checked with pahole, both cases size is 3256 bytes) and we can

[PATCH net-next v2 6/9] net: ipmr: drop an instance of CONFIG_IP_MROUTE_MULTIPLE_TABLES

From: Nikolay Aleksandrov Trivial replace of ifdef with IS_BUILTIN(). Signed-off-by: Nikolay Aleksandrov --- net/ipv4/ipmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c

[PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

From: Nikolay Aleksandrov Take rtnl in the beginning unconditionally as most options already need it (one exception - MRT_DONE, see the comment inside), make the lock/unlock places central and move out the switch() local variables. Signed-off-by: Nikolay Aleksandrov

[PATCH 2/9] kernfs: implement kernfs_walk_and_get()

Implement kernfs_walk_and_get() which is similar to kernfs_find_and_get() but can walk a path instead of just a name. v2: Use strlcpy() instead of strlen() + memcpy() as suggested by David. Signed-off-by: Tejun Heo Acked-by: Greg Kroah-Hartman

[PATCH] VSOCK: constify vmci_transport_notify_ops structures

The vmci_transport_notify_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- net/vmw_vsock/vmci_transport.h |2 +- net/vmw_vsock/vmci_transport_notify.c|2 +-

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

Tejun Heo wrote: > On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote: > > > +struct xt_cgroup_info_v1 { > > > + __u8has_path; > > > + __u8has_classid; > > > + __u8invert_path; > > > + __u8invert_classid; > > > + char

Re: Kernel 4.1.12 crash

On 11/21/2015 12:16 AM, Andrew wrote: Memory corruption, if happens, IMHO shouldn't be a hardware-related - almost all of these boxes, except H61M-based box from 1st log, works for a long time with uptime more than year; and only software was changed on it; H61M-based box runs memtest86 for a

[PATCH] tipc: fix error handling of expanding buffer headroom

Coverity says: *** CID 1338065: Error handling issues (CHECKED_RETURN) /net/tipc/udp_media.c: 162 in tipc_udp_send_msg() 156 struct udp_media_addr *dst = (struct udp_media_addr *)>value; 157 struct udp_media_addr *src = (struct udp_media_addr *)>addr.value; 158

[PATCH] tipc: avoid packets leaking on socket receive queue

Even if we drain receive queue thoroughly in tipc_release() after tipc socket is removed from rhashtable, it is possible that some packets are in flight because some CPU runs receiver and did rhashtable lookup before we removed socket. They will achieve receive queue, but nobody delete them at

[PATCH 04/13] net: mvneta: enable suspend/resume support

This commit introduces suspend/resume routines used for both in 'standby' and 'mem' modes. For the latter, in which registers' contents are lost, following steps are performed: * in suspend - update port statistics and, if interface is running, detach netif, clean the queues, disable cpu

[PATCH 00/13] mvneta Buffer Management and enhancements

Hi, Hereby I submit a patchset that introduces various fixes and support for new features and enhancements to the mvneta driver: 1. First three patches are minimal fixes, stable-CC'ed. 2. Suspend to ram ('s2ram') support. Due to some stability problems Thomas Petazzoni's patches did not get

[PATCH 11/13] ARM: mvebu: enable buffer manager support on Armada 38x boards

Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on: * A385-DB-AP - each port has its own pool for long and common pool for short packets, * A388-DB - to each port unique 'short' and 'long'

[PATCH 13/13] ARM: mvebu: enable buffer manager support on Armada XP boards

Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on AXP-DB and AXP-GP in same manner - because number of ports on those boards is the same as number of possible pools, each port is supposed

[PATCH 12/13] ARM: mvebu: add buffer manager nodes to armada-xp.dtsi

Armada XP network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-xp.dtsi - for the actual common BM unit (bm@c) and its internal SRAM (bm-bppi), which is used for indirect access to buffer pointer ring

[PATCH 06/13] net: mvneta: enable mixed egress processing using HR timer

Mixed approach allows using higher interrupt threshold (increased back to 15 packets), useful in high throughput. In case of small amount of data or very short TX queues HR timer ensures releasing buffers with small latency. Along with existing tx_done processing by coalescing interrupts this

[PATCH 10/13] ARM: mvebu: add buffer manager nodes to armada-38x.dtsi

Armada 38x network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its internal SRAM (bm-bppi), which is used for indirect access to buffer pointer ring

[PATCH 08/13] ARM: mvebu: enable SRAM support in mvebu_v7_defconfig

Signed-off-by: Marcin Wojtas --- arch/arm/configs/mvebu_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig index c6729bf..fe57e20 100644 --- a/arch/arm/configs/mvebu_v7_defconfig +++

[PATCH 05/13] net: mvneta: add xmit_more support

From: Simon Guinot Basing on xmit_more flag of the skb, TX descriptors can be concatenated before flushing. This commit delay Tx descriptor flush if the queue is running and if there is more skb's to send. Signed-off-by: Simon Guinot ---

[PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

This commit enables finding appropriate mbus window and obtaining its target id and attribute for given physical address in two separate routines, both for IO and DRAM windows. This functionality is needed for Armada XP/38x Network Controller's Buffer Manager and PnC configuration. Signed-off-by:

[PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection

This commit adds missing configuration of MBUS windows access protection in mvneta_conf_mbus_windows function - a dedicated variable for that purpose remained there unused since v3.8 initial mvneta support. Because of that the register contents were inherited from the bootloader. Signed-off-by:

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Less checks in batadv_tvlv_unicast_send()

On Sunday, November 15, 2015 09:45:51 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Nov 2015 09:00:42 +0100 > > * Let us return directly if a call of the batadv_orig_hash_find() function > returned a null pointer. > > * Omit the initialisation

Re: [PATCH net] vrf: fix double free and memory corruption on register_netdevice failure

On 11/21/15 11:46 AM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When vrf's ->newlink is called, if register_netdevice() fails then it does free_netdev(), but that's also done by rtnl_newlink() so a second free happens and memory gets corrupted, to

[PATCH] broadcom: fix PHY_ID_BCM5481 entry in the id table

Commit fcb26ec5b18d ("broadcom: move all PHY_ID's to header") updated broadcom_tbl to use PHY_IDs, but incorrectly replaced 0x0143bca0 with PHY_ID_BCM5482 (making a duplicate entry, and completely omitting the original). Fix that. Fixes: fcb26ec5b18d ("broadcom: move all PHY_ID's to header")

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

On Fri, Nov 20, 2015 at 11:30:13AM +0100, Hannes Frederic Sowa wrote: > Hi Alexei, > > > If user space can be see both 'count' and 'max_entries', it can be very > > tempting to start assuming 'full' and 'empty' state of the map which will > > lead to race conditions and bad design. > > bpf

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Delete an unnecessary check before the function call "batadv_softif_vlan_free_ref"

On Tuesday, November 03, 2015 21:52:58 SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 3 Nov 2015 19:20:34 +0100 > > The batadv_softif_vlan_free_ref() function tests whether its argument is > NULL and then returns immediately. Thus the test around the

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb"

On Sunday, November 15, 2015 09:43:26 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Nov 2015 08:04:43 +0100 > > The kfree_skb() function tests whether its argument is NULL and then > returns immediately. Thus the test around the calls is not

Re: r8169 regression: UDP packets dropped intermittantly

Francois Romieu : [...] If you can crash your system at will, you may apply the patch below to da78dbff2e05630921c551dbbc70a4b7981a8fff ("r8169: remove work from irq handler.") parent (aka 1e874e041fc7c222cbd85b20c4406070be1f687a) and build it in a current tree (say 4.2).

Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Split a condition check

On Tuesday, November 03, 2015 21:54:35 SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 3 Nov 2015 20:41:02 +0100 > > Let us split a check for a condition at the beginning of the > batadv_is_ap_isolated() function so that a direct return can be

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

On Saturday 2015-11-21 19:54, Florian Westphal wrote: > >The only other question I have is wheter PATH_MAX might be a possible >ABI breaker in future. It would have to be guaranteed that this is the >same size forever, else you'd get strange errors on rule insertion if >the sizes of the kernel

Re: [PATCH] packet: Allow packets with only a header (but no payload)

Hello. On 11/21/2015 3:50 AM, Martin Blumenstingl wrote: 9c70776 added validation for the packet size in packet_snd. This change Please run your patch thru scripts/checkpatch.pl -- it now enforces certain commit citing style. enforced that every packet needs a header with at least

Re: Kernel 4.1.12 crash

Memory corruption, if happens, IMHO shouldn't be a hardware-related - almost all of these boxes, except H61M-based box from 1st log, works for a long time with uptime more than year; and only software was changed on it; H61M-based box runs memtest86 for a tens of hours w/o any error. If it was

[patch] net/hsr: fix a warning message

WARN_ON_ONCE() takes a condition, it doesn't take an error message. I have converted this to WARN() instead. Signed-off-by: Dan Carpenter diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index 35a9788..c7d1adc 100644 --- a/net/hsr/hsr_device.c +++

Linux 3.16.7: WARNING at kernfs_get+0x2a/0x30() and ida_remove+0xdd/0x120() in loop

Last week I have a problem with kernel update my PPPoE BRAS server from Linux 3.2.0-4-686-pae #1 SMP Debian 3.2.68-1+deb7u1 i686 GNU/Linux to 3.16.0-4-686-pae #1 Debian 3.16.7-ckt11-1+deb8u5. At any time, for no reason, at any load server downed to oops with following trace