[PATCH net-next v4 0/2] Netronome NFP4000/NFP6000 NIC VF driver

2015-11-25 Thread Jakub Kicinski
This patchset adds support for VFs of Netronome's NFP-4000 and NFP-6000 based NICs. We are currently also preparing the submission for the PF driver, but it is not quite ready yet. The PF driver can be found on GitHub: https://github.com/Netronome/nfp-drv-kmods Jakub Kicinski (2): pci_ids:

[PATCH net-next v4 1/2] pci_ids: add Netronome Systems vendor

2015-11-25 Thread Jakub Kicinski
Add PCI vendor id for Netronome Systems. Signed-off-by: Jakub Kicinski Signed-off-by: Rolf Neugebauer --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: > Mason writes: > >> On 25/11/2015 13:45, Måns Rullgård wrote: >> >>> Mason wrote: >>> On 19/11/2015 14:02, Mans Rullgard wrote: > + if (dma_mapping_error(>dev, dma_addr)) { > +

Re: [RFCv2 bluetooth-next 1/3] 6lowpan: add debugfs support

2015-11-25 Thread Stefan Schmidt
Hello. On 17/11/15 23:33, Alexander Aring wrote: This patch will introduce a 6lowpan entry into the debugfs if enabled. Inside this 6lowpan directory we create a subdirectories of all 6lowpan interfaces to offer a per interface debugfs support. This will be useful for other things as well

Re: [RFCv2 bluetooth-next 2/3] ipv6: add ipv6_addr_prefix_cpy

2015-11-25 Thread Stefan Schmidt
Hello. On 18/11/15 14:55, Sergei Shtylyov wrote: Hello. On 11/18/2015 1:33 AM, Alexander Aring wrote: This patch adds a static inline function ipv6_addr_prefix_cpy which I suggest not to reduce "copy". Agreed. Not worth saving one character here. copies a ipv6 address

Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support

2015-11-25 Thread Thomas Petazzoni
Gregory, On Wed, 25 Nov 2015 15:54:03 +0100, Gregory CLEMENT wrote: > pp->rxq_def = rxq_def; > > + pp->indir[0] = rxq_def; So now we have the RX queue in both pp->rxq_def and pp->indir[0] ? Is this really useful ? Also, if the RX queue becomes a per-port definition, why do you keep

[PATCH net] drivers: net: xgene: fix possible use after free

2015-11-25 Thread Eric Dumazet
From: Eric Dumazet Once TX has been enabled on a NIC, it is illegal to access skb, as this skb might have been freed by another cpu, from TX completion handler. Signed-off-by: Eric Dumazet Reported-by: Mark Rutland Tested-by:

Re: [net-next 06/16] i40e: Properly cast type for arithmetic

2015-11-25 Thread Rustad, Mark D
Joe Perches wrote: > On Wed, 2015-11-25 at 02:46 -0800, Jeff Kirsher wrote: >> On Tue, 2015-11-24 at 16:43 -0800, Joe Perches wrote: >>> On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote: From: Helin Zhang Pointer of type void *

Re: [RFCv2 bluetooth-next 3/3] 6lowpan: iphc: add support for stateful compression

2015-11-25 Thread Stefan Schmidt
Helllo. On 17/11/15 23:33, Alexander Aring wrote: This patch introduce support for IPHC stateful address compression. It will offer three debugfs per interface entries, which are: - dci_table: destination context indentifier table - sci_table: source context indentifier table -

TUN interfaces loopback

2015-11-25 Thread Radu Rendec
Disclaimer: I know this is a *development* list, but I feel the answer lies deep down in the ipv4 routing code, so it's more likely that I find help here. That being said, I have two TUN interfaces that are "cross-connected" in user space (i.e. whatever is read on the socket corresponding to

[PATCH 0/2] Basic support for Solarflare 8000 series NICs

2015-11-25 Thread Bert Kenward
The upcoming Solarflare 8000 series 10G/40G network card supports a similar interface to the current 7000 series cards. This patch series provides basic support for these cards, making no use of any new functionality. Bert Kenward (2): sfc: make TSO version a per-queue parameter sfc: Add

Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy

2015-11-25 Thread Bjørn Mork
Anup Limbu writes: > replace kmalloc + memset with kmemdup > > Signed-off-by: Anup Limbu > --- > drivers/net/usb/ch9200.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/usb/ch9200.c b/drivers/net/usb/ch9200.c

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 8:02 AM, Lan, Tianyu wrote: > On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: >> >> Frankly, I don't really see what this short term hack buys us, >> and if it goes in, we'll have to maintain it forever. >> > > The framework of how to notify VF about

Re: [PATCH 06/13] net: tcp_memcontrol: simplify the per-memcg limit access

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:51:58 -0500 > tcp_memcontrol replicates the global sysctl_mem limit array per > cgroup, but it only ever sets these entries to the value of the > memory_allocated page_counter limit. Use the latter directly. > > Signed-off-by:

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-25 Thread Sowmini Varadhan
On (11/24/15 17:25), Florian Westphal wrote: > Its a well-written document, but I don't see how moving the burden of > locking a single logical tcp connection (to prevent threads from > reading a partial record) from userspace to kernel is an improvement. > > If you really have 100 threads and

Re: [PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

2015-11-25 Thread David Miller
From: Joe Perches Date: Tue, 24 Nov 2015 17:04:11 -0800 > On Tue, 2015-11-24 at 15:29 -0800, Florian Fainelli wrote: >> Now that there is a reviewer role, add myself as reviewer since the PHY >> library code is maintained via the networking tree. > > [] > >> diff --git

WARNING in tcp_recvmsg

2015-11-25 Thread Dmitry Vyukov
Hello, The following program triggers WARNING in tcp_recvmsg: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include #include int fd = -1; void *thr0(void *arg) { memcpy((void*)0x20003000,

Re: [RFCv2 bluetooth-next 2/3] ipv6: add ipv6_addr_prefix_cpy

2015-11-25 Thread Stefan Schmidt
Hello. On 17/11/15 23:33, Alexander Aring wrote: This patch adds a static inline function ipv6_addr_prefix_cpy which copies a ipv6 address prefix(argument pfx) into the ipv6 address prefix. The prefix len is given by plen as bits. This function mainly based on ipv6_addr_prefix which copies one

[PATCH net] openvswitch: properly refcount vport-vxlan module

2015-11-25 Thread Paolo Abeni
After 614732eaa12d, no refcount is mainteined for the vport-vxlan module. This allows the userspace to remove such module while vport-vxlan devices still exist, which lead to later oops, i.e. when the openvswitch module is removed. Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Alexander Duyck writes: > On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >> Mason writes: >> >>> On 25/11/2015 13:45, Måns Rullgård wrote: >>> Mason wrote: > On 19/11/2015 14:02, Mans Rullgard wrote: >

Re: [PATCH 09/13] mm: memcontrol: generalize the socket accounting jump label

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:52:01 -0500 > The unified hierarchy memory controller is going to use this jump > label as well to control the networking callbacks. Move it to the > memory controller code and give it a more generic name. > > Signed-off-by:

Re: [PATCH 12/13] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:58:44 -0500 > Socket memory can be a significant share of overall memory consumed by > common workloads. In order to provide reasonable resource isolation in > the unified hierarchy, this type of memory needs to be included in

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Michael S. Tsirkin
On Wed, Nov 25, 2015 at 08:24:38AM -0800, Alexander Duyck wrote: > >> Also, assuming you just want to do ifdown/ifup for some reason, it's > >> easy enough to do using a guest agent, in a completely generic way. > >> > > > > Just ifdown/ifup is not enough for migration. It needs to restore some

Re: [PATCH net] isdn: Partially revert debug format string usage clean up

2015-11-25 Thread David Miller
From: Christoph Biedl Date: Wed, 25 Nov 2015 07:47:40 +0100 > Commit 35a4a57 ("isdn: clean up debug format string usage") introduced > a safeguard to avoid accidential format string interpolation of data > when calling debugl1 or HiSax_putstatus. This did

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Lan, Tianyu
On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: Frankly, I don't really see what this short term hack buys us, and if it goes in, we'll have to maintain it forever. The framework of how to notify VF about migration status won't be changed regardless of stopping VF or not before doing

Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 15:59 +, Mark Rutland wrote: > xgene_enet_start_xmit Please try following trivial fix diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 1adfe7036843..9147a0107c44 100644 ---

Re: [PATCH net-next v5] mpls: support for dead routes

2015-11-25 Thread David Miller
From: Roopa Prabhu Date: Tue, 24 Nov 2015 15:22:22 -0800 > v4 -v5 > - if kmemdup fails, modify the original route in place. This is a > corner case and only side effect is that in the remote case > of kmemdup failure, the changes will not be

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Mason writes: > On 25/11/2015 17:16, Måns Rullgård wrote: > >> Alexander Duyck writes: >> >>> On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >>> Mason writes: > On 25/11/2015 13:45, Måns Rullgård wrote: > >> Mason wrote: >> >>> On

Re: [PATCH 13/13] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:59:40 -0500 > Let the networking stack know when a memcg is under reclaim pressure > so that it can clamp its transmit windows accordingly. > > Whenever the reclaim efficiency of a cgroup's LRU lists drops low > enough for a

Re: [PATCH net-next] net: phy: bcm7xxx: Add entry for Broadcom BCM7435

2015-11-25 Thread David Miller
From: Florian Fainelli Date: Tue, 24 Nov 2015 15:30:21 -0800 > Add a PHY entry for the Broadcom BCM7435 chips, this is a 40nm > generation Ethernet PHY which is analogous to its 7425 and 7429 counter > parts. > > Signed-off-by: Florian Fainelli

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 12:21 AM, Lan Tianyu wrote: > On 2015年11月25日 13:30, Alexander Duyck wrote: >> No, what I am getting at is that you can't go around and modify the >> configuration space for every possible device out there. This >> solution won't scale. > > > PCI

[PATCH 1/2] sfc: make TSO version a per-queue parameter

2015-11-25 Thread Bert Kenward
The Solarflare 8000 series NIC will use a new TSO scheme. The current driver refuses to load if the current TSO scheme is not found. Remove that check and instead make the TSO version a per-queue parameter. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 12:02:33AM +0800, Lan, Tianyu wrote: > On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: > >Frankly, I don't really see what this short term hack buys us, > >and if it goes in, we'll have to maintain it forever. > > > > The framework of how to notify VF about migration

Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2

2015-11-25 Thread Mark Rutland
On Wed, Nov 25, 2015 at 08:17:36AM -0800, Eric Dumazet wrote: > On Wed, 2015-11-25 at 15:59 +, Mark Rutland wrote: > > xgene_enet_start_xmit > > Please try following trivial fix With that applied KASAN is silent, despite my efforts to trigger the issue, so it looks like that fixes it.

Re: [PATCH 11/13] mm: memcontrol: move socket code for unified hierarchy accounting

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:52:03 -0500 > The unified hierarchy memory controller will account socket > memory. Move the infrastructure functions accordingly. > > Signed-off-by: Johannes Weiner > Acked-by: Michal Hocko

Re: net: Generalise wq_has_sleeper helper

2015-11-25 Thread David Miller
From: Peter Zijlstra Date: Wed, 25 Nov 2015 10:15:33 +0100 > On Tue, Nov 24, 2015 at 01:54:23PM +0800, Herbert Xu wrote: >> + * The race for tcp fires when the __add_wait_queue changes done by CPU1 >> stay >> + * in its cache, and so does the tp->rcv_nxt update on CPU2

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Tue, Nov 24, 2015 at 5:10 PM, Rainer Weikusat > wrote: [...] >> It's also easy to verify: Swap the unix_state_lock and >> other->sk_data_ready and see if the issue still occurs. Right now (this >> may change

[PATCH 2/2] sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC.

2015-11-25 Thread Bert Kenward
Also add support for 7000 series 40G NIC VF. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 4e82bcf..b405349 100644 ---

Re: [PATCH 10/13] mm: memcontrol: do not account memory+swap on unified hierarchy

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:52:02 -0500 > The unified hierarchy memory controller doesn't expose the memory+swap > counter to userspace, but its accounting is hardcoded in all charge > paths right now, including the per-cpu charge cache ("the stock"). > >

Re: [PATCH 08/13] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:52:00 -0500 > There won't be any separate counters for socket memory consumed by > protocols other than TCP in the future. Remove the indirection and > link sockets directly to their owning memory cgroup. > > Signed-off-by:

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 16:43 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Tue, Nov 24, 2015 at 5:10 PM, Rainer Weikusat > > wrote: > > [...] > > >> It's also easy to verify: Swap the unix_state_lock and > >>

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 8:39 AM, Michael S. Tsirkin wrote: > On Wed, Nov 25, 2015 at 08:24:38AM -0800, Alexander Duyck wrote: >> >> Also, assuming you just want to do ifdown/ifup for some reason, it's >> >> easy enough to do using a guest agent, in a completely generic way. >> >>

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 16:43 +, Rainer Weikusat wrote: >> Eric Dumazet writes: >> > On Tue, Nov 24, 2015 at 5:10 PM, Rainer Weikusat >> > wrote: >> >> [...] >> >> >> It's also easy to

KASAN failures in X-Gene ethernet driver in v4.4-rc2

2015-11-25 Thread Mark Rutland
While testing a v4.4-rc2 defconfig + KASAN_INLINE kernel on an X-Gene platform, I spotted the KASAN warnings below. I'm using the Linaro 15.08 little-endian AArch64 GCC [1] to enable KASAN_INLINE. My rootfs is an NFS mount. Most of the time I can trigger the issue by grabbing the kernel source

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Mason
On 25/11/2015 17:16, Måns Rullgård wrote: > Alexander Duyck writes: > >> On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >> >>> Mason writes: >>> On 25/11/2015 13:45, Måns Rullgård wrote: > Mason wrote: > >> On 19/11/2015 14:02, Mans Rullgard wrote: >> >>> +

Re: [PATCH 07/13] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-25 Thread David Miller
From: Johannes Weiner Date: Tue, 24 Nov 2015 16:51:59 -0500 > There won't be a tcp control soft limit, so integrating the memcg code > into the global skmem limiting scheme complicates things > unnecessarily. Replace this with simple and clear charge and uncharge >

Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support

2015-11-25 Thread Gregory CLEMENT
Hi Thomas, On mer., nov. 25 2015, Thomas Petazzoni wrote: > Gregory, > > On Wed, 25 Nov 2015 15:54:03 +0100, Gregory CLEMENT wrote: > >> pp->rxq_def = rxq_def; >> >> +pp->indir[0] = rxq_def; > > So now we have the RX queue in both pp->rxq_def

Re: use-after-free in sock_wake_async

2015-11-25 Thread Hannes Frederic Sowa
On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > I do agree that keeping the ->sk_data_ready outside of the lock will > > very likely have performance advantages. That's just something I > > wouldn't have undertaken because I'd

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 14:32 -0800, Eric Dumazet wrote: > On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: > > > > diff --git a/include/net/sock.h b/include/net/sock.h > > > index 7f89e4ba18d1..ead514332ae8 100644 > > > --- a/include/net/sock.h > > > +++ b/include/net/sock.h > > > @@ -776,7

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Richard Weinberger
Am 25.11.2015 um 23:38 schrieb Florian Fainelli: > On 25/11/15 01:21, Richard Weinberger wrote: >> Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: >>> On Wed, 25 Nov 2015 01:24:47 +0100 >>> Richard Weinberger wrote: >>> Am 25.11.2015 um 01:15 schrieb Richard Weinberger:

[PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new

[PATCH net-next v3 3/8] netfilter: Allow calling into nat helper without skb_dst.

2015-11-25 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar

[PATCH net-next v3 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2015-11-25 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++---

[PATCH net-next v3 5/8] openvswitch: Find existing conntrack entry after upcall.

2015-11-25 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall.

[PATCH net-next v3 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2015-11-25 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH net-next v3 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-11-25 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Florian Fainelli
On 25/11/15 01:21, Richard Weinberger wrote: > Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: >> On Wed, 25 Nov 2015 01:24:47 +0100 >> Richard Weinberger wrote: >> >>> Am 25.11.2015 um 01:15 schrieb Richard Weinberger: Hi! Today I was hunting down an issue where

Re: severe regression in alx ethernet driver

2015-11-25 Thread Francois Romieu
Jarod Wilson : [...] > They do at least have a signed-off-by in the patches attached to the bug, > so I'm working on touching up the descriptions and formatting, regression > testing them on my laptop that has an alx-driven E2200 in it (which isn't > affected by this bug), and

[PATCH net-next v3 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-11-25 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +---

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > In case this is wrong, it obviously implies that sk_sleep(sk) must not > be used anywhere as it accesses the same struck sock, hence, when that > can "suddenly" disappear despite locks are used in the way indicated > above, there is now

Re: [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection

2015-11-25 Thread Gregory CLEMENT
Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > This commit adds missing configuration of MBUS windows access protection > in mvneta_conf_mbus_windows function - a dedicated variable for that > purpose remained there unused since v3.8 initial mvneta support.

Re: [PATCH net] isdn: Partially revert debug format string usage clean up

2015-11-25 Thread Kees Cook
On Tue, Nov 24, 2015 at 10:47 PM, Christoph Biedl wrote: > Commit 35a4a57 ("isdn: clean up debug format string usage") introduced > a safeguard to avoid accidential format string interpolation of data > when calling debugl1 or HiSax_putstatus. This did

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 23:32 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > > > I do agree that keeping the ->sk_data_ready outside of the lock will > > > very likely have performance

Re: [Resend PATCH] RDS: fix race condition when sending a message on unbound socket

2015-11-25 Thread santosh shilimkar
On 11/25/2015 4:52 AM, Quentin Casasnovas wrote: On Wed, Nov 25, 2015 at 12:21:45PM +, David Laight wrote: From: Santosh Shilimkar Sent: 24 November 2015 22:13 ... Sasha's found a NULL pointer dereference in the RDS connection code when sending a message to an apparently unbound socket.

Re: linux-next: manual merge of the net-next tree with the net tree

2015-11-25 Thread Daniel Borkmann
On 11/26/2015 01:01 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/syscall.c between commit: c9da161c6517 ("bpf: fix clearing on persistent program array maps") from the net tree and commit: f99bf205dab0 ("bpf: add

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: > > diff --git a/include/net/sock.h b/include/net/sock.h > > index 7f89e4ba18d1..ead514332ae8 100644 > > --- a/include/net/sock.h > > +++ b/include/net/sock.h > > @@ -776,7 +776,7 @@ static inline int sk_memalloc_socks(void) > > > > static

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Richard Weinberger
Hi! Am 25.11.2015 um 23:30 schrieb Santiago Garcia Mantinan: > Hi! > >> Ask Debian maintainer to send his patches, I don't go patch hunting. > > > While looking what other distros do I came across this patch: > >

Re: use-after-free in sock_wake_async

2015-11-25 Thread Hannes Frederic Sowa
On Wed, Nov 25, 2015, at 23:43, Eric Dumazet wrote: > On Wed, 2015-11-25 at 23:32 +0100, Hannes Frederic Sowa wrote: > > On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > > > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > > > > > I do agree that keeping the ->sk_data_ready

linux-next: manual merge of the net-next tree with the net tree

2015-11-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/syscall.c between commit: c9da161c6517 ("bpf: fix clearing on persistent program array maps") from the net tree and commit: f99bf205dab0 ("bpf: add show_fdinfo handler for maps") from the net-next

[PATCH net-next v3 0/8] openvswitch: NAT support.

2015-11-25 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch

[PATCH net-next v3 2/8] netfilter: Factor out nf_ct_get_info().

2015-11-25 Thread Jarno Rajahalme
Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch ("openvswitch: Find existing conntrack entry after upcall."). Signed-off-by: Jarno Rajahalme ---

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 7:15 PM, Dong, Eddie wrote: >> On Wed, Nov 25, 2015 at 12:21 AM, Lan Tianyu wrote: >> > On 2015年11月25日 13:30, Alexander Duyck wrote: >> >> No, what I am getting at is that you can't go around and modify the >> >> configuration

Re: [PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/openvswitch-NAT-support/20151126-081504 config: x86_64-randconfig-n0-11260924 (attached as .config) reproduce: # save the attached .config to linux build tree

Re: severe regression in alx ethernet driver

2015-11-25 Thread David Miller
From: Francois Romieu Date: Wed, 25 Nov 2015 23:47:08 +0100 > Jarod Wilson : > [...] >> They do at least have a signed-off-by in the patches attached to the bug, >> so I'm working on touching up the descriptions and formatting, regression >> testing them

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Aaron Conole
Eric Dumazet writes: > On Wed, 2015-11-25 at 14:32 -0800, Eric Dumazet wrote: >> On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: >> >> > > diff --git a/include/net/sock.h b/include/net/sock.h >> > > index 7f89e4ba18d1..ead514332ae8 100644 >> > > ---

RE: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-25 Thread Dong, Eddie
> On Wed, Nov 25, 2015 at 12:21 AM, Lan Tianyu wrote: > > On 2015年11月25日 13:30, Alexander Duyck wrote: > >> No, what I am getting at is that you can't go around and modify the > >> configuration space for every possible device out there. This > >> solution won't scale. > >

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 22:17 -0500, Aaron Conole wrote: > Probably that would call for a different more primitive version of this > API (sk_gfp_or_memalloc() as you suggest below). Then this could be > written in terms of that > > static inline sk_gfp_or_memalloc(const struct sock *sk, gfp_t

Re: [PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/openvswitch-NAT-support/20151126-081504 config: x86_64-randconfig-s0-11260956 (attached as .config) reproduce: # save the attached .config to linux build tree

[PATCH v2 1/4] staging: rtl8712: Remove casts between void * and type *

2015-11-25 Thread Mauro Dreissig
This removes unnecessary explicit pointer casts in rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Sergei Shtylyov
Hello. On 11/25/2015 09:21 PM, Jeff Kirsher wrote: From: Shannon Nelson There's really no reason to kill the kernel thread just because of a little info string. This reworks the code to use snprintf's limiting to assure that the string is never too long, and WARN_ON

Re: [RFCv2 bluetooth-next 2/3] ipv6: add ipv6_addr_prefix_cpy

2015-11-25 Thread Alexander Aring
On Wed, Nov 25, 2015 at 05:42:52PM +0100, Stefan Schmidt wrote: > Hello. > > On 17/11/15 23:33, Alexander Aring wrote: > >This patch adds a static inline function ipv6_addr_prefix_cpy which > >copies a ipv6 address prefix(argument pfx) into the ipv6 address prefix. > >The prefix len is given by

Re: [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG

2015-11-25 Thread Gregory CLEMENT
Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer > allocation was mistakenly set as BIT(1). This commit fixes the > assignment. I confirm it from the datasheet I got: Reviewed-by: Gregory CLEMENT

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 18:24 +, Rainer Weikusat wrote: >> Eric Dumazet writes: >> > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: >> > >> >> In case this is wrong, it obviously implies that sk_sleep(sk) must

[PATCH v2 0/4] Cleanups for rtl871x_ioctl_rtl

2015-11-25 Thread Mauro Dreissig
This applies some janitorial work to rtl8712 driver. Mauro Dreissig (4): staging: rtl8712: Remove casts between void * and type * staging: rtl8712: Rename local variable staging: rtl8712: Make error handling check for failure staging: rtl8712: Rename local variable

[PATCH v2 2/4] staging: rtl8712: Rename local variable

2015-11-25 Thread Mauro Dreissig
Renames all instances of struct _adapter to adapter in rtl871x_ioctl_rtl.c, avoiding camel case. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 ++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git

[PATCH] packet.7: Indicate CAP_NET_BIND_SERVICE capability is required for binding packet sockets

2015-11-25 Thread Stewart Brodie
Adds a note to packet.7 that the calling process must have the CAP_NET_BIND_SERVICE capability in order to call bind on packet sockets. The linux/capability.h header file comments for CAP_NET_BIND_SERVICE do not document this requirement either. I did take a brief look in the kernel source code

[net-next v2 15/15] i40e: Bump version to 1.4.2

2015-11-25 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I2d1ce93b2ce74e4eef2394c932aef52cba99713f Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next v2 11/15] i40evf: handle many MAC filters correctly

2015-11-25 Thread Jeff Kirsher
From: Mitch Williams When a lot (many hundreds) of MAC or VLAN filters are added at one time, we can overflow the Admin Queue buffer size with all the requests. Unfortunately, the driver would then calculate the message size incorrectly, causing it to be rejected by

[net-next v2 06/15] i40e: Workaround fix for mss < 256 issue

2015-11-25 Thread Jeff Kirsher
From: Anjali Singhai Jain HW/NVM sets a limit of no less than 256 bytes for MSS. Stack can send as low as 76 bytes MSS. This patch lowers the HW limit to 64 bytes to avoid MDDs from firing and causing a reset when the MSS is lower than 256. Change-ID:

[net-next v2 12/15] i40e: return the number of enabled queues for ETHTOOL_GRXRINGS

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang This patch fixes a problem where using ethtool rxnfc command could let RX flow hash be set on disabled queues. This patch fixes the problem by returning the number of enabled queues before setting rxnfc. Change-ID:

[net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Jeff Kirsher
From: Shannon Nelson There's really no reason to kill the kernel thread just because of a little info string. This reworks the code to use snprintf's limiting to assure that the string is never too long, and WARN_ON to still put out a warning that we might want to look

[net-next v2 07/15] i40e/i40evf: Add a stat to track how many times we have to do a force WB

2015-11-25 Thread Jeff Kirsher
From: Anjali Singhai Jain When in NAPI with interrupts disabled, the HW needs to be forced to do a write back on TX if the number of descriptors pending are less than a cache line. This stat helps keep track of how many times we get into this situation. Change-ID:

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 19:38 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Wed, 2015-11-25 at 18:24 +, Rainer Weikusat wrote: > >> Eric Dumazet writes: > >> > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > >> > > >> >>

[PATCH v2 4/4] staging: rtl8712: Rename local variable

2015-11-25 Thread Mauro Dreissig
Renames all instances of struct oid_par_priv to oid in rtl871x_ioctl_rtl.c and rtl871x_ioctl_rtl.h, making the code cleaner. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 292 +---

[PATCH v2 3/4] staging: rtl8712: Make error handling check for failure

2015-11-25 Thread Mauro Dreissig
Make all error handling paths check for failure instead of success in rtl871x_ioctl_rtl.c, reducing indentation and avoiding else statements. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 +++- 1 file changed, 124

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Joe Perches
On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > From: Shannon Nelson > > > > > > There's really no reason to kill the kernel thread just because

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > >> In case this is wrong, it obviously implies that sk_sleep(sk) must not >> be used anywhere as it accesses the same struck sock, hence, when that >> can "suddenly" disappear despite locks

Re: WARNING in tcp_recvmsg

2015-11-25 Thread Eric Dumazet
On Wed, Nov 25, 2015 at 8:36 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers WARNING in tcp_recvmsg: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > #include

Re: [PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

2015-11-25 Thread Florian Fainelli
On 25/11/15 08:36, David Miller wrote: > From: Joe Perches > Date: Tue, 24 Nov 2015 17:04:11 -0800 > >> On Tue, 2015-11-24 at 15:29 -0800, Florian Fainelli wrote: >>> Now that there is a reviewer role, add myself as reviewer since the PHY >>> library code is maintained via the

[net-next v2 13/15] i40e: rework the functions to configure RSS with similar parameters

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks. Change-ID: If446e34fcfaf1bc3320d9d319829a095b5976e67 Signed-off-by: Helin Zhang Tested-by: Andrew Bowers

  1   2   >