Re: [PATCH net] net:sysctl fix the confusing corner of tcp_mem

2015-12-20 Thread Hanjun Guo
Hi Eric, On 2015/12/10 0:38, Eric W. Biederman wrote: > Wang Yufen writes: > >> From: Yufen Wang >> >> I tried on linux-4.1: >> linux:~# cat /proc/sys/net/ipv4/tcp_mem >> 8388608 1258291216777216 >> linux:~# echo 1234

Re: [PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB

2015-12-20 Thread Or Gerlitz
On Sun, Dec 20, 2015 at 11:46 PM, Saeed Mahameed wrote: > From: Achiad Shochat > > If the SKB is cloned, or has an elevated users count, someone else > can be looking at it at the same time. > drivers/net/ethernet/mellanox/mlx5/core/en.h |5 +- >

[PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-20 Thread Saeed Mahameed
From: Eran Ben Elisha Add support for enable/disable HW timestamping for incoming and/or outgoing packets. To enable/disable HW timestamping appropriate ioctl should be used. Currently HWTSTAMP_FILTER_ALL/NONE and HWTSAMP_TX_ON/OFF only are supported. Make all relevant

[PATCH net-next V2 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

2015-12-20 Thread Saeed Mahameed
From: Eran Ben Elisha Add a PHC support to the mlx5_en driver. Use reader/writer spinlocks to protect the timecounter since every packet received needs to call timecounter_cycle2time() when timestamping is enabled. This can become a performance bottleneck with RSS and

[PATCH net-next V2 2/4] net/mlx5_core: Add support for reading hardware timestamp

2015-12-20 Thread Saeed Mahameed
From: Eran Ben Elisha A preparation step which adds support for reading the hardware timestamp from the internal clock and from the CQE. In addition, advertize device_frequency_khz HCA capability. Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed

[PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB

2015-12-20 Thread Saeed Mahameed
From: Achiad Shochat If the SKB is cloned, or has an elevated users count, someone else can be looking at it at the same time. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed ---

[PATCH net-next V2 0/4] Introduce mlx5 ethernet timestamping

2015-12-20 Thread Saeed Mahameed
Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. This version addresses all the comments received on v1. The first patch was replaced with a one that addresses the SKB data issue and fixes it in the right way (By Achiad), Also Addressed

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-20 Thread Yoshihiro Kaneko
Hi, 2015-12-18 2:42 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/17/2015 07:29 PM, Yoshihiro Kaneko wrote: > From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for

Re: [PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

2015-12-20 Thread Saeed Mahameed
On Thu, Dec 17, 2015 at 10:20 PM, Richard Cochran wrote: > On Thu, Dec 17, 2015 at 02:35:35PM +0200, Saeed Mahameed wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c >> b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c >> index

[PATCH/RFC v2 net-next] ravb: Add dma queue interrupt support

2015-12-20 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) Signed-off-by: Kazuya Mizuguchi

Re: [PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

2015-12-20 Thread Saeed Mahameed
On Thu, Dec 17, 2015 at 10:21 PM, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 17 Dec 2015 14:35:32 +0200 > >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> index

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-20 Thread Saeed Mahameed
On Thu, Dec 17, 2015 at 10:11 PM, Richard Cochran wrote: > On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: >> @@ -63,6 +65,7 @@ >> #define MLX5E_TX_CQ_POLL_BUDGET128 >> #define MLX5E_UPDATE_STATS_INTERVAL200 /* msecs */ >> #define

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-20 Thread Richard Cochran
On Sun, Dec 20, 2015 at 03:08:18PM +0200, Saeed Mahameed wrote: > Agree, but what will happen if the calculated period is too rapid ? > shouldn't we have some kind of minimum ? If the period is shorter than you can handle, then the clock will overflow and is therefore unusable. Thanks, Richard

[PATCH net-next 5/5] cxgb4: Use napi_complete_done() api in napi handler

2015-12-20 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 138be46..5e3ffa7 100644 ---

[PATCH net-next 2/5] cxgb4: get naming correct for iscsi queues

2015-12-20 Thread Hariprasad Shenai
All the upper level protocols like rdma, iscsi have their own offload rx queues, so instead of using the generic naming convention be specific while naming them. Improves code readability Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h

[PATCH net-next 1/5] cxgb4: Warn if device doesn't have enough PCI bandwidth

2015-12-20 Thread Hariprasad Shenai
Check if the device get enough bandwidth from the entire PCI chain to satisfy its capabilities. This patch determines the PCIe device's bandwidth capabilities by reading its PCIe Link Capabilities registers and then call the pcie_get_minimum_link function to ensure that the adapter is hooked into

[PATCH net-next 0/5] Trivial enhancements for cxgb4

2015-12-20 Thread Hariprasad Shenai
Hi This series adds a debug message if adapter isn't inserted in right PCI slot, adds a debug entry to dump dcb information. Changes naming conventions for iSCSI rx queues, use node info while allocating rx queue and use napi_complete_done() api in napi handler. This patch series has been

[PATCH net-next 4/5] cxgb4: Use the node info to alloc_ring() for RX queues

2015-12-20 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 0333435..138be46 100644 ---

[PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-20 Thread Hariprasad Shenai
Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out various Data Center Bridging information. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 11 -- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h | 11 ++

Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-20 Thread Or Gerlitz
On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai wrote: > Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out > various Data Center Bridging information. why? what's wrong with using the lldp tool for that purpose? -- To unsubscribe from this list: send the line

[PULL] vhost: cleanups and fixes

2015-12-20 Thread Michael S. Tsirkin
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

[PATCH] ibmveth: consolidate kmalloc of array, memset 0 to kcalloc

2015-12-20 Thread Nicholas Mc Guire
This is an API consolidation only. The use of kmalloc + memset to 0 is equivalent to kcalloc in this case as it is allocating an array of elements. Signed-off-by: Nicholas Mc Guire --- Found by coccinelle script (relaxed version of

NULL pointer deref in dccp (inet_csk_listen_start/inet_csk_get_port)

2015-12-20 Thread Vegard Nossum
Hi all, I've been running into the following oops: [ 1128.895622] BUG: unable to handle kernel NULL pointer dereference at (null) [ 1128.896010] IP: [< (null)>] (null) [ 1128.896010] PGD 179ee067 PUD 189b1067 PMD 0 [ 1128.896010] Oops: 0010 [#1] PREEMPT SMP [

Re: [PATCH] ibmveth: consolidate kmalloc of array, memset 0 to kcalloc

2015-12-20 Thread David Miller
From: Nicholas Mc Guire Date: Sun, 20 Dec 2015 15:06:18 +0100 > This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kcalloc in this case as it is allocating an array > of elements. > > Signed-off-by: Nicholas Mc Guire

[PATCH] dccp: fix use-after-free after cloning struct dccp_sock

2015-12-20 Thread Vegard Nossum
I've observed various spew (KASAN, warnings, oopses, etc.) that seem to stem from incorrect cloning of dccp_sock in dccp_create_openreq_child(). The problem is that struct dccp_sock's ->dccps_hc_rx_ackvec, ->dccps_hc_rx_ccid, and ->dccps_hc_tx_ccid members are pointers to memory which is