[PATCH] net-sysfs: use to_net_dev in net_namespace()

2015-12-22 Thread Geliang Tang
Use to_net_dev() instead of open-coding it. Signed-off-by: Geliang Tang --- net/core/net-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index bca8c35..b6c8a66 100644 --- a/net/core/net-sysfs.c +++

Re: [PATCH/RFC v2 net-next] ravb: Add dma queue interrupt support

2015-12-22 Thread Sergei Shtylyov
Hello. On 12/20/2015 12:15 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Hannes Frederic Sowa
On 12.12.2015 20:58, Marc Haber wrote: > Any hints would be appreciated. This sysctl should help: accept_ra_from_local - BOOLEAN Accept RA with source-address that is found on local machine if the RA is otherwise proper and able to be accepted. Default is to NOT accept

Re: pull request (net): ipsec 2015-12-22

2015-12-22 Thread David Miller
From: Steffen Klassert Date: Tue, 22 Dec 2015 10:35:18 +0100 > Just one patch to fix dst_entries_init with multiple namespaces. > From Dan Streetman. > > Please pull or let me know if there are problems. Pulled, thanks Steffen. -- To unsubscribe from this list:

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Marc Haber
Hi Hannes, thanks for your mail. On Tue, Dec 22, 2015 at 04:15:14PM +0100, Hannes Frederic Sowa wrote: > On 12.12.2015 20:58, Marc Haber wrote: > > Any hints would be appreciated. > > This sysctl should help: > > accept_ra_from_local - BOOLEAN > Accept RA with source-address that is

Re: [PATCH 0/2] Netfilter fixes for net

2015-12-22 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 22 Dec 2015 18:53:15 +0100 > The following patchset contains two netfilter fixes: > > 1) Oneliner from Florian to dump missing NFT_CT_L3PROTOCOL netlink >attribute, from Florian Westphal. > > 2) Another oneliner for nf_tables to use

[PATCH net-next 4/4] soreuseport: BPF selection functional test

2015-12-22 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig

[PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the

[PATCH net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2015-12-22 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change

[PATCH net-next 2/4] soreuseport: fast reuseport UDP socket selection

2015-12-22 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This

[PATCH net-next 0/4] Faster SO_REUSEPORT

2015-12-22 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to

Re: [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Mon, 21 Dec 2015 09:56:01 +0100 > From: Ido Schimmel > > The bridge's ageing time is offloaded to hardware when: > 1) A port joins a bridge > 2) The ageing time of the bridge is changed > > In the first case the ageing

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread David Miller
From: Andrey Ryabinin Date: Mon, 21 Dec 2015 12:54:45 +0300 > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry

Re: [patch net-next v2] mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Dec 2015 09:43:07 +0100 > From: Jiri Pirko > > KASan reported use-after-free for the hwmon structure. So fix this by > using devm_kzalloc and let the core take care about freeing the memory > during device dettach. > >

net: user-controllable kmalloc size in __sctp_setsockopt_connectx

2015-12-22 Thread Dmitry Vyukov
Hello, The following program triggers WARNING in kmalloc: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include int main() { long r0 = syscall(SYS_mmap, 0x2000ul, 0x4000ul, 0x3ul, 0x32ul, 0xul, 0x0ul); long

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 3:45 PM, Dave Jones wrote: > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other info

Re: [PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > Hannes points out that when we generate tcp reset for timewait sockets we > pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). > > Make it cope with inet tw sockets and then provide tw sk. > > This makes RSTs appear on

Re: [PATCH] net: tcp: deal with listen sockets properly in tcp_abort.

2015-12-22 Thread David Miller
From: Lorenzo Colitti Date: Tue, 22 Dec 2015 00:03:44 +0900 > When closing a listen socket, tcp_abort currently calls > tcp_done without clearing the request queue. If the socket has a > child socket that is established but not yet accepted, the child > socket is then left

Re: [net-next 00/10][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-22

2015-12-22 Thread David Miller
From: Jeff Kirsher Date: Tue, 22 Dec 2015 06:02:02 -0800 > This series contains updates to fm10k only. Pulled, thanks a lot Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation

2015-12-22 Thread David Miller
From: Bert Kenward Date: Fri, 18 Dec 2015 17:09:04 + > +#ifdef DEBUG > + WARN_ON(1); > +#endif Don't do stuff like this. Either the assertion is valid and belongs here, or it doesn't. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [patch net-next] mlxsw: core: Allow to reset temperature history via hwmon interface

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Mon, 21 Dec 2015 11:14:21 +0100 > From: Jiri Pirko > > Add another sysfs hwmon attribute to expose possibility to reset > temperature sensors history. > > Signed-off-by: Jiri Pirko Applied, thanks Jiri. -- To

Re: net: user-controllable kmalloc size in __sctp_setsockopt_connectx

2015-12-22 Thread Marcelo Ricardo Leitner
Hi, On Tue, Dec 22, 2015 at 09:13:54PM +0100, Dmitry Vyukov wrote: > Hello, ... > > [] __sctp_setsockopt_connectx+0xc6/0x150 > net/sctp/socket.c:1318 > [< inline >] sctp_getsockopt_connectx3 net/sctp/socket.c:1410 > [] sctp_getsockopt+0x25ee/0x3e00 net/sctp/socket.c:6007 > []

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 15:51:19 -0500 > I was actually just looking at this as well (though a slightly > different stack). The issue is with: c6ff5268293e rhashtable: Fix > walker list corruption > > It changed the lock acquired in rhashtable_walk_init

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:50:20PM -0500, David Miller wrote: > > > > Simple fix is below. Though, I don't understand the history of the > > > > multiple locks in this structure to be sure it's correct. I'll send > > > > it as a formal patch. Please reject if it's not the right

Re: [Patch net] addrconf: always initialize sysctl table data

2015-12-22 Thread David Miller
From: Cong Wang Date: Mon, 21 Dec 2015 10:55:45 -0800 > When sysctl performs restrict writes, it allows to write from > a middle position of a sysctl file, which requires us to initialize > the table data before calling proc_dostring() for the write case. > > Fixes:

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 16:58:11 -0500 > On Tue, Dec 22, 2015 at 4:40 PM, David Miller wrote: >> From: Craig Gallek >> Date: Tue, 22 Dec 2015 15:05:07 -0500 >> >>> + for (i = 0; i < reuse->num_socks; i++)

Re: [PATCH v2 -next 0/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread David Miller
From: Florian Westphal Date: Mon, 21 Dec 2015 21:29:23 +0100 > This is V2, this time as a small series since I followed Erics advice > to split this into smaller chunks, I hope this makes it easier to > review. > > First patch adds inet_sk_transparent helper. > Second patch

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread kbuild test robot
Hi Craig, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT/20151223-040911 config: arm-mvebu_v7_defconfig (attached as .config) reproduce: wget

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread David Miller
From: Andrew Lunn Date: Tue, 22 Dec 2015 12:06:34 +0100 > On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: >> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC >> node.") only fixes finding PHY properties in MAC node for KSZ9021. This >> commit

[PATCH 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same

[PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin This series is based on the tip of the net tree. The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, and also

[PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was specified and

[PATCH 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be in cpsw_slave_data rather

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > Acked-by: Eric Dumazet -- To unsubscribe from this list: send the line

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > Avoids cluttering tcp_v4_send_reset when followup patch extends > it to deal with timewait sockets. > > Suggested-by: Eric Dumazet > Signed-off-by: Florian Westphal > --- Acked-by: Eric Dumazet

Re: [PATCH] net-sysfs: use to_net_dev in net_namespace()

2015-12-22 Thread David Miller
From: Geliang Tang Date: Tue, 22 Dec 2015 23:11:49 +0800 > Use to_net_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH] dccp: fix use-after-free after cloning struct dccp_sock

2015-12-22 Thread David Miller
From: Vegard Nossum Date: Sun, 20 Dec 2015 21:53:27 +0100 > @@ -115,6 +115,10 @@ struct sock *dccp_create_openreq_child(const struct sock > *sk, > newdp->dccps_isr = dreq->dreq_isr; > newdp->dccps_gsr = dreq->dreq_gsr; > > +

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Huw Davies
On Tue, Dec 22, 2015 at 10:47:43PM +0100, Hannes Frederic Sowa wrote: > On 22.12.2015 17:59, Huw Davies wrote: > > I'm confused about this one. AFAICS, this will drop packets that we > > can't process. We don't send the icmp error, but I can certainly add > > that. Is that what you mean? > >

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 15:05:07 -0500 > + for (i = 0; i < reuse->num_socks; i++) { > + if (reuse->socks[i] == sk) { > + reuse->socks[i] = reuse->socks[reuse->num_socks - 1]; > + reuse->num_socks--;

Re: [PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > Hannes points out that when we generate tcp reset for timewait sockets we > pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). > > Make it cope with inet tw sockets and then provide tw sk. > > This makes RSTs appear on correct

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:42 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > >> On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >>> From: Craig Gallek >>> Date:

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > >> From: Craig Gallek > >> Date: Tue,

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Hannes Frederic Sowa
On 22.12.2015 17:59, Huw Davies wrote: > On Tue, Dec 22, 2015 at 02:50:20PM +0100, Hannes Frederic Sowa wrote: >> On 22.12.2015 12:46, Huw Davies wrote: >>> >>> +/* CALIPSO RFC 5570 */ >>> + >>> +static bool ipv6_hop_calipso(struct sk_buff *skb, int optoff) >>> +{ >>> + const unsigned char *nh

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > > if (!sk && hash_location) > > to something like > > if ((!sk || !sk_fullsock(sk)) && hash_location) { > ... > }

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > Avoids cluttering tcp_v4_send_reset when followup patch extends > it to deal with timewait sockets. > > Suggested-by: Eric Dumazet > Signed-off-by: Florian Westphal Acked-by: Hannes Frederic Sowa

[PATCH v2] net-next: Add tcindex to conntrack and add netfilter target/matches

2015-12-22 Thread Luuk Paulussen
This patch implements support for setting/matching the skb->tc_index field from Xtables, as well as allowing it to be saved/restored using connection tracking. This provides 16 extra bits of mark space that can be saved/restored from the connection (for performance benefits) when the marking is

[no subject]

2015-12-22 Thread Luuk Paulussen
Sorry for the resend. I forgot to include relevant netfilter maintainers in CC list Changes from v1 are to add dependency on NF_CONNTRACK to Kconfig to resolve the build issue and some style fixups from checkpatch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 15:51:19 -0500 > >> I was actually just looking at this as well (though a slightly >> different stack). The issue is with: c6ff5268293e rhashtable: Fix

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 16:47:34 -0500 > On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > > From: Craig Gallek > > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Hannes Frederic Sowa
Hi Marc, On 22.12.2015 22:28, Marc Haber wrote: > Hi Hannes, > > thanks for your mail. > > On Tue, Dec 22, 2015 at 04:15:14PM +0100, Hannes Frederic Sowa wrote: >> On 12.12.2015 20:58, Marc Haber wrote: >>> Any hints would be appreciated. >> >> This sysctl should help: >> >>

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:40 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 15:05:07 -0500 > >> + for (i = 0; i < reuse->num_socks; i++) { >> + if (reuse->socks[i] == sk) { >> + reuse->socks[i]

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 5:11 PM, kbuild test robot wrote: > Hi Craig, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT/20151223-040911 > config: arm-mvebu_v7_defconfig (attached as .config) >

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-22 Thread Doug Ledford
On 12/21/2015 06:13 PM, Faisal Latif wrote: > This (V1) series contains the addition of the i40iw.ko driver after > incorporating the feedback from Christoph Hellwig and Joe Perches for > initial series. > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > controller

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-22 Thread David Miller
From: Vijay Pandurangan Date: Fri, 18 Dec 2015 14:34:59 -0500 > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current

Re: [PATCH] sh_eth: fix 16-bit descriptor field access endianness too

2015-12-22 Thread David Miller
From: Sergei Shtylyov Date: Sun, 20 Dec 2015 01:48:04 +0300 > Commit 1299653affa4 ("sh_eth: fix descriptor access endianness") only > addressed the 32-bit buffer address field byte-swapping but the driver > still accesses 16-bit frame/buffer length descriptor

Re: [PATCH v2] RDS: don't pretend to use cpu notifiers

2015-12-22 Thread David Miller
From: Santosh Shilimkar Date: Sat, 19 Dec 2015 12:55:43 -0800 > From: Sebastian Andrzej Siewior > > It looks like an attempt to use CPU notifier here which was never > completed. Nobody tried to wire it up completely since 2k9. So I unwind >

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 15:45:39 -0500 > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other

[PATCH 1/2] netfilter: nf_tables: use skb->protocol instead of assuming ethernet header

2015-12-22 Thread Pablo Neira Ayuso
Otherwise we may end up with incorrect network and transport header for other protocols. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_netdev.c

[PATCH 2/2] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key

2015-12-22 Thread Pablo Neira Ayuso
From: Florian Westphal one nft userspace test case fails with 'ct l3proto original ipv4' mismatches 'ct l3proto ipv4' ... because NFTA_CT_DIRECTION attr is missing. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 0/2] Netfilter fixes for net

2015-12-22 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two netfilter fixes: 1) Oneliner from Florian to dump missing NFT_CT_L3PROTOCOL netlink attribute, from Florian Westphal. 2) Another oneliner for nf_tables to use skb->protocol from the new netdev family, we can't assume ethernet there. You can

Re: [PATCH 3/8] cgroup: implement cgroup_get_from_path() and expose cgroup_put()

2015-12-22 Thread Tejun Heo
Hello, Serge. On Mon, Dec 21, 2015 at 06:22:41PM -0600, Serge E. Hallyn wrote: > I'm trying to figure out how to handle this in the cgroup ns patchset. > Is this going to be purely used internally? From the user i see in > this patchset it looks like I should leave it be (and have @path always >

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 16:38:32 -0500 > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >> From: Craig Gallek >> Date: Tue, 22 Dec 2015 15:51:19 -0500 >> >>> I was actually just looking at this as well

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-22 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] [...] > It is clear to me that you cannot get away with using the same operation > for resume() and reset_resume() in your driver. It is fundamentally > impossible. Firmware cannot fix it. I would think how to fix it. > Sorry for the length of the

[PATCHv2 net-next 0/4] Trivial enhancements for cxgb4

2015-12-22 Thread Hariprasad Shenai
Hi This series adds a debug message if adapter isn't inserted in right PCI slot. Changes naming conventions for iSCSI rx queues, use node info while allocating rx queue and use napi_complete_done() api in napi handler. This patch series has been created against net-next tree and includes patches

[PATCHv2 net-next 2/4] cxgb4: get naming correct for iscsi queues

2015-12-22 Thread Hariprasad Shenai
All the upper level protocols like rdma, iscsi have their own offload rx queues, so instead of using the generic naming convention be specific while naming them. Improves code readability Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h

[PATCHv2 net-next 1/4] cxgb4: Warn if device doesn't have enough PCI bandwidth

2015-12-22 Thread Hariprasad Shenai
Check if the device get enough bandwidth from the entire PCI chain to satisfy its capabilities. This patch determines the PCIe device's bandwidth capabilities by reading its PCIe Link Capabilities registers and then call the pcie_get_minimum_link function to ensure that the adapter is hooked into

Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-22 Thread Hariprasad Shenai
On Tue, Dec 22, 2015 at 15:45:52 -0500, David Miller wrote: > From: Or Gerlitz > Date: Mon, 21 Dec 2015 09:33:22 +0200 > > > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai > > wrote: > >> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump

AW: Commit-8b63ec18 breaks setting PHY pad-skew settings

2015-12-22 Thread Roosen Henri
> -Ursprüngliche Nachricht- > Von: Florian Fainelli [mailto:f.faine...@gmail.com] > Gesendet: Montag, 21. Dezember 2015 20:51 > An: Roosen Henri; david.da...@cavium.com > Cc: buyt...@wantstofly.org; grant.lik...@secretlab.ca; > da...@davemloft.net; netdev@vger.kernel.org; Andrew Lunn >

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-22 Thread Oliver Neukum
On Tue, 2015-12-22 at 09:48 +, Hayes Wang wrote: > Peter Wu [mailto:pe...@lekensteyn.nl] > > Sent: Tuesday, December 08, 2015 10:33 PM > [...] > > I found another problem with runtime PM. When a device is suspended via > > autosuspend and a system suspend takes place, there is no network I/O

Use-after-free/out-of-bounds in tipc filter_rcv()

2015-12-22 Thread Vegard Nossum
Hi all, On latest linus/master I'm able to trigger the following KASAN warnings: == BUG: KASAN: out-of-bounds in filter_rcv+0xc3/0xa10 at addr 880014b4d680 Read of size 4 by task a.out/992

[RFC v4 4/5] VSOCK: Introduce vhost_vsock.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He VM sockets vhost transport implementation. This driver runs on the host. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry * virtqueue used len is now sizeof(pkt->hdr) +

[RFC v4 2/5] VSOCK: Introduce virtio_vsock_common.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio_transporto and vhost_vsock kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry *

[RFC v4 5/5] VSOCK: Add Makefile and Kconfig

2015-12-22 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Make checkpatch.pl happy with longer option description * Clarify dependency on virtio rather than QEMU as suggested

[PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Signed-off-by: Henri Roosen --- drivers/net/phy/micrel.c | 13 +++-- 1 file

pull request (net): ipsec 2015-12-22

2015-12-22 Thread Steffen Klassert
Just one patch to fix dst_entries_init with multiple namespaces. >From Dan Streetman. Please pull or let me know if there are problems. Thanks! The following changes since commit 5f6c99e0ab805d8ec9eda105822912d49aa1d409: net: phy: fix a bug in get_phy_c45_ids (2015-11-02 23:45:20 -0500) are

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-22 Thread Hayes Wang
Peter Wu [mailto:pe...@lekensteyn.nl] > Sent: Tuesday, December 08, 2015 10:33 PM [...] > I found another problem with runtime PM. When a device is suspended via > autosuspend and a system suspend takes place, there is no network I/O > after resume. Triggering a renegotiation (ethtool -r eth1)

Re: Commit-8b63ec18 breaks setting PHY pad-skew settings

2015-12-22 Thread Andrew Lunn
> Unfortunately the patch is incomplete: it only fixes the issue for > the KSZ9021. Please have a look at the funcion ksz9031_config_init() > which has the the same (broken) search for the parent node. Ah, sorry missed that. I was a bit blinkered, the issue was report for KSZ9021 and i did not

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread Andrew Lunn
On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: > Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC > node.") only fixes finding PHY properties in MAC node for KSZ9021. This > commit applies the same fix for KSZ9031. > > Signed-off-by: Henri Roosen

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-22 Thread Saeed Mahameed
On Mon, Dec 21, 2015 at 8:35 PM, Richard Cochran wrote: > On Mon, Dec 21, 2015 at 04:35:23PM +0200, Saeed Mahameed wrote: >> think of a case where: >> CPU1: is just about to call >> "schedule_delayed_work(>overflow_work, >> tstamp->overflow_period);" >> CPU2:

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-22 Thread Saeed Mahameed
On Mon, Dec 21, 2015 at 11:15 AM, Richard Cochran wrote: > On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote: >> +/* Should run once every mlx5e_tstamp->overflow_period */ >> +static void mlx5e_timestamp_overflow(struct work_struct *work) >> +{ >> +

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-22 Thread Andrew Lunn
> I did missed the device tree binding documentation. > This driver expected a property "lane-instance" in mdio bus node, and > "lane-handle" and "lane-range" properties in phy node. > > The "lane-instance" indicates what the phy should be probed as, > 1000BASE-KX or 10GBASE-KR, seems phy node is

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread YOSHIFUJI Hideaki
Cong Wang wrote: > On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin > wrote: >> ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, >> ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, >> ip6addrlbl_get() will use about to be free

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-22 Thread Souptick Joarder
Hi Brent, On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: > On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder > wrote: >> Hi Brent, >> >> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >>> Since commit

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-22 Thread Kalle Valo
Souptick Joarder writes: > Hi Brent, > > On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: >> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder >> wrote: >>> Hi Brent, >>> >>> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor

Re: [patch net-next] mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

2015-12-22 Thread Jiri Pirko
Mon, Dec 21, 2015 at 04:12:06PM CET, j...@resnulli.us wrote: >From: Jiri Pirko > >KASan reported use-after-free for the hwmon structure. So fix this by >using devm_kzalloc and let the core take care about freeing the memory >during device dettach. We found one small change is

Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-22 Thread Lorenzo Colitti
On Tue, Dec 22, 2015 at 5:31 PM, Lorenzo Colitti wrote: > I've just uploaded a new version. The changes from v2 are as > follows: > [...] Also: as requested, kill is now a boolean instead of a bitfield inside a struct. -- To unsubscribe from this list: send the line

[PATCH] i40iw: fix compare_const_fl.cocci warnings

2015-12-22 Thread Julia Lawall
Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Faisal Latif Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- It's a minor point, but when I

[iproute PATCH v3 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-22 Thread Lorenzo Colitti
This patch adds a -K / --kill option to ss that attempts to forcibly close matching sockets using SOCK_DESTROY. Because ss typically prints sockets instead of acting on them, and because the kernel only supports forcibly closing some types of sockets, the output of -K is as follows: - If closing

Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-22 Thread Lorenzo Colitti
I've just uploaded a new version. The changes from v2 are as follows: - Removed the superfluous inline keyword. - The code now ignores ENOENT from kill_inet_sock. This can happen if something else closed the socket during the scan, or if the user requests killing a socket that is not in the

[iproute PATCH v3 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs

2015-12-22 Thread Lorenzo Colitti
The new variant is identical to rtnl_send_check, except it also consumes the kernel response instead of using MSG_PEEK. This is useful for callers that send simple commands that never cause a response but only ACKs, and that expect to receive and deal with errors without printing them to stderr

[patch net-next v2] mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

2015-12-22 Thread Jiri Pirko
From: Jiri Pirko KASan reported use-after-free for the hwmon structure. So fix this by using devm_kzalloc and let the core take care about freeing the memory during device dettach. Reported-by: Ido Schimmel Fixes: 89309da39 ("mlxsw: core: Implement

[RFC v4 3/5] VSOCK: Introduce virtio_transport.ko

2015-12-22 Thread Stefan Hajnoczi
From: Asias He VM sockets virtio transport implementation. This driver runs in the guest. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v4: * Add MAINTAINERS file entry * Drop short/long rx packets * checkpatch.pl

[RFC v4 0/5] Add virtio transport for AF_VSOCK

2015-12-22 Thread Stefan Hajnoczi
This series is based on v4.4-rc2 and the "virtio: make find_vqs() checkpatch.pl-friendly" patch I recently submitted. v4: * Addressed code review comments from Alex Bennee * MAINTAINERS file entries for new files * Trace events instead of pr_debug() * RST packet is sent when there is no

[RFC v4 1/5] VSOCK: transport-specific vsock_transport functions

2015-12-22 Thread Stefan Hajnoczi
struct vsock_transport contains function pointers called by AF_VSOCK core code. The transport may want its own transport-specific function pointers and they can be added after struct vsock_transport. Allow the transport to fetch vsock_transport. It can downcast it to access transport-specific

[PATCH] [stable 4.1.y PACTH] openvswitch: fix crash cause by non-nvgre packet

2015-12-22 Thread wenxu
kernel BUG at include/linux/skbuff.h:1219! invalid opcode: [#1] SMP RIP: 0010:[] ovs_flow_extract+0x8ed/0xa40 [openvswitch] Call Trace: ovs_dp_process_received_packet+0x44/0x80 [openvswitch] ovs_vport_receive+0x2e/0x30 [openvswitch] gre_rcv+0xac/0xd0 [openvswitch] gre_cisco_rcv+0x1c2/0x310

[PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-12-22 Thread Steffen Klassert
From: Dan Streetman Remove the dst_entries_init/destroy calls for xfrm4 and xfrm6 dst_ops templates; their dst_entries counters will never be used. Move the xfrm dst_ops initialization from the common xfrm/xfrm_policy.c to xfrm4/xfrm4_policy.c and

Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-22 Thread Hariprasad S
On Mon, Dec 21, 2015 at 09:33:22 +0200, Or Gerlitz wrote: > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai > wrote: > > Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out > > various Data Center Bridging information. > > why? what's wrong with using the lldp

[RFC PATCH 17/17] calipso: Add a label cache.

2015-12-22 Thread Huw Davies
This works in exactly the same way as the CIPSO label cache. The idea is to allow the lsm to cache the result of a secattr lookup so that it doesn't need to perform the lookup for every skbuff. It introduces two sysctl controls: calipso_cache_enable - enables/disables the cache.

[RFC PATCH 03/17] netlabel: Initial support for the CALIPSO netlink protocol.

2015-12-22 Thread Huw Davies
CALIPSO is a packet labelling protocol for IPv6 which is very similar to CIPSO. It is specified in RFC 5570. Much of the code is based on the current CIPSO code. This adds support for adding passthrough-type CALIPSO DOIs through the NLBL_CALIPSO_C_ADD command. It requires attributes:

[RFC PATCH 06/17] netlabel: Add support for creating a CALIPSO protocol domain mapping.

2015-12-22 Thread Huw Davies
This extends the NLBL_MGMT_C_ADD and NLBL_MGMT_C_ADDDEF commands to accept CALIPSO protocol DOIs. Signed-off-by: Huw Davies --- net/netlabel/netlabel_domainhash.c | 40 +-- net/netlabel/netlabel_domainhash.h | 1 + net/netlabel/netlabel_mgmt.c

  1   2   >