Re: 4.4-rc7 failure report

On 12/28/2015 10:53 PM, Doug Ledford wrote: The 4.4-rc7 kernel is failing for me. In my case, all of my vlan interfaces are failing to obtain a dhcp address using dhclient. I've tried a hand built 4.4-rc7, and the Fedora rawhide 4.4-rc7 kernel, both failed. I've tried NetworkManager and the

Re: [RFC PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

Sabrina Dubroca wrote: > + if (h->short_length) > + return len == h->short_length + 24; > + else > + return len >= 72; [..] > + return len == h->short_length + 32; [..] > +

Re: 4.4-rc7 failure report

On 12/28/2015 05:20 PM, Daniel Borkmann wrote: > On 12/28/2015 10:53 PM, Doug Ledford wrote: >> The 4.4-rc7 kernel is failing for me. In my case, all of my vlan >> interfaces are failing to obtain a dhcp address using dhclient. I've >> tried a hand built 4.4-rc7, and the Fedora rawhide 4.4-rc7

[PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

From: Zhu Yanjun When the X540 NIC acts as a slave of some virtual NICs, it is very important to synchronize link_up and link_speed, such as a bonding driver in 802.3ad mode. When X540 NIC acts as an independent interface, it is not necessary to synchronize link_up and

[PATCH V3] ixgbe: force to synchronize link_up and speed as a slave

Hi, all During the discussion with Emil, I think the time span between link_up and link_speed is not important when the X540 NIC acts as an independent interface. As such, a new patch is made to restrict synchronization between link_up and link_speed. Any reply is appreciated. Zhu Yanjun --

[PATCH 1/2] ixgbe: force to synchronize reporting "link on" and getting speed

From: yzhu1 In X540 NIC, there is a time span between reporting "link on" and getting the speed and duplex. To a bonding driver in 802.3ad mode, this time span will make it not work well if the time span is big enough. The big time span will make bonding driver change the

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: > wrote: > >In 802.3ad mode, the speed and duplex is needed. But in some NIC, > >there is a time span between NIC up state and getting speed and duplex. > >As such, sometimes a slave in 802.3ad mode is in up state

Re: [PATCH 3/3] bpf: hash: use per-bucket spinlock

On Mon, Dec 28, 2015 at 5:13 PM, Daniel Borkmann wrote: > On 12/26/2015 10:31 AM, Ming Lei wrote: >> >> From: Ming Lei >> >> Both htab_map_update_elem() and htab_map_delete_elem() can be >> called from eBPF program, and they may be in kernel hot

Re: [PATCH net-next v2 05/10] be2net: log digital signature errors while flashing FW image

Hi Suresh, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Sathya-Perla/be2net-patch-set/20151228-145423 config: x86_64-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64

Re: [PATCH 1/3] bpf: hash: use atomic count

On 12/26/2015 10:31 AM, Ming Lei wrote: Preparing for removing global per-hashtable lock, so the counter need to be defined as aotmic_t first. Signed-off-by: Ming Lei Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

On 12/28/2015 04:43 PM, Michal Kubecek wrote: On Thu, Dec 17, 2015 at 01:57:16PM -0800, Jay Vosburgh wrote: wrote: In 802.3ad mode, the speed and duplex is needed. But in some NIC, there is a time span between NIC up state and getting speed and duplex. As such, sometimes

Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote: > From: David Miller > Date: Mon, 28 Dec 2015 00:32:43 -0500 (EST) > > > From: Andrew Lunn > > Date: Sun, 27 Dec 2015 12:58:25 +0100 > > > >> This patchset add ethtool support for reading

Re: [PATCH 3/3] bpf: hash: use per-bucket spinlock

On 12/26/2015 10:31 AM, Ming Lei wrote: From: Ming Lei Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, so it isn't efficient to use a per-hashtable lock in this two helpers. The per-hashtable

pull-request: wireless-drivers 2015-12-28

Hi Dave, here's one more pull request, a bit late due to holidays but I hope this still makes it to 4.4. Just two small fixes to iwlwifi, nothing else. Kalle The following changes since commit eeec5d0ef7ee54a75e09e861c3cc44177b8752c7: rtlwifi: rtl8821ae: Fix lockups on boot (2015-11-17

Re: [PATCH 2/3] bpf: hash: move select_bucket() out of htab's spinlock

On 12/26/2015 10:31 AM, Ming Lei wrote: The spinlock is just used for protecting the per-bucket hlist, so it isn't needed for selecting bucket. Signed-off-by: Ming Lei Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line

skb_clone query

Hi, Just out of curisity, I was looking at Kernel 3.14, skb_clone function in f_ncm.c http://lxr.free-electrons.com/source/drivers/usb/gadget/f_ncm.c?v=3.14#L1063 QUERY : Shouldn't a kfree_skb(skb2); happen before goto err @1070 ? Is this not a memleak ? 1068 if

[PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

Recent fix "net: add length argument to skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable branches, namely stable-3.2.y: commit 127500d724f8 stable-3.12.y: commit 3e1ac3aafbd0 doesn't handle truncated reads correctly. If read length is shorter than incoming datagram (but

[PATCH] unix: properly account for FDs passed over unix sockets

It is possible for a process to allocate and accumulate far more FDs than the process' limit by sending them over a unix socket then closing them to keep the process' fd count low. This change addresses this problem by keeping track of the number of FDs in flight per user and preventing

[PATCH v1 1/3] bpf: hash: use atomic count

Preparing for removing global per-hashtable lock, so the counter need to be defined as aotmic_t first. Acked-by: Daniel Borkmann Signed-off-by: Ming Lei --- kernel/bpf/hashtab.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v1 3/3] bpf: hash: use per-bucket spinlock

Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, so it isn't efficient to use a per-hashtable lock in this two helpers. The per-hashtable spinlock is used for protecting bucket's hlist, and per-bucket lock is just enough.

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

Hello Michal, 2015-12-28, 15:01:57 +0100, Michal Kubecek wrote: > Recent fix "net: add length argument to > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > branches, namely > > stable-3.2.y: commit 127500d724f8 > stable-3.12.y: commit 3e1ac3aafbd0 > > doesn't handle

[RFC PATCH net-next 1/3] uapi: add MACsec bits

Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- include/uapi/linux/Kbuild | 1 + include/uapi/linux/if_ether.h | 1 + include/uapi/linux/if_link.h | 21 ++ include/uapi/linux/if_macsec.h | 160

[RFC PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

This is an implementation of MACsec/IEEE 802.1AE. This driver provides authentication and encryption of traffic in a LAN, typically with GCM-AES-128, and optional replay protection. http://standards.ieee.org/getieee802/download/802.1AE-2006.pdf Signed-off-by: Sabrina Dubroca

[RFC PATCH net-next 2/3] net: add MACsec netdevice priv_flags and helper

Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- include/linux/netdevice.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c20b814e46a0..4f80f621ecf9

[RFC PATCH net-next 0/3] MACsec IEEE 802.1AE implementation

MACsec (IEEE 802.1AE [0]) is a protocol that provides security for wired ethernet LANs. MACsec offers two protection modes: authentication only, or authenticated encryption. MACsec defines "secure channels" that allow transmission from one node to one or more others. Communication on a channel

Re: [PATCH v1 3/3] bpf: hash: use per-bucket spinlock

On 12/28/2015 01:55 PM, Ming Lei wrote: Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, so it isn't efficient to use a per-hashtable lock in this two helpers. The per-hashtable spinlock is used for protecting bucket's

[PATCH v1 0/3] bpf: hash: use per-bucket spinlock

Hi, This patchset tries to optimize ebpf hash map, and follows the idea: Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, it isn't efficient to use a per-hashtable lock in this two helpers,

[PATCH v1 2/3] bpf: hash: move select_bucket() out of htab's spinlock

The spinlock is just used for protecting the per-bucket hlist, so it isn't needed for selecting bucket. Acked-by: Daniel Borkmann Signed-off-by: Ming Lei --- kernel/bpf/hashtab.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. Signed-off-by: Ivan Safonov --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

On December 28, 2015 12:58:25 AM PST, Andrew Lunn wrote: >On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote: >> From: David Miller >> Date: Mon, 28 Dec 2015 00:32:43 -0500 (EST) >> >> > From: Andrew Lunn >> > Date: Sun, 27 Dec

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

On Mon, Dec 28, 2015 at 03:29:42PM +0100, Sabrina Dubroca wrote: > 2015-12-28, 15:01:57 +0100, Michal Kubecek wrote: > > Recent fix "net: add length argument to > > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > > branches, namely > > > > stable-3.2.y: commit 127500d724f8 > >

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal > for X >= 0. X is not guaranteed to be >= 0 here > Signed-off-by: Ivan Safonov > --- >  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c |

[PATCH 1/3] batman-adv: use to_delayed_work

Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang --- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/distributed-arp-table.c | 2 +- net/batman-adv/network-coding.c| 2 +- net/batman-adv/originator.c| 2 +-

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

On Mon, 2015-12-28 at 16:38 +0100, Michal Kubecek wrote: > On Mon, Dec 28, 2015 at 03:29:42PM +0100, Sabrina Dubroca wrote: > > 2015-12-28, 15:01:57 +0100, Michal Kubecek wrote: > > > Recent fix "net: add length argument to > > > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > >

Re: [PATCH] net, socket, socket_wq: fix missing initialization of flags

On Sun, 2015-12-27 at 21:00 +0100, Nicolai Stange wrote: > Fixes: ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") > > Commit ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") from > the current 4.4 release cycle introduces a new flags member in > struct socket_wq and moved

Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

From: Andrew Lunn Date: Mon, 28 Dec 2015 09:58:25 +0100 > On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote: >> From: David Miller >> Date: Mon, 28 Dec 2015 00:32:43 -0500 (EST) >> >> > From: Andrew Lunn >> > Date: Sun, 27 Dec

4.4-rc7 failure report

Hi Dave, The 4.4-rc7 kernel is failing for me. In my case, all of my vlan interfaces are failing to obtain a dhcp address using dhclient. I've tried a hand built 4.4-rc7, and the Fedora rawhide 4.4-rc7 kernel, both failed. I've tried NetworkManager and the old SysV network service, both fail.

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

On Sun, 27 Dec 2015 17:34:25 -0800 Bjorn Andersson wrote: > In preparation for handling incoming messages from IRQ context, change > the indication list lock to a spinlock > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On 12/29/2015 12:56 AM, Joe Perches wrote: On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. X is not guaranteed to be >= 0 here X is fixed constant. In this case X is {0, 1, 2}. @@ -4097,16

Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

From: Florian Fainelli Date: Mon, 28 Dec 2015 09:27:25 -0800 > On December 28, 2015 12:58:25 AM PST, Andrew Lunn wrote: >>On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote: >>> From: David Miller >>> Date: Mon, 28 Dec 2015

nf_unregister_net_hook: hook not found!

Hi, Running a 4.4.0-rc6 kernel i encountered the warning below. -- Sander [ 13.740472] ip_tables: (C) 2000-2006 Netfilter Core Team [ 13.936237] iwlwifi :03:00.0: L1 Enabled - LTR Disabled [ 13.945391] iwlwifi :03:00.0: L1 Enabled - LTR Disabled [ 13.947434] iwlwifi

Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

On December 28, 2015 12:02:13 PM PST, David Miller wrote: >From: Florian Fainelli >Date: Mon, 28 Dec 2015 09:27:25 -0800 > >> On December 28, 2015 12:58:25 AM PST, Andrew Lunn >wrote: >>>On Mon, Dec 28, 2015 at 12:44:27AM -0500, David

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

Le 18/12/2015 01:30, shh@gmail.com a écrit : [snip] > +struct training_state_machine { > + bool bin_m1_late_early; > + bool bin_long_late_early; > + bool bin_m1_stop; > + bool bin_long_stop; > + bool tx_complete; > + bool an_ok; > + bool link_up; > + bool

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

On Mon 28 Dec 15:06 PST 2015, Stephen Hemminger wrote: > On Sun, 27 Dec 2015 17:34:25 -0800 > Bjorn Andersson wrote: > > > In preparation for handling incoming messages from IRQ context, change > > the indication list lock to a spinlock > > > > Signed-off-by: Bjorn Andersson

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On 12/29/2015 07:31 AM, Joe Perches wrote: On Tue, 2015-12-29 at 01:38 +0700, Ivan Safonov wrote: On 12/29/2015 12:56 AM, Joe Perches wrote: On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal for X >= 0. X is

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Wed, Dec 23, 2015 at 3:03 PM, Calvin Owens wrote: > Commit 7332a13b038be05c ("vxlan: defer vxlan init as late as possible") > changed vxlan to use late_initcall(), because vxlan relies on ipv6 being > loaded when a new device is opened. > > This causes netconsole to panic

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thu, Dec 24, 2015 at 2:25 AM, Hannes Frederic Sowa wrote: > Hi, > > On 24.12.2015 00:03, Calvin Owens wrote: >> This patch addresses the issue cited in 7332a13b038be05c by making vxlan >> actually check if ipv6 is loaded, and reverts it to module_init() so >> that

Re: [PATCH RFC 00/26] Phylink & SFP support

Hi Florian, On Sun Dec 27 18:08, Florian Fainelli wrote: > On December 14, 2015 11:26:21 PM PST, Dustin Byford > wrote: > >On Mon Dec 07 17:35, Russell King - ARM Linux wrote: > >> Hi, > > > >Hello. > > > >> SFP modules are hot-pluggable ethernet transceivers; they

New "ip wait" subcommand for iproute2

Hallo netdev@, I had occasion to want to programmatically wait for an interface to become available from within a shell script, but found there to be no off-the-shelf tool for such a thing. Could this patch be considered for inclusion as part of iproute2? It adds an "ip wait link" subcommand

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On Tue, 2015-12-29 at 01:38 +0700, Ivan Safonov wrote: > On 12/29/2015 12:56 AM, Joe Perches wrote: > > On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > > > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == > > > X) are equal for X >= 0. > > X is not guaranteed to be >= 0