Re: [PATCH] unix: properly account for FDs passed over unix sockets

Willy Tarreau wrote: > On Wed, Dec 30, 2015 at 09:58:42AM +0100, Hannes Frederic Sowa wrote: > > The MSG_PEEK code should not be harmful and the patch is good as is. I > > first understood from the published private thread, that it is possible > > for a program to exceed the rlimit of fds. But

Re: [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface

On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > According to the suggestions from Rustad, Mark D, to all the slave  > interfaces, the link_speed and link_up should be synchronized since > the time span between link_up and link_speed

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On Thu, Dec 31, 2015 at 03:08:53PM +0900, Tetsuo Handa wrote: > Willy Tarreau wrote: > > On Wed, Dec 30, 2015 at 09:58:42AM +0100, Hannes Frederic Sowa wrote: > > > The MSG_PEEK code should not be harmful and the patch is good as is. I > > > first understood from the published private thread,

[PATCH RFC] vhost: basic device IOTLB support

This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of iommu for a secure DMA environment in guest. The idea is simple. When vhost meets an IOTLB miss, it will request the assistance of userspace to do the

[net-next] ppp: rtnetlink device handling

Hi Guillaume, can you explain why you moved ppp to rtnetlink device handling? Benefits, etc.? Does anything change when using NetworkManager/ModemManager/pppd for my network setup/handling (here: Ubuntu/precise AMD64)? Thanks in advance. Regards, - Sedat - P.S.: Coming soon... Not (only) in

Re: [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave

On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote: > Thanks for the suggestions from Rustad, Mark D. > According to his suggestions, the logs and source code are > simplified. I find it funny that this email (no patch) is got the correct subject, yet the updated patch you sent does

Re: [PATCHv4 net-next 0/3] Ethtool support for phy stats

From: Andrew Lunn Date: Wed, 30 Dec 2015 16:28:24 +0100 > This patchset add ethtool support for reading statistics from the PHY. > The Marvell and Micrel Phys are then extended to report receiver > packet errors and idle errors. > > v2: > Fix linking when phylib is not

Re: [PATCH] igb: When GbE link up, wait for Remote receiver status condition.

2015-12-31 13:42 GMT+09:00 Jeff Kirsher : > Please send this to intel-wired-...@lists.osuosl.org mailing list, or > at least CC the list since all Wired Ethernet Intel driver patches are > handled through that list. Thanks for the info. I just sent it. -- To

RE: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, December 30, 2015 11:13 PM > To: Shaohui Xie > Cc: David Miller; Florian Fainelli; netdev > Subject: Re: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics > counters > > On Wed, Dec 30, 2015 at

Re: [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave

On 12/31/2015 01:17 PM, Jeff Kirsher wrote: On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote: Thanks for the suggestions from Rustad, Mark D. According to his suggestions, the logs and source code are simplified. I find it funny that this email (no patch) is got the correct

[PATCH net-next 4/5] sctp: drop the old assoc hashtable of sctp

transport hashtable will replace the association hashtable, so association hashtable is not used in sctp any more, so drop the codes about that. Signed-off-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/sctp.h| 21

[PATCH net-next 5/5] sctp: remove the local_bh_disable/enable in sctp_endpoint_lookup_assoc

sctp_endpoint_lookup_assoc is called in the protection of sock lock there is no need to call local_bh_disable in this function. so remove them. Signed-off-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/endpointola.c | 17

RE: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

>-Original Message- >From: zhuyj [mailto:zyjzyj2...@gmail.com] >Sent: Wednesday, December 30, 2015 12:20 AM >To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, >Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak, >John; Williams, Mitch A;

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder wrote: > > HI Bjorn, > > On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: > > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > > clients from having to cast away a const qualifier. >

[RFC PATCH 06/12] net: sched: support qdisc_reset on NOLOCK qdisc

The qdisc_reset operation depends on the qdisc lock at the moment to halt any additions to gso_skb and statistics while the list is free'd and the stats zeroed. Without the qdisc lock we can not guarantee another cpu is not in the process of adding a skb to one of the "cells". Here are the two

[RFC PATCH 07/12] net: sched: qdisc_qlen for per cpu logic

This is a bit interesting because it means sch_direct_xmit will return a positive value which causes the dequeue/xmit cycle to continue only when a specific cpu has a qlen > 0. However checking each cpu for qlen will break performance so its important to note that qdiscs that set the no lock bit

[RFC PATCH 05/12] net: sched: per cpu gso handlers

The net sched infrastructure has a gso ptr that points to skb structs that have failed to be enqueued by the device driver. This can happen when multiple cores try to push a skb onto the same underlying hardware queue resulting in lock contention. This case is handled by a cpu collision handler

[RFC PATCH 04/12] net: sched: provide per cpu qstat helpers

The per cpu qstats support was added with per cpu bstat support which is currently used by the ingress qdisc. This patch adds a set of helpers needed to make other qdiscs that use qstats per cpu as well. Signed-off-by: John Fastabend --- include/net/sch_generic.h |

[RFC PATCH 08/12] net: sched: a dflt qdisc may be used with per cpu stats

Enable dflt qdisc support for per cpu stats before this patch a dflt qdisc was required to use the global statistics qstats and bstats. Signed-off-by: John Fastabend --- net/sched/sch_generic.c | 24 1 file changed, 20 insertions(+), 4

Re: nf_unregister_net_hook: hook not found!

On 2015-12-30 03:39, ebied...@xmission.com wrote: Pablo Neira Ayuso writes: On Mon, Dec 28, 2015 at 09:05:03PM +0100, Sander Eikelenboom wrote: Hi, Running a 4.4.0-rc6 kernel i encountered the warning below. Cc'ing Eric Biederman. @Sander, could you provide a way to

[PATCH v2] mwifiex: correctly handling kzalloc

Since kzalloc can be failed in memory pressure, it needs to be handled, otherwise NULL dereference could be happened Signed-off-by: Insu Yun --- drivers/net/wireless/mwifiex/sdio.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote: > On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > > > besides, this patchset will use transport hashtable to replace > > association hashtable to lookup with rhashtable api. get transport > > first then get association by t->asoc.

Re: [PATCH net-next v2 00/10] be2net: patch set

From: Sathya Perla Date: Wed, 30 Dec 2015 11:57:18 +0530 > On Wed, Dec 30, 2015 at 2:20 AM, David Miller wrote: >> >> Please fix the problems reported by the kbuild test robot, they happened >> when I tried to build this too. > > David, the test

[RFC PATCH 03/12] net: sched: allow qdiscs to handle locking

This patch adds a flag for queueing disciplines to indicate the stack does not need to use the qdisc lock to protect operations. This can be used to build lockless scheduling algorithms and improving performance. The flag is checked in the tx path and the qdisc lock is only taken if it is not

[RFC PATCH 02/12] net: sched: free per cpu bstats

When a qdisc is using per cpu stats only the bstats are being freed. This also free's the qstats. Signed-off-by: John Fastabend --- net/sched/sch_generic.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_generic.c

Re: [RFC PATCH 12/12] net: sched: pfifo_fast new option to deque multiple pkts

On 15-12-30 09:55 AM, John Fastabend wrote: > Now that pfifo_fast is using the alf_queue data structures we can > dequeue multiple skbs and save some overhead. > > This works because the bulk dequeue logic accepts skb lists already. > > Signed-off-by: John Fastabend

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson wrote: > On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder > wrote: >> >> HI Bjorn, >> >> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: >> > Make the addr parameter const in

[PATCH net-next 3/5] sctp: apply rhashtable api to sctp procfs

Traversal the transport rhashtable, get the association only once through the condition assoc->peer.primary_path != transport. Signed-off-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/proc.c | 316

[PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

tranport hashtbale will replace the association hashtable to do the lookup for transport, and then get association by t->assoc, rhashtable apis will be used because of it's resizable, scalable and using rcu. lport + rport + paddr will be the base hashkey to locate the chain, with net to protect

[PATCH net-next 2/5] sctp: apply rhashtable api to send/recv path

apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc and __sctp_lookup_association, it's invoked in the protection of sock lock, it will be safe, but sctp_lookup_association need to call rcu_read_lock() and to detect the t->dead to protect it. Signed-off-by: Xin Long

[PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

for telecom center, the usual case is that a server is connected by thousands of clients. but if the server with only one enpoint(udp style) use the same sport and dport to communicate with every clients, and every assoc in server will be hashed in the same chain of global assoc hashtable due to

Re: Q: bad routing table cache entries

From: Eric Dumazet Date: Wed, 30 Dec 2015 09:17:42 -0500 > On Wed, 2015-12-30 at 15:42 +0300, Stas Sergeev wrote: >> 29.12.2015 18:22, Sowmini Varadhan пишет: >> > Do you have admin control over the ubuntu router? >> > If yes, you might want to check the shared_media [#]

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote: > From: Pravin B Shelar > Date: Tue, 22 Sep 2015 12:57:53 -0700 > > > VXLAN device can receive skb with checksum partial. But the checksum > > offset could be in outer header which is pulled on receive. This results > >

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

HI Bjorn, On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > clients from having to cast away a const qualifier. > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

On Wed, Dec 30, 2015 at 11:50:46PM +0800, Xin Long wrote: ... > +void sctp_hash_transport(struct sctp_transport *t) > +{ > + struct sctp_sockaddr_entry *addr; > + struct sctp_hash_cmp_arg arg; > + > + addr = list_entry(t->asoc->base.bind_addr.address_list.next, > +

[RFC PATCH 00/12] drop the qdisc lock for pfifo_fast/mq

Hi, This is a first take at removing the qdisc lock on the xmit path where qdiscs actually have queues of skbs. The ingress qdisc which is already lockless was "easy" at least in the sense that we did not need any lock-free data structures to hold skbs. The series here is experimental at the

[RFC PATCH 01/12] lib: array based lock free queue

Initial implementation of an array based lock free queue. This works is originally done by Jesper Dangaard Brouer and I've grabbed it made only minor tweaks at the moment and plan to use it with the 'tc' subsystem although it is general enough to be used elsewhere. Certainly this implementation

Re: 4.4-rc7 failure report

From: Eric Dumazet Date: Wed, 30 Dec 2015 11:55:25 -0500 > On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote: >> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote: >> >> > Given that this drop doesn't strictly need to be caused by filter code, >> > it

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

From: Eric Dumazet Date: Wed, 30 Dec 2015 11:57:31 -0500 > I am against using rhashtable in SCTP (or TCP) at this stage, given the > number of bugs we have with it. Come on Eric, we've largely dealt with all of these problems. I haven't seen a serious report in a while.

Re: 4.4-rc7 failure report

On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote: > On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote: > > > Given that this drop doesn't strictly need to be caused by filter code, > > it would be nice if you could pin the location down where the packet gets > > dropped

Re: [PATCH RESEND] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd

Hi, On 12/30/2015 07:15 PM, Nicholas Krause wrote: > This fixes error handling in the function iwl_pcie_enqueue_hcmd > by checking if all calls to the function wl_pcie_txq_build_tfd > have failed by returning a error code and if so jump to the goto > label out from the cleaning up of acquired

[RFC PATCH 10/12] net: sched: helper to sum qlen

Reporting qlen when qlen is per cpu requires aggregating the per cpu counters. This adds a helper routine for this. Signed-off-by: John Fastabend --- include/net/sch_generic.h | 15 +++ 1 file changed, 15 insertions(+) diff --git

[RFC PATCH 09/12] net: sched: pfifo_fast use alf_queue

This converts the pfifo_fast qdisc to use the alf_queue enqueue and dequeue routines then sets the NOLOCK bit. This also removes the logic used to pick the next band to dequeue from and instead just checks each alf_queue for packets from top priority to lowest. This might need to be a bit more

[RFC PATCH 11/12] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq

The sch_mq qdisc creates a sub-qdisc per tx queue which are then called for independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this

[RFC PATCH 12/12] net: sched: pfifo_fast new option to deque multiple pkts

Now that pfifo_fast is using the alf_queue data structures we can dequeue multiple skbs and save some overhead. This works because the bulk dequeue logic accepts skb lists already. Signed-off-by: John Fastabend --- include/net/sch_generic.h |2 +-

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 10:30 AM, Souptick Joarder wrote: > On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson wrote: >> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder >> wrote: >>> >>> HI Bjorn, >>> >>> On Thu, Dec 24, 2015 at 2:03

Re: [RFC PATCH 05/12] net: sched: per cpu gso handlers

On Wed, 30 Dec 2015 09:52:49 -0800 John Fastabend wrote: > The net sched infrastructure has a gso ptr that points to skb structs > that have failed to be enqueued by the device driver. What about fixing up the naming "gso" to something else like "requeue", in the

net/sctp: sock memory leak

Hello, The following program leads to a leak of two sock objects: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include int fd; void *thr(void *arg) { memcpy((void*)0x2000bbbe,

Re: [RFC PATCH 05/12] net: sched: per cpu gso handlers

On 15-12-30 12:26 PM, Jesper Dangaard Brouer wrote: > On Wed, 30 Dec 2015 09:52:49 -0800 > John Fastabend wrote: > >> The net sched infrastructure has a gso ptr that points to skb structs >> that have failed to be enqueued by the device driver. > > What about fixing up

Re: 4.4-rc7 failure report

On 12/30/2015 12:50 PM, David Miller wrote: > From: Eric Dumazet > Date: Wed, 30 Dec 2015 11:55:25 -0500 > >> On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote: >>> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote: >>> >>> > Given that this drop doesn't

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

From: Eric Dumazet Date: Wed, 30 Dec 2015 14:11:20 -0500 > Let see how funny it will be then. It is more fun than waiting longer for the more limited uses of it to trigger problems. I cannot be convinced that using it in more places in order to find and fix more bugs is

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

On Wed, 2015-12-30 at 12:52 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 30 Dec 2015 12:19:39 -0500 > > > Switching SCTP to rhashtable at this moment is premature, it is > > still moving fast. > > I completely, and totally, disagree. > > rhashtable

Re: [PATCH 3/3] ixgbe: synchronize the link_speed and link_up of a slave interface

zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > According to the suggestion from Rustad, Mark D, this behavior perhaps > is more related to the copper phy. But to make fiber phy more robust, > to all the interfaces as a slave interface, the link_speed and link_up >

Re: 4.4-rc7 failure report

On Wed, 2015-12-30 at 12:50 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 30 Dec 2015 11:55:25 -0500 > > > On Wed, 2015-12-30 at 10:11 -0500, Dave Jones wrote: > >> On Wed, Dec 30, 2015 at 10:38:56AM +0100, Daniel Borkmann wrote: > >> > >> > Given that

Re: [PATCH iproute2 net-next 1/2] iproute2: ip-route.8.in: Add missing '[' before 'pref'

On Fri, 25 Dec 2015 11:12:15 +0800 Hangbin Liu wrote: > Signed-off-by: Hangbin Liu Both applied, thank you -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [iproute PATCH v3 2/2] ss: support closing inet sockets via SOCK_DESTROY.

On Tue, 22 Dec 2015 17:31:34 +0900 Lorenzo Colitti wrote: > > +static int kill_inet_sock(const struct sockaddr_nl *addr, > + struct nlmsghdr *h, void *arg) > +{ > + struct inet_diag_msg *d = NLMSG_DATA(h); > + struct inet_diag_arg *diag_arg = arg; > +

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

From: Eric Dumazet Date: Wed, 30 Dec 2015 14:03:43 -0500 > You sure can disagree with me, but calling my opinion 'incredily > stupid' is not wise. I think fundamentally giving facilities less rather than more coverage is not a smart approach at all. If the code is that

Re: net/sctp: sock memory leak

On Wed, Dec 30, 2015 at 09:42:27PM +0100, Dmitry Vyukov wrote: > Hello, > > The following program leads to a leak of two sock objects: Damn, Dmitry ;-) If no one takes care of it by then, I'll look into it next week, thanks. Marcelo -- To unsubscribe from this list: send the line "unsubscribe

memory leak in lapb_create_cb

Hello, The following program leads to a leak of struct lapb_cb: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include int main() { syscall(SYS_mmap, 0x2000ul, 0x1ul, 0x3ul, 0x32ul, 0xul, 0x0ul); int fd

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

On Wed, 2015-12-30 at 15:32 -0200, Marcelo Ricardo Leitner wrote: > On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote: > > On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > > > > > besides, this patchset will use transport hashtable to replace > > > association hashtable to lookup

Re: New "ip wait" subcommand for iproute2

On Mon, 28 Dec 2015 18:47:51 -0500 Nathaniel W Filardo wrote: > Hallo netdev@, > > I had occasion to want to programmatically wait for an interface to become > available from within a shell script, but found there to be no off-the-shelf > tool for such a thing. Could this

Re: [PATCH] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

Hello Kalle Valo, On 12/30/2015 05:15 PM, Kalle Valo wrote: Uri Mashiach writes: Fix the below Oops when trying to modprobe wlcore_spi. The oops occurs because the wl1271_power_{off,on}() function doesn't check the power() function pointer. [ 23.401447] Unable

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > besides, this patchset will use transport hashtable to replace > association hashtable to lookup with rhashtable api. get transport > first then get association by t->asoc. and also it will make tcp > style work better. SCTP already has a hash

net/sctp: sctp_datamsg memory leak

Hello, The following program leads to leak of multiple objects allocated in sctp_datamsg_from_user: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include long r[50]; int main() { memset(r, -1, sizeof(r)); r[0] =

Re: [PATCH v2] net, socket, socket_wq: fix missing initialization of flags

From: Nicolai Stange Date: Tue, 29 Dec 2015 13:29:55 +0100 > Fixes: ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") > > Commit ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") from > the current 4.4 release cycle introduced a new flags member in >

Re: [PATCHv2 net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

From: Xin Long Date: Tue, 29 Dec 2015 17:49:25 +0800 > In sctp_close, sctp_make_abort_user may return NULL because of memory > allocation failure. If this happens, it will bypass any state change > and never free the assoc. The assoc has no chance to be freed and it > will

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

Em 30-12-2015 19:57, Eric Dumazet escreveu: On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote: It is more fun than waiting longer for the more limited uses of it to trigger problems. I cannot be convinced that using it in more places in order to find and fix more bugs is a bad thing. I'm

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog wrote: > On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: >> How often can you trigger this bug ? > > Ok. I don't have a good repro to trigger it unfortunately, I've seen it just a > few times

Re: [PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

On Wed, Dec 30, 2015 at 08:51:12AM -0500, Eric Dumazet wrote: > From: Eric Dumazet > > Backport of this upstream commit into stable kernels : > 89c22d8c3b27 ("net: Fix skb csum races when peeking") > exposed a bug in udp stack vs MSG_PEEK support, when user provides > a

Re: [PATCH net-next v3 00/10] be2net: patch set

From: Sathya Perla Date: Wed, 30 Dec 2015 01:28:55 -0500 > The following patch set contains some feature additions, code > re-organization and cleanup and a few non-critical fixes. Pls > consider applying this to the net-next tree. Thanks. Series applied, thanks. --

Re: pull-request: wireless-drivers 2015-12-28

From: Kalle Valo Date: Mon, 28 Dec 2015 13:47:43 +0200 > here's one more pull request, a bit late due to holidays but I hope this > still makes it to 4.4. Just two small fixes to iwlwifi, nothing else. Pulled, thanks Kalle. -- To unsubscribe from this list: send the line

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote: > It is more fun than waiting longer for the more limited uses of it to > trigger problems. > > I cannot be convinced that using it in more places in order to find > and fix more bugs is a bad thing. > > I'm sorry if a lot of bug fixes in a

Re: 4.4-rc7 failure report

On 12/29/2015 11:16 PM, Alexei Starovoitov wrote: > On Tue, Dec 29, 2015 at 10:44:31PM -0500, Doug Ledford wrote: >> On 12/29/2015 10:43 PM, Alexei Starovoitov wrote: >>> On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote: On 12/28/2015 05:20 PM, Daniel Borkmann wrote: > On

Re: [PATCH] igb: When GbE link up, wait for Remote receiver status condition.

On Wed, Dec 30, 2015 at 4:09 AM, Takuma Ueba wrote: > I210 device IPv6 autoconf test sometimes fails, > because DAD NS for link-local is not transmitted. > This packet is silently dropped. > This problem is seen only GbE environment. > > igb_watchdog_task link up detection

[PATCH V5] ixgbe: synchronize link_up and link_speed of a slave

Hi, all Thanks for the suggestions from Rustad, Mark D. According to his suggestions, the logs and source code are simplified. Zhu Yanjun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface

From: Zhu Yanjun According to the suggestions from Rustad, Mark D, to all the slave interfaces, the link_speed and link_up should be synchronized since the time span between link_up and link_speed will make some virtual NICs not work well, such as a bonding driver in

[PATCH V6 1/1] ixgbe: synchronize link_up and link_speed of a slave interface

From: Zhu Yanjun According to the suggestions from Rustad, Mark D, to all the slave interfaces, the link_speed and link_up should be synchronized since the time span between link_up and link_speed will make some virtual NICs not work well, such as a bonding driver in

[PATCH V6] ixgbe: synchronize link_up and link_speed of a slave

Hi, all Thanks for the reply from Jeff. V2: Based on feedback from Jeff Kirsher, it is not appropriate to continue in the function ixgbe_watchdog_link_is_up without link_speed since this will make some virtual NICs not work well. V3: Based on feedback from Emil Tantilov, the time span

net/nfc: user-controllable kmalloc size in nfc_llcp_send_ui_frame

Hello, The following program triggers WARNING In kmalloc: [ cut here ] WARNING: CPU: 2 PID: 6754 at mm/page_alloc.c:2989 __alloc_pages_nodemask+0x771/0x15f0() Modules linked in: CPU: 2 PID: 6754 Comm: a.out Not tainted 4.4.0-rc7+ #181 Hardware name: QEMU Standard PC

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Tue, Dec 29, 2015 at 9:08 PM, David Miller wrote: > From: Rainer Weikusat > Date: Tue, 29 Dec 2015 19:42:36 + > >> Jacob Siverskog writes: >>> This should fix a NULL pointer dereference I encountered (dump

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote: > Hi Heinrich, > > On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: >> IOCTL SIOCRTMSG does nothing but return EINVAL. >> >> So comment it as unused. > > Can you say something about how you confirmed this? > It's not immediately

Linux 4.4-rc4 regression, bisected to "net: fix sock_wake_async() rcu protection"

On recent v4.4-rc releases, I can't run emacs. No, really, running "emacs" in a GNOME 3 session makes gnome-shell think that emacs is running, but no window is drawn, and the overall system UI is a bit weird when the invisible emacs window is focused. This is 100% reproducible. There might be

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On Wed, Dec 30, 2015 at 09:58:42AM +0100, Hannes Frederic Sowa wrote: > The MSG_PEEK code should not be harmful and the patch is good as is. I > first understood from the published private thread, that it is possible > for a program to exceed the rlimit of fds. But the DoS is only by > keeping

[PATCH] iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

The il_sensitivity_ranges is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/wireless/intel/iwlegacy/4965-mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

Hi Heinrich, On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. Can you say something about how you confirmed this? It's not immediately obvious from the code. Cheers, Michael > Signed-off-by: Heinrich Schuchardt

Re: Linux 4.4-rc4 regression, bisected to "net: fix sock_wake_async() rcu protection"

Andy Lutomirski writes: > On recent v4.4-rc releases, I can't run emacs. No, really, running > "emacs" in a GNOME 3 session makes gnome-shell think that emacs is > running, but no window is drawn, and the overall system UI is a bit > weird when the invisible emacs window is

Re: [PATCH] unix: properly account for FDs passed over unix sockets

On 29.12.2015 21:35, Willy Tarreau wrote: On Tue, Dec 29, 2015 at 03:48:45PM +0100, Hannes Frederic Sowa wrote: On 28.12.2015 15:14, Willy Tarreau wrote: It is possible for a process to allocate and accumulate far more FDs than the process' limit by sending them over a unix socket then closing

Re: 4.4-rc7 failure report

On 12/30/2015 05:16 AM, Alexei Starovoitov wrote: On Tue, Dec 29, 2015 at 10:44:31PM -0500, Doug Ledford wrote: On 12/29/2015 10:43 PM, Alexei Starovoitov wrote: On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote: On 12/28/2015 05:20 PM, Daniel Borkmann wrote: On 12/28/2015 10:53

Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

On 12/30/2015 02:55 PM, Tantilov, Emil S wrote: -Original Message- From: zhuyj [mailto:zyjzyj2...@gmail.com] Sent: Tuesday, December 29, 2015 6:49 PM To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W;

[PATCH 3/3] ixgbe: synchronize the link_speed and link_up of a slave interface

From: Zhu Yanjun According to the suggestion from Rustad, Mark D, this behavior perhaps is more related to the copper phy. But to make fiber phy more robust, to all the interfaces as a slave interface, the link_speed and link_up is synchronized. Signed-off-by: Zhu

[PATCH 1/3] ixgbe: force to synchronize reporting "link on" and getting speed

From: Zhu Yanjun In X540 NIC, there is a time span between reporting "link on" and getting the speed and duplex. To a bonding driver in 802.3ad mode, this time span will make it not work well if the time span is big enough. The big time span will make bonding driver

[PATCH V4] ixgbe: synchronize the link_speed and link_up of a slave interface

Hi, all According to Rustad, Mark D, maybe it is related with copper phy. To make fiber phy more robust, synchronize both the link_up and link_speed of a slave interface in ixgbe driver. Best Regards! Zhu Yanjun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

[PATCH 2/3] ixgbe: restrict synchronization of link_up and speed

From: Zhu Yanjun When the X540 NIC acts as a slave of some virtual NICs, it is very important to synchronize link_up and link_speed, such as a bonding driver in 802.3ad mode. When X540 NIC acts as an independent interface, it is not necessary to synchronize link_up and

Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

Hi David, On Wed, Dec 30, 2015 at 2:48 AM, David Miller wrote: > From: Heiko Stübner > Date: Tue, 29 Dec 2015 23:27:55 +0100 >> Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller: >>> You have to submit this series properly, the same problem

[PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

From: Eric Dumazet Backport of this upstream commit into stable kernels : 89c22d8c3b27 ("net: Fix skb csum races when peeking") exposed a bug in udp stack vs MSG_PEEK support, when user provides a buffer smaller than skb payload. In this case,

Re: Linux 4.4-rc4 regression, bisected to "net: fix sock_wake_async() rcu protection"

On Wed, 2015-12-30 at 12:32 +0100, Nicolai Stange wrote: > Andy Lutomirski writes: > > > On recent v4.4-rc releases, I can't run emacs. No, really, running > > "emacs" in a GNOME 3 session makes gnome-shell think that emacs is > > running, but no window is drawn, and the

Re: Q: bad routing table cache entries

On Wed, 2015-12-30 at 15:42 +0300, Stas Sergeev wrote: > 29.12.2015 18:22, Sowmini Varadhan пишет: > > Do you have admin control over the ubuntu router? > > If yes, you might want to check the shared_media [#] setting > > on that router for the interfaces with overlapping subnets. > > (it is on

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: > On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog > wrote: > >> Ok. Thanks for your feedback. How do you believe the issue could be >> solved? Investigating it gives: >> >> static inline void

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog wrote: > Ok. Thanks for your feedback. How do you believe the issue could be > solved? Investigating it gives: > > static inline void __skb_unlink(struct sk_buff *skb, struct sk_buff_head > *list) > { > struct sk_buff

  1   2   >