Re: [PATCH net] sctp: translate network order to host order when users get a hmacid

On Wed, Feb 03, 2016 at 11:33:30PM +0800, Xin Long wrote: > Commit ed5a377d87dc ("sctp: translate host order to network order when > setting a hmacid") corrected the hmacid byte-order when setting a hmacid. > but the same issue also exists on getting a hmacid. > > We fix it by changing hmacids to

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

* Ingo Molnar wrote: > s/!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > > > + > > + /* Check length */ > > +10:cmpl$8, %esi > > + jg 30f > > + jl 20f > > + > > + /* Exactly 8 bytes length */ > > + addl(%rdi), %eax > > + adcl4(%rdi), %eax >

Re: Keystone 2 boards boot failure

Hi Arnd, On 02/03/2016 10:40 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: >> On 02/03/2016 06:20 PM, Arnd Bergmann wrote: >>> On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote:

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

On 02/04/2016 12:32 AM, Stephen Hemminger wrote: > On Wed, 3 Feb 2016 04:04:36 +0100 > Nikolay Aleksandrov wrote: > >> >> +static inline int ethtool_validate_speed(__u32 speed) >> +{ > > > No need for inline. > This is defined in a header, if it's not inline you start

Re: [PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

On Thu, 2016-02-04 at 11:35 +0200, Corcodel Marian wrote: > This patch set MSI on probe stage without this patch MSI is set when > rtl_open occur. > Do not need to run rtl_try_msi on multiple times. > > Signed-off-by: Corcodel Marian > --- >

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote: > On 02/03/2016 03:32 PM, Stephen Hemminger wrote: > > >But why check for valid value at all. At some point in the > >future, there will be yet another speed adopted by some standard body > >and the switch statement would need another

Re: [PATCH net] sctp: do sanity checks before migrating the asoc

On Wed, Feb 03, 2016 at 05:13:25PM +0100, Dmitry Vyukov wrote: > On Tue, Jan 19, 2016 at 9:08 PM, Marcelo Ricardo Leitner > wrote: > > Em 19-01-2016 17:55, Vlad Yasevich escreveu: > >> > >> On 01/19/2016 02:31 PM, Marcelo Ricardo Leitner wrote: > >>> > >>> Em 19-01-2016

Re: net/tipc: memory leak in tipc_release

On Thu, Dec 31, 2015 at 11:35 AM, Dmitry Vyukov wrote: > Hello, > > The following program, if run a parallel loop, leads to a leak of 2 > objects allocated in tipc_release: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include >

[net-next 01/20] i40e: Add mac_filter_element at the end of the list instead of HEAD

From: Kiran Patil Add MAC filter element to the end of the list in the given order, just to be tidy, and just in case there are ever any ordering issues in the future. Change-ID: Idc15276147593ea9393ac72c861f9c7905a791b4 Signed-off-by: Kiran Patil

[PATCH net-next] MAINTAINERS: Update tg3 maintainer

From: Siva Reddy Kallam Signed-off-by: Siva Reddy Kallam Signed-off-by: Michael Chan Acked-by: Prashant Sreedharan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[PATCH] bpf_dbg: do not initialise statics to 0

This patch fixes the checkpatch.pl error to bpf_dbg.c: ERROR: do not initialise statics to 0 Signed-off-by: Wei Tang --- tools/net/bpf_dbg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c

RE: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

From: Larry Finger > Sent: 03 February 2016 19:45 ... > The performance will depend on where you satisfy the condition. All switch > cases > have the same execution time, but in the if .. else if .. else form, the > earlier > tests execute more quickly. I'm not sure that one can make any blanket

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

From: Tom Herbert > Sent: 03 February 2016 19:19 ... > + /* Main loop */ > +50: adcq0*8(%rdi),%rax > + adcq1*8(%rdi),%rax > + adcq2*8(%rdi),%rax > + adcq3*8(%rdi),%rax > + adcq4*8(%rdi),%rax > + adcq5*8(%rdi),%rax > + adcq6*8(%rdi),%rax > +

[net-next 02/20] i40e/i40evf: Fix RSS rx-flow-hash configuration through ethtool

From: Anjali Singhai Jain This patch fixes the Hash PCTYPE enable for X722 since it supports a broader selection of PCTYPES for TCP and UDP. This patch also fixes a bug in XL710, X710, X722 support for RSS, as of now we cannot reduce the (4)tuple for RSS for

[net-next 14/20] i40e/i40evf: Use private workqueue

From: Jesse Brandeburg As done per ixgbe, use a private workqueue to avoid blocking the system workqueue. This avoids some strange side effects when some other entity is depending on the system work queue. Change-ID: Ic8ba08f5b03696cf638b21afd25fbae7738d55ee

[net-next 19/20] i40e: AQ Add external power class to get link status

From: Shannon Nelson Add the new External Device Power Ability field to the get_link_status data structure, using space from the reserved field at the end of the struct. Signed-off-by: Shannon Nelson Acked-by: Kevin Scott

[net-next 09/20] i40e: bump version to 1.4.10

From: Catherine Sullivan Bump. Change-ID: Ic9a495feb9ab0606f953c3848b0acf67169d3930 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-03

This series contains updates to i40e and i40evf only. Kiran adds the MAC filter element to the end of the list instead of HEAD just in case there are ever any ordering issues in the future. Anjali fixes several RSS issues, first fixes the hash PCTYPE enable for X722 since it supports a broader

[net-next 03/20] i40e: Replace X722 mac check in ethtool get_settings

From: Catherine Sullivan 100M SGMII is only supported on X722. Replace the mac check with a feature flag check that is only set for the X722 device. Change-ID: I53452d9af6af8cd9dca8500215fbc6ce93418f52 Signed-off-by: Catherine Sullivan

[net-next 16/20] i40e: Limit DCB FW version checks to X710/XL710 devices

From: Greg Bowers X710/XL710 devices require FW version checks to properly handle DCB configurations from the FW. Newer devices do not, so limit these checks to X710/XL710. Signed-off-by: Greg Bowers Acked-by: Shannon Nelson

[net-next 18/20] i40e: AQ Geneve cloud tunnel type

From: Shannon Nelson Fix the name of the new cloud tunnel type from the place-holder NGE name to the official Geneve. Also fix the spelling of the VXLAN type. Signed-off-by: Shannon Nelson Acked-by: Kevin Scott

[net-next 05/20] i40e: define function capabilities in only one place

From: Shannon Nelson The device capabilities were defined in two places, and neither had all the definitions. It really belongs with the AQ API definition, so this patch removes the other set of definitions and fills out the missing item. Change-ID:

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

On 02/04/2016 01:21 PM, Michael S. Tsirkin wrote: > On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov [snip] >> struct padded_vnet_hdr { >> @@ -1376,6 +1380,58 @@ static void virtnet_get_channels(struct net_device >>

net: memory leak in ip_cmsg_send

Hello, I've hit the following memory leak while running syzkaller fuzzer: unreferenced object 0x88002ea39708 (size 64): comm "syz-executor", pid 19887, jiffies 4295848369 (age 8.676s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Re: gigaset: memory leak in gigaset_initcshw

On Wed, Feb 3, 2016 at 8:11 PM, Paul Bolle wrote: > Hi Dmitry, > > On wo, 2016-02-03 at 17:16 +0100, Paul Bolle wrote: >> The above should provide me with enough information to figure out >> what's going on here. > > I've instrumented ser_gigaset with some printk's. Basically

[net-next 17/20] i40e: AQ Add Run PHY Activity struct

From: Shannon Nelson Add the AQ opcode and struct definitions for the Run PHY Activity command Signed-off-by: Shannon Nelson Acked-by: Kevin Scott Tested-by: Andrew Bowers Signed-off-by:

[net-next 12/20] i40e/i40evf: Fix for UDP/TCP RSS for X722

From: Anjali Singhai Jain The PCTYPES for the X710 and X722 families are different. This patch makes adjustments for that. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 08/20] i40e: update features with right offload

From: Jesse Brandeburg Synchronize code bases and add SCTP offload support. Change-ID: I9f99071f7176225479026930c387bf681a47494e Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 06/20] i40evf: null out ring pointers on free

From: Mitch Williams Since we check these ring pointers to make sure we don't double-allocate or double-free the rings, we had better null them out after we free them. In very rare cases this can cause a panic if the driver is removed during reset recovery.

[net-next 20/20] i40e: add 100Mb ethtool reporting

From: Catherine Sullivan Add some missing reporting/advertisement of 100Mb capability for adapters that support it. Change-ID: I8b8523fbdc99517bec29d90c71b3744db11542ac Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers

[net-next 11/20] i40e: Extend ethtool RSS hooks for X722

From: Anjali Singhai Jain This patch adds another way to access the RSS keys and lut using the AQ for X722 devices. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 07/20] i40e: Cleanup the code with respect to restarting autoneg

From: Anjali Singhai Jain The restart-autoneg work around does not apply to X722. Added a flag to set it only for the right MAC and right FW version where the work around should be applied. Signed-off-by: Anjali Singhai Jain Change-ID:

[net-next 04/20] i40evf: allow channel bonding of VFs

From: Mitch Williams In some modes, bonding would not enslave VF interfaces. This is due to bonding calling change_mtu and the immediately calling open. Because of the asynchronous nature of the admin queue mechanism, the VF returns -EBUSY to the open call, because it

[net-next 15/20] i40e: add new proxy-wol bit for X722

From: Shannon Nelson Add the new proxy-wake-on-lan capability bit available with the new X722 device. Signed-off-by: Shannon Nelson Acked-by: Jesse Brandeburg Tested-by: Andrew Bowers

[net-next 13/20] i40evf: add new write-back mode

From: Anjali Singhai Jain Add write-back on interrupt throttle rate timer expiration support for the i40evf driver, when running on X722 devices. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers

[net-next 10/20] i40e: add new device IDs for X722

From: Anjali Singhai Jain Add the KX and QSFP device IDs for X722. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

On Wed, Feb 03, 2016 at 10:19:04AM +0100, Nikolay Aleksandrov wrote: > On 02/03/2016 04:04 AM, Nikolay Aleksandrov wrote: > > From: Nikolay Aleksandrov > > > > This patch allows the user to set and retrieve speed and duplex of the > > virtio_net device via ethtool.

[PATCH v3 4/4] ipv6: add option to drop unsolicited neighbor advertisements

From: Johannes Berg In certain 802.11 wireless deployments, there will be NA proxies that use knowledge of the network to correctly answer requests. To prevent unsolicitd advertisements on the shared medium from being a problem, on such deployments wireless needs to drop

[PATCH v3 3/4] ipv6: add option to drop unicast encapsulated in L2 multicast

From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv6 unicast packets encapsulated in link-layer multi- or broadcast

[PATCH v3 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv4 unicast packets encapsulated in link-layer multi- or broadcast

[PATCH v3 2/4] ipv4: add option to drop gratuitous ARP packets

From: Johannes Berg In certain 802.11 wireless deployments, there will be ARP proxies that use knowledge of the network to correctly answer requests. To prevent gratuitous ARP frames on the shared medium from being a problem, on such deployments wireless needs to drop

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

On Thu, Feb 04, 2016 at 12:23:02AM -0800, Fastabend, John R wrote: > On 2/3/2016 11:30 PM, Amir Vadai" wrote: > > On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: > >> This adds initial support for offloading the u32 tc classifier. This > >> initial implementation only implements a

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

On Thu, Feb 04, 2016 at 10:32:26AM +1100, Stephen Hemminger wrote: > On Wed, 3 Feb 2016 04:04:36 +0100 > Nikolay Aleksandrov wrote: > > > > > +static inline int ethtool_validate_speed(__u32 speed) > > +{ > > > No need for inline. > > But why check for valid value at

[PATCH v2 1/4] lib: move strtobool to kstrtobool

Create the kstrtobool_from_user helper and moves strtobool logic into the new kstrtobool (matching all the other kstrto* functions). Provides an inline wrapper for existing strtobool callers. Signed-off-by: Kees Cook --- include/linux/kernel.h | 3 +++

[PATCH v3 net 6/7] net: mvneta: The mvneta_percpu_elect function should be atomic

Electing a CPU must be done in an atomic way: it should be done after or before the removal/insertion of a CPU and this function is not reentrant. During the loop of mvneta_percpu_elect we associates the queues to the CPUs, if there is a topology change during this loop, then the mapping between

[PATCH v3 net 5/7] net: mvneta: Modify the queue related fields from each cpu

In the MVNETA_INTR_* registers, the queues related fields are per cpu, according to the datasheet (comment in [] are added by me): "In a multi-CPU system, bits of RX[or TX] queues for which the access by the reading[or writing] CPU is disabled are read as 0, and cannot be cleared[or written]."

[PATCH V2 net-next] hv_netvsc: cleanup netdev feature flags for netvsc

1. Adding NETIF_F_TSO6 feature flag; 2. Adding NETIF_F_HW_CSUM. NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated; 3. Cleanup the coding style of flag assignment by using macro. Signed-off-by: Simon Xiao Reviewed-by: K. Y. Srinivasan

[PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

This changes several users of manual "on"/"off" parsing to use strtobool. (Which means they will now parse y/n/1/0 meaningfully too.) Signed-off-by: Kees Cook Acked-by: Heiko Carstens Acked-by: Michael Ellerman Cc:

[PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

Add support for "on" and "off" when converting to boolean. Signed-off-by: Kees Cook --- lib/kstrtox.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index e18f088704d7..09e83a19a96d 100644 --- a/lib/kstrtox.c +++

[PATCH v2 2/4] lib: update single-char callers of strtobool

Some callers of strtobool were passing a pointer to unterminated strings. In preparation of adding multi-character processing to kstrtobool, update the callers to not pass single-character pointers, and switch to using the new kstrtobool_from_user helper where possible. Signed-off-by: Kees Cook

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

I missed the original email (I don't have net-devel in my mailbox), but based on Ingo's quoting have a more fundamental question: Why wasn't that done with C code instead of asm with odd numerical targets? It seems likely that the real issue is avoiding the short loops (that will cause branch

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

On Thu, Feb 4, 2016 at 2:43 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Create the kstrtobool_from_user helper and moves strtobool logic into >> the new kstrtobool (matching all the other kstrto* functions).

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 2:43 PM, Tom Herbert wrote: > > The reason I did this in assembly is precisely about the your point of > having to close the carry chains with adcq $0. I do have a first > implementation in C which using switch() to handle alignment, excess > length

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > This changes several users of manual "on"/"off" parsing to use strtobool. > (Which means they will now parse y/n/1/0 meaningfully too.) > I like this change, but can you carefully check the acceptance of the returned

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

On Thu, 2016-02-04 at 17:53 -0500, David Miller wrote: > From: Jacob Keller > Date: Tue,  2 Feb 2016 15:22:06 -0800 > > > Ethtool supports a few operations for modifying and controlling > > a device's RSS table. Sometimes, changes in other features of the > > device > >

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Create the kstrtobool_from_user helper and moves strtobool logic into > the new kstrtobool (matching all the other kstrto* functions). Provides > an inline wrapper for existing strtobool callers. > > Signed-off-by: Kees

[PATCH v2 0/4] lib: add "on" and "off" to strtobool

This consolidates logic for handling "on"/"off" parsing for bools into the strtobool function, by way of moving it into kstrtobool (with helpers), and updating various callers. arch/powerpc/kernel/rtasd.c|9 --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 10

[PATCH v3 net 2/7] net: mvneta: Fix the CPU choice in mvneta_percpu_elect

When passing to the management of multiple RX queue, the mvneta_percpu_elect function was broken. The use of the modulo can lead to elect the wrong cpu. For example with rxq_def=2, if the CPU 2 goes offline and then online, we ended with the third RX queue activated in the same time on CPU 0 and

[PATCH v3 net 4/7] net: mvneta: Remove unused code

Since the commit 2dcf75e2793c ("net: mvneta: Associate RX queues with each CPU") all the percpu irq are used and disabled at initialization, so there is no point to disable them first. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c |

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 1:46 PM, Linus Torvalds wrote: > > static const unsigned long mask[9] = { > 0x, > 0xff00, > 0x, > 0xff00, >

[PATCH v3 net 1/7] net: mvneta: Fix for_each_present_cpu usage

This patch convert the for_each_present in on_each_cpu, instead of applying on the present cpus it will be applied only on the online cpus. This fix a bug reported on http://thread.gmane.org/gmane.linux.ports.arm.kernel/468173. Using the macro on_each_cpu (instead of a for_each_* loop) also

[PATCH v3 net 0/7] mvneta fixes for SMP

Hi, Following this bug report: http://thread.gmane.org/gmane.linux.ports.arm.kernel/468173 and the suggestions from Russell King, I reviewed all the code involving multi-CPU. It ended with this series of patches which should improve the stability of the driver. During my test I found another bug

[PATCH v3 net 3/7] net: mvneta: Use on_each_cpu when possible

Instead of using a for_each_* loop in which we just call the smp_call_function_single macro, it is more simple to directly use the on_each_cpu macro. Moreover, this macro ensures that the calls will be done all at once. Suggested-by: Russell King Signed-off-by:

Re: [RFC RESEND] iwlwifi: pcie: transmit queue auto-sizing

I am not on linux-wireless nor netdev presently, but... On Thu, Feb 4, 2016 at 12:16 PM, Emmanuel Grumbach wrote: > As many (all?) WiFi devices, Intel WiFi devices have > transmit queues which have 256 transmit descriptors > each and each descriptor corresponds to an

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 9:09 AM, David Laight wrote: > From: Tom Herbert > ... >> > If nothing else reducing the size of this main loop may be desirable. >> > I know the newer x86 is supposed to have a loop buffer so that it can >> > basically loop on already decoded

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

On 02/04/2016 12:56 PM, Grumbach, Emmanuel wrote: On 02/04/2016 10:46 PM, Ben Greear wrote: On 02/04/2016 12:16 PM, Emmanuel Grumbach wrote: As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Some callers of strtobool were passing a pointer to unterminated strings. > In preparation of adding multi-character processing to kstrtobool, update > the callers to not pass single-character pointers, and switch to using

[PATCH v3 net 7/7] net: mvneta: Fix race condition during stopping

When stopping the port, the CPU notifier are still there whereas the mvneta_stop_dev function calls mvneta_percpu_disable() on each CPUs. It was possible to have a new CPU coming at this point which could be racy. This patch adds a flag preventing executing the code notifier for a new CPU when

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 1:46 PM, Linus Torvalds wrote: > I missed the original email (I don't have net-devel in my mailbox), > but based on Ingo's quoting have a more fundamental question: > > Why wasn't that done with C code instead of asm with odd numerical

Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Add support for "on" and "off" when converting to boolean. > > Signed-off-by: Kees Cook > --- > lib/kstrtox.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/lib/kstrtox.c

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

On Thu, Feb 04, 2016 at 10:16:56AM +0100, Jiri Pirko wrote: > Wed, Feb 03, 2016 at 10:27:32AM CET, john.fastab...@gmail.com wrote: > > > >Also by adding get_parse_graph and set_parse_graph attributes as > >in my previous flow_api work we can build programmable devices > >and programmatically learn

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

From: Jacob Keller Date: Tue, 2 Feb 2016 15:22:06 -0800 > Ethtool supports a few operations for modifying and controlling > a device's RSS table. Sometimes, changes in other features of the device > may require (or desire) changes to the RSS table. Currently there is

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

On Thu, Feb 4, 2016 at 2:59 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Some callers of strtobool were passing a pointer to unterminated strings. >> In preparation of adding multi-character processing to

Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

On Thu, Feb 4, 2016 at 3:00 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Add support for "on" and "off" when converting to boolean. >> >> Signed-off-by: Kees Cook >> --- >>

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 12:59 PM, Tom Herbert wrote: > On Thu, Feb 4, 2016 at 9:09 AM, David Laight wrote: >> From: Tom Herbert >> ... >>> > If nothing else reducing the size of this main loop may be desirable. >>> > I know the newer x86 is supposed

Re: [PATCH next] ipvlan: inherit MTU from master device

From: Mahesh Bandewar Date: Wed, 27 Jan 2016 23:33:28 -0800 > From: Mahesh Bandewar > > When we create IPvlan slave; we use ether_setup() and that > sets up default MTU to 1500 while the master device may have > lower / different MTU. Any subsequent

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

On Thu, Feb 04 2016, Kees Cook wrote: > Create the kstrtobool_from_user helper and moves strtobool logic into > the new kstrtobool (matching all the other kstrto* functions). Provides > an inline wrapper for existing strtobool callers. > > Signed-off-by: Kees Cook

Re: bonding reports interface up with 0 Mbps

Jay Vosburgh wrote: [...] > Thinking about the trace again... Emil: what happens in the >trace before this? Is there ever a call to the ixgbe_get_settings? >Does a NETDEV_UP or NETDEV_CHANGE event ever hit the bond_netdev_event >function? Emil kindly

Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'

On Tue, 2 Feb 2016 16:53:40 -0800 Roopa Prabhu wrote: > From: Roopa Prabhu > > 'ip monitor all' is broken on older kernels. > This patch fixes 'ip monitor all' to match > 'all' and not 'all-nsid'. > > It moves parsing arg 'all-nsid' to

Re: [RESEND PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

On Wed, 3 Feb 2016 08:25:00 + Nicolas Dichtel wrote: > Commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") was reverted > to ease the merge of the net-next branch. > > Here is the new version. > > Signed-off-by: Nicolas Dichtel

Re: [PATCH iproute2] geneve: add support for lwt tunnel creation and dst port selection

On Thu, 28 Jan 2016 14:48:55 +0100 Paolo Abeni wrote: > This change add the ability to create lwt/flow based/externally > controlled geneve device and to select the udp destination port used > by a full geneve tunnel. > > Signed-off-by: Paolo Abeni

Reply: [net] bonding: use return instead of goto

> On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > Replace 'goto' with 'return' to remove unnecessary check at label: > > err_undo_flags. > > I think you're going to have to explain how you came to the conclusion that > the check isn't necessary. > > -- > Jarod Wilson >

Re: [PATCH net-next 2/2] sfc: implement IPv6 NFC (and IPV4_USER_FLOW)

On Tue, 2016-02-02 at 18:49 +, Edward Cree wrote: > Signed-off-by: Edward Cree > --- >  drivers/net/ethernet/sfc/ethtool.c | 176 > + >  1 file changed, 176 insertions(+) > > diff --git a/drivers/net/ethernet/sfc/ethtool.c >

[PATCH v2 net-next 3/4] net: core: introduce neigh_ifdown_all for all down interfaces

This cleans up neighbour entries for all interfaces in the down state, avoiding walking the whole neighbour table for each interface being brought down. Signed-off-by: Salam Noureddine --- include/net/arp.h | 1 + include/net/neighbour.h | 1 +

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 5:27 PM, Linus Torvalds wrote: > sum = csum_partial_lt8(*(unsigned long *)buff, len, sum); > return rotate_by8_if_odd(sum, align); Actually, that last word-sized access to "buff" might be past the end of the buffer. The code

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

On Thu, Feb 4, 2016 at 2:09 PM, Linus Torvalds wrote: > > The "+" should be "-", of course - the point is to shift up the value > by 8 bits for odd cases, and we need to load starting one byte early > for that. The idea is that we use the byte shifter in the load

Re: [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API

On Tue, 2016-02-02 at 18:49 +, Edward Cree wrote: > Signed-off-by: Edward Cree > --- >  include/uapi/linux/ethtool.h | 70 > >  1 file changed, 64 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/ethtool.h

Reply: [PATCH iproute2] ip-link: remove warning message

> On Thu, 21 Jan 2016 02:23:49 + > Zhang Shengju wrote: > > > the warning was: > > iproute.c:301:12: warning: 'val' may be used uninitialized in this > > function [-Wmaybe-uninitialized] > >features &= ~RTAX_FEATURE_ECN; > > ^ > >

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

On Thu, Feb 4, 2016 at 4:11 PM, Kees Cook wrote: > On Thu, Feb 4, 2016 at 3:04 PM, Andy Shevchenko > wrote: >> On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >>> This changes several users of manual "on"/"off" parsing

feature - ip link set primary ?

Should there be an ip link set primary command in the iproute2 package, to set the Primary Slave on a "bond" type link? It seems that the alternative now is to use the sysfs, with echo -n > /sys/devices/virtual/net//bonding/primary which, in systemd Service Unit Files, requires

[PATCH v2 net-next 1/4] net: add event_list to struct net and provide utility functions

Signed-off-by: Salam Noureddine --- include/net/net_namespace.h | 22 ++ net/core/net_namespace.c| 1 + 2 files changed, 23 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 4089abc..6dbc0b2 100644 ---

[PATCH v2 net-next 2/4] net: dev: add batching to net_device notifiers

This can be used to optimize bringing down and unregsitering net_devices by running certain cleanup operations only on the net namespace instead of on each net_device. Signed-off-by: Salam Noureddine --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 48

[PATCH v2 net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

Call fib_flush at the end when closing or unregistering multiple devices. This can save walking the fib many times and greatly reduce rtnl_lock hold time when unregistering many devices with a fib having hundreds of thousands of routes. Signed-off-by: Salam Noureddine ---

[PATCH v2 net-next 0/4] batch calls to fib_flush and arp_ifdown

Added changes suggested by Julian Anastasov in version 2. fib_flush walks the whole fib in a net_namespace and is called for each net_device being closed or unregistered. This can be very expensive when dealing with 100k or more routes in the fib and removal of a lot of interfaces. These four

RE: [net] igbvf: remove "link is Up" message when registering mcast address

> From: netdev-ow...@vger.kernel.org [netdev-ow...@vger.kernel.org] on behalf > of Jon Maxwell [jmaxwel...@gmail.com] > Sent: Sunday, January 24, 2016 3:22 PM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; jmaxw...@redhat.com; vinsc...@redhat.com; > intel-wired-...@lists.osuosl.org;

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

On Thu, Feb 4, 2016 at 3:04 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> This changes several users of manual "on"/"off" parsing to use strtobool. >> (Which means they will now parse y/n/1/0 meaningfully too.)

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

From: "Keller, Jacob E" Date: Thu, 4 Feb 2016 23:09:56 + > So you're suggesting instead, to error when the second operation > (change number of queues) would fail the current settings? Yes. This is absolutely required.

RE: bonding reports interface up with 0 Mbps

>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Thursday, February 04, 2016 4:37 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj; >j...@mellanox.com >Subject: Re: bonding reports interface up with 0 Mbps > >Jay

Re: bonding reports interface up with 0 Mbps

On 02/05/2016 08:37 AM, Jay Vosburgh wrote: Jay Vosburgh wrote: [...] Thinking about the trace again... Emil: what happens in the trace before this? Is there ever a call to the ixgbe_get_settings? Does a NETDEV_UP or NETDEV_CHANGE event ever hit the

  1   2   >