[PATCH net-next V2 5/8] net: fec: add variable reg_desc_active to speed things up

2016-02-05 Thread Troy Kisky
There is no need for complex macros every time we need to activate a queue. Also, no need to call skb_get_queue_mapping when we already know which queue it is using. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 7 +

[PATCH net-next V2 3/8] net: fec: fix fec_enet_get_free_txdesc_num

2016-02-05 Thread Troy Kisky
When first initialized, cur_tx points to the 1st entry in the queue, and dirty_tx points to the last. At this point, fec_enet_get_free_txdesc_num will return tx_ring_size -2. If tx_ring_size -2 entries are now queued, then fec_enet_get_free_txdesc_num should return 0, but it returns tx_ring_size

[PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-05 Thread Andrew F. Davis
The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Add these and re-order code to support additional PHYs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 89

Re: [net-next] igb: assume MSI-X interrupts during initialization

2016-02-05 Thread Stefan Assmann
On 02/05/2016 10:24 PM, Laine Stump wrote: Stefan, I have an AMD 990FX system with an Intel 82576 card that could not successfully boot with any kernel starting somewhere prior to 4.2, but does boot properly in 4.4+. After a lot of time bisecting, I found that this patch, when applied to kernel

[PATCH net v4] r8169: Completition on Enable bios support.

2016-02-05 Thread Corcodel Marian
Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 2e83059..1d119a6 100644 ---

[PATCH net v4] r8169: Add bios support.

2016-02-05 Thread Corcodel Marian
This patch help do not compile functions relative to setting latency, setting bus master wich have provided on bios.Davem says "The chip can be used on systems without a BIOS and that should still work." Signed-off-by: Corcodel Marian --- drivers/Kconfig

Re: [PATCH 3/3] bonding: make device count build-time configurable

2016-02-05 Thread Lubomir Rintel
Hi Bjørn, On Tue, 2016-01-12 at 22:40 +0100, Bjørn Mork wrote: > David Miller writes: > > From: Lubomir Rintel > > Date: Tue, 12 Jan 2016 18:19:49 +0100 > > > > > It's still an improvement to let the distributions decide if > > > they're > > > keeping "ip

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

2016-02-05 Thread Keller, Jacob E
On Thu, 2016-02-04 at 19:30 -0500, David Miller wrote: > From: "Keller, Jacob E" > Date: Thu, 4 Feb 2016 23:09:56 + > > > So you're suggesting instead, to error when the second operation > > (change number of queues) would fail the current settings? > > Yes. > >

Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Sebastian Frias
On 02/05/2016 04:08 PM, Måns Rullgård wrote: Sebastian Frias writes: On 02/05/2016 03:34 PM, Måns Rullgård wrote: Sebastian Frias writes: Signed-off-by: Sebastian Frias Please change the subject to something like "net: ethernet:

[PATCH v3] openvswitch: allow management from inside user namespaces

2016-02-05 Thread Tycho Andersen
Operations with the GENL_ADMIN_PERM flag fail permissions checks because this flag means we call netlink_capable, which uses the init user ns. Instead, let's introduce a new flag, GENL_UNS_ADMIN_PERM for operations which should be allowed inside a user namespace. The motivation for this is to be

RE: bonding reports interface up with 0 Mbps

2016-02-05 Thread Tantilov, Emil S
>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Thursday, February 04, 2016 4:37 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj; >j...@mellanox.com >Subject: Re: bonding reports interface up with 0 Mbps > >Jay

Re: [PATCH 2/3] dummy: make device count build-time configurable

2016-02-05 Thread Lubomir Rintel
Hi Stephen, On Tue, 2016-01-12 at 10:42 -0800, Stephen Hemminger wrote: > On Tue, 12 Jan 2016 12:57:33 +0100 > Lubomir Rintel wrote: > > > The devices can be created at run-time for quite some time already > > and the > > load-time device creation collides with attempts to

Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Andy Shevchenko
On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård wrote: >> + if (ret < 0) { >> + dev_err(>dev, "broken fixed-link >> specification\n"); > > Line is longer than 80 chars. This is actually okay, though I would recommend to move long

[PATCH net] hv_netvsc: Restore needed_headroom request

2016-02-05 Thread Vitaly Kuznetsov
Commit c0eb454034aa ("hv_netvsc: Don't ask for additional head room in the skb") got rid of needed_headroom setting for the driver. With the change I hit the following issue trying to use ptkgen module: [ 57.522021] kernel BUG at net/core/skbuff.c:1128! [ 57.522021] invalid opcode: [#1]

Re: [PATCH net-next 2/2] sfc: implement IPv6 NFC (and IPV4_USER_FLOW)

2016-02-05 Thread Ben Hutchings
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote: > Signed-off-by: Edward Cree Reviewed-by: Ben Hutchings > --- >  drivers/net/ethernet/sfc/ethtool.c | 184 > + >  1 file changed, 184 insertions(+) > > diff

Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Måns Rullgård
Sebastian Frias writes: > On 02/05/2016 04:08 PM, Måns Rullgård wrote: >> Sebastian Frias writes: >> >>> On 02/05/2016 03:34 PM, Måns Rullgård wrote: Sebastian Frias writes: > Signed-off-by: Sebastian Frias

Re: [PATCH v2 net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

2016-02-05 Thread Sergei Shtylyov
On 02/05/2016 02:35 AM, Salam Noureddine wrote: Call fib_flush at the end when closing or unregistering multiple devices. This can save walking the fib many times and greatly reduce rtnl_lock hold time when unregistering many devices with a fib having hundreds of thousands of routes.

Re: Keystone 2 boards boot failure

2016-02-05 Thread Arnd Bergmann
On Thursday 04 February 2016 18:25:08 Grygorii Strashko wrote: > > > > I have another version for testing below. That removes the logic that > > splits and reassembles the 64-bit values, but leaves the other changes > > in place. Can you try this? > > > > Nop. It crashes kernel Ah. too bad. >

[PATCH] net: cavium: liquidio: fix check for in progress flag

2016-02-05 Thread Colin King
From: Colin Ian King smatch detected a suspicious looking bitop condition: drivers/net/ethernet/cavium/liquidio/lio_main.c:2529 handle_timestamp() warn: suspicious bitop condition (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero, so the logic is

Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Måns Rullgård
Sebastian Frias writes: > On 02/05/2016 03:34 PM, Måns Rullgård wrote: >> Sebastian Frias writes: >> >>> Signed-off-by: Sebastian Frias >> >> Please change the subject to something like "net: ethernet: nb8800: >> support fixed-link DT node"

Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Sebastian Frias
On 02/05/2016 03:34 PM, Måns Rullgård wrote: Sebastian Frias writes: Signed-off-by: Sebastian Frias Please change the subject to something like "net: ethernet: nb8800: support fixed-link DT node" and add a comment body. The subject is pretty explicit

[PATCH v4] net: ethernet: nb8800: support fixed-link DT node

2016-02-05 Thread Sebastian Frias
Properly handles the case where the PHY is not connected to the real MDIO bus Signed-off-by: Sebastian Frias --- drivers/net/ethernet/aurora/nb8800.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c

Re: gigaset: memory leak in gigaset_initcshw

2016-02-05 Thread Paul Bolle
Hi Dmitry, (If anyone is confused by this conversation: Dmitry replied to an off list message.) On vr, 2016-02-05 at 14:28 +0100, Dmitry Vyukov wrote: > I wonder why you don't see the leak I am seeing... So do I, for a few days now. > are you suing qemu or real hardware? I am using qemu. Real

Re: Keystone 2 boards boot failure

2016-02-05 Thread Grygorii Strashko
hi Arnd, On 02/05/2016 06:18 PM, Arnd Bergmann wrote: > On Thursday 04 February 2016 18:25:08 Grygorii Strashko wrote: >>> >>> I have another version for testing below. That removes the logic that >>> splits and reassembles the 64-bit values, but leaves the other changes >>> in place. Can you try

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-05 Thread Dave Taht
> A bursted txop can be as big as 5-10ms. If you consider you want to > queue 5-10ms worth of data for *each* station at any given time you > obviously introduce a lot of lag. If you have 10 stations you might > end up with service period at 10*10ms = 100ms. This gets even worse if > you consider

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-05 Thread Ben Greear
On 02/05/2016 12:44 AM, Michal Kazior wrote: Per-station queues sound tricky if you consider bufferbloat. To maximize use of airtime (i.e. txop) you need to send big aggregates. Since aggregates are per station-tid to maximize multi-station performance (in AP mode) you'll need to queue a lot

Re: [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API

2016-02-05 Thread Ben Hutchings
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote: > Signed-off-by: Edward Cree Reviewed-by: Ben Hutchings > --- >  include/uapi/linux/ethtool.h | 70 > >  1 file changed, 64 insertions(+), 6

Re: [PATCH net-next v1 2/2] tipc: fix link priority propagation

2016-02-05 Thread David Miller
From: Richard Alpe Date: Mon, 1 Feb 2016 08:19:57 +0100 > Currently link priority changes isn't handled for active links. In > this patch we resolve this by changing our priority if the peer passes > a valid priority in a state message. > > Reviewed-by: Jon Maloy

Re: [PATCH net-next v1 1/2] tipc: fix link attribute propagation bug

2016-02-05 Thread David Miller
From: Richard Alpe Date: Mon, 1 Feb 2016 08:19:56 +0100 > Changing certain link attributes (link tolerance and link priority) > from the TIPC management tool is supposed to automatically take > effect at both endpoints of the affected link. > > Currently the media

Re: [PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes

2016-02-05 Thread David Miller
From: Florian Fainelli Date: Fri, 5 Feb 2016 17:25:50 -0800 > On 03/02/16 13:13, Florian Fainelli wrote: >> Hi David, >> >> Here is a collection of fixes for the 40nm Ethernet PHY supported >> by the 7xxx PHY driver, please also queue these fixes for stable. >> >> Let me

Re: [net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-03

2016-02-05 Thread David Miller
From: Jeff Kirsher Date: Thu, 4 Feb 2016 03:48:51 -0800 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH net v4] r8169: Add bios support.

2016-02-05 Thread David Miller
From: Corcodel Marian Date: Sat, 6 Feb 2016 08:31:26 +0200 > @@ -8262,8 +8262,9 @@ static int rtl_init_one(struct pci_dev *pdev, const > struct pci_device_id *ent) > rtl_hw_reset(tp); > > rtl_ack_events(tp, 0x); > - > +#ifndef CONFIG_BIOS_SUPPORT >

Re: gigaset: memory leak in gigaset_initcshw

2016-02-05 Thread Paul Bolle
On vr, 2016-02-05 at 17:06 +0100, Paul Bolle wrote: > If that would happen, then cs can be reused while the previous > > cs->hw.ser is not freed yet. Just a guess. > > I'll have to ponder on that a bit, sorry. This is from the hit-the-code-until-it-confesses department: ---

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-05 Thread Alexei Starovoitov
On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote: > > Okay. I see it more as changing mode of operation of hardware and thus has > not really anything to do with networking. If you say you change ethernet to > infiniband it has something to do with networking, sure. But I am

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-05 Thread Jason A. Donenfeld
On Thu, Feb 4, 2016 at 4:44 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 22:02 +0100, Jason A. Donenfeld wrote: > >> >> > I don't know about the particular problems with >> > tunnels but the scripts can use the route metric to order >> > the routes in a table.

Re: Keystone 2 boards boot failure

2016-02-05 Thread Murali Karicheri
On 02/03/2016 03:13 PM, santosh shilimkar wrote: > On 2/3/2016 10:47 AM, Murali Karicheri wrote: >> On 02/03/2016 12:08 PM, santosh shilimkar wrote: >>> On 2/3/2016 8:35 AM, Arnd Bergmann wrote: > > [..] > It would be nice to give this a go once the network driver problem is solved.

[PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

2016-02-05 Thread Vivien Didelot
BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the VLAN with the bridge's default_pvid. The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports isolation. When a port joins a bridge, it leaves its reserved VLAN. When a port leaves a bridge, it joins again its

[RFC 0/2] mac80211: add support for ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
This patchset allows the ht_caps mcs rxmask to be defined on the fly. It applies the given rxmask to all available bands. This is actually limited to radio cards without internal rc. Cedric DEBARGE (2): cfg80211: add support for ht_caps mcs rxmask override nl80211: add nl attribute to set

[RFC 1/2] cfg80211: add support for ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
Allows the ht_caps mcs rxmask to be defined on the fly. In this implementation, the given rxmask is applied to every band available. This is only applicable for radio cards without internal rc. Signed-off-by: Cedric Debarge --- include/net/cfg80211.h | 7 +++

[RFC 2/2] nl80211: add nl attribute to set ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
This adds the NL80211_ATTR_WIPHY_HTCAP_RXMASK attribute to NL80211_CMD_SET_WIPHY in order for the user to specify the ht_caps mcs rxmask. Signed-off-by: Cedric Debarge --- include/uapi/linux/nl80211.h | 5 + net/wireless/nl80211.c | 18 ++

[PATCH net] net: dsa: mv88e6xxx: fix software VLAN deletion

2016-02-05 Thread Vivien Didelot
The current bridge code calls switchdev_port_obj_del on a VLAN port even if the corresponding switchdev_port_obj_add call returned -EOPNOTSUPP. If the DSA driver doesn't return -EOPNOTSUPP for a software port VLAN in its port_vlan_del function, the VLAN is not deleted. Unbridging the port also

[V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Joseph Salisbury
Hi Rainer, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 3822b5c2fc62e3de8a0f33806ff279fb7df92432 Author: Rainer Weikusat Date: Wed Dec 16 20:09:25 2015

我的主页在

2016-02-05 Thread 我的主页在
你的老朋友邀你来Q群:343257759

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-05 Thread Ingo Molnar
* Tom Herbert wrote: > [] gcc turns these switch statements into jump tables (not function > tables > which is what Ingo's example code was using). [...] So to the extent this still matters, on most x86 microarchitectures that count, jump tables and function call

Hello There

2016-02-05 Thread Ms.Ella Golan
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your

Re: [PATCH 1/3] ifb: make device count build-time configurable

2016-02-05 Thread Lubomir Rintel
On Tue, 2016-01-12 at 15:54 -0500, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 12 Jan 2016 10:44:37 -0800 > > > On Tue, 12 Jan 2016 07:55:22 -0500 > > Jamal Hadi Salim wrote: > >  > >> On 16-01-12 06:56 AM, Lubomir Rintel wrote: > >>

Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

2016-02-05 Thread Måns Rullgård
Andy Shevchenko writes: > On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård wrote: >>> + if (ret < 0) { >>> + dev_err(>dev, "broken fixed-link >>> specification\n"); >> >> Line is longer than 80 chars. > >

[PATCH net-next 1/2] mpls: packet stats

2016-02-05 Thread Robert Shearman
Having MPLS packet stats is useful for observing network operation and for diagnosing network problems. In the absence of anything better, use RFCs for MIBs defining MPLS stats for guidance on the semantics of the stats to expose. RFC3813 details two per-interface packet stats that should be

[PATCH net-next 2/2] mpls: allow TTL propagation to/from IP packets to be configured

2016-02-05 Thread Robert Shearman
It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses used in the provider network overlap with addresses in the overlay

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Joseph Salisbury writes: > Hi Rainer, > > A kernel bug report was opened against Ubuntu [0]. After a kernel > bisect, it was found that reverting the following commit resolved this bug: > > commit 3822b5c2fc62e3de8a0f33806ff279fb7df92432 > Author: Rainer Weikusat

[PATCH net-next 2/8] net: udp: always set up for CHECKSUM_PARTIAL offload

2016-02-05 Thread Edward Cree
If the dst device doesn't support it, it'll get fixed up later anyway by validate_xmit_skb(). Also, this allows us to take advantage of LCO to avoid summing the payload multiple times. Signed-off-by: Edward Cree --- net/ipv4/udp.c | 14 +-

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-05 Thread Kees Cook
On Thu, Feb 4, 2016 at 3:55 PM, Rasmus Villemoes wrote: > On Thu, Feb 04 2016, Kees Cook wrote: > >> Create the kstrtobool_from_user helper and moves strtobool logic into >> the new kstrtobool (matching all the other kstrto* functions). Provides

[net-next PATCH 06/10] gre: Use GSO flags to determine csum need instead of GRE flags

2016-02-05 Thread Alexander Duyck
This patch updates the gre checksum path to follow something much closer to the UDP checksum path. By doing this we can avoid needing to do as much header inspection and can just make use of the fields we were already reading in the sk_buff structure. Signed-off-by: Alexander Duyck

[net-next PATCH 07/10] gre: Use inner_proto to obtain inner header protocol

2016-02-05 Thread Alexander Duyck
Instead of parsing headers to determine the inner protocol we can just pull the value from inner_proto. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/ipv4/gre_offload.c

[net-next PATCH 02/10] net: Move GSO csum into SKB_GSO_CB

2016-02-05 Thread Alexander Duyck
This patch moves the checksum maintained by GSO out of skb->csum and into the GSO context block in order to allow for us to work on outer checksums while maintaining the inner checksum offsets in the case of the inner checksum being offloaded, while the outer checksums will be computed. While

[net-next PATCH 04/10] net: Store checksum result for offloaded GSO checksums

2016-02-05 Thread Alexander Duyck
This patch makes it so that we can offload the checksums for a packet up to a certain point and then begin computing the checksums via software. Setting this up is fairly straight forward as all we need to do is reset the values stored in csum and csum_start for the GSO context block. One

[net-next PATCH 03/10] net: Update remote checksum segmentation to support use of GSO checksum

2016-02-05 Thread Alexander Duyck
This patch addresses two main issues. First in the case of remote checksum offload we were avoiding dealing with scatter-gather issues. As a result it would be possible to assemble a series of frames that used frags instead of being linearized as they should have if remote checksum offload was

[net-next PATCH 05/10] net: Move skb_has_shared_frag check out of GRE code and into segmentation

2016-02-05 Thread Alexander Duyck
The call skb_has_shared_frag is used in the GRE path and skb_checksum_help to verify that no frags can be modified by an external entity. This check really doesn't belong in the GRE path but in the skb_segment function itself. This way any protocol that might be segmented will be performing this

[PATCH net-next V2 2/8] net: fec: fix rx error counts

2016-02-05 Thread Troy Kisky
On an overrun, the other flags are not valid, so don't check them. Also, don't pass bad frames up the stack. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 36 +-- 1 file changed, 15 insertions(+), 21

[PATCH net-next V2 8/8] net: fec: improve error handling

2016-02-05 Thread Troy Kisky
Unmap initial buffer on error. Don't free skb until it has been unmapped. Move cbd_bufaddr assignment closer to the mapping function. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH net-next V2 4/8] net: fec: add struct bufdesc_prop

2016-02-05 Thread Troy Kisky
This reduces code and gains speed. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 29 ++- drivers/net/ethernet/freescale/fec_main.c | 288 -- 2 files changed, 132 insertions(+), 185 deletions(-) diff --git

[PATCH net-next V2 0/8] net: fec: cleanup/fixes

2016-02-05 Thread Troy Kisky
V2 is a rebase on top of johannes endian-safe patch and is only the 1st eight patches. The testing for this series was done on a nitrogen6x. The base commit was commit b45efa30a626e915192a6c548cd8642379cd47cc Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net Testing showed no

[PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-05 Thread Troy Kisky
If you don't own it, you shouldn't write to it. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c

[PATCH net-next V2 6/8] net: fec: don't disable FEC_ENET_TS_TIMER interrupt

2016-02-05 Thread Troy Kisky
Only the interrupt routine processes this condition. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-02-05 Thread Salam Noureddine
Forgot to mention the rtnl_lock hold time gain with these changes. I got the following benchmark results on one of our switches. Without this patch, deleting 1k interfaces with 100k routes in the fib held the rtnl_lock for 13 seconds. With the patch, rtnl_lock hold time went down to 5 seconds.

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Eric Dumazet
On Fri, 2016-02-05 at 21:44 +, Rainer Weikusat wrote: > The present unix_stream_read_generic contains various code sequences of > the form > > err = -EDISASTER; > if () > goto out; > > This has the unfortunate side effect of possibly causing the error code > to bleed through to the

[net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
The enc_features variable isn't necessary since features isn't used anywhere after we create enc_features so instead just use a destructive AND on features itself and save ourselves the variable declaration. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6

[net-next PATCH 00/10] Add GSO support for outer checksum w/ inner checksum offloads

2016-02-05 Thread Alexander Duyck
This patch series updates the existing segmentation offload code for tunnels to make better use of existing and updated GSO checksum computation. This is done primarily through two mechanisms. First we maintain a separate checksum in the GSO context block of the sk_buff. This allows us to

[PATCH net-next V2 1/8] net: fec: stop the "rcv is not +last, " error messages

2016-02-05 Thread Troy Kisky
Setting the FTRL register will stop the fec from trying to use multiple receive buffers. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-05 Thread David Miller
From: Robert Jarzmik Date: Fri, 05 Feb 2016 22:44:56 +0100 > Apart from Alberto who answered he cannot test it by lack of hardware, the > others didn't answer. > > So how can I move forward ? Would you want me to amend the KConfig to add a > "&& > !ARCH_PXA" on the

[PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-05 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned

[PATCH] af_unix: Don't use continue to re-execute unix_stream_read_generic loop

2016-02-05 Thread Rainer Weikusat
The unix_stream_read_generic function tries to use a continue statement to restart the receive loop after waiting for a message. This may not work as intended as the caller might use a recvmsg call to peek at control messages without specifying a message buffer. If this was the case, the continue

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-05 Thread Robert Jarzmik
Robert Jarzmik writes: > David Miller writes: > >> From: Robert Jarzmik >> Date: Mon, 30 Nov 2015 22:40:28 +0100 >> >>> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >>> slave driver. This makes

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Rainer Weikusat writes: > Joseph Salisbury writes: >> On 02/05/2016 02:59 PM, Rainer Weikusat wrote: > > [recvmsg w/o iovecs returning ENOTSUP for CMSG requests] [...] > There are more problems wrt handling

[net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
The enc_features variable isn't necessary since features isn't used anywhere after we create enc_features so instead just use a destructive AND on features itself and save ourselves the variable declaration. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6

Re: [net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
Please ignore this patch. I am re-sending series with cover page. Sorry for the noise. - Alex

[PATCH 18/30] rapidio/rionet: add mport removal handling

2016-02-05 Thread Alexandre Bounine
Add handling of a local mport device removal. RIONET driver registers itself as class interface that supports only removal notification, 'add_device' callback is not provided because RIONET network device can be initialized only after enumeration is completed and the existing method (using remote

[PATCH 0/2] ethtool: {SG}RXFH indirection deficiency

2016-02-05 Thread Jacob Keller
This patch set adds a new ethtool operation .reset_rxfh_indir which is used by the core ethtool stack to properly indicate to a driver that the default RSS indirection table has been requested. Current behavior for notifying the default settings is indistinguishable from an explicit request. There

[PATCH 1/2] ethtool: support notifying drivers when user requests default rxfh table

2016-02-05 Thread Jacob Keller
Currently, userspace ethtool supports requesting the default indirection table by passing 0 as the indir_size. However, ops->set_rxfh does not distinguish between user requesting default via indir_size=0 and user requesting explicitly settings which are equivalent of the default. This causes

[PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-05 Thread Jacob Keller
Previously, the fm10k driver would incorrectly allow changing the number of combined channels when this would have altered user configured RSS indirection table. With the new ethtool operation .reset_rxfh_indir, we are now able to correctly handle the changes to number of channels. This requires

[PATCH net-next 7/8] net: ip_tunnel: remove 'csum_help' argument to iptunnel_handle_offloads

2016-02-05 Thread Edward Cree
All users now pass false, so we can remove it, and remove the code that was conditional upon it. Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 4 ++-- include/net/ip_tunnels.h| 3 +-- include/net/udp_tunnel.h| 3 +-- net/ipv4/fou.c

[PATCH net-next 4/8] net: vxlan: enable local checksum offload

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6543918..7299e5f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1706,10

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Joseph Salisbury
On 02/05/2016 02:59 PM, Rainer Weikusat wrote: > Joseph Salisbury writes: >> Hi Rainer, >> >> A kernel bug report was opened against Ubuntu [0]. After a kernel >> bisect, it was found that reverting the following commit resolved this bug: >> >> commit

[PATCH net-next 5/8] fou: enable LCO in FOU and GUE

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/fou.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 976f0dc..dac1874 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -774,7 +774,6 @@ static void

[PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/ip_gre.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 7c51c4e..9b31532 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -440,6 +440,17 @@

[PATCH net-next 3/8] net: enable LCO for udp_tunnel_handle_offloads() users

2016-02-05 Thread Edward Cree
The only protocol affected at present is Geneve. Signed-off-by: Edward Cree --- include/net/udp_tunnel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index cca2ad3..734c156 100644 ---

[PATCH v3 1/4] lib: move strtobool to kstrtobool

2016-02-05 Thread Kees Cook
Create the kstrtobool_from_user helper and moves strtobool logic into the new kstrtobool (matching all the other kstrto* functions). Provides an inline wrapper for existing strtobool callers. Signed-off-by: Kees Cook --- v3: - drop needless "base" argument, rasmus ---

Re: gigaset: memory leak in gigaset_initcshw

2016-02-05 Thread Dmitry Vyukov
On Fri, Feb 5, 2016 at 7:36 PM, Paul Bolle wrote: > On vr, 2016-02-05 at 17:06 +0100, Paul Bolle wrote: >> If that would happen, then cs can be reused while the previous >> > cs->hw.ser is not freed yet. Just a guess. >> >> I'll have to ponder on that a bit, sorry. > > This is

[PATCH net-next 0/2] mpls: packet stats and ttl propagation config

2016-02-05 Thread Robert Shearman
This patch series implements new bits of mpls functionality: keeping statistics on packets as they pass through the box and allowing ttl propagation to be configured. Robert Shearman (2): mpls: packet stats mpls: allow TTL propagation to/from IP packets to be configured

[PATCH v4 net-next 0/8] Local Checksum Offload

2016-02-05 Thread Edward Cree
Tested with VxLAN, GRE and FOU-IPIP tunnels. Not tested with GENEVE, because iproute2 doesn't support enabling checksums on GENEVE tunnels. Also tested VxLAN with IPv6 (as both inner and outer protocol). Changes from v3: * Fixed inverted checksum values introduced in v3. * Don't mangle zero

[PATCH net-next 8/8] Documentation/networking: add checksum-offloads.txt to explain LCO

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- Documentation/networking/00-INDEX | 2 + Documentation/networking/checksum-offloads.txt | 119 + include/linux/skbuff.h | 2 + 3 files changed, 123 insertions(+) create mode

[PATCH v3 4/4] param: convert some "on"/"off" users to strtobool

2016-02-05 Thread Kees Cook
This changes several users of manual "on"/"off" parsing to use strtobool. Some side-effects: - these uses will now parse y/n/1/0 meaningfully too - the early_param uses will now bubble up parse errors Signed-off-by: Kees Cook Acked-by: Heiko Carstens

[PATCH net-next 1/8] net: local checksum offload for encapsulation

2016-02-05 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the

[PATCH v3 2/4] lib: update single-char callers of strtobool

2016-02-05 Thread Kees Cook
Some callers of strtobool were passing a pointer to unterminated strings. In preparation of adding multi-character processing to kstrtobool, update the callers to not pass single-character pointers, and switch to using the new kstrtobool_from_user helper where possible. Signed-off-by: Kees Cook

[PATCH v3 0/4] lib: add "on" and "off" to strtobool

2016-02-05 Thread Kees Cook
This consolidates logic for handling "on"/"off" parsing for bools into the strtobool function, by way of moving it into kstrtobool (with helpers), and updating various callers. v3: - removed unused "base" argument - fixed missing description change - retained inverted __setup return values -

[PATCH v3 3/4] lib: add "on"/"off" support to kstrtobool

2016-02-05 Thread Kees Cook
Add support for "on" and "off" when converting to boolean. Signed-off-by: Kees Cook --- v3: - add dropped descripion change, andy.shevchenko --- lib/kstrtox.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/lib/kstrtox.c

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Joseph Salisbury writes: > On 02/05/2016 02:59 PM, Rainer Weikusat wrote: [recvmsg w/o iovecs returning ENOTSUP for CMSG requests] >> Funny little problem :-). The code using the interruptible lock cleared >> err as side effect hence the >> >> out: >> return

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

2016-02-05 Thread Kees Cook
On Fri, Feb 5, 2016 at 2:46 AM, David Laight wrote: > From: Kees Cook >> Sent: 04 February 2016 21:01 >> Some callers of strtobool were passing a pointer to unterminated strings. >> In preparation of adding multi-character processing to kstrtobool, update >> the callers

Re: Reply: [net] bonding: use return instead of goto

2016-02-05 Thread Jarod Wilson
On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > err_undo_flags. > > > > I think you're going to have to explain how you came to the conclusion > >

  1   2   >