[PATCH] vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()

2016-03-14 Thread Arnd Bergmann
A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a way that left the error handling for oversized headers unlock a lock that had not been taken yet. Gcc warns about the incorrect use of the 'flags' variable because of that: drivers/net/vmxnet3/vmxnet3_drv.c: In function

Re: Generic TSO

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 3:32 AM, Edward Cree wrote: > On 14/03/16 10:26, Edward Cree wrote: >> On 12/03/16 05:40, Alexander Duyck wrote: >>> Well that is the thing. Before we can actually start tinkering with >>> the outer header we probably need to make sure we set the DF

Re: When will net-next merge with linux-next?

2016-03-14 Thread gre...@linuxfoundation.org
On Mon, Mar 14, 2016 at 06:09:41AM +, Dexuan Cui wrote: > Hi David, > I have a pending patch of the hv_sock driver, which should go into the > kernel through the net-next tree: > https://lkml.org/lkml/2016/2/14/7 > > The VMBus side's supporting patches of hv_sock have been in Greg's tree >

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Jiri Pirko
Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >This patch adds a new RTM_GETSTATS message to query link stats via netlink >from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >returns a lot more than just

[PATCH trivial] netfilter: xt_limit: Spelling s/maxmum/maximum/

2016-03-14 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- net/netfilter/xt_limit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_limit.c b/net/netfilter/xt_limit.c index bef8505965589298..c1a4d5bf25d5bf9f 100644 --- a/net/netfilter/xt_limit.c +++

Re: pull-request: wireless-drivers-next 2016-03-14

2016-03-14 Thread David Miller
From: Kalle Valo Date: Mon, 14 Mar 2016 10:31:48 +0200 > I know I'm late now that merge window was opened yesterday but here's > one more set of patches I would like to get to 4.6 still. There isn't > anything controversial so I hope this should be still safe to pull. The >

RE: [ethtool PATCH v4 10/11] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-14 Thread David Laight
> > + /* ignore optional '0x' prefix */ > > + if ((slen > 2) && ( Unnecessary (). > > + (0 == memcmp(s, "0x", 2) > > +  || (0 == memcmp(s, "0X", 2) { A-about-F comparisons. > memcmp() is a really poor tool for comparing strings.  You should use >

[PATCH] fsl/fman: fix dtsec_set_tx_pause_frames

2016-03-14 Thread igal.liberman
From: Igal Liberman Fix a bug introduced in e06a03b (fsl/fman: fix the pause_time test) When pause_time is set to '0' - pause frames are disabled and there's no need to apply dTSEC-A003 Errata workaround. Signed-off-by: Igal Liberman

[PATCH net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
For LLC based protocols like lldp, stp etc., the ethernet header is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or even 0x806. In this world, the skb_network_header() points at the DSAP/SSAP/.. and is not likely to be NET_IP_ALIGNed in ixgbe_atr(). With LLC, drivers are not

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Nicolas Dichtel
Le 13/03/2016 02:56, Roopa Prabhu a écrit : From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-14 Thread Giuseppe CAVALLARO
Hi Tomeu On 3/14/2016 12:43 PM, Tomeu Vizoso wrote: Hi Peppe, with that patch I don't see any difference at all in my setup. So to be clear, with these commits on top of next-20160314, I still get the hang during boot: 209afef6f0cd ARM: dts: rockchip: Add mdio node to ethernet node

Re: [PATCH v2 0/2] net: thunderx: Performance enhancement changes

2016-03-14 Thread David Miller
From: sunil.kovv...@gmail.com Date: Mon, 14 Mar 2016 16:36:13 +0530 > Below patches attempts to improve performance by reducing > no of atomic operations while allocating new receive buffers > and reducing cache misses by adjusting nicvf structure elements. > > Changes from v1: > No changes,

RE: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Elad Raz
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Roopa Prabhu > Sent: Sunday, March 13, 2016 3:56 AM > To: netdev@vger.kernel.org > Cc: j...@mojatatu.com; da...@davemloft.net > Subject: [PATCH net-next 1/2] rtnetlink: add new

Re: Backport patch from 4.2 to 3.18

2016-03-14 Thread Sasha Levin
On 03/04/2016 04:26 PM, Sasha Levin wrote: > On 03/04/2016 03:40 PM, Andrei Sharaev wrote: >> > Hi Sasha, >> > >> > Can you backport this patch for "inet-frag-fixes" to linux kernel 3.18 LTS? >> > http://kernel.suse.com/cgit/kernel/commit/?h=v4.2-rc5=64b892ad2326348a5b8314167590d240e3bcc69e >> >

Re: [PATCH][net-next] ipv6: replace write lock with read lock in addrconf_permanent_addr

2016-03-14 Thread David Miller
From: roy.qing...@gmail.com Date: Mon, 14 Mar 2016 17:35:08 +0800 > From: Li RongQing > > nothing of idev is changed, so read lock is enough > > Signed-off-by: Li RongQing We need it for the modifications made by fixup_permanent_addr().

Re: [PATCH 1/1] net: Fix use after free in the recvmmsg exit path

2016-03-14 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Mon, 14 Mar 2016 09:56:35 -0300 > From: Arnaldo Carvalho de Melo > > The syzkaller fuzzer hit the following use-after-free: > > Call Trace: >[] __asan_report_load8_noabort+0x3e/0x40 > mm/kasan/report.c:295 >[]

Re: userns, netns, and quick physical memory consumption by unprivileged user

2016-03-14 Thread Yuriy M. Kaminskiy
On 03/14/16 12:14 , Michal Hocko wrote: > On Fri 11-03-16 18:06:59, Yuriy M. Kaminskiy wrote: > [...] >> And also tried with memcg: >> t=/sys/fs/cgroup/memory/test1;mkdir $t;echo 0 >$t/tasks; >> echo 48M >$t/memory.limit_in_bytes; su testuser [...] >> and it has not helped at all (rather

Re: [PATCH -next] bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict

2016-03-14 Thread Zefir Kurtisi
On 03/12/2016 11:14 AM, Florian Westphal wrote: > Zefir Kurtisi reported kernel panic with an openwrt specific patch. > However, it turns out that mainline has a similar bug waiting to happen. > > Once NF_HOOK() returns the skb is in undefined state and must not be > used. Moreover, the okfn

Re: [PATCH net-next v1] tipc: make sure IPv6 header fits in skb headroom

2016-03-14 Thread David Miller
From: Richard Alpe Date: Mon, 14 Mar 2016 09:43:52 +0100 > Expand headroom further in order to be able to fit the larger IPv6 > header. Prior to this patch this caused a skb under panic for certain > tipc packets when using IPv6 UDP bearer(s). > > Signed-off-by:

Re: [PATCH v6 net-next 00/10] API set for HW Buffer management

2016-03-14 Thread David Miller
From: Gregory CLEMENT Date: Mon, 14 Mar 2016 09:38:55 +0100 > This is the sixth version of the API set for HW Buffer management (that was > initially submitted here: > http://thread.gmane.org/gmane.linux.kernel/2125152). Series applied, thanks.

Re: [net-next PATCH 3/7] net: bulk alloc and reuse of SKBs in NAPI context

2016-03-14 Thread Jesper Dangaard Brouer
On Sun, 13 Mar 2016 16:06:17 +0200 Rana Shahout wrote: > On Fri, Mar 4, 2016 at 3:01 PM, Jesper Dangaard Brouer > wrote: > > > /* build_skb() is wrapper over __build_skb(), that specifically > > * takes care of skb->head and skb->pfmemalloc > > *

Re: [net-next,iproute2] netconf: add support for ignore route attribute

2016-03-14 Thread Stephen Hemminger
On Mon, 14 Mar 2016 04:55:36 + Zhang Shengju wrote: > Add support for ignore_routes_with_linkdown attribute. > > Signed-off-by: Zhang Shengju > --- > ip/ipnetconf.c | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-14 Thread Leon Romanovsky
On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: > > > On 2016/3/12 18:43, Leon Romanovsky wrote: > > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > >> It added hns_dsaf_roce_reset routine for roce driver. > >> RoCE is a feature of hns. > >> In hip06 SOC, in

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread oulijun
Hi Parav Pandit, thanks your reviewing. On 2016/3/4 17:37, Parav Pandit wrote: > On Fri, Mar 4, 2016 at 2:11 PM, Wei Hu(Xavier) > wrote: >> + >> +int hns_roce_register_device(struct hns_roce_dev *hr_dev) >> +{ >> + int ret; >> + struct hns_roce_ib_iboe *iboe

Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

2016-03-14 Thread Kalle Valo
Sudip Mukherjee writes: > From: Jia-Ju Bai > > The memory allocated by kzalloc in b43_bus_dev_ssb_init and > b43_bus_dev_bcma_init is not freed. > This patch fixes the bug by adding kfree in b43_ssb_remove, > b43_bcma_remove and error handling

Re: [PATCH V2 net 0/4] net: hns: bugs fix about hns driver

2016-03-14 Thread Lisheng011
We will appoint Daode Huang to send these patchs. Thanks. 在 2016/3/12 0:56, David Miller 写道: This does not work. I will not allow two sets of people sending me patches in parallel to the same driver at the same time. Have one person manage the maintainence of

Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action

2016-03-14 Thread Stephen Hemminger
On Wed, 9 Mar 2016 07:04:36 -0500 Jamal Hadi Salim wrote: > + fprintf(f, "\t Metadata: "); > + > + if (metalist[IFE_META_SKBMARK]) { > + len = RTA_PAYLOAD(metalist[IFE_META_SKBMARK]); > + if (len) { > +

When will net-next merge with linux-next?

2016-03-14 Thread Dexuan Cui
Hi David, I have a pending patch of the hv_sock driver, which should go into the kernel through the net-next tree: https://lkml.org/lkml/2016/2/14/7 The VMBus side's supporting patches of hv_sock have been in Greg's tree and linux-next for more than 1 month, but they haven't been in net-next yet,

Re: [PATCH] kcm: fix variable type

2016-03-14 Thread Andrzej Hajda
On 03/11/2016 05:44 PM, David Miller wrote: > From: Andrzej Hajda > Date: Fri, 11 Mar 2016 07:51:15 +0100 > >> Function skb_splice_bits can return negative values, its result should >> be assigned to signed variable to allow correct error checking. >> >> The problem has been

Re: [PATCH iproute2 net-next v4] bridge: mdb: add support for extended router port information

2016-03-14 Thread Stephen Hemminger
On Mon, 7 Mar 2016 11:10:32 +0100 Nikolay Aleksandrov wrote: > rem = RTA_PAYLOAD(attr); > for (i = RTA_DATA(attr); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) { > port_ifindex = RTA_DATA(i); > - fprintf(f, "%s ",

[PATCH v3 1/9] net: arc_emac: make the rockchip emac document more compatible

2016-03-14 Thread Caesar Wang
Add the rk3036 SoCs to match driver for document since the emac driver has supported the rk3036 SoCs. This patch adds the rk3036/rk3066/rk3188 SoCS to compatible for rockchip emac ducument. Also, that will suit for other SoCs in the future. Signed-off-by: Caesar Wang Cc:

Re: [PATCH v6 net-next 01/10] misc: sram: add optional ioremap without write combining

2016-03-14 Thread Gregory CLEMENT
Hi Arnd, I forgot to add you in CC for this patch. What is your opinion about it? Gregory On lun., mars 14 2016, Gregory CLEMENT wrote: > From: Marcin Wojtas > > Some SRAM users may require non-bufferable access to the memory, which

Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

2016-03-14 Thread Giuseppe CAVALLARO
On 3/14/2016 10:14 AM, Gabriel Fernandez wrote: Hi Peppe, Just one remark below diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 6a52fa1..d2322e9 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

[PATCH][net-next] ipv6: replace write lock with read lock in addrconf_permanent_addr

2016-03-14 Thread roy . qing . li
From: Li RongQing nothing of idev is changed, so read lock is enough Signed-off-by: Li RongQing --- net/ipv6/addrconf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index

Re: [PATCH v6 net-next 08/10] net: mvneta: bm: add support for hardware buffer management

2016-03-14 Thread Jesper Dangaard Brouer
On Mon, 14 Mar 2016 09:39:03 +0100 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/marvell/mvneta.c > b/drivers/net/ethernet/marvell/mvneta.c > index b0ae69f84493..2847c0c291de 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++

RE: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-03-14 Thread Yangbo Lu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Monday, March 14, 2016 6:26 AM > To: linuxppc-...@lists.ozlabs.org > Cc: Yangbo Lu; devicet...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-ker...@vger.kernel.org; linux- > c...@vger.kernel.org;

[PATCH v3 0/9] arc_emac: fixes the emac issues and cleanup emac drivers

2016-03-14 Thread Caesar Wang
Hi all, This series patches are based on kernel 4.5-rc7+ version. Linux version 4.5.0-rc7-next-20160311+ (wxt@nb) (...) #45 SMP Sun Mar 13 16:17:56 The history patch in here: Patch-v1: https://lkml.org/lkml/2016/3/11/209 Patch-v2: https://lkml.org/lkml/2016/3/13/39 Verified on kylin board with

[PATCH v3 3/9] net: arc_emac: support the phy reset for emac driver

2016-03-14 Thread Caesar Wang
This patch adds to support the emac phy reset. Different boards may require different phy reset duration. Add property phy-reset-duration for emac driver, so that the boards that need a longer reset duration can specify it in their device tree. Signed-off-by: Heiko Stuebner

[PATCH v3 2/9] net: arc_emac: add phy reset is optional for device tree

2016-03-14 Thread Caesar Wang
This patch adds the following property for arc_emac. 1) phy-reset-gpios: The phy-reset-gpio is an optional property for arc emac device tree boot. Change the binding document to match the driver code. 2) phy-reset-duration: Different boards may require different phy reset duration. Add property

[PATCH v3 5/9] clk: rockchip: add node-id for rk3036 emac hclk

2016-03-14 Thread Caesar Wang
From: Xing Zheng Add the node-id for the emac hclk to the binding header. Signed-off-by: Xing Zheng Signed-off-by: Caesar Wang Cc: Xing Zheng Cc: Michael Turquette Cc:

[PATCH v3 7/9] clk: rockchip: add clock-id for rk3036 emac pll source clock

2016-03-14 Thread Caesar Wang
From: Xing Zheng Suitable PLLs for the emac on the rk3036 are difficult to find and one of them is the (continuously changing) APLL. So in most cases it will be necessary to select a PLL manually. So add a clock-id for it. Signed-off-by: Xing Zheng

[PATCH net-next v1] tipc: make sure IPv6 header fits in skb headroom

2016-03-14 Thread Richard Alpe
Expand headroom further in order to be able to fit the larger IPv6 header. Prior to this patch this caused a skb under panic for certain tipc packets when using IPv6 UDP bearer(s). Signed-off-by: Richard Alpe Acked-by: Jon Maloy ---

Re: [PATCH net-next 3/3] net: dsa: refine netdev event notifier

2016-03-14 Thread Ido Schimmel
Sun, Mar 13, 2016 at 10:21:34PM IST, vivien.dide...@savoirfairelinux.com wrote: >Rework the netdev event handler, similar to what the Mellanox Spectrum >driver does, to easily welcome more events later (for example >NETDEV_PRECHANGEUPPER) and use netdev helpers (such as >netif_is_bridge_master). >

[PATCH v6 net-next 02/10] ARM: dts: armada-38x: add buffer manager nodes

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Armada 38x network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its internal SRAM (bm-bppi), which is used for

Re: userns, netns, and quick physical memory consumption by unprivileged user

2016-03-14 Thread Michal Hocko
On Fri 11-03-16 18:06:59, Yuriy M. Kaminskiy wrote: [...] > And also tried with memcg: > t=/sys/fs/cgroup/memory/test1;mkdir $t;echo 0 >$t/tasks; > echo 48M >$t/memory.limit_in_bytes; su testuser [...] > and it has not helped at all (rather opposite, it ended up with killed > init and kernel

pull-request: wireless-drivers-next 2016-03-14

2016-03-14 Thread Kalle Valo
Hi Dave, I know I'm late now that merge window was opened yesterday but here's one more set of patches I would like to get to 4.6 still. There isn't anything controversial so I hope this should be still safe to pull. The patches have been in linux-next since Friday and I haven't seen any reports

[PATCH v6 net-next 05/10] ARM: dts: armada-xp: enable buffer manager support on Armada XP boards

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on AXP-DB and AXP-GP in same manner - because number of ports on those boards is the same as number

[PATCH v6 net-next 03/10] ARM: dts: armada-38x: enable buffer manager support on Armada 38x boards

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Since mvneta driver supports using hardware buffer management (BM), in order to use it, board files have to be adjusted accordingly. This commit enables BM on: * A385-DB-AP - each port has its own pool for long and common pool for short packets, *

[PATCH v6 net-next 04/10] ARM: dts: armada-xp: add buffer manager nodes

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Armada XP network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-xp.dtsi - for the actual common BM unit (bm@c) and its internal SRAM (bm-bppi), which is used for

[PATCH v6 net-next 06/10] ARM: dts: armada-xp-openblocks-ax3-4: Add BM support

2016-03-14 Thread Gregory CLEMENT
Allow Openblock AX3 using hardware buffer management with mvneta. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[PATCH v3 4/9] net: arc: trivial: cleanup the emac driver

2016-03-14 Thread Caesar Wang
This patch will make the driver more readability The emac has the error and warnings if you run 'scripts/checkpatch.pl -f --subjective xxx' to check. Let's clean up such trivial details. Signed-off-by: Caesar Wang Cc: Jiri Kosina Cc: "David S. Miller"

[PATCH v3 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable reparenting on rk3036

2016-03-14 Thread Caesar Wang
From: Heiko Stuebner The emac needs constant and very specific rate but the possible PLL-sources are very limited, so we expect the PLL source to be set manually on per board and don't want it to get changed in an automatic way later. So add the necessary clock-id and disable

[PATCH v3 9/9] ARM: dts: rockchip: add to support emac for rk3036 SoCs

2016-03-14 Thread Caesar Wang
From: Xing Zheng This patch adds the emac device node for rk3036 SoCs. We need to let mac clock under the DPLL which is able to provide the accurate 50MHz what mac_ref need, since that will cause some unstable things if the cpufreq is working. Signed-off-by: Xing Zheng

[PATCH v3 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC clock-id

2016-03-14 Thread Caesar Wang
From: Xing Zheng Associate the new clock id the clock. Signed-off-by: Xing Zheng Signed-off-by: Caesar Wang Cc: Xing Zheng Cc: Michael Turquette Cc: Heiko Stuebner

RE: [net-next,iproute2] netconf: add support for ignore route attribute

2016-03-14 Thread 张胜举
> On Mon, 14 Mar 2016 04:55:36 + > Zhang Shengju wrote: > > > Add support for ignore_routes_with_linkdown attribute. > > > > Signed-off-by: Zhang Shengju > > --- > > ip/ipnetconf.c | 4 > > 1 file changed, 4

[PATCH v6 net-next 08/10] net: mvneta: bm: add support for hardware buffer management

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Buffer manager (BM) is a dedicated hardware unit that can be used by all ethernet ports of Armada XP and 38x SoC's. It allows to offload CPU on RX path by sparing DRAM access on refilling buffer pool, hardware-based filling of descriptor ring data and

[PATCH v6 net-next 09/10] net: add a hardware buffer management helper API

2016-03-14 Thread Gregory CLEMENT
This basic implementation allows to share code between driver using hardware buffer management. As the code is hardware agnostic, there is few helpers, most of the optimization brought by the an HW BM has to be done at driver level. Tested-by: Sebastian Careba

[PATCH v6 net-next 01/10] misc: sram: add optional ioremap without write combining

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas Some SRAM users may require non-bufferable access to the memory, which is impossible, because devm_ioremap_wc() is used for setting sram->virt_base. This commit adds optional flag 'no-memory-wc', which allow to choose remap method, using DT property.

[PATCH v6 net-next 10/10] net: mvneta: Use the new hwbm framework

2016-03-14 Thread Gregory CLEMENT
Now that the hardware buffer management framework had been introduced, let's use it. Tested-by: Sebastian Careba Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 1 + drivers/net/ethernet/marvell/mvneta.c

[PATCH v6 net-next 07/10] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

2016-03-14 Thread Gregory CLEMENT
From: Marcin Wojtas This commit enables finding appropriate mbus window and obtaining its target id and attribute for given physical address in two separate routines, both for IO and DRAM windows. This functionality is needed for Armada XP/38x Network Controller's Buffer

[PATCH v6 net-next 00/10] API set for HW Buffer management

2016-03-14 Thread Gregory CLEMENT
Hi, This is the sixth version of the API set for HW Buffer management (that was initially submitted here: http://thread.gmane.org/gmane.linux.kernel/2125152). This version is just a rebasing onto the last net-next. I also added the Tested-by flag from Sebastian Careba : "The patch set applies

Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

2016-03-14 Thread Gabriel Fernandez
Hi Peppe, Just one remark below > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 6a52fa1..d2322e9 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++

[PATCH iproute2 net-next v5] bridge: mdb: add support for extended router port information

2016-03-14 Thread Nikolay Aleksandrov
Recently a new temp router port mode was added and with it the dumped information was extended similar to how mdb entries were done. This patch adds support to dump the new information by using the "-s" switch. Example: $ bridge -d -s mdb show dev br0 port eth1 grp ff02::1:ffbf:5716 temp 234.39

[PATCH v2 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-14 Thread sunil . kovvuri
From: Sunil Goutham Instead of calling get_page() for every receive buffer carved out of page, set page's usage count at the end, to reduce no of atomic calls. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h |1

[PATCH v2 2/2] net: thunderx: Adjust nicvf structure to reduce cache misses

2016-03-14 Thread sunil . kovvuri
From: Sunil Goutham Adjusted nicvf structure such that all elements used in hot path like napi, xmit e.t.c fall into same cache line. This reduced no of cache misses and resulted in ~2% increase in no of packets handled on a core. Also modified elements with :1 notation to

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-14 Thread Tomeu Vizoso
p with normal descriptors, I let you >>> know >>> >> >> Doesn't the printout "Enhanced/Alternate descriptors" mean that I'm using >> Enhanced/Alternate descriptors? > > > yes this means that you have the Databook 3.70a and, from the HW > ca

[PATCH] netfilter: nf_conntrack: consolidate lock/unlock into unlock_wait

2016-03-14 Thread Nicholas Mc Guire
The spin_lock()/spin_unlock() is synchronizing on the nf_conntrack_locks_all_lock which is equivalent to spin_unlock_wait() but the later should be more efficient. Signed-off-by: Nicholas Mc Guire --- Patch was compile tested with: x86_64_defconfig (implies

Re: Generic TSO

2016-03-14 Thread Edward Cree
On 14/03/16 10:26, Edward Cree wrote: > On 12/03/16 05:40, Alexander Duyck wrote: >> Well that is the thing. Before we can actually start tinkering with >> the outer header we probably need to make sure we set the DF bit and >> that it would be honored on the outer headers for IPv4. I don't >>

Re: Generic TSO

2016-03-14 Thread Edward Cree
On 12/03/16 05:40, Alexander Duyck wrote: > Well that is the thing. Before we can actually start tinkering with > the outer header we probably need to make sure we set the DF bit and > that it would be honored on the outer headers for IPv4. I don't > believe any of the tunnels are currently

Re: [PATCH v6 net-next 09/10] net: add a hardware buffer management helper API

2016-03-14 Thread Jesper Dangaard Brouer
I've not fully understood the hardware support part. But I do think this generalization is very interesting work, and would like to cooperate. If my use-case can fit into this, where my use-case is in the extreme 100Gbit/s area. There is some potential for performance improvements, if the API

[PATCH v2 0/2] net: thunderx: Performance enhancement changes

2016-03-14 Thread sunil . kovvuri
From: Sunil Goutham Below patches attempts to improve performance by reducing no of atomic operations while allocating new receive buffers and reducing cache misses by adjusting nicvf structure elements. Changes from v1: No changes, resubmitting a fresh as per David's

Re: [PATCH 1/2 net v3.16]r8169: Not enable/disable bus mastering when is enabled on BIOS

2016-03-14 Thread Michal Kubecek
On Sun, Mar 13, 2016 at 11:32:48AM +0200, Corcodel Marian wrote: > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 02aec96..ec555e7 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -754,6

[PATCH 1/1] net: Fix use after free in the recvmmsg exit path

2016-03-14 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The syzkaller fuzzer hit the following use-after-free: Call Trace: [] __asan_report_load8_noabort+0x3e/0x40 mm/kasan/report.c:295 [] __sys_recvmmsg+0x6fa/0x7f0 net/socket.c:2261 [< inline >] SYSC_recvmmsg net/socket.c:2281

[PATCH 0/1] recvmmsg use-after-free fix

2016-03-14 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Hi David, Please consider applying, - Arnaldo Arnaldo Carvalho de Melo (1): net: Fix use after free in the recvmmsg exit path net/socket.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-)

[PATCH 3/5] ethtool: introduce new ioctl for per queue setting

2016-03-14 Thread kan . liang
From: Kan Liang Introduce a new ioctl for per queue parameters setting. Users can apply commands to specific queues by setting SUB_COMMAND and queue_mask as following command. ethtool --set-perqueue-command DEVNAME [queue_mask %x] SUB_COMMAND If queue_mask is not set, the

[PATCH 4/5] ethtool: support per queue sub command --show-coalesce

2016-03-14 Thread kan . liang
From: Kan Liang Get all masked queues' coalesce from kernel and dump them one by one. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x11 --show-coalesce Queue: 0 Adaptive RX: off TX: off stats-block-usecs: 0 sample-interval: 0 pkt-rate-low: 0

Re: [PATCH 3/3] net: mediatek: check device_reset return code

2016-03-14 Thread David Miller
From: Arnd Bergmann Date: Mon, 14 Mar 2016 15:07:12 +0100 > The device_reset() function may fail, so we have to check > its return value, e.g. to make deferred probing work correctly. > gcc warns about it because of the warn_unused_result attribute: > >

Re: [PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment

2016-03-14 Thread David Miller
From: Arnd Bergmann Date: Mon, 14 Mar 2016 15:07:11 +0100 > Device drivers should not mess with the DMA mask directly, > but instead call dma_set_mask() etc if needed. > > In case of the mtk_eth_soc driver, the mask already gets set > correctly when the device is created, and

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread roopa
On 3/14/16, 7:51 AM, Jiri Pirko wrote: > Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink > >from the kernel. RTM_NEWLINK also dumps stats today,

Re: [PATCH 1/3] net: mediatek: use dma_addr_t correctly

2016-03-14 Thread John Crispin
On 14/03/2016 15:07, Arnd Bergmann wrote: > dma_alloc_coherent() expects a dma_addr_t pointer as its argument, > not an 'unsigned int', and gcc correctly warns about broken > code in the mtk_init_fq_dma function: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_init_fq_dma': >

Re: [PATCH net-next] rds-tcp: Add module parameters to control sndbuf/rcvbuf size of RDS-TCP socket

2016-03-14 Thread Sowmini Varadhan
In any case, to wrap up this thread. I managed to set this up with sysctl. End result gives me a tunable per netns (which modparam would not), and thanks to the RDS reconnect infra, can be done dynamically at any time, not just at startup. And it is more compact than a daemon-y solution. I'll

[PATCH net-next v6] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-14 Thread Martin KaFai Lau
Per RFC4898, they count segments sent/received containing a positive length data segment (that includes retransmission segments carrying data). Unlike tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments carrying no data (e.g. pure ack). The patch also updates the segs_in in

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

2016-03-14 Thread Cong Wang
On Sun, Mar 13, 2016 at 8:53 PM, David Miller wrote: > > Please stop pretending that this device switching is ok, it's not. +1 This is what I have been complaining about since v1...

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread Saeed Mahameed
On Fri, Mar 11, 2016 at 9:58 PM, Eric Dumazet wrote: >> I totally agree with this, we should have reported skb->truesize += >> (consumed strides)*(stride size). >> but again this is not as critical as you think, in the worst case >> skb->truesize will be off by 127B at

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 10:46 AM, Sowmini Varadhan wrote: > > For LLC based protocols like lldp, stp etc., the ethernet header > is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or > even 0x806. In this world, the skb_network_header() points at > the

[PATCH] ath5k: Change led pin configuration for compaq c700 laptop

2016-03-14 Thread Joseph Salisbury
BugLink: http://bugs.launchpad.net/bugs/972604 Commit 09c9bae26b0d3c9472cb6ae45010460a2cee8b8d ("ath5k: add led pin configuration for compaq c700 laptop") added a pin configuration for the Compaq c700 laptop. However, the polarity of the led pin is reversed. It should be red for wifi off and

Re: [PATCH v2 2/3] of_mdio: use IS_ERR_OR_NULL()

2016-03-14 Thread Sergei Shtylyov
On 03/14/2016 01:22 AM, Arnd Bergmann wrote: IS_ERR_OR_NULL() is open coded in of_mdiobus_register_phy(), so just call it directly... Signed-off-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- Changes in version 2: - removed

Re: [PATCH net] ppp: ensure file->private_data can't be overridden

2016-03-14 Thread Guillaume Nault
On Fri, Mar 11, 2016 at 02:42:16PM -0500, David Miller wrote: > From: Guillaume Nault > Date: Tue, 8 Mar 2016 20:14:30 +0100 > > > Lock ppp_mutex and check that file->private_data is NULL before > > executing any action in ppp_unattached_ioctl(). > > The test done by

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
On (03/14/16 10:55), Alexander Duyck wrote: > > One other thing I forgot to mention is that we don't support ARP so > that check could be dropped. The ATR code only supports IPv4 or IPv6 > with TCP. I did notice that, but I left it in place because (a) it comes down the stack with the

[PATCH] Documentation: networking: phy.txt: Add missing functions

2016-03-14 Thread Florian Fainelli
Some new development in PHYLIB added new function pointers to the struct phy_driver, document these. Signed-off-by: Florian Fainelli --- Documentation/networking/phy.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/networking/phy.txt

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

2016-03-14 Thread Mahesh Bandewar
On Sun, Mar 13, 2016 at 8:53 PM, David Miller wrote: > From: Mahesh Bandewar > Date: Sun, 13 Mar 2016 19:29:58 -0700 > >> On Sun, Mar 13, 2016 at 6:50 PM, David Miller wrote: >>> It doesn't matter whether doing so or not makes sense.

Re: [PATCH net-next] rds-tcp: Add module parameters to control sndbuf/rcvbuf size of RDS-TCP socket

2016-03-14 Thread Tom Herbert
On Fri, Mar 11, 2016 at 8:39 PM, Sowmini Varadhan wrote: > On (03/11/16 20:07), Tom Herbert wrote: > >> You are describing your deployment of RDS, not kernel implementation. >> What I see is a very rigid implementation that would make it hard for >> many us to ever

RE: [PATCH v2 4/4] ethtool: support setting default Rx flow indirection table

2016-03-14 Thread Keller, Jacob E
> -Original Message- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Sunday, March 13, 2016 9:25 AM > To: Keller, Jacob E > Cc: netdev > Subject: Re: [PATCH v2 4/4] ethtool: support setting default Rx flow > indirection table

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

2016-03-14 Thread Cong Wang
On Sun, Mar 13, 2016 at 5:01 PM, Mahesh Bandewar wrote: >>> If I understand correctly (and as Cong already said), information are >>> leaking >>> between netns during the input phase. On the tx side, skb_scrub_packet() is >>> called, but not on the rx side. I think it's wrong.

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread Parav Pandit
>> >> Since SRQ is not supported in this driver version, can you keep >> remaining code base also to not bother about SRQ specifically >> poll_cq_one, modify_qp, destroy_qp etc? >> SRQ support can come as complete additional patch along with cmd_mask, >> callbacks and rest of the code. >> >> . >

Re: [PATCH 1/5] mlx4: add missing braces in verify_qp_parameters

2016-03-14 Thread Leon Romanovsky
On Mon, Mar 14, 2016 at 03:18:34PM +0100, Arnd Bergmann wrote: > The implementation of QP paravirtualization back in linux-3.7 included > some code that looks very dubious, and gcc-6 has grown smart enough > to warn about it: > > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function

Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-03-14 Thread Scott Wood
On 03/14/2016 02:29 AM, Yangbo Lu wrote: >> -Original Message- >> From: Arnd Bergmann [mailto:a...@arndb.de] >> Sent: Monday, March 14, 2016 6:26 AM >> To: linuxppc-...@lists.ozlabs.org >> Cc: Yangbo Lu; devicet...@vger.kernel.org; linux-arm- >> ker...@lists.infradead.org;

[PATCH 5/5] ethtool: support per queue sub command --coalesce

2016-03-14 Thread kan . liang
From: Kan Liang This patch uses a similar way as do_scoalesce to set coalesce per queue. It reads the current settings, change them, and write them back to the kernel for each masked queue. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x1 --coalesce

[PATCH 2/5] ethtool: move cmdline_coalesce out of do_scoalesce

2016-03-14 Thread kan . liang
From: Kan Liang Moving cmdline_coalesce out of do_scoalesce, so it can be shared with other functions. No behavior change. Signed-off-by: Kan Liang --- ethtool.c | 147 +++--- 1 file changed, 74

[PATCH 1/5] ethtool: move option parsing related codes into function

2016-03-14 Thread kan . liang
From: Kan Liang Move option parsing code into find_option function. No behavior changes. Signed-off-by: Kan Liang --- ethtool.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git

  1   2   3   >