Re: [next-queue PATCH 0/3] Add support for GSO partial to Intel NIC drivers

2016-04-09 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 11:59 PM, Jeff Kirsher wrote: > On Fri, 2016-04-08 at 17:06 -0400, Alexander Duyck wrote: >> So these are the patches needed to enable tunnel segmentation >> offloads on >> the igb, igbvf, ixgbe, and ixgbevf drivers. In addition this patch >>

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Xin Long
On Sat, Apr 9, 2016 at 1:16 PM, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: >> sctp_diag will dump some important details of sctp's assoc or ep, we use >> sctp_info to describe them, sctp_get_sctp_info to get them, and export >> it to

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-09 Thread Jesse Gross
On Fri, Apr 8, 2016 at 7:04 PM, Alexander Duyck wrote: > On Fri, Apr 8, 2016 at 2:40 PM, Jesse Gross wrote: >> Maybe I missed it but I didn't see any checks for the DF bit being set >> when we transmit a packet with NETIF_F_TSO_MANGLEID. Even if I am

Re: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra wrote: > Rationale behind this change is that with some OVS configuration > UDP ports doesn't get notified to the driver using > .ndo_[add|del]_vxlan_port. So for the driver to work with > these specific ports in that

Re: [RFC PATCH v2 5/5] Add sample for adding simple drop program to link

2016-04-09 Thread Brenden Blanco
On Sat, Apr 09, 2016 at 10:48:05AM -0400, Jamal Hadi Salim wrote: > On 16-04-08 12:48 AM, Brenden Blanco wrote: > >Add a sample program that only drops packets at the > >BPF_PROG_TYPE_PHYS_DEV hook of a link. With the drop-only program, > >observed single core rate is ~19.5Mpps. > > > >Other tests

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Alexei Starovoitov
On Sat, Apr 09, 2016 at 08:17:04AM -0300, Tom Herbert wrote: > > > > +/* user return codes for PHYS_DEV prog type */ > > +enum bpf_phys_dev_action { > > + BPF_PHYS_DEV_DROP, > > + BPF_PHYS_DEV_OK, > > I don't like OK. Maybe this mean LOCAL. We also need FORWARD (not sure > how to

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Jamal Hadi Salim
On 16-04-09 07:29 AM, Tom Herbert wrote: +1. Forwarding which will be a common application almost always requires modification (decrement TTL), and header data split has always been a weak feature since the device has to have some arbitrary rules about what headers needs to be split out (either

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-09 Thread Xin Long
On Sat, Apr 9, 2016 at 1:51 PM, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: >> This one will implement all the interface of inet_diag, inet_diag_handler. >> which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > > >>

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Xin Long
On Sat, Apr 9, 2016 at 1:19 PM, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: >> sctp_diag will dump some important details of sctp's assoc or ep, we use >> sctp_info to describe them, sctp_get_sctp_info to get them, and export >> it to

Re: [PATCH net-next 3/6] qed/qede: Add VXLAN tunnel slowpath configuration support

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra wrote: > diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c > b/drivers/net/ethernet/qlogic/qede/qede_main.c > index 518af32..9a82d42 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_main.c > +++

Re: [next-queue PATCH 1/3] i40e/i40evf: Add support for GSO partial with UDP_TUNNEL_CSUM and GRE_CSUM

2016-04-09 Thread Jeff Kirsher
On Fri, 2016-04-08 at 17:06 -0400, Alexander Duyck wrote: > This patch makes it so that i40e and i40evf can use GSO_PARTIAL to > support > segmentation for frames with checksums enabled in outer headers.  As > a > result we can now send data over these types of tunnels at over > 20Gb/s > versus

Re: [next-queue PATCH 2/3] ixgbe/ixgbevf: Add support for GSO partial

2016-04-09 Thread Jeff Kirsher
On Fri, 2016-04-08 at 17:06 -0400, Alexander Duyck wrote: > This patch adds support for partial GSO segmentation in the case of > tunnels.  Specifically with this change the driver an perform > segmenation > as long as the frame either has IPv6 inner headers, or we are allowed > to > mangle the IP

[PATCH net-next v2] net: bcmgenet: add BQL support

2016-04-09 Thread Petri Gynther
Add Byte Queue Limits (BQL) support to bcmgenet driver. Signed-off-by: Petri Gynther --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c

[PATCH net-next RFC v2 2/2] ipv6: add support for stats via RTM_GETSTATS

2016-04-09 Thread Roopa Prabhu
From: Roopa Prabhu This patch is an example of adding af stats in RTM_GETSTATS. It adds a new nested IFLA_STATS_INET6 attribute for ipv6 af stats. stats attributes inside IFLA_STATS_INET6 nested attribute use the existing ipv6 stats attributes from ipv6 IFLA_PROTINFO

[PATCH net-next v2 0/2] rtnetlink: new message for stats

2016-04-09 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

[PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-09 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from

[PATCH] qdisc: constify meta_type_ops structures

2016-04-09 Thread Julia Lawall
The meta_type_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- net/sched/em_meta.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/sched/em_meta.c

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-09 Thread Jesper Dangaard Brouer
Hi Eric, On Thu, 07 Apr 2016 08:18:29 -0700 Eric Dumazet wrote: > On Thu, 2016-04-07 at 16:17 +0200, Jesper Dangaard Brouer wrote: > > (Topic proposal for MM-summit) > > > > Network Interface Cards (NIC) drivers, and increasing speeds stress > > the page-allocator (and

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-09 Thread Jamal Hadi Salim
Thanks for doing the work Roopa and I apologize for late comments below: On 16-04-09 02:38 AM, Roopa Prabhu wrote: From: Roopa Prabhu This patch also allows for af family stats (an example af stats for IPV6 is available with the second patch in the series).

Re: [RFC PATCH v2 5/5] Add sample for adding simple drop program to link

2016-04-09 Thread Jamal Hadi Salim
On 16-04-08 12:48 AM, Brenden Blanco wrote: Add a sample program that only drops packets at the BPF_PROG_TYPE_PHYS_DEV hook of a link. With the drop-only program, observed single core rate is ~19.5Mpps. Other tests were run, for instance without the dropcnt increment or without reading from the

[PATCH net-next] ipv6: fix inet6_lookup_listener()

2016-04-09 Thread Eric Dumazet
From: Eric Dumazet A stupid refactoring bug in inet6_lookup_listener() needs to be fixed in order to get proper SO_REUSEPORT behavior. Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt under synflood") Signed-off-by: Eric Dumazet

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Jamal Hadi Salim
On 16-04-09 01:16 AM, Eric Dumazet wrote: Lots of holes in this structure... I may have mentioned to you that there is 8 bit hole in tcp_info too ;-> (above tcpi_rto). Adding an 8 bit explicit pad seems useful since it is already in the wild. I was going to send the patch after netdev11

[PATCH net-next 3/6] qed/qede: Add VXLAN tunnel slowpath configuration support

2016-04-09 Thread Manish Chopra
This patch enables VXLAN tunnel on the adapter and add support for driver hooks to configure UDP ports for VXLAN tunnel offload to be performed by the adapter. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior

[PATCH net-next 2/6] qed: Add infrastructure support for tunneling

2016-04-09 Thread Manish Chopra
This patch adds various structure/APIs needed to configure/enable different tunnel [VXLAN/GRE/GENEVE] parameters on the adapter. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior ---

[PATCH net-next 5/6] qed: Enable GRE tunnel slowpath configuration

2016-04-09 Thread Manish Chopra
Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_main.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH net-next 6/6] qede: Add fastpath support for tunneling

2016-04-09 Thread Manish Chopra
This patch enables netdev tunneling features and adds TX/RX fastpath support for tunneling in driver. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior ---

[PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Manish Chopra
This patch defines default UDP ports for vxlan and geneve in their respective header files to be accessed by the driver. Rationale behind this change is that with some OVS configuration UDP ports doesn't get notified to the driver using .ndo_[add|del]_vxlan_port. So for the driver to work with

[PATCH net-next 0/6] qed/qede: Add tunneling support

2016-04-09 Thread Manish Chopra
Hi David, This patch series adds support for VXLAN, GRE and GENEVE tunnels to be used over this driver. With this support, adapter can perform TSO offload, inner/outer checksums offloads on TX and RX for encapsulated packets. Almost all the changes in this series addresses our driver modules,

[PATCH net-next 4/6] qed/qede: Add GENEVE tunnel slowpath configuration support

2016-04-09 Thread Manish Chopra
This patch configures adapter for GENEVE tunnel offloads to be performed by the adapter. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/Kconfig

Re: [RFC PATCH v2 0/5] Add driver bpf hook for early packet drop

2016-04-09 Thread Jamal Hadi Salim
On 16-04-08 12:47 AM, Brenden Blanco wrote: This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling Express Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Jamal Hadi Salim
Appreciate these patches. Finally some love for sctp. Small comment below: On 16-04-09 12:53 AM, Xin Long wrote: sctp_diag will dump some important details of sctp's assoc or ep, we use sctp_info to describe them, sctp_get_sctp_info to get them, and export it to sctp_diag.ko. Signed-off-by:

[PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

2016-04-09 Thread Amitoj Kaur Chawla
Replace deprecated create_singlethread_workqueue with alloc_ordered_workqueue. Work items include getting tx/rx frame sizes, resetting MPI processor, setting asic recovery bit so ordering seems necessary as only one work item should be in queue/executing at any given time, hence the use of

Re: [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > There are some repetitive codes in forward_delay_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 27 ++- > 1 file changed, 10

[PATCH net-next] vxlan: reduce usage of synchronize_net in ndo_stop

2016-04-09 Thread Hannes Frederic Sowa
We only need to do the synchronize_net dance once for both, ipv4 and ipv6 sockets, thus removing one synchronize_net in case both sockets get dismantled. Signed-off-by: Hannes Frederic Sowa --- Based on patch: [net-next,v2] vxlan: synchronously and race-free

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Tom Herbert
On Fri, Apr 8, 2016 at 6:34 PM, Alexei Starovoitov wrote: > On Fri, Apr 08, 2016 at 10:08:08PM +0200, Jesper Dangaard Brouer wrote: >> On Fri, 8 Apr 2016 10:26:53 -0700 >> Alexei Starovoitov wrote: >> >> > On Fri, Apr 08, 2016 at

Re: [PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > There are some repetitive codes in flush_store, we can remove > them by calling store_bridge_parm, also, it would send rtnl notification > after we add it in store_bridge_parm in the following patches. > > Signed-off-by: Xin Long >

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Jesper Dangaard Brouer
On Sat, 9 Apr 2016 08:17:04 -0300 Tom Herbert wrote: > One other API issue is how to deal with encapsulation. In this case a > header may be prepended to the packet, I assume there are BPF helper > functions and we don't need to return a new length or start? That reminds

Re: [PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change

Re: [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > This patchset is used to support sending rntl info to user in some places, > and ensure that whenever those attributes change internally or from sysfs, > that a netlink notification is sent out to listeners. > > It also make some adjustment in bridge

Hello....!!

2016-04-09 Thread Paul Lukas
PEASE URGENT RESPONSE, I am Dr Paul Lukas,the Audit and Account Manager (A.D.B)Bank in Ouagadougou Burkina Faso,west africa I have a business transaction for you.In my department i discovered an abandoned Sum of US$10.2 Million Dollars.In an account that belongs to one of our late foreign

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Tom Herbert
On Fri, Apr 8, 2016 at 1:48 AM, Brenden Blanco wrote: > Add a new bpf prog type that is intended to run in early stages of the > packet rx path. Only minimal packet metadata will be available, hence a > new context type, struct bpf_phys_dev_md, is exposed to userspace. So >

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-09 Thread Eric Dumazet
On Sat, 2016-04-09 at 11:11 +0200, Jesper Dangaard Brouer wrote: > Hi Eric, > Above code is okay. But do you think we also can get away with the same > trick we do with the SKB refcnf? Where we avoid an atomic operation if > refcnt==1. > > void kfree_skb(struct sk_buff *skb) > { > if

Re: [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +--- > 1 file changed, 9 insertions(+),

Re: [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change

Re: [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if

2016-04-09 Thread Nikolay Aleksandrov
On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Tom Herbert
On Sat, Apr 9, 2016 at 9:27 AM, Jesper Dangaard Brouer wrote: > On Sat, 9 Apr 2016 08:17:04 -0300 > Tom Herbert wrote: > >> One other API issue is how to deal with encapsulation. In this case a >> header may be prepended to the packet, I assume there are

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Eric Dumazet
On Sat, 2016-04-09 at 11:19 -0400, Jamal Hadi Salim wrote: > On 16-04-09 01:16 AM, Eric Dumazet wrote: > > > > > Lots of holes in this structure... > > > > > > > I may have mentioned to you that there is 8 bit hole in tcp_info too ;-> > (above tcpi_rto). Adding an 8 bit explicit pad seems

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Eric Dumazet
On Sun, 2016-04-10 at 00:10 +0800, Xin Long wrote: > 1. sctp_diag_dump_one -> sctp_transport_lookup_process-> sctp_tsp_dump_one > this one just holds the tsp. and we're using list_for_each_safe here now, > isn't it enough ? list_for_each_safe is 'safe' if you do a list_del() yourself. It is

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-09 Thread Alexander Duyck
On Sat, Apr 9, 2016 at 11:02 AM, Eric Dumazet wrote: > On Sat, 2016-04-09 at 10:36 -0700, Alexander Duyck wrote: > >> For next version I plan to include a check in netif_skb_features that >> will clear NETIF_F_TSO_MANGLEID if the DF bit is not set. > > So it looks like we

Re: [RFC PATCH v2 5/5] Add sample for adding simple drop program to link

2016-04-09 Thread Jamal Hadi Salim
On 16-04-09 12:43 PM, Brenden Blanco wrote: On Sat, Apr 09, 2016 at 10:48:05AM -0400, Jamal Hadi Salim wrote: Ok, sorry - should have looked this far before sending earlier email. So when you run concurently you see about 5Mpps per core but if you shoot all traffic at a single core you see

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-09 Thread Alexei Starovoitov
On Sat, Apr 09, 2016 at 11:29:18AM -0400, Jamal Hadi Salim wrote: > On 16-04-09 07:29 AM, Tom Herbert wrote: > > >+1. Forwarding which will be a common application almost always > >requires modification (decrement TTL), and header data split has > >always been a weak feature since the device has

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-09 Thread Eric Dumazet
On Sun, 2016-04-10 at 00:10 +0800, Xin Long wrote: > On Sat, Apr 9, 2016 at 1:19 PM, Eric Dumazet wrote: > > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > >> sctp_diag will dump some important details of sctp's assoc or ep, we use > >> sctp_info to describe them,

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-09 Thread Alexander Duyck
On Sat, Apr 9, 2016 at 8:52 AM, Jesse Gross wrote: > On Fri, Apr 8, 2016 at 7:04 PM, Alexander Duyck > wrote: >> On Fri, Apr 8, 2016 at 2:40 PM, Jesse Gross wrote: >>> Maybe I missed it but I didn't see any checks for the DF bit

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-09 Thread roopa
On 4/9/16, 7:30 AM, Jamal Hadi Salim wrote: > > Thanks for doing the work Roopa and I apologize for late comments > below: > > On 16-04-09 02:38 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> > >> This patch also allows for af family stats (an example af stats for

Re: [PATCH] sh_eth: re-enable-E-MAC interrupts in sh_eth_set_ringparam()

2016-04-09 Thread David Miller
From: Sergei Shtylyov Date: Sun, 10 Apr 2016 02:28:41 +0300 > The E-MAC interrupts are left disabled when the ring parameters are changed > via 'ethtool'. In order to fix this, it's enough to call sh_eth_dev_init() > with 'true' instead of 'false' for the

Re: [PATCH net-next] ipv6: fix inet6_lookup_listener()

2016-04-09 Thread David Miller
From: Eric Dumazet Date: Sat, 09 Apr 2016 08:01:13 -0700 > From: Eric Dumazet > > A stupid refactoring bug in inet6_lookup_listener() needs to be fixed > in order to get proper SO_REUSEPORT behavior. > > Fixes: 3b24d854cb35 ("tcp/dccp: do not touch

我的相册在

2016-04-09 Thread 我的相册在
你的老朋友邀你来Q群:343257759 抢红包 抢秒杀 抢vip 什么都要抢。太刺激了。不靠手气只拼手速

LOAN

2016-04-09 Thread darlehen
Brauchen Sie einen Kredit? Wir bieten Darlehen in 2% gelten heute Kontakt mit uns auf: legacyassetgro...@hotmail.com

Re: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Jesse Gross
On Sat, Apr 9, 2016 at 5:46 PM, Manish Chopra wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Saturday, April 09, 2016 9:36 PM >> To: Manish Chopra >> Cc: David Miller ; netdev

[PATCH] sh_eth: re-enable-E-MAC interrupts in sh_eth_set_ringparam()

2016-04-09 Thread Sergei Shtylyov
The E-MAC interrupts are left disabled when the ring parameters are changed via 'ethtool'. In order to fix this, it's enough to call sh_eth_dev_init() with 'true' instead of 'false' for the second argument (which conveniently allows us to remove the following code re-enabling E-DMAC interrupts and

Re: optimizations to sk_buff handling in rds_tcp_data_ready

2016-04-09 Thread Sowmini Varadhan
On (04/07/16 07:16), Eric Dumazet wrote: > Use skb split like TCP in output path ? > Really, pskb_expand_head() is not supposed to copy payload ;) Question- how come skb_split doesnt have to deal with frag_list and do a skb_walk_frags()? Couldn't the split-line be somewhere in the frag_list? Also

Re: [PATCH net-next] net: bcmgenet: use __napi_schedule_irqoff()

2016-04-09 Thread Petri Gynther
On Fri, Apr 8, 2016 at 10:30 PM, Eric Dumazet wrote: > From: Florian Fainelli > > bcmgenet_isr1() and bcmgenet_isr0() run in hard irq context, > we do not need to block irq again. > > Signed-off-by: Florian Fainelli >

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-09 Thread Eric Dumazet
On Sat, 2016-04-09 at 23:40 +0800, Xin Long wrote: > you meant we can remove it here ? > yes, it seems similar with INET_DIAG_SKMEMINFO. > but I do not know if userpace may use INET_DIAG_MEMINFO now. > You are adding new features here. No problem of legacy code. Anyway, as I said you really

Re: [PATCH net-next] net: bcmgenet: use napi_complete_done()

2016-04-09 Thread Petri Gynther
On Fri, Apr 8, 2016 at 10:06 PM, Eric Dumazet wrote: > From: Eric Dumazet > > By using napi_complete_done(), we allow fine tuning > of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation > efficiency for a Gbit NIC. > > Check commit

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-09 Thread Eric Dumazet
On Sat, 2016-04-09 at 10:36 -0700, Alexander Duyck wrote: > For next version I plan to include a check in netif_skb_features that > will clear NETIF_F_TSO_MANGLEID if the DF bit is not set. So it looks like we slowly but surely make the whole stack damn slow, to support some extra features. How

[PATCH net-next] net: remove netdevice gso_min_segs

2016-04-09 Thread Eric Dumazet
From: Eric Dumazet After introduction of ndo_features_check(), we believe that very specific checks for rare features should not be done in core networking stack. No driver uses gso_min_segs yet, so we revert this feature and save few instructions per tx packet in fast

RE: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports public

2016-04-09 Thread Manish Chopra
> -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Saturday, April 09, 2016 9:36 PM > To: Manish Chopra > Cc: David Miller ; netdev ; > Ariel Elior ; Yuval Mintz

[git pull] sock_recvmsg() redundant argument

2016-04-09 Thread Al Viro
Preparation for a bunch of iov_iter stuff; I'm not sure if all of those should go via net-next (e.g. cifs stuff almost certainly doesn't, etc.), but this bit is common to all those series and it would be better off in your tree. sendmsg counterpart was "get rid of the size argument of