[PATCH net-next] fq_codel: fix memory limitation drift

2016-05-15 Thread Eric Dumazet
From: Eric Dumazet memory_usage must be decreased in dequeue_func(), not in fq_codel_dequeue(), otherwise packets dropped by Codel algo are missing this decrease. Also we need to clear memory_usage in fq_codel_reset() Fixes: 95b58430abe7 ("fq_codel: add memory limitation

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Alexander, On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top

Re: [PATCH net-next] tuntap: introduce tx skb ring

2016-05-15 Thread Eric Dumazet
On Mon, 2016-05-16 at 09:17 +0800, Jason Wang wrote: > We used to queue tx packets in sk_receive_queue, this is less > efficient since it requires spinlocks to synchronize between producer > and consumer. ... > struct tun_struct *detached; > + /* reader lock */ > + spinlock_t

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Thanks for your reviewing. Ethan On 2016/5/13 20:52, Sergei Shtylyov wrote: Hello. On 5/13/2016 8:56 AM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less Performance. CPUs were assigned. especially when DCB is enabled, so we should take

[PATCH net-next] tuntap: introduce tx skb ring

2016-05-15 Thread Jason Wang
We used to queue tx packets in sk_receive_queue, this is less efficient since it requires spinlocks to synchronize between producer and consumer. This patch tries to address this by using circular buffer which allows lockless synchronization. This is done by switching from sk_receive_queue to a

Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi

2016-05-15 Thread Yankejian (Hackim Yim)
On 2016/5/13 21:12, Andy Shevchenko wrote: > On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: >> From: Kejian Yan >> >> Dsaf needs to get configuration parameter by ACPI, so this patch add >> support of ACPI. >> > Looks like at some point better to split driver to

Re: [PATCH net-next] tuntap: introduce tx skb ring

2016-05-15 Thread Michael S. Tsirkin
On Mon, May 16, 2016 at 09:17:01AM +0800, Jason Wang wrote: > We used to queue tx packets in sk_receive_queue, this is less > efficient since it requires spinlocks to synchronize between producer > and consumer. > > This patch tries to address this by using circular buffer which allows > lockless

Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h

2016-05-15 Thread Yankejian (Hackim Yim)
On 2016/5/13 21:15, Andy Shevchenko wrote: > On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: >> From: Hanjun Guo >> >> acpi_match_device_ids() will be used for drivers to match >> different hardware versions, it will be compiled in non-ACPI >> case, but

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-15 Thread Eric Dumazet
On Mon, 2016-05-16 at 01:34 +0300, Roman Yeryomin wrote: > qdisc fq_codel 8003: parent :3 limit 1024p flows 16 quantum 1514 > target 80.0ms ce_threshold 32us interval 100.0ms ecn > Sent 1601271168 bytes 1057706 pkt (dropped 1422304, overlimits 0 requeues 17) > backlog 1541252b 1018p requeues 17

[PATCH 1/2] net: ethernet: gianfar: use phydev from struct net_device

2016-05-15 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH 2/2] net: ethernet: gianfar: use phy_ethtool_{get|set}_link_ksettings

2016-05-15 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 27 + 1 files changed, 2

Re: [PATCH net-next] net: also make sch_handle_egress() drop monitor ready

2016-05-15 Thread Alexei Starovoitov
On Sun, May 15, 2016 at 11:28:29PM +0200, Daniel Borkmann wrote: > Follow-up for 8a3a4c6e7b34 ("net: make sch_handle_ingress() drop > monitor ready") to also make the egress side drop monitor ready. > > Also here only TC_ACT_SHOT is a clear indication that something > went wrong. Hence don't

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-15 Thread Roman Yeryomin
On 16 May 2016 at 02:07, Eric Dumazet wrote: > On Mon, 2016-05-16 at 01:34 +0300, Roman Yeryomin wrote: > >> qdisc fq_codel 8003: parent :3 limit 1024p flows 16 quantum 1514 >> target 80.0ms ce_threshold 32us interval 100.0ms ecn >> Sent 1601271168 bytes 1057706 pkt

Re: [patch net-next 05/11] net: hns: add uniform interface for phy connection

2016-05-15 Thread Yankejian (Hackim Yim)
On 2016/5/13 21:07, Andy Shevchenko wrote: > On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: >> From: Kejian Yan >> >> As device_node is only used by OF case, HNS needs to treat the others >> cases including ACPI. It needs to use uniform ways to handle both of >> OF

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-15 Thread Roman Yeryomin
On 6 May 2016 at 22:43, Dave Taht wrote: > On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin wrote: >> On 6 May 2016 at 21:43, Roman Yeryomin wrote: >>> On 6 May 2016 at 15:47, Jesper Dangaard Brouer wrote:

[PATCH v5 net-next 04/14] ipv6: Change "final" protocol processing for encapsulation

2016-05-15 Thread Tom Herbert
When performing foo-over-UDP, UDP packets are processed by the encapsulation handler which returns another protocol to process. This may result in processing two (or more) protocols in the loop that are marked as INET6_PROTO_FINAL. The actions taken for hitting a final protocol, in particular the

[PATCH v5 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-15 Thread Tom Herbert
Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions for getting encap hlen, setting up encap on a tunnel, performing encapsulation operation. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 58 ++

[PATCH v5 net-next 08/14] fou: Support IPv6 in fou

2016-05-15 Thread Tom Herbert
This patch adds receive path support for IPv6 with fou. - Add address family to fou structure for open sockets. This supports AF_INET and AF_INET6. Lookups for fou ports are performed on both the port number and family. - In fou and gue receive adjust tot_len in IPv4 header or payload_len

[PATCH v5 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-15 Thread Tom Herbert
This patch defines two new GSO definitions SKB_GSO_IPXIP4 and SKB_GSO_IPXIP6 along with corresponding NETIF_F_GSO_IPXIP4 and NETIF_F_GSO_IPXIP6. These are used to described IP in IP tunnel and what the outer protocol is. The inner protocol can be deduced from other GSO types (e.g. SKB_GSO_TCPV4

[PATCH v5 net-next 14/14] ip4ip6: Support for GSO/GRO

2016-05-15 Thread Tom Herbert
Signed-off-by: Tom Herbert --- include/net/inet_common.h | 5 + net/ipv4/af_inet.c| 12 +++- net/ipv6/ip6_offload.c| 33 - net/ipv6/ip6_tunnel.c | 3 +++ 4 files changed, 47 insertions(+), 6 deletions(-) diff

[PATCH v5 net-next 11/14] ip6_gre: Add support for fou/gue encapsulation

2016-05-15 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_gre.c | 77 +++--- 1 file changed, 74 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index

[PATCH v5 net-next 05/14] net: Cleanup encap items in ip_tunnels.h

2016-05-15 Thread Tom Herbert
Consolidate all the ip_tunnel_encap definitions in one spot in the header file. Also, move ip_encap_hlen and ip_tunnel_encap from ip_tunnel.c to ip_tunnels.h so they call be called without a dependency on ip_tunnel module. Similarly, move iptun_encaps to ip_tunnel_core.c. Signed-off-by: Tom

[PATCH v5 net-next 06/14] fou: Call setup_udp_tunnel_sock

2016-05-15 Thread Tom Herbert
Use helper function to set up UDP tunnel related information for a fou socket. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 50 -- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/net/ipv4/fou.c

[PATCH v5 net-next 10/14] fou: Add encap ops for IPv6 tunnels

2016-05-15 Thread Tom Herbert
This patch add a new fou6 module that provides encapsulation operations for IPv6. Signed-off-by: Tom Herbert --- include/net/fou.h | 2 +- net/ipv6/Makefile | 1 + net/ipv6/fou6.c | 140 ++ 3 files changed, 142

[PATCH v5 net-next 07/14] fou: Split out {fou,gue}_build_header

2016-05-15 Thread Tom Herbert
Create __fou_build_header and __gue_build_header. These implement the protocol generic parts of building the fou and gue header. fou_build_header and gue_build_header implement the IPv4 specific functions and call the __*_build_header functions. Signed-off-by: Tom Herbert

[PATCH v5 net-next 00/14] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling

2016-05-15 Thread Tom Herbert
This patch set: - Fixes GRE6 to process translate flags correctly from configuration - Adds support for GSO and GRO for ip6ip6 and ip4ip6 - Add support for FOU and GUE in IPv6 - Support GRE, ip6ip6 and ip4ip6 over FOU/GUE - Fixes ip6_input to deal with UDP encapsulations - Some other

[PATCH v5 net-next 13/14] ip6ip6: Support for GSO/GRO

2016-05-15 Thread Tom Herbert
Signed-off-by: Tom Herbert --- net/ipv6/ip6_offload.c | 24 +--- net/ipv6/ip6_tunnel.c | 3 +++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 787e55f..332d6a0 100644 ---

[PATCH v5 net-next 01/14] gso: Remove arbitrary checks for unsupported GSO

2016-05-15 Thread Tom Herbert
In several gso_segment functions there are checks of gso_type against a seemingly arbitrary list of SKB_GSO_* flags. This seems like an attempt to identify unsupported GSO types, but since the stack is the one that set these GSO types in the first place this seems unnecessary to do. If a

[PATCH v5 net-next 12/14] ip6_tunnel: Add support for fou/gue encapsulation

2016-05-15 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_tunnel.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 9f0ea85..093bdba 100644

[PATCH v5 net-next 03/14] ipv6: Fix nexthdr for reinjection

2016-05-15 Thread Tom Herbert
In ip6_input_finish the nexthdr protocol is retrieved from the next header offset that is returned in the cb of the skb. This method does not work for UDP encapsulation that may not even have a concept of a nexthdr field (e.g. FOU). This patch checks for a final protocol (INET6_PROTO_FINAL) when

From Andreas Christopher (Please read the attached letter and contact me on Tel:+27603505087)

2016-05-15 Thread Andreas Christopher
Compliments of the day.doc Description: MS-Word document

linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

2016-05-15 Thread Stephen Rothwell
Hi Kalle, Today's linux-next merge of the wireless-drivers-next tree got a conflict in: drivers/net/wireless/intel/iwlwifi/mvm/tx.c between commit: 909b27f70643 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") from the net-next tree and commit: a525d0eab17d ("Merge tag

[PATCH net-next] net: also make sch_handle_egress() drop monitor ready

2016-05-15 Thread Daniel Borkmann
Follow-up for 8a3a4c6e7b34 ("net: make sch_handle_ingress() drop monitor ready") to also make the egress side drop monitor ready. Also here only TC_ACT_SHOT is a clear indication that something went wrong. Hence don't provide false positives to drop monitors such as 'perf record -e skb:kfree_skb

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-15 Thread Roman Yeryomin
On 7 May 2016 at 12:57, Kevin Darbyshire-Bryant wrote: > > > On 06/05/16 10:42, Jesper Dangaard Brouer wrote: >> Hi Felix, >> >> This is an important fix for OpenWRT, please read! >> >> OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, >> without

[PATCH 1/2] net: ethernet: ftgmac100: use phydev from struct net_device

2016-05-15 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH 2/2] net: ethernet: ftgmac100: use phy_ethtool_{get|set}_link_ksettings

2016-05-15 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/faraday/ftgmac100.c | 16 ++-- 1 files changed, 2 insertions(+), 14

Re: [PATCH v5 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-15 Thread Jeff Kirsher
On Sun, 2016-05-15 at 16:42 -0700, Tom Herbert wrote: > This patch defines two new GSO definitions SKB_GSO_IPXIP4 and > SKB_GSO_IPXIP6 along with corresponding NETIF_F_GSO_IPXIP4 and > NETIF_F_GSO_IPXIP6. These are used to described IP in IP > tunnel and what the outer protocol is. The inner

Re: [PATCH net-next 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO

2016-05-15 Thread Michael Chan
On Sat, May 14, 2016 at 6:31 PM, Ben Hutchings wrote: > On Sat, 2016-05-14 at 20:29 -0400, Michael Chan wrote: >> From: Ajit Khaparde > [...] >> + /* Read A2 portion of the EEPROM */ >> + if (length) { >> + start -=

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-15 Thread Jiri Pirko
Sun, May 15, 2016 at 06:11:20AM CEST, ro...@cumulusnetworks.com wrote: >On 5/14/16, 11:46 AM, Jiri Pirko wrote: >> Sat, May 14, 2016 at 05:47:41PM CEST, ro...@cumulusnetworks.com wrote: >>> On 5/14/16, 5:49 AM, Jiri Pirko wrote: Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com

[PATCH net-next v2 8/9] bnxt_en: Add BCM57314 device ID.

2016-05-15 Thread Michael Chan
Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 6def145..f2ac7da 100644 ---

[PATCH net-next v2 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO

2016-05-15 Thread Michael Chan
From: Ajit Khaparde Add support to fetch the SFP EEPROM settings from the firmware and display it via the ethtool -m command. We support SFP+ and QSFP modules. v2: Fixed a bug in bnxt_get_module_eeprom() found by Ben Hutchings. Signed-off-by: Ajit Khaparde

[PATCH net-next v2 6/9] bnxt_en: Fix length value in dmesg log firmware error message.

2016-05-15 Thread Michael Chan
The len value in the hwrm error message is wrong. Use the properly adjusted value in the variable len. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v2 5/9] bnxt_en: Improve the delay logic for firmware response.

2016-05-15 Thread Michael Chan
The current code has 2 problems: 1. The maximum wait time is not long enough. It is about 60% of the duration specified by the firmware. It is calling usleep_range(600, 800) for every 1 msec we are supposed to wait. 2. The granularity of the delay is too coarse. Many simple firmware commands

[PATCH net-next v2 3/9] bnxt_en: Report PCIe link speed and width during driver load

2016-05-15 Thread Michael Chan
From: Ajit Khaparde Add code to log a message during driver load indicating PCIe link speed and width. The log message will look like this: bnxt_en :86:00.0 eth0: PCIe: Speed 8.0GT/s Width x8 Signed-off-by: Ajit Khaparde

[PATCH net] net/mlx4_core: Fix access to uninitialized index

2016-05-15 Thread Tariq Toukan
Prevent using uninitialized or negative index when handling steering entries. Fixes: b12d93d63c32 ('mlx4: Add support for promiscuous mode in the new steering model.') Signed-off-by: Tariq Toukan Reported-by: Dan Carpenter ---

Re: [PATCH] ethernet:arc: Fix racing of TX ring buffer

2016-05-15 Thread Francois Romieu
Shuyu Wei : [...] > I don't think taking txbd_curr and txbd_dirty only as hints is a good idea. > That could be a big waste, since tx_clean have to go through all the txbds. Sorry if my point was not clear: arc_emac_tx_clean() does not need to change (at least not for the

[PATCH net-next v2 4/9] bnxt_en: Reduce maximum ring pages if page size is 64K.

2016-05-15 Thread Michael Chan
The chip supports 4K/8K/64K page sizes for the rings and we try to match it to the CPU PAGE_SIZE. The current page size limits for the rings are based on 4K/8K page size. If the page size is 64K, these limits are too large. Reduce them appropriately. Signed-off-by: Michael Chan

[PATCH net-next v2 7/9] bnxt_en: Simplify and improve unsupported SFP+ module reporting.

2016-05-15 Thread Michael Chan
The current code is more complicated than necessary and can only report unsupported SFP+ module if it is plugged in after the device is up. Rename bnxt_port_module_event() to bnxt_get_port_module_status(). We already have the current module_status in the link_info structure, so just check that

[PATCH net-next v2 1/9] bnxt_en: Fix invalid max channel parameter in ethtool -l.

2016-05-15 Thread Michael Chan
From: Satish Baddipadige When there is only 1 MSI-X vector or in INTA mode, tx and rx pre-set max channel parameters are shown incorrectly in ethtool -l. With only 1 vector, bnxt_get_max_rings() will return -ENOMEM. bnxt_get_channels should check this return value, and

[PATCH net-next v2 0/9] bnxt_en: updates for net-next.

2016-05-15 Thread Michael Chan
Non-critical bug fixes, improvements, a new ethtool feature, and a new device ID. v2: Fixed a bug in bnxt_get_module_eeprom() found by Ben Hutchings. Ajit Khaparde (2): bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO bnxt_en: Report PCIe link speed and width during

[PATCH net-next v2 9/9] bnxt_en: Use dma_rmb() instead of rmb().

2016-05-15 Thread Michael Chan
Use the weaker but more appropriate dma_rmb() to order the reading of the completion ring. Suggested-by: Ajit Khaparde Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: What ixgbe devices support HWTSTAMP_FILTER_ALL for hardware time stamping?

2016-05-15 Thread Richard Cochran
On Sat, May 14, 2016 at 07:11:50PM -0700, Guy Harris wrote: > It could do a combination of #2 and #1, where "offers all > possibilities" is replaced by "opens the adapter, tries each of the > possibilities, and offers the ones that don't fail" - but, other > than the current bugs with

[PATCH net] net/mlx4_core: Fix access to uninitialized index

2016-05-15 Thread Tariq Toukan
Prevent using uninitialized or negative index when handling steering entries. Fixes: b12d93d63c32 ('mlx4: Add support for promiscuous mode in the new steering model.') Signed-off-by: Tariq Toukan Reported-by: Dan Carpenter ---

[PATCH net-next 3/5] qed: Reset link on IOV disable

2016-05-15 Thread Yuval Mintz
From: Manish Chopra PF updates its VFs' bulletin boards with link configurations whenever the physical carrier changes or whenever hyper-user explicitly requires some setting of the VFs link via the hypervisor's PF. Since the bulletin board is getting cleaned as part

[PATCH net-next 0/5] qed: IOV enhncements and fixups

2016-05-15 Thread Yuval Mintz
Hi Dave, This is a follow-up on the recent patch series that adds SR-IOV support to qed. All content here is iov-related fixups [nothing terminal] and enhancements. Please consider applying this series to `net-next'. Thanks, Yuval Manish Chopra (1): qed: Reset link on IOV disable Yuval

[PATCH net-next 4/5] qed: Allow more than 16 VFs

2016-05-15 Thread Yuval Mintz
In multi-function modes, PFs are currently limited to using 16 VFs - But that limitation would also currently apply in case there's a single PCI function exposed, where no such restriction should have existed. This lifts the restriction for the default mode; User should be able to start the

[PATCH net-next 2/5] qed: Improve VF interrupt reset

2016-05-15 Thread Yuval Mintz
During FLR flow, need to make sure HW is no longer capable of writing to host memory as part of its interrupt mechanisms. While we're at it, unify the logic cleaning the driver's status-blocks into using a single API function for both PFs and VFs. Signed-off-by: Yuval Mintz

[PATCH net-next 5/5] qed: VFs gracefully accept lack of PM

2016-05-15 Thread Yuval Mintz
VF's probe might log that it has no PM capability in its PCI configuration space. As this is a valid configuration, silence such prints. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next 1/5] qed: Correct PF-sanity check

2016-05-15 Thread Yuval Mintz
Seems like something broke in commit 1408cc1fa48c ("qed: Introduce VFs") and the function no longer verifies that the vf is indeed a valid one. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH] ethernet:arc: Fix racing of TX ring buffer

2016-05-15 Thread Shuyu Wei
On Sun, May 15, 2016 at 11:19:53AM +0200, Francois Romieu wrote: > > static void arc_emac_tx_clean(struct net_device *ndev) > { > [...] > for (i = 0; i < TX_BD_NUM; i++) { > unsigned int *txbd_dirty = >txbd_dirty; > struct arc_emac_bd *txbd =

Re: [PATCH net-next v2 0/9] bnxt_en: updates for net-next.

2016-05-15 Thread David Miller
From: Michael Chan Date: Sun, 15 May 2016 03:04:42 -0400 > Non-critical bug fixes, improvements, a new ethtool feature, and a new > device ID. > > v2: Fixed a bug in bnxt_get_module_eeprom() found by Ben Hutchings. Series applied, thanks.

Re: [net-next 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2016-05-14

2016-05-15 Thread David Miller
From: Jeff Kirsher Date: Sat, 14 May 2016 21:57:22 -0700 > This series contains updates to i40e and i40evf. Pulled, thanks Jeff.

Re: [PATCH] nf_conntrack: avoid kernel pointer value leak in slab name

2016-05-15 Thread Linus Torvalds
On Sat, May 14, 2016 at 2:31 PM, Linus Torvalds wrote: > > "u64" is indeed "unsigned long long" on x86 and many other > architectures, but on alpha and ia64 it's just "unsigned long". Actually, I take that back. In the kernel, it seems to always be "unsigned long

Re: [PATCH] ethernet:arc: Fix racing of TX ring buffer

2016-05-15 Thread Francois Romieu
Shuyu Wei : [...] > I still have a question, is it possible that tx_clean() run > between priv->tx_buff[*txbd_curr].skb = skb and dma_wmb()? A (previous) run can take place after priv->tx_buff[*txbd_curr].skb and before *info = cpu_to_le32(FOR_EMAC | FIRST_OR_LAST_MASK |

Re: r8169: Unconditionally disabling ASPM

2016-05-15 Thread Francois Romieu
Paul Menzel : [...] > As over five years have passed now, do you think that is still needed? > I wonder why no module parameter was added back then, where users could > enable ASPM if it works on their systems? Because there is no such > situation and it always

Re: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-15 Thread David Miller
From: Dexuan Cui Date: Sun, 15 May 2016 09:52:42 -0700 > Changes since v10 > > 1) add module params: send_ring_page, recv_ring_page. They can be used to > enlarge the ringbuffer size to get better performance, e.g., > # modprobe hv_sock recv_ring_page=16 send_ring_page=16

r8169: Unconditionally disabling ASPM

2016-05-15 Thread Paul Menzel
Dear Linux folks, Running the Firmware Test Suite (fwts) [1] on an ASRock E350M1, it suggests that ASPM should be enabled. The module r8169 disables ASPM since the commit below. commit ba04c7c93bbcb48ce880cf75b6e9dffcd79d4c7b Author: Stanislaw Gruszka Date:   Tue Feb 22

BUG: net/ipv4: KASAN: use-after-free in tcp_v4_rcv

2016-05-15 Thread Baozeng Ding
Hi all, I've got the following report use-after-free in tcp_v4_rcv while running syzkaller. Unfortunately no reproducer.The kernel version is 4.6.0-rc2+. === BUG: KASAN: use-after-free in tcp_v4_rcv+0x2144/0x2c20 at addr 8800380279c0

BUG: net/ipv4: KASAN: use-after-free in tcp_sendmsg

2016-05-15 Thread Baozeng Ding
Hi all, I've got the following report use-after-free in tcp_sendmsg (net/ipv4) while running syzkaller. Unfortunately no reproducer.The kernel version is 4.6.0-rc2+. == BUG: KASAN: use-after-free in release_sock+0x4a0/0x510 at

[PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-15 Thread Daniel Borkmann
In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, NULL, 0) to the netlink message nevertheless. This has the side effect that when someone tries a 'tc qdisc replace' and already an existing such qdisc is present, tc

[PATCH] net/hsr: Use setup_timer and mod_timer.

2016-05-15 Thread Muhammad Falak R Wani
The function setup_timer combines the initialization of a timer with the initialization of the timer's function and data fields. The mulitiline code for timer initialization is now replaced with function setup_timer. Also, quoting the mod_timer() function comment: -> mod_timer() is a more

[PATCH 4/4] batman-adv: Fix refcnt leak in batadv_v_neigh_*

2016-05-15 Thread Antonio Quartulli
From: Sven Eckelmann The functions batadv_neigh_ifinfo_get increase the reference counter of the batadv_neigh_ifinfo. These have to be reduced again when the reference is not used anymore to correctly free the objects. Fixes: 9786906022eb ("batman-adv: B.A.T.M.A.N. V -

[PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-15 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH v11 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-05-15 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

pull request [net]: batman-adv 20160515

2016-05-15 Thread Antonio Quartulli
Hello David, although we are extremely late in the release cycle we have 4 fixes which would really be worth merging before releasing linux-4.6. As you can read in the git tag below, each of them can lead to a kernel crash or to an unstable system. We came up with several fixes after having

[PATCH 3/4] batman-adv: Fix double neigh_node_put in batadv_v_ogm_route_update

2016-05-15 Thread Antonio Quartulli
From: Sven Eckelmann The router is put down twice when it was non-NULL and either orig_ifinfo is NULL afterwards or batman-adv receives a packet with the same sequence number. This will end up in a use-after-free when the batadv_neigh_node is removed because the reference

[PATCH 2/4] batman-adv: Avoid nullptr derefence in batadv_v_neigh_is_sob

2016-05-15 Thread Antonio Quartulli
From: Sven Eckelmann batadv_neigh_ifinfo_get can return NULL when it cannot find (even when only temporarily) anymore the neigh_ifinfo in the list neigh->ifinfo_list. This has to be checked to avoid kernel Oopses when the ifinfo is dereferenced. This a situation which isn't

[PATCH 3/5] ethtool: introduce new ioctl for per queue setting

2016-05-15 Thread kan . liang
From: Kan Liang Introduce a new ioctl for per queue parameters setting. Users can apply commands to specific queues by setting SUB_COMMAND and queue_mask as following command. ethtool --set-perqueue-command DEVNAME [queue_mask %x] SUB_COMMAND If queue_mask is not set, the

[PATCH 1/5] ethtool: move option parsing related codes into function

2016-05-15 Thread kan . liang
From: Kan Liang Move option parsing code into find_option function. No behavior changes. Signed-off-by: Kan Liang --- ethtool.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git

[PATCH 2/5] ethtool: move cmdline_coalesce out of do_scoalesce

2016-05-15 Thread kan . liang
From: Kan Liang Moving cmdline_coalesce out of do_scoalesce, so it can be shared with other functions. No behavior change. Signed-off-by: Kan Liang --- ethtool.c | 147 +++--- 1 file changed, 74

[PATCH 4/5] ethtool: support per queue sub command --show-coalesce

2016-05-15 Thread kan . liang
From: Kan Liang Get all masked queues' coalesce from kernel and dump them one by one. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x11 --show-coalesce Queue: 0 Adaptive RX: off TX: off stats-block-usecs: 0 sample-interval: 0 pkt-rate-low: 0

[PATCH 5/5] ethtool: support per queue sub command --coalesce

2016-05-15 Thread kan . liang
From: Kan Liang This patch uses a similar way as do_scoalesce to set coalesce per queue. It reads the current settings, change them, and write them back to the kernel for each masked queue. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x1 --coalesce

[PATCH 1/4] batman-adv: fix skb deref after free

2016-05-15 Thread Antonio Quartulli
From: Florian Westphal batadv_send_skb_to_orig() calls dev_queue_xmit() so we can't use skb->len. Fixes: 953324776d6d ("batman-adv: network coding - buffer unicast packets before forward") Signed-off-by: Florian Westphal Reviewed-by: Sven Eckelmann

BUG: use-after-free in netlink_dump

2016-05-15 Thread Baozeng Ding
Hi all, I've got the following report (use-after-free in netlink_dump) while running syzkaller. Unfortunately no reproducer.The kernel version is 4.6.0-rc2+. == BUG: KASAN: use-after-free in netlink_dump+0x4eb/0xa40 at addr

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-15 Thread Andrew Lunn
> >I think there could be similar code one layer above to handle one gpio > >line for multiple phys. > >Ah, you want me to recognize some MAC/MDIO bound prop (e.g. > "mdio-reset-gpios") in of_mdiobus_register()? I'll think about it > now that my patch needs fixing anyway... Hi Sergi It does

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-15 Thread Andrew Lunn
> I think we don/t understand each other. HW stats always include SW > stats. Because whatever goes in or out goes through HW. Hi Jiri Bit of a corner case, but what about multicast and broadcast? Can you do the replication in the switch, so that only a single copy is sent from the host to the

Re: BUG: net/ipv4: KASAN: use-after-free in tcp_v4_rcv

2016-05-15 Thread Eric Dumazet
On Mon, 2016-05-16 at 00:02 +0800, Baozeng Ding wrote: > Hi all, > I've got the following report use-after-free in tcp_v4_rcv while running > syzkaller. > Unfortunately no reproducer.The kernel version is 4.6.0-rc2+. > > === > BUG: KASAN:

Re: BUG: use-after-free in netlink_dump

2016-05-15 Thread Cong Wang
On Sun, May 15, 2016 at 8:24 AM, Baozeng Ding wrote: > Hi all, > I've got the following report (use-after-free in netlink_dump) while running > syzkaller. > Unfortunately no reproducer.The kernel version is 4.6.0-rc2+. ... > Call Trace: > [< inline >] __dump_stack