Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

Hi Francois, On 19.05.2016 00:55, Francois Romieu wrote: >> The smp_wmb() in tx function combined with the smp_rmb() in tx_clean ensures >> that the CPU running tx_clean sees consistent values for info, data and skb >> (thus no need to check for validity of all three values any more). >> The

[PATCH net-next 2/4] liquidio updates and features

This patch is second in series of patches for liquidio new features and updates: 1) Adds support in Napi to handle tx buffers apart from RX traffic. 2) Resolves the order of chip reset while destroying the resources by postoponing soft reset in destroy resources function until all queues are

låne

Hilsener herr / fru:   Jeg er Justins Morgam, fra private lån selskapet CITY FINANCE, som ligger i Storbritannia. Vi tilbyr alle typer lån til enkeltpersoner og bedrifter, Gjør deg selv økonomisk stabil ved å skaffe et lån fra CITY FINANCE på 3% Rente som kort og Langsiktig lån, firma lån, hus

Re: [PATCH net] udp: prevent skbs lingering in tunnel socket queues

Hi Cong, On Fri, May 20, 2016, at 00:33, Cong Wang wrote: > On Thu, May 19, 2016 at 6:58 AM, Hannes Frederic Sowa > wrote: > > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > > index 2e3ebfe5549ef5..d56c0559b477cb 100644 > > --- a/net/ipv4/udp.c > > +++

Re: rtk8168 driver help needed

On 05/07/2016 04:35 AM, Francois Romieu wrote: > Murali Karicheri : > [...] >> I am trying to integrate the rtl8168 PCIe card to have Ethernet functional >> on my Keystone EVM. > > Which (EVM) one ? > >> I purchased the rtl8111c Gib card from Amazon. The Card is detected >>

Re: [RFC] net: remove busylock

On Thu, May 19, 2016 at 12:35 PM, Eric Dumazet wrote: > On Thu, 2016-05-19 at 11:56 -0700, Eric Dumazet wrote: > >> Removing busylock helped in all cases I tested. (at least on x86 as >> David pointed out) >> >> As I said, we need to revisit busylock now that spinlocks are

[PATCH net-next 4/4] liquidio updates and features

This patch is fourth in series of patches for liquidio updates: This patch adds support for vxlan offload features for liquidio along with ethtool support. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next 3/4] liquidio updates and features

This patch is third in series of patches for liquidio ethtool updates: Add extensive support of statistics for data path, control and firmware. Improved support for interrupt moderation. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

Re: pull-request: wireless-drivers-next 2016-05-13 (take two)

On Thu, May 19, 2016 at 6:45 AM, Kalle Valo wrote: > Hi Dave, > > this the second version of the last pull request to net-next for 4.7, > which got postponed due to the recent iwlwifi merge conflict. Now that > Linus fixed the merge problem in his tree I actually didn't have

Re: [PATCH net] udp: prevent skbs lingering in tunnel socket queues

On Thu, May 19, 2016 at 6:58 AM, Hannes Frederic Sowa wrote: > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index 2e3ebfe5549ef5..d56c0559b477cb 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -1565,7 +1565,7 @@ int udp_queue_rcv_skb(struct sock *sk, struct

Re: [PATCH net-next 1/4] liquidio updates and features

Is this a patch that stands on it's own or is this a combination of all of the other patches? In any event, you need to resubmit this properly and break up the large patches into extremely smaller, logical pieces. You also need to post a proper "[PATCH 0/4] ..." header posting.

Re: [GIT] Networking

On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds wrote: > On Wed, May 18, 2016 at 11:45 AM, Linus Torvalds > wrote: >> >> From what I can tell, there's a merge bug in commit 909b27f70643, >> where David seems to have lost some of the

Re: [PATCH 1/1] iwlwifi: rs: remove superfluous check

On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote: > If we dereference a variable anyway in other parts of the code, > there is no need to check against NULL in a single place. NACK.  This is not true. If lq_sta is NULL, it means that mvm_sta is also NULL.  Then we call the

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, May 19, 2016 at 5:35 AM, Eric Dumazet wrote: > > These stats are using u64 or u32 fields, so reading integral values > should not prevent writers from doing concurrent updates if the kernel > arch is a 64bit one. > > Being able to atomically fetch all counters like

[PATCH net-next 1/2] bpf: support decreasing order in direct packet access

when packet headers are accessed in 'decreasing' order (like TCP port may be fetched before the program reads IP src) the llvm may generate the following code: [...]// R7=pkt(id=0,off=22,r=70) r2 = *(u32 *)(r7 +0) // good access [...] r7 += 40 //

[PATCH net-next 0/2] bpf: verifier fixes

Further testing of 'direct packet access' uncovered several usability issues. Fix them. Alexei Starovoitov (2): bpf: support decreasing order in direct packet access bpf: teach verifier to recognize imm += ptr pattern kernel/bpf/verifier.c | 30 +- 1 file

[PATCH net-next 2/2] bpf: teach verifier to recognize imm += ptr pattern

Humans don't write C code like: u8 *ptr = skb->data; int imm = 4; imm += ptr; but from llvm backend point of view 'imm' and 'ptr' are registers and imm += ptr may be preferred vs ptr += imm depending which register value will be used further in the code, while verifier can only recognize ptr

for stable: vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

Can you queue this 3-commit patch series for stable? 7e059158d57b79159eaf1f504825d19866ef2c42 ("vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices") 55e5bfb53cff286c1c1ff49f51325dc15c7fea63 ("geneve: Relax MTU constraints") 72564b59ffc438ea103b0727a921aaddce766728 ("vxlan: Relax

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, 2016-05-19 at 18:50 -0700, Cong Wang wrote: > On Thu, May 19, 2016 at 5:35 AM, Eric Dumazet wrote: > > > > These stats are using u64 or u32 fields, so reading integral values > > should not prevent writers from doing concurrent updates if the kernel > > arch is a

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

Lino Sanfilippo : [...] > 2. requires a smp_wmb, while 3. requires a rmb(). AFAIK the mb() implies all > we need, > the dma_rmb() for 1., the smp_wmb() for 2. and the rmb() for 3. A revalidation of tx_dirty is still needed (see below) despite the rmb() for 3. The rmb()

Re: rtk8168 driver help needed

Murali Karicheri : [...] > Do you what could be wrong with rtk8168? Hardly. What do the device registers (ethtool -d) and device stats (ethtool -S) look like ? (please trim useless material from previous mail) -- Ueimor

Re: [PATCH net] udp: prevent skbs lingering in tunnel socket queues

On Thu, May 19, 2016 at 3:50 PM, Hannes Frederic Sowa wrote: > Hi Cong, > > On Fri, May 20, 2016, at 00:33, Cong Wang wrote: >> On Thu, May 19, 2016 at 6:58 AM, Hannes Frederic Sowa >> wrote: >> > diff --git a/net/ipv4/udp.c

∝ Hello

welcome to our electronics shop tv,camera,laptop,bike,dj,iphone,samsung product.50% discount for all of our product www. slooone .com

linux-next: build warnings after merge of the net tree

Hi all, After merging the net tree, today's linux-next build (arm multi_v7_defconfig) produced these warnings: drivers/net/usb/pegasus.c: In function 'read_bulk_callback': drivers/net/usb/pegasus.c:475:1: warning: label 'goon' defined but not used [-Wunused-label] goon: ^

Re: [RFC] net: remove busylock

On Thu, 2016-05-19 at 21:49 -0700, John Fastabend wrote: > I plan to start looking at this again in June when I have some > more time FWIW. The last set of RFCs I sent out bypassed both the > qdisc lock and the busy poll lock. I remember thinking this was a > net win at the time but I only did

Re: [RFC] net: remove busylock

On 16-05-19 01:39 PM, Alexander Duyck wrote: > On Thu, May 19, 2016 at 12:35 PM, Eric Dumazet wrote: >> On Thu, 2016-05-19 at 11:56 -0700, Eric Dumazet wrote: >> >>> Removing busylock helped in all cases I tested. (at least on x86 as >>> David pointed out) >>> >>> As I

Re: [PATCH net] fou: avoid using sk_user_data before it is initialised

On Wed, May 18, 2016 at 10:16 AM, Tom Herbert wrote: > On Wed, May 18, 2016 at 10:07 AM, Cong Wang wrote: >> On Wed, May 18, 2016 at 9:30 AM, Tom Herbert wrote: >>> On Wed, May 18, 2016 at 1:30 AM, Simon Horman >>>

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, 2016-05-19 at 22:23 -0700, Cong Wang wrote: > On Thu, May 19, 2016 at 7:45 PM, Eric Dumazet wrote: > > On Thu, 2016-05-19 at 18:50 -0700, Cong Wang wrote: > >> On Thu, May 19, 2016 at 5:35 AM, Eric Dumazet > >> wrote: > >> > > >> > These

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

Hi Jiri, On Tue, May 17, 2016 at 04:32:50PM +0200, Jiri Benc wrote: > Looking through the patchset again, this time more deeply. Sorry for > the delay. No need to be sorry, good things take time. > On Wed, 4 May 2016 16:36:30 +0900, Simon Horman wrote: > > +struct ovs_action_push_eth { > > +

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

Giuseppe, Alexandre, et al., On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier wrote: > On Thu, 17 Mar 2016 00:56:40 +0100 > Bert Lindner wrote: >> On 2016-03-16 18:42, Marc Zyngier wrote: >> > On 16/03/16 15:10, Bert Lindner wrote: >> >> On 2016-03-16 14:10,

[PATCH net v2] fou: avoid using sk_user_data before it is initialised

During initialisation sk->sk_user_data should not be used before it is initialised. Found by bisection after noticing the following: $ ip fou add port ipproto 47 [0.383417] BUG: unable to handle kernel NULL pointer dereference at 0008 [0.384132] IP: []

[PATCH] net: alx: use custom skb allocator

This patch follows Eric Dumazet's commit 7b70176421 to fix one exactly same bug in alx driver, that the network link will be lost in 1-5 minutes after the device is up. Following is a git log from Eric's 7b70176421: "We had reports ( https://bugzilla.kernel.org/show_bug.cgi?id=54021 ) that using

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

On Thu, May 19, 2016 at 9:38 AM, Cong Wang wrote: > On Thu, May 19, 2016 at 5:15 AM, Jamal Hadi Salim wrote: >> On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: >>> >>> On 16-05-18 01:17 PM, Cong Wang wrote: >> >> I think it is the time to add a

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, May 19, 2016 at 7:45 PM, Eric Dumazet wrote: > On Thu, 2016-05-19 at 18:50 -0700, Cong Wang wrote: >> On Thu, May 19, 2016 at 5:35 AM, Eric Dumazet wrote: >> > >> > These stats are using u64 or u32 fields, so reading integral values >> >

Re: [PATCH net] fou: avoid using sk_user_data before it is initialised

On Thu, May 19, 2016 at 10:17:40PM -0700, Cong Wang wrote: > On Wed, May 18, 2016 at 10:16 AM, Tom Herbert wrote: > > On Wed, May 18, 2016 at 10:07 AM, Cong Wang > > wrote: > >> On Wed, May 18, 2016 at 9:30 AM, Tom Herbert

Re: linux-next: build warnings after merge of the net tree

From: Stephen Rothwell Date: Fri, 20 May 2016 13:33:30 +1000 > After merging the net tree, today's linux-next build (arm > multi_v7_defconfig) produced these warnings: ... > Introduced by commit > > e00be9e4d0ff ("net: pegasus: remove dead coding") This change has

[PATCH 4.8 2/2] brcmfmac: support get_channel cfg80211 callback

This is important for brcmfmac as the firmware may pick different channel than requested. This has been tested with BCM4366B1 (in D-Link DIR-885L). Signed-off-by: Rafał Miłecki --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 59 ++ 1 file changed,

Re: [GIT] Networking

On Thu, May 19, 2016 at 2:20 AM, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds > wrote: >> On Wed, May 18, 2016 at 11:45 AM, Linus Torvalds >> wrote: >>> >>> From what I can

Re: [GIT] Networking

On 5/19/16, Reinoud Koornstra wrote: > On Thu, May 19, 2016 at 2:20 AM, Reinoud Koornstra > wrote: >> On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds >> wrote: >>> On Wed, May 18, 2016 at 11:45 AM, Linus

RE: [PATCH 1/1] net: hns: avoid null pointer dereference

From: Heinrich Schuchardt > Sent: 17 May 2016 21:01 > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 8

Re: [PATCH net V2] tuntap: correctly wake up process during uninit

On Thu, May 19, 2016 at 01:36:51PM +0800, Jason Wang wrote: > We used to check dev->reg_state against NETREG_REGISTERED after each > time we are woke up. But after commit 9e641bdcfa4e ("net-tun: > restructure tun_do_read for better sleep/wakeup efficiency"), it uses > skb_recv_datagram() which

[PATCH net,stable v2] net: cdc_ncm: update datagram size after changing mtu

From: Rafal Redzimski Current implementation updates the mtu size and notify cdc_ncm device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram size change instead of changing rx_urb_size. Whenever mtu is being changed, datagram size should also be updated.

Re: [PATCH net-next] tuntap: introduce tx skb ring

On Wed, 18 May 2016 19:26:38 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 18, 2016 at 10:13:59AM +0200, Jesper Dangaard Brouer wrote: > > I agree. It is sad to see everybody is implementing the same thing, > > open coding an array/circular based ring buffer. This kind of

[PATCH 3.12 70/76] VSOCK: do not disconnect socket when peer has shutdown SEND only

From: Ian Campbell 3.12-stable review patch. If anyone has any objections, please let me know. === [ Upstream commit dedc58e067d8c379a15a8a183c5db318201295bb ] The peer may be expecting a reply having sent a request and then done a shutdown(SHUT_WR), so

[PATCH 3.12 30/76] cpuset: Fix potential deadlock w/ set_mems_allowed

From: John Stultz 3.12-stable review patch. If anyone has any objections, please let me know. === commit db751fe3ea6880ff5ac5abe60cb7b80deb5a4140 upstream. After adding lockdep support to seqlock/seqcount structures, I started seeing the following warning:

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 9:03 GMT+02:00 John Crispin : > On 19/05/2016 08:57, Alexander Stein wrote: >> Thanks for the link, I wasn't aware of that patch. I like it in general, but >> there are some things I'd like to get addressed first: >> * vr9_gphy_of_reg_init() writes uncoditionally to

[PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

Our d11 code supports encoding/decoding channel info into/from chanspec format used by firmware. Current implementation is quite misleading because of the way "chnum" field is used. When encoding channel info, "chnum" has to be filled by a caller with *center* channel number. However when decoding

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > 2016-05-19 9:03 GMT+02:00 John Crispin : > > On 19/05/2016 08:57, Alexander Stein wrote: > >> Thanks for the link, I wasn't aware of that patch. I like it in general, > >> but there are some things I'd like to get

Re: [PATCH net V2] tuntap: correctly wake up process during uninit

On Thu, 2016-05-19 at 13:36 +0800, Jason Wang wrote: > We used to check dev->reg_state against NETREG_REGISTERED after each > time we are woke up. But after commit 9e641bdcfa4e ("net-tun: > restructure tun_do_read for better sleep/wakeup efficiency"), it uses > skb_recv_datagram() which does not

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

On Thu, 2016-05-19 at 08:06 -0600, David Ahern wrote: > On 5/18/16 10:12 PM, Eric Dumazet wrote: > > On Wed, 2016-05-18 at 22:05 -0600, David Ahern wrote: > > > >> You think it is ok to send a request to the kernel, the kernel says "I > >> can't do it" and the command says nothing to the user?

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

On Thu, May 19, 2016 at 11:06 PM, David Ahern wrote: > got it. Google does not care about users; don't un-suppress failures. The users I was trying to care about are the ones that have correctly configured kernels. It did not seem useful to those users to litter the

Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

On 05/19/2016 06:11 AM, Sergei Shtylyov wrote: Hello. On 5/18/2016 7:05 PM, Fabio Estevam wrote: Commit da47b4572056 ("phy: add support for a reset-gpio specification") causes the following xtensa qemu crash according to Guenter Roeck: [9.366256] libphy: ethoc-mdio: probed [9.367389]

[PATCH v4] skb_array: array based FIFO for skbs

A simple array based FIFO of pointers. Intended for net stack so uses skbs for type safety, but we can replace with with void * if others find it useful outside of net stack. Signed-off-by: Michael S. Tsirkin --- Still untested. Posting since several people expressed interest

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

On 16-05-18 01:17 PM, Cong Wang wrote: On Tue, May 17, 2016 at 4:38 PM, Jamal Hadi Salim wrote: diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c index 014f9a6..f581e01 100644 --- a/net/sched/act_bpf.c +++ b/net/sched/act_bpf.c @@ -156,6 +156,7 @@ static int

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

Hello. On 5/15/2016 6:23 PM, Andrew Lunn wrote: I think there could be similar code one layer above to handle one gpio line for multiple phys. Ah, you want me to recognize some MAC/MDIO bound prop (e.g. "mdio-reset-gpios") in of_mdiobus_register()? I'll think about it now that my patch

[PATCH] net: usb: ch9200: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/net/usb/ch9200.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

On 5/18/16 10:12 PM, Eric Dumazet wrote: On Wed, 2016-05-18 at 22:05 -0600, David Ahern wrote: You think it is ok to send a request to the kernel, the kernel says "I can't do it" and the command says nothing to the user? That is current behavior. How on Earth is that acceptable? I don't

[PATCH net] udp: prevent skbs lingering in tunnel socket queues

In case we find a socket with encapsulation enabled we should call the encap_recv function even if just a udp header without payload is available. The callbacks are responsible for correctly verifying and dropping the packets. Also, in case the header validation fails for geneve and vxlan we

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: On 16-05-18 01:17 PM, Cong Wang wrote: I think it is the time to add a wrapper for these tm.XX = jiffies_to_clock_t(XXX). Agreed. Will send a patch. Actually I will resend the firstuse as well without RFC tag and the wrapper one as separate

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

> To be honest I don't know how the PHY LEDs could be set by LED triggers. > Wouldn't that require to create triggers for each value which can be written > to LEDxH and LEDxL? In my case the hardware requires some specific setting > due > to LED connections. Supporting all possibilities is

[PATCH v2] skb_array: array based FIFO for skbs

A simple array based FIFO of pointers. Intended for net stack so uses skbs for type safety, but we can replace with with void * if others find it useful outside of net stack. Signed-off-by: Michael S. Tsirkin --- Still untested, fixed the bug pointed out by Eric. Posting since

pull-request: wireless-drivers-next 2016-05-13 (take two)

Hi Dave, this the second version of the last pull request to net-next for 4.7, which got postponed due to the recent iwlwifi merge conflict. Now that Linus fixed the merge problem in his tree I actually didn't have to fix anything in my tree anymore. So that's why I still use the same tag as in

Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

Hello. On 5/18/2016 7:05 PM, Fabio Estevam wrote: Commit da47b4572056 ("phy: add support for a reset-gpio specification") causes the following xtensa qemu crash according to Guenter Roeck: [9.366256] libphy: ethoc-mdio: probed [9.367389] (null): could not attach to PHY [9.368555]

[PATCH] ps3_gelic: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 4 ++-- 1 file

[PATCH] brcmfmac: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +-- 1

[RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

From: Eric Dumazet Large tc dumps (tc -s {qdisc|class} sh dev ethX) done by Google BwE host agent [1] are problematic at scale : For each qdisc/class found in the dump, we currently lock the root qdisc spinlock in order to get stats. Sampling stats every 5 seconds from

Re: [PATCH] iwlegacy: avoid warning about missing braces

On Thu, May 19, 2016 at 09:58:49AM +0200, Arnd Bergmann wrote: > gcc-6 warns about code in il3945_hw_txq_ctx_free() being > somewhat ambiguous: > > drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit > braces to avoid ambiguous 'else' [-Wparentheses] > > This adds a set

Re: [PATCH v2] skb_array: array based FIFO for skbs

On Thu, 2016-05-19 at 15:15 +0300, Michael S. Tsirkin wrote: > A simple array based FIFO of pointers. Intended for net stack so uses > skbs for type safety, but we can replace with with void * if others find > it useful outside of net stack. > > Signed-off-by: Michael S. Tsirkin

Re: [PATCH] net: suppress warnings on dev_alloc_skb

On Wed, May 18, 2016 at 02:47:05PM -0700, Eric Dumazet wrote: > On Wed, 2016-05-18 at 17:09 -0400, Neil Horman wrote: > > > Oh, my bad, I misread what he was saying. Yeah, thats the way to go. > > Please submit a v2 ;) > > Thanks > Will do shortly :) Neil > > >

[PATCH] net:liquidio: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +--- 1 file

sfc MC errors when using accelerated RFS

After a couple weeks of uptime under moderate accelerated RFS load (mostly long-lived flows), I start getting errors like this: sfc :05:00.1 p3p2: MC command 0x8a inlen 108 failed rc=-28 (raw=28) arg=2 I've seem problems like this for a long time, and they're currently happening on a stock

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, May 19, 2016 at 05:35:20AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Large tc dumps (tc -s {qdisc|class} sh dev ethX) done by Google BwE host > agent [1] are problematic at scale : > > For each qdisc/class found in the dump, we currently lock the root

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > Noticed an allocation failure in a network driver the other day on a 32 bit > system: Presumably driver could fall back to HIGH memory allocation for the page frag.

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On 17/05/2016 at 17:35:30 -0600, David Mosberger wrote : > At 7.96 seconds, phy_start() gets called, but even though this enters > state PHY_UP, it does not trigger phy_state_machine() and therefore > doesn't trigger autonegotiation. I'm not quite sure how this is > intended to be handled

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

On Thu, May 19, 2016 at 5:15 AM, Jamal Hadi Salim wrote: > On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: >> >> On 16-05-18 01:17 PM, Cong Wang wrote: > > >>> I think it is the time to add a wrapper for these tm.XX = >>> jiffies_to_clock_t(XXX). >>> >> >> Agreed. Will send a

[PATCH net] uapi glibc compat: fix compilation when !__USE_MISC in glibc

These structures are defined only if __USE_MISC is set in glibc net/if.h headers, ie when _BSD_SOURCE or _SVID_SOURCE are defined. CC: Jan Engelhardt CC: Josh Boyer CC: Stephen Hemminger CC: Waldemar Brodkorb

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > Noticed an allocation failure in a network driver the other day on a 32 bit > system: > Signed-off-by: Neil Horman > CC: "David S. Miller" > CC: Eric Dumazet > CC:

[PATCHv2] net: suppress warnings on dev_alloc_skb

Noticed an allocation failure in a network driver the other day on a 32 bit system: DMA-API: debugging out of memory - disabling bnx2fc: adapter_lookup: hba NULL lldpad: page allocation failure. order:0, mode:0x4120 Pid: 4556, comm: lldpad Not tainted 2.6.32-639.el6.i686.debug #1 Call Trace: []

[PATCH net-next] tools: hv: Add a script for bonding synthetic and VF NICs

This example script creates bonding network devices based on synthetic NIC (the virtual network adapter usually provided by Hyper-V) and the matching VF NIC (SRIOV virtual function). So the synthetic NIC and VF NIC can function as one network device, and fail over to the synthetic NIC if VF is

[RFC] net: remove busylock

busylock was added at the time we had expensive ticket spinlocks (commit 79640a4ca6955e3ebdb7038508fa7a0cd7fa5527 ("net: add additional lock to qdisc to increase throughput") Now kernel spinlocks are MCS, this busylock things is no longer relevant. It is slowing down things a bit. With HTB

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

On Thu, 2016-05-19 at 13:34 -0400, Neil Horman wrote: > On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > > Noticed an allocation failure in a network driver the other day on a 32 > > > bit > > > system: > > > > Presumably

[PATCH iproute2] ipaddress: needs to include

It's using MIN() now, otherwise it breaks for musl libc. Signed-off-by: Gustavo Zacarias --- ip/ipaddress.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 0692fba..df363b0 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@

Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

Hello. On 05/19/2016 04:29 PM, Guenter Roeck wrote: Commit da47b4572056 ("phy: add support for a reset-gpio specification") causes the following xtensa qemu crash according to Guenter Roeck: [9.366256] libphy: ethoc-mdio: probed [9.367389] (null): could not attach to PHY [

Re: mlx5 core/en oops in 4.6-rc6+

Hi Doug, Attaching here a response from Ophir Maor (from Mellanox community) > > Read your own guides ;-). > > I'm using this one for your switches: > https://community.mellanox.com/docs/DOC-1417 > > And these to try and get the linux machines configured properly: >

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On Thu, May 19, 2016 at 10:31 AM, Alexandre Belloni wrote: > On 17/05/2016 at 17:35:30 -0600, David Mosberger wrote : >> At 7.96 seconds, phy_start() gets called, but even though this enters >> state PHY_UP, it does not trigger phy_state_machine() and

Re: [RFC net-next] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

On Thu, 2016-05-19 at 09:08 -0700, Alexei Starovoitov wrote: > initially I thought that above line could have been qdisc_root_sleeping_lock() > but then realized that moving out ASSERT_RTNL makes more sense. Good call. > The only thing not clear to me is why '!defined(CONFIG_LOCKDEP)' ? > Just

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > Noticed an allocation failure in a network driver the other day on a 32 bit > > system: > > Presumably driver could fall back to HIGH memory allocation for the page > frag. >

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

On Thu, May 19, 2016 at 10:39:50AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-19 at 13:34 -0400, Neil Horman wrote: > > On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > > > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > > > Noticed an allocation failure in a network

Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

On Thu, May 19, 2016 at 08:11:22PM +0300, Sergei Shtylyov wrote: > Hello. > > On 05/19/2016 04:29 PM, Guenter Roeck wrote: > > >>>Commit da47b4572056 ("phy: add support for a reset-gpio specification") > >>>causes the following xtensa qemu crash according to Guenter Roeck: > >>> > >>>[

Re: [PATCH 1/1] net: ehea: avoid null pointer dereference

From: Heinrich Schuchardt Date: Tue, 17 May 2016 22:28:54 +0200 > ehea_get_port may return NULL. Do not dereference NULL value. > > Fixes: 8c4877a4128e ("ehea: Use the standard logging functions") > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference

From: Heinrich Schuchardt Date: Tue, 17 May 2016 21:40:38 +0200 > In function bgx_lmac_handler only use a member of > lmac after checking it is not null. > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: i40e: avoid null pointer dereference

From: Heinrich Schuchardt Date: Tue, 17 May 2016 22:41:33 +0200 > In function i40e_debug_aq parameter desc is assumed to be > possibly NULL. Do not dereference it before checking the > value. > > Fixes: f905dd62be88 ("i40e/i40evf: add max buf len to aq debug print helper") >

Re: [PATCH 1/1] net: rsi: eliminate superfluous NULL check

From: Heinrich Schuchardt Date: Wed, 18 May 2016 00:30:41 +0200 > msg is dereferenced before checking against NULL, e.g. > when assigning pad_bytes. > Remove the superfluous check in function rsi_mgmt_pkt_to_core. > > Signed-off-by: Heinrich Schuchardt

Re: [PATCH net-next 0/2] tcp: add NV congestion control

From: Lawrence Brakmo Date: Tue, 17 May 2016 18:25:34 -0700 > This patchset adds support for NV congestion control. > > This version of NV does much better than previous versions when things are > very congested. > > Tested in a rack using between 1 and 380 active TCP-NV flows.

Re: [PATCH v2] net: Fix coding style warnings and errors.

From: Amit Ghadge Date: Wed, 18 May 2016 06:46:30 +0530 > This is a patch to clean checkpatch warnings and errors > in the Space.c file. > Clean up the following warnings and errors. > > WARNING : > * Block comments use * on subsequent lines > * Missing a blank line after

Re: pull request: batman-adv 20160518

From: Antonio Quartulli Date: Wed, 18 May 2016 13:04:44 +0800 > these are the fixes that couldn't make it for linux-4.6 rebased on top > of net-next. > > They were all supposed to be applied on 4.6, therefore it would be nice > if you could queue them for inclusion in the

Re: [PATCH] net: au1000 eth: simplify logical expression

From: Heinrich Schuchardt Date: Wed, 18 May 2016 01:58:45 +0200 > (a && a > 0) is equivalent to (a > 0). > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: ieee802154/adf7242: syntax error ifdef DEBUG

From: Heinrich Schuchardt Date: Tue, 17 May 2016 23:58:40 +0200 > If DEBUG is defined, a superfluous closing brace > is introduced. > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: irda: avoid null pointer dereference

From: Heinrich Schuchardt Date: Wed, 18 May 2016 00:06:02 +0200 > Only dereference variable self after checking it is not NULL. > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH net-next 0/4] net: block BH in TCP callbacks

From: Eric Dumazet Date: Tue, 17 May 2016 17:44:05 -0700 > Four layers using TCP stack were assuming sk_callback_lock could > be locked using read_lock() in their handlers because TCP stack > was running with BH disabled. > > This is no longer the case. Since presumably the

  1   2   >