Re: [PATCH net-next] bridge: Synchronize unicast filtering with FDB

2016-06-03 Thread Nikolay Aleksandrov
> On Jun 3, 2016, at 11:33 AM, Toshiaki Makita > wrote: > > Patrick Schaaf reported that flooding due to a missing fdb entry of > the address of macvlan on the bridge device caused high CPU > consumption of an openvpn process behind a tap bridge port. > Adding an

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Neal Cardwell
On Fri, Jun 3, 2016 at 11:13 AM, Eric Dumazet wrote: > I have no strict opinion on this. > > It seems to me that checking at most 4 right edges (at least in current > linux implementation) is not adding a huge risk, and allows for better > interoperability. > > I vote for

[PATCH net-next 09/17] net: dsa: Split up creating/destroying of DSA and CPU ports

2016-06-03 Thread Andrew Lunn
Refactor the code to setup a single DSA/CPU port into a function of its own, and export it, so it can be used by the new binding. Similarly, refactor the destroy code into a function. When destroying the ports, don't put the of node. They should be released at the end along with the normal

Re: [PATCH net-next 01/17] net: dsa: slave: chip data is optional, don't dereference NULL

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The new binding does not make use of dsa_chip_data, a.k.a cd. When > retrieving the size of the EEPROM attached to a switch, don't assume > there is a cd attached to the switch structure. > > Signed-off-by: Andrew Lunn Reviewed-by:

Re: [PATCH net-next 03/17] net: dsa: slave: Remove MDIO address from switch MDIO bus name

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The DSA layer should no longer assume the switch is connected to an > MDIO bus. As a result, we cannot use the address on the MDIO bus when > forming the name of the switches internal MDIO bus for its builtin and > possibly external PHYs. The switch

Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-03 Thread Oliver Hartkopp
On 06/03/2016 07:03 PM, Ulrich Hecht wrote: Thanks; I missed that every register is described twice. Nevertheless, names often vary more or less subtly between your patch and the specs, making it very hard to review. Some have letters added, some have letters removed, and some are just plain

[PATCH net-next 03/15] smc: establish pnet table management

2016-06-03 Thread Ursula Braun
From: Thomas Richter Connection creation with SMC-R starts through an internal TCP-connection. The Ethernet interface for this TCP-connection is not restricted to the Ethernet interface of a RoCE device. Any existing Ethernet interface belonging to the same physical

[PATCH net-next 14/15] smc: socket closing and linkgroup cleanup

2016-06-03 Thread Ursula Braun
smc_shutdown() and smc_release() handling delayed linkgroup cleanup for linkgroups without connections Signed-off-by: Ursula Braun --- net/smc/Makefile| 2 +- net/smc/af_smc.c| 102 ++-- net/smc/smc.h | 20 ++- net/smc/smc_cdc.c | 33 ++--

[PATCH v3 4/7] dt:mdio-mux: Add mdio multiplexer driver node

2016-06-03 Thread Pramod Kumar
Add integrated MDIO multiplexer driver node which contains two mux PCIe bus and one ethernet bus along with phys lying on these bus. Signed-off-by: Pramod Kumar --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 arch/arm64/boot/dts/broadcom/ns2.dtsi|

[PATCH net-next 02/15] smc: establish new socket family

2016-06-03 Thread Ursula Braun
* enable smc module loading and unloading * register new socket family * basic smc socket creation and deletion * use backing TCP socket to run CLC (Connection Layer Control) handshake of SMC protocol * Setup for infiniband traffic is implemented in follow-on patches. For now fallback

[PATCH net-next 15/15] smc: proc-fs interface for smc connections

2016-06-03 Thread Ursula Braun
Maintain a list of SMC sockets and display important SMC socket information in /proc/net/smc. Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 14 +++ net/smc/smc.h | 1 + net/smc/smc_proc.c | 251

[PATCH net-next 12/17] net: dsa: Make mdio bus optional

2016-06-03 Thread Andrew Lunn
The switch may want to instantiate its own MDIO bus. Only do it centrally if the switch has not already created one, and the read op is implemented. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-)

[PATCH net-next 11/17] net: dsa: Refactor selection of tag ops into a function

2016-06-03 Thread Andrew Lunn
Replace the two switch statements with an array lookup, and store the result in the dsa tree structure. The drivers no longer need to know the selected tag protocol, so remove it from the dsa switch structure. Signed-off-by: Andrew Lunn --- rfc->v1: Rename _DSA_TAG_LAST to

[PATCH net-next 2/2] bgmac: Add support for ethtool statistics

2016-06-03 Thread Florian Fainelli
Read the statistics from the BGMAC's builtin MAC and return them to user-space using the standard ethtool helpers. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.c | 125 ++ drivers/net/ethernet/broadcom/bgmac.h |

[PATCH net-next 1/2] bgmac: Bind net_device with backing device structure

2016-06-03 Thread Florian Fainelli
In preparation for allowing different helpers to be utilized against network devices created by the bgmac driver, make sure that we bind the net_device with core->dev. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bgmac.c | 1 + 1 file changed, 1

[PATCH net-next 0/2] net: bgmac: Misc improvements

2016-06-03 Thread Florian Fainelli
Hi David, Rafal, Hauke, Felix, This patch series add minor changes to the bgmac driver: - properly bind net_device with its backing device structure such that we can locate the device using common helper functions - add support for ethtool statistics reading the HW MIB counters which is

Re: [PATCH v3 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer

2016-06-03 Thread Andrew Lunn
> +Properties for an MDIO bus mutiplexer found in Broadcom iProc based SoCs. > + > +This MDIO bus multiplexer defines buses that could be internal as well as > +external to SoCs and could accept MDIO transaction compatible to C-22 or > +C-45 Clause. When child bus is selected, one needs to select

[PATCH v2 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

2016-06-03 Thread Lucas Stach
Add the DT property to all boards that have the hardware workaround for erratum ERR006687 present. This allows the CPUidle driver to use the deep idle states, even if the FEC is active. Signed-off-by: Lucas Stach --- v2: Spell out "workaround" to avoid confusion. ---

[PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

2016-06-03 Thread Lucas Stach
The i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from waking the CPUs when they are in wait(unclocked) state. As the hardware workaround isn't applicable to all boards, disable the deeper idle state when the workaround isn't present and the FEC is in use. This allows to safely run

[PATCH net-next 13/17] net: dsa: mv88e6xxx: Rename _phy_ to _mdio_

2016-06-03 Thread Andrew Lunn
The switch implements a generic MDIO bus, which could host more than PHYs. It is conventional to use _mdio_ or _mii_ in the function name, so rename them. Also postfix make the historically first read/write function with _direct, to help distinguish it from _indirect and _ppu. While touching

[PATCH net-next 17/17] net: dsa: Document new binding

2016-06-03 Thread Andrew Lunn
Add the new binding to the documentation of the existing binding. Mark the old binding as deprecated. Signed-off-by: Andrew Lunn Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 278 +- 1 file

Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-03 Thread Ulrich Hecht
On Fri, Jun 3, 2016 at 8:42 AM, Ramesh Shanmugasundaram wrote: > Hi Uli, > > Thanks for the review > >> Thank you for your patch. >> >> On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram >> wrote: >> [...] >> >

[PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Pau Espin Pedrol
RFC 5961 advises to only accept RST packets containing a seq number matching the next expected seq number instead of the whole receive window in order to avoid spoofing attacks. However, this situation is not optimal in the case SACK is in use at the time the RST is sent. I recently run into a

[PATCH net-next v2 5/5] hv_netvsc: pass struct net_device to rndis_filter_set_offload_params()

2016-06-03 Thread Vitaly Kuznetsov
The only caller rndis_filter_device_add() has 'struct net_device' pointer already. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/rndis_filter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c

[PATCH net-next v2 4/5] hv_netvsc: pass struct net_device to rndis_filter_set_device_mac()

2016-06-03 Thread Vitaly Kuznetsov
We unpack 'struct net_device' in netvsc_set_mac_addr() to get to 'struct hv_device' pointer which we use in rndis_filter_set_device_mac() to get back to 'struct net_device'. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 2 +-

[PATCH net-next 02/17] net: dsa: mv88e6xxx: fix circular lock in PPU work

2016-06-03 Thread Andrew Lunn
From: Vivien Didelot Lock debugging shows that there is a possible circular lock in the PPU work code. Switch the lock order of smi_mutex and ppu_mutex to fix this. Here's the full trace: [4.341325]

[PATCH net-next 10/17] net: dsa: mv88e6xxx: Only support EDSA tagging

2016-06-03 Thread Andrew Lunn
The merged driver no longer offers the option to use DSA tagging. So remove the code to setup the switch to do DSA tagging and hard code the use of EDSA. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-)

Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock

2016-06-03 Thread Grygorii Strashko
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote: There is no reason in this lock. At least for now. Signed-off-by: Ivan Khoronzhuk --- Based on master drivers/net/ethernet/ti/cpsw.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH net-next 07/17] net: dsa: Remove dynamic allocate of routing table

2016-06-03 Thread Andrew Lunn
With a maximum of four switches, the size of the routing table is the same as the pointer to it. Removing it makes the code simpler. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 3 +-- include/net/dsa.h | 9 - net/dsa/dsa.c | 12

Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency

2016-06-03 Thread Grygorii Strashko
On 06/02/2016 04:30 PM, Ivan Khoronzhuk wrote: On 02.06.16 16:14, Ivan Khoronzhuk wrote: The rx-usecs shouldn't be changed while interface down/up. Currently, for instance, if it's set to 100us, after interface down/up it's 500us. It's a hidden bug that can lead to lavish interrupt pacing time

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-03 Thread Grygorii Strashko
On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: There is no reason to hold s/w dependent parameter in device tree. Even more, there is no reason in this parameter because davinici_cpdma driver splits pool of descriptors equally between tx and rx channels. That is, if number of descriptors 256,

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Pau Espin
Hi Neal, Sorry I saw your email just after sending the second version of the patch. Indeed, it could make sense to do it as you say. I'll try to do some tests in my environment and send a new version with those changes if I don't find any problem with it. On Fri, Jun 3, 2016 at 5:45 PM, Neal

Re: [PATCH v3 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-03 Thread Andrew Lunn
On Fri, Jun 03, 2016 at 08:56:06PM +0530, Pramod Kumar wrote: > iProc based SoCs supports the integrated mdio multiplexer which > has the bus selection as well as mdio transaction generation logic > inside. > > This mutiplexer has child buses for PCIe, SATA, USB and ETH. These multiplexer >

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
Could not compile this new version of skb_array.h, it complains about implicit declaration of function 'skb_vlan_tag_present' and 'VLAN_HLEN' being undeclared. Fix this by including linux/if_vlan.h, but is that correct? On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin"

[PATCH net-next 04/15] smc: introduce SMC as an IB-client

2016-06-03 Thread Ursula Braun
* create a list of SMC IB-devices (IB-devices mentioned in PNET table) * determine RoCE device and port belonging to used internal TCP interface according to the PNET table definitions Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c |

[PATCH net-next 11/15] smc: connection data control (CDC)

2016-06-03 Thread Ursula Braun
send and receive CDC messages (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 1 + net/smc/af_smc.c | 8 ++ net/smc/smc.h | 89 + net/smc/smc_cdc.c | 281

[PATCH net-next 01/15] net: introduce keepalive function in struct proto

2016-06-03 Thread Ursula Braun
Direct call of tcp_set_keepalive() function from protocol-agnostic sock_setsockopt() function in net/core/sock.c violates network layering. And newly introduced protocol (SMC-R) will need its own keepalive function. Therefore, add "keepalive" function pointer to "struct proto", and call it from

[PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-06-03 Thread Ursula Braun
From: Ursula Braun These patches are the initial part of the implementation of the "Shared Memory Communications-RDMA" (SMC-R) protocol. The protocol is defined in RFC7609 [1]. It allows transformation of TCP connections using the "Remote Direct Memory Access over

[PATCH net-next 05/15] smc: CLC handshake (incl. preparation steps)

2016-06-03 Thread Ursula Braun
* CLC (Connection Layer Control) handshake Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 467 ++ net/smc/smc.h | 24 ++- net/smc/smc_clc.c | 251 +

[PATCH net-next 13/15] smc: receive data from RMBE

2016-06-03 Thread Ursula Braun
move RMBE data into user space buffer and update managing cursors Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 7 +- net/smc/smc.h | 4 + net/smc/smc_cdc.c | 6 +- net/smc/smc_core.c | 10 +++ net/smc/smc_rx.c | 212

[PATCH v3 6/7] Binding:PHY: Binding doc for NS2 PCIe PHYs.

2016-06-03 Thread Pramod Kumar
Binding doc for NS2 PCIe PHYs. Acked-by: Rob Herring Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- .../bindings/phy/brcm,mdio-mux-bus-pci.txt | 27 ++ 1 file changed, 27 insertions(+)

[PATCH v3 7/7] phy: Add Northstar2 PCI Phy support

2016-06-03 Thread Pramod Kumar
Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the interface from the iproc mdio mux driver to enable the devices respective phys. Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- drivers/phy/Kconfig|

[PATCH net-next 09/15] smc: initialize IB transport incl. PD, MR, QP, CQ, event, WR

2016-06-03 Thread Ursula Braun
Prepare the link for RDMA transport: Create a queue pair (QP) and move it into the state Ready-To-Receive (RTR). Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 34 ++-- net/smc/smc.h | 1 + net/smc/smc_clc.c | 10 ++- net/smc/smc_core.c | 80

[PATCH ipvs-next] ipvs: count pre-established TCP states as active

2016-06-03 Thread Michal Kubecek
Some users observed that "least connection" distribution algorithm doesn't handle well bursts of TCP connections from reconnecting clients after a node or network failure. This is because the algorithm counts active connection as worth 256 inactive ones where for TCP, "active" only means TCP

[PATCH v3 RESEND 6/7] Binding:PHY: Binding doc for NS2 PCIe PHYs.

2016-06-03 Thread Pramod Kumar
Binding doc for NS2 PCIe PHYs. Acked-by: Rob Herring Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- .../bindings/phy/brcm,mdio-mux-bus-pci.txt | 27 ++ 1 file changed, 27 insertions(+)

[PATCH v3 RESEND 7/7] phy: Add Northstar2 PCI Phy support

2016-06-03 Thread Pramod Kumar
Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the interface from the iproc mdio mux driver to enable the devices respective phys. Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- drivers/phy/Kconfig|

Re: [PATCH v2 -next] virtio-net: Add initial MTU advice feature

2016-06-03 Thread Michael S. Tsirkin
On Thu, Jun 02, 2016 at 05:10:59PM -0400, Aaron Conole wrote: > This commit adds the feature bit and associated mtu device entry for the > virtio network device. When a virtio device comes up, it checks the > feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is > enabled, the

[PATCH v3 RESEND 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-03 Thread Pramod Kumar
iProc based SoCs supports the integrated mdio multiplexer which has the bus selection as well as mdio transaction generation logic inside. This mutiplexer has child buses for PCIe, SATA, USB and ETH. These buses could be internal or external to SOC where PHYs are attached. These buses could use

[PATCH net-next 05/17] net: dsa: Add a ports structure and use it in the switch structure

2016-06-03 Thread Andrew Lunn
There are going to be more per-port members added to the switch structure. So add a port structure and move the netdev into it. Signed-off-by: Andrew Lunn --- drivers/net/dsa/bcm_sf2.c | 4 ++-- drivers/net/dsa/mv88e6xxx.c | 27 --- include/net/dsa.h

[PATCH net-next 01/17] net: dsa: slave: chip data is optional, don't dereference NULL

2016-06-03 Thread Andrew Lunn
The new binding does not make use of dsa_chip_data, a.k.a cd. When retrieving the size of the EEPROM attached to a switch, don't assume there is a cd attached to the switch structure. Signed-off-by: Andrew Lunn --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net-next 16/17] arm: dt: vf610-zii-devel-b: Make use of new DSA binding

2016-06-03 Thread Andrew Lunn
Hang the three switches of the three MDIO busses using the new DSA binding. Also, make use of the mdio-bus and explicitly list the phys on one device. This is not required, but good for testing. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 328

[PATCH net-next 06/17] net: dsa: Move port device node into port structure

2016-06-03 Thread Andrew Lunn
Move the port device node structure into the port structure, from the chip data. This information is needed in the next step of implementing the new binding. The chip data structure is used while parsing the whole old binding, before the individual switch structures exist. With the new bindings,

[PATCH net-next 04/17] net: dsa: tag_{e}dsa.c: Remove dependency on platform data

2016-06-03 Thread Andrew Lunn
The platform data nr_chips is used when validating a received packet, to ensure it comes from a know switch chip. The number of possible switches is limited to DSA_MAX_SWITCHES, so use this as the first validation step. The new binding allows holes in the dst->ds[] array, so also ensure ensure

[PATCH net-next 15/17] net: dsa: Add new binding implementation

2016-06-03 Thread Andrew Lunn
The existing DSA binding has a number of limitations and problems. The main problem is that it cannot represent a switch as a linux device, hanging off some bus. It is limited to one CPU port. The DSA platform device is artificial, and does not really represent hardware. Implement a new binding

[PATCH net-next 03/17] net: dsa: slave: Remove MDIO address from switch MDIO bus name

2016-06-03 Thread Andrew Lunn
The DSA layer should no longer assume the switch is connected to an MDIO bus. As a result, we cannot use the address on the MDIO bus when forming the name of the switches internal MDIO bus for its builtin and possibly external PHYs. The switch index is sufficient to make the name unique, so drop

[PATCH v3 1/7] mdio:mux: Enhanced MDIO mux framework for integrated multiplexers

2016-06-03 Thread Pramod Kumar
An integrated multiplexer uses same address space for "muxed bus selection" and "generation of mdio transaction" hence its good to register parent bus from mux driver. Hence added a mechanism where mux driver could register a parent bus and pass it down to framework via mdio_mux_init api.

[PATCH v3 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer

2016-06-03 Thread Pramod Kumar
Add DT binding doc for Broadcom MDIO bus mutiplexer driver. Signed-off-by: Pramod Kumar --- .../bindings/net/brcm,mdio-mux-iproc.txt | 59 ++ 1 file changed, 59 insertions(+) create mode 100644

[PATCH v3 0/7] Add MDIO bus multiplexer support for iProc SoCs

2016-06-03 Thread Pramod Kumar
Broadcom iProc based SoCs use a MDIO bus multiplexer where child buses could be internal as well external to SoCs. These buses could supports MDIO transaction compatible to C-22/C-45. Broadcom MDIO bus mulitplexer is an integrated multiplexer where child bus selection and mdio transaction logic

[PATCH v3 2/7] binding: Make "mdio-parent-bus" property from mandatory to optional

2016-06-03 Thread Pramod Kumar
Change "mdio-parent-bus" from mandatory section to optional as it won't be required by integrated MDIO multiplexer which has bus selection and mdio transaction generation logic, integrated inside. Signed-off-by: Pramod Kumar ---

[PATCH net-next v2 1/5] hv_netvsc: remove redundant assignment in netvsc_recv_callback()

2016-06-03 Thread Vitaly Kuznetsov
net_device_ctx is assigned in the very beginning of the function and 'net' pointer doesn't change. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/netvsc_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c

[PATCH net-next v2 0/5] hv_netvsc: cleanup after untangling the pointer mess

2016-06-03 Thread Vitaly Kuznetsov
Changes since v1: - resend when net-next is open [David Miller] - rebased to current net-next. After we made traveling through our internal structures explicit it became obvious that some functions take arguments they don't need just to do redundant pointer travel and get to what they really need

[PATCH net-next v2 2/5] hv_netvsc: introduce {net,hv}_device_to_netvsc_device() helpers

2016-06-03 Thread Vitaly Kuznetsov
Make it easier to get 'struct netvsc_device' from 'struct net_device' and 'struct hv_device' by introducing inline helpers. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 12 drivers/net/hyperv/netvsc.c | 11 +++

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Eric Dumazet
On Fri, 2016-06-03 at 11:45 -0400, Neal Cardwell wrote: > On Fri, Jun 3, 2016 at 11:13 AM, Eric Dumazet wrote: > > I have no strict opinion on this. > > > > It seems to me that checking at most 4 right edges (at least in current > > linux implementation) is not adding a

Re: [PATCH v3 RESEND 0/7] Add MDIO bus multiplexer support for iProc SoCs

2016-06-03 Thread Andrew Lunn
> Reason for resend: > -Rebased on v4.7-rc1 How do you see this getting merged? Via netdev? If so, you should be based on net-next/master, not v4.7-rc1. Andrew

[PATCH net-next 08/17] net: dsa: Copy the routing table into the switch structure

2016-06-03 Thread Andrew Lunn
The new binding will not have a chip data structure, it will place the routing directly into the switch structure. To enable backwards compatibility, copy the routing from the chip data into the switch structure. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 4

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Mario_Limonciello
> -Original Message- > From: Hayes Wang [mailto:hayesw...@realtek.com] > Sent: Friday, June 3, 2016 4:44 AM > To: Limonciello, Mario > Cc: LKML ; Netdev > ; Linux USB ; >

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Mario_Limonciello
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, June 2, 2016 9:02 PM > To: Limonciello, Mario > Cc: hayesw...@realtek.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; linux-...@vger.kernel.org;

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Eric Dumazet
On Fri, 2016-06-03 at 14:16 +0200, Pau Espin wrote: > I will provide a new patch as soon as I find some time to do it. > > Indeed, I think there is no need to check duplicate_sack, I will remove it. > > I will also update the description. > > Shall I also add a sysctl to disable this patch and

Re: [PATCH v3 7/7] phy: Add Northstar2 PCI Phy support

2016-06-03 Thread Andrew Lunn
On Fri, Jun 03, 2016 at 08:56:08PM +0530, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Signed-off-by: Jon Mason > Signed-off-by: Pramod

[PATCH net-next 14/17] net: dsa: mv88e6xxx: Refactor MDIO so driver registers mdio bus

2016-06-03 Thread Andrew Lunn
Have the switch driver register its own MDIO bus. This allows for an mdio property in the device tree, with child nodes for phys, which can be referenced via phandles, etc. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 89

[PATCH] net: stmmac: dwmac-rk: keep PHY up for WoL

2016-06-03 Thread Vincent Palatin
Do not shutdown the PHY if Wake-on-Lan is enabled, else it cannot wake us up. Signed-off-by: Vincent Palatin --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

Re: [PATCH net-next 04/17] net: dsa: tag_{e}dsa.c: Remove dependency on platform data

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The platform data nr_chips is used when validating a received packet, > to ensure it comes from a know switch chip. The number of possible > switches is limited to DSA_MAX_SWITCHES, so use this as the first > validation step. The new binding allows holes in

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-03 Thread Ivan Khoronzhuk
On 03.06.16 19:50, Grygorii Strashko wrote: On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: There is no reason to hold s/w dependent parameter in device tree. Even more, there is no reason in this parameter because davinici_cpdma driver splits pool of descriptors equally between tx and rx

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-03 Thread Grygorii Strashko
On 06/03/2016 09:25 PM, Ivan Khoronzhuk wrote: > > > On 03.06.16 19:50, Grygorii Strashko wrote: >> On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: >>> There is no reason to hold s/w dependent parameter in device tree. >>> Even more, there is no reason in this parameter because davinici_cpdma >>>

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of SACK block

2016-06-03 Thread Neal Cardwell
On Fri, Jun 3, 2016 at 12:24 PM, Eric Dumazet wrote: > On Fri, 2016-06-03 at 11:45 -0400, Neal Cardwell wrote: >> But I would also vote to tighten up the proposed logic slightly, and >> only check the seq of the incoming RST against the right edge of the >> *right-most*

Re: [PATCH net-next 2/2] bgmac: Add support for ethtool statistics

2016-06-03 Thread Florian Fainelli
On 06/03/2016 10:57 AM, Ben Hutchings wrote: > On Fri, 2016-06-03 at 10:07 -0700, Florian Fainelli wrote: > [...] >> +static void bgmac_get_strings(struct net_device *dev, u32 stringset, >> + u8 *data) >> +{ >> +int i; >> + >> +if (stringset != ETH_SS_STATS) >> +

Re: [PATCH] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-03 Thread Ivan Khoronzhuk
On 03.06.16 22:13, Grygorii Strashko wrote: On 06/03/2016 09:25 PM, Ivan Khoronzhuk wrote: On 03.06.16 19:50, Grygorii Strashko wrote: On 06/03/2016 01:43 AM, Ivan Khoronzhuk wrote: There is no reason to hold s/w dependent parameter in device tree. Even more, there is no reason in this

Re: [PATCH net-next 04/17] net: dsa: tag_{e}dsa.c: Remove dependency on platform data

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The platform data nr_chips is used when validating a received packet, > to ensure it comes from a know switch chip. The number of possible > switches is limited to DSA_MAX_SWITCHES, so use this as the first > validation step. The new binding allows

Re: [PATCH net-next 11/17] net: dsa: Refactor selection of tag ops into a function

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > Replace the two switch statements with an array lookup, and store the > result in the dsa tree structure. The drivers no longer need to know > the selected tag protocol, so remove it from the dsa switch structure. > > Signed-off-by: Andrew Lunn

[PATCH stable] Set a large MTU on ovs-created tunnel devices

2016-06-03 Thread Dan Streetman
Can you queue up these commits for stable? commit 72564b59ffc438ea103b0727a921aaddce766728 Author: David Wragg Date: Wed Feb 10 00:05:55 2016 + vxlan: Relax MTU constraints commit 55e5bfb53cff286c1c1ff49f51325dc15c7fea63 Author: David Wragg

Re: [PATCH net-next 2/2] bgmac: Add support for ethtool statistics

2016-06-03 Thread Ben Hutchings
On Fri, 2016-06-03 at 10:07 -0700, Florian Fainelli wrote: [...] > +static void bgmac_get_strings(struct net_device *dev, u32 stringset, > +   u8 *data) > +{ > + int i; > + > + if (stringset != ETH_SS_STATS) > + return; > + > + for (i = 0; i <

Re: [PATCH net-next 06/17] net: dsa: Move port device node into port structure

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > Move the port device node structure into the port structure, from the > chip data. This information is needed in the next step of implementing > the new binding. > > The chip data structure is used while parsing the whole old binding, > before the individual

Re: [PATCH net-next 08/17] net: dsa: Copy the routing table into the switch structure

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The new binding will not have a chip data structure, it will place the > routing directly into the switch structure. To enable backwards > compatibility, copy the routing from the chip data into the switch > structure. > > Signed-off-by: Andrew Lunn

[PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Helge Deller
Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF setsockoption() option. Since both SO_ATTACH_FILTER and SO_ATTACH_REUSEPORT_CBPF use a struct sock_fprog let's combine the handling of both. Signed-off-by: Helge

Re: [PATCH net-next 00/17] New DSA bind, switches as devices

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:43 AM, Andrew Lunn wrote: > The interesting patches here are the last three. They implement a new > binding for DSA, which removes a few limitations of the current DSA > binding. In particular, it allows switches to be true Linux devices. > These devices can be on any type of bus,

Re: [PATCH net-next] bridge: Synchronize unicast filtering with FDB

2016-06-03 Thread Nikolay Aleksandrov
> On Jun 3, 2016, at 5:54 PM, Nikolay Aleksandrov > wrote: > >> >> On Jun 3, 2016, at 11:33 AM, Toshiaki Makita >> wrote: >> >> Patrick Schaaf reported that flooding due to a missing fdb entry of >> the address of macvlan on the

Re: [PATCH net-next 05/17] net: dsa: Add a ports structure and use it in the switch structure

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > There are going to be more per-port members added to the switch > structure. So add a port structure and move the netdev into it. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC v7 0/5] skb_array: array based FIFO for skbs

2016-06-03 Thread Jesper Dangaard Brouer
I applied this V7 to my github tree: https://github.com/netoptimizer/prototype-kernel/commits/master And adjusted my benchmark and unit-tests of this skb_array API. Added an unit test of re-sizing to small queue size.

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

2016-06-03 Thread Jes Sorensen
Colin King writes: > From: Colin Ian King > > path_b_ok is being assigned but immediately after path_a_ok is being > compared to the value 0x03. This appears to be a typo on the > variable name, compare path_b_ok instead. > > Signed-off-by:

[PATCH] net: igb: Only dma sync frame length

2016-06-03 Thread Andrew Lunn
On some platforms, syncing a buffer for DMA is expensive. Rather than sync the whole 2K receive buffer, only synchronise the length of the frame, which will typically be the MTU, or a much smaller TCP ACK. For an IMX6Q, this gives around 6% increased TCP receive performance, which is cache

Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-03 Thread Sergei Shtylyov
Hello. On 06/03/2016 08:18 PM, Helge Deller wrote: Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") At least 12 digits must be specified for SHA1. checkpatch.pl should've caught this. missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF setsockoption()

Re: [PATCH net-next 03/17] net: dsa: slave: Remove MDIO address from switch MDIO bus name

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The DSA layer should no longer assume the switch is connected to an > MDIO bus. As a result, we cannot use the address on the MDIO bus when > forming the name of the switches internal MDIO bus for its builtin and > possibly external PHYs. The switch index is

Re: [PATCH net-next 06/17] net: dsa: Move port device node into port structure

2016-06-03 Thread Florian Fainelli
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > Move the port device node structure into the port structure, from the > chip data. This information is needed in the next step of implementing > the new binding. > > The chip data structure is used while parsing the whole old binding, > before the

Re: [PATCH net-next 07/17] net: dsa: Remove dynamic allocate of routing table

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > With a maximum of four switches, the size of the routing table is the > same as the pointer to it. Removing it makes the code simpler. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-03 Thread David Miller
From: Oliver Hartkopp Date: Fri, 3 Jun 2016 19:15:29 +0200 > On 06/03/2016 07:03 PM, Ulrich Hecht wrote: > >> Thanks; I missed that every register is described twice. >> >> Nevertheless, names often vary more or less subtly between your patch >> and the specs, making it

Re: [PATCH stable] Set a large MTU on ovs-created tunnel devices

2016-06-03 Thread David Miller
From: Dan Streetman Date: Fri, 3 Jun 2016 13:49:09 -0400 > Can you queue up these commits for stable? This stuff doesn't cleanly backport, I tried several times already. Therfore, someone knowledgable with OVS is going to have to do the backport, test it, and post

[PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules

2016-06-03 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH net-next v3 2/2] net: vrf: Add l3mdev rules on first device create

2016-06-03 Thread David Ahern
Add l3mdev rule per address family when the first VRF device is created. Remove them when the last is deleted. Signed-off-by: David Ahern --- v3 - per Nik's comment changed num_vrfs from atomic to unsigned int; all accesses are with rtnl held v2 - added EXCL flag and

Re: [PATCH net-next 13/17] net: dsa: mv88e6xxx: Rename _phy_ to _mdio_

2016-06-03 Thread Vivien Didelot
Andrew Lunn writes: > The switch implements a generic MDIO bus, which could host more than > PHYs. It is conventional to use _mdio_ or _mii_ in the function name, > so rename them. Also postfix make the historically first read/write > function with _direct, to help distinguish it

[PATCH] soreuseport: Fix reuseport_bpf testcase on 32bit architectures

2016-06-03 Thread Helge Deller
This fixes the following compiler warnings when compiling the reuseport_bpf testcase on a 32 bit platform: reuseport_bpf.c: In function ‘attach_ebpf’: reuseport_bpf.c:114:15: warning: cast from pointer to integer of ifferent size [-Wpointer-to-int-cast] Signed-off-by: Helge Deller

  1   2   3   >