Eric Dumazet wrote:
> From: Eric Dumazet
>
> My prior attempt to fix the backlogs of parents failed.
>
> If we return NET_XMIT_CN, our parents wont increase their backlog,
> so our qdisc_tree_reduce_backlog() should take this into account.
[..]
>
The existing DSA binding has a number of limitations and problems. The
main problem is that it cannot represent a switch as a linux device,
hanging off some bus. It is limited to one CPU port. The DSA platform
device is artificial, and does not really represent hardware.
Implement a new binding
The merged driver no longer offers the option to use DSA tagging. So
remove the code to setup the switch to do DSA tagging and hard code
the use of EDSA.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Reviewed-by: Vivien Didelot
Replace the two switch statements with an array lookup, and store the
result in the dsa tree structure. The drivers no longer need to know
the selected tag protocol, so remove it from the dsa switch structure.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Move the port device node structure into the port structure, from the
chip data. This information is needed in the next step of implementing
the new binding.
The chip data structure is used while parsing the whole old binding,
before the individual switch structures exist. With the new bindings,
> index e8386157de30..938262010524 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst,
> struct dsa_switch *ds)
> continue;
> }
>
> - return 0;
> + return
The send path needs to be quiesced before resetting callbacks from
rds_tcp_accept_one(), and commit eb192840266f ("RDS:TCP: Synchronize
rds_tcp_accept_one with rds_send_xmit when resetting t_sock") achieves
this using the c_state and RDS_IN_XMIT bit following the pattern
used by
This three part patchset fixes bugs in synchronization between
rds_tcp_accept_one() and the rds-tcp send/recv path.
Patch 1 ensures that the lock_sock() is taken appropriately
and the RDS datagram reassembly state is reset to synchronize
with the receive path.
Patch 2 ensures that partially
When rds_tcp_accept_one() has to replace the existing tcp socket
with a newer tcp socket (duelling-syn resolution), it must lock_sock()
to suppress the rds_tcp_data_recv() path while callbacks are being
changed. Also, existing RDS datagram reassembly state must be reset,
so that the next datagram
When we switch a connection's sockets in rds_tcp_rest_callbacks,
any partially sent datagram must be retransmitted on the new
socket so that the receiver can correctly reassmble the RDS
datagram. Use rds_send_reset() which is designed for this purpose.
Signed-off-by: Sowmini Varadhan
On 06/04/2016 09:54 AM, Guenter Roeck wrote:
gcc-6 reports the following error with -Werror=unused-const-variable.
drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
'b43_phyops_a' defined but not used
Per Michael Büsch: "All a-phy code is usused", so remove it all,
and move the
On Sat, 2016-06-04 at 21:03 +0200, Florian Westphal wrote:
> Is skb still valid here? AFAICS its possible that fq_codel_drop() drops it.
>
> Other than that this looks good, thanks Eric!
You are are right. skb is guaranteed to be valid only when we return
NET_XMIT_SUCCESS.
I'll send a V2,
> @@ -626,8 +736,8 @@ static int _dsa_register_switch(struct dsa_switch *ds,
> struct device_node *np)
> {
> struct device_node *ports = dsa_get_ports(ds, np);
>
> - if (IS_ERR(ports))
> - return PTR_ERR(ports);
> + if (IS_ERR(ports) && PTR_ERR(ports) == -EINVAL)
> +
From: Eric Dumazet
My prior attempt to fix the backlogs of parents failed.
If we return NET_XMIT_CN, our parents wont increase their backlog,
so our qdisc_tree_reduce_backlog() should take this into account.
v2: Florian Westphal pointed out that we could drop the packet,
Add support for JMP_CALL_X (tail call) introduced by commit 04fd61ab36ec
("bpf: allow bpf programs to tail-call other bpf programs").
bpf_tail_call() arguments:
ctx - context pointer passed to next program
array - pointer to map which type is BPF_MAP_TYPE_PROG_ARRAY
index - index inside
net/rxrpc/rxkad.c:1165:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
CC: David Howells
Signed-off-by: Fengguang Wu
---
rxkad.c |4 +---
From: Colin Ian King
trivial fix to spelling mistake in pr_err message
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hang the three switches of the three MDIO busses using the new DSA
binding. Also, make use of the mdio-bus and explicitly list the phys
on one device. This is not required, but good for testing.
Signed-off-by: Andrew Lunn
Reviewed-by: Vivien Didelot
Add the new binding to the documentation of the existing binding.
Mark the old binding as deprecated.
Signed-off-by: Andrew Lunn
Signed-off-by: Florian Fainelli
Reviewed-by: Vivien Didelot
---
The new binding will not have a chip data structure, it will place the
routing directly into the switch structure. To enable backwards
compatibility, copy the routing from the chip data into the switch
structure.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Have the switch driver register its own MDIO bus. This allows for an
mdio property in the device tree, with child nodes for phys, which
can be referenced via phandles, etc.
Signed-off-by: Andrew Lunn
Reviewed-by: Vivien Didelot
---
The interesting patches here are the last three. They implement a new
binding for DSA, which removes a few limitations of the current DSA
binding. In particular, it allows switches to be true Linux devices.
These devices can be on any type of bus, unlike the old DSA binding
which assumes MDIO. See
From: Andrew Lunn
Date: Sat, 4 Jun 2016 21:16:50 +0200
> The interesting patches here are the last three. They implement a new
> binding for DSA, which removes a few limitations of the current DSA
> binding. In particular, it allows switches to be true Linux devices.
> These
The platform data nr_chips is used when validating a received packet,
to ensure it comes from a know switch chip. The number of possible
switches is limited to DSA_MAX_SWITCHES, so use this as the first
validation step. The new binding allows holes in the dst->ds[] array,
so also ensure ensure
---
drivers/dma/Kconfig | 5 +
drivers/dma/Makefile| 1 +
drivers/dma/dma_sram_rx_benchmark.c | 231
3 files changed, 237 insertions(+)
create mode 100644 drivers/dma/dma_sram_rx_benchmark.c
diff --git
There are going to be more per-port members added to the switch
structure. So add a port structure and move the netdev into it.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Reviewed-by: Vivien Didelot
---
The new binding does not make use of dsa_chip_data, a.k.a cd. When
retrieving the size of the EEPROM attached to a switch, don't assume
there is a cd attached to the switch structure.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Reviewed-by:
With a maximum of four switches, the size of the routing table is the
same as the pointer to it. Removing it makes the code simpler.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Reviewed-by: Vivien Didelot
On Sat, Jun 4, 2016 at 4:01 PM, Colin King wrote:
> From: Colin Ian King
>
> trivial fix to spelling mistake in pr_err message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/freescale/fec_main.c | 4
> @@ -517,6 +541,15 @@ static int dsa_parse_ports_dn(struct device_node *ports,
> struct dsa_switch *ds)
> return -EINVAL;
>
> ds->ports[reg].dn = port;
> +
> + if (dsa_port_is_cpu(port))
> + ds->dst->cpu_port = reg;
> +
On Fri, Jun 03, 2016 at 05:05:27PM -0700, Florian Fainelli wrote:
> In preparation for allowing switch drivers to implement system-wide
> suspend/resume functions, export dsa_switch_suspend and
> dsa_switch_resume() such that these are callable from the appropriate
> driver specific suspend/resume
Hi Phil,
On 04.06.2016 09:35, Phil Sutter wrote:
> [Cc'ing other interested parties, therefore full-quoting.]
> On Fri, Jun 03, 2016 at 10:22:26PM +0200, Helge Deller wrote:
>> I'm testing 4.7.0-rc1-64bit on a parisc/hppa machine and get
>> those message with CONFIG_TEST_RHASHTABLE=y.
>>
>> Is
> Andrew Lunn (16):
> net: dsa: slave: chip data is optional, don't dereference NULL
> net: dsa: slave: Remove MDIO address from switch MDIO bus name
> net: dsa: tag_{e}dsa.c: Remove dependency on platform data
> net: dsa: Add a ports structure and use it in the switch structure
> net:
On Fri, Jun 03, 2016 at 05:05:25PM -0700, Florian Fainelli wrote:
> In case we have multiples trees and switches with the same index, we
> need to add another discriminating id: the switch tree.
>
> Signed-off-by: Florian Fainelli
Reviewed-by: Andrew Lunn
Remove superfluous stack frame, saving us 3 instructions for every
LD_ABS or LD_IND.
Signed-off-by: Zi Shen Lim
---
arch/arm64/net/bpf_jit_comp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index
Remove superfluous stack frame, saving us 3 instructions for
every JMP_CALL.
Signed-off-by: Zi Shen Lim
---
arch/arm64/net/bpf_jit_comp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index
Hi,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Zi-Shen-Lim/arm64-bpf-implement-bpf_tail_call-helper/20160605-060435
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
In bpf_perf_event_read() and bpf_perf_event_output(), we must use
READ_ONCE() for fetching the struct file pointer, which could get
updated concurrently, so we must prevent the compiler from potential
refetching.
We already do this with tail calls for fetching the related bpf_prog,
but not so on
Refactor the code to setup a single DSA/CPU port into a function of
its own, and export it, so it can be used by the new binding.
Similarly, refactor the destroy code into a function. When destroying
the ports, don't put the of node. They should be released at the end
along with the normal
The DSA layer should no longer assume the switch is connected to an
MDIO bus. As a result, we cannot use the address on the MDIO bus when
forming the name of the switches internal MDIO bus for its builtin and
possibly external PHYs. The switch index is sufficient to make the
name unique, so drop
From: Bhaktipriya Shridhar
Date: Sat, 4 Jun 2016 19:31:35 +0530
> Thank you for your feedback.
> Will send another patch with changed description.
I already applied your patch to the net-next tree, so that wouldn't
be appropriate.
> -static struct dsa_switch_driver bcm_sf2_switch_driver = {
> +static struct dsa_switch_driver bcm_sf2_switch_ops = {
> .tag_protocol = DSA_TAG_PROTO_BRCM,
> .probe = bcm_sf2_sw_drv_probe,
> .setup = bcm_sf2_sw_setup,
Does this also
The switch implements a generic MDIO bus, which could host more than
PHYs. It is conventional to use _mdio_ or _mii_ in the function name,
so rename them. Also postfix make the historically first read/write
function with _direct, to help distinguish it from _indirect and _ppu.
While touching
On some platforms, syncing a buffer for DMA is expensive. Rather than
sync the whole 2K receive buffer, only synchronise the length of the
frame, which will typically be the MTU, or a much smaller TCP ACK.
For an IMX6Q, this gives around 6% increased TCP receive performance,
which is cache
The switch may want to instantiate its own MDIO bus. Only do it
centrally if the switch has not already created one, and the read op
is implemented.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
net/dsa/dsa.c | 24 +---
1
From: Vivien Didelot
Lock debugging shows that there is a possible circular lock in the PPU
work code. Switch the lock order of smi_mutex and ppu_mutex to fix this.
Here's the full trace:
[4.341325]
> -static int bcm_sf2_sw_phy_read(struct dsa_switch *ds, int addr, int regnum)
> +static int bcm_sf2_sw_phy_read(struct mii_bus *bus, int addr, int regnum)
Hi Florian
When i did the same for mv88e6xxx, i renamed _phy_ to _mdio_. That
keeps with the general pattern for other mdio drivers, making
From: Eric Dumazet
My prior attempt to fix the backlogs of parents failed.
If we return NET_XMIT_CN, our parents wont increase their backlog,
so our qdisc_tree_reduce_backlog() should take this into account.
Fixes: 9d18562a2278 ("fq_codel: add batch ability to
> -static int dsa_cpu_parse(struct device_node *port, u32 index,
> - struct dsa_switch_tree *dst,
> - struct dsa_switch *ds)
> +static int _dsa_cpu_parse(struct dsa_switch_tree *dst,
> +struct dsa_switch *ds,
> +
From: Yisen Zhuang
Date: Fri, 3 Jun 2016 10:55:08 +0800
> From: Kejian Yan
>
> This series adds HNS support of acpi. The routine will call some ACPI
> helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which
> are not included in
From: Kalle Valo
Date: Sat, 04 Jun 2016 18:45:21 +0300
> few fixes for 4.7. Please let me know if you have any issues.
Pulled, thanks kalle.
From: Eric Dumazet
Note: Tom Herbert posted almost same patch 3 months back, but for
different reasons.
The reasons we want to get rid of this spin_trylock() are :
1) Under high qdisc pressure, the spin_trylock() has almost no
chance to succeed.
2) We loop multiple times
> When is_kdump_kernel() is true, reduce our memory footprint by only using a
> single "Queue Set" and Forcing Master so we can reinitialize the
> Firmware/Chip.
>
> Signed-off-by: Hariprasad Shenai
...
> if (q10g > netif_get_num_default_rss_queues())
>
alloc_workqueue replaces deprecated create_workqueue().
In if_sdio.c, the workqueue card->workqueue has workitem
>packet_worker, which is mapped to if_sdio_host_to_card_worker.
The workitem is involved in sending packets to firmware.
Forward progress under memory pressure is a requirement here.
Thank you for your feedback.
Will send another patch with changed description.
Bhaktipriya.
On Fri, Jun 3, 2016 at 5:25 AM, Izumi, Taku wrote:
> Dear Bhaktipriya,
>
> Thanks. Looks good to me.
>
> Sincerely,
> Taku Izumi
>
>> -Original Message-
>> From:
Hi,
On Fri, 3 Jun 2016 12:39:45 +0300 Ido Schimmel wrote:
> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
> index 1607977..c73ed44 100644
> --- a/net/bridge/br_input.c
> +++ b/net/bridge/br_input.c
> @@ -223,9 +223,7 @@ static int br_handle_local_finish(struct
[Cc'ing other interested parties, therefore full-quoting.]
Hi Helge,
On Fri, Jun 03, 2016 at 10:22:26PM +0200, Helge Deller wrote:
> Hi Phil,
>
> I'm testing 4.7.0-rc1-64bit on a parisc/hppa machine and get
> those message with CONFIG_TEST_RHASHTABLE=y.
>
> Is this expected/normal ?
No, this
On Fri, 3 Jun 2016 21:11:51 -0700
Guenter Roeck wrote:
> +static void __b43_phy_initg(struct b43_wldev *dev)
> +{
> + struct b43_phy *phy = >phy;
> +
> + might_sleep();
> +
> + if (phy->rev >= 6) {
> + if (b43_phy_read(dev, B43_PHY_ENCORE) &
Sat, Jun 04, 2016 at 09:41:41AM IDT, shmulik.ladk...@gmail.com wrote:
>Hi,
>
>On Fri, 3 Jun 2016 12:39:45 +0300 Ido Schimmel wrote:
>> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
>> index 1607977..c73ed44 100644
>> --- a/net/bridge/br_input.c
>> +++
On Sat, Jun 4, 2016 at 1:49 AM, Marcelo Ricardo Leitner
wrote:
> On Fri, Jun 03, 2016 at 10:42:45PM +0800, Xin Long wrote:
>> Now sctp doesn't change socket state upon shutdown reception. It changes
>> just the assoc state, even though it's a TCP-style socket.
>>
>> For
Hello Hauke,
[...]
> +
> +static int xway_gphy_ack_interrupt(struct phy_device *phydev)
> +{
> + int reg;
> +
> + /**
> + * Possible IRQ numbers:
> + * - IM3_IRL18 for GPHY0
> + * - IM3_IRL17 for GPHY1
These are references to the SoC interrupts.
> + *
> + * Due
alloc_workqueue replaces deprecated create_workqueue().
A dedicated workqueue has been used since the workitem viz
(>wk.work which maps to oct_poll_req_completion) is involved
in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
forward progress under memory pressure, which is a
gcc-6 reports the following error with -Werror=unused-const-variable.
drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
'b43_phyops_a' defined but not used
Per Michael Büsch: "All a-phy code is usused", so remove it all,
and move the remaining Type-G initialization code into
Per Michael Büsch: "All a-phy code is usused", so remove it all.
Cc: Michael Büsch
Signed-off-by: Guenter Roeck
---
v3: no change
v2: added patch
drivers/net/wireless/broadcom/b43/main.c | 31 +---
drivers/net/wireless/broadcom/b43/wa.c | 283
Lauri Kasanen wrote:
> The previous text was confusing, leading readers to think this
> driver was a duplicate, and so didn't need to be enabled.
>
> After the removal of the older staging driver, this is the only
> driver in mainline for these devices.
>
> Signed-off-by: Lauri
alloc_workqueue replaces deprecated create_workqueue().
A dedicated workqueue has been used since the workitem viz
(_wq->wk.work which maps to check_db_timeout) is involved
in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
forward progress under memory pressure, which is a
Hi Dave,
few fixes for 4.7. Please let me know if you have any issues.
Kalle
The following changes since commit b7e7ad611e24b95b0db2998428ce78370415c086:
Merge branch 'qed-fixes' (2016-05-26 12:27:33 -0700)
are available in the git repository at:
alloc_workqueue replaces deprecated create_workqueue().
The workqueue adapter->txrx_wq has workitem
>raise_intr_rxdata_task per adapter. Extended Socket Network
Device is shared memory based, so someone's transmission denotes other's
reception. raise_intr_rxdata_task raises interruption of
Bhaktipriya Shridhar writes:
> alloc_workqueue replaces deprecated create_workqueue().
>
> In if_sdio.c, the workqueue card->workqueue has workitem
> >packet_worker, which is mapped to if_sdio_host_to_card_worker.
> The workitem is involved in sending packets to
On Sat, Jun 4, 2016 at 7:59 PM, Kalle Valo wrote:
>
> $ git log --oneline --no-merges -10
Sure. Will keep that in mind.
Thanks,
Bhaktipriya
(Fixing top posting)
"Pan, Miaoqing" writes:
>>> --- a/drivers/net/wireless/ath/ath9k/reg.h
>>> +++ b/drivers/net/wireless/ath/ath9k/reg.h
>>> @@ -1122,8 +1122,8 @@ enum {
>>> #define AR9300_NUM_GPIO 16
>>> #define AR9330_NUM_GPIO
Hi Thomas
Hi Hauke
On 04/06/2016 16:43, Langer, Thomas wrote:
>> + /* there is an errata regarding irqs in this rev */
> And then this is comment is also now valid.
> What about a system with a single external phy connected,
> on a non-Lantiq/Intel SoC?
>
> I think the feasibility of
Julia Lawall wrote:
> firmare -> firmware
>
> Signed-off-by: Julia Lawall
Thanks, 1 patch applied to wireless-drivers-next.git:
47ce90f9f08a mwifiex: fix typo
--
Sent by pwcli
https://patchwork.kernel.org/patch/9113281/
Am 04.06.2016 um 16:43 schrieb Langer, Thomas:
> Hello Hauke,
>
> [...]
>> +
>> +static int xway_gphy_ack_interrupt(struct phy_device *phydev)
>> +{
>> +int reg;
>> +
>> +/**
>> + * Possible IRQ numbers:
>> + * - IM3_IRL18 for GPHY0
>> + * - IM3_IRL17 for GPHY1
>
> These
Add a possibility where the user can just specify the parent and
all filters under that parent are then being purged. Currently,
for example for scripting, one needs to specify pref/prio to have
a well-defined number for 'tc filter del' command for addressing
the previously created instance or
On Thu, 2 Jun 2016 18:12:35 +0200
Sebastian Andrzej Siewior wrote:
> * Steven Rostedt | 2016-05-26 19:56:41 [-0400]:
>
> >[ Alison, can you try this patch ]
>
> Alison, did you try it?
>
> Sebastian
This patch may help too...
-- Steve
>From
This adds support for the Intel (former Lantiq) XWAY 11G and 22E PHYs.
These PHYs are also named PEF 7061, PEF 7071, PEF 7072.
Signed-off-by: John Crispin
Signed-off-by: Hauke Mehrtens
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile |
This binding makes it possible to control the LEDs of an Ethernet PHY.
These settings allow it to abstract the hardware configuration which
tells the hardware when to switch the LED constant on or blink for
example. This will be used by the Intel XWAY PHY driver. I also
checked datasheets for
This makes it possible to configure the behavior of the LEDs connected
to a PHY. The LEDs are controlled by the chip, this makes it possible
to configure the behavior when the hardware should activate and
deactivate the LEDs.
Signed-off-by: Hauke Mehrtens
---
Em 04-06-2016 02:57, David Miller escreveu:
From: kbuild test robot
Date: Sat, 4 Jun 2016 08:48:17 +0800
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 330348d94223346f855357fab2517f6c903001c7
commit:
This adds the Intel XWAY driver and also adds a device tree binding for
Ethernet PHY LEDs.
changes since
RFC v2:
* add Documentation/devicetree/bindings/phy/intel-xway.txt
* fixed some typos
* renamed from lantiq.c to intel-xway.c
* split the generic PHY binding information out
Hauke
Em 04-06-2016 06:45, Xin Long escreveu:
On Sat, Jun 4, 2016 at 1:49 AM, Marcelo Ricardo Leitner
wrote:
On Fri, Jun 03, 2016 at 10:42:45PM +0800, Xin Long wrote:
Now sctp doesn't change socket state upon shutdown reception. It changes
just the assoc state, even
82 matches
Mail list logo