[PATCH V2 0/3] basic device IOTLB support for vhost_net

2016-06-23 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace IOMMU implementation (qemu) for a secure DMA environment (DMAR) in guest. The idea is simple. When vhost meets an IOTLB miss, it will request the assistance of userspace to do the

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

2016-06-23 Thread Herbert Xu
On Thu, Jun 23, 2016 at 11:48:25AM +0800, Herbert Xu wrote: > > No we never had such an API in the kernel. However, I see that > rxkad does some pretty silly things and we should be able to avoid > using the stack in pretty much all cases. Let me try to come up with > something. Here it is:

Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-23 Thread Tien Hock Loh
Hi Arnd, On Tue, 2016-06-21 at 11:34 +0200, Arnd Bergmann wrote: > On Tuesday, June 21, 2016 1:46:11 AM CEST th...@altera.com wrote: > > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > > b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > > index 72d82d6..dd10f2f

Re: [PATCH v2] net/mlx5: use mlx5_buf_alloc_node instead of mlx5_buf_alloc in mlx5_wq_ll_create

2016-06-23 Thread Saeed Mahameed
On Thu, Jun 23, 2016 at 4:04 AM, Wang Sheng-Hui wrote: > Fixes: 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on > reader NUMA node") > Hi Wang, I am sorry for the nitpicking, but the commit message needs to be improved. I prefer putting the "Fixes" line only after

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

2016-06-23 Thread Saeed Mahameed
On Thu, Jun 23, 2016 at 8:27 AM, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: >> The logging macros create a bit of duplicated code/text. >> >> Use specialized functions to reduce the duplication. >> >> (defconfig/x86-64) >> $ size

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-23 Thread David Miller
From: Richard Weinberger Date: Thu, 23 Jun 2016 00:15:04 +0200 > On Thu, Jun 16, 2016 at 7:51 PM, Tom Herbert wrote: >> Transports over UDP is intended to encapsulate TCP and other transport >> protocols directly and securely in UDP. >> >> The

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

2016-06-23 Thread Leon Romanovsky
On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > The logging macros create a bit of duplicated code/text. > > Use specialized functions to reduce the duplication. > > (defconfig/x86-64) > $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o* >    text    data bss

Re: [PATCH net-next 4/4] net_sched: generalize bulk dequeue

2016-06-23 Thread Paolo Abeni
On Tue, 2016-06-21 at 23:16 -0700, Eric Dumazet wrote: > When qdisc bulk dequeue was added in linux-3.18 (commit > 5772e9a3463b "qdisc: bulk dequeue support for qdiscs > with TCQ_F_ONETXQUEUE"), it was constrained to some > specific qdiscs. > > With some extra care, we can extend this to all

Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-23 Thread Giuseppe CAVALLARO
On 6/23/2016 3:38 AM, Tien Hock Loh wrote: Hi Peppe, On Wed, 2016-06-22 at 11:00 +0200, Giuseppe CAVALLARO wrote: Hello Tien Hock On 6/21/2016 10:46 AM, th...@altera.com wrote: From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of

[PATCH V2 3/3] vhost: device IOTLB API

2016-06-23 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of DMA remapping. The idea is simple, cache the translation in a software device IOTLB (which was implemented as interval tree) in vhost and use vhost_net file

[PATCH V2 2/3] vhost: convert pre sorted vhost memory array to interval tree

2016-06-23 Thread Jason Wang
Current pre-sorted memory region array has some limitations for future device IOTLB conversion: 1) need extra work for adding and removing a single region, and it's expected to be slow because of sorting or memory re-allocation. 2) need extra work of removing a large range which may intersect

[PATCH V2 1/3] vhost: introduce vhost memory accessors

2016-06-23 Thread Jason Wang
This patch introduces vhost memory accessors which were just wrappers for userspace address access helpers. This is a requirement for vhost device iotlb implementation which will add iotlb translations in those accessors. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

2016-06-23 Thread Leon Romanovsky
On Thu, Jun 23, 2016 at 08:27:01AM +0300, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > > The logging macros create a bit of duplicated code/text. > > > > Use specialized functions to reduce the duplication. > > > > (defconfig/x86-64) > > $ size

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-23 Thread Richard Weinberger
Am 23.06.2016 um 09:40 schrieb David Miller: > From: Richard Weinberger > Date: Thu, 23 Jun 2016 00:15:04 +0200 > >> On Thu, Jun 16, 2016 at 7:51 PM, Tom Herbert wrote: >>> Transports over UDP is intended to encapsulate TCP and other transport

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

2016-06-23 Thread Saeed Mahameed
On Wed, Jun 22, 2016 at 9:23 PM, Joe Perches wrote: [...] > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c > @@ -1557,3 +1557,37 @@ static void __exit cleanup(void) > > module_init(init); > module_exit(cleanup); > +

Re: r8169 regression: UDP packets dropped intermittantly

2016-06-23 Thread Jonathan Woithe
On Thu, Jun 23, 2016 at 01:22:50AM +0200, Francois Romieu wrote: > Jonathan Woithe : > [...] > > to mainline (in which case I'll keep watching out for it)? Or is the > > out-of-tree workaround mentioned above considered to be the long term > > fix for those who encounter

Re: [Patch net 1/2] act_ife: only acquire tcf_lock for existing actions

2016-06-23 Thread Jamal Hadi Salim
On 16-06-20 04:37 PM, Cong Wang wrote: Alexey reported that we have GFP_KERNEL allocation when holding the spinlock tcf_lock. Actually we don't have to take that spinlock for all the cases, especially for the new one we just create. To modify the existing actions, we still need this spinlock to

Re: [Patch net 2/2] act_ife: acquire ife_mod_lock before reading ifeoplist

2016-06-23 Thread Jamal Hadi Salim
On 16-06-20 04:37 PM, Cong Wang wrote: Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

2016-06-23 Thread Daniel Borkmann
Hi Martin, [ sorry to jump late in here, on pto currently ] On 06/22/2016 11:17 PM, Martin KaFai Lau wrote: Add a BPF_MAP_TYPE_CGROUP_ARRAY and its bpf_map_ops's implementations. To update an element, the caller is expected to obtain a cgroup2 backed fd by open(cgroup2_dir) and then update the

Re: [PATCH net-next v2 4/4] cgroup: bpf: Add an example to do cgroup checking in BPF

2016-06-23 Thread Daniel Borkmann
On 06/22/2016 11:17 PM, Martin KaFai Lau wrote: test_cgrp2_array_pin.c: A userland program that creates a bpf_map (BPF_MAP_TYPE_GROUP_ARRAY), pouplates/updates it with a cgroup2's backed fd and pins it to a bpf-fs's file. The pinned file can be loaded by tc and then used by the bpf prog later.

[REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-23 Thread Arjun V.
Hi all, The following patch introduced a regression in Chelsio cxgb4 driver, causing port failure when running heavy TSO traffic: commit 10d3be569243def8d92ac3722395ef5a59c504e6 Author: Eric Dumazet Date: Thu Apr 21 10:55:23 2016 -0700 tcp-tso: do not split TSO

Re: [PATCH iptables 1/3] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-06-23 Thread Pablo Neira Ayuso
Not specifically related to this patch. It would be great if you can send us a patch to add new tests to iptables/extensions/libxt_hashlimit.t for this new higher resolution pps ratelimit. Thanks!

Re: esp: Fix ESN generation under UDP encapsulation

2016-06-23 Thread Steffen Klassert
On Thu, Jun 23, 2016 at 04:25:21AM +, Blair Steven wrote: > This change tests okay in my setup. > > Thanks very much > -Blair David, can you please take this patch directly in the net tree? This is a candidate for stable. Acked-by: Steffen Klassert

[PATCH 1/3] can: fix handling of unmodifiable configuration options fix

2016-06-23 Thread Marc Kleine-Budde
From: Oliver Hartkopp With upstream commit bb208f144cf3f59 (can: fix handling of unmodifiable configuration options) a new can_validate() function was introduced. When invoking 'ip link set can0 type can' without any configuration data can_validate() tries to validate

[PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Marc Kleine-Budde
From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a private dellink function for the CAN device driver

pull-request: can 2016-06-23

2016-06-23 Thread Marc Kleine-Budde
-20160623 for you to fetch changes up to 71873a9b38d1cc6c93e2962149a7bb7272a7cb66: can: kvaser_usb: Add support for more Kvaser Leaf v2 devices (2016-06-23 11:16:41 +0200) linux-can-fixes-for-4.7-20160623

pull-request: can-next 2016-06-17

2016-06-23 Thread Marc Kleine-Budde
://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.8-20160623 for you to fetch changes up to b63f69d0fc1fa1e25842a2266633862d523c380f: can: mcp251x: add message about sucessful/unsuccessful probe (2016-06-23 11:23:49 +0200

Re: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Johannes Berg
On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote: > Changed the configuration to support 64bit instead of 32bit > this in order to offload the driver from handling a wraparound. [...] Since you Cc'ed me, and presumably want me to review it, I'll say that this looks like a terrible idea: >

[PATCH 3/3] can: kvaser_usb: Add support for more Kvaser Leaf v2 devices

2016-06-23 Thread Marc Kleine-Budde
From: Jimmy Assarsson This patch adds support for Kvaser Leaf Light HS v2 OEM, Mini PCI Express 2xHS and USBcan Light 2xHS. Signed-off-by: Jimmy Assarsson Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/Kconfig

4.4 stable request for net: macb: fix default configuration for GMAC on AT91

2016-06-23 Thread Cyrille Pitchen
Hi David, For 4.4 -stable, can you please consider commit: commit 6bdaa5e9ed39b3b3328f35d218e8ad5a99cfc4d2 Author: Nicolas Ferre Date: Thu Mar 10 16:44:32 2016 +0100 net: macb: fix default configuration for GMAC on AT91 On AT91 SoCs, the User Register

Re: [PATCH iproute2 net-next v4 0/5] bridge: json support for fdb and vlan show

2016-06-23 Thread Roopa Prabhu
On Wed, Jun 22, 2016 at 1:00 PM, Jiri Pirko wrote: > Wed, Jun 22, 2016 at 08:10:47PM CEST, step...@networkplumber.org wrote: >>On Wed, 22 Jun 2016 16:53:44 +0200 >>Jiri Pirko wrote: >> >>> Wed, Jun 22, 2016 at 03:45:50PM CEST, ro...@cumulusnetworks.com wrote:

Re: [PATCHv2,1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le

2016-06-23 Thread Michael Ellerman
On Wed, 2016-22-06 at 16:25:01 UTC, "Naveen N. Rao" wrote: > Classic BPF JIT was never ported completely to work on little endian > powerpc. However, it can be enabled and will crash the system when used. > As such, disable use of BPF JIT on ppc64le. > > Reported-by: Thadeu Lima de Souza Cascardo

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-23 Thread Henrik Austad
On Tue, Jun 21, 2016 at 10:45:18AM -0700, Pierre-Louis Bossart wrote: > On 6/20/16 5:18 AM, Richard Cochran wrote: > >On Mon, Jun 20, 2016 at 01:08:27PM +0200, Pierre-Louis Bossart wrote: > >>The ALSA API provides support for 'audio' timestamps (playback/capture rate > >>defined by audio

Re: [PATCH 2/3] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

2016-06-23 Thread Pablo Neira Ayuso
On Wed, Jun 01, 2016 at 08:11:38PM -0400, Vishwanath Pai wrote: > +static void > +cfg_copy(struct hashlimit_cfg2 *to, void *from, int revision) > +{ > + if (revision == 1) { > + struct hashlimit_cfg1 *cfg = (struct hashlimit_cfg1 *)from; > + > + to->mode = cfg->mode; >

RE: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

2016-06-23 Thread Yuval Mintz
> > My systems are presently in the midst of an install but I should be > > able to demonstrate it in the morning (US Pacific time, modulo the > > shuttle service of a car repair place) > > stack@np-cp1-comp0002-mgmt:~$ ./netperf -H np-cp1-comp0001-guest -- -G > 1400 -P 12867 -O

[PATCH] Bridge: Fix ipv6 mc snooping if it has no ipv6 address.

2016-06-23 Thread daniel
The bridge is falsly dropping ipv6 mulitcast packets if there is no ipv6 address assigned on the brigde and no external mld querier is present. When the bridge fails to build mld queries, because it has no ipv6 address, it silently returns, but keeps the local querier enabled.

Re: [PATCH net-next v2 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

2016-06-23 Thread Daniel Borkmann
On 06/22/2016 11:17 PM, Martin KaFai Lau wrote: Adds a bpf helper, bpf_skb_in_cgroup, to decide if a skb->sk belongs to a descendant of a cgroup2. It is similar to the feature added in netfilter: commit c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match") The user is expected to

Re: [PATCH v2] netfilter: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2016-06-23 Thread Pablo Neira Ayuso
On Thu, Jun 02, 2016 at 10:59:56AM +0800, Xiubo Li wrote: > Since we cannot make sure that the 'hook_mask' will always be none > zero here. If it equals to zero, the num_hooks will be zero too, > and then kmalloc() will return ZERO_SIZE_PTR, which is (void *)16. > > Then the following error check

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-06-23 Thread Pablo Neira Ayuso
On Wed, Jun 01, 2016 at 08:17:59PM -0400, Vishwanath Pai wrote: > libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit > > Add the following iptables rule. > > $ iptables -A INPUT -m hashlimit --hashlimit-above 200/sec \ > --hashlimit-burst 5 --hashlimit-mode srcip

[PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Yaniv Machani
Changed the configuration to support 64bit instead of 32bit this in order to offload the driver from handling a wraparound. Signed-off-by: Yaniv Machani --- drivers/net/wireless/ti/wl18xx/event.c | 26 +- drivers/net/wireless/ti/wl18xx/event.h | 19

[PATCH] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-23 Thread Grygorii Strashko
TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using genalloc and add desc_num property for each

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Oliver Hartkopp
On 06/23/2016 02:55 PM, Sergei Shtylyov wrote: Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-23 Thread ivan.khoronzhuk
On 23.06.16 15:36, Grygorii Strashko wrote: TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using

Re: [PATCH net] ipv6: allows gracefull fallback from table lookup

2016-06-23 Thread Paolo Abeni
On Thu, 2016-06-23 at 15:11 +0200, Paolo Abeni wrote: > with the commit 8c14586fc320 ("net: ipv6: Use passed in table for > nexthop lookups"), net hop lookup is first performed on route creation > in the passed-in table. > However device match is not enforced in table lookup, so the found > route

Re: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Johannes Berg
> > Additionally, this looks like it changes the firmware API, so that  > > older firmware images will no longer work? > > It is backwards compatible,  > although it changes a API structure, older firmware are using only > u16 for the field so there is no impact on that. > Oh, ok. I had also

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-23 Thread Eric Dumazet
On Thu, Jun 23, 2016 at 3:08 AM, Arjun V. wrote: > Hi all, > > The following patch introduced a regression in Chelsio cxgb4 driver, causing > port failure when running heavy TSO traffic: > > commit 10d3be569243def8d92ac3722395ef5a59c504e6 > Author: Eric Dumazet

Re: [RFC v2 3/3] vsockmon: Add vsock hooks

2016-06-23 Thread Sergei Shtylyov
Hello. On 6/22/2016 7:11 PM, ggar...@abra.uab.cat wrote: From: Gerard Garcia Signed-off-by: Gerard Garcia --- drivers/vhost/vsock.c | 73 +++ 1 file changed, 73 insertions(+) diff --git

RE: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Machani, Yaniv
On Thu, Jun 23, 2016 at 14:18:00, Johannes Berg wrote: > linux-wirel...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH] wlcore: time sync : add support for 64 bit clock > > On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote: > > Changed the configuration to support 64bit

[PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected_output

2016-06-23 Thread Abdelrhman Ahmed
neigh_resolve_output and neigh_connected_output resets the skb to network_header because of the retry loop and this reset will pull down the data pointer to the network header in the first iteration then hardware header will be added, but it will overwrite any data which is inserted between

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Sergei Shtylyov
Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch

[PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread Paolo Abeni
with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded due to egress device mismatch and no

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Roopa Prabhu
On 6/22/16, 10:40 PM, Jiri Pirko wrote: > Wed, Jun 22, 2016 at 09:32:25PM CEST, ro...@cumulusnetworks.com wrote: >> On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> The problem we try to handle is about offloaded forwarded

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Jiri Pirko
Thu, Jun 23, 2016 at 01:27:35PM CEST, ro...@cumulusnetworks.com wrote: >On 6/22/16, 10:40 PM, Jiri Pirko wrote: >> Wed, Jun 22, 2016 at 09:32:25PM CEST, ro...@cumulusnetworks.com wrote: >>> On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: From: Jiri Pirko

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-23 Thread Ivan Khoronzhuk
On 23.06.16 15:36, Grygorii Strashko wrote: TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Sergei Shtylyov
On 6/23/2016 4:01 PM, Oliver Hartkopp wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a

[PATCH net] ipv6: allows gracefull fallback from table lookup

2016-06-23 Thread Paolo Abeni
with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded due to egress device mismatch and no

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-23 Thread Richard Cochran
On Thu, Jun 23, 2016 at 12:38:48PM +0200, Henrik Austad wrote: > Richard: is it fair to assume that if ptp4l is running and is part of a PTP > domain, ktime_get() will return PTP-adjusted time for the system? No. > Or do I also need to run phc2sys in order to sync the system-time > to PTP-time?

[PATCH net-next 3/5] phy: separate swphy state validation from register generation

2016-06-23 Thread Russell King
Separate out the generation of MII registers from the state validation. This allows us to simplify the error handing in fixed_phy() by allowing earlier error detection. Reviewed-by: Florian Fainelli Signed-off-by: Russell King ---

[PATCH net-next 1/5] phy: move fixed_phy MII register generation to a library

2016-06-23 Thread Russell King
Move the fixed_phy MII register generation to a library to allow other software phy implementations to use this code. Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/Kconfig | 4 ++ drivers/net/phy/Makefile

[PATCH net-next 0/5] Initial SFP support patches

2016-06-23 Thread Russell King - ARM Linux
Hi David, Please review and merge this initial patch set, which is part of a larger set previously posted adding SFP support to phy and mvneta. This initial set are focused on cleaning up and reorganising the fixed-phy code to allow the core software-phy code to be re-used. These are based on

[PATCH net-next 2/5] phy: convert swphy register generation to tabular form

2016-06-23 Thread Russell King
Convert the swphy register generation to tabular form which allows us to eliminate multiple switch() statements. This results in a smaller object code size, more efficient, and easier to add support for faster speeds. Before: Idx Name Size VMA LMA File off Algn 0

[PATCH net-next 4/5] phy: generate swphy registers on the fly

2016-06-23 Thread Russell King
Generate software phy registers as and when requested, rather than duplicating the state in fixed_phy. This allows us to eliminate the duplicate storage of of the same data, which is only different in format. As fixed_phy_update_regs() no longer updates register state, rename it to

[PATCH net-next 5/5] phy: improve safety of fixed-phy MII register reading

2016-06-23 Thread Russell King
There is no prevention of a concurrent call to both fixed_mdio_read() and fixed_phy_update_state(), which can result in the state being modified while it's being inspected. Fix this by using a seqcount to detect modifications, and memcpy()ing the state. We remain slightly naughty here, calling

[PATCH] dsa: mv88e6xxx: hide unused functions

2016-06-23 Thread Arnd Bergmann
When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused functions whose only callers are all inside of an #ifdef: drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function] drivers/net/dsa/mv88e6xxx.c:3244:12:

Re: [PATCH] dsa: mv88e6xxx: hide unused functions

2016-06-23 Thread Vivien Didelot
Hi, Arnd Bergmann writes: > When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused > functions whose only callers are all inside of an #ifdef: > > drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but > not used [-Werror=unused-function] >

[PATCH] vsock: make listener child lock ordering explicit

2016-06-23 Thread Stefan Hajnoczi
There are several places where the listener and pending or accept queue child sockets are accessed at the same time. Lockdep is unhappy that two locks from the same class are held. Tell lockdep that it is safe and document the lock ordering. Originally Claudio Imbrenda

vmw_vsock sk_ack_backlog double decrement bug

2016-06-23 Thread Stefan Hajnoczi
Hi Jorgen, virtio-vsock doesn't use vsock_pending_work() but I may have spotted a problem that affects the VMCI transport. I'm not sending a patch because I can't test it. 1. During vsock_accept() listener->sk_ack_backlog is decremented. 2. vsock_pending_work() will decrement

Re: [PATCH net-next 0/4] net_sched: bulk dequeue and deferred drops

2016-06-23 Thread Jesper Dangaard Brouer
On Wed, 22 Jun 2016 09:49:48 -0700 Eric Dumazet wrote: > On Wed, 2016-06-22 at 17:44 +0200, Jesper Dangaard Brouer wrote: > > On Wed, 22 Jun 2016 07:55:43 -0700 > > Eric Dumazet wrote: > > > > > On Wed, 2016-06-22 at 16:47 +0200, Jesper

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread David Ahern
On 6/23/16 8:20 AM, David Ahern wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 969913d..520b788 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1782,7 +1782,7 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net, }; struct fib6_table *table;

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread David Ahern
On 6/23/16 7:25 AM, Paolo Abeni wrote: with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded

Re: rstpd implementation

2016-06-23 Thread Phil
On 06/22/2016 08:12 PM, Stephen Hemminger wrote: On Wed, 22 Jun 2016 12:44:52 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: Phil writes: Hi, When looking for an RSTP daemon I found Stephen Hemminger's

[PATCH net-next V2 00/10] Mellanox 100G mlx5e Ethernet extensions

2016-06-23 Thread Saeed Mahameed
Hi Dave, This series includes multiple features extensions for mlx5 Ethernet netdevice driver. Namely, TX Rate limiting, RX interrupt moderation, ethtool settings. TX Rate limiting: - ConnectX-4 rate limiting infrastructure - Set max rate NDO support RX interrupt moderation:

[PATCH net-next V2 05/10] net/mlx5e: Support adaptive RX coalescing

2016-06-23 Thread Saeed Mahameed
From: Gil Rockah Striving for high message rate and low interrupt rate. Usage: ethtool -C adaptive-rx on/off Signed-off-by: Gil Rockah Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed CC:

Re: [Patch net 0/2] net_sched: bug fixes for ife action

2016-06-23 Thread David Miller
From: Cong Wang Date: Mon, 20 Jun 2016 13:37:17 -0700 > Cong Wang (2): > act_ife: only acquire tcf_lock for existing actions > act_ife: acquire ife_mod_lock before reading ifeoplist Series applied, thanks.

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Jiri Pirko
Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: > we can't separate CPU and HW stats there. In some cases (or ASICs) HW > counters do > not include CPU generated packetsyou will have to add CPU > generated pkt counters to the > hw counters for

[PATCH net-next V2 02/10] net/mlx5e: Add TXQ set max rate support

2016-06-23 Thread Saeed Mahameed
From: Yevgeny Petrilin Implement set_maxrate ndo. Use the rate index from the hardware table to attach to channel SQ/TXQ. In case of failure to configure new rate, the queue remains with unlimited rate. We save the configuration on priv structure and apply it each time

[PATCH net-next V2 09/10] net/mlx5e: Use new ethtool get/set link ksettings API

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Use new get/set link ksettings and remove get/set settings legacy callbacks. This allows us to use bitmasks longer than 32 bit for supported and advertised link modes and use modes that were previously not supported. Signed-off-by: Gal Pressman

[PATCH net-next V2 01/10] net/mlx5: Rate limit tables support

2016-06-23 Thread Saeed Mahameed
From: Yevgeny Petrilin Configuring and managing HW rate limit tables. The HW holds a table of rate limits, each rate is associated with an index in that table. Later a Send Queue uses this index to set the rate limit. Multiple Send Queues can have the same rate limit,

[PATCH net-next V2 10/10] net/mlx5e: Report correct auto negotiation and allow toggling

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Previous to this patch auto negotiation was reported off although it was on by default in hardware. This patch reports the correct information to ethtool and allows the user to toggle it on/off. Added another parameter to set port proto function in order to

[PATCH net-next V2 04/10] net/mlx5e: CQE based moderation

2016-06-23 Thread Saeed Mahameed
From: Tariq Toukan In this mode the moderation timer will restart upon new completion (CQE) generation rather than upon interrupt generation. The outcome is that for bursty traffic the period timer will never expire and thus only the moderation frames counter will dictate

[PATCH net-next V2 08/10] net/mlx5e: Add missing 50G baseSR2 link mode

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Add MLX5E_50GBASE_SR2 as ETHTOOL_LINK_MODE_5baseSR2_Full_BIT. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Cc: Ben Hutchings Cc: David Decotigny ---

[PATCH net-next V2 03/10] net/mlx5e: Introduce net device priv flags infrastructure

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Introduce an infrastructure for getting/setting private net device flags. Currently a 'nop' priv flag is added, following patches will override the flag will actual feature specific flags. Signed-off-by: Gal Pressman Signed-off-by:

[PATCH net-next V2 06/10] net/mlx5e: Toggle link only after modifying port parameters

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Add a dedicated function to toggle port link. It should be called only after setting a port register. Toggle will set port link to down and bring it back up in case that it's admin status was up. Signed-off-by: Gal Pressman

[PATCH net-next V2 07/10] ethtool: Add 50G baseSR2 link mode

2016-06-23 Thread Saeed Mahameed
From: Gal Pressman Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT bit. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Cc: Ben Hutchings Cc: David Decotigny ---

Re: esp: Fix ESN generation under UDP encapsulation

2016-06-23 Thread David Miller
From: Steffen Klassert Date: Thu, 23 Jun 2016 12:40:07 +0200 > On Thu, Jun 23, 2016 at 04:25:21AM +, Blair Steven wrote: >> This change tests okay in my setup. >> >> Thanks very much >> -Blair > > David, can you please take this patch directly in the net tree?

Re: [PATCH] mpls: Add missing RCU-bh read side critical section locking in output path

2016-06-23 Thread David Miller
From: Lennert Buytenhek Date: Mon, 20 Jun 2016 21:05:27 +0300 > From: David Barroso > > When locally originated IP traffic hits a route that says to push > MPLS labels, we'll get a call chain dst_output() -> lwtunnel_output() > -> mpls_output() ->

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

2016-06-23 Thread Paolo Abeni
On Thu, 2016-06-23 at 08:29 -0600, David Ahern wrote: > On 6/23/16 8:20 AM, David Ahern wrote: > >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > >> index 969913d..520b788 100644 > >> --- a/net/ipv6/route.c > >> +++ b/net/ipv6/route.c > >> @@ -1782,7 +1782,7 @@ static struct rt6_info > >>

Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

2016-06-23 Thread David Miller
From: Zhao Qiang Date: Thu, 23 Jun 2016 09:09:45 +0800 > +MODULE_DESCRIPTION(DRV_DESC); There is no definition of DRV_DESC, so this makes it look like you didn't even compile this driver.

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Anuradha Karuppiah
we can't separate CPU and HW stats there. In some cases (or ASICs) HW counters do not include CPU generated packetsyou will have to add CPU generated pkt counters to the hw counters for such virtual device stats. >>> Can you please provide and example how that could

Re: [PATCH] Bridge: Fix ipv6 mc snooping if it has no ipv6 address.

2016-06-23 Thread Linus Lüssing
Hi Daniel, Thanks for submitting this patch here :). On Thu, Jun 23, 2016 at 11:28:55AM +0200, daniel wrote: > The bridge is falsly dropping ipv6 mulitcast packets > if there is no ipv6 address assigned on the brigde and no > external mld querier is present. and if the bridge internal querier

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

2016-06-23 Thread Joe Perches
On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > There is code duplication of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment

Re: [PATCH net-next] ti_cpsw: Check for disabled child nodes

2016-06-23 Thread David Miller
From: Ben Hutchings Date: Tue, 21 Jun 2016 01:16:31 +0100 > Dual MAC devices don't necessarily have both MACs wired up, so ignore > those that are disabled. > > Signed-off-by: Ben Hutchings Applied.

Re: [PATCH] net: vrf: replace hard tab with space in assignment

2016-06-23 Thread David Miller
From: Chris Packham Date: Tue, 21 Jun 2016 15:39:43 +1200 > The assignment of rth->dst.output in vrf_rt6_create() and > vrf_rtable_create() used a hard tab before the '='. The neighboring > assignments did not. Make the assignment of rth->dst.output consistent

Re: [PATCH v4 00/19] CALIPSO Implementation

2016-06-23 Thread David Miller
From: Huw Davies Date: Tue, 21 Jun 2016 10:55:48 +0100 > On Tue, Jun 21, 2016 at 05:39:28AM -0400, David Miller wrote: >> From: Huw Davies >> Date: Mon, 20 Jun 2016 14:36:40 +0100 >> >> > This patch series implements RFC 5570 - Common Architecture

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Oliver Hartkopp
On 06/23/2016 03:09 PM, Sergei Shtylyov wrote: +static void can_dellink(struct net_device *dev, struct list_head *head) +{ +return; Why? http://marc.info/?l=linux-can=146651600421205=2 The same reason as for commit 993e6f2fd. I was asking just about the useless *return*

Re: [PATCH v2 2/2] netfilter/nflog: nflog-range does not truncate packets (userspace)

2016-06-23 Thread Pablo Neira Ayuso
On Tue, Jun 21, 2016 at 03:02:16PM -0400, Vishwanath Pai wrote: > netfilter/nflog: nflog-range does not truncate packets > > The option --nflog-range has never worked, but we cannot just fix this > because users might be using this feature option and their behavior would > change. Instead add a

[ PATCH] usbnet.c mtu change needs to stop RX

2016-06-23 Thread Soohoon Lee
When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 61ba464..e03e3e6 100644 ---

Re: [PATCH net-next] net: dsa: b53: Fix statistics readings

2016-06-23 Thread David Miller
From: Florian Fainelli Date: Mon, 20 Jun 2016 18:26:53 -0700 > Due to a typo we would always be using the MIB counter width of the > first element of the counter array instead of the current element, and > we would always be accessing the register statistics with a 64-bits

Re: [PATCH net] netem: fix a use after free

2016-06-23 Thread David Miller
From: Eric Dumazet Date: Mon, 20 Jun 2016 15:00:43 -0700 > From: Eric Dumazet > > If the packet was dropped by lower qdisc, then we must not > access it later. > > Save qdisc_pkt_len(skb) in a temp variable. > > Fixes: 2f5fb43f ("net_sched:

Re: [PATCH net-next V2 07/10] ethtool: Add 50G baseSR2 link mode

2016-06-23 Thread David Decotigny
On Thu, Jun 23, 2016 at 7:02 AM, Saeed Mahameed wrote: > From: Gal Pressman > > Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT bit. > > Signed-off-by: Gal Pressman > Signed-off-by: Saeed Mahameed > Cc: Ben Hutchings

  1   2   >