Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 6/29/2016 11:25 PM, Jiri Pirko wrote: Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: On 16-06-29 08:35 PM, John Fastabend wrote: On 16-06-29 03:09 PM, John Fastabend wrote: On 16-06-29 02:33 PM, Or Gerlitz wrote: On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend

[no subject]

did you get my mail..?

Re: [net-next PATCH 1/2] net: pktgen: support injecting packets for qdisc testing

On 16-06-29 03:47 PM, John Fastabend wrote: Add another xmit_mode to pktgen to allow testing xmit functionality of qdiscs. The new mode "queue_xmit" injects packets at __dev_queue_xmit() so that qdisc is called. Signed-off-by: John Fastabend --- net/core/pktgen.c

[PATCH] usbnet: add reset_resume quirk to prevent resume failure

Ideally, usbnet_resume is sufficient for device resume operation. since usbcore function usb_resume_device() sets udev->reset_resume flag as a quirk solution, reset_resume() quirk we can keep in class driver also. We checked on dongle DA-Queen UFE20C, without reset function resume operation

Re: [RFC v2 1/3] vsockmon: Add tap functions

On Wed, Jun 22, 2016 at 06:11:00PM +0200, ggar...@abra.uab.cat wrote: > +int __vsock_remove_tap(struct vsock_tap *vt) { This function should be static, it's not used outside this source file. > +static int __vsock_deliver_tap_skb(struct sk_buff *skb, > + struct

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-29 18:59 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > [...] >>Thanks for the patch. I have been now testing it and the reselection >>seems to be working now in most cases, but I hit one case that seems >>to consistently fail

RE: [patch] be2net: signedness bug in be_msix_enable()

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > "num_vec" needs to be signed for the error handling to work. > > Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts') > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support

Hi, On Monday 06 June 2016 06:11 PM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason

Re: [PATCH] tcp: add an ability to dump and restore window parameters

From: Andrey Vagin Date: Mon, 27 Jun 2016 15:33:56 -0700 > We found that sometimes a restored tcp socket doesn't work. > > A reason of this bug is incorrect window parameters and in this case > tcp_acceptable_seq() returns tcp_wnd_end(tp) instead of tp->snd_nxt. The > other

Re: [PATCH V6 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: Date: Wed, 29 Jun 2016 02:10:13 -0700 > +static void auto_nego_timer_callback(unsigned long data) > +{ > + u16 val = 0; > + u16 speed = 0; > + u16 duplex = 0; > + > + struct tse_pcs *pcs = (struct tse_pcs *)data; > + void __iomem *tse_pcs_base =

Re: [PATCH] [linux-next] net: netcp: Fix a typo in keystone-netcp.txt

From: Masanari Iida Date: Wed, 29 Jun 2016 23:36:20 +0900 > This patch fix a spelling typo in keystone-netcp.txt > > Signed-off-by: Masanari Iida Applied.

[PATCH net] bonding: prevent out of bound accesses

From: Eric Dumazet ether_addr_equal_64bits() requires some care about its arguments, namely that 8 bytes might be read, even if last 2 byte values are not used. KASan detected a violation with null_mac_addr and lacpdu_mcast_addr in bond_3ad.c Fixes: 815117adaf5b ("bonding:

Re: [patch] be2net: signedness bug in be_msix_enable()

From: Dan Carpenter Date: Wed, 29 Jun 2016 17:39:43 +0300 > "num_vec" needs to be signed for the error handling to work. > > Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts') > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked

On Tue, Jun 28, 2016 at 09:01:12AM -0400, David Miller wrote: > From: Joe Perches > Date: Fri, 24 Jun 2016 11:32:26 -0700 > > > There are code duplications of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o

Re: [PATCH v4] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

From: Mateusz Bajorski Date: Wed, 29 Jun 2016 09:22:10 +0200 > When adding rule with NLM_F_EXCL flag then check if the same rule exist. > If yes then exit with -EEXIST. > > This is already implemented in iproute2: > if (cmd == RTM_NEWRULE) { >

Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui Date: Wed, 29 Jun 2016 11:30:40 + > @@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct > vmbus_channel *channel) > } > > > +struct vmpipe_proto_header { > + u32 pkt_type; It is wasteful to have two empty lines before this

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2016-06-29

From: Jeff Kirsher Date: Wed, 29 Jun 2016 09:30:02 -0700 > This series contains fixes to e1000e and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

Thu, Jun 30, 2016 at 09:57:21AM CEST, john.fastab...@gmail.com wrote: >On 16-06-30 12:41 AM, Jiri Pirko wrote: >> Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: >>> >>> >>> On 6/29/2016 11:25 PM, Jiri Pirko wrote: Thu, Jun 30, 2016 at 06:04:39AM CEST,

Re: [RFC v2 3/3] vsockmon: Add vsock hooks

On Wed, Jun 22, 2016 at 06:11:02PM +0200, ggar...@abra.uab.cat wrote: > + hdr = (struct af_vsockmon_hdr *) skb_push(skb, sizeof(*hdr)); > + > + hdr->src_cid = pkt->hdr.src_cid; > + hdr->src_port = pkt->hdr.src_port; > + hdr->dst_cid = pkt->hdr.dst_cid; > + hdr->dst_port =

Re: [PATCH V2 net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

From: "Seymour, Shane M" Date: Tue, 28 Jun 2016 23:06:48 + > In previous commit 01f83d69844d307be2aa6fea88b0e8fe5cbdb2f4 > the following comments were added: > > "When peer uses tiny windows, there is no use in packetizing to sub-MSS > pieces for the sake of SWS or

Re: [PATCH V2 0/4] net-next: mediatek: IRQ cleanups, fixes and grouping

From: John Crispin Date: Wed, 29 Jun 2016 13:38:07 +0200 > This series contains 2 small code cleanups that are leftovers from the > MIPS support. There is also a small fix that adds proper locking to the > code accessing the IRQ registers. Without this fix we saw deadlocks

It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ))

[ resending as a new email, as I'm assuming people do not sort their INBOX via last email on thread, thus my last email is sitting in the bottom of everyone's INBOX ] I've hit this again. Not sure when it started, but I applied my old debug trace_printk() patch (attached) and rebooted

Re: [PATCH v2 net-next 1/9] MAINTAINERS: add maintainers for hns driver

On Thu, 2016-06-30 at 15:25 +0800, Yisen Zhuang wrote: > From: Daode Huang > > This patch adds maintainers for hisilicon network subsystem driver [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h >  F:

[PATCH net-next 0/3] Add option to specify PF parameter for IFLA_VF_MAC

Hi, We're struggling to implement the PCI SR-IOV management features for administering Virtual Functions which represent networking devices using the current Linux APIs. The problem is that these APIs incorporate all sorts of assumptions which don't match chelsio networking cards. For instance,

[PATCH net-next 1/3] net: Add provision to specify pf number while assigning VF mac

Chelsio T4/T5 cards have SR-IOV Capabilities on Physical Functions 0..3 and the administrative Driver(cxgb4) attaches to Physical Function 4. Each of the Physical Functions 0..3 can support up to 16 Virtual Functions. With the current Linux APIs, a 2-Port card would only be able to use the Virtual

[PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address support

Add ndo_set_vf_mac support which allows to set the MAC address for cxgb4vf interfaces from the host. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |3 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 33 ++-

[PATCH net-next iproute2 3/3] ip: Add option to specify PF number associated with the VF

Add options to specify PF number associated with the VF for MAC ACL. The current API assumes that there is one to one mapping between Network Ports, Physical Functions and the SR-IOV Virtual Function. But that's not true in the case of Chelsio, our cards have SR-IOV Capabilities on Physical

Re: [PATCH 1/2] ath10k: remove unused

Sergei Shtylyov writes: > On 6/21/2016 2:45 PM, Chaehyun Lim wrote: > >> is not used anymore, so just remove it. > >s/it/#include/? Fixed that in the pending branch. -- Kalle Valo

Re: [PATCH net-next] cxgb4: Introduce API for sending work requests on ctrl queue via copy

From: Hariprasad Shenai Date: Wed, 29 Jun 2016 09:01:19 +0530 > If the ctrl queue is full, just follows current path by allocating an > skb. If that fails then caller will just have to handle that case as > before. > > Signed-off-by: Hariprasad Shenai

Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, Jun 30, 2016 at 2:56 PM, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a

Re: [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2016-06-29

From: Jeff Kirsher Date: Wed, 29 Jun 2016 14:32:47 -0700 > This series contains updates and fixes to e1000e, igb, ixgbe and > fm10k. A true smorgasbord of changes. Pulled, thanks Jeff.

[PATCH net] net: poll tx timeout only on active tx queues

From: Mohamad Haj Yahia Change the netdev watchdog to poll only the real active tx queues instead of polling all tx queues. The netdev driver doesn't necessarily have to start/stop all the tx queues including the inactive tx queues. Fixes: fd2ea0a79faa ('net: Use queue

Re: [PATCH v2 net] bonding: prevent out of bound accesses

On 30/06/16 16:13, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and

Re: [PATCH net v3] usbnet: Stop RX Q on MTU change

From: soohoon@f5.com Date: Wed, 29 Jun 2016 15:07:21 -0400 > When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() > can fill up the Q at the same time. > Depends on which HCD is down there unlink takes long time then the flush > never ends. > > Signed-off-by: Soohoon Lee

Re: [PATCH net] bonding: prevent out of bound accesses

On 30/06/16 14:56, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and

[PATCH net-next 01/19] rxrpc: Check the source of a packet to a client conn

When looking up a client connection to which to route a packet, we need to check that the packet came from the correct source so that a peer can't try to muck around with another peer's connection. Signed-off-by: David Howells --- net/rxrpc/conn_object.c |4 +++- 1

[PATCH net-next 03/19] rxrpc: Provide more refcount helper functions

Provide refcount helper functions for connections so that the code doesn't touch conn->usage directly. Also provide queueing helper functions so that the queueing of local and connection objects can be fixed later. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h

[PATCH net-next 00/19] rxrpc: Improve conn/call lookup and fix call number generation

lso: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160630 David --- David Howells (18): rxrpc: Check the source of a packet to a cli

Re: [PATCH v2 net] bonding: prevent out of bound accesses

On Thu, Jun 30, 2016 at 4:13 PM, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a

[PATCH net-next 09/19] rxrpc: Release a call's connection ref on call disconnection

When a call is disconnected, clear the call's pointer to the connection and release the associated ref on that connection. This means that the call no longer pins the connection and the connection can be discarded even before the call is. As the code currently stands, the call struct is

[PATCH net-next 04/19] rxrpc: Dup the main conn list for the proc interface

The main connection list is used for two independent purposes: primarily it is used to find connections to reap and secondarily it is used to list connections in procfs. Split the procfs list out from the reap list. This allows the reap list to be phased out in stages as the client conns and

[PATCH net-next 07/19] rxrpc: Move usage count getting into rxrpc_queue_conn()

Rather than calling rxrpc_get_connection() manually before calling rxrpc_queue_conn(), do it inside the queue wrapper. This allows us to do some important fixes: (1) If the usage count is 0, do nothing. This prevents connections from being reanimated once they're dead. (2) If

[PATCH net-next 06/19] rxrpc: Check that the client conns cache is empty before module removal

Check that the client conns cache is empty before module removal and bug if not, listing any offending connections that are still present. Unfortunately, if there are connections still around, then the transport socket is still unexpectedly open and active, so we can't just unallocate the

[PATCH net-next 05/19] rxrpc: Turn connection #defines into enums and put outside struct def

Turn the connection event and state #define lists into enums and move outside of the struct definition. Whilst we're at it, change _SERVER to _SERVICE in those identifiers and add EV_ into the event name to distinguish them from flags and states. Also add a symbol indicating the number of states

Re: [PATCH net-next 00/19] rxrpc: Improve conn/call lookup and fix call number generation

Sigh. It seems I misunderstood the comment on read_seqbegin_or_lock() and failed to initialise seq in rxrpc_find_service_conn_rcu(). For some reason my compiler didn't notice, though Fengguang's magic compile farm did. So, please ignore this version of the patchset and I'll post a new set.

RE: [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address support

> + /* verify MAC addr is valid */ > + if (!is_zero_ether_addr(mac) && !is_valid_ether_addr(mac) && > + is_multicast_ether_addr(mac)) { This is really odd as verification goes; Currently this is a very elaborate way of checking for multicast, but I guess it's probably a mistake.

[PATCH net-next 08/19] rxrpc: Fix handling of connection failure in client call creation

If rxrpc_connect_call() fails during the creation of a client connection, there are two bugs that we can hit that need fixing: (1) The call state should be moved to RXRPC_CALL_DEAD before the call cleanup phase is invoked. If not, this can cause an assertion failure later. (2)

[PATCH net 09/13] net/mlx5e: Handle RQ flush in error cases

From: Daniel Jurgens Add a timeout to avoid an infinite loop waiting for RQ's to flush. This occurs during AER/EEH and will also happen if the device stops posting completions due to internal error or reset, or if moving the RQ to the error state fails. Also cleanup posted

[PATCH net 10/13] net/mlx5e: Copy all L2 headers into inline segment

From: Matthew Finlay ConnectX4-Lx uses an inline wqe mode that currently defaults to requiring the entire L2 header be included in the wqe. This patch fixes mlx5e_get_inline_hdr_size() to account for all L2 headers (VLAN, QinQ, etc) using skb_network_offset(skb). Fixes:

[PATCH net 12/13] net/mlx5e: Validate BW weight values of ETS

From: Rana Shahout Valid weight assigned to ETS TClass values are 1-100 Fixes: 08fb1dacdd76 ('net/mlx5e: Support DCBNL IEEE ETS') Signed-off-by: Rana Shahout Signed-off-by: Saeed Mahameed ---

[PATCH net 04/13] net/mlx5: Fix wait_vital for VFs and remove fixed sleep

From: Daniel Jurgens The device ID for VFs is in a different location than PFs. This results in the poll always timing out for VFs. There's no good way to read the VF device ID without using the PF's configuration space. Switch to waiting for the health poll to start

[PATCH net 08/13] net/mlx5e: Implement ndo_tx_timeout callback

From: Daniel Jurgens Add callback to handle TX timeouts. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed ---

[PATCH net 00/13] Mellanox 100G mlx5 resiliency and xmit path fixes

Hi Dave, This series provides two set of fixes to the mlx5 driver: - Resiliency fixes for reset flow and internal pci errors - xmit path fixes Please consider queuing those patches for -stable (4.6). Reset flow fixes for core driver: - Add more commands to the list of

[PATCH net 11/13] net/mlx5e: Fix select queue callback

From: Rana Shahout The default fallback function used by mlx5e select queue can return any TX queues in range [0..dev->num_real_tx_queues). The current implementation assumes that the fallback function returns a number in the range [0.. number of channels). Actually

[PATCH net 06/13] net/mlx5: Add timeout handle to commands with callback

From: Mohamad Haj Yahia The current implementation does not handle timeout in case of command with callback request, and this can lead to deadlock if the command doesn't get fw response. Add delayed callback timeout work before posting the command to fw. In case of real fw

[PATCH net 03/13] net/mlx5: Fix incorrect page count when in internal error

From: Daniel Jurgens Change page cleanup flow when in internal error to properly decrement the page counts when reclaiming pages. The prevents timing out waiting for extra pages that were actually cleaned up previously. fixes: 89d44f0a6c73 ('net/mlx5_core: Add pci error

[PATCH net 02/13] net/mlx5: Avoid calling sleeping function by the health poll thread

From: Mohamad Haj Yahia In internal error state the health poll thread will eventually call synchronize_irq() (to safely trigger command completions) which might sleep, so we are calling sleeping function from atomic context which is invalid. Here we move

[PATCH net 05/13] net/mlx5: Fix potential deadlock in command mode change

From: Mohamad Haj Yahia Call command completion handler in case of timeout when working in interrupts mode. Avoid flushing the commands workqueue after acquiring the semaphores to prevent a potential deadlock. Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB

Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, 2016-06-30 at 15:35 +0200, Dmitry Vyukov wrote: > > What does nm -S say? > I've tried to compile a sample program with gcc6 and > __attribute__((aligned(8))) does in fact force alignment of start of > the symbol, but size still stays 6. (and asan still barks on my test > program).

[PATCH net-next 10/19] rxrpc: Add RCU destruction for connections and calls

Add RCU destruction for connections and calls as the RCU lookup from the transport socket data_ready handler is going to come along shortly. Whilst we're at it, move the cleanup workqueue flushing and RCU barrierage into the destruction code for the objects that need it (locals and connections)

[PATCH v2 net] bonding: prevent out of bound accesses

From: Eric Dumazet ether_addr_equal_64bits() requires some care about its arguments, namely that 8 bytes might be read, even if last 2 byte values are not used. KASan detected a violation with null_mac_addr and lacpdu_mcast_addr in bond_3ad.c Same problem with mac_bcast[]

[PATCH net-next 13/19] rxrpc: Split client connection code out into its own file

Split the client-specific connection code out into its own file. It will behave somewhat differently from the service-specific connection code, so it makes sense to separate them. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |7 + net/rxrpc/conn_client.c |

[PATCH net-next 02/19] rxrpc: Avoid using stack memory in SG lists in rxkad

From: Herbert Xu rxkad uses stack memory in SG lists which would not work if stacks were allocated from vmalloc memory. In fact, in most cases this isn't even necessary as the stack memory ends up getting copied over to kmalloc memory. This patch eliminates all the

[PATCH net-next 19/19] rxrpc: Use RCU to access a peer's service connection tree

Move to using RCU access to a peer's service connection tree when routing an incoming packet. This is done using a seqlock to trigger retrying of the tree walk if a change happened. Further, we no longer get a ref on the connection looked up in the data_ready handler unless we queue the

[PATCH net-next 17/19] rxrpc: Prune the contents of the rxrpc_conn_proto struct

Prune the contents of the rxrpc_conn_proto struct. Most of the fields aren't used anymore. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h | 20 +++- net/rxrpc/call_object.c |2 +- net/rxrpc/conn_client.c | 11 ---

[PATCH net-next 14/19] rxrpc: Split service connection code out into its own file

Split the service-specific connection code out into into its own file. The client-specific code has already been split out. This will leave just the common code in the original file. Signed-off-by: David Howells --- net/rxrpc/Makefile |1

[PATCH net-next 11/19] rxrpc: Access socket accept queue under right lock

The socket's accept queue (socket->acceptq) should be accessed under socket->call_lock, not under the connection lock. Signed-off-by: David Howells --- net/rxrpc/call_event.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/call_event.c

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On Thu, Jun 30, 2016 at 1:52 PM, Jiri Pirko wrote: > Why not to have 2 modes: > 1) lagacy - the current solution, blackbox eswitch, undefined behaviour > 2) switchdev - with representors, all features possible as on physical > switches, whitebox eswitch configured using

[iproute PATCH] ip-address: constify match_link_kind arg

Since the function won't ever change the data 'kind' is pointing at, it can sanely be made const. Fixes: e0513807f6dbb ("ip-address: Support filtering by slave type, too") Suggested-by: Stephen Hemminger Signed-off-by: Phil Sutter --- ip/ipaddress.c | 2 +- 1

Re: [PATCH net] net: poll tx timeout only on active tx queues

On Thu, Jun 30, 2016 at 5:28 PM, Eric Dumazet wrote: > On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote: >> - for (i = 0; i < dev->num_tx_queues; i++) { >> + for (i = 0; i < dev->real_num_tx_queues; i++) { >>

Re: [PATCH] ipv4: Fix ip_skb_dst_mtu to use the sk passed by ip_finish_output

From: Shmulik Ladkani Date: Wed, 29 Jun 2016 21:47:03 +0300 > ip_skb_dst_mtu uses skb->sk, assuming it is an AF_INET socket (e.g. it > calls ip_sk_use_pmtu which casts sk as an inet_sk). > > However, in the case of UDP tunneling, the skb->sk is not necessarily an >

Re: It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ))

> On Jun 30, 2016, at 08:59, Steven Rostedt wrote: > > [ resending as a new email, as I'm assuming people do not sort their > INBOX via last email on thread, thus my last email is sitting in the > bottom of everyone's INBOX ] > > I've hit this again. Not sure when it

Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, 2016-06-30 at 15:04 +0200, Dmitry Vyukov wrote: > On Thu, Jun 30, 2016 at 2:56 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > ether_addr_equal_64bits() requires some care about its arguments, > > namely that 8 bytes might be read, even

Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, Jun 30, 2016 at 3:25 PM, Eric Dumazet wrote: > On Thu, 2016-06-30 at 15:04 +0200, Dmitry Vyukov wrote: >> On Thu, Jun 30, 2016 at 2:56 PM, Eric Dumazet wrote: >> > From: Eric Dumazet >> > >> > ether_addr_equal_64bits()

Re: [PATCH net] net: poll tx timeout only on active tx queues

On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote: > From: Mohamad Haj Yahia > > Change the netdev watchdog to poll only the real active tx queues > instead of polling all tx queues. > The netdev driver doesn't necessarily have to start/stop all the > tx queues

[PATCH net 07/13] net/mlx5e: Timeout if SQ doesn't flush during close

From: Daniel Jurgens Avoid an infinite loop by timing out waiting for the SQ to flush. Also clean up the TX descriptors if that happens. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Daniel Jurgens

[PATCH net 13/13] net/mlx5e: Log link state changes

From: Shaker Daibes Add Link UP/Down prints to kernel log when link state changes Signed-off-by: Shaker Daibes Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 7 +-- 1 file changed, 5

[PATCH net 01/13] net/mlx5: Fix teardown errors that happen in pci error handler

From: Mohamad Haj Yahia In case of internal error state we will simulate the commands status through the return value translation function, but we need to simulate all the teardown fw commands as successful so we will not have fw command failure prints. This also fix memory

Re: [PATCH net-next 0/3] nfp: few code improvements

From: Jakub Kicinski Date: Wed, 29 Jun 2016 21:55:52 +0100 > Three small patches for net-next. First and second patches > improve the code quality by spelling things correctly and > removing unused parameters. Third patch hooks-in standard > kernel implementation

Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, Jun 30, 2016 at 4:08 PM, Eric Dumazet wrote: > On Thu, 2016-06-30 at 15:35 +0200, Dmitry Vyukov wrote: > >> >> What does nm -S say? >> I've tried to compile a sample program with gcc6 and >> __attribute__((aligned(8))) does in fact force alignment of start of >>

[PATCH net-next 18/19] rxrpc: Move data_ready peer lookup into rxrpc_find_connection()

Move the peer lookup done in input.c by data_ready into rxrpc_find_connection(). Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |3 -- net/rxrpc/conn_object.c | 73 --- net/rxrpc/input.c | 30

RE: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, June 30, 2016 20:45 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

[PATCH net-next 16/19] rxrpc: Maintain an extra ref on a conn for the cache list

Overhaul the usage count accounting for the rxrpc_connection struct to make it easier to implement RCU access from the data_ready handler. The problem is that currently we're using a lock to prevent the garbage collector from trying to clean up a connection that we're contemplating unidling. We

[PATCH net-next 15/19] rxrpc: Move peer lookup from call-accept to new-incoming-conn

Move the lookup of a peer from a call that's being accepted into the function that creates a new incoming connection. This will allow us to avoid incrementing the peer's usage count in some cases in future. Note that I haven't bother to integrate rxrpc_get_addr_from_skb() with

[PATCH net-next 12/19] rxrpc: Call channels should have separate call number spaces

Each channel on a connection has a separate, independent number space from which to allocate callNumber values. It is entirely possible, for example, to have a connection with four active calls, each with call number 1. Note that the callNumber values for any particular channel don't have to

Re: [net-next PATCH v2 1/2] net: pktgen: support injecting packets for qdisc testing

On Wed, 29 Jun 2016 13:03:06 -0700 John Fastabend wrote: > Add another xmit_mode to pktgen to allow testing xmit functionality > of qdiscs. The new mode "queue_xmit" injects packets at > __dev_queue_xmit() so that qdisc is called. > > Signed-off-by: John Fastabend

[PATCH v2 net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang

[PATCH v2 net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- change log: v2: fix the wrong indentations v1: first submit link:

[PATCH v2 net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan

[PATCH v2 net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: > > >On 6/29/2016 11:25 PM, Jiri Pirko wrote: >>Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: >>>On 16-06-29 08:35 PM, John Fastabend wrote: On 16-06-29 03:09 PM, John Fastabend wrote: >On

[PATCH net-next V4 4/6] skb_array: add wrappers for resizing

Signed-off-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- include/linux/skb_array.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index 2dd0d1e..f4dfade 100644 ---

[PATCH net-next V4 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN

This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this will be triggered when tx_queue_len. It could be used by net device who want to do some processing at that time. An example is tun who may want to resize tx array when tx_queue_len is changed. Cc: John Fastabend

[PATCH net-next V4 6/6] tun: switch to use skb array for tx

We used to queue tx packets in sk_receive_queue, this is less efficient since it requires spinlocks to synchronize between producer and consumer. This patch tries to address this by: - switch from sk_receive_queue to a skb_array, and resize it when tx_queue_len was changed. - introduce a new

[PATCH net-next 3/5] qede: Utilize xmit_more

This patch uses xmit_more optimization to reduce number of TX doorbells write per packet. Signed-off-by: Manish Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 37 +--- 1 file changed, 23

[PATCH net-next 1/5] qede: Add support for handling IP fragmented packets.

When handling IP fragmented packets with csum in their transport header, the csum isn't changed as part of the fragmentation. As a result, the packet containing the transport headers would have the correct csum of the original packet, but one that mismatches the actual packet that passes on the

[PATCH net-next 2/5] qede: qede_poll refactoring

This patch cleanups qede_poll() routine a bit and allows qede_poll() to do single iteration to handle TX completion [As under heavy TX load qede_poll() might run for indefinite time in the while(1) loop for TX completion processing and cause CPU stuck]. Signed-off-by: Manish

[PATCH net-next 4/5] qede: Add get/set rx copy break tunable support

Signed-off-by: Manish Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 3 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 46 + drivers/net/ethernet/qlogic/qede/qede_main.c| 3 +-

Re: [PATCH V2 2/4] net-next: mediatek: don't use intermediate variables to store IRQ masks

On 30/06/2016 08:03, kbuild test robot wrote: > Hi, > > [auto build test ERROR on net/master] > [also build test ERROR on v4.7-rc5 next-20160629] > [cannot apply to net-next/master] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

  1   2   3   >