Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Thomas Graf
On 07/07/16 at 10:36pm, Jiri Kosina wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index f45929c..630838e 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > > struct

Re: [PATCH v15 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-08 Thread Cathy Avery
It's too bad about having to allocate the send/receive rings on a per socket basis. Hopefully this will change in the future. I have built kernel 4.7.0-rc6 with this patch and did a quick test on the driver using rhel7 over hyperv Windows Server 2016 TP5. These were basic send and receive

Re: [linux-next] rtlwifi: Fix typo in printk

2016-07-08 Thread Kalle Valo
Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida > Reviewed-by: Julian Calaby Thanks, 1 patch applied to wireless-drivers-next.git: 8a1902374fa0

Re: wcn36xx: Silence error about unsupported smd event 188

2016-07-08 Thread Kalle Valo
Bjorn Andersson wrote: > Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently > ignore this message so let's do the same to silence the error message. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Loganaden Velvindron
On Fri, Jul 8, 2016 at 6:14 PM, Eric Dumazet wrote: > On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: >> I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A >> DDoS with about 300 MBit/sec over 5 mins resulted an issue for ipv6 at >> that system.

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Toralf Förster
On 07/08/2016 04:14 PM, Eric Dumazet wrote: > Are you sure conntrack is needed at all ? Erm, I didn't mention conntrack - but yes, I do have in the firewall rules. It is my understanding that conntrack is best practise, right ? -- Toralf PGP: C4EACDDE 0076E94E, OTR: 420E74C8 30246EE7

Re: XDP seeking input from NIC hardware vendors

2016-07-08 Thread Jakub Kicinski
On Thu, 7 Jul 2016 19:22:12 -0700, Alexei Starovoitov wrote: > > If the goal is to just separate XDP traffic from non-XDP traffic you could > > accomplish this with a combination of SR-IOV/macvlan to separate the device > > queues into multiple netdevs and then run XDP on just one of the

Re: mwifiex: mask PCIe interrupts before removal

2016-07-08 Thread Kalle Valo
Brian Norris wrote: > The PCIe driver didn't mask the host interrupts before trying to tear > down. This causes lockups at reboot or rmmod when using MSI-X on 8997, > since the MSI handler gets confused and locks up the system. > > Also tested on 8897, which does not

Re: [PATCH 2/3] net: smsc911x: request and deassert optional RESET GPIO

2016-07-08 Thread Guenter Roeck
On 07/08/2016 02:07 AM, Linus Walleij wrote: On some systems (such as the Qualcomm APQ8060 Dragonboard) the RESET signal of the SMSC911x is not pulled up by a resistor but connected to a GPIO line, so that the operating system must explicitly deassert RESET before use. Support this in the

Re: [iproute PATCH 0/2] Netns performance improvements

2016-07-08 Thread Brian Haley
On 07/07/2016 01:28 PM, Rick Jones wrote: On 07/07/2016 09:34 AM, Eric W. Biederman wrote: Rick Jones writes: 300 routers is far from the upper limit/goal. Back in HP Public Cloud, we were running as many as 700 routers per network node (*), and more than four network

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: > I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A > DDoS with about 300 MBit/sec over 5 mins resulted an issue for ipv6 at > that system. > > The IPv6 monitoring from my ISP told my that the to be monitored > services

Re: [PATCH 4/4] net: ethernet: ti: cpsw: add ethtool channels support

2016-07-08 Thread Grygorii Strashko
On 06/30/2016 10:04 PM, Ivan Khoronzhuk wrote: > These ops allow to control number of channels driver is allowed to > work with. The maximum number of channels is 8 for rx and 8 for tx. > After this patch the following commands are possible: > > $ ethtool -l eth0 > $ ethtool -L eth0 rx 6 tx 6

Re: [1/2] brcmfmac: delete interface directly in code that sent fw request

2016-07-08 Thread Kalle Valo
Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal our > event worker was notifying listener and afterwards it was removing Linux > interface. > > First of all it was resulting in slightly unexpected order. The listener > (del_virtual_intf callback) was

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-07-08 Thread Roopa Prabhu
On Mon, Jun 27, 2016 at 6:11 AM, Jiri Pirko wrote: > Mon, Jun 27, 2016 at 03:02:31PM CEST, ro...@cumulusnetworks.com wrote: [snip] >> >>The point of the stats api is to bring all stats together. >>ethtool stats are very valuable. so there is no point leaving them out. >>they

Dear Beneficiary,

2016-07-08 Thread Sarah Michael
Dear Beneficiary, I'm happy to inform you that your email address has been selected among those that have compensation payment of ($2.5 Million USD), The INTERNATIONAL MONETARY FUND contacted us for the release of your money a couple of hours ago due to your allocated security code. We are

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-08 Thread Roland Dreier
On Thu, Jul 7, 2016 at 4:14 PM, Jason Gunthorpe wrote: > We have neighbour_priv, and ndo_neigh_construct/destruct now .. > > A first blush that would seem to be enough to let ipoib store the AH > and other path information in the neigh and avoid the cb? At least

ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Toralf Förster
I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A DDoS with about 300 MBit/sec over 5 mins resulted an issue for ipv6 at that system. The IPv6 monitoring from my ISP told my that the to be monitored services (80, 443, 5) weren't reachable any longer at ipv6 (at ipv4 there

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 13:07 +0200, Thomas Graf wrote: > On 07/07/16 at 10:36pm, Jiri Kosina wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index f45929c..630838e 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -52,6 +52,7 @@

Re: [1/6] wcn36xx: Fold indication payload into message header

2016-07-08 Thread Kalle Valo
Bjorn Andersson wrote: > From: Bjorn Andersson > > Merge the two allocation instead of separately allocating room for the > indication payload. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-08 Thread Veli-Matti Lintu
2016-07-08 4:48 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > >>2016-07-06 0:20 GMT+03:00 Jay Vosburgh : >>Thanks for the pointers. Adding some extra debug in __enable_port >>helped me to get in right

RE: [PATCH] net: Fragment large datagrams even when IP_HDRINCL is set.

2016-07-08 Thread Paul Jakma
On Wed, 15 Jun 2016, Alan Davey wrote: The only case that would break is that where an application relies on the existing (documented as a bug) feature of getting an EMSGSIZE return code in the case of an over-sized packet. Applications that perform their own fragmentation would be

Re: [PATCH 2/4] net: ethernet: ti: cpsw: add multi queue support

2016-07-08 Thread Grygorii Strashko
On 06/30/2016 10:04 PM, Ivan Khoronzhuk wrote: > The cpsw h/w supports up to 8 tx and 8 rx channels.This patch adds > multi-queue support to the driver. An ability to configure h/w > shaper will be added with separate patch. Default shaper mode, as > before, priority mode. > > The poll function

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-07-08 Thread Pablo Neira Ayuso
On Wed, Jul 06, 2016 at 06:26:39PM -0400, Vishwanath Pai wrote: > On 07/05/2016 04:13 PM, Vishwanath Pai wrote: > > On 06/25/2016 05:39 AM, Pablo Neira Ayuso wrote: > >> I see, but I'm not convinced about this /proc rename feature. > >> > >> I think the main point of this, as well as other entries

RE: [PATCH net-next v2 0/4] net: support MPLS in IPv4 and UDP

2016-07-08 Thread Manish Chopra
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Simon Horman > Sent: Thursday, July 07, 2016 11:26 AM > To: David Miller > Cc: Tom Herbert ; netdev ; > Simon

[PATCH v2 4/4] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-07-08 Thread Jan Beulich
For single items being collected this should be preferred as being more typesafe (as the compiler can check format string and to-be-written-to variable match) and more efficient (requiring one less parameter to be passed). Signed-off-by: Jan Beulich --- v2: Avoid commit

Re: [PATCH v15 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-08 Thread Vitaly Kuznetsov
Dexuan Cui writes: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. > > With Hyper-V Sockets, applications

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Toralf Förster
On 07/08/2016 04:14 PM, Eric Dumazet wrote: > Hard to tell without knowing DDOS details, but IPv6 lacks some > scalability improvements found in IPv4. Well, not too much I got from my ISP : On 07 Jul 15:42, flow-s...@traffic1.core.hetzner.de wrote: > Direction IN > Internal 5.9.158.75 >

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 10:14, Eric Dumazet wrote: > On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: >> I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A >> DDoS with about 300 MBit/sec over 5 mins resulted an issue for ipv6 at >> that system. >> >> The IPv6 monitoring from my ISP

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 16:34 +0200, Toralf Förster wrote: > On 07/08/2016 04:14 PM, Eric Dumazet wrote: > > Are you sure conntrack is needed at all ? > > Erm, I didn't mention conntrack - but yes, I do have in the firewall rules. > > It is my understanding that conntrack is best practise, right ?

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 11:33, Eric Dumazet wrote: > On Fri, 2016-07-08 at 11:12 -0400, Hannes Frederic Sowa wrote: >> Hi Eric, >> >> On 07.07.2016 12:13, Eric Dumazet wrote: >>> On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: GRO is now handled entirely by the udp_offload layer and there is no

Re: [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-08 Thread Wei Liu
On Thu, Jul 07, 2016 at 01:58:18AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich Acked-by: Wei Liu

Re: [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-08 Thread Wei Liu
On Fri, Jul 08, 2016 at 05:13:49PM +0100, Wei Liu wrote: > On Thu, Jul 07, 2016 at 01:58:18AM -0600, Jan Beulich wrote: > > ... as being the simpler variant. > > > > Signed-off-by: Jan Beulich > > Acked-by: Wei Liu Please ignore this, I acked v2

Re: [Xen-devel] [PATCH v2 4/4] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-07-08 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:28:58AM -0600, Jan Beulich wrote: > For single items being collected this should be preferred as being more > typesafe (as the compiler can check format string and to-be-written-to > variable match) and more efficient (requiring one less parameter to be > passed). > >

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:55 -0400, Hannes Frederic Sowa wrote: > Exactly, thus we are also only touching UDP tunneling protocols at the > moment. Did you nack the removal of gro_cell support from the udp > protocols or are you fine with it, given that we won't take away the > functionality to

Re: [PATCH 7/7] ARM: dts: NSP: Add bgmac entries

2016-07-08 Thread Scott Branden
Hi Jon, In Subject line, you mean add amac entries. On 16-07-08 08:56 AM, Jon Mason wrote: Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 18

Re:Hiking Enthusiasts

2016-07-08 Thread Mike Falk
Hi, A quick note to see if you would be interested in a discussion about would you be interested in reaching out to "Hiking Enthusiasts" from USA? We also have data for:- 1. Camping Enthusiasts 2. Cycling Enthusiasts 3. Boat Owners 4. Skiers 5. Horse Racing

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Toralf Förster
On 07/08/2016 05:38 PM, Eric Dumazet wrote: > With IPv4, a server can typically absorb 10 Mpps SYN without major > disruption on linux-4.6 Well, this particular server even survived >900 MBit/sec w/o any service disruption at IPv4 ([1]) but yesterday with a much more less attack the IPv6 issue

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 18:17 +0400, Loganaden Velvindron wrote: > On Fri, Jul 8, 2016 at 6:14 PM, Eric Dumazet wrote: > > On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: > >> I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A > >> DDoS with about

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

2016-07-08 Thread Jesper Dangaard Brouer
On Fri, 08 Jul 2016 05:56:31 +0200 Eric Dumazet wrote: > On Thu, 2016-07-07 at 19:15 -0700, Brenden Blanco wrote: > > XDP programs read and/or write packet data very early, and cache miss is > > seen to be a bottleneck. > > > > Add prefetch logic in the xdp case 3

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:12 -0400, Hannes Frederic Sowa wrote: > Hi Eric, > > On 07.07.2016 12:13, Eric Dumazet wrote: > > On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: > >> GRO is now handled entirely by the udp_offload layer and there is no need > >> for trying it again at the device

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 11:38, Eric Dumazet wrote: > On Fri, 2016-07-08 at 11:28 -0400, Hannes Frederic Sowa wrote: >> On 08.07.2016 10:14, Eric Dumazet wrote: >>> On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A DDoS with

[PATCH] bnxt_en: initialize rc to zero to avoid returning garbage

2016-07-08 Thread Colin King
From: Colin Ian King rc is not initialized so it can contain garbage if it is not set by the call to bnxt_read_sfp_module_eeprom_info. Ensure garbage is not returned by initializing rc to 0. Signed-off-by: Colin Ian King ---

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:43 -0400, Hannes Frederic Sowa wrote: > Exactly, I can very well imagine that the stack becomes unresponsive > during DDoS, but after the DDoS I don't see a reason why services should > come up like in IPv4. If the service uses different listeners, one for IPV4, one (or

Re: [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support

2016-07-08 Thread Jon Mason
On Thu, Jul 7, 2016 at 7:08 PM, Jon Mason wrote: > David Miller, Please consider including patches 1-5 in net-next > > Florian Fainelli, Please consider including patches 6 & 7 in > devicetree/next Oops. I didn't send out the 7th patch in this series. Sending out

[PATCH net] udp: prevent bugcheck if filter truncates packet too much

2016-07-08 Thread Michal Kubecek
If socket filter truncates an udp packet below the length of UDP header in udpv6_queue_rcv_skb() or udp_queue_rcv_skb(), it will trigger a BUG_ON in skb_pull_rcsum(). This BUG_ON (and therefore a system crash if kernel is configured that way) can be easily enforced by an unprivileged user which

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Hannes Frederic Sowa
Hi Eric, On 07.07.2016 12:13, Eric Dumazet wrote: > On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: >> GRO is now handled entirely by the udp_offload layer and there is no need >> for trying it again at the device level. We can drop gro_cell usage, >> simplifying the driver a bit, while

Re: XDP seeking input from NIC hardware vendors

2016-07-08 Thread Jesper Dangaard Brouer
On Fri, 8 Jul 2016 14:44:53 +0100 Jakub Kicinski wrote: > On Thu, 7 Jul 2016 19:22:12 -0700, Alexei Starovoitov wrote: > > > > If the goal is to just separate XDP traffic from non-XDP traffic > > > you could accomplish this with a combination of SR-IOV/macvlan to

Re: ipv6 issues after an DDoS for kernel 4.6.3

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:28 -0400, Hannes Frederic Sowa wrote: > On 08.07.2016 10:14, Eric Dumazet wrote: > > On Fri, 2016-07-08 at 15:51 +0200, Toralf Förster wrote: > >> I do run a 4.6.3 hardened Gentoo kernel at a commodity i7 server. A > >> DDoS with about 300 MBit/sec over 5 mins resulted an

[PATCH 7/7] ARM: dts: NSP: Add bgmac entries

2016-07-08 Thread Jon Mason
Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 18 ++ arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 26 insertions(+) diff

[net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-08 Thread Jesper Dangaard Brouer
This patch is about prefetching without being opportunistic. The idea is only to start prefetching on packets that are marked as ready/completed in the RX ring. This is acheived by splitting the napi_poll call mlx4_en_process_rx_cq() loop into two. The first loop extract completed CQEs and start

Re: XDP seeking input from NIC hardware vendors

2016-07-08 Thread Jakub Kicinski
On Fri, 8 Jul 2016 17:19:43 +0200, Jesper Dangaard Brouer wrote: > On Fri, 8 Jul 2016 14:44:53 +0100 Jakub Kicinski > wrote: > > On Thu, 7 Jul 2016 19:22:12 -0700, Alexei Starovoitov wrote: > > > > If the goal is to just separate XDP traffic from non-XDP traffic > >

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-08 Thread Jason Gunthorpe
On Fri, Jul 08, 2016 at 07:18:11AM -0700, Roland Dreier wrote: > On Thu, Jul 7, 2016 at 4:14 PM, Jason Gunthorpe > wrote: > > We have neighbour_priv, and ndo_neigh_construct/destruct now .. > > > > A first blush that would seem to be enough to let ipoib store the

Re: [PATCH net-next 2/4] udp offload: allow GRO on 0 checksum packets

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 12:46, Alexander Duyck wrote: > On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: >> currently, UDP packets with zero checksum are not allowed to >> use udp offload's GRO. This patch admits such packets to >> GRO, if the related socket settings allow it: ipv6

RE: [Intel-wired-lan] [PATCH] (resend) ixgbe: always initialize setup_fc

2016-07-08 Thread Tantilov, Emil S
>-Original Message- >From: Patrick McLean [mailto:patri...@gaikai.com] >Sent: Friday, July 08, 2016 9:45 AM >To: zhuyj >Cc: Tantilov, Emil S ; Rustad, Mark D >; netdev ; intel-wired-lan

Re: [PATCH net-next 2/4] udp offload: allow GRO on 0 checksum packets

2016-07-08 Thread Alexander Duyck
On Fri, Jul 8, 2016 at 9:56 AM, Hannes Frederic Sowa wrote: > On 08.07.2016 12:46, Alexander Duyck wrote: >> On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: >>> currently, UDP packets with zero checksum are not allowed to >>> use udp offload's

Re: [Intel-wired-lan] [PATCH] (resend) ixgbe: always initialize setup_fc

2016-07-08 Thread Patrick McLean
How about just initializing it when the rest of the struct is initialized? This is what is done for every other model. On Fri, Jul 8, 2016 at 2:47 AM, zhuyj wrote: > Sure. setup_fc should not be null. Emil, your patch can fix it well. > > On Fri, Jul 8, 2016 at 8:18 AM,

Re: [PATCH net-next 2/4] udp offload: allow GRO on 0 checksum packets

2016-07-08 Thread Alexander Duyck
On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: > currently, UDP packets with zero checksum are not allowed to > use udp offload's GRO. This patch admits such packets to > GRO, if the related socket settings allow it: ipv6 packets > are not admitted if the sockets don't have

Re: XDP seeking input from NIC hardware vendors

2016-07-08 Thread John Fastabend
On 16-07-08 09:07 AM, Jakub Kicinski wrote: > On Fri, 8 Jul 2016 17:19:43 +0200, Jesper Dangaard Brouer wrote: >> On Fri, 8 Jul 2016 14:44:53 +0100 Jakub Kicinski >> wrote: >>> On Thu, 7 Jul 2016 19:22:12 -0700, Alexei Starovoitov wrote: > If the goal is to just

Re: [PATCH v2 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-07-08 Thread Vishwanath Pai
On 07/08/2016 12:54 PM, Vishwanath Pai wrote: > On 07/08/2016 12:37 PM, David Laight wrote: >> If you think some users would still want 32bit limits, then you should >> (probably) use a _64 suffix for the new functions. >> >> David > > I am proposing a new revision for hashlimit that

Re: [iproute PATCH 0/2] Netns performance improvements

2016-07-08 Thread Rick Jones
On 07/08/2016 01:01 AM, Nicolas Dichtel wrote: Those 300 routers will each have at least one namespace along with the dhcp namespaces. Depending on the nature of the routers (Distributed versus Centralized Virtual Routers - DVR vs CVR) and whether the routers are supposed to be "HA" there can

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: > With udp tunnel offload in place, the kernel can do GRO for some udp tunnels > at the ingress device level. Currently both the geneve and the vxlan drivers > implement an additional GRO aggregation point via gro_cells. > The

[PATCH net] tcp: make challenge acks less predictable

2016-07-08 Thread Eric Dumazet
From: Eric Dumazet Yue Cao claims that current host rate limiting of challenge ACKS (RFC 5961) could leak enough information to allow a patient attacker to hijack TCP sessions. He will soon provide details in an academic paper. This patch increases the default limit from

RE: [PATCH v2 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-07-08 Thread David Laight
From: Vishwanath Pai > Sent: 08 July 2016 00:34 > I am planning to add a revision 2 for the hashlimit xtables module to > support higher packets per second rates. This patch renames all the > functions and variables related to revision 1 by adding _v1 at the end of > the names. Sounds backwards.

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

2016-07-08 Thread Brenden Blanco
On Fri, Jul 08, 2016 at 08:56:45AM +0200, Eric Dumazet wrote: > On Thu, 2016-07-07 at 21:16 -0700, Alexei Starovoitov wrote: > > > I've tried this style of prefetching in the past for normal stack > > and it didn't help at all. > > This is very nice, but my experience showed opposite numbers. >

Re: [PATCH v2 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-07-08 Thread Vishwanath Pai
On 07/08/2016 12:37 PM, David Laight wrote: > If you think some users would still want 32bit limits, then you should > (probably) use a _64 suffix for the new functions. > > David I am proposing a new revision for hashlimit that supports a higher rate along with a few other changes/fixes

Re: XDP seeking input from NIC hardware vendors

2016-07-08 Thread Jakub Kicinski
On Fri, 8 Jul 2016 09:45:25 -0700, John Fastabend wrote: > The only distinction between VFs and queue groupings on my side is VFs > provide RSS where as queue groupings have to be selected explicitly. > In a programmable NIC world the distinction might be lost if a "RSS" > program can be loaded

Re: [PATCH v2 1/6] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > The bgmac_* print wrappers call dev_* prints with the dev pointer from > the bcma core. In anticipation of removing the bcma requirement for > this driver, these must be changed to not reference that struct. So, > simply change all of the bgmac_* prints

[PATCH net-next 1/2] net: dsa: b53: Allow SRAB driver to specify platform data

2016-07-08 Thread Florian Fainelli
For Northstart Plus SoCs, we cannot detect the switch because only the revision information is provied in the Management page, instead, rely on Device Tree to tell us the chip id, and pass it down using the b53_platform_data structure. Signed-off-by: Florian Fainelli ---

[PATCH net-next 0/2] net: dsa: b53: Add Broadcom NSP switch support

2016-07-08 Thread Florian Fainelli
Hi all, This patch series updates the B53 driver to support Broadcom's Northstar Plus Soc integrated switch. Unlike the version of the core present in BCM5301x/Northstar, we cannot read the full chip id of the switch, so we need to get the information about our switch id from Device Tree. Other

[PATCH net-next 2/2] net: dsa: b53: Add support for BCM585xx/586xx/88312 integrated switch

2016-07-08 Thread Florian Fainelli
Update the SRAB, core driver and binding document to support the BCM585xx/586xx/88312 integrated switch (Northstar Plus SoCs family). Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/b53.txt | 9 + drivers/net/dsa/b53/b53_common.c

[PATCH 2/2] ARM: dts: NSP: Add BCM958625HR switch ports

2016-07-08 Thread Florian Fainelli
Add the layout of the switch ports found on the BCM958625HR reference board. The CPU port is hooked up to the AMAC0 Ethernet controlelr adapter, so we also enable it. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm958625hr.dts | 49

[PATCH 0/2] ARM: dts: NSP: Add built-in Ethernet switch nodes

2016-07-08 Thread Florian Fainelli
This patch series is based on Broadcom/stblinux/devicetree/next which contains proper support for the BCM958625HR board. To get working Ethernet switch and CPU Ethernet support, the following dependencies based on David Miller's net-next tree are required: - Jon Mason's BGMAC/AMAC support:

[PATCH 1/3] ARM: dts: Enable SRAB switch and GMACs on 5301x DTS

2016-07-08 Thread Florian Fainelli
Add the Switch Register Access Block which is a special piece of hardware allowing us to perform indirect read/writes towards the integrated BCM5301X Ethernet switch. We also add the 4 Gigabit MAC Device Tree nodes within the brcm,bus-axi bus node to get proper binding between the BCMA

[PATCH 0/2] ARM: dts: NSP: Add built-in Ethernet switch nodes

2016-07-08 Thread Florian Fainelli
This patch series is based on Broadcom/stblinux/devicetree/next which contains proper support for the BCM958625HR board. To get working Ethernet switch and CPU Ethernet support, the following dependencies based on David Miller's net-next tree are required: - Jon Mason's BGMAC/AMAC support:

[PATCH 2/3] ARM: dts: BCM5301X: Add SRAB interrupts

2016-07-08 Thread Florian Fainelli
Add interrupt mapping for the Switch Register Access Block. Only 12 interrupts are usable at the moment even though up to 32 are dedicated to the SRAB. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 15 +++ 1 file changed, 15

[PATCH 1/2] ARM: dts: NSP: Add Switch Register Access Block node

2016-07-08 Thread Florian Fainelli
Add the Switch Register Access Block node, this peripheral is identical to the BCM5301x Northstar SoC, but we utilize the SoC-wide "brcm,nsp-srab" compatible string to illustrate the integration difference here. Signed-off-by: Florian Fainelli ---

[PATCH 1/2] ARM: dts: NSP: Add Switch Register Access Block node

2016-07-08 Thread Florian Fainelli
Add the Switch Register Access Block node, this peripheral is identical to the BCM5301x Northstar SoC, but we utilize the SoC-wide "brcm,nsp-srab" compatible string to illustrate the integration difference here. Signed-off-by: Florian Fainelli ---

[PATCH 2/2] ARM: dts: NSP: Add BCM958625HR switch ports

2016-07-08 Thread Florian Fainelli
Add the layout of the switch ports found on the BCM958625HR reference board. The CPU port is hooked up to the AMAC0 Ethernet controlelr adapter, so we also enable it. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm958625hr.dts | 49

Re: [PATCH 0/2] ARM: dts: NSP: Add built-in Ethernet switch nodes

2016-07-08 Thread Florian Fainelli
On 07/08/2016 11:48 AM, Florian Fainelli wrote: > This patch series is based on Broadcom/stblinux/devicetree/next which > contains proper support for the BCM958625HR board. To get working > Ethernet switch and CPU Ethernet support, the following dependencies > based on David Miller's net-next tree

[net-next 5/6] libcxgb: export ppm release and tagmask set api

2016-07-08 Thread Varun Prakash
Export cxgbi_ppm_release() to release ppod manager and cxgbi_tagmask_set() to set tag mask, they are used by cxgb3i, cxgb4i and cxgbit. Signed-off-by: Varun Prakash --- drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c | 2 ++ drivers/scsi/cxgbi/cxgb3i/cxgb3i.c

[net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning

2016-07-08 Thread Varun Prakash
Fix following sparse warnings warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static? warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static? warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static? Signed-off-by: Varun Prakash

[net-next 3/6] cxgb4i,libcxgbi: add iSCSI DDP support

2016-07-08 Thread Varun Prakash
Add iSCSI DDP support in cxgb4i driver using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/Makefile| 2 + drivers/scsi/cxgbi/cxgb3i/Kbuild | 1 + drivers/scsi/cxgbi/cxgb3i/Kconfig | 1 +

[net-next 1/6] libcxgb: add library module for Chelsio drivers

2016-07-08 Thread Varun Prakash
Add common library module(libcxgb.ko) for Chelsio drivers to remove duplicate code. Code for iSCSI DDP Page Pod Manager is moved from cxgb4.ko to libcxgb.ko. Earlier only cxgbit.ko was using this code, now cxgb3i and cxgb4i will also use common Page Pod manager code. In future this module will

[net-next 4/6] cxgb3i: add iSCSI DDP support

2016-07-08 Thread Varun Prakash
Add iSCSI DDP support in cxgb3i driver using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 119 - 1 file changed, 118 insertions(+), 1 deletion(-) diff --git

[net-next 0/6] common library for Chelsio drivers

2016-07-08 Thread Varun Prakash
Hi, This patch series adds common library module(libcxgb.ko) for Chelsio drivers to remove duplicate code. This series moves common iSCSI DDP Page Pod manager code from cxgb4.ko to libcxgb.ko, earlier this code was used by only cxgbit.ko now it is used by three Chelsio iSCSI drivers cxgb3i,

[net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support

2016-07-08 Thread Varun Prakash
Remove old ddp code from cxgb3i,cxgb4i,libcxgbi. Next two commits adds DDP support using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 128 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 142 -

Re: [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > David Miller, Please consider including patches 1-5 in net-next > > Florian Fainelli, Please consider including patches 6 & 7 in > devicetree/next David should pick all 6 patches, including the binding documentation, as this comes with the driver, I

Re: [PATCH v2 3/6] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > Move the BCMA MDIO phy into a separate file, as it is very tightly > coupled with the BCMA bus. This will help with the upcoming BCMA > removal from the bgmac driver. Optimally, this should be moved into > phy drivers, but it is too tightly coupled with

Re: [PATCH v2 5/6] net: ethernet: bgmac: Add platform device support

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > The bcma portion of the driver has been split off into a bcma specific > driver. This has been mirrored for the platform driver. The last > references to the bcma core struct have been changed into a generic > function call. These function calls are

Re: [PATCH v2 6/6] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli -- Florian

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > The bgmac driver is using the bcma provides device ID and revision, as > well as the SoC ID and package, to determine which features are > necessary to enable, reset, etc in the driver. In anticipation of > removing the bcma requirement for this driver,

Re: [PATCH v2 2/6] net: ethernet: bgmac: add dma_dev pointer

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > The dma buffer allocation, etc references a dma_dev device pointer from > the bcma core. In anticipation of removing the bcma requirement for > this driver, these must be changed to not reference that struct. Add a > dma_dev device pointer to the bgmac

Re: [PATCH net-next 0/2] net: dsa: b53: Add Broadcom NSP switch support

2016-07-08 Thread Andrew Lunn
On Fri, Jul 08, 2016 at 11:39:11AM -0700, Florian Fainelli wrote: > Hi all, > > This patch series updates the B53 driver to support Broadcom's Northstar Plus > Soc integrated switch. Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 16:17, Shmulik Ladkani wrote: > On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck > wrote: >> On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: >>> With udp tunnel offload in place, the kernel can do GRO for some udp tunnels >>> at

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 17:19, Shmulik Ladkani wrote: > On Fri, 8 Jul 2016 16:57:10 -0400 Hannes Frederic Sowa > wrote: >> On 08.07.2016 16:17, Shmulik Ladkani wrote: >>> On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck >>> wrote: I get that

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-08 Thread Roland Dreier
On Fri, Jul 8, 2016 at 9:51 AM, Jason Gunthorpe wrote: > So, it appears, the dst and neigh can be used for all performances cases. > > For the non performance dst == null case, can we just burn cycles and > stuff the daddr in front of the packet at hardheader

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 17:27, Alexander Duyck wrote: > On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa > wrote: >> On 08.07.2016 16:17, Shmulik Ladkani wrote: >>> On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck >>> wrote: On Thu, Jul 7,

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Fri, Jul 8, 2016 at 2:51 PM, Hannes Frederic Sowa wrote: > On 08.07.2016 17:27, Alexander Duyck wrote: >> On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa >> wrote: >>> On 08.07.2016 16:17, Shmulik Ladkani wrote: On Fri, 8 Jul

Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings"

2016-07-08 Thread Florian Fainelli
On 07/08/2016 03:54 PM, Philippe Reynes wrote: > This reverts commit 4386f5662e63 ("net: ethernet: bcmgenet: use > phy_ethtool_{get|set}_link_ksettings") > > This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings > don't check if the device is running, but the driver bcmgenet need

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 18:11, Alexander Duyck wrote: > On Fri, Jul 8, 2016 at 2:51 PM, Hannes Frederic Sowa > wrote: >> On 08.07.2016 17:27, Alexander Duyck wrote: >>> On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa >>> wrote: On

  1   2   >