Re: [LEDE-DEV] DHCP via bridge in case of IPv4

2016-07-10 Thread Russell Senior
> "Alexey" == Alexey Brodkin writes: Alexey> Hi Aaron, Alexey> On Sat, 2016-07-09 at 07:47 -0400, Aaron Z wrote: >> On Sat, Jul 9, 2016 at 4:37 AM, Alexey Brodkin >> wrote: >> > >> > Hello, >> > >> > I was playing with quite simple

Re: [ovs-dev] [PATCH net-next v11 4/6] openvswitch: add support to push and pop mpls for layer3 packets

2016-07-10 Thread Simon Horman
On Thu, Jul 07, 2016 at 01:52:47PM -0700, pravin shelar wrote: > On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman > wrote: > > Allow push and pop mpls actions to act on layer 3 packets by teaching > > them not to access non-existent L2 headers of such packets. > > > >

[BUG?] tcp regression in v4.7-r1: c14ac9451c34832554db33386a4393be8bba3a7b breaks pulseaudio over TCP

2016-07-10 Thread Sergei Trofimovich
Hi netdev folk! Commit c14ac9451c34832554db33386a4393be8bba3a7b broke pulseaudio (PA) over TCP. PA does unusual thing: it calls sendmsg(cmsg_type=SCM_CREDENTIALS) on a TCP socket. It's not a new PA behaviour though. Originally reported as PA bug (has more details)

Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

2016-07-10 Thread Steffen Klassert
On Wed, Jul 06, 2016 at 10:27:29AM +0800, Herbert Xu wrote: > On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote: > > From: Vegard Nossum > > Date: Tue, 5 Jul 2016 10:18:08 +0200 > > > > > If we hit any of the error conditions inside xfrm_dump_sa(), then > >

Re: [PATCH v2 net] tcp: make challenge acks less predictable

2016-07-10 Thread Neal Cardwell
On Sun, Jul 10, 2016 at 4:04 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > Yue Cao claims that current host rate limiting of challenge ACKS > (RFC 5961) could leak enough information to allow a patient attacker > to hijack TCP sessions. He will

RE: [PATCH net-next 1/4] net/mlx4_core: Fix QUERY FUNC CAP flags

2016-07-10 Thread Moshe Shemesh
>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: >> From: Moshe Shemesh >> >> Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags. >> Remove QUERY_FUNC_CAP port_flags field which was not in use. > >The patch title says "Fix ..." but the change

[patch net-next] MAINTAINERS: release Scott from being a rocker maintainer

2016-07-10 Thread Jiri Pirko
From: Jiri Pirko As requested by Scott, removing him. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6374be2..06e8411 100644 ---

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

2016-07-10 Thread Shmulik Ladkani
On Sat, 9 Jul 2016 15:22:30 +0200, f...@strlen.de wrote: > Shmulik Ladkani wrote: > > I'd appreciate any suggestion how to determine traffic is local OTHER > > THAN testing IPSKB_FORWARDED; If we have such a way, there wouldn't be an > > impact on local

[PATCH v2 net] tcp: make challenge acks less predictable

2016-07-10 Thread Eric Dumazet
From: Eric Dumazet Yue Cao claims that current host rate limiting of challenge ACKS (RFC 5961) could leak enough information to allow a patient attacker to hijack TCP sessions. He will soon provide details in an academic paper. This patch increases the default limit from

[PATCH v5] wlcore: spi: add wl18xx support

2016-07-10 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Jesper Dangaard Brouer
On Sat, 9 Jul 2016 08:47:52 -0500 Tom Herbert wrote: > On Sat, Jul 9, 2016 at 3:14 AM, Jesper Dangaard Brouer > wrote: > > On Thu, 7 Jul 2016 19:15:13 -0700 > > Brenden Blanco wrote: > > > >> Add a new bpf prog type that is

Re: [BUG?] tcp regression in v4.7-r1: c14ac9451c34832554db33386a4393be8bba3a7b breaks pulseaudio over TCP

2016-07-10 Thread Soheil Hassas Yeganeh
On Sun, Jul 10, 2016 at 7:42 AM, Sergei Trofimovich wrote: > Hi netdev folk! > > Commit c14ac9451c34832554db33386a4393be8bba3a7b > broke pulseaudio (PA) over TCP. Sorry that my patch broke your app and thanks for the bug report. Breaking PA was certainly not my intention. >

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

2016-07-10 Thread Philippe Reynes
Hi all, On 05/07/16 23:40, Ben Hutchings wrote: On Tue, 2016-07-05 at 14:15 -0700, Florian Fainelli wrote: On 07/05/2016 02:07 PM, Philippe Reynes wrote: Hi Florian, On 05/07/16 06:30, Florian Fainelli wrote: Le 04/07/2016 16:03, David Miller a écrit : From: Philippe

RE: [PATCH net-next 4/4] net/mlx4_core: Add an option to configure SVLAN TPID

2016-07-10 Thread Moshe Shemesh
>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: >> From: Moshe Shemesh >> >> Expose mlx4_config_svlan_tpid, that checks for feature support in >> device capabilities and sets the Service Tag TPID accordingly. > >I Googled for service tag TPID and I

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Tom Herbert
On Sun, Jul 10, 2016 at 8:37 AM, Jesper Dangaard Brouer wrote: > On Sat, 9 Jul 2016 08:47:52 -0500 > Tom Herbert wrote: > >> On Sat, Jul 9, 2016 at 3:14 AM, Jesper Dangaard Brouer >> wrote: >> > On Thu, 7 Jul 2016 19:15:13 -0700 >> >

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

2016-07-10 Thread Tom Herbert
On Fri, Jul 8, 2016 at 11:49 AM, Brenden Blanco wrote: > On Fri, Jul 08, 2016 at 08:56:45AM +0200, Eric Dumazet wrote: >> On Thu, 2016-07-07 at 21:16 -0700, Alexei Starovoitov wrote: >> >> > I've tried this style of prefetching in the past for normal stack >> > and it didn't

Saudações

2016-07-10 Thread harry . martant
Saudações, Eu sou a senhora Annie Ethan de uma empresa de crédito privado conhecido como Aspire dinheiro Loan®. Oferecemos todos os tipos de empréstimo a taxa de juro de 3%. Se você está na necessidade de empréstimo favor contacte-nos com as informações abaixo. Nome completo: Gênero:

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Tom Herbert
On Sun, Jul 10, 2016 at 12:09 PM, Brenden Blanco wrote: > On Sun, Jul 10, 2016 at 03:37:31PM +0200, Jesper Dangaard Brouer wrote: >> On Sat, 9 Jul 2016 08:47:52 -0500 >> Tom Herbert wrote: >> >> > On Sat, Jul 9, 2016 at 3:14 AM, Jesper Dangaard Brouer

Re: [PATCH v6 02/12] net: add ndo to set xdp prog in adapter rx

2016-07-10 Thread Tom Herbert
On Thu, Jul 7, 2016 at 9:15 PM, Brenden Blanco wrote: > Add two new set/check netdev ops for drivers implementing the > BPF_PROG_TYPE_XDP filter. > > Signed-off-by: Brenden Blanco > --- > include/linux/netdevice.h | 14 ++ > net/core/dev.c

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

2016-07-10 Thread Florian Fainelli
Le 10/07/2016 15:50, Philippe Reynes a écrit : > Hi all, > > > On 05/07/16 23:40, Ben Hutchings wrote: >> On Tue, 2016-07-05 at 14:15 -0700, Florian Fainelli wrote: >>> On 07/05/2016 02:07 PM, Philippe Reynes wrote: Hi Florian, On 05/07/16 06:30, Florian Fainelli wrote: > Le

RE: [PATCH net-next 2/4] net/mlx4: Preparation for VST QinQ

2016-07-10 Thread Tariq Toukan
>> Add func capability vlan_offload_disable to disable all vlan HW >> acceleration on VF while the VF is set to VST QinQ mode. > >this part (above two lines) is code running in the VF Eth driver, correct? if >this is indeed the case, break the patch to two (1) PF core driver (2) VF >core/EN

Re: [PATCH v7 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-07-10 Thread David Miller
From: Date: Thu, 7 Jul 2016 20:23:30 -0700 > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii. > > Signed-off-by: Tien Hock Loh > Acked-by: Rob Herring

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-10 Thread Dongpo Li
Hi Arnd, On 2016/6/28 17:34, Arnd Bergmann wrote: > On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: >> On 2016/6/15 5:20, Arnd Bergmann wrote: >>> On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: On 2016/6/13 17:06, Arnd Bergmann wrote: > On Monday, June 13, 2016

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-10 Thread Tariq Toukan
On 09/07/2016 10:58 PM, Saeed Mahameed wrote: On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanco wrote: + /* A bpf program gets first chance to drop the packet. It may +* read bytes but not past the end of the frag. +*/ +

[PATCHv2 net] ipv4: reject RTNH_F_DEAD and RTNH_F_LINKDOWN from user space

2016-07-10 Thread Julian Anastasov
Vegard Nossum is reporting for a crash in fib_dump_info when nh_dev = NULL and fib_nhs == 1: Pid: 50, comm: netlink.exe Not tainted 4.7.0-rc5+ RIP: 0033:[<602b3d18>] RSP: 62623890 EFLAGS: 00010202 RAX: RBX: 6261b800 RCX: RDX:

Re: [PATCH v2 net] tcp: make challenge acks less predictable

2016-07-10 Thread Yue Cao
This second patch does make our attack much harder but it's still possible to do such off-path attack with enough network bandwidth. Here is our modified attack for this second patch. Modified Attack: Main idea of our attack is to send multiple same spoofed packets in 1 second so attacker can

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

2016-07-10 Thread Shmulik Ladkani
On Sat, 9 Jul 2016 15:30:17 +0300 Shmulik Ladkani wrote: > On Sat, 9 Jul 2016 11:00:20 +0200 Florian Westphal wrote: > > I am worried about this patch, skb_gso_validate_mtu is more costly than > > the ->flags & FORWARD check; everyone pays

Re: [BUG?] tcp regression in v4.7-r1: c14ac9451c34832554db33386a4393be8bba3a7b breaks pulseaudio over TCP

2016-07-10 Thread Soheil Hassas Yeganeh
On Sun, Jul 10, 2016 at 12:25 PM, Sergei Trofimovich wrote: > On Sun, 10 Jul 2016 11:15:01 -0400 > Soheil Hassas Yeganeh wrote: > >> On Sun, Jul 10, 2016 at 7:42 AM, Sergei Trofimovich >> wrote: >> > Hi netdev folk! >> > >> > Commit

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-10 Thread Brenden Blanco
On Sat, Jul 09, 2016 at 05:07:36PM +0300, Or Gerlitz wrote: > On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanco wrote: > > Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. > > > > In tc/socket bpf programs, helpers linearize skb fragments as needed > > when the

Re: [PATCH v6 00/12] Add driver bpf hook for early packet drop and forwarding

2016-07-10 Thread Tariq Toukan
On 08/07/2016 5:15 AM, Brenden Blanco wrote: This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling eXpress Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Brenden Blanco
On Sun, Jul 10, 2016 at 03:37:31PM +0200, Jesper Dangaard Brouer wrote: > On Sat, 9 Jul 2016 08:47:52 -0500 > Tom Herbert wrote: > > > On Sat, Jul 9, 2016 at 3:14 AM, Jesper Dangaard Brouer > > wrote: > > > On Thu, 7 Jul 2016 19:15:13 -0700 > > >

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

2016-07-10 Thread Tom Herbert
> This particular patch in the series is meant to be standalone exactly > for this reason. I don't pretend to assert that this optimization will > work for everybody, or even for a future version of me with different > hardware. But, it passes my internal criteria for usefulness: > 1. It provides

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Tom Herbert
On Thu, Jul 7, 2016 at 9:15 PM, Brenden Blanco wrote: > Add a new bpf prog type that is intended to run in early stages of the > packet rx path. Only minimal packet metadata will be available, hence a > new context type, struct xdp_md, is exposed to userspace. So far only >

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-10 Thread Tariq Toukan
+ switch (act) { + case XDP_PASS: + break; + default: + bpf_warn_invalid_xdp_action(act); + case XDP_DROP: + goto

Re: Multi-thread udp 4.7 regression, bisected to 71d8c47fc653

2016-07-10 Thread Marc Dionne
On Tue, Jul 5, 2016 at 9:28 AM, Pablo Neira Ayuso wrote: > Hi, > > On Mon, Jul 04, 2016 at 09:35:28AM -0300, Marc Dionne wrote: >> If there is no quick fix, seems like a revert should be considered: >> - Looks to me like the commit attempts to fix a long standing bug >>

Re: [PATCH v6 01/12] bpf: add XDP prog type for early driver filter

2016-07-10 Thread Tom Herbert
On Thu, Jul 7, 2016 at 9:15 PM, Brenden Blanco wrote: > Add a new bpf prog type that is intended to run in early stages of the > packet rx path. Only minimal packet metadata will be available, hence a > new context type, struct xdp_md, is exposed to userspace. So far only >

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-10 Thread Brenden Blanco
On Sun, Jul 10, 2016 at 06:25:40PM +0300, Tariq Toukan wrote: > > On 09/07/2016 10:58 PM, Saeed Mahameed wrote: > >On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanco wrote: > >>+ /* A bpf program gets first chance to drop the packet. It > >>may > >>+

Re: [BUG?] tcp regression in v4.7-r1: c14ac9451c34832554db33386a4393be8bba3a7b breaks pulseaudio over TCP

2016-07-10 Thread Sergei Trofimovich
On Sun, 10 Jul 2016 11:15:01 -0400 Soheil Hassas Yeganeh wrote: > On Sun, Jul 10, 2016 at 7:42 AM, Sergei Trofimovich wrote: > > Hi netdev folk! > > > > Commit c14ac9451c34832554db33386a4393be8bba3a7b > > broke pulseaudio (PA) over TCP. > > Sorry that my

[PATCH net] sock: ignore SCM_RIGHTS and SCM_CREDENTIALS in __sock_cmsg_send

2016-07-10 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Sergei Trofimovich reported that pulse audio sends SCM_CREDENTIALS as a control message to TCP. Since __sock_cmsg_send does not support SCM_RIGHTS and SCM_CREDENTIALS, it returns an error and hence breaks pulse audio over TCP. SCM_RIGHTS and