[NetDev] [ANNOUNCE] Netdev 1.2 weekly updates (6th September, 2016)

Hello folks, Tokyo is still being in a hot weather but it'll start comfortable autumn very soon. Here is an weekly update of Netdev 1.2 Tokyo. We again extended the deadline of early bird registration. Please don't miss the discount ticket - and your early registration will be definitely

Re: [RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

Hi Andrei, Adding Richard Cochran for PTP. On Fri, Sep 2, 2016 at 6:23 PM, Andrei Pistirica wrote: > From: Harini Katakam > > Cadence GEM provides a 102 bit time counter with 48 bits for seconds, > 30 bits for nsecs and 24 bits for sub-nsecs

Re: [RFC PATCH 2/2] macb: Enable 1588 support in SAMA5D2 platform.

Hi Andrei, +Richard Cochran On Fri, Sep 2, 2016 at 6:23 PM, Andrei Pistirica wrote: > Hardware time stamp on the PTP Ethernet packets are received using the > SO_TIMESTAMPING API. Timers are obtained from the PTP event/peer > gem registers. > > Signed-off-by:

[PATCH iproute2] ip route: check ftell, fseek return value

ftell() may return -1 in error case, which is not handled and therefore pass a negative offset to fseek(). The return code of fseek() is also not checked. Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- ip/iproute.c | 11 +-- 1 file changed, 9

[PATCH iproute] gitignore: Ignore 'tags' file generated by ctags

Signed-off-by: Hangbin Liu --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index ef03b17..74a5496 100644 --- a/.gitignore +++ b/.gitignore @@ -10,6 +10,7 @@ Config # cscope cscope.* ncscope.* +tags TAGS # git files that we

[PATCH iproute2] ip link: fix up bond/bridge slave id

Signed-off-by: Hangbin Liu --- ip/iplink_bond_slave.c | 2 +- ip/iplink_bridge_slave.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c index 9c60dea..8a3104b 100644 --- a/ip/iplink_bond_slave.c +++

[v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

The global utilities block controls power management, I/O device enabling, power-onreset(POR) configuration monitoring, alternate function selection for multiplexed signals,and clock control. This patch adds a driver to manage and access global utilities block. Initially only reading SVR and

[v11, 3/8] dt: bindings: move guts devicetree doc out of powerpc directory

Move guts devicetree doc to Documentation/devicetree/bindings/soc/fsl/ since it's used by not only PowerPC but also ARM. And add a specification for 'little-endian' property. Signed-off-by: Yangbo Lu Acked-by: Rob Herring Acked-by: Scott Wood

[v11, 8/8] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

The eSDHC of T4240-R1.0-R2.0 has incorrect vender version and spec version. Acturally the right version numbers should be VVN=0x13 and SVN = 0x1. This patch adds the GUTS driver support for eSDHC driver to match SoC. And fix host version to avoid that incorrect version numbers break down the ADMA

[v11, 7/8] base: soc: introduce soc_device_match() interface

We keep running into cases where device drivers want to know the exact version of the a SoC they are currently running on. In the past, this has usually been done through a vendor specific API that can be called by a driver, or by directly accessing some kind of version register that is not part

RE: linux-next: manual merge of the char-misc tree with the net-next tree

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Monday, September 5, 2016 5:04 PM > To: Stephen Rothwell > Cc: Arnd Bergmann ; David Miller ; > Networking ;

[v11, 0/8] Fix eSDHC host version register bug

This patchset is used to fix a host version register bug in the T4240-R1.0-R2.0 eSDHC controller. To match the SoC version and revision, 10 previous version patchsets had tried many methods but all of them were rejected by reviewers. Such as - dts compatible method - syscon method

[v11, 6/8] MAINTAINERS: add entry for Freescale SoC drivers

Add maintainer entry for Freescale SoC drivers including the QE library and the GUTS driver now. Also add maintainer for QE library. Signed-off-by: Yangbo Lu Acked-by: Scott Wood Acked-by: Qiang Zhao --- Changes for v8: - Added

Re: [PATCH net-next 2/3] smsc95xx: Add register define

From: Joe Perches Date: Fri, 02 Sep 2016 13:40:01 -0700 > On Fri, 2016-09-02 at 20:34 +, woojung@microchip.com wrote: >> From: Woojung Huh >> >> Add STRAP_STATUS defines. > [] >> diff --git a/drivers/net/usb/smsc95xx.h

Re: [PATCH net-next 0/3] smsc95xx: patch serises

From: Date: Fri, 2 Sep 2016 20:34:17 + > From: Woojung Huh Series applied, thanks.

Re: [ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

On Sun, Aug 28, 2016 at 11:56:48PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > This patchset enhances ethtool link mode bitmap to include > missing interface modes for 1G/10G speeds > > Vidya Sagar Ravipati (2): > ethtool-copy.h:sync with net

Re: [ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

Will send out man page fix. Missed it. On Tue, Sep 6, 2016 at 1:32 PM, Vidya Sagar Ravipati wrote: > Will send out man page fix too. Missed it. > > On Tue, Sep 6, 2016 at 1:16 PM, John W. Linville > wrote: >> >> On Sun, Aug 28, 2016 at

Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

From: Haishuang Yan Date: Sun, 4 Sep 2016 18:52:51 +0800 > If vxlan_build_skb return err < 0, tx_errors should be also increased. > > Signed-off-by: Haishuang Yan Applied to net-next.

Re: [PATCH repost net-next] bnx2x: Add support for segmentation of tunnels with outer checksums

From: Yuval Mintz Date: Mon, 5 Sep 2016 13:26:33 +0300 > From: Alexander Duyck > > Signed-off-by: Alexander Duyck > Tested-by: Yuval Mintz Applied.

Re: [PATCH] ipv6: addrconf: fix dev refcont leak when DAD failed

From: Wei Yongjun Date: Mon, 5 Sep 2016 16:06:31 +0800 > In general, when DAD detected IPv6 duplicate address, ifp->state > will be set to INET6_IFADDR_STATE_ERRDAD and DAD is stopped by a > delayed work, the call tree should be like this: > > ndisc_recv_ns > ->

[PATCH] smsc95xx: Remove trailing underscores from macros and uses

Make the #defines a bit more sensible to read. Done with: $ sed -r -i -e 's/\b([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \ drivers/net/usb/smsc95xx.[ch] and a little editing of the .h file to realign tabstop define values. There are 3 [RT]x_COE_ defines that were also uppercased. No change in

Re: [PATCH net-next] sfc: check MTU against minimum threshold

On Tue, Sep 06, 2016 at 05:50:00PM +0100, Bert Kenward wrote: > Reported-by: Ma Yuying > Suggested-by: Jarod Wilson > Signed-off-by: Bert Kenward Works for me, until we can get some dialog going about possible centralization (or not)

[PATCH v5 6/6] net: stmmac: update the module description of the dwmac-meson driver

The dwmac-meson glue driver supports Meson6 and Meson8 SoCs. Newer SoCs are supported by the dwmac-meson8b driver. Signed-off-by: Martin Blumenstingl --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v5 2/6] clk: gxbb: expose MPLL2 clock for use by DT

This exposes the MPLL2 clock as this is one of the input clocks of the ethernet controller's internal mux. Signed-off-by: Martin Blumenstingl --- drivers/clk/meson/gxbb.h | 2 +- include/dt-bindings/clock/gxbb-clkc.h | 1 + 2 files changed, 2

Re: [PATCH 0/2] hso: neatening

From: Joe Perches Date: Fri, 2 Sep 2016 15:58:00 -0700 > This seems to be the only code in the kernel that uses > macro defines with a trailing underscore. Fix that. Series applied, thanks.

Re: [PATCH v2] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

From: Brenden Blanco Date: Sat, 3 Sep 2016 21:29:58 -0700 > Depending on the preempt mode, the bpf_prog stored in xdp_prog may be > freed despite the use of call_rcu inside bpf_prog_put. The situation is > possible when running in PREEMPT_RCU=y mode, for instance, since

Re: [PATCH v3] net: macb: initialize checksum when using checksum offloading

From: Helmut Buchsbaum Date: Sun, 4 Sep 2016 18:09:47 +0200 > I'm still struggling to get this fix right.. > > Changes since v2: > - do not blindly modify SKB contents according to Dave's legitimate >objection > > Changes since v1: > - dropped disabling HW

Re: [net-next PATCH V2] qed: Remove OOM messages

From: Joe Perches Date: Sun, 4 Sep 2016 14:24:03 -0700 > These messages are unnecessary as OOM allocation failures already do > a dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) >text

Re: [PATCH net] bnxt_en: Fix TX push operation on ARM64.

From: Michael Chan Date: Mon, 5 Sep 2016 01:57:35 -0400 > There is a code path where we are calling __iowrite64_copy() on > an address that is not 64-bit aligned. This causes an exception on > some architectures such as arm64. Fix that code path by using >

Re: XPS configuration question (on tg3)

On 2016-09-06 22:21, Alexander Duyck wrote: > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: >> Hi, >> >> I've been testing different configurations and I didn't manage to get XPS to >> "behave" correctly - so I'm probably misunderstanding or forgetting >> something. The

Re: [RFC Patch net-next 2/6] net_sched: introduce tcf_hash_replace()

On Tue, Sep 6, 2016 at 5:52 AM, Jamal Hadi Salim wrote: > On 16-09-02 01:57 AM, Cong Wang wrote: > >> Cc: Jamal Hadi Salim >> Signed-off-by: Cong Wang >> --- >> include/net/act_api.h | 2 ++ >> net/sched/act_api.c | 20

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

Brandon Cazander wrote: [ cc netfilter-devel ] > Sorry to resurrect this so much later—I just got back from holidays and this > was still on my desk. > > Will anyone have another chance to look at this? It appears that the DIVERT > rule is not working in our

Re: [PATCH] lan78xx: mark symbols static where possible

From: Baoyou Xie Date: Tue, 6 Sep 2016 16:19:02 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for > 'lan78xx_defer_kevent' [-Wmissing-prototypes] > drivers/net/usb/lan78xx.c:1409:5:

Re: [PATCH] net: arc_emac: mark arc_mdio_reset() static

From: Baoyou Xie Date: Tue, 6 Sep 2016 16:21:56 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/arc/emac_mdio.c:107:5: warning: no previous prototype > for 'arc_mdio_reset' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static

From: Baoyou Xie Date: Tue, 6 Sep 2016 16:11:59 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for > 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function

[PATCH 1/2] lan78xx: Remove locally defined trailing underscores from defines and uses

Macro defines with trailing underscore are hard to read. These locally defined ones with trailing underscores are all unique without the trailing underscore, so remove them from the defines and uses. Global defines that start with LAN88XX_ that are excluded. Done with: $ perl -p -i -e

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

> Joe Perches (2): > lan78xx: Remove locally defined trailing underscores from defines and uses > microchipphy.h and uses: Remove trailing underscores from defines and > uses > > drivers/net/phy/microchip.c |4 +- > drivers/net/usb/lan78xx.c| 368 +++ >

Re: [PATCH] net: hns: declare function as static

From: Kefeng Wang Date: Tue, 6 Sep 2016 19:53:11 +0800 > Declare function as static to kill warning about missing-prototypes. > > Cc: Yisen Zhuang > Cc: Kejian Yan > Signed-off-by: Kefeng Wang

Re: [RFC Patch net-next 1/6] net_sched: use RCU for action hash table

On Tue, Sep 6, 2016 at 5:47 AM, Jamal Hadi Salim wrote: > On 16-09-02 01:57 AM, Cong Wang wrote: >> >> We already free tc actions in a RCU callback, so here >> we just need to convert the hash table operations to >> RCU API's. >> >> Cc: Jamal Hadi Salim >>

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 > +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Please do not define private min/max macros, use the existing max_t() or similar as needed.

[PATCH 2/2] microchipphy.h and uses: Remove trailing underscores from defines and uses

Macro defines with trailing underscore are hard to read. These uses with trailing underscores are all unique to this .h file, so remove them from the defines and uses. Done with: $ sed -r -i -e 's/\b([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \ include/linux/microchipphy.h \

[PATCH 0/2] lan78xx: Remove trailing underscores from macros

Joe Perches (2): lan78xx: Remove locally defined trailing underscores from defines and uses microchipphy.h and uses: Remove trailing underscores from defines and uses drivers/net/phy/microchip.c |4 +- drivers/net/usb/lan78xx.c| 368 +++ drivers/net/usb/lan78xx.h|

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

Hi Bjorn, > Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. > > Cc: Marcel Holtmann > Signed-off-by: Bjorn Andersson > --- > > There are no other pending changes colliding with this, so if Andy is okay > with > this it

[PATCH] lan78xx: mark symbols static where possible

We get a few warnings when building kernel with W=1: drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for 'lan78xx_defer_kevent' [-Wmissing-prototypes] drivers/net/usb/lan78xx.c:1409:5: warning: no previous prototype for 'lan78xx_nway_reset' [-Wmissing-prototypes]

[PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static

We get 1 warning when building kernel with W=1: drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be

[PATCH] net: arc_emac: mark arc_mdio_reset() static

We get 1 warning when building kernel with W=1: drivers/net/ethernet/arc/emac_mdio.c:107:5: warning: no previous prototype for 'arc_mdio_reset' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so

Re: [PATCH iproute2] ip link: fix up bond/bridge slave id

> On Sep 6, 2016, at 10:44 AM, Hangbin Liu wrote: > > Signed-off-by: Hangbin Liu > --- > ip/iplink_bond_slave.c | 2 +- > ip/iplink_bridge_slave.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ip/iplink_bond_slave.c

RE: [PATCH -next v2] net: hns: fix return value check in hns_dsaf_get_cfg()

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, September 05, 2016 8:43 PM > To: Salil Mehta > Cc: weiyj...@163.com; Zhuangyuzeng (Yisen); Yankejian (Hackim Yim); > yongjun_...@trendmicro.com.cn; netdev@vger.kernel.org > Subject: Re: [PATCH -next

[v11, 1/8] dt: bindings: update Freescale DCFG compatible

Update Freescale DCFG compatible with 'fsl,-dcfg' instead of 'fsl,ls1021a-dcfg' to include more chips such as ls1021a, ls1043a, and ls2080a. Signed-off-by: Yangbo Lu Acked-by: Rob Herring Signed-off-by: Scott Wood --- Changes for v8:

[v11, 4/8] powerpc/fsl: move mpc85xx.h to include/linux/fsl

Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common header file. This SVR numberspace is used on some ARM chips as well as PPC, and even to check for a PPC SVR multi-arch drivers would otherwise need to ifdef the header inclusion and all references to the SVR symbols.

[v11, 2/8] ARM64: dts: ls2080a: add device configuration node

Add the dts node for device configuration unit that provides general purpose configuration and status for the device. Signed-off-by: Yangbo Lu Acked-by: Scott Wood --- Changes for v5: - Added this patch Changes for v6: - None Changes for v7:

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

On Wed, 2016-09-07 at 02:00 +, ronnie.ku...@microchip.com wrote: > Microchip's internal convention is for register (offset) definitions > to be capitalized (i.e.: MY_REGISTER). Our convention for bits > (position) definitions within a register is to carry as a prefix the > name of the register

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/7/16 6:57 AM, David Miller wrote: From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

Hi Marcelo Thanks for the suggestion Will consider that B.R. Jia On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote: On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... v2: - 1/6 fix bug in udplite statistics. - 1/6 snmp_seq_show is split into 2 parts Jia He (6): proc: Reduce

RE: linux-next: manual merge of the char-misc tree with the net-next tree

> -Original Message- > From: KY Srinivasan > Sent: Tuesday, September 6, 2016 11:06 AM > To: 'Greg KH' ; Stephen Rothwell > Cc: Arnd Bergmann ; David Miller ; > Networking ;

Re: [v11, 7/8] base: soc: introduce soc_device_match() interface

On 6 September 2016 at 10:28, Yangbo Lu wrote: > We keep running into cases where device drivers want to know the exact > version of the a SoC they are currently running on. In the past, this has > usually been done through a vendor specific API that can be called by a >

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Kalle, On 09/03/2016 12:35 PM, Kalle Valo wrote: > Javier Martinez Canillas wrote: >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >> is printed but the actual error is not propagated to the caller function. >> >> Signed-off-by: Javier

Re: Centralizing support for TCAM?

On 16-09-05 11:44 PM, Alexei Starovoitov wrote: lol :) compiling bpf into fixed pipeline asic is definitely not easy. The problem with adding new cls classifieris and actions to match what configurable hw does isn't pretty either. The fixed pipeline isn't interesting beyond l2/l3 and flow-based

[PATCH] net: hns: declare function as static

Declare function as static to kill warning about missing-prototypes. Cc: Yisen Zhuang Cc: Kejian Yan Signed-off-by: Kefeng Wang --- The warning is shown when make with W=1.

[PATCH 3/3] ath10k: do not check if reset is NULL

Since reset_control_get() never returns NULL, we can use IS_ERR() instead of IS_ERR_OR_NULL(). The return statements can be simpler as well. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 25 ++--- 1 file changed,

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On 16-09-04 06:55 AM, Hadar Hen Zion wrote: From: Amir Vadai This action could be used before redirecting packets to a shared tunnel device, or when redirecting packets arriving from a such a device. The action will release the metadata created by the tunnel device (decap), or

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... > v2: > - 1/6 fix bug in udplite statistics. > - 1/6 snmp_seq_show is split into 2 parts > > Jia He (6): > proc: Reduce cache miss in {snmp,netstat}_seq_show > proc: Reduce cache miss in snmp6_seq_show > proc: Reduce cache miss in

Re: Centralizing support for TCAM?

> >Since this thread about tcam... my 0.02 here is it's pretty bad in > >the nic(host) due to power consumption and in the tor it's only good as > >a part of algorithmic lpm solutions. There it won't be even seen as tcam. > >Instead the fancy algorithms will use exact match + tcam + aux data to

Re: [PATCH] rxrpc: remove duplicate 'error' variable

On Tuesday, September 6, 2016 2:34:02 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > The rxrpc_process_call function has debug code to print a failure code, > > but instead of printing the code from the rxrpc_call structure, it > > prints an uninitialized variable: > >

[patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

From: Jiri Pirko This is RFC, unfinished. I came across some issues in the process so I would like to share those and restart the fib offload discussion in order to make it really usable. So the goal of this patchset is to allow driver to propagate all prefixes configured in

[patch net-next RFC 1/2] fib: introduce fib notification infrastructure

From: Jiri Pirko This allows to pass information about added/deleted fib entries to whoever is interested. This is done in a very similar way as devinet notifies address additions/removals. Signed-off-by: Jiri Pirko --- include/net/ip_fib.h | 19

[patch net-next RFC 2/2] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

From: Jiri Pirko Until now, in order to offload a FIB entry to HW we use switchdev op. However that has limits. Mainly in case we need to make the HW aware of all route prefixes configured in kernel. HW needs to know those in order to properly trap appropriate packets and pass

Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

ng On 16-08-30 08:44 AM, Eric Dumazet wrote: On Tue, 2016-08-30 at 07:57 -0400, Jamal Hadi Salim wrote: if (flags & SKBMOD_F_SWAPMAC) { u8 tmpaddr[ETH_ALEN]; /*XXX: I am sure we can come up with something more efficient */

[PATCH 2/3] ath10k: use devm_reset_control_get() instead of reset_control_get()

Use the managed variant of reset_control_get() to simplify the failure path and the .remove callback. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 56 +++ 1 file changed, 10 insertions(+), 46

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On 16-09-06 07:03 AM, Hadar Hen Zion wrote: On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim wrote: Please verify by running a test and send a packet or two and verify that stats are incremented (I know it may sound silly to ask but it is important). Already tested that

Re: [PATCH v4 nf] netfilter: seqadj: Drop the packet directly when fail to add seqadj extension to avoid dereference NULL pointer later

inline On Tue, Sep 6, 2016 at 6:17 PM, Pablo Neira Ayuso wrote: > On Tue, Sep 06, 2016 at 09:57:23AM +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj >> extension. But the

[PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

The newly added bpf_overflow_handler function is only built of both CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller only checks the latter: kernel/events/core.c: In function 'perf_event_alloc': kernel/events/core.c:9106:27: error: 'bpf_overflow_handler' undeclared (first

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim wrote: > On 16-09-04 06:55 AM, Hadar Hen Zion wrote: >> >> From: Amir Vadai >> >> This action could be used before redirecting packets to a shared tunnel >> device, or when redirecting packets arriving from a such

RE: [PATCH iproute2] ip route: check ftell, fseek return value

From: Hangbin Liu > Sent: 06 September 2016 07:40 > ftell() may return -1 in error case, which is not handled and therefore pass a > negative offset to fseek(). The return code of fseek() is also not checked. > > Reported-by: Phil Sutter > Signed-off-by: Hangbin Liu

Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

On 16-08-30 08:35 AM, Eric Dumazet wrote: synchronize_rcu() might bee to expensive if you plan to change actions hundred of times per second. You could instead add a 'struct rcu_head rcu;' field in struct tcf_skbmod_params (but make sure this is not exported to user space) Then :

Re: [v11, 7/8] base: soc: introduce soc_device_match() interface

On Tuesday, September 6, 2016 1:44:23 PM CEST Ulf Hansson wrote: > On 6 September 2016 at 10:28, Yangbo Lu wrote: > > We keep running into cases where device drivers want to know the exact > > version of the a SoC they are currently running on. In the past, this has > > usually

[PATCH] rxrpc: remove duplicate 'error' variable

The rxrpc_process_call function has debug code to print a failure code, but instead of printing the code from the rxrpc_call structure, it prints an uninitialized variable: net/rxrpc/call_event.c: In function 'rxrpc_process_call': net/rxrpc/call_event.c:879:58: error: 'error' may be used

Re: [PATCH] rxrpc: remove duplicate 'error' variable

Arnd Bergmann wrote: > The rxrpc_process_call function has debug code to print a failure code, > but instead of printing the code from the rxrpc_call structure, it > prints an uninitialized variable: > > net/rxrpc/call_event.c: In function 'rxrpc_process_call': >

Re: [RFC Patch net-next 1/6] net_sched: use RCU for action hash table

On 16-09-02 01:57 AM, Cong Wang wrote: We already free tc actions in a RCU callback, so here we just need to convert the hash table operations to RCU API's. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang This one stands on its own merit, no? So:

Re: Centralizing support for TCAM?

On 16-09-06 09:31 AM, Andrew Lunn wrote: So if i'm reading this right, you are talking about big switches, top of racks, etc. And you don't see much use for the TCAM. Florian and I are interested in the other end of the scale. Little 5-10 port switches in SoHo, STB, WiFi Access points etc. At

[PATCH 0/3] ath10k: a little bit clean-up of ATH10K driver

Clean-up code with devm_clk_get() and devm_reset_control_get(). I know devm_reset_control_get() should be replaced with either devm_reset_control_get_exclusive() or devm_reset_control_get_shared(). My best guess is devm_reset_control_get_shared() for this case, but I am not 100% sure, so I am

[PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ u32 match ip protocol 1 0xff flowid 1:2 \ action pedit

Re: [PATCH] vti: use right inner_mode for inbound inter address family policy checks

On Sun, Sep 04, 2016 at 12:57:13PM +0200, Thomas Zeitlhofer wrote: > In case of inter address family tunneling (IPv6 over vti4 or IPv4 over > vti6), the inbound policy checks in vti_rcv_cb and vti6_rcv_cb are using > the wrong address family. As a result, all inbound inter address family > traffic

Re: [ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

On Sun, Sep 04, 2016 at 01:05:46PM +0200, Jiri Benc wrote: > On Sat, 3 Sep 2016 13:30:12 -0400, Eric Garver wrote: > > Would a BUG_ON(!(encap && in_encap)) be better? > > Please don't crash the kernel for something that could very well > continue without problems. Use WARN_ON at most. Thanks

[PATCH 1/3] ath10k: use devm_clk_get() instead of clk_get()

Use the managed variant of clk_get() to simplify the failure path and the .remove callback. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff

Re: [RFC Patch net-next 2/6] net_sched: introduce tcf_hash_replace()

On 16-09-02 01:57 AM, Cong Wang wrote: Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/act_api.h | 2 ++ net/sched/act_api.c | 20 2 files changed, 22 insertions(+) diff --git a/include/net/act_api.h

[PATCH v4 1/6] bpf: add new prog type for cgroup socket filtering

For now, this program type is equivalent to BPF_PROG_TYPE_SOCKET_FILTER in terms of checks during the verification process. It may access the skb as well. Programs of this type will be attached to cgroups for network filtering and accounting. Signed-off-by: Daniel Mack ---

[PATCH v4 4/6] net: filter: run cgroup eBPF ingress programs

If the cgroup associated with the receiving socket has an eBPF programs installed, run them from sk_filter_trim_cap(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have access to the full skb, including the MAC

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On Sun, 2016-09-04 at 13:55 +0300, Hadar Hen Zion wrote: > From: Amir Vadai ... > +struct tcf_tunnel_key_params { > + struct rcu_head rcu; > + int tcft_action; > + int action; > + struct metadata_dst

Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

On Tue, 2016-09-06 at 08:08 -0400, Jamal Hadi Salim wrote: > ng > On 16-08-30 08:44 AM, Eric Dumazet wrote: > > On Tue, 2016-08-30 at 07:57 -0400, Jamal Hadi Salim wrote: > >> if (flags & SKBMOD_F_SWAPMAC) { > >> u8 tmpaddr[ETH_ALEN]; > >> /*XXX: I am sure

Re: [patch net-next v7 1/3] netdevice: Add offload statistics ndo

On 9/5/16, 10:18 AM, Jiri Pirko wrote: > From: Nogah Frankel > > Add a new ndo to return statistics for offloaded operation. > Since there can be many different offloaded operation with many > stats types, the ndo gets an attribute id by which it knows which > stats are

Re: [patch net-next v7 2/3] net: core: Add offload stats to if_stats_msg

On 9/5/16, 10:18 AM, Jiri Pirko wrote: > From: Nogah Frankel > > Add a nested attribute of offload stats to if_stats_msg > named IFLA_STATS_LINK_OFFLOAD_XSTATS. > Under it, add SW stats, meaning stats only per packets that went via > slowpath to the cpu, named

Re: [PATCH v5 nf] netfilter: seqadj: Drop the packet directly when fail to add seqadj extension to avoid dereference NULL pointer later

f...@ikuai8.com wrote: > From: Gao Feng > > When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj > extension. But the function nf_ct_seqadj_init doesn't check if get valid > seqadj pointer by the nfct_seqadj. > > Now drop the packet

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

On 9/6/16 8:44 AM, Jiri Pirko wrote: > Tue, Sep 06, 2016 at 04:32:12PM CEST, d...@cumulusnetworks.com wrote: >> On 9/6/16 6:01 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This allows to pass information about added/deleted fib entries to >>> whoever is interested. This

[PATCH v5 nf] netfilter: seqadj: Drop the packet directly when fail to add seqadj extension to avoid dereference NULL pointer later

From: Gao Feng When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj extension. But the function nf_ct_seqadj_init doesn't check if get valid seqadj pointer by the nfct_seqadj. Now drop the packet directly when fail to add seqadj extension to avoid

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

Tue, Sep 06, 2016 at 04:32:12PM CEST, d...@cumulusnetworks.com wrote: >On 9/6/16 6:01 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This allows to pass information about added/deleted fib entries to >> whoever is interested. This is done in a very similar way as devinet >>

Re: [patch net-next v7 0/3] return offloaded stats as default and expose original sw stats

On 9/5/16, 10:18 AM, Jiri Pirko wrote: > From: Jiri Pirko > > The problem we try to handle is about offloaded forwarded packets > which are not seen by kernel. Let me try to draw it: > > port1 port2 (HW stats are counted here) > \

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

Tue, Sep 06, 2016 at 11:34:30AM CEST, jasminder.k...@hpe.com wrote: >From: "Kaur, Jasminder" > >If a bond is in use such as with IP address configured, removing it >can result in application disruptions. If bond is used for cluster >communication or network file system

Re: [PATCH 249/249] net:ethernet:intel:igb_main.c: Add Throttling disable option in order to decrease latency usually required by RT applications.

On Tue, 6 Sep 2016 13:17:04 + Amir Yihie wrote: > I guess there's not much to do here? -- Steve

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On Tue, Sep 6, 2016 at 5:11 PM, Eric Dumazet wrote: > On Sun, 2016-09-04 at 13:55 +0300, Hadar Hen Zion wrote: >> From: Amir Vadai > > ... > >> +struct tcf_tunnel_key_params { >> + struct rcu_head rcu; >> + int

  1   2   >