[PATCH 2/6] xfrm: get rid of incorrect WARN

2016-09-08 Thread Steffen Klassert
From: Vegard Nossum AFAICT this message is just printed whenever input validation fails. This is a normal failure and we shouldn't be dumping the stack over it. Looks like it was originally a printk that was maybe incorrectly upgraded to a WARN: commit

[PATCH 1/6] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

2016-09-08 Thread Steffen Klassert
From: Vegard Nossum If we hit any of the error conditions inside xfrm_dump_sa(), then xfrm_state_walk_init() never gets called. However, we still call xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash because the state walk was never initialized

pull request (net): ipsec 2016-09-08

2016-09-08 Thread Steffen Klassert
1) Fix a crash when xfrm_dump_sa returns an error. From Vegard Nossum. 2) Remove some incorrect WARN() on normal error handling. From Vegard Nossum. 3) Ignore socket policies when rebuilding hash tables, socket policies are not inserted into the hash tables. From Tobias Brunner. 4)

[PATCH 4/6] xfrm: Ignore socket policies when rebuilding hash tables

2016-09-08 Thread Steffen Klassert
From: Tobias Brunner Whenever thresholds are changed the hash tables are rebuilt. This is done by enumerating all policies and hashing and inserting them into the right table according to the thresholds and direction. Because socket policies are also contained in

[PATCH 6/6] xfrm: Only add l3mdev oif to dst lookups

2016-09-08 Thread Steffen Klassert
From: David Ahern Subash reported that commit 42a7b32b73d6 ("xfrm: Add oif to dst lookups") broke a wifi use case that uses fib rules and xfrms. The intent of 42a7b32b73d6 was driven by VRFs with IPsec. As a compromise relax the use of oif in xfrm lookups to L3 master

[PATCH 3/6] xfrm: get rid of another incorrect WARN

2016-09-08 Thread Steffen Klassert
From: Vegard Nossum During fuzzing I regularly run into this WARN(). According to Herbert Xu, this "certainly shouldn't be a WARN, it probably shouldn't print anything either". Cc: Stephen Hemminger Cc: Steffen Klassert

[PATCH 5/6] net/xfrm_input: fix possible NULL deref of tunnel.ip6->parms.i_key

2016-09-08 Thread Steffen Klassert
From: Alexey Kodanev Running LTP 'icmp-uni-basic.sh -6 -p ipcomp -m tunnel' test over openvswitch + veth can trigger kernel panic: BUG: unable to handle kernel NULL pointer dereference at 00e0 IP: [] xfrm_input+0x82/0x750 ... []

[patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg

2016-09-08 Thread Jiri Pirko
From: Nogah Frankel Add a nested attribute of offload stats to if_stats_msg named IFLA_STATS_LINK_OFFLOAD_XSTATS. Under it, add SW stats, meaning stats only per packets that went via slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CPU_HIT. Signed-off-by: Nogah Frankel

Re: [patch net 1/2] mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init

2016-09-08 Thread Ido Schimmel
On Thu, Sep 08, 2016 at 08:16:01AM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > When neigh_init fails, we have to do proper cleanup including > router_fini call. > > Fixes: 6cf3c971dc84cb ("mlxsw: spectrum_router: Add private neigh table") > Signed-off-by: Jiri Pirko

Re: [PATCH net-next V6 0/4] net/sched: ip tunnel metadata set/release/classify by using TC

2016-09-08 Thread Hadar Hen Zion
On Thu, Sep 8, 2016 at 3:32 AM, David Miller wrote: > From: Hadar Hen Zion > Date: Wed, 7 Sep 2016 11:08:02 +0300 > >> This patchset introduces ip tunnel manipulation support using the TC >> subsystem. > > Please address the feedback given by Eric

[PATCH 16/17] xfrm: Fix xfrm_policy_lock imbalance

2016-09-08 Thread Steffen Klassert
An earlier patch accidentally replaced a write_lock_bh with a spin_unlock_bh. Fix this by using spin_lock_bh instead. Fixes: 9d0380df6217 ("xfrm: policy: convert policy_lock to spinlock") Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 2 +- 1 file

[PATCH 09/17] xfrm: policy: prepare policy_bydst hash for rcu lookups

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Since commit 56f047305dd4b6b617 ("xfrm: add rcu grace period in xfrm_policy_destroy()") xfrm policy objects are already free'd via rcu. In order to make more places lockless (i.e. use rcu_read_lock instead of grabbing read-side of policy rwlock) we only

[PATCH 15/17] xfrm: policy: convert policy_lock to spinlock

2016-09-08 Thread Steffen Klassert
From: Florian Westphal After earlier patches conversions all spots acquire the writer lock and we can now convert this to a normal spinlock. Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert ---

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

2016-09-08 Thread Steffen Klassert
On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote: > From: Subash Abhinov Kasiviswanathan > Date: Tue, 6 Sep 2016 18:09:31 -0600 > > > proc_dointvec limits the values to INT_MAX in u32 sysctl entries. > > proc_douintvec allows to write upto UINT_MAX. > > > >

[PATCH 12/17] xfrm: policy: make xfrm_policy_lookup_bytype lockless

2016-09-08 Thread Steffen Klassert
From: Florian Westphal side effect: no longer disables BH (should be fine). Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert --- include/net/netns/xfrm.h | 2 +- net/xfrm/xfrm_policy.c | 4 ++-- 2 files changed, 3

[PATCH 02/17] xfrm: state: use hlist_for_each_entry_rcu helper

2016-09-08 Thread Steffen Klassert
From: Florian Westphal This is required once we allow lockless access of bydst/bysrc hash tables. Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_state.c | 38

pull request (net-next): ipsec-next 2016-09-08

2016-09-08 Thread Steffen Klassert
1) Constify the xfrm_replay structures. From Julia Lawall 2) Protect xfrm state hash tables with rcu, lookups can be done now without acquiring xfrm_state_lock. From Florian Westphal. 3) Protect xfrm policy hash tables with rcu, lookups can be done now without acquiring

[PATCH 08/17] xfrm: policy: use rcu versions for iteration and list add/del

2016-09-08 Thread Steffen Klassert
From: Florian Westphal This is required once we allow lockless readers. Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH 17/17] xfrm: state: remove per-netns gc task

2016-09-08 Thread Steffen Klassert
From: Florian Westphal After commit 5b8ef3415a21f173 ("xfrm: Remove ancient sleeping when the SA is in acquire state") gc does not need any per-netns data anymore. As far as gc is concerned all state structs are the same, so we can use a global work struct for it.

[PATCH 11/17] xfrm: policy: use atomic_inc_not_zero in rcu section

2016-09-08 Thread Steffen Klassert
From: Florian Westphal If we don't hold the policy lock anymore the refcnt might already be 0, i.e. policy struct is about to be free'd. Switch to atomic_inc_not_zero to avoid this. On removal policies are already unlinked from the tables (lists) before the last _put occurs so

[PATCH 14/17] xfrm: policy: don't acquire policy lock in xfrm_spd_getinfo

2016-09-08 Thread Steffen Klassert
From: Florian Westphal It doesn't seem that important. We now get inconsistent view of the counters, but those are stale anyway right after we drop the lock. Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert ---

[PATCH 03/17] xfrm: state: use atomic_inc_not_zero to increment refcount

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Once xfrm_state_lookup_byaddr no longer acquires the state lock another cpu might be freeing the state entry at the same time. To detect this we use atomic_inc_not_zero, we then signal -EAGAIN to caller in case our result was stale. Signed-off-by: Florian

[PATCH 04/17] xfrm: state: delay freeing until rcu grace period has elapsed

2016-09-08 Thread Steffen Klassert
From: Florian Westphal The hash table backend memory and the state structs are free'd via kfree/vfree. Once we only rely on rcu during lookups we have to make sure no other cpu is currently accessing this before doing the free. Free operations already happen from worker so we

[PATCH 10/17] xfrm: policy: add sequence count to sync with hash resize

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Once xfrm_policy_lookup_bytype doesn't grab xfrm_policy_lock anymore its possible for a hash resize to occur in parallel. Use sequence counter to block lookup in case a resize is in progress and to also re-lookup in case hash table was altered in the mean

[PATCH 01/17] xfrm: constify xfrm_replay structures

2016-09-08 Thread Steffen Klassert
From: Julia Lawall The xfrm_replay structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 2

[PATCH 07/17] xfrm: state: don't use lock anymore unless acquire operation is needed

2016-09-08 Thread Steffen Klassert
From: Florian Westphal push the lock down, after earlier patches we can rely on rcu to make sure state struct won't go away. Signed-off-by: Florian Westphal Signed-off-by: Steffen Klassert --- include/net/netns/xfrm.h | 6 +++---

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

2016-09-08 Thread Or Gerlitz
On Thu, Sep 8, 2016 at 1:36 AM, David Miller wrote: > From: Or Gerlitz > Date: Wed, 7 Sep 2016 23:51:56 +0300 > >> On Wed, Sep 7, 2016 at 11:27 PM, David Miller wrote: >>> From: Saeed Mahameed >>> Date:

[PATCH] vhost: mark vhost_process_iotlb_msg() static

2016-09-08 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/vhost/vhost.c:937:5: warning: no previous prototype for 'vhost_process_iotlb_msg' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this

Re: [PATCH 2/4] net: phy: Add MAC-IF driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and valuable comments. I accepted your review comments. I will re-send the code. Thanks, Raju. On Wed, Aug 24, 2016 at 03:06:44PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > +static int vsc85xx_mac_if_set(struct phy_device *phydev, > > +

[PATCH net 4/6] sctp: save transmit error to sk_err in sctp_outq_flush

2016-09-08 Thread Xin Long
Every time when sctp calls sctp_outq_flush, it sends out the chunks of control queue, retransmit queue and data queue. Even if some trunks are failed to transmit, it still has to flush all the transports, as it's the only chance to clean that transmit_list. So the latest transmit error here

Re: linux-next: manual merge of the char-misc tree with the net-next tree

2016-09-08 Thread Greg KH
On Wed, Sep 07, 2016 at 04:51:12PM +, Stephen Hemminger wrote: > It isn't so much about the Pull Request, more about having a single pre-merged > location and making sure that everyone is on the same page for testing. I don't understand. If you want to have a git tree, for testing in

[PATCH v2] qed: mark symbols static where possible

2016-09-08 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_sriov.c:110:6: warning: no previous prototype for 'qed_iov_is_valid_vfid'

RE: [PATCH] qede: mark qede_set_features() static

2016-09-08 Thread Yuval Mintz
> We get 1 warning when building kernel with W=1: > drivers/net/ethernet/qlogic/qede/qede_main.c:2113:5: warning: no previous > prototype for 'qede_set_features' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared and > don't need > a declaration,

[PATCH v2 net-next 2/2] net: phy: Add MAC-IF driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
From: Raju Lakkaraju Used Device Tree to configure the MAC Interface as per review comments and re-sending code for review Signed-off-by: Raju Lakkaraju --- drivers/net/phy/mscc.c | 60

[PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
From: Raju Lakkaraju Used Device Tree to configure the Edge-rate as per review comments and re-sending code for review Signed-off-by: Raju Lakkaraju --- drivers/net/phy/mscc.c | 76 ++

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and given valuable comments. Other driver is not yet complete. I accepted your review comment. I will keep all Register defined MACRO's in mscc.c file. Thanks, Raju. On Fri, Aug 26, 2016 at 03:40:28PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > >

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Or Gerlitz
On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer wrote: > On Wed, 7 Sep 2016 23:55:42 +0300 > Or Gerlitz wrote: > >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> > From: Rana Shahout >> > >> >

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Ingo Molnar
* Daniel Borkmann wrote: > On 09/08/2016 09:01 AM, Ingo Molnar wrote: > >* Peter Zijlstra wrote: > >>On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: > Thanks for the fix. Just saw build bot complaining last night and > by the

[PATCH net] sctp: hold the transport before using it in sctp_hash_cmp

2016-09-08 Thread Xin Long
Now sctp uses the transport without holding it in sctp_hash_cmp, it can cause a use-after-free panic. As after it get transport from hashtable, another CPU may free it, then the members it accesses may be unavailable memory. This patch is to use sctp_transport_hold, in which it checks the refcnt

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Thu, 8 Sep 2016 12:31:47 +0300 Or Gerlitz wrote: > On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer > wrote: > > On Wed, 7 Sep 2016 23:55:42 +0300 > > Or Gerlitz wrote: > > > >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed

Re: [PATCH bug-fix] iproute: fix documentation for ip rule scan order

2016-09-08 Thread Phil Sutter
Hi, On Thu, Sep 08, 2016 at 11:59:55AM +0200, Michal Kubecek wrote: > On Thu, Sep 01, 2016 at 09:04:54AM -0700, Stephen Hemminger wrote: > > On Tue, 30 Aug 2016 17:32:52 -0700 > > Iskren Chernev wrote: > > > > > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00

Re: [PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data

2016-09-08 Thread Jesper Dangaard Brouer
On Wed, 07 Sep 2016 21:52:56 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as > ancillary data") Francesco added IP_TOS values specified as integer. > > However, kernel sends to

[PATCH v2 net-next 0/2] net: phy: Add Edge-rate, MAC-IF driver for Microsemi PHYs

2016-09-08 Thread Raju Lakkaraju
Patch 1/2: This is Edge rate control feature. As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of interference problems like

[PATCH net 3/6] sctp: free msg->chunks when sctp_primitive_SEND return err

2016-09-08 Thread Xin Long
Last patch "sctp: do not return the transmit err back to sctp_sendmsg" made sctp_primitive_SEND return err only when asoc state is unavailable. In this case, chunks are not enqueued, they have no chance to be freed if we don't take care of them later. This Patch is actually to revert commit

[PATCH net 1/6] sctp: remove the unnecessary state check in sctp_outq_tail

2016-09-08 Thread Xin Long
Data Chunks are only sent by sctp_primitive_SEND, in which sctp checks the asoc's state through statetable before calling sctp_outq_tail. So there's no need to do it again in sctp_outq_tail. This patch is to remove it from sctp_outq_tail. Signed-off-by: Xin Long ---

[PATCH net 0/6] sctp: fix the transmit err process

2016-09-08 Thread Xin Long
This patchset is to improve the transmit err process and also fix some issues. After this patchset, once the chunks are enqueued successfully, even if the chunks fail to send out, no matter because of nodst or nomem, no err retruns back to users any more. Instead, they are taken care of by

[PATCH net 2/6] sctp: do not return the transmit err back to sctp_sendmsg

2016-09-08 Thread Xin Long
Once a chunk is enqueued successfully, sctp queues can take care of it. Even if it is failed to transmit (like because of nomem), it should be put into retransmit queue. If sctp report this error to users, it confuses them, they may resend that msg, but actually in kernel sctp stack is in charge

[PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit

2016-09-08 Thread Xin Long
As David and Marcelo's suggestion, ENOMEM err shouldn't return back to user in transmit path. Instead, sctp's retransmit would take care of the chunks that fail to send because of ENOMEM. This patch is only to do some release job when alloc_skb fails, not to return ENOMEM back any more. Besides,

Re: [PATCH bug-fix] iproute: fix documentation for ip rule scan order

2016-09-08 Thread Michal Kubecek
On Thu, Sep 01, 2016 at 09:04:54AM -0700, Stephen Hemminger wrote: > On Tue, 30 Aug 2016 17:32:52 -0700 > Iskren Chernev wrote: > > > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001 > > From: Iskren Chernev > > Date: Tue, 30 Aug 2016 17:08:54

[PATCH net-next 1/1] net: phy: Fixed checkpatch errors for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
From: Raju Lakkaraju The existing VSC85xx PHY driver did not follow the coding style and caused "checkpatch" to complain. This commit fixes this. Signed-off-by: Raju Lakkaraju --- drivers/net/phy/Kconfig | 6 +-

[PATCH] qede: mark qede_set_features() static

2016-09-08 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/net/ethernet/qlogic/qede/qede_main.c:2113:5: warning: no previous prototype for 'qede_set_features' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made

AF_PACKET can't be received on local machine

2016-09-08 Thread Roman Savchenko
Dear all, I created UDP packet with AF_PACKET and SOCK_RAW. It was successfully received on another physical machine, but I have problem to receive it localy. I searched a bit and found that other people have such problem too:

[PATCH net 6/9] net/mlx4_core: Use RCU to perform radix tree lookup for SRQ

2016-09-08 Thread Tariq Toukan
From: Leon Romanovsky Radix tree lookup can be performed without locking. Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters") Suggested-by: Sagi Grimberg Signed-off-by: Leon Romanovsky Signed-off-by:

[PATCH net 3/9] net/mlx4_en: Fix the return value of mlx4_en_dcbnl_set_all()

2016-09-08 Thread Tariq Toukan
From: Kamal Heib mlx4_en_dcbnl_set_all() returns u8, so return value can't be negative in case of failure. Fixes: af7d51852631 ("net/mlx4_en: Add DCB PFC support through CEE netlink commands") Signed-off-by: Kamal Heib Signed-off-by: Rana Shahout

[PATCH net 8/9] net/mlx4_core: Fix to clean devlink resources

2016-09-08 Thread Tariq Toukan
From: Kamal Heib This patch cleans devlink resources by calling devlink_port_unregister() to avoid the following issues: - Kernel panic when triggering reset flow. - Memory leak due to unfreed resources in mlx4_init_port_info(). Fixes: 09d4d087cd48 ("mlx4: Implement

[PATCH net 5/6] sctp: make sctp_outq_flush/tail/uncork return void

2016-09-08 Thread Xin Long
sctp_outq_flush return value is meaningless now, this patch is to make sctp_outq_flush return void, as well as sctp_outq_fail and sctp_outq_uncork. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 4 ++-- net/sctp/outqueue.c| 19 +++

[PATCH net] sctp: identify chunks that need to be fragmented at IP level

2016-09-08 Thread Xin Long
From: Marcelo Ricardo Leitner Previously, without GSO, it was easy to identify it: if the chunk didn't fit and there was no data chunk in the packet yet, we could fragment at IP level. So if there was an auth chunk and we were bundling a big data chunk, it would

[PATCH net 1/9] net/mlx4_en: Add branch prediction hints in RX data-path

2016-09-08 Thread Tariq Toukan
Add likely/unlikely hints to improve branch predictions in the RX data-path. Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH net 0/9] mlx4 fixes

2016-09-08 Thread Tariq Toukan
Hi Dave, This patchset contains several bug fixes from the team to the mlx4 Eth and core drivers. Series generated against net commit: 9dd4aaef194e "MAINTAINERS: Update CPMAC email address" Please push the following patch to -stable >= 4.6 as well: "net/mlx4_core: Fix to clean devlink

[PATCH net 2/9] net/mlx4_en: Fix wrong indentation

2016-09-08 Thread Tariq Toukan
From: Kamal Heib Use tabs instead of spaces before if statement, no functional change. Fixes: e7c1c2c46201 ("mlx4_en: Added self diagnostics test implementation") Signed-off-by: Kamal Heib Signed-off-by: Tariq Toukan ---

[PATCH net 7/9] net/mlx4_core: Fix deadlock when switching between polling and event fw commands

2016-09-08 Thread Tariq Toukan
From: Jack Morgenstein When switching from polling-based fw commands to event-based fw commands, there is a race condition which could cause a fw command in another task to hang: that task will keep waiting for the polling sempahore, but may never be able to acquire it.

[PATCH net 4/9] net/mlx4_en: Fix the return value of mlx4_en_dcbnl_set_state()

2016-09-08 Thread Tariq Toukan
From: Kamal Heib mlx4_en_dcbnl_set_state() returns u8, the return value from mlx4_en_setup_tc() could be negative in case of failure, so fix that. Fixes: af7d51852631 ("net/mlx4_en: Add DCB PFC support through CEE netlink commands") Signed-off-by: Kamal Heib

[PATCH net 9/9] net/mlx4_en: Fix panic on xmit while port is down

2016-09-08 Thread Tariq Toukan
From: Moshe Shemesh When port is down, tx drop counter update is not needed. Updating the counter in this case can cause a kernel panic as when the port is down, ring can be NULL. Fixes: 63a664b7e92b ("net/mlx4_en: fix tx_dropped bug") Signed-off-by: Moshe Shemesh

Re: [PATCH 1/4] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and valuable comments. I accepted your review comments. I too use the Device Tree for Edge-rate and MAC interface configuration. Thanks, Raju. On Wed, Aug 24, 2016 at 02:59:34PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Wed, Aug 24, 2016 at

[PATCH] via-velocity: remove null pointer check on array tdinfo->skb_dma

2016-09-08 Thread Colin King
From: Colin Ian King tdinfo->skb_dma is a 7 element array of dma_addr_t hence cannot be null, so the pull pointer check on tdinfo->skb_dma is redundant. Remove it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/via/via-velocity.c |

Re: [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and valuable comments. On Wed, Aug 24, 2016 at 03:13:47PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Wed, Aug 24, 2016 at 12:27:07PM +, Raju Lakkaraju wrote: > > From: Nagaraju Lakkaraju > > > > PHY Read

*** MICROSOFT FINAL WARNING ***

2016-09-08 Thread Muhammad Fadzli Bin Ali
Outlook A few of your incoming mails were placed on pending status due to the recent upgrade on our database. In order to receive your messages, click on the link below to login and wait for response from Webmail. CLICK HERE We apologise for any

[patch net-next v8 1/3] netdevice: Add offload statistics ndo

2016-09-08 Thread Jiri Pirko
From: Nogah Frankel Add a new ndo to return statistics for offloaded operation. Since there can be many different offloaded operation with many stats types, the ndo gets an attribute id by which it knows which stats are wanted. The ndo also gets a void pointer to be cast

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Ingo Molnar
* Alexei Starovoitov wrote: > On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote: > > The newly added bpf_overflow_handler function is only built of both > > CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller > > only checks the

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: > > > Thanks for the fix. Just saw build bot complaining last night and > > > by the morning your fix is already here. Thanks! > > > > Guys, this is the first time I saw this patch (and

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Or Gerlitz
On Thu, Sep 8, 2016 at 12:53 AM, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 11:55 PM, Or Gerlitz via iovisor-dev > wrote: >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >>> From: Rana Shahout

[patch net 2/2] mlxsw: spectrum: Set port type before setting its address

2016-09-08 Thread Jiri Pirko
From: Ido Schimmel During port init, we currently set the port's type to Ethernet after setting its MAC address. However, the hardware documentation states this should be the other way around. Align the driver with the hardware documentation and set the port's MAC address

Re: [PATCH net-next 0/6] be2net: patch-set

2016-09-08 Thread David Miller
From: Sriharsha Basavapatna Date: Wed, 7 Sep 2016 19:57:48 +0530 > The following patch set contains an error recovery feature and a few > bug fixes. Please consider applying this to the net-next tree. Thanks. > > Patch-1 Supports HW error recovery in

[PATCH 13/17] xfrm: policy: only use rcu in xfrm_sk_policy_lookup

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Don't acquire the readlock anymore and rely on rcu alone. In case writer on other CPU changed policy at the wrong moment (after we obtained sk policy pointer but before we could obtain the reference) just repeat the lookup. Signed-off-by: Florian Westphal

[PATCH] net: x25: remove null checks on arrays calling_ae and called_ae

2016-09-08 Thread Colin King
From: Colin Ian King dtefacs.calling_ae and called_ae are both 20 element __u8 arrays and cannot be null and hence are redundant checks. Remove these. Signed-off-by: Colin Ian King --- net/x25/af_x25.c | 4 1 file changed, 4

README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-08 Thread Jesper Dangaard Brouer
I'm sorry but I have a problem with this patch! Looking at this patch, I want to bring up a fundamental architectural concern with the development direction of XDP transmit. What you are trying to implement, with delaying the doorbell, is basically TX bulking for TX_XDP. Why not implement a

Re: [RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions

2016-09-08 Thread John Fastabend
On 16-09-07 09:23 AM, John Fastabend wrote: > On 16-09-01 10:57 PM, Cong Wang wrote: >> Currently there are only two tc actions lockless: >> gact and mirred. But they are questionable because >> we don't have anything to prevent a parallel update >> on an existing tc action in hash table while

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Bjørn Mork
Hayes Wang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Wednesday, September 07, 2016 9:51 PM > [...] >> So this adds a lot of code to work around the issues you introduced by >> unnecessarily blacklisting the CDC ECM configuration earlier, and still >> makes the

[patch net 0/2] mlxsw: couple of fixes

2016-09-08 Thread Jiri Pirko
From: Jiri Pirko Couple of fixes from Ido and myself. Ido Schimmel (1): mlxsw: spectrum: Set port type before setting its address Jiri Pirko (1): mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init drivers/net/ethernet/mellanox/mlxsw/spectrum.c| 18

[patch net 1/2] mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init

2016-09-08 Thread Jiri Pirko
From: Jiri Pirko When neigh_init fails, we have to do proper cleanup including router_fini call. Fixes: 6cf3c971dc84cb ("mlxsw: spectrum_router: Add private neigh table") Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

Re: [RFC Patch net-next 5/6] net_sched: use rcu in fast path

2016-09-08 Thread John Fastabend
On 16-09-06 07:52 AM, Eric Dumazet wrote: > On Thu, 2016-09-01 at 22:57 -0700, Cong Wang wrote: > > > > Missing changelog ? > Yeah this stuff is a bit tricky more notes to walk us through this would be helpful. (btw you can disregard my comment from earlier this morning I've tracked most of

[patch net-next v8 3/3] mlxsw: spectrum: Implement offload stats ndo and expose HW stats by default

2016-09-08 Thread Jiri Pirko
From: Nogah Frankel Change the default statistics ndo to return HW statistics (like the one returned by ethtool_ops). The HW stats are collected to a cache by delayed work every 1 sec. Implement the offload stat ndo. Add a function to get SW statistics, to be called from

[patch net-next v8 0/3] return offloaded stats as default and expose original sw stats

2016-09-08 Thread Jiri Pirko
From: Jiri Pirko The problem we try to handle is about offloaded forwarded packets which are not seen by kernel. Let me try to draw it: port1 port2 (HW stats are counted here) \ / \/

[PATCH 06/17] xfrm: state: use rcu_deref and assign_pointer helpers

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Before xfrm_state_find() can use rcu_read_lock instead of xfrm_state_lock we need to switch users of the hash table to assign/obtain the pointers with the appropriate rcu helpers. Signed-off-by: Florian Westphal Signed-off-by: Steffen

[PATCH 05/17] xfrm: state: add sequence count to detect hash resizes

2016-09-08 Thread Steffen Klassert
From: Florian Westphal Once xfrm_state_find is lockless we have to cope with a concurrent resize opertion. We use a sequence counter to block in case a resize is in progress and to detect if we might have missed a state that got moved to a new hash table. Signed-off-by: Florian

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Wed, 7 Sep 2016 20:07:01 +0300 Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 7:54 PM, Tom Herbert wrote: > > On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed > > wrote: > >> On Wed, Sep 7, 2016 at 4:32 PM, Or

Re: [RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

2016-09-08 Thread Richard Cochran
On Thu, Sep 08, 2016 at 10:22:43AM +0530, Harini Katakam wrote: > I cant be sure of the version of Cadence GEM used in SAMA5D2 > but these registers (sub ns increments alteast) only exist in > the IP version used in Zynq Ultrascale+ MPSoC. Then you need to find a way to make sure the driver only

Re: [Patch v6] net: ethernet: xilinx: Enable emaclite for MIPS

2016-09-08 Thread Zubair Lutfullah Kakakhel
Hi, On 09/08/2016 12:07 AM, David Miller wrote: From: Zubair Lutfullah Kakakhel Date: Mon, 5 Sep 2016 13:07:54 +0100 The MIPS based xilfpga platform uses this driver. Enable it for MIPS Signed-off-by: Zubair Lutfullah Kakakhel --- V1

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

2016-09-08 Thread David Miller
From: Steffen Klassert Date: Thu, 8 Sep 2016 07:51:17 +0200 > On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote: >> From: Subash Abhinov Kasiviswanathan >> Date: Tue, 6 Sep 2016 18:09:31 -0600 >> >> > proc_dointvec limits the

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Wed, 7 Sep 2016 23:55:42 +0300 Or Gerlitz wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > > From: Rana Shahout > > > > Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. > > > > When XDP is on we

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Daniel Borkmann
On 09/08/2016 09:01 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: Thanks for the fix. Just saw build bot complaining last night and by the morning your fix is already here. Thanks! Guys, this is the first

pull-request: wireless-drivers 2016-09-08

2016-09-08 Thread Kalle Valo
Hi Dave, few important, but as can be seen from the diffstat, really small fixes for 4.8. Please let me know if you have any problems. Kalle The following changes since commit bb87f02b7e4ccdb614a83cbf840524de81e9b321: Merge ath-current from ath.git (2016-08-29 21:39:04 +0300) are available

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Kalle Valo
Bjorn Andersson writes: > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > channel, as such it should be a SMD client. This patch makes this > transition, now that we have the necessary frameworks available. > > Signed-off-by: Bjorn Andersson

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

2016-09-08 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby I assume Jes will take

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jamal Hadi Salim
On 16-09-07 08:42 AM, Saeed Mahameed wrote: Comparison is done between: 1. Baseline, Before this patch with TC drop action 2. This patch with TC drop action 3. This patch with XDP RX fast drop StreamsBaseline(TC drop)TC dropXDP fast Drop

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread Ilpo Järvinen
On Wed, 7 Sep 2016, Eric Dumazet wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 >

[PATCH net-next 3/7] rxrpc: Convert rxrpc_local::services to an hlist

2016-09-08 Thread David Howells
Convert the rxrpc_local::services list to an hlist so that it can be accessed under RCU conditions more readily. Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c | 10 +- net/rxrpc/ar-internal.h |4 ++-- net/rxrpc/call_accept.c |2 +-

Re: [PATCH bug-fix] iproute: fix documentation for ip rule scan order

2016-09-08 Thread Phil Sutter
On Thu, Sep 08, 2016 at 01:48:08PM +0200, Michal Kubecek wrote: > On Thu, Sep 08, 2016 at 12:33:03PM +0200, Phil Sutter wrote: > > On Thu, Sep 08, 2016 at 11:59:55AM +0200, Michal Kubecek wrote: > > > > > > I'm sorry I didn't notice before but this just reverts the change done > > > by commit

RE: [PATCH net] sctp: hold the transport before using it in sctp_hash_cmp

2016-09-08 Thread David Laight
From: Xin Long > Sent: 08 September 2016 10:49 > Now sctp uses the transport without holding it in sctp_hash_cmp, > it can cause a use-after-free panic. As after it get transport from > hashtable, another CPU may free it, then the members it accesses > may be unavailable memory. How old is this

Re: [PATCH net-next v3] gso: Support partial splitting at the frag_list pointer

2016-09-08 Thread Steffen Klassert
On Mon, Sep 05, 2016 at 10:30:44AM -0700, Alexander Duyck wrote: > On Mon, Sep 5, 2016 at 3:47 AM, Steffen Klassert > wrote: > > Since commit 8a29111c7 ("net: gro: allow to build full sized skb") > > gro may build buffers with a frag_list. This can hurt forwarding >

  1   2   3   >