[PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-12 Thread John Crispin
This patch contains initial support for the QCA8337 switch. It will detect a QCA8337 switch, if present and declared in the DT. Each port will be represented through a standalone net_device interface, as for other DSA switches. CPU can communicate with any of the ports by setting an IP@ on ethN

[PATCH 1/3] Documentation: devicetree: add qca8k binding

2016-09-12 Thread John Crispin
Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin --- .../devicetree/bindings/net/dsa/qca8k.txt | 53 1 file changed, 53 insertions(+) create mode 100644

Re: [PATCH net-next 7/7] cxgb4: add support for drop and redirect actions

2016-09-12 Thread Jiri Pirko
Mon, Sep 12, 2016 at 10:12:40AM CEST, rahul.lakkire...@chelsio.com wrote: >Add support for dropping matched packets in hardware. Also add support >for re-directing matched packets to a specified port in hardware. > >Signed-off-by: Rahul Lakkireddy >Signed-off-by:

Re: [PATCH v4 15/16] IB: Add PVRDMA driver

2016-09-12 Thread kbuild test robot
ase= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Adit-Ranadive/Add-Paravirtual-RDMA-Driver/20160912-125631 con

[PATCH 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

2016-09-12 Thread John Crispin
Add support for the 2-bytes Qualcomm tag that gigabit switches such as the QCA8337/N might insert when receiving packets, or that we need to insert while targeting specific switch ports. The tag is inserted directly behind the ethernet header. Signed-off-by: John Crispin ---

[PATCH 0/3] net-next: dsa: add QCA8K support

2016-09-12 Thread John Crispin
This series is based on the AR8xxx series posted by Matthieu Olivari in may 2015. The following changes were made since then * fixed the nitpicks from the previous review * updated to latest API * turned it into an mdio device * added callbacks for fdb, bridge offloading, stp, eee, port status *

[PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

2016-09-12 Thread Colin King
From: Colin Ian King The newline escape is incorrect and needs fixing. Also adjust source formatting / indentation and remove trailing white space. Signed-off-by: Colin Ian King --- drivers/atm/iphase.c | 5 ++--- 1 file changed, 2

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-12 Thread Jesper Dangaard Brouer
On Fri, 9 Sep 2016 18:03:09 +0300 Saeed Mahameed wrote: > On Fri, Sep 9, 2016 at 6:22 AM, Alexei Starovoitov via iovisor-dev > wrote: > > On Thu, Sep 08, 2016 at 10:11:47AM +0200, Jesper Dangaard Brouer wrote: > >> > >> I'm sorry but I

Re: [PATCH net-next 5/7] cxgb4: add support for setting u32 filters

2016-09-12 Thread Jiri Pirko
Mon, Sep 12, 2016 at 10:12:38AM CEST, rahul.lakkire...@chelsio.com wrote: >Add support for offloading u32 filter onto hardware. Links are stored >in a jump table to perform necessary jumps to match TCP/UDP header. >When inserting rules in the linked bucket, the TCP/UDP match fields >in the

Re: [PATCH net-next 6/7] cxgb4: add support for deleting u32 filters

2016-09-12 Thread Jiri Pirko
Mon, Sep 12, 2016 at 10:12:39AM CEST, rahul.lakkire...@chelsio.com wrote: >Add support for deleting an offloaded u32 filter from hardware. If a >link is deleted, then all corresponding filters associated with the link >are also deleted. Also enable hardware tc offload as a supported >feature. >

Re: [PATCH net-next 2/7] cxgb4: add common api support for configuring filters

2016-09-12 Thread Jiri Pirko
Mon, Sep 12, 2016 at 10:12:35AM CEST, rahul.lakkire...@chelsio.com wrote: >Enable filters for non-offload configuration and add common api support >for setting and deleting filters in LE-TCAM region of the hardware. > >IPv4 filters occupy one slot. IPv6 filters occupy 4 slots and must >be on a

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

Re: [PATCH v2] cfg80211: Remove deprecated create_singlethread_workqueue

2016-09-12 Thread Johannes Berg
On Wed, 2016-08-31 at 00:35 +0530, Bhaktipriya Shridhar wrote: > The workqueue "cfg80211_wq" is involved in cleanup, scan and event > related > works. It queues multiple work items >event_work, > >dfs_update_channels_wk, > _to_rdev(request->wiphy)->scan_done_wk, >

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-09-12 Thread Maxime Ripard
On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote: > This patch add the dt node for the syscon register present on the > Allwinner H3. > > Only two register are present in this syscon and the only one useful is > the one dedicated to EMAC clock. > > Signed-off-by: Corentin Labbe

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents but: > > 1. You *can* use a static

Re: [PATCH 25/26] pch_gbe: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, David Miller wrote: > > Julia, I went over the networking driver patches in this series and > I have to say that I'd rather see these changes be more durable > and self-checking. > > By this I mean that I want you to also make the driver private pointer > that holds these

Re: [PATCH net-next 3/7] cxgb4: add debugfs support to dump filter debug logs

2016-09-12 Thread Jiri Pirko
Mon, Sep 12, 2016 at 10:12:36AM CEST, rahul.lakkire...@chelsio.com wrote: >Add debugfs support to dump filter debug information. Please no debugfs. Why would you want to use it? Use a well defined user api instead. If not available, please introduce it. > >Signed-off-by: Rahul Lakkireddy

Re: README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-12 Thread Jesper Dangaard Brouer
On Thu, 8 Sep 2016 23:30:50 -0700 Alexei Starovoitov wrote: > On Fri, Sep 09, 2016 at 07:36:52AM +0200, Jesper Dangaard Brouer wrote: > > > > Lets do bundling/bulking from the start! > > > > > > mlx4 already does bulking and this proposed mlx5 set of patches >

[PATCH] net: dsa: add FIB support

2016-09-12 Thread John Crispin
Add SWITCHDEV_OBJ_ID_IPV4_FIB support to the DSA layer. Signed-off-by: John Crispin --- Documentation/networking/dsa/dsa.txt | 18 +++ include/net/dsa.h| 13 +++ net/dsa/slave.c | 41

[PATCH v2 net 1/1] net sched actions: fix GETing actions

2016-09-12 Thread Jamal Hadi Salim
From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list we lost in the translation the fact that tcf_action_destroy() will eventually delete the action from the permanent location if the refcount is zero. Example of what broke:

Re: [PATCH net 0/2] ip: fix creation flags reported in RTM_NEWROUTE events

2016-09-12 Thread Guillaume Nault
On Fri, Sep 09, 2016 at 04:51:26PM -0700, David Miller wrote: > From: Guillaume Nault > Date: Wed, 7 Sep 2016 17:18:50 +0200 > > > Netlink messages sent to user-space upon RTM_NEWROUTE events have their > > nlmsg_flags field inconsistently set. While the NLM_F_REPLACE and >

Re: [PATCH net] net_sched: act_mirred: full rcu conversion

2016-09-12 Thread Cong Wang
On Fri, Sep 9, 2016 at 8:52 AM, John Fastabend wrote: > On 16-09-08 10:26 PM, Cong Wang wrote: >> On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote: >>> On Thu, 2016-09-08 at 08:47 -0700, John Fastabend wrote: >>> Works for me. FWIW I find

[PATCH net-next 1/7] cxgb4: move common filter code to separate file

2016-09-12 Thread Rahul Lakkireddy
Move common filter code to separate files. Also fix the following checkpatch checks. CHECK: Comparison to NULL could be written "!f->l2t" + if (f->l2t == NULL) { CHECK: spaces preferred around that '/' (ctx:VxV) + fwr->len16_pkd = htonl(FW_WR_LEN16_V(sizeof(*fwr)/16));

[PATCH net-next 0/7] cxgb4: add support for offloading TC u32 filters

2016-09-12 Thread Rahul Lakkireddy
This series of patches add support to offload TC u32 filters onto Chelsio NICs. Patch 1 moves current common filter code to separate files in order to provide a common api for performing packet classification and filtering in Chelsio NICs. Patch 2 enables filters for normal NIC configuration and

Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

2016-09-12 Thread Maxime Ripard
On Fri, Sep 09, 2016 at 02:45:13PM +0200, Corentin Labbe wrote: > The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 > speed. > > This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. > The SoC H3 have an internal PHY, so optionals syscon and ephy are set. > >

Re: [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit()

2016-09-12 Thread Nicolas Ferre
Le 10/09/2016 à 13:17, Wei Yongjun a écrit : > From: Wei Yongjun > > Fix missing unlock before return from function macb_start_xmit() > in the error handling case. > > Fixes: 007e4ba3ee13 ("net: macb: initialize checksum when using > checksum offloading") >

[PATCH net-next 4/7] cxgb4: add parser to translate u32 filters to internal spec

2016-09-12 Thread Rahul Lakkireddy
Parse information sent by u32 into internal filter specification. Add support for parsing several fields in IPv4, IPv6, TCP, and UDP. Signed-off-by: Rahul Lakkireddy Signed-off-by: Hariprasad Shenai ---

[PATCH net-next 2/7] cxgb4: add common api support for configuring filters

2016-09-12 Thread Rahul Lakkireddy
Enable filters for non-offload configuration and add common api support for setting and deleting filters in LE-TCAM region of the hardware. IPv4 filters occupy one slot. IPv6 filters occupy 4 slots and must be on a 4-slot boundary. IPv4 filters can not occupy a slot belonging to IPv6 and the

[PATCH net-next 5/7] cxgb4: add support for setting u32 filters

2016-09-12 Thread Rahul Lakkireddy
Add support for offloading u32 filter onto hardware. Links are stored in a jump table to perform necessary jumps to match TCP/UDP header. When inserting rules in the linked bucket, the TCP/UDP match fields in the corresponding entry of the jump table are appended to the filter rule before

[PATCH net-next 6/7] cxgb4: add support for deleting u32 filters

2016-09-12 Thread Rahul Lakkireddy
Add support for deleting an offloaded u32 filter from hardware. If a link is deleted, then all corresponding filters associated with the link are also deleted. Also enable hardware tc offload as a supported feature. Signed-off-by: Rahul Lakkireddy Signed-off-by:

[PATCH net-next 7/7] cxgb4: add support for drop and redirect actions

2016-09-12 Thread Rahul Lakkireddy
Add support for dropping matched packets in hardware. Also add support for re-directing matched packets to a specified port in hardware. Signed-off-by: Rahul Lakkireddy Signed-off-by: Hariprasad Shenai ---

[PATCH net-next 3/7] cxgb4: add debugfs support to dump filter debug logs

2016-09-12 Thread Rahul Lakkireddy
Add debugfs support to dump filter debug information. Signed-off-by: Rahul Lakkireddy Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 4 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 415

RE: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-09-12 Thread Y.B. Lu
Hi Scott, Thanks for your review :) See my comment inline. > -Original Message- > From: Scott Wood [mailto:o...@buserror.net] > Sent: Friday, September 09, 2016 11:47 AM > To: Y.B. Lu; linux-...@vger.kernel.org; ulf.hans...@linaro.org; Arnd > Bergmann > Cc: linuxppc-...@lists.ozlabs.org;

Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig

2016-09-12 Thread Maxime Ripard
Hi, On Fri, Sep 09, 2016 at 02:45:16PM +0200, Corentin Labbe wrote: > Enable the sun8i-emac driver in the sunxi default configuration > > Signed-off-by: Corentin Labbe Could you make the same patch for multi_v7 ? Thanks, Maxime -- Maxime Ripard, Free Electrons

[PATCH] net: inet: diag: Fix an error handling

2016-09-12 Thread Christophe JAILLET
If 'inet_diag_lock_handler()' returns an error, we should not call 'inet_diag_unlock_handler()' on it. 'handler' is not a valid mutexc in this case. This has been spotted with the folowing coccinelle script: @@ expression x; identifier f; @@ * if (IS_ERR(x)) {

Re: [PATCH v4 15/16] IB: Add PVRDMA driver

2016-09-12 Thread kbuild test robot
ase= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Adit-Ranadive/Add-Paravirtual-RDMA-Driver/20160912-125631 config: i

Re: [PATCH 08/26] iwlegacy: constify local structures

2016-09-12 Thread Stanislaw Gruszka
On Sun, Sep 11, 2016 at 03:05:50PM +0200, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level

Re: [PATCH] net: dsa: add FIB support

2016-09-12 Thread kbuild test robot
Hi John, [auto build test ERROR on net-next/master] [also build test ERROR on next-20160912] [cannot apply to v4.8-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=a

Re: [PATCH 1/3] Documentation: devicetree: add qca8k binding

2016-09-12 Thread Sergei Shtylyov
On 9/12/2016 11:35 AM, John Crispin wrote: Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin --- .../devicetree/bindings/net/dsa/qca8k.txt | 53 1 file changed, 53 insertions(+)

Re: [PATCH 25/26] pch_gbe: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

Re: README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-12 Thread Jesper Dangaard Brouer
On Thu, 8 Sep 2016 23:30:50 -0700 Alexei Starovoitov wrote: > On Fri, Sep 09, 2016 at 07:36:52AM +0200, Jesper Dangaard Brouer wrote: [...] > > Imagine you have packets intermixed towards the stack and XDP_TX. > > Every time you call the stack code, then you flush

Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

2016-09-12 Thread Sergei Shtylyov
Hello. On 9/12/2016 12:29 PM, Colin King wrote: From: Colin Ian King The newline escape is incorrect and needs fixing. Also adjust source formatting / indentation and remove trailing white space. Signed-off-by: Colin Ian King ---

[PATCH] net: r6040: add in missing white space in error message text

2016-09-12 Thread Colin King
From: Colin Ian King A couple of dev_err messages span two lines and the literal string is missing a white space between words. Add the white space. Signed-off-by: Colin Ian King --- drivers/net/ethernet/rdc/r6040.c | 4 ++-- 1 file changed,

[PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-12 Thread Hadar Hen Zion
Remove rcu_read_lock protection from tunnel_key_dump and use rtnl_dereference, dump operation is protected by rtnl lock. Also, remove rcu_read_lock from tunnel_key_release and use rcu_dereference_protected. Both operations are running exclusively and a writer couldn't modify t->params while

Re: [PATCH 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

2016-09-12 Thread Andrew Lunn
Hi John > + > +static inline int reg_to_port(int reg) > +{ > + if (reg < 5) > + return reg + 1; > + > + return -1; > +} > + > +static inline int port_to_reg(int port) > +{ > + if (port >= 1 && port <= 6) > + return port - 1; > + > + return -1; > +} No need

Re: [PATCH 11/26] can: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

[patch net-next 3/5] mlxsw: spectrum: Report port type according to operational speed

2016-09-12 Thread Jiri Pirko
From: Ido Schimmel In case port isn't operational we shouldn't report the port type, but instead return PORT_OTHER. This is consistent with most other drivers that return PORT_OTHER when media type can't be determined. Signed-off-by: Ido Schimmel

[patch net-next 1/5] mlxsw: spectrum: Correctly report autonegotiation

2016-09-12 Thread Jiri Pirko
From: Ido Schimmel Up until now the device always reported autonegotiation to be off although it was on by default. Allow the user to disable / enable autonegotiation and report its status correctly. Signed-off-by: Ido Schimmel Signed-off-by: Jiri

[patch net-next 0/5] mlxsw: ethtool enhancements

2016-09-12 Thread Jiri Pirko
From: Jiri Pirko Ido says: Patches 1-4 do some minor cleanup in current ethtool ops. Patch 5 replace legacy {get,set}_settings callbacks with {get,set}_link_ksettings. Ido Schimmel (5): mlxsw: spectrum: Correctly report autonegotiation mlxsw: spectrum: Report link

[patch net-next 5/5] mlxsw: spectrum: Add support for new ethtool API

2016-09-12 Thread Jiri Pirko
From: Ido Schimmel Remove the deprecated {get,set}_settings callbacks and instead add {get,set}_link_ksettings along with support for newly available speeds. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next 2/5] mlxsw: spectrum: Report link partner's advertised speeds

2016-09-12 Thread Jiri Pirko
From: Ido Schimmel If autonegotiation was performed successfully, then we should report the link partner's advertised speeds instead of the operational speed of the port. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next 4/5] mlxsw: spectrum: Indicate support of multiple port types

2016-09-12 Thread Jiri Pirko
From: Ido Schimmel The device can support multiple port types, so don't return on first match. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 +--- 1 file changed, 5

Re: [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-12 Thread Vitaly Kuznetsov
David Vrabel writes: > On 22/08/16 16:42, Vitaly Kuznetsov wrote: >> Small packet loss is reported on complex multi host network configurations >> including tunnels, NAT, ... My investigation led me to the following check >> in netback which drops packets: >> >>

Re: [net-next PATCH v2 2/2] e1000: bundle xdp xmit routines

2016-09-12 Thread Jesper Dangaard Brouer
On Fri, 9 Sep 2016 18:19:56 -0700 Tom Herbert wrote: > On Fri, Sep 9, 2016 at 6:12 PM, John Fastabend > wrote: > > On 16-09-09 06:04 PM, Tom Herbert wrote: > >> On Fri, Sep 9, 2016 at 5:01 PM, John Fastabend > >>

Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

2016-09-12 Thread Sergei Shtylyov
Hello. On 9/12/2016 12:29 PM, Colin King wrote: From: Colin Ian King The newline escape is incorrect and needs fixing. Also adjust source formatting / indentation and remove trailing white space. Signed-off-by: Colin Ian King ---

Re: [PATCH 20/26] stmmac: pci: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

[PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Jakub Kicinski
Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") made flow dissector look at vlan_proto when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 (including VLAN_TAG_PRESENT) we have to populate skb->vlan_proto. Fixes false negative on test #24:

Re: [PATCH 05/26] ARCNET: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

[PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2016-09-12 Thread Colin King
From: Colin Ian King The newline escape is incorrect and needs fixing. Also adjust source formatting / indentation and add { } to trailing else. Signed-off-by: Colin Ian King --- drivers/atm/iphase.c | 6 +++--- 1 file changed, 3

Re: [PATCH] net: dsa: add FIB support

2016-09-12 Thread kbuild test robot
Hi John, [auto build test WARNING on net-next/master] [also build test WARNING on next-20160912] [cannot apply to v4.8-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=a

Re: [net-next PATCH v2 2/2] e1000: bundle xdp xmit routines

2016-09-12 Thread Jesper Dangaard Brouer
On Fri, 09 Sep 2016 14:29:38 -0700 John Fastabend wrote: > e1000 supports a single TX queue so it is being shared with the stack > when XDP runs XDP_TX action. This requires taking the xmit lock to > ensure we don't corrupt the tx ring. To avoid taking and dropping the

Re: [PATCH] net: r6040: add in missing white space in error message text

2016-09-12 Thread Sergei Shtylyov
Hello. On 9/12/2016 3:08 PM, Colin King wrote: From: Colin Ian King A couple of dev_err messages span two lines and the literal string is missing a white space between words. Add the white space. Signed-off-by: Colin Ian King ---

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-12 Thread Andrew Lunn
> +static u32 > +qca8k_mii_read32(struct mii_bus *bus, int phy_id, u32 regnum) > +{ > + u16 lo, hi; > + > + lo = bus->read(bus, phy_id, regnum); > + hi = bus->read(bus, phy_id, regnum + 1); > + > + return (hi << 16) | lo; > +} > + > +static void > +qca8k_mii_write32(struct mii_bus

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that makes this change is as follows: > > >

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > > Constify local structures. > > > > > > > > The

[PATCH net-next 0/5] mlx4 misc fixes and improvements

2016-09-12 Thread Tariq Toukan
Hi Dave, This patchset contains some bug fixes, a cleanup, and small improvements from the team to the mlx4 Eth and core drivers. Series generated against net-next commit: 02154927c115 "net: dsa: bcm_sf2: Get VLAN_PORT_MASK from b53_device" Please push the following patch to -stable >= 4.6 as

[PATCH net-next 5/5] net/mlx4_core: Fix to clean devlink resources

2016-09-12 Thread Tariq Toukan
From: Kamal Heib This patch cleans devlink resources by calling devlink_port_unregister() to avoid the following issues: - Kernel panic when triggering reset flow. - Memory leak due to unfreed resources in mlx4_init_port_info(). Fixes: 09d4d087cd48 ("mlx4: Implement

[PATCH net-next 3/5] net/mlx4_core: Use RCU to perform radix tree lookup for SRQ

2016-09-12 Thread Tariq Toukan
From: Leon Romanovsky Radix tree lookup can be performed without locking. Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters") Suggested-by: Sagi Grimberg Signed-off-by: Leon Romanovsky Signed-off-by:

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

RE: [patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg

2016-09-12 Thread Nogah Frankel
> -Original Message- > From: Nikolay Aleksandrov [mailto:niko...@cumulusnetworks.com] > Sent: Friday, September 09, 2016 4:39 PM > To: Nikolay Aleksandrov > Cc: Jiri Pirko ; Linux Kernel Network Developers > ; David

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
On Mon, Sep 12, 2016 at 3:43 PM, Felipe Balbi wrote: > Jarkko Sakkinen writes: >> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >>> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >>> > On Sun, Sep 11, 2016 at 03:05:42PM

[PATCH net-next 2/5] net/mlx4_en: Fix wrong indentation

2016-09-12 Thread Tariq Toukan
From: Kamal Heib Use tabs instead of spaces before if statement, no functional change. Fixes: e7c1c2c46201 ("mlx4_en: Added self diagnostics test implementation") Signed-off-by: Kamal Heib Signed-off-by: Tariq Toukan ---

[PATCH net-next 1/5] net/mlx4_en: Add branch prediction hints in RX data-path

2016-09-12 Thread Tariq Toukan
Add likely/unlikely hints to improve branch predictions in the RX data-path. Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH net-next 4/5] net/mlx4_core: Fix deadlock when switching between polling and event fw commands

2016-09-12 Thread Tariq Toukan
From: Jack Morgenstein When switching from polling-based fw commands to event-based fw commands, there is a race condition which could cause a fw command in another task to hang: that task will keep waiting for the polling sempahore, but may never be able to acquire it.

Re: [PATCH v4 1/6] net: stmmac: dwmac-rk: add rk3366 & rk3399 specific data

2016-09-12 Thread Rob Herring
On Fri, Sep 02, 2016 at 01:49:59AM +0800, Caesar Wang wrote: > From: Roger Chen > > Add constants and callback functions for the dwmac on rk3228/rk3229 socs. > As can be seen, the base structure is the same, only registers and the > bits in them moved slightly. > >

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Daniel Borkmann
On 09/12/2016 02:04 PM, Jakub Kicinski wrote: Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") made flow dissector look at vlan_proto when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 (including VLAN_TAG_PRESENT) we have to populate

Re: [PATCH V3] dt: net: enhance DWC EQoS binding to support Tegra186

2016-09-12 Thread Rob Herring
On Thu, Sep 08, 2016 at 11:49:31AM -0600, Stephen Warren wrote: > On 09/01/2016 01:02 PM, Stephen Warren wrote: > >From: Stephen Warren > > > >The Synopsys DWC EQoS is a configurable IP block which supports multiple > >options for bus type, clocking and reset structure, and

Re: [PATCH] net: dsa: add FIB support

2016-09-12 Thread kbuild test robot
own) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/John-Crispin/net-dsa-add-FIB-support/20160912-190416 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia

[PATCH iproute2 net-next v1 0/7] tipc: updates for neighbour monitor

2016-09-12 Thread Parthasarathy Bhuvaragan
We add configuration support for the new link monitoring attributes. Parthasarathy Bhuvaragan (7): tipc: remove dead code tipc: add link monitor set threshold tipc: add link monitor get threshold tipc: add link monitor summary tipc: refractor bearer to facilitate link monitor tipc:

Re: [PATCH net] net_sched: act_mirred: full rcu conversion

2016-09-12 Thread John Fastabend
On 16-09-11 11:12 PM, Cong Wang wrote: > On Fri, Sep 9, 2016 at 8:52 AM, John Fastabend > wrote: >> On 16-09-08 10:26 PM, Cong Wang wrote: >>> On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote: On Thu, 2016-09-08 at 08:47 -0700, John

[RFC 03/11] Add support for RoCE HW init

2016-09-12 Thread Ram Amrani
Allocate and setup RoCE resources, interrupts and completion queues. Adds device attributes. Signed-off-by: Rajesh Borundia Signed-off-by: Ram Amrani --- drivers/infiniband/hw/qedr/main.c | 408 +++-

Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module

2016-09-12 Thread Alexandre Torgue
Hi Javier, On 09/12/2016 04:03 PM, Javier Martinez Canillas wrote: The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of

Re: icmpv6: issue with routing table entries from link local addresses

2016-09-12 Thread Hannes Frederic Sowa
Hello, On 12.09.2016 16:27, Andreas Hübner wrote: > Hi, > > I'm currently debugging a potential issue with the icmpv6 stack and > hopefully this is the correct place to ask. (Was actually looking for a > more specific list, but didn't find anything. Please point me to a more > apropriate list if

[PATCHv2 next 1/3] ipv6: Export p6_route_input_lookup symbol

2016-09-12 Thread Mahesh Bandewar
From: Mahesh Bandewar Make ip6_route_input_lookup available outside of ipv6 the module similar to ip_route_input_noref in the IPv4 world. Signed-off-by: Mahesh Bandewar --- include/net/ip6_route.h | 3 +++ net/ipv6/route.c| 7 --- 2 files

Re: [PATCH v4 00/16] Add Paravirtual RDMA Driver

2016-09-12 Thread Jason Gunthorpe
On Sun, Sep 11, 2016 at 09:49:10PM -0700, Adit Ranadive wrote: > [2] Libpvrdma User-level library - > http://git.openfabrics.org/?p=~aditr/libpvrdma.git;a=summary You will probably find that rdma-plumbing will be the best way to get your userspace component into the distributors.

Re: [net-next PATCH v2 2/2] e1000: bundle xdp xmit routines

2016-09-12 Thread John Fastabend
On 16-09-12 05:17 AM, Jesper Dangaard Brouer wrote: > On Fri, 09 Sep 2016 14:29:38 -0700 > John Fastabend wrote: > >> e1000 supports a single TX queue so it is being shared with the stack >> when XDP runs XDP_TX action. This requires taking the xmit lock to >> ensure we

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-12 Thread Marcelo
On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: > This is to use the generic interface snmp_get_cpu_field{,64}_batch to > aggregate the data by going through all the items of each cpu sequentially. > Then snmp_seq_show and netstat_seq_show are split into 2 parts to avoid build > warning

Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show

2016-09-12 Thread Marcelo
On Fri, Sep 09, 2016 at 02:33:58PM +0800, Jia He wrote: > This is to use the generic interface snmp_get_cpu_field{,64}_batch to > aggregate the data by going through all the items of each cpu sequentially. > > Signed-off-by: Jia He > --- > net/ipv6/proc.c | 32

Re: [PATCH net-next 2/2] errqueue: include linux/time.h

2016-09-12 Thread kbuild test robot
Hi Willem, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/uapi-include-time-h-from-errqueue-h/20160913-020431 config: i386-defconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 reproduce: # save the

Re: [PATCH net 3/6] sctp: free msg->chunks when sctp_primitive_SEND return err

2016-09-12 Thread Marcelo Ricardo Leitner
On Thu, Sep 08, 2016 at 05:31:47PM +0800, Xin Long wrote: > Last patch "sctp: do not return the transmit err back to sctp_sendmsg" > made sctp_primitive_SEND return err only when asoc state is unavailable. > In this case, chunks are not enqueued, they have no chance to be freed if > we don't take

Re: [ovs-dev] [PATCH 2/2] openvswitch: use percpu flow stats

2016-09-12 Thread pravin shelar
On Fri, Sep 9, 2016 at 1:41 PM, Thadeu Lima de Souza Cascardo wrote: > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. > > On a E5-2690 12-core system, usual throughput went from ~4Mpps to >

[PATCH net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-09-12 Thread Jarod Wilson
With centralized MTU checking, there's nothing productive done by eth_change_mtu that isn't already done in dev_set_mtu, so mark it as deprecated and remove all usage of it in the kernel. All callers have been audited for calls to alloc_etherdev* or ether_setup directly, which means they all have

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Alexei Starovoitov
On Mon, Sep 12, 2016 at 01:04:57PM +0100, Jakub Kicinski wrote: > Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan > info from skb->vlan_tci") made flow dissector look at vlan_proto > when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 > (including VLAN_TAG_PRESENT) we

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Parav Pandit
On Mon, Sep 12, 2016 at 10:09 PM, Leon Romanovsky wrote: > On Mon, Sep 12, 2016 at 07:07:34PM +0300, Ram Amrani wrote: > >> include/linux/qed/common_hsi.h |1 + >> include/linux/qed/qed_if.h |9 +- >> include/linux/qed/qed_ll2_if.h

Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

2016-09-12 Thread Sergei Shtylyov
Hello. On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Net policy needs to know device information. Currently, it's enough to only get irq information of rx and tx queues. This patch introduces ndo ops to do so, not ethtool ops. Because there are

Re: [RFC V3 PATCH 22/26] net/netpolicy: set per task policy by proc

2016-09-12 Thread Sergei Shtylyov
On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Users may not want to change the source code to add per task net polic Policy? support. Or they may want to change a running task's net policy. prctl does not work for both cases. This patch adds

Re: [RFC V3 PATCH 00/26] Kernel NET policy

2016-09-12 Thread Cong Wang
On Mon, Sep 12, 2016 at 8:38 AM, Florian Westphal wrote: > kan.li...@intel.com wrote: >> From: Kan Liang >> >> It is a big challenge to get good network performance. First, the network >> performance is not good with default system

  1   2   3   >