Re: [PATCH v2] bnx2: Reset device during driver initialization

Just to be clear, I did actually apply this v2 of the patch rather than the initial version.:)

Re: [PATCH] bnx2: Reset device during driver initialization

From: Baoquan He Date: Fri, 9 Sep 2016 16:11:07 +0800 > When system enters into kdump kernel because of kernel panic, it won't > shutdown devices. On-flight DMA will continue transferring data until > device driver initializes. All devices are supposed to reset during > driver

[net-next PATCH 09/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_req()

Add cxgb_mk_abort_req() to remove duplicate code to form CPL_ABORT_REQ hardware command. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 13 - drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 16

[net-next PATCH 08/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_close_con_req()

Add cxgb_mk_close_con_req() to remove duplicate code to form CPL_CLOSE_CON_REQ hardware command. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 13 - drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 16

[net-next PATCH 10/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_abort_rpl()

Add cxgb_mk_abort_rpl() to remove duplicate code to form CPL_ABORT_RPL hardware command. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 10 -- drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 14 ++

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov Date: Sun, 11 Sep 2016 22:17:15 +0300 > On Sat, Sep 10, 2016 at 04:28:40PM -0600, David Ahern wrote: >> On 9/10/16 4:05 PM, Cyrill Gorcunov wrote: >> > On Sat, Sep 10, 2016 at 10:31:35AM -0600, David Ahern wrote: >> >> >> >> Would you mind adding the

[net-next PATCH 03/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route6()

Add cxgb_find_route6() in libcxgb_cm.c to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 70 ++-

[net-next PATCH 11/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_rx_data_ack()

Add cxgb_mk_rx_data_ack() to remove duplicate code to form CPL_RX_DATA_ACK hardware command. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 19 --- drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 15 +++

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Tue, 2016-09-13 at 16:20 +0100, Edward Cree wrote: > On 12/09/16 11:15, Jesper Dangaard Brouer wrote: > > I'm reacting so loudly, because this is a mental model switch, that > > need to be applied to the full drivers RX path. Also for normal stack > > delivery of SKBs. As both Edward Cree[1]

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

> Hi Andrew, > > this function does indeed duplicate the functionality of > phy_ethtool_get_eee() with the small difference, that e->eee_active is > also set which phy_ethtool_get_eee() does not set. > > dsa_slave_get_eee() will call phy_ethtool_get_eee() right after the > get_eee() op has been

[net-next PATCH 04/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_is_neg_adv()

Add cxgb_is_neg_adv() in libcxgb_cm.h to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 15 +++ drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 9

Re: [PATCH RFC 03/11] net/mlx5e: Implement RX mapped page cache for page recycle

On Tue, 13 Sep 2016 13:16:29 +0300 Tariq Toukan wrote: > On 07/09/2016 9:45 PM, Jesper Dangaard Brouer wrote: > > On Wed, 7 Sep 2016 15:42:24 +0300 Saeed Mahameed > > wrote: > > > >> From: Tariq Toukan > >> > >> Instead of

Re: [PATCH V3] net-next: dsa: add FIB support

On 13/09/2016 18:21, Vivien Didelot wrote: > Hi John, > > John Crispin writes: > >> @@ -237,6 +237,7 @@ struct switchdev_obj; >> struct switchdev_obj_port_fdb; >> struct switchdev_obj_port_mdb; >> struct switchdev_obj_port_vlan; >> +struct switchdev_obj_ipv4_fib; > > Can

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On 12/09/16 11:15, Jesper Dangaard Brouer wrote: > I'm reacting so loudly, because this is a mental model switch, that > need to be applied to the full drivers RX path. Also for normal stack > delivery of SKBs. As both Edward Cree[1] and I[2] have demonstrated, > there is between 10%-25% perf gain

Re: [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit()

From: Wei Yongjun Date: Sat, 10 Sep 2016 11:17:57 + > From: Wei Yongjun > > Fix missing unlock before return from function macb_start_xmit() > in the error handling case. > > Fixes: 007e4ba3ee13 ("net: macb: initialize checksum when using >

Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

On Mon, Sep 12, 2016 at 4:07 PM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > With the batch changes that translated transient actions into > a temporary list lost in the translation was the fact that > tcf_action_destroy() will eventually delete the

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

On Tue, 13 Sep 2016 08:58:30 -0700 Eric Dumazet wrote: > We also care about icache pressure, and GRO/TSO already provides > bundling where it is applicable, without adding insane complexity in > the stacks. Sorry, I cannot resist. The GRO code is really bad regarding

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

On Mon, Sep 12, 2016 at 08:42:41PM -0700, Alexander Duyck wrote: > On Mon, Sep 12, 2016 at 3:13 PM, John Fastabend > wrote: > > From: Alexei Starovoitov > > > > This patch adds initial support for XDP on e1000 driver. Note e1000 > > driver does not support

Re: [RFC 07/11] Add support for memory registeration verbs

+struct qedr_mr *__qedr_alloc_mr(struct ib_pd *ibpd, int max_page_list_len) +{ + struct qedr_pd *pd = get_qedr_pd(ibpd); + struct qedr_dev *dev = get_qedr_dev(ibpd->device); + struct qedr_mr *mr; + int rc = -ENOMEM; + + DP_VERBOSE(dev, QEDR_MSG_MR, +

Re: [PATCH 0/4] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Tue, 13 Sep 2016 11:05:13 +0200 > The following patchset contains Netfilter fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks Pablo.

Re: [PATCHv2 net] sctp: hold the transport before using it in sctp_hash_cmp

From: Xin Long Date: Sat, 10 Sep 2016 23:11:23 +0800 > Since commit 4f0087812648 ("sctp: apply rhashtable api to send/recv > path"), sctp uses transport rhashtable with .obj_cmpfn sctp_hash_cmp, > in which it compares the members of the transport with the rhashtable > args

Re: [patch net-next 0/5] mlxsw: ethtool enhancements

From: Jiri Pirko Date: Mon, 12 Sep 2016 13:26:22 +0200 > From: Jiri Pirko > > Ido says: > > Patches 1-4 do some minor cleanup in current ethtool ops. Patch 5 > replace legacy {get,set}_settings callbacks with > {get,set}_link_ksettings. Series applied,

Re: [PATCH 2/2] net: ethernet: apm: xgene: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 11 Sep 2016 17:54:04 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: apm: xgene: use phydev from struct net_device

From: Philippe Reynes Date: Sun, 11 Sep 2016 17:54:03 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy_dev in the private structure, and update the driver to use the > one

[net-next PATCH 06/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_compute_wscale()

Add cxgb_compute_wscale() in libcxgb_cm.h to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 12 ++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h| 9

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On Tue, Sep 13, 2016 at 11:57:35AM -0400, David Miller wrote: > > > > Thanks for review, David. I updated against net-next. > > Please do not post new versions of patches as replies to existing > discussions. > > Instead, make fresh patch postings to the list. Oh, will do. Sorry for

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, Sep 13, 2016 at 09:21:47AM -0700, Tom Herbert wrote: > On Mon, Sep 12, 2016 at 6:28 PM, Alexei Starovoitov > wrote: > > On Mon, Sep 12, 2016 at 05:03:25PM -0700, Tom Herbert wrote: > >> On Mon, Sep 12, 2016 at 4:46 PM, Eric Dumazet >

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

On Tue, Sep 13, 2016 at 08:44:06AM +, Ram Amrani wrote: > Hi Jason, > I see that "include/uapi/rdma" contains API that is common. It is intended to contain *all* the uapi. > The qedr_user.h, that I assume you are referring to, is a qedr specific API. > For example, we issue the

[net-next PATCH 05/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_best_mtu()

Add cxgb_best_mtu() in libcxgb_cm.h to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 32 +++ drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h |

[net-next PATCH 01/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple()

Add cxgb_get_4tuple() in libcxgb_cm.c to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/Kconfig | 1 + drivers/infiniband/hw/cxgb4/Makefile | 1 +

[net-next PATCH 02/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()

Add cxgb_find_route() in libcxgb_cm.c to remove it's duplicate definitions from cxgb4/cm.c and cxgbit/cxgbit_cm.c. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 53 +++

Re: [PATCH net-next 0/7] cxgb4: add support for offloading TC u32 filters

From: Rahul Lakkireddy Date: Mon, 12 Sep 2016 13:42:33 +0530 > This series of patches add support to offload TC u32 filters onto > Chelsio NICs. > > Patch 1 moves current common filter code to separate files > in order to provide a common api for performing packet

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

On Mon, Sep 12, 2016 at 6:28 PM, Alexei Starovoitov wrote: > On Mon, Sep 12, 2016 at 05:03:25PM -0700, Tom Herbert wrote: >> On Mon, Sep 12, 2016 at 4:46 PM, Eric Dumazet wrote: >> > On Mon, 2016-09-12 at 16:07 -0700, Alexei Starovoitov

Re: [PATCH V3] net-next: dsa: add FIB support

Hi John, John Crispin writes: > @@ -237,6 +237,7 @@ struct switchdev_obj; > struct switchdev_obj_port_fdb; > struct switchdev_obj_port_mdb; > struct switchdev_obj_port_vlan; > +struct switchdev_obj_ipv4_fib; Can you keep it ordered please (put obj_ipv4 above port_fdb). >

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: > Hi, > > On 09/13/2016 01:56 PM, Pablo Neira Ayuso wrote: > > On Mon, Sep 12, 2016 at 06:12:09PM +0200, Daniel Mack wrote: > >> This is v5 of the patch set to allow eBPF programs for network > >> filtering and accounting to be attached

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Hello, On Sat, Sep 10, 2016 at 11:33:48AM +0200, Dmitry Vyukov wrote: > Hit the WARNING with the patch. It showed "Showing busy workqueues and > worker pools:" after the WARNING, but then no queue info. Was it > already destroyed and removed from the list?... Hmm... It either means that the

Re: [PATCH -next] net: ethernet: dwmac: fix non static symbol warning

From: Wei Yongjun Date: Sat, 10 Sep 2016 12:31:30 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:172:1: warning: > symbol 'stm32_dwmac_pm_ops' was not declared. Should it be

[net-next PATCH 07/11] libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()

Add cxgb_mk_tid_release() to remove duplicate code to form CPL_TID_RELEASE hardware command. Signed-off-by: Varun Prakash --- drivers/infiniband/hw/cxgb4/cm.c | 10 -- drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 13 +

[net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

This patch series removes duplicate code from iw_cxgb4 and cxgbit by adding common function definitions in libcxgb. Please review. Thanks Varun Varun Prakash (11): libcxgb,iw_cxgb4,cxgbit: add cxgb_get_4tuple() libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route() libcxgb,iw_cxgb4,cxgbit: add

Re: [PATCH -next] tipc: fix possible memory leak in tipc_udp_enable()

From: Wei Yongjun Date: Sat, 10 Sep 2016 00:56:55 + > From: Wei Yongjun > > 'ub' is malloced in tipc_udp_enable() and should be freed before > leaving from the error handling cases, otherwise it will cause > memory leak. > > Fixes: ba5aa84a2d22

Re: [PATCH] drivers: net: phy: xgene: Fix 'remove' function

From: Christophe JAILLET Date: Sun, 11 Sep 2016 21:43:34 +0200 > If 'IS_ERR(pdata->clk)' is true, then 'clk_disable_unprepare(pdata->clk)' > will do nothing. > > It is likely that 'if (!IS_ERR(pdata->clk))' was expected here. > In fact, the test can even be

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

Hi Andrew, Andrew Lunn writes: >> ok, i will simply substract 1 from the phy_addr inside the mdio >> callbacks. this would make the code more readable and make the DT >> binding compliant with the ePAPR spec. > > It does however need well commenting. It is setting a trap for

[PATCH v3] net: ip, diag -- Add diag interface for raw sockets

In criu we are actively using diag interface to collect sockets present in the system when dumping applications. And while for unix, tcp, udp[lite], packet, netlink it works as expected, the raw sockets do not have. Thus add it. v2: - add missing sock_put calls in raw_diag_dump_one (by

Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 07:33 -0700, Eric Dumazet wrote: > Hi Marcin > > Well, given the above comment, and fact that MVNETA_MAX_TXD == 532, it > looks like you might add a bug if more than 256 skb are given to your > ndo_start_xmit() with skb->xmit_more = 1 > > I therefore suggest you make sure

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 09/13/2016 08:59 AM, Andrew Lunn wrote: >> Hi Andrew, >> >> this function does indeed duplicate the functionality of >> phy_ethtool_get_eee() with the small difference, that e->eee_active is >> also set which phy_ethtool_get_eee() does not set. >> >> dsa_slave_get_eee() will call

Re: [PATCH net-next 1/2] net: mvneta: add xmit_more support

On Tue, 2016-09-13 at 09:00 +0200, Marcin Wojtas wrote: > From: Simon Guinot > > Basing on xmit_more flag of the skb, TX descriptors can be concatenated > before flushing. This commit delay Tx descriptor flush if the queue is > running and if there is more skb's to

Re: [PATCH] net: Remove NO_IRQ from powerpc-only network drivers

From: Michael Ellerman Date: Sat, 10 Sep 2016 19:59:05 +1000 > We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it > from powerpc-only drivers. > > Signed-off-by: Michael Ellerman Applied to net-next, thanks.

Re: [PATCH V3] net-next: dsa: add FIB support

Hi John, John Crispin writes: > i sent an email to Jiri earlier today and he asked me to drop this > until his notification series got merged. That makes sense then. So David should ignore this for the moment. Thanks, Vivien

[PATCHv2 net 2/6] sctp: do not return the transmit err back to sctp_sendmsg

Once a chunk is enqueued successfully, sctp queues can take care of it. Even if it is failed to transmit (like because of nomem), it should be put into retransmit queue. If sctp report this error to users, it confuses them, they may resend that msg, but actually in kernel sctp stack is in charge

[PATCHv2 net 1/6] sctp: remove the unnecessary state check in sctp_outq_tail

Data Chunks are only sent by sctp_primitive_SEND, in which sctp checks the asoc's state through statetable before calling sctp_outq_tail. So there's no need to check the asoc's state again in sctp_outq_tail. Besides, sctp_do_sm is protected by lock_sock, even if sending msg is interrupted by

[PATCHv2 net 0/6] sctp: fix the transmit err process

This patchset is to improve the transmit err process and also fix some issues. After this patchset, once the chunks are enqueued successfully, even if the chunks fail to send out, no matter because of nodst or nomem, no err retruns back to users any more. Instead, they are taken care of by

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 19:09, Florian Fainelli wrote: > On 09/13/2016 08:59 AM, Andrew Lunn wrote: >>> Hi Andrew, >>> >>> this function does indeed duplicate the functionality of >>> phy_ethtool_get_eee() with the small difference, that e->eee_active is >>> also set which phy_ethtool_get_eee() does not

Re: [PATCH net-next] MAINTAINERS: Add an entry for the core network DSA code

> F:drivers/net/dsa/ > > Other than that, LGTM I was a bit hesitant to go that far. We have individual entries for b53 and mv88e6xxx, but not for bcm_sf2. But O.K, v2 on the way. Andrew

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, Sep 13, 2016 at 10:37:32AM -0700, Eric Dumazet wrote: > On Tue, 2016-09-13 at 10:13 -0700, Alexei Starovoitov wrote: > > > I'm afraid the point 'only for debugging' still didn't make it across. > > xdp+e1k is for development (and debugging) of xdp-type of bpf > > programs and _not_ for

[PATCHv2 net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit

As David and Marcelo's suggestion, ENOMEM err shouldn't return back to user in transmit path. Instead, sctp's retransmit would take care of the chunks that fail to send because of ENOMEM. This patch is only to do some release job when alloc_skb fails, not to return ENOMEM back any more. Besides,

[PATCHv2 net 5/6] sctp: make sctp_outq_flush/tail/uncork return void

sctp_outq_flush return value is meaningless now, this patch is to make sctp_outq_flush return void, as well as sctp_outq_fail and sctp_outq_uncork. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 4 ++-- net/sctp/outqueue.c| 19 +++

[PATCHv2 net 3/6] sctp: free msg->chunks when sctp_primitive_SEND return err

Last patch "sctp: do not return the transmit err back to sctp_sendmsg" made sctp_primitive_SEND return err only when asoc state is unavailable. In this case, chunks are not enqueued, they have no chance to be freed if we don't take care of them later. This Patch is actually to revert commit

[PATCHv2 net 4/6] sctp: save transmit error to sk_err in sctp_outq_flush

Every time when sctp calls sctp_outq_flush, it sends out the chunks of control queue, retransmit queue and data queue. Even if some trunks are failed to transmit, it still has to flush all the transports, as it's the only chance to clean that transmit_list. So the latest transmit error here

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 21:07, Andrew Lunn wrote: >> Since the former alternative is prefered, we may want to remove the >> latter soon from DSA. If this phy_port_map is needed for that case, it'd >> be preferable not to add it. > > O.K, so maybe we should solve it the device tree way: > > > {

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, 2016-09-13 at 10:13 -0700, Alexei Starovoitov wrote: > I'm afraid the point 'only for debugging' still didn't make it across. > xdp+e1k is for development (and debugging) of xdp-type of bpf > programs and _not_ for debugging of xdp itself, kernel or anything else. > The e1k provided

Re: [PATCH net 1/6] sctp: remove the unnecessary state check in sctp_outq_tail

> > I also don't see an issue with this patch, btw. > > Xin, you may want to add more/such details to the changelog, specially > about the timer versus primitive handling. > OK, I will post v2 of this patchset.

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 09/13/2016 11:07 AM, John Crispin wrote: > > > On 13/09/2016 19:09, Florian Fainelli wrote: >> On 09/13/2016 08:59 AM, Andrew Lunn wrote: Hi Andrew, this function does indeed duplicate the functionality of phy_ethtool_get_eee() with the small difference, that e->eee_active

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: Alexei Starovoitov wrote: I've looked through qemu and it appears only emulate e1k and tg3. The latter is still used in the field, so the

Re: [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, Sep 13, 2016 at 10:13 AM, Alexei Starovoitov wrote: > On Tue, Sep 13, 2016 at 09:21:47AM -0700, Tom Herbert wrote: >> On Mon, Sep 12, 2016 at 6:28 PM, Alexei Starovoitov >> wrote: >> > On Mon, Sep 12, 2016 at 05:03:25PM -0700,

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

On 09/13/2016, 05:35 PM, Tejun Heo wrote: > Hello, > > On Sat, Sep 10, 2016 at 11:33:48AM +0200, Dmitry Vyukov wrote: >> Hit the WARNING with the patch. It showed "Showing busy workqueues and >> worker pools:" after the WARNING, but then no queue info. Was it >> already destroyed and removed from

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: > Alexei Starovoitov wrote: > > >I've looked through qemu and it appears only emulate e1k and tg3. > >The latter is still used in the field, so the risk of touching > >it is higher. > > I have no idea

Re: [PATCH net-next 3/3] net: ethernet: mediatek: add dts configuration to enable HW LRO

On 09/13/2016 06:54 AM, Nelson Chang wrote: > Add the configuration of HW LRO in the binding document. > > Signed-off-by: Nelson Chang > --- > Documentation/devicetree/bindings/net/mediatek-net.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

On 16-09-13 12:20 PM, Cong Wang wrote: On Mon, Sep 12, 2016 at 4:07 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that

Re: [PATCH net-next 2/3] net: ethernet: mediatek: add ethtool functions to configure RX flows of HW LRO

On 09/13/2016 06:54 AM, Nelson Chang wrote: > The codes add ethtool functions to set RX flows for HW LRO. Because the > HW LRO hardware can only recognize the destination IP of TCP/IP RX flows, > the ethtool command to add HW LRO flow is as below: > ethtool -N [devname] flow-type tcp4 dst-ip

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

Alexei Starovoitov wrote: I've looked through qemu and it appears only emulate e1k and tg3. The latter is still used in the field, so the risk of touching it is higher. I have no idea what makes you think that e1k is *not* "used in the field". I grant you it

Re: [PATCH net-next] MAINTAINERS: Add an entry for the core network DSA code

On 09/13/2016 12:00 PM, Andrew Lunn wrote: > The core distributed switch architecture code currently does not have > a MAINTAINERS entry, which results in some contributions not landing > in the right peoples inbox. > > Signed-off-by: Andrew Lunn > --- > MAINTAINERS | 7 +++

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On Tue, 2016-09-13 at 20:19 +0300, Cyrill Gorcunov wrote: > In criu we are actively using diag interface to collect sockets > present in the system when dumping applications. And while for > unix, tcp, udp[lite], packet, netlink it works as expected, > the raw sockets do not have. Thus add it. >

[PATCH net-next] MAINTAINERS: Add an entry for the core network DSA code

The core distributed switch architecture code currently does not have a MAINTAINERS entry, which results in some contributions not landing in the right peoples inbox. Signed-off-by: Andrew Lunn --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

> Since the former alternative is prefered, we may want to remove the > latter soon from DSA. If this phy_port_map is needed for that case, it'd > be preferable not to add it. O.K, so maybe we should solve it the device tree way: { phy_port1: phy@0 {

[PATCH net-next 1/4] rxrpc: Create an address for sendmsg() to bind unbound socket with

Create an address for sendmsg() to bind unbound socket with rather than using a completely blank address otherwise the transport socket creation will fail because it will try to use address family 0. We use the address family specified in the protocol argument when the AF_RXRPC socket was created

[PATCH net-next 3/4] rxrpc: Use rxrpc_extract_addr_from_skb() rather than doing this manually

There are two places that want to transmit a packet in response to one just received and manually pick the address to reply to out of the sk_buff. Make them use rxrpc_extract_addr_from_skb() instead so that IPv6 is handled automatically. Signed-off-by: David Howells ---

[PATCH net-next 2/4] rxrpc: Don't specify protocol to when creating transport socket

Pass 0 as the protocol argument when creating the transport socket rather than IPPROTO_UDP. Signed-off-by: David Howells --- net/rxrpc/local_object.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/local_object.c

[PATCH net-next 4/4] rxrpc: Add IPv6 support

Add IPv6 support to AF_RXRPC. With this, AF_RXRPC sockets can be created: service = socket(AF_RXRPC, SOCK_DGRAM, PF_INET6); instead of: service = socket(AF_RXRPC, SOCK_DGRAM, PF_INET); The AFS filesystem doesn't support IPv6 at the moment, though, since that requires upgrades

Re: [PATCH v2] bnx2: Reset device during driver initialization

On 09/13/16 at 11:25am, David Miller wrote: > > Just to be clear, I did actually apply this v2 of the patch > rather than the initial version.:) Thanks a lot!

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 10:41:12PM +, Rustad, Mark D wrote: That said, I can see that you have tried to keep the original code path pretty much intact. I would note that you introduced rcu calls into the !bpf path that would never

re

Did you get my message?

Re: Modification to skb->queue_mapping affecting performance

On Tue, 2016-09-13 at 15:59 -0700, Michael Ma wrote: > Hi - > > We currently use mqprio on ifb to work around the qdisc root lock > contention on the receiver side. The problem that we found was that > queue_mapping is already set when redirecting from ingress qdisc to > ifb (based on RX

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

Rustad, Mark D : > Alexei Starovoitov wrote: [...] > > the point that it's only used virtualized, since PCI (not PCIE) have > > been long dead. > > My point is precisely the opposite. It is a real device, it exists in real > systems and it

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 07:14:27PM +, Rustad, Mark D wrote: Alexei Starovoitov wrote: On Tue, Sep 13, 2016 at 06:28:03PM +, Rustad, Mark D wrote: Alexei Starovoitov

[PATCH net-next 0/4] rxrpc: Support IPv6

://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160913-2 David --- David Howells (4): rxrpc: Create an address for sendmsg() to bind unbound socket with rxrpc: Don't specify protocol to when creating transport socket rxrpc: Use

Re: Modification to skb->queue_mapping affecting performance

On Tue, 2016-09-13 at 16:30 -0700, Michael Ma wrote: > The RX queue number I found from "ls /sys/class/net/eth0/queues" is > 64. (is this the correct way of identifying the queue number on NIC?) > I setup ifb with 24 queues which is equal to the TX queue number of > eth0 and also the number of

Modification to skb->queue_mapping affecting performance

Hi - We currently use mqprio on ifb to work around the qdisc root lock contention on the receiver side. The problem that we found was that queue_mapping is already set when redirecting from ingress qdisc to ifb (based on RX selection, I guess?) so the TX queue selection is not based on priority.

Re: [Intel-wired-lan] [net-next PATCH v3 2/3] e1000: add initial XDP support

On Tue, Sep 13, 2016 at 10:41:12PM +, Rustad, Mark D wrote: > That said, I can see that you have tried to keep the original code path > pretty much intact. I would note that you introduced rcu calls into the !bpf > path that would never have been done before. While that should be ok, I > would

Re: Modification to skb->queue_mapping affecting performance

2016-09-13 17:09 GMT-07:00 Eric Dumazet : > On Tue, 2016-09-13 at 16:30 -0700, Michael Ma wrote: > >> The RX queue number I found from "ls /sys/class/net/eth0/queues" is >> 64. (is this the correct way of identifying the queue number on NIC?) >> I setup ifb with 24 queues

[PATCH v2 4/6] selftests: move vDSO tests from Documentation/vDSO

Remove vDSO from Makefile to move the to selftests. Update vDSO Makefile to work under selftests. vDSO will not be run as part of selftests suite and will not be included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan ---

[PATCH v2 1/6] selftests: move dnotify_test from Documentation/filesystems

Move dnotify_test.c, Makefile, and .gitignore from Documentation/filesystems to selftests/filesystems. Remove filesystems build target from Documentation/Makefile and update selftests/filesystems/Makefile to work under selftests. dnotify_test will not be run as part of selftests suite and will

[PATCH v2 5/6] selftests: move ia64 tests from Documentation/ia64

Remove ia64 from Makefile to move the test to selftests. Update ia64 Makefile to work under selftests. ia64 will not be run as part of selftests suite and will not be included in install targets. They can be built separately for now. The original Makefile built this test on all archirectures and

Re: [PATCH net-next] openvswitch: avoid deferred execution of recirc actions

On Tue, Sep 13, 2016 at 7:08 AM, Lance Richardson wrote: > The ovs kernel data path currently defers the execution of all > recirc actions until stack utilization is at a minimum. > This is too limiting for some packet forwarding scenarios due to > the small size of the

[PATCH net-next 03/10] rxrpc: The IDLE ACK packet should use rxrpc_idle_ack_delay

The IDLE ACK packet should use the rxrpc_idle_ack_delay setting when the timer is set for it. Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c

[PATCH net-next 10/10] rxrpc: Correctly initialise, limit and transmit call->rx_winsize

call->rx_winsize should be initialised to the sysctl setting and the sysctl setting should be limited to the maximum we want to permit. Further, we need to place this in the ACK info instead of the sysctl setting. Furthermore, discard the idea of accepting the subpackets of a jumbo packet that

[PATCH net-next 06/10] rxrpc: Use skb->len not skb->data_len

skb->len should be used rather than skb->data_len when referring to the amount of data in a packet. This will only cause a malfunction in the following cases: (1) We receive a jumbo packet (validation and splitting both are wrong). (2) We see if there's extra ACK info in an ACK packet (we

[PATCH net-next 05/10] rxrpc: Add missing unlock in rxrpc_call_accept()

Add a missing unlock in rxrpc_call_accept() in the path taken if there's no call to wake up. Signed-off-by: David Howells --- net/rxrpc/call_accept.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/call_accept.c

[PATCH net-next 04/10] rxrpc: Requeue call for recvmsg if more data

rxrpc_recvmsg() needs to make sure that the call it has just been processing gets requeued for further attention if the buffer has been filled and there's more data to be consumed. The softirq producer only queues the call and wakes the socket if it fills the first slot in the window, so

[PATCH net-next 07/10] rxrpc: Allow tx_winsize to grow in response to an ACK

Allow tx_winsize to grow when the ACK info packet shows a larger receive window at the other end rather than only permitting it to shrink. Signed-off-by: David Howells --- net/rxrpc/input.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 09/10] rxrpc: Fix prealloc refcounting

The preallocated call buffer holds a ref on the calls within that buffer. The ref was being released in the wrong place - it worked okay for incoming calls to the AFS cache manager service, but doesn't work right for incoming calls to a userspace service. Instead of releasing an extra ref service

  1   2   3   >