RE: [RFC 07/11] Add support for memory registeration verbs

2016-09-14 Thread Kalderon, Michal
> > +struct qedr_mr *__qedr_alloc_mr(struct ib_pd *ibpd, int > > +max_page_list_len) { > > + struct qedr_pd *pd = get_qedr_pd(ibpd); > > + struct qedr_dev *dev = get_qedr_dev(ibpd->device); > > + struct qedr_mr *mr; > > + int rc = -ENOMEM; > > + > > + DP_VERBOSE(dev, QEDR_MSG_MR, > > +

[PATCH 0/2] pull request for net: batman-adv 2016-09-14

2016-09-14 Thread Simon Wunderlich
14:31:23 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20160914 for you to fetch changes up to 1e5d343b8f23770e8ac5d31f5c439826bdb35148: batman-adv: fix elp packet data reservation (2016-08-26 15:22:31 +0

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
Hello Tariq, On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > If an error occurs in mlx4_init_eq_table the index used in the > > err_out_unmap label is one too big which results in a panic in > > mlx4_free_eq. This patch fixes the index in the error path.

[PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap label is one too big which results in a panic in mlx4_free_eq. This patch fixes the index in the error path. Signed-off-by: Sebastian Ott --- drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++--

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Yuval Shaia
Please update vmxnet3_drv.c accordingly. Yuval On Sun, Sep 11, 2016 at 09:49:11PM -0700, Adit Ranadive wrote: > The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver. > Moved it to the shared location in pci_ids.h. > > Suggested-by: Leon Romanovsky >

[net v1] fib_rules: interface group matching

2016-09-14 Thread Vincent Bernat
When a user wants to assign a routing table to a group of incoming interfaces, the current solutions are: - one IP rule for each interface (scalability problems) - use of fwmark and devgroup matcher (don't work with internal route lookups, used for example by RPF) - use of VRF devices (more

Re: [PATCH v4 11/16] IB/pvrdma: Add support for memory regions

2016-09-14 Thread Yuval Shaia
No more comments. Reviewed-by: Yuval Shaia On Sun, Sep 11, 2016 at 09:49:21PM -0700, Adit Ranadive wrote: > This patch adds support for creating and destroying memory regions. The > PVRDMA device supports User MRs, DMA MRs (no Remote Read/Write support), > Fast Register

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-14 Thread Daniel Borkmann
On 09/14/2016 12:30 PM, Pablo Neira Ayuso wrote: On Tue, Sep 13, 2016 at 09:42:19PM -0700, Alexei Starovoitov wrote: [...] For us this cgroup+bpf is _not_ for filterting and _not_ for security. If your goal is monitoring, then convert these hooks not to allow to issue a verdict on the packet,

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-14 Thread Tariq Toukan
On 08/09/2016 12:31 PM, Or Gerlitz wrote: On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer wrote: On Wed, 7 Sep 2016 23:55:42 +0300 Or Gerlitz wrote: On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: From: Rana

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Christoph Hellwig
> + props->max_fmr = dev->dsr->caps.max_fmr; > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr; Please don't add FMR support to any new drivers.

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-14 Thread Daniel Mack
Hi Pablo, On 09/13/2016 07:24 PM, Pablo Neira Ayuso wrote: > On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: >> On 09/13/2016 01:56 PM, Pablo Neira Ayuso wrote: >>> On Mon, Sep 12, 2016 at 06:12:09PM +0200, Daniel Mack wrote: This is v5 of the patch set to allow eBPF programs

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-14 Thread Daniel Borkmann
On 09/14/2016 01:13 PM, Daniel Mack wrote: On 09/13/2016 07:24 PM, Pablo Neira Ayuso wrote: On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: On 09/13/2016 01:56 PM, Pablo Neira Ayuso wrote: On Mon, Sep 12, 2016 at 06:12:09PM +0200, Daniel Mack wrote: This is v5 of the patch set

[PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-09-14 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rftclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rftclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the

[PATCH 2/9] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-09-14 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 41

[PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify consumer's code and CPTS driver porting on other SoC in the future (like Keystone 2). Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 16 +--- drivers/net/ethernet/ti/cpsw.h | 2

[PATCH 0/9] net: ethernet: ti: cpts: update and fixes

2016-09-14 Thread Grygorii Strashko
Hi, It is preparation serie intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. It also include some non critical fixes: net: ethernet: ti: exclude cpts from build when disabled net: ethernet: ti: cpts: fix overflow check

[PATCH 1/9] net: ethernet: ti: exclude cpts from build when disabled

2016-09-14 Thread Grygorii Strashko
TI CPTS feature declared as optional, but cpts.c module is included in build always. Exclude cpts.c from build when CPTS is disabled in Kconfig and optimize usage of CONFIG_TI_CPTS. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/Makefile | 3 ++-

[PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-09-14 Thread Grygorii Strashko
From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive and timestamps the ptp packets which eventually occupy all the event list entries. When this happns, the added code

[PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-09-14 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) is pretty entangled and has some issues, like: - ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization; - CPTS ref_clk

[PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and rx timestamp funcitons

2016-09-14 Thread Grygorii Strashko
From: WingMan Kwok Added return values in tx and rx timestamp funcitons facilitate the possibililies of timestamping by CPSW modules other than CPTS, such as packet accelerator on Keystone 2 devices. Signed-off-by: WingMan Kwok Signed-off-by: Grygorii Strashko

Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:26PM +0300, Grygorii Strashko wrote: > Move DT properties parsing into CPTS driver to simplify consumer's > code and CPTS driver porting on other SoC in the future > (like Keystone 2). And just who is the consumer? > Signed-off-by: Grygorii Strashko

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Yuval Shaia
On Sun, Sep 11, 2016 at 09:49:15PM -0700, Adit Ranadive wrote: > + > +/** > + * pvrdma_alloc_pd - allocate protection domain > + * @ibdev: the IB device > + * @context: user context > + * @udata: user data > + * > + * @return: the ib_pd protection domain pointer on success, otherwise errno. > + */

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread Vincent Bernat
❦ 14 septembre 2016 14:40 CEST, Vincent Bernat  : > Each interface can be assigned to a numeric group using IFLA_GROUP. This > commit enables a user to reference such a group into an IP rule. Here is > an example of output of iproute2: > > $ ip rule show > 0: from

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-14 Thread Thomas Graf
On 09/14/16 at 12:30pm, Pablo Neira Ayuso wrote: > On Tue, Sep 13, 2016 at 09:42:19PM -0700, Alexei Starovoitov wrote: > [...] > > For us this cgroup+bpf is _not_ for filterting and _not_ for security. > > If your goal is monitoring, then convert these hooks not to allow to > issue a verdict on

Re: [PATCH v4 06/16] IB/pvrdma: Add paravirtual rdma device

2016-09-14 Thread Yuval Shaia
No more comments. Reviewed-by: Yuval Shaia On Sun, Sep 11, 2016 at 09:49:16PM -0700, Adit Ranadive wrote: > This patch adds the main device-level structures and functions to be used > to provide RDMA functionality. Also, we define conversion functions from > the IB core

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-14 Thread Marcelo
Hi Jia, On Wed, Sep 14, 2016 at 01:58:42PM +0800, hejianet wrote: > Hi Marcelo > > > On 9/13/16 2:57 AM, Marcelo wrote: > > On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: > > > This is to use the generic interface snmp_get_cpu_field{,64}_batch to > > > aggregate the data by going

Re: [PATCH v4 07/16] IB/pvrdma: Add helper functions

2016-09-14 Thread Yuval Shaia
No more comments. Reviewed-by: Yuval Shaia On Sun, Sep 11, 2016 at 09:49:17PM -0700, Adit Ranadive wrote: > This patch adds helper functions to store guest page addresses in a page > directory structure. The page directory pointer is passed down to the > backend which

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-14 Thread Yuval Shaia
On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote: > + > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp **cur_qp, > +struct ib_wc *wc) > +{ > + struct pvrdma_dev *dev = to_vdev(cq->ibcq.device); > + int has_data; > + unsigned int

Re: [RFC 02/11] Add RoCE driver framework

2016-09-14 Thread Leon Romanovsky
On Wed, Sep 14, 2016 at 08:15:23AM +, Mintz, Yuval wrote: > > > >> >> +uint debug; > > > >> >> +module_param(debug, uint, 0); > > > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel"); > > > >> > > > >> >Why are you adding this as a module parameter? > > > >> > > > >>  I believe this is

[PATCH 18/19] stmmac: dwmac-sti: Remove obsolete STi platforms

2016-09-14 Thread Peter Griffin
This patch removes support for STiH415/6 SoC's from the dwmac-sti driver and dt binding doc, as support for these platforms is being removed from the kernel. It also removes STiD127 related code, which has never actually been supported upstream. Signed-off-by: Peter Griffin

[PATCH net] net: ethernet: mediatek: fix module loading automatically based on MODULE_DEVICE_TABLE

2016-09-14 Thread sean.wang
From: Sean Wang The device table is required to load modules based on modaliases. After adding MODULE_DEVICE_TABLE, below entries for example will be added to modules.alias: alias of:N*T*Cmediatek,mt7623-ethC* mtk_eth_soc Signed-off-by: Sean Wang

Re: [PATCH v2 0/6] Move runnable code (tests) from Documentation to selftests

2016-09-14 Thread Jonathan Corbet
On Tue, 13 Sep 2016 14:18:39 -0600 Shuah Khan wrote: > Move runnable code (tests) from Documentation to selftests and update > Makefiles to work under selftests. This all seems good to me. Acked-by: Jonathan Corbet jon

Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote: > @@ -323,7 +307,7 @@ void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff > *skb) > u64 ns; > struct skb_shared_hwtstamps *ssh; > > - if (!cpts->rx_enable) > + if (!cpts || !cpts->rx_enable) >

Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

2016-09-14 Thread Jamal Hadi Salim
On 16-09-13 03:47 PM, Jamal Hadi Salim wrote: On 16-09-13 12:20 PM, Cong Wang wrote: On Mon, Sep 12, 2016 at 4:07 PM, Jamal Hadi Salim wrote: [..] I am still trying to understand this piece, so here you hold the refcnt for the same action used by the later iteration?

[PATCH 1/2] batman-adv: Add missing refcnt for last_candidate

2016-09-14 Thread Simon Wunderlich
From: Sven Eckelmann batadv_find_router dereferences last_bonding_candidate from orig_node without making sure that it has a valid reference. This reference has to be retrieved by increasing the reference counter while holding neigh_list_lock. The lock is required to avoid

[PATCH 2/2] batman-adv: fix elp packet data reservation

2016-09-14 Thread Simon Wunderlich
From: Linus Lüssing The skb_reserve() call only reserved headroom for the mac header, but not the elp packet header itself. Fixing this by using skb_put()'ing towards the skb tail instead of skb_push()'ing towards the skb head. Fixes: d6f94d91f766 ("batman-adv: ELP -

[PATCH 9/9] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-09-14 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because The CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period

2016-09-14 Thread Grygorii Strashko
The CPTS drivers uses 8sec period for overflow checking with assumption that CPTS rftclk will not exceed 500MHz. But that's not true on some TI's platforms (Kesytone 2). As result, it is possible that CPTS counter will overflow more than once between two readings. Hence, fix it by selecting

[PATCH net-next v2 6/7] net: ethernet: mediatek: add more resets for internal ethernet circuit block

2016-09-14 Thread sean.wang
From: Sean Wang struct mtk_eth has already contained struct regmap ethsys pointer to the address range of the internal circuit reset, so we reuse it to reset more internal blocks on ethernet hardware such as packet processing engine (PPE) and frame engine (FE) instead of

[PATCH net-next v2 4/7] net: ethernet: mediatek: add controlling power domain the ethernet belongs to

2016-09-14 Thread sean.wang
From: Sean Wang introduce power domain control which the digital circuit of the ethernet belongs to inside the flow of hardware initialization and deinitialization which helps the entire ethernet hardware block could restart cleanly and completely as being back to the

[PATCH net-next v2 2/7] net: ethernet: mediatek: add mtk_hw_deinit call as the opposite to mtk_hw_init call

2016-09-14 Thread sean.wang
From: Sean Wang grouping things related to the deinitialization of what mtk_hw_init call does that help to be reused by the reset process and the error path handling. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 15

[PATCH net-next v2 1/7] net: ethernet: mediatek: refactoring mtk_hw_init to be reused

2016-09-14 Thread sean.wang
From: Sean Wang the existing mtk_hw_init includes hardware and software initialization inside so that it is slightly hard to reuse them for the process of the reset recovery, so some splitting is made here for keeping hardware initializing relevant thing and the else such

[PATCH net-next v2 0/7] add enhancement into the existing reset flow

2016-09-14 Thread sean.wang
From: Sean Wang Current driver only resets DMA used by descriptor rings which can't guarantee it can recover all various kinds of fatal errors, so the patch 1) tries to reset the underlying hardware resource from scratch on Mediatek SoC required for ethernet running. 2)

[PATCH net-next v2 3/7] net: ethernet: mediatek: cleanup error path inside mtk_hw_init

2016-09-14 Thread sean.wang
From: Sean Wang This cleans up the error path inside mtk_hw_init call, causing it able to exit appropriately when something fails and also includes refactoring mtk_cleanup call to make the partial logic reusable on the error path. Signed-off-by: Sean Wang

[PATCH net-next v2 5/7] net: ethernet: mediatek: add the whole ethernet reset into the reset process

2016-09-14 Thread sean.wang
From: Sean Wang 1) original driver only resets DMA used by descriptor rings which can't guarantee it can recover all various kinds of fatal errors, so the patch tries to reset the underlying hardware resource from scratch on Mediatek SoC required for ethernet running,

[PATCH net-next v2 7/7] net: ethernet: mediatek: avoid race condition during the reset process

2016-09-14 Thread sean.wang
From: Sean Wang add the protection of the race condition between the reset process and hardware access happening on the related callbacks. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 36

[PATCH 1/2] net/ibm/emac: add set mac addr callback

2016-09-14 Thread Ivan Mikhaylov
add realization for mac address set and remove dummy callback. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/ibm/emac/core.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/core.c

RE: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Adit Ranadive
On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > Please update vmxnet3_drv.c accordingly. Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved PCI device id from pci_ids.h file. - Adit

Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:29PM +0300, Grygorii Strashko wrote: > @@ -35,6 +33,8 @@ Optional properties: > For example in dra72x-evm, pcf gpio has to be > driven low so that cpsw slave 0 and phy data > lines are connected

Re: [PATCH 8/9] net: ethernet: ti: cpts: fix overflow check period

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:30PM +0300, Grygorii Strashko wrote: > @@ -427,9 +427,6 @@ static void cpts_calc_mult_shift(struct cpts *cpts) > u64 ns; > u64 frac; > > - if (cpts->cc_mult || cpts->cc.shift) > - return; > - > freq = clk_get_rate(cpts->refclk); >

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread Vincent Bernat
❦ 14 septembre 2016 16:39 CEST, David Ahern  : When a user wants to assign a routing table to a group of incoming interfaces, the current solutions are: - one IP rule for each interface (scalability problems) - use of fwmark and devgroup

Re: [PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-14 Thread John Crispin
On 14/09/2016 12:39, John Crispin wrote: > +static void > +qca8k_fdb_add(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_fdb *fdb, > + struct switchdev_trans *trans) > +{ > + struct qca8k_priv *priv = qca8k_to_priv(ds); > + u16 port_mask =

Re: [PATCH 5/9] net: ethernet: ti: cpts: add return value to tx and rx timestamp funcitons

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:27PM +0300, Grygorii Strashko wrote: > From: WingMan Kwok > > Added return values in tx and rx timestamp funcitons facilitate the > possibililies of timestamping by CPSW modules other than CPTS, such as > packet accelerator on Keystone 2 devices.

RE: [RFC v3 00/22] Landlock LSM: Unprivileged sandboxing

2016-09-14 Thread David Laight
From: Mickaël Salaün > Sent: 14 September 2016 08:24 ... > ## Why does seccomp-filter is not enough? > > A seccomp filter can access to raw syscall arguments which means that it is > not > possible to filter according to pointed data as a file path. As demonstrated > the first version of this

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread David Ahern
On 9/14/16 8:25 AM, Vincent Bernat wrote: > ❦ 14 septembre 2016 16:15 CEST, David Ahern : > >>> When a user wants to assign a routing table to a group of incoming >>> interfaces, the current solutions are: >>> >>> - one IP rule for each interface (scalability

Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 04:02:28PM +0300, Grygorii Strashko wrote: > From: WingMan Kwok > > When a CPTS user does not exit gracefully by disabling cpts > timestamping and leaving a joined multicast group, the system > continues to receive and timestamps the ptp packets which

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread David Ahern
On 9/14/16 6:40 AM, Vincent Bernat wrote: > When a user wants to assign a routing table to a group of incoming > interfaces, the current solutions are: > > - one IP rule for each interface (scalability problems) > - use of fwmark and devgroup matcher (don't work with internal route >

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread David Ahern
On 9/14/16 9:14 AM, Vincent Bernat wrote: > I could just give more time to VRF. I also had some concerns over > performance with the way Netfilter integration is done, but I understand > that I could just stay away from POSTROUTING rules which is the only > hook executed twice? > With the

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-14 Thread Alexei Starovoitov
On Wed, Sep 14, 2016 at 01:42:49PM +0200, Daniel Borkmann wrote: > >As I said, I'm open to discussing that. In order to make it work for L3, > >the LL_OFF issues need to be solved, as Daniel explained. Daniel, > >Alexei, any idea how much work that would be? > > Not much. You simply need to

[PATCH stable] tipc: apply skb linearization commit to stable 4.4.x

2016-09-14 Thread Jon Maloy
commit c7cad0d6f70cd upstream (“tipc: move linearization of buffers to generic code”) was applied to net-next in November 2015, and is present in kernel versions from 4.5.x onwards. We later discovered that this commit also fixes a serious bug, since even L2 buffers may arrive non-linearized.

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Tariq Toukan
Hi Sebastian, Thanks for this fix. On 14/09/2016 2:09 PM, Sebastian Ott wrote: If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap label is one too big which results in a panic in mlx4_free_eq. This patch fixes the index in the error path. You are right, but your

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread Vincent Bernat
❦ 14 septembre 2016 16:15 CEST, David Ahern  : >> When a user wants to assign a routing table to a group of incoming >> interfaces, the current solutions are: >> >> - one IP rule for each interface (scalability problems) >> - use of fwmark and devgroup matcher (don't

Re: [net v1] fib_rules: interface group matching

2016-09-14 Thread Vincent Bernat
❦ 14 septembre 2016 17:25 CEST, David Ahern  : >> I could just give more time to VRF. I also had some concerns over >> performance with the way Netfilter integration is done, but I understand >> that I could just stay away from POSTROUTING rules which is the only >>

Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support

2016-09-14 Thread LABBE Corentin
On Mon, Sep 12, 2016 at 10:44:51PM +0200, Maxime Ripard wrote: > Hi, > > On Fri, Sep 09, 2016 at 02:45:17PM +0200, Corentin Labbe wrote: > > This patch add pm_runtime support to sun8i-emac. > > For the moment, only basic support is added, (the device is marked as > > used when net/open) > > > >

RE: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Amrani, Ram
> Anything that is used with copy_to/from_user, ib_copy_to/from_udata, > etc, etc must be in a include/uapi header. > > Any constant you might want to copy into your userspace provider must > be in include/uapi. > I understand you mean something like

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Tariq Toukan
On 14/09/2016 4:53 PM, Sebastian Ott wrote: Hello Tariq, On Wed, 14 Sep 2016, Tariq Toukan wrote: On 14/09/2016 2:09 PM, Sebastian Ott wrote: If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap label is one too big which results in a panic in mlx4_free_eq. This

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-09-14 Thread Giuseppe CAVALLARO
Hello Martin On 9/11/2016 10:39 PM, Martin Blumenstingl wrote: Hello, I have a device with a Meson GXBB SoC with an stmmac IP block. Gbit ethernet on my device is provided by a Realtek RTL8211F RGMII PHY. Similar issues were reported in #linux-amlogic by a user with an Odroid C2 board (=

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Yuval Shaia
On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > Please update vmxnet3_drv.c accordingly. > > Any reason why? I don't think we need to. Vmxnet3 should just pick up the > moved > PCI device id from pci_ids.h file. So

Re: [PATCH v2 net 1/1] net sched actions: fix GETing actions

2016-09-14 Thread Cong Wang
On Mon, Sep 12, 2016 at 3:21 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > With the batch changes that translated transient actions into > a temporary list we lost in the translation the fact that > tcf_action_destroy() will eventually delete the

Re: Modification to skb->queue_mapping affecting performance

2016-09-14 Thread Michael Ma
2016-09-13 22:22 GMT-07:00 Eric Dumazet : > On Tue, 2016-09-13 at 22:13 -0700, Michael Ma wrote: > >> I don't intend to install multiple qdisc - the only reason that I'm >> doing this now is to leverage MQ to workaround the lock contention, >> and based on the profile this

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 4:53 PM, Sebastian Ott wrote: > > On Wed, 14 Sep 2016, Tariq Toukan wrote: > > > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > > > If an error occurs in mlx4_init_eq_table the index used in the > > > > err_out_unmap label is one too big

[PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list'

2016-09-14 Thread Ivan Mikhaylov
for preventing race conditions within ioctl calls. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/ibm/emac/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index 2dfc603..7af09cb

Re: [PATCH v4 13/16] IB/pvrdma: Add the main driver module for PVRDMA

2016-09-14 Thread Yuval Shaia
On Sun, Sep 11, 2016 at 09:49:23PM -0700, Adit Ranadive wrote: + > +static void pvrdma_netdevice_event_handle(struct pvrdma_dev *dev, > + unsigned long event) > +{ > + struct net_device *netdev; > + > + netdev = dev->netdev; Please remove the above

Re: [PATCH v4 00/16] Add Paravirtual RDMA Driver

2016-09-14 Thread Jason Gunthorpe
On Mon, Sep 12, 2016 at 10:43:00PM +, Adit Ranadive wrote: > On Mon, Sep 12, 2016 at 11:03:39 -0700, Jason Gunthorpe wrote: > > On Sun, Sep 11, 2016 at 09:49:10PM -0700, Adit Ranadive wrote: > > > [2] Libpvrdma User-level library - > > >

Re: [PATCHv2 next 3/3] ipvlan: Introduce l3s mode

2016-09-14 Thread महेश बंडेवार
Hi David, thanks for the comments. On Tue, Sep 13, 2016 at 8:24 PM, David Ahern wrote: > On 9/12/16 12:01 PM, Mahesh Bandewar wrote: > >> +struct sk_buff *ipvlan_l3_rcv(struct net_device *dev, struct sk_buff *skb, >> + u16 proto) >> +{ >> +

Re: [PATCH v4 12/16] IB/pvrdma: Add Queue Pair support

2016-09-14 Thread Yuval Shaia
No more comments. Reviewed-by: Yuval Shaia On Sun, Sep 11, 2016 at 09:49:22PM -0700, Adit Ranadive wrote: > This patch adds the ability to create, modify, query and destroy QPs. The > PVRDMA device supports RC, UD and GSI QPs. > > Reviewed-by: Jorgen Hansen

Re: [06/26] ath: constify local structures

2016-09-14 Thread Kalle Valo
Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

Re: [PATCHv2 next 3/3] ipvlan: Introduce l3s mode

2016-09-14 Thread David Ahern
On 9/14/16 10:30 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > Hi David, thanks for the comments. > > On Tue, Sep 13, 2016 at 8:24 PM, David Ahern wrote: >> On 9/12/16 12:01 PM, Mahesh Bandewar wrote: >> >>> +struct sk_buff *ipvlan_l3_rcv(struct net_device *dev, struct

Re: [PATCHv2 net 0/6] sctp: fix the transmit err process

2016-09-14 Thread Marcelo Ricardo Leitner
On Wed, Sep 14, 2016 at 02:04:17AM +0800, Xin Long wrote: > This patchset is to improve the transmit err process and also fix some > issues. > > After this patchset, once the chunks are enqueued successfully, even > if the chunks fail to send out, no matter because of nodst or nomem, > no err

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Jason Gunthorpe
On Wed, Sep 14, 2016 at 02:44:47PM +, Amrani, Ram wrote: > > Anything that is used with copy_to/from_user, ib_copy_to/from_udata, > > etc, etc must be in a include/uapi header. > > > > Any constant you might want to copy into your userspace provider must > > be in include/uapi. > > > I

Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

2016-09-14 Thread Cong Wang
On Wed, Sep 14, 2016 at 4:33 AM, Jamal Hadi Salim wrote: > On 16-09-13 03:47 PM, Jamal Hadi Salim wrote: >> >> On 16-09-13 12:20 PM, Cong Wang wrote: >>> >>> On Mon, Sep 12, 2016 at 4:07 PM, Jamal Hadi Salim >>> wrote: > > > [..] >>> >>> I am still trying to

Re: [RFC v3 11/22] seccomp,landlock: Handle Landlock hooks per process hierarchy

2016-09-14 Thread Andy Lutomirski
On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: > A Landlock program will be triggered according to its subtype/origin > bitfield. The LANDLOCK_FLAG_ORIGIN_SECCOMP value will trigger the > Landlock program when a seccomp filter will return RET_LANDLOCK. > Moreover, it is

[PATCHv3 net-next 14/15] nfp: bpf: add support for legacy redirect action

2016-09-14 Thread Jakub Kicinski
Data path has redirect support so expressing redirect to the port frame came from is a trivial matter of setting the right result code. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h | 1 +

[PATCHv3 net-next 09/15] nfp: bpf: add hardware bpf offload

2016-09-14 Thread Jakub Kicinski
Add hardware bpf offload on our smart NICs. Detect if capable firmware is loaded and use it to load the code JITed with just added translator onto programmable engines. This commit only supports offloading cls_bpf in legacy mode (non-direct action). Signed-off-by: Jakub Kicinski

[PATCHv3 net-next 11/15] net: bpf: allow offloaded filters to update stats

2016-09-14 Thread Jakub Kicinski
Periodically poll stats and call into offloaded actions to update them. Signed-off-by: Jakub Kicinski --- v3: - add missing hunk with ethtool stats. --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 19 +++

[PATCHv3 net-next 08/15] nfp: add BPF to NFP code translator

2016-09-14 Thread Jakub Kicinski
Add translator for JITing eBPF to operations which can be executed on NFP's programmable engines. Signed-off-by: Jakub Kicinski --- v3: - don't clone the program for the verifier (no longer needed); - temporarily add a local copy of macros from bitfield.h. ---

[PATCHv3 net-next 12/15] nfp: bpf: add packet marking support

2016-09-14 Thread Jakub Kicinski
Add missing ABI defines and eBPF instructions to allow mark to be passed on and extend prepend parsing on the RX path to pick it up from packet metadata. Signed-off-by: Jakub Kicinski --- v3: - change metadata format. ---

[PATCHv3 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats

2016-09-14 Thread Jakub Kicinski
Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Acked-by: John Fastabend Acked-by: Daniel Borkmann --- include/net/pkt_cls.h | 1 + net/sched/cls_bpf.c | 11 +++ 2 files

Re: [PATCH 6/9] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-09-14 Thread Grygorii Strashko
On 09/14/2016 05:14 PM, Richard Cochran wrote: On Wed, Sep 14, 2016 at 04:02:28PM +0300, Grygorii Strashko wrote: From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive

[PATCH 3/3] mm: memcontrol: consolidate cgroup socket tracking

2016-09-14 Thread Johannes Weiner
The cgroup core and the memory controller need to track socket ownership for different purposes, but the tracking sites being entirely different is kind of ugly. Be a better citizen and rename the memory controller callbacks to match the cgroup core callbacks, then move them to the same place.

[PATCH 1/3] mm: memcontrol: make per-cpu charge cache IRQ-safe for socket accounting

2016-09-14 Thread Johannes Weiner
From: Johannes Weiner During cgroup2 rollout into production, we started encountering css refcount underflows and css access crashes in the memory controller. Splitting the heavily shared css reference counter into logical users narrowed the imbalance down to the cgroup2 socket

Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-09-14 Thread Grygorii Strashko
On 09/14/2016 04:52 PM, Richard Cochran wrote: > On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote: >> @@ -323,7 +307,7 @@ void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff >> *skb) >> u64 ns; >> struct skb_shared_hwtstamps *ssh; >> >> -if (!cpts->rx_enable)

Re: [PATCH 4/9] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-09-14 Thread Richard Cochran
On Wed, Sep 14, 2016 at 10:45:54PM +0300, Grygorii Strashko wrote: > With this change It will not be required to add the same DT parsing code > in Keystone 2 netcp driver, so overall number of lines will be reduced. This explanation would make the commit message much more informative. Thanks,

Re: [RFC v3 03/22] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-09-14 Thread Alexei Starovoitov
On Wed, Sep 14, 2016 at 09:23:56AM +0200, Mickaël Salaün wrote: > This new arraymap looks like a set and brings new properties: > * strong typing of entries: the eBPF functions get the array type of > elements instead of CONST_PTR_TO_MAP (e.g. > CONST_PTR_TO_LANDLOCK_HANDLE_FS); > * force

Re: [PATCH 7/9] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-09-14 Thread Grygorii Strashko
On 09/14/2016 05:22 PM, Richard Cochran wrote: On Wed, Sep 14, 2016 at 04:02:29PM +0300, Grygorii Strashko wrote: @@ -35,6 +33,8 @@ Optional properties: For example in dra72x-evm, pcf gpio has to be driven low so that cpsw slave 0 and phy data

Re: [RFC 02/11] Add RoCE driver framework

2016-09-14 Thread Mintz, Yuval
> > > > >> >> +uint debug; > > > > >> >> +module_param(debug, uint, 0); > > > > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel"); > > > > >> > > > > >> >Why are you adding this as a module parameter? > > > > >> > > > > >>  I believe this is mostly to follow same line as qede which also >

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-14 Thread Andy Lutomirski
On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: > Add a new flag CGRP_NO_NEW_PRIVS for each cgroup. This flag is initially > set for all cgroup except the root. The flag is clear when a new process > without the no_new_privs flags is attached to the cgroup. > > If a

Re: [PATCH net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-09-14 Thread Jarod Wilson
On Wed, Sep 14, 2016 at 05:59:14AM +0800, kbuild test robot wrote: > Hi Jarod, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Jarod-Wilson/net-centralize-net_device-min-max-MTU-checking/20160913-042130 > config: mips-xway_defconfig

[PATCHv3 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag

2016-09-14 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_HW flag. Unlike U32 and flower cls_bpf already has some netlink flags defined. Create a new attribute to be able to use the same flag values as the above. Unlike U32 and flower reject unknown flags. Signed-off-by: Jakub Kicinski

[PATCHv3 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-14 Thread Jakub Kicinski
Hi! In the last year a lot of progress have been made on offloading simpler TC classifiers. There is also growing interest in using BPF for generic high-speed packet processing in the kernel. It seems beneficial to tie those two trends together and think about hardware offloads of BPF programs.

  1   2   3   >