Re: [PATCH V2 net-next] net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON

2016-10-13 Thread David Miller
From: Saeed Mahameed Date: Wed, 12 Oct 2016 04:57:10 +0300 > From: Tom Herbert > > I am hitting this in mlx5: > > drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function > reclaim_pages_cmd.clone.0: >

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Thu, 13 Oct 2016 10:42:46 -0500 > Do you have suggestions on how to better handle the choice of the array size > and the speeds? All of the speed values are simply the rate in bits per second. There is therefore no reason you can't just print the raw

RE: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-13 Thread David Laight
From: Koehrer Mathias > Sent: 13 October 2016 11:57 .. > > The time between my trace points 700 and 701 is about 30us, the time > > between my > > trace points 600 and 601 is even 37us!! > > The code in between is > > tsyncrxctl = rd32(E1000_TSYNCRXCTL); resp. > > lvmmc =

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread David Miller
From: Paolo Abeni Date: Tue, 11 Oct 2016 19:15:44 +0200 > After the commit 9207f9d45b0a ("net: preserve IP control block > during GSO segmentation"), the GSO CB and the IPoIB CB conflict. > That destroy the IPoIB address information cached there, > causing a severe performance

Re: [Patch net] net_sched: reorder pernet ops and act ops registrations

2016-10-13 Thread David Miller
From: Cong Wang Date: Tue, 11 Oct 2016 10:56:45 -0700 > Krister reported a kernel NULL pointer dereference after > tcf_action_init_1() invokes a_o->init(), it is a race condition > where one thread calling tcf_register_action() to initialize > the netns data after

Re: [PATCH] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-13 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 13 Oct 2016 14:14:40 + >> > Since we will remove items off the list using list_del() we need to >> > use a safe version of the list_for_each_entry() macro aptly named >> > list_for_each_entry_safe(). >> > >> > Fixes: 0a7fb11c23c0 ("qed:

Re: [PATCH] qed: fix old-style function definition

2016-10-13 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 13 Oct 2016 14:15:51 + >> > The definition of qed_get_rdma_ops() is not a prototype unless we add >> > 'void' here, as indicated by this W=1 warning: >> > >> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:

[PATCH net-next] Documentation/networking: update git urls to use https over http

2016-10-13 Thread Alexander Alemayhu
This fixes the following errors when trying to clone the urls: Cloning into 'net'... fatal: repository 'http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/' not found Cloning into 'net-next'... fatal: repository 'http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/' not found

Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-13 Thread Jonathan Cooper
On 13/10/16 15:35, David Miller wrote: From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread Paolo Abeni
On Thu, 2016-10-13 at 10:24 -0400, David Miller wrote: > From: Paolo Abeni > Date: Tue, 11 Oct 2016 19:15:44 +0200 > > > After the commit 9207f9d45b0a ("net: preserve IP control block > > during GSO segmentation"), the GSO CB and the IPoIB CB conflict. > > That destroy the

Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver

2016-10-13 Thread David Miller
From: Taku Izumi Date: Tue, 11 Oct 2016 17:55:20 +0900 > This patch implements debug mode for fjes driver. > You can get firmware activity information by enabling > debug mode. This is useful for debugging. > > To enable debug mode, write value of debugging mode to >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 08:56 -0500, Chris Rorvick wrote: > Hi Luca, > > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Chris Rorvick

Re: [PATCH (net.git) 1/2] stmmac: fix ptp init for gmac4

2016-10-13 Thread David Miller
From: Giuseppe Cavallaro Date: Wed, 12 Oct 2016 15:42:03 +0200 > The gmac 4.x version has not extended descriptors > (that are available on 3.x instead of). > While initializing the PTP module, the advanced PTP was > enabled in case of extended descriptors. This cannot be

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/14/16 00:00), Sergey Senozhatsky wrote: > kernel: [] ieee80211_crypto_ccmp_decrypt+0x204/0x298 > kernel: [] ieee80211_rx_handlers+0x7df/0x1c1d > kernel: [] ieee80211_prepare_and_rx_handle+0xdc2/0xe79 > kernel: [] ? ieee80211_rx_napi+0x168/0x7b6 > kernel: []

Re: [PATCH net-next] net: phy: Trigger state machine on state change and not polling.

2016-10-13 Thread David Miller
From: Andrew Lunn Date: Wed, 12 Oct 2016 22:14:53 +0200 > The phy_start() is used to indicate the PHY is now ready to do its > work. The state is changed, normally to PHY_UP which means that both > the MAC and the PHY are ready. > > If the phy driver is using polling, when the

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread David Miller
From: Doug Ledford Date: Thu, 13 Oct 2016 10:35:35 -0400 > On 10/13/2016 10:24 AM, David Miller wrote: >> From: Paolo Abeni >> Date: Tue, 11 Oct 2016 19:15:44 +0200 >> >>> After the commit 9207f9d45b0a ("net: preserve IP control block >>> during GSO

Re: [PATCH (net.git) 2/2] stmmac: fix error check when init ptp

2016-10-13 Thread David Miller
From: Giuseppe Cavallaro Date: Wed, 12 Oct 2016 15:42:04 +0200 > This patch fixes a problem when propagated the > failure of ptp_clock_register to open function. > > Signed-off-by: Giuseppe Cavallaro Applied.

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
SMP kernel: Modules linked in: nls_iso8859_1 nls_cp437 vfat fat mousedev psmouse serio_raw atkbd libps2 i915 coretemp i2c_algo_bit hwmon crc32c_intel mxm_wmi drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect iwlmvm sysimgblt fb_sys_fops i2c_i801 cfbcopyarea ie31200_edac drm iwlwifi i2c

Re: [PATCH] xen-netback: fix type mismatch warning

2016-10-13 Thread David Miller
From: Arnd Bergmann Date: Wed, 12 Oct 2016 16:54:01 +0200 > Wiht the latest rework of the xen-netback driver, we get a warning > on ARM about the types passed into min(): > > drivers/net/xen-netback/rx.c: In function 'xenvif_rx_next_chunk': > include/linux/kernel.h:739:16: error:

Re: [PATCH] net: ipv4: Do not drop to make_route if oif is l3mdev

2016-10-13 Thread David Miller
From: David Ahern Date: Wed, 12 Oct 2016 13:20:11 -0700 > Commit e0d56fdd7342 was a bit aggressive removing l3mdev calls in > the IPv4 stack. If the fib_lookup fails we do not want to drop to > make_route if the oif is an l3mdev device. > > Also reverts 19664c6a0009

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread Doug Ledford
On 10/13/2016 10:24 AM, David Miller wrote: > From: Paolo Abeni > Date: Tue, 11 Oct 2016 19:15:44 +0200 > >> After the commit 9207f9d45b0a ("net: preserve IP control block >> during GSO segmentation"), the GSO CB and the IPoIB CB conflict. >> That destroy the IPoIB address

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Tue, 11 Oct 2016 15:26:20 -0500 > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per

Re: [PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread Michal Simek
On 13.10.2016 16:40, Tobias Klauser wrote: > On 2016-10-13 at 14:23:49 +0200, Michal Simek wrote: >> On 13.10.2016 13:28, Tobias Klauser wrote: >>> The dev parameter passed to __axienet_device_reset() is not used inside >>> the function, so remove it. >>> >>>

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the

2016-10-13 Thread David Miller
From: Doug Ledford Date: Thu, 13 Oct 2016 11:20:59 -0400 > We *had* a safe way to do that. It got broken. What about increasing > the size of skb->cb? Or adding a skb->dgid that is a > u8[INFINIBAND_ALEN]? Or a more generic skb->dest_ll_addr that is sized > to hold the

Re: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-13 Thread David Miller
From: David Vrabel Date: Tue, 11 Oct 2016 16:48:27 +0100 > If a VIF has been ready for rx_stall_timeout (60s by default) and an > Rx ring is drained of all requests an Rx stall will be incorrectly > detected. When this occurs and the guest Rx queue is empty, the Rx >

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread Doug Ledford
On 10/13/2016 10:43 AM, David Miller wrote: > From: Doug Ledford > Date: Thu, 13 Oct 2016 10:35:35 -0400 > >> On 10/13/2016 10:24 AM, David Miller wrote: >>> From: Paolo Abeni >>> Date: Tue, 11 Oct 2016 19:15:44 +0200 >>> After the commit

Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-13 Thread Jonathan Cooper
On 13/10/16 15:35, David Miller wrote: From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken

RE: [PATCH] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-13 Thread Mintz, Yuval
> > Since we will remove items off the list using list_del() we need to > > use a safe version of the list_for_each_entry() macro aptly named > > list_for_each_entry_safe(). > > > > Fixes: 0a7fb11c23c0 ("qed: Add Light L2 support") > > Signed-off-by: Wei Yongjun > > Can

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-13 Thread Cyrill Gorcunov
On Thu, Oct 13, 2016 at 09:43:57AM -0600, David Ahern wrote: > On 10/13/16 1:16 AM, Cyrill Gorcunov wrote: > > On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: > >> From: Cyrill Gorcunov > >> Date: Wed, 12 Oct 2016 09:53:29 +0300 > >> > >>> I can't rename the

Re: [PATCH net] netvsc: fix checksum on UDP IPV6

2016-10-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 11 Oct 2016 14:03:07 -0700 > The software calculation of UDP checksum in Netvsc driver was > only handling IPv4 case. By using skb_checksum_help() instead > all protocols can be handled. Rearrange code to eliminate goto > and look

Re: [PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread Tobias Klauser
On 2016-10-13 at 14:23:49 +0200, Michal Simek wrote: > On 13.10.2016 13:28, Tobias Klauser wrote: > > The dev parameter passed to __axienet_device_reset() is not used inside > > the function, so remove it. > > > > Signed-off-by: Tobias Klauser > >

Re: [PATCH net-next 00/11] net: Fix netdev adjacency tracking

2016-10-13 Thread David Ahern
On 10/13/16 1:34 AM, Jiri Pirko wrote: > > Although I didn't like the "all-list" idea when Veaceslav pushed it > because it looked to me like a big hammer, it turned out to be very handy > and quick for traversing neighbours. Why it cannot be fixed? > > The walks with possibly hundreds of

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-13 Thread David Ahern
On 10/13/16 1:16 AM, Cyrill Gorcunov wrote: > On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: >> From: Cyrill Gorcunov >> Date: Wed, 12 Oct 2016 09:53:29 +0300 >> >>> I can't rename the field, neither a can use union. >> >> Remind me again what is wrong with

[PATCH iproute2] bridge: add support for the multicast flood flag

2016-10-13 Thread Nikolay Aleksandrov
Recently a new per-port flag was added which controls the flooding of unknown multicast, this patch adds support for controlling it via iproute2. It also updates the man pages with information about the new flag. Signed-off-by: Nikolay Aleksandrov --- note that

RE: [PATCH] qed: fix old-style function definition

2016-10-13 Thread Mintz, Yuval
> > The definition of qed_get_rdma_ops() is not a prototype unless we add > > 'void' here, as indicated by this W=1 warning: > > > > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’: > > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style > > function

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-13 Thread Eric W. Biederman
Andrei Vagin writes: > From: Andrey Vagin > > The operation of destroying netns is heavy and it is executed under > net_mutex. If many namespaces are destroyed concurrently, net_mutex can > be locked for a long time. It is impossible to create a new netns

Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 > This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. > > The code has been in kernel since 4.4 but there are no in tree > code that uses. Unused code is broken code, remove it. > >

Re: [PATCH net-next v2] bridge: add address and vlan to fdb warning messages

2016-10-13 Thread David Miller
From: Roopa Prabhu Date: Tue, 11 Oct 2016 16:12:56 -0700 > From: Roopa Prabhu > > This patch adds vlan and address to warning messages printed > in the bridge fdb code for debuggability. > > Signed-off-by: Roopa Prabhu

Re: [PATCH net 0/3] s390 network driver patches

2016-10-13 Thread David Miller
From: Ursula Braun Date: Wed, 12 Oct 2016 12:38:48 +0200 > here are 3 small patches for the s390 network drivers netiucv and lcs. > They are built for the net-tree. Series applied, thanks.

Re: [PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread Michal Simek
On 13.10.2016 13:28, Tobias Klauser wrote: > The dev parameter passed to __axienet_device_reset() is not used inside > the function, so remove it. > > Signed-off-by: Tobias Klauser > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 11 +-- > 1 file changed,

Re: [PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread David Miller
From: Tobias Klauser Date: Thu, 13 Oct 2016 13:28:33 +0200 > The dev parameter passed to __axienet_device_reset() is not used inside > the function, so remove it. > > Signed-off-by: Tobias Klauser Applied.

[PATCH net 4/4] afs: call->operation_ID sometimes used as __be32 sometimes as u32

2016-10-13 Thread David Howells
call->operation_ID is sometimes being used as __be32 sometimes is being used as u32. Be consistent and settle on using as u32. Signed-off-by: David Howells

Re: [patch -next] net: rtnl: info leak in rtnl_fill_vfinfo()

2016-10-13 Thread David Miller
From: Dan Carpenter Date: Thu, 13 Oct 2016 11:45:28 +0300 > The "vf_vlan_info" struct ends with a 2 byte struct hole so we have to > memset it to ensure that no stack information is revealed to user space. > > Fixes: 79aab093a0b5 ('net: Update API for VF vlan protocol

[PATCH net 1/4] afs: unmapping the wrong buffer

2016-10-13 Thread David Howells
From: Dan Carpenter We switched from kmap_atomic() to kmap() so the kunmap() calls need to be updated to match. Fixes: d001648ec7cf ('rxrpc: Don't expose skbs to in-kernel users [ver #2]') Signed-off-by: Dan Carpenter Signed-off-by: David

[PATCH 1/2] IPv6: Drop the temporary address regen_timer

2016-10-13 Thread Jiri Bohac
The randomized interface identifier (rndid) was periodically updated from the regen_timer timer. Simplify the code by updating the rndid only when needed by ipv6_try_regen_rndid(). This makes the follow-up DESYNC_FACTOR fix much simpler. Also it fixes a reference counting error in this error

Re: [patch] liquidio: CN23XX: fix a loop timeout

2016-10-13 Thread David Miller
From: Dan Carpenter Date: Thu, 13 Oct 2016 11:56:57 +0300 > This is supposed to loop 1000 times and then give up. The problem is > it's a post-op and after the loop we test if "loop" is zero when really > it would be -1. Fix this by making it a pre-op. > > Fixes:

Re: [patch] tipc: info leak in __tipc_nl_add_udp_addr()

2016-10-13 Thread David Miller
From: Dan Carpenter Date: Thu, 13 Oct 2016 11:06:06 +0300 > We should clear out the padding and unused struct members so that we > don't expose stack information to userspace. > > Fixes: fdb3accc2c15 ('tipc: add the ability to get UDP options via netlink') >

[PATCH net-next 0/4] rxrpc: Fixes

2016-10-13 Thread David Howells
_ID is BE or CPU-E within AFS. The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20161013 David ---

[PATCH net 3/4] rxrpc: Fix checking of error from ip6_route_output()

2016-10-13 Thread David Howells
ip6_route_output() doesn't return a negative error when it fails, rather the ->error field of the returned dst_entry struct needs to be checked. Reported-by: Dan Carpenter Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support") Signed-off-by: David Howells

[PATCH v3] IB/ipoib: move back IB LL address into the hard header

2016-10-13 Thread Paolo Abeni
After the commit 9207f9d45b0a ("net: preserve IP control block during GSO segmentation"), the GSO CB and the IPoIB CB conflict. That destroy the IPoIB address information cached there, causing a severe performance regression, as better described here:

[GIT] Networking

2016-10-13 Thread David Miller
1) Fix various build warnings in tlan/qed/xen-netback drivers, from Arnd Bergmann. 2) Propagate proper error code in strparser's strp_recv(), from Geert Uytterhoeven. 3) Fix accidental broadcast of RTM_GETTFILTER responses, from Eric Dumazret. 4) Need to use list_for_each_entry_safe() in

Re: [PATCH net-next] net: phy: Trigger state machine on state change and not polling.

2016-10-13 Thread Andrew Lunn
> On Thu, Oct 13, 2016 at 12:04:38PM -0400, David Miller wrote: > From: Andrew Lunn > Date: Wed, 12 Oct 2016 22:14:53 +0200 > > > The phy_start() is used to indicate the PHY is now ready to do its > > work. The state is changed, normally to PHY_UP which means that both > > the

[PATCH 2/2] IPv6: fix DESYNC_FACTOR

2016-10-13 Thread Jiri Bohac
The IPv6 temporary address generation uses a variable called DESYNC_FACTOR to prevent hosts updating the addresses at the same time. Quoting RFC 4941: ... The value DESYNC_FACTOR is a random value (different for each client) that ensures that clients don't synchronize with each other and

[PATCH net 2/4] rxrpc: Fix checker warning by not passing always-zero value to ERR_PTR()

2016-10-13 Thread David Howells
Fix the following checker warning: net/rxrpc/call_object.c:279 rxrpc_new_client_call() warn: passing zero to 'ERR_PTR' where a value that's always zero is passed to ERR_PTR() so that it can be passed to a tracepoint in an auxiliary pointer field. Just pass NULL instead to the

Re: [PATCH net-next] net: phy: Trigger state machine on state change and not polling.

2016-10-13 Thread David Miller
From: Andrew Lunn Date: Thu, 13 Oct 2016 18:29:01 +0200 > Just for my clarification: > > We are in the middle of the merge window. What does net-next and net > mean at the moment? Once I merge net-next to Linus, bug fixes should go to 'net'. And for the past day or so I've

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread Andrew Lunn
> Do you have suggestions on how to better handle the choice of the array size > and the speeds? phydev->supported lists the speeds this phy supports. Andrew

Re: [PATCH net] net: bridge: add the multicast_flood flag attribute to brport_attrs

2016-10-13 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 13 Oct 2016 15:20:52 +0200 > When I added the multicast flood control flag, I also added an attribute > for it for sysfs similar to other flags, but I forgot to add it to > brport_attrs. > > Fixes: b6cb5ac8331b ("net: bridge: add

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-13 Thread Julia Cartwright
Hey Mathias- On Thu, Oct 13, 2016 at 10:57:18AM +, Koehrer Mathias (ETAS/ESW5) wrote: [..] Interesting indeed! > > Here are some places where I added traces: > > In file igb_ptp.c: > > void igb_ptp_rx_hang(struct igb_adapter *adapter) { > > struct e1000_hw *hw = >hw; > >

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread Zach Brown
On Thu, Oct 13, 2016 at 10:46:34AM -0400, David Miller wrote: > From: Zach Brown > Date: Tue, 11 Oct 2016 15:26:20 -0500 > > > From: Josh Cartwright > > > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > > create a set of led

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:55 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: > >  Even though there is apparently something wrong with this part of the > > ACPI table on you laptop, since it doesn't match our specifications. > >  In any case, it's mostly harmless. >

[PATCH net 0/3] qed: Fix dependencies and warnings series

2016-10-13 Thread Yuval Mintz
Hi Dave, The first patch in this series follows Dan Carpenter's reports about Smatch warnings for recent qed additions and fixes those. The second patch is the most significant one [and the reason this is ntended for 'net'] - it's based on Arnd Bermann's suggestion for fixing compilation issues

[PATCH net-next v11 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-13 Thread Allan W. Nielsen
Edge-Rate cleanup include the following: - Updated device tree bindings documentation for edge-rate - The edge-rate is now specified as a "slowdown", meaning that it is now being specified as positive values instead of negative (both documentation and implementation wise). - Only explicitly

Re: slab corruption with current -git

2016-10-13 Thread Linus Torvalds
On Wed, Oct 12, 2016 at 11:27 PM, Markus Trippelsdorf wrote: > > Yeah. > > 105 entry->orig_ops = reg; > 106 entry->ops = *reg; > 107 entry->next = NULL; So ipt_register_table() does: ret = nf_register_net_hooks(net, ops,

[PATCH] net: Require exact match for TCP socket lookups if dif is l3mdev

2016-10-13 Thread David Ahern
Currently, socket lookups for l3mdev (vrf) use cases can match a socket that is bound to a port but not a device (ie., a global socket). If the sysctl tcp_l3mdev_accept is not set this leads to ack packets going out based on the main table even though the packet came in from an L3 domain. The end

Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-13 Thread David Miller
From: Tom Herbert Date: Wed, 12 Oct 2016 16:25:42 -0700 > Since performing a UDP lookup on every packet might be expensive I > added a static key check to bypass the lookup if there are no > sockets with flow_dissect set. I should mention that doing the > lookup wasn't

[PATCH net 2/3] qed*: Fix Kconfig dependencies with INFINIBAND_QEDR

2016-10-13 Thread Yuval Mintz
The qedr driver would require a tristate Kconfig option [to allow it to compile as a module], and toward that end we've added the INFINIBAND_QEDR option. But as we've made the compilation of the qed/qede infrastructure required for RoCE dependent on the option we'd be facing linking difficulties

[PATCH net 3/3] qed: Additional work toward cleaning C=1

2016-10-13 Thread Yuval Mintz
This cleans many of the warnings that would arise in qed as a result of compilations with C=1; Most of those are the addition of missing 'static' to functions, although there are several other fixes as well. Signed-off-by: Yuval Mintz ---

Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-13 Thread Tom Herbert
On Thu, Oct 13, 2016 at 12:17 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 12 Oct 2016 16:25:42 -0700 > >> Since performing a UDP lookup on every packet might be expensive I >> added a static key check to bypass the lookup if there are no >>

[PATCH net 1/3] qed: Fix static checker warning.

2016-10-13 Thread Yuval Mintz
Smatch compains about qed_roce_ll2_tx() dereference of the 'cdev' variable while testing its validity later. As the validation checking is an over-kill [variable would always be set], simply remove it. Reported-by: Dan Carpenter Fixes: abd49676c707 ("qed: Add RoCE ll2 &

[PATCH net-next v11 0/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs (rebase)

2016-10-13 Thread Allan W. Nielsen
Hi, On 13/10/16 10:01, David Miller wrote: > This doesn't apply cleanly to net-next, please respin. Sorry about that... But, I have already send a rebased version (v11) which does apply cleanly. This time I will try and see if I can get git-send-email to use the same thread ID. Anyway, here is a

Re: XDP_TX bug report on mlx4

2016-10-13 Thread Brenden Blanco
On Sun, Sep 18, 2016 at 07:59:43PM -0400, Brenden Blanco wrote: > On Fri, Sep 16, 2016 at 09:24:43PM +0200, Jesper Dangaard Brouer wrote: > > On Fri, 16 Sep 2016 12:17:27 -0700 > > Brenden Blanco wrote: > > > > > On Fri, Sep 16, 2016 at 09:03:40PM +0200, Jesper Dangaard

[PATCH net] net/mlx4_en: fixup xdp tx irq to match rx

2016-10-13 Thread Brenden Blanco
In cases where the number of tx rings is not a multiple of the number of rx rings, the tx completion event will be handled on a different core from the transmit and population of the ring. Races on the ring will lead to a double-free of the page, and possibly other corruption. The rings are

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Eric Dumazet
On Thu, 2016-10-13 at 09:54 -0400, David Miller wrote: > Applied, thanks Eric. > > Want me to queue this up for -stable too? No thanks, it just occurred to me during a debugging session.

Re: slab corruption with current -git

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 12:49:33PM -0700, Linus Torvalds wrote: > That said, xt_hook_ops_alloc() itself is odd. Lookie here, this is the > loop that initializes things: > > for (i = 0, hooknum = 0; i < num_hooks && hook_mask != 0; > hook_mask >>= 1, ++hooknum) { > > and it

Re: [PATCH] net: Require exact match for TCP socket lookups if dif is l3mdev

2016-10-13 Thread David Ahern
On 10/13/16 3:29 PM, Eric Dumazet wrote: > Since netif_index_is_l3_master() is not cheap, can you reorder the > test ? > > if (!net->ipv4.sysctl_tcp_l3mdev_accept) > return netif_index_is_l3_master(net, dif); sure. Since this use case is called under rcu_read_lock I can make a

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Andy Lutomirski
On Oct 13, 2016 6:46 AM, "Johannes Berg" wrote: > > On Thu, 2016-10-13 at 22:42 +0900, Sergey Senozhatsky wrote: > > > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > > > t/?h=x86/vmap_stack=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > > > >

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-13 Thread Alexander Duyck
On Thu, Oct 13, 2016 at 4:00 AM, Nikita Yushchenko wrote: It would make more sense to update the DMA API for __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if the direction is DMA_FROM_DEVICE. >>> >>> No, in generic case it's

Re: [PATCH net 2/2] conntrack: enable to tune gc parameters

2016-10-13 Thread Florian Westphal
Nicolas Dichtel wrote: > Le 10/10/2016 à 16:04, Florian Westphal a écrit : > > Nicolas Dichtel wrote: > >> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove > >> timed-out entries"), netlink conntrack deletion events

Re: slab corruption with current -git

2016-10-13 Thread Florian Westphal
Linus Torvalds wrote: > On Wed, Oct 12, 2016 at 11:27 PM, Markus Trippelsdorf > wrote: > > > > Yeah. > > > > 105 entry->orig_ops = reg; > > 106 entry->ops = *reg; > > 107 entry->next = NULL; > > So

Re: [PATCH] net: Require exact match for TCP socket lookups if dif is l3mdev

2016-10-13 Thread Eric Dumazet
On Thu, 2016-10-13 at 13:14 -0700, David Ahern wrote: > Currently, socket lookups for l3mdev (vrf) use cases can match a socket > that is bound to a port but not a device (ie., a global socket). If the > sysctl tcp_l3mdev_accept is not set this leads to ack packets going out > based on the main

[PATCH NET] ethtool: silence warning on bit loss

2016-10-13 Thread Jesse Brandeburg
Sparse was complaining when we went to prototype some code using ethtool_cmd_speed_set and SPEED_10, which uses the upper 16 bits of __u32 speed for the first time. CHECK ... .../uapi/linux/ethtool.h:123:28: warning: cast truncates bits from constant value (186a0 becomes 86a0) The warning

[PATCH] net: asix: Avoid looping when the device does not respond

2016-10-13 Thread Guenter Roeck
Check answers from USB stack and avoid re-sending the request multiple times if the device does not respond. This fixes the following problem, observed with a probably flaky adapter. [62108.732707] usb 1-3: new high-speed USB device number 5 using xhci_hcd [62108.914421] usb 1-3: New USB device

Need help with mdiobus_register and phy

2016-10-13 Thread Timur Tabi
I need help with a program I've discovered with my driver (ethernet/qualcomm/emac/) that occurs in the following process: 1. Load the driver 1a. Driver calls mdiobus_register (see emac_phy_config), which calls mdiobus_scan(), which calls get_phy_device() 1b. get_phy_device() performs MDIO bus

[PATCH v2] net: Require exact match for TCP socket lookups if dif is l3mdev

2016-10-13 Thread David Ahern
Currently, socket lookups for l3mdev (vrf) use cases can match a socket that is bound to a port but not a device (ie., a global socket). If the sysctl tcp_l3mdev_accept is not set this leads to ack packets going out based on the main table even though the packet came in from an L3 domain. The end

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Roopa Prabhu
On Thu, Oct 13, 2016 at 5:45 AM, Jiri Pirko wrote: > Thu, Oct 13, 2016 at 02:30:19PM CEST, j...@mojatatu.com wrote: >>On 16-10-13 08:10 AM, Jiri Pirko wrote: >>> Thu, Oct 13, 2016 at 01:49:07PM CEST, j...@mojatatu.com wrote: >>> > On 16-10-13 04:48 AM, Jiri Pirko wrote: >>

Re: bug in ixgbe_atr

2016-10-13 Thread Sowmini Varadhan
On (10/14/16 02:06), Duyck, Alexander H wrote: > > + case ETH_P_IP: > > + skb_header_pointer(skb, ETH_HLEN, sizeof (struct iphdr), > > + _hdr); > > /* access ihl as u8 to avoid unaligned access on ia64 */ > > - hlen = (hdr.network[0] &

Re: Need help with mdiobus_register and phy

2016-10-13 Thread Andrew Lunn
On Thu, Oct 13, 2016 at 06:15:39PM -0500, Timur Tabi wrote: > I need help with a program I've discovered with my driver > (ethernet/qualcomm/emac/) that occurs in the following process: > > 1. Load the driver > 1a. Driver calls mdiobus_register (see emac_phy_config), which calls > mdiobus_scan(),

Re: [PATCH v4 net-next 0/4] act_mirred: Ingress actions support

2016-10-13 Thread Cong Wang
On Wed, Oct 12, 2016 at 11:06 PM, Shmulik Ladkani wrote: > This patch series implements action mirred 'ingress' actions > TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. > > This allows attaching filters whose target is to hand matching skbs into > the rx processing of a

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-13 Thread Eric W. Biederman
Andrei Vagin writes: > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: >> Andrei Vagin writes: >> >> > From: Andrey Vagin >> > >> > The operation of destroying netns is heavy and it is executed under >> >

Re: tg3 BUG: spinlock lockup suspected

2016-10-13 Thread Siva Reddy Kallam
On Mon, Oct 10, 2016 at 5:21 PM, Siva Reddy Kallam wrote: > On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos wrote: >>> > That did not go well - bisect found the following commit but that does >>> > not seem to be related at all. So probably the

bug in ixgbe_atr

2016-10-13 Thread Sowmini Varadhan
When I was playing around with TPACKET_V2, I think I ran into a bug in ixgbe_atr(): if I get here with an sk_buff that has, e.g., just 14 bytes in the header, then the skb_network_header is invalid. I found my kernel sometimes wandering off into ipv6_find_hdr() in an attempt to get the

RE: bug in ixgbe_atr

2016-10-13 Thread Duyck, Alexander H
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Thursday, October 13, 2016 6:44 PM > To: Duyck, Alexander H ; > netdev@vger.kernel.org > Subject: bug in ixgbe_atr > > When I was playing around with TPACKET_V2, I think

linux-next: manual merge of the akpm tree with the net tree

2016-10-13 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in: include/linux/mlx5/device.h between commit: b8a4ddb2e8f4 ("net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON") from the net tree and patch: "include/linux/mlx5/device.h: kill BUILD_BUG_ON()s" from the akpm tree.

[PATCH net-next 2/2] ila: Cache a route to translated address

2016-10-13 Thread Tom Herbert
Add a dst_cache to ila_lwt structure. This holds a cached route for the translated address. In ila_output we now perform a route lookup after translation and if possible (destination in original route is full 128 bits) we set the dst_cache. Subsequent calls to ila_output can then use the cache to

[PATCH net-next 0/2] ila: Cache a route in ILA lwt structure

2016-10-13 Thread Tom Herbert
Add a dst_cache to ila_lwt structure. This holds a cached route for the translated address. In ila_output we now perform a route lookup after translation and if possible (destination in original route is full 128 bits) we set the dst_cache. Subsequent calls to ila_output can then use the cache to

[PATCH net-next 1/2] lwtunnel: Add destroy state operation

2016-10-13 Thread Tom Herbert
Users of lwt tunnels may set up some secondary state in build_state function. Add a corresponding destroy_state function to allow users to clean up state. This destroy state function is called from lwstate_free. Also, we now free lwstate using kfree_rcu so user can assume structure is not freed

[PATCH net 0/5] net/ncsi: More bug fixes

2016-10-13 Thread Gavin Shan
This series fixes 2 issues that were found during NCSI's availability testing on BCM5718 and improves HNCDSC AEN handler: * PATCH[1] and PATCH[2] refactors the code so that minimal code change is put to PATCH[3]. * PATCH[3] fixes the NCSI channel's stale link state before doing

[PATCH net 5/5] net/ncsi: Improve HNCDSC AEN handler

2016-10-13 Thread Gavin Shan
This improves AEN handler for Host Network Controller Driver Status Change (HNCDSC): * The channel's lock should be hold when accessing its state. * Do failover when host driver isn't ready. * Configure channel when host driver becomes ready. Signed-off-by: Gavin Shan

[PATCH net 4/5] net/ncsi: Choose hot channel as active one if necessary

2016-10-13 Thread Gavin Shan
The issue was found on BCM5718 which has two NCSI channels in one package: C0 and C1. C0 is in link-up state while C1 is in link-down state. C0 is chosen as active channel until unplugging and plugging C0's cable: On unplugging C0's cable, LSC (Link State Change) AEN packet received on C0 to

[PATCH net 3/5] net/ncsi: Fix stale link state of inactive channels on failover

2016-10-13 Thread Gavin Shan
The issue was found on BCM5718 which has two NCSI channels in one package: C0 and C1. Both of them are connected to different LANs, means they are in link-up state and C0 is chosen as the active one until resetting BCM5718 happens as below. Resetting BCM5718 results in LSC (Link State Change)

  1   2   >