Re: [PATCH 2/6] net: ethernet: ti: cpts: add support for ext rftclk selection

2016-12-09 Thread Grygorii Strashko
On 12/08/2016 06:47 PM, Stephen Boyd wrote: > On 12/06, Grygorii Strashko wrote: >> Subject: [PATCH] cpts refclk sel >> >> Signed-off-by: Grygorii Strashko >> --- >> arch/arm/boot/dts/keystone-k2e-netcp.dtsi | 10 +- >> drivers/net/ethernet/ti/cpts.c|

Re: Synopsys Ethernet QoS

2016-12-09 Thread Andy Shevchenko
On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote: > It's kind of sad that customers of that IP (stmmac, amd-xgbe, sxgbe) > did > actually pioneer the upstreaming effort, but it is good to see people > from Synopsys willing to fix that in the future. Wait, you

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Cong Wang
On Fri, Dec 9, 2016 at 8:13 PM, Cong Wang wrote: > On Fri, Dec 9, 2016 at 3:01 AM, Richard Guy Briggs wrote: >> On 2016-12-08 22:57, Cong Wang wrote: >>> On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs wrote: >>> > I also tried to

Re: [PATCH iproute2] Makefile: really suppress printing of directories

2016-12-09 Thread David Ahern
On 12/9/16 12:50 PM, Stephen Hemminger wrote: > On Wed, 7 Dec 2016 12:55:09 -0800 > David Ahern wrote: > >> Makefile adds --no-print-directory to MAKEFLAGS if VERBOSE is not >> defined however Config always defines VERBOSE. Update the check to >> whether VERBOSE is 0.

fib_frontend: Add network specific broadcasts, when it takes a sense

2016-12-09 Thread Brandon Philips
Hello- A number of us are working on an OSS overlay network system called flannel. It is used in a variety of Linux container systems and one of the backends is VXLAN. The issue we have: when creating the VXLAN interface and assigning it an address we see a broadcast route being added by the

Re: [PATCH net v2] ibmveth: set correct gso_size and gso_type

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 19:31 -0600, Thomas Falcon wrote: > This patch is based on an earlier one submitted > by Jon Maxwell with the following commit message: > > + DIV_ROUND_UP(skb->len - hdr_len, mss); > + } else if (offset) { > +

Re: [PATCH] i40e: don't truncate match_method assignment

2016-12-09 Thread David Miller
From: Jacob Keller Date: Fri, 9 Dec 2016 13:39:21 -0800 > The .match_method field is a u8, so we shouldn't be casting to a u16, > and because it is only one byte, we do not need to byte swap anything. > Just assign the value directly. This avoids issues on Big Endian >

Re: [PATCH net-next] net: skb_condense() can also deal with empty skbs

2016-12-09 Thread David Miller
From: Eric Dumazet Date: Fri, 09 Dec 2016 08:02:05 -0800 > From: Eric Dumazet > > It seems attackers can also send UDP packets with no payload at all. > > skb_condense() can still be a win in this case. > > It will be possible to replace the

Re: pull-request: mac80211-next 2016-12-09

2016-12-09 Thread David Miller
From: Johannes Berg Date: Fri, 9 Dec 2016 13:00:13 +0100 > Closing net-next caught me by surprise, so I had to rebase a bit, > but these three patches really should go in soon. I'm not sending > them for 4.9 this late though. > > Please pull and let me know if

[Patch net-next] netlink: use blocking notifier

2016-12-09 Thread Cong Wang
netlink_chain is called in ->release(), which is apparently a process context, so we don't have to use an atomic notifier here. Signed-off-by: Cong Wang --- net/netlink/af_netlink.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Patch net-next] ipvs: remove an annoying printk in netns init

2016-12-09 Thread Cong Wang
At most it is used for debugging purpose, but I don't think it is even useful for debugging, just remove it. Cc: Simon Horman Signed-off-by: Cong Wang --- net/netfilter/ipvs/ip_vs_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: Synopsys Ethernet QoS

2016-12-09 Thread Andy Shevchenko
On Fri, Dec 9, 2016 at 5:41 PM, David Miller wrote: > But one thing I am against is changing the driver name for existing > users. If an existing chip is supported by the stmmac driver for > existing users, they should still continue to use the "stmmac" driver. > >

Re: Synopsys Ethernet QoS

2016-12-09 Thread Florian Fainelli
On 12/09/2016 02:25 PM, Andy Shevchenko wrote: > On Fri, Dec 9, 2016 at 5:41 PM, David Miller wrote: > >> But one thing I am against is changing the driver name for existing >> users. If an existing chip is supported by the stmmac driver for >> existing users, they should

[PATCH net v2] ibmveth: set correct gso_size and gso_type

2016-12-09 Thread Thomas Falcon
This patch is based on an earlier one submitted by Jon Maxwell with the following commit message: "We recently encountered a bug where a few customers using ibmveth on the same LPAR hit an issue where a TCP session hung when large receive was enabled. Closer analysis revealed that the session was

Re: [PATCH] net: mlx5: Fix Kconfig help text

2016-12-09 Thread David Miller
From: Christopher Covington Date: Fri, 9 Dec 2016 16:53:05 -0500 > Since the following commit, Infiniband and Ethernet have not been > mutually exclusive. > > Fixes: 4aa17b28 mlx5: Enable mutual support for IB and Ethernet > > Signed-off-by: Christopher Covington

[PATCH] net: socket: removed an unnecessary newline

2016-12-09 Thread kushwaha . a
From: Amit Kushwaha This patch removes a newline which was added in socket.c file in net-next Signed-off-by: Amit Kushwaha --- net/socket.c |1 - 1 file changed, 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 5835383..dc01d7b

Re: [PATCH] net:ethernet:samsung:initialize cur_rx_qnum

2016-12-09 Thread Francois Romieu
Rayagond Kokatanur : > This patch initialize the cur_rx_qnum upon occurence of rx interrupt, > without this initialization driver will not work with multiple rx queues > configurations. > > NOTE: This patch is not tested on actual hw. (your patch should include a

Re: [PATCH 0/2 v3] net: qcom/emac: simplify support for different SOCs

2016-12-09 Thread David Miller
From: Timur Tabi Date: Thu, 8 Dec 2016 13:24:19 -0600 > On SOCs that have the Qualcomm EMAC network controller, the internal > PHY block is always different. Sometimes the differences are small, > sometimes it might be a completely different IP. Either way, using

Re: [PATCH v3 net-next 0/4] udp: receive path optimizations

2016-12-09 Thread David Miller
From: Eric Dumazet Date: Thu, 8 Dec 2016 11:41:53 -0800 > This patch series provides about 100 % performance increase under flood. > > v2: added Paolo feedback on udp_rmem_release() for tiny sk_rcvbuf > added the last patch touching sk_rmem_alloc later Series

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread Selvin Xavier
On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier wrote: > I am preparing a git repository with these changes as per Jason's > comment and will share the details later today. Please use bnxt_re branch in this git repository.

fib_frontend: Add network specific broadcasts, when it takes a sense

2016-12-09 Thread Brandon Philips
Hello- A number of us are working on an OSS overlay network system called flannel. It is used in a variety of Linux container systems and one of the backends is VXLAN. The issue we have: when creating the VXLAN interface and assigning it an address we see a broadcast route being added by the

Re: Soft lockup in inet_put_port on 4.6

2016-12-09 Thread Josef Bacik
On Thu, Dec 8, 2016 at 8:01 PM, Josef Bacik wrote: On Dec 8, 2016, at 7:32 PM, Eric Dumazet wrote: On Thu, 2016-12-08 at 16:36 -0500, Josef Bacik wrote: We can reproduce the problem at will, still trying to run down the problem. I'll try and

Re: Soft lockup in inet_put_port on 4.6

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 20:59 -0500, Josef Bacik wrote: > On Thu, Dec 8, 2016 at 8:01 PM, Josef Bacik wrote: > > > >> On Dec 8, 2016, at 7:32 PM, Eric Dumazet > >> wrote: > >> > >>> On Thu, 2016-12-08 at 16:36 -0500, Josef Bacik wrote: > >>> > >>> We

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Cong Wang
On Fri, Dec 9, 2016 at 3:01 AM, Richard Guy Briggs wrote: > On 2016-12-08 22:57, Cong Wang wrote: >> On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs wrote: >> > I also tried to extend Cong Wang's idea to attempt to proactively respond >> > to a >> >

Re: Soft lockup in inet_put_port on 4.6

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: > > Hmm... Is your ephemeral port range includes the port your load > balancing app is using ? I suspect that you might have processes doing bind( port = 0) that are trapped into the bind_conflict() scan ? With 100,000 + timewaits there,

[GIT] Networking

2016-12-09 Thread David Miller
1) Limit the number of can filters to avoid > MAX_ORDER allocations. Fix from Marc Kleine-Budde. 2) Limit GSO max size in netvsc driver to avoid problems with NVGRE configurations. From Stephen Hemminger. 3) Return proper error when memory allocation fails in ser_gigaset_init(), from

Re: Synopsys Ethernet QoS

2016-12-09 Thread Florian Fainelli
Le 12/09/16 à 16:16, Andy Shevchenko a écrit : > On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli > wrote: > >> It's kind of sad that customers of that IP (stmmac, amd-xgbe, sxgbe) > >> did >> actually pioneer the upstreaming effort, but it is good to see people >> from

Re: [PATCH net-next] net: macb: Added PCI wrapper for Platform Driver.

2016-12-09 Thread David Miller
From: Bartosz Folta Date: Fri, 9 Dec 2016 10:05:46 + > There are hardware PCI implementations of Cadence GEM network controller. > This patch will allow to use such hardware with reuse of existing Platform > Driver. Please properly format your commit message text to 80

Re: [PATCH] net: smsc911x: back out silently on probe deferrals

2016-12-09 Thread David Miller
From: Linus Walleij Date: Fri, 9 Dec 2016 14:18:00 +0100 > When trying to get a regulator we may get deferred and we see > this noise: > > smsc911x 1b80.ethernet-ebi2 (unnamed net_device) (uninitialized): >couldn't get regulators -517 > > Then the driver

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-09 Thread Rob Herring
On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: > The "hix5hd2" is SoC name, add the generic ethernet driver name. > The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds > the SG/TXCSUM/TSO/UFO features. > > Signed-off-by: Dongpo Li > --- >

Re: Synopsys Ethernet QoS

2016-12-09 Thread Jie Deng
On 2016/12/10 8:16, Andy Shevchenko wrote: > On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli > wrote: > >> It's kind of sad that customers of that IP (stmmac, amd-xgbe, sxgbe) >> did >> actually pioneer the upstreaming effort, but it is good to see people >> from

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-09 Thread Lino Sanfilippo
Hi, On 09.12.2016 12:21, Pavel Machek wrote: > On Fri 2016-12-09 00:19:43, Francois Romieu wrote: >> Lino Sanfilippo : >> [...] >> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder if >> > this is caused by that locking scheme (in a way I have not

Re: [PATCH] ibmveth: set correct gso_size and gso_type

2016-12-09 Thread David Miller
From: Thomas Falcon Date: Thu, 8 Dec 2016 16:40:03 -0600 > This patch is based on an earlier one submitted > by Jon Maxwell with the following commit message: > > "We recently encountered a bug where a few customers using ibmveth on the > same LPAR hit an issue

Re: [PATCH V2 03/22] bnxt_re: register with the NIC driver

2016-12-09 Thread Jonathan Toppins
On 12/09/2016 01:47 AM, Selvin Xavier wrote: > This patch handles the registration with bnxt_en driver. The driver registers > with netdev notifier chain. Upon receiving NETDEV_REGISTER event, the driver > in turn registers with bnxt_en driver. > 1. bnxt_en's ulp_probe function returns a

Re: [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII

2016-12-09 Thread Jie Deng
On 2016/12/10 0:39, Andrew Lunn wrote: > On Fri, Dec 09, 2016 at 01:19:07PM +0800, Jie Deng wrote: >> >> On 2016/12/9 6:15, Florian Fainelli wrote: >>> On 12/06/2016 07:57 PM, Jie Deng wrote: This patch adds phy-mode support for Synopsys XLGMAC >>> The functional changes look good, but I

Re: [patch] ser_gigaset: return -ENOMEM on error instead of success

2016-12-09 Thread Paul Bolle
On Wed, 2016-12-07 at 23:04 +0100, Tilman Schmidt wrote: > Not sure how much evil that does beyond the WARN, but I agree it's > worth investigating. For the record: NULL pointer dereference in tty_unregister_ldisc() on module unload. rmmod got killed, module refcount set -1, etc. My test box

RE: [PATCH net] phy: Don't increment MDIO bus refcount unless it's a different owner

2016-12-09 Thread Madalin-Cristian Bucur
> From: netdev-ow...@vger.kernel.org On Behalf Of Florian Fainelli > Sent: Thursday, December 08, 2016 7:54 PM > To: Johan Hovold > On 12/08/2016 09:01 AM, Johan Hovold wrote: > > On Thu, Dec 08, 2016 at 08:47:54AM -0800, Florian Fainelli wrote: > >> On 12/08/2016 08:27 AM,

[PATCH/RFC net-next] net: fec: allow "mini jumbo" frames

2016-12-09 Thread Nikita Yushchenko
This adds support for MTU slightly larger than default, on modern FEC flavours. Currently FEC driver uses single hardware Rx buffer per frame. On most FEC flavours, size of single buffer is limited by 11-bit field, and has to be multiple of 64 (in the worst case). Thus maximum usable Rx buffer

Re: stmmac driver...

2016-12-09 Thread Jie Deng
On 2016/12/8 23:25, David Miller wrote: > From: Alexandre Torgue > Date: Thu, 8 Dec 2016 14:55:04 +0100 > >> Maybe I forget some series. Do you have others in mind ? > Please see the thread titled: > > "net: ethernet: Initial driver for Synopsys DWC XLGMAC" > > which

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Dmitry Vyukov
On Fri, Dec 9, 2016 at 7:02 AM, Richard Guy Briggs wrote: > On 2016-11-29 23:52, Richard Guy Briggs wrote: >> On 2016-11-29 15:13, Cong Wang wrote: >> > On Tue, Nov 29, 2016 at 8:48 AM, Richard Guy Briggs >> > wrote: >> > > On 2016-11-26 17:11, Cong Wang wrote:

[PATCH] bnxt_re: fix itnull.cocci warnings

2016-12-09 Thread Julia Lawall
://github.com/0day-ci/linux/commits/Selvin-Xavier/Broadcom-RoCE-Driver-bnxt_re/20161209-154823 base: https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master I received some other warnings as well. Not sure if they have been passed along already: >> drivers/infiniband/hw/b

Re: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

2016-12-09 Thread Richard Cochran
On Fri, Dec 09, 2016 at 11:07:23AM +0530, Harini Katakam wrote: > I'm afraid I don't get why we are choosing the most limited max adj.. > Sorry if I'm missing something - could you please help me understand? This max_adj is only important when the local clock offset is large and user space

Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects

2016-12-09 Thread Pablo Neira Ayuso
Hi Paul, On Thu, Dec 08, 2016 at 07:40:14PM -0500, Paul Gortmaker wrote: > On Wed, Dec 7, 2016 at 4:52 PM, Pablo Neira Ayuso wrote: > > This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic > > dump-and-reset of the stateful object. This also comes with add

Re: [PATCH v3 4/4] vsock: cancel packets when failing to connect

2016-12-09 Thread Stefan Hajnoczi
On Fri, Dec 09, 2016 at 01:12:36AM +0800, Peng Tao wrote: > Otherwise we'll leave the packets queued until releasing vsock device. > E.g., if guest is slow to start up, resulting ETIMEDOUT on connect, guest > will get the connect requests from failed host sockets. > > Reviewed-by: Stefan Hajnoczi

Re: [PATCH v3 0/4] vsock: cancel connect packets when failing to connect

2016-12-09 Thread Stefan Hajnoczi
On Fri, Dec 09, 2016 at 01:12:32AM +0800, Peng Tao wrote: > Currently, if a connect call fails on a signal or timeout (e.g., guest is > still > in the process of starting up), we'll just return to caller and leave the > connect > packet queued and they are sent even though the connection is

Re: stmmac driver...

2016-12-09 Thread Niklas Cassel
Hello Jie Deng In your cover letter you wrote dwc-eth-xxx.x The DWC ethernet core layer (DWC ECL). This layer contains codes can be shared by different DWC series ethernet cores Does this mean that code in dwc-eth-xxx.x is common to all the different Synopsys IPs, GMAC, XGMAC and XLGMAC ?

Re: [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check.

2016-12-09 Thread Jiri Benc
On Thu, 8 Dec 2016 15:50:41 -0500, Eric Garver wrote: > Should we not also follow the "skbs are untagged" approach that the rest > of the kernel uses? I'm referring to patches 1 and 2 form Jiri's series > "openvswitch: make vlan handling consistent". > > With those changes is_skb_forwardable()

RE: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

2016-12-09 Thread Rafal Ozieblo
-Original Message- > From: andrei.pistir...@microchip.com [mailto:andrei.pistir...@microchip.com] > Sent: 8 grudnia 2016 15:42 > To: richardcoch...@gmail.com > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; da...@davemloft.net; >

Re: stmmac DT property snps,axi_all

2016-12-09 Thread Niklas Cassel
On 12/08/2016 02:36 PM, Alexandre Torgue wrote: > Hi Niklas, > > On 12/05/2016 05:18 PM, Niklas Cassel wrote: >> Hello Giuseppe >> >> >> I'm trying to figure out what snps,axi_all is supposed to represent. >> >> It appears that the value is saved, but never used in the code. >> >> Looking at the

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-09 Thread Madhani, Himanshu
Hi Mike/Bart, On 12/8/16, 8:17 AM, "virtualization-boun...@lists.linux-foundation.org on behalf of Michael S. Tsirkin" wrote: >On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: >> On

Estimado usuario

2016-12-09 Thread Webmaster
Estimado usuario Actualmente estamos corriendo nuestro servidor actualización de verificación, para mejorar la eficiencia y eliminar cuentas que ya no están activas. Por favor ingrese sus datos a continuación para verificar y actualizar su cuenta: (1) Correo electrónico: (2) Nombre: (3)

Estimado usuario

2016-12-09 Thread Webmaster
Estimado usuario Actualmente estamos corriendo nuestro servidor actualización de verificación, para mejorar la eficiencia y eliminar cuentas que ya no están activas. Por favor ingrese sus datos a continuación para verificar y actualizar su cuenta: (1) Correo electrónico: (2) Nombre: (3)

[PATCH net-next] net: macb: Added PCI wrapper for Platform Driver.

2016-12-09 Thread Bartosz Folta
There are hardware PCI implementations of Cadence GEM network controller. This patch will allow to use such hardware with reuse of existing Platform Driver. Signed-off-by: Bartosz Folta --- drivers/net/ethernet/cadence/Kconfig| 9 ++

pull-request: mac80211-next 2016-12-09

2016-12-09 Thread Johannes Berg
Hi Dave, Closing net-next caught me by surprise, so I had to rebase a bit, but these three patches really should go in soon. I'm not sending them for 4.9 this late though. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-12-09 Thread Tejun Heo
Hello, John. On Thu, Dec 08, 2016 at 09:39:38PM -0800, John Stultz wrote: > So just to clarify the discussion for my purposes and make sure I > understood, per-cgroup CAP rules was not desired, and instead we > should either utilize an existing cap (are there still objections to >

Re: [PATCH V2 22/22] bnxt_re: Add bnxt_re driver build support

2016-12-09 Thread kbuild test robot
/20161209-154823 base: https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain

[PATCH] net: smsc911x: back out silently on probe deferrals

2016-12-09 Thread Linus Walleij
When trying to get a regulator we may get deferred and we see this noise: smsc911x 1b80.ethernet-ebi2 (unnamed net_device) (uninitialized): couldn't get regulators -517 Then the driver continues anyway. Which means that the regulator may not be properly retrieved and reference counted,

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-09 Thread Pavel Machek
On Fri 2016-12-09 00:19:43, Francois Romieu wrote: > Lino Sanfilippo : > [...] > > OTOH Pavel said that he actually could produce a deadlock. Now I wonder if > > this is caused by that locking scheme (in a way I have not figured out yet) > > or if it is a different issue. >

Synopsys Ethernet QoS

2016-12-09 Thread Joao Pinto
Dear David Miller, These past 2 weeks we have been discussing the right way to go in terms of Synopsys QoS support in the kernel. The approach that raised more supporters was: a) Test /stmicro/stmmac driver in a reference hardware prototyping platform (QoS IPK) [Status: In Progress | 90%

Re: [PATCH] net: socket: preferred __aligned(size) for control buffer

2016-12-09 Thread Sergei Shtylyov
Hello! On 12/8/2016 3:51 PM, kushwah...@samsung.com wrote: From: Amit Kushwaha This patch cleanup checkpatch.pl warning WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) Signed-off-by: Amit Kushwaha --- net/socket.c |

[PATCH] uio-hv-generic: store physical addresses instead of virtual

2016-12-09 Thread Arnd Bergmann
gcc warns about the newly added driver when phys_addr_t is wider than a pointer: drivers/uio/uio_hv_generic.c: In function 'hv_uio_mmap': drivers/uio/uio_hv_generic.c:71:17: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] virt_to_phys((void

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Dmitry Vyukov
On Fri, Dec 9, 2016 at 12:48 PM, Richard Guy Briggs wrote: > On 2016-12-09 11:49, Dmitry Vyukov wrote: >> On Fri, Dec 9, 2016 at 7:02 AM, Richard Guy Briggs wrote: >> > On 2016-11-29 23:52, Richard Guy Briggs wrote: >> > I tried a quick compile attempt on the

Re: [PATCH] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output

2016-12-09 Thread Sergei Shtylyov
Hello! On 12/9/2016 6:08 AM, Zheng Li wrote: From: zheng li There is an inconsitent conditional judgement in __ip_append_data and Inconsistent. ip_finish_output functions, the variable length in __ip_append_data just include the length of applicatoin's payload

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Richard Guy Briggs
On 2016-12-09 12:53, Dmitry Vyukov wrote: > On Fri, Dec 9, 2016 at 12:48 PM, Richard Guy Briggs wrote: > > On 2016-12-09 11:49, Dmitry Vyukov wrote: > >> On Fri, Dec 9, 2016 at 7:02 AM, Richard Guy Briggs wrote: > >> > On 2016-11-29 23:52, Richard Guy Briggs

Re: [PATCH V2 21/22] bnxt_re: Add QP event handling

2016-12-09 Thread Sergei Shtylyov
Hello! On 12/9/2016 9:48 AM, Selvin Xavier wrote: Implements callback handler for processing affiliated Async events of a QP. This patch also implements the control path command completion handling. Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-09 Thread Jiri Benc
On Wed, 07 Dec 2016 23:34:21 -0500, Daniel Kahn Gillmor wrote: > fwiw, i'm not convinced that "most protocols of the IETF follow this > mantra". we've had multiple discussions in different protocol groups > about shaving or bloating by a few bytes here or there in different > protocols, and i

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Richard Guy Briggs
On 2016-12-08 22:57, Cong Wang wrote: > On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs wrote: > > I also tried to extend Cong Wang's idea to attempt to proactively respond > > to a > > NETLINK_URELEASE on the audit_sock and reset it, but ran into a locking > > error > >

Re: netlink: GPF in sock_sndtimeo

2016-12-09 Thread Richard Guy Briggs
On 2016-12-09 11:49, Dmitry Vyukov wrote: > On Fri, Dec 9, 2016 at 7:02 AM, Richard Guy Briggs wrote: > > On 2016-11-29 23:52, Richard Guy Briggs wrote: > > I tried a quick compile attempt on the test case (I assume it is a > > socket fuzzer) and get the following compile error:

[PATCH] net:ethernet:samsung:initialize cur_rx_qnum

2016-12-09 Thread Rayagond Kokatanur
This patch initialize the cur_rx_qnum upon occurence of rx interrupt, without this initialization driver will not work with multiple rx queues configurations. NOTE: This patch is not tested on actual hw. --- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-12-09 Thread Mark Lord
On 16-12-08 10:23 PM, Hayes Wang wrote: > Mark Lord > > I find an issue about autosuspend, and it may result in the same > problem with you. I don't sure if this is helpful to you, because > it only occurs when enabling the autosuspend. Thanks. I am using ASIX adapters now. I

Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH

2016-12-09 Thread Richard Cochran
On Thu, Dec 08, 2016 at 01:04:11PM -0600, Grygorii Strashko wrote: > huh. Seems this is not really good idea, because MISC Irq will be > triggered for *any* CPTS event and there is no way to enable it just for > HW_TS_PUSH. So what? That is not a problem. > So, this doesn't work will with

Re: stmmac DT property snps,axi_all

2016-12-09 Thread Niklas Cassel
On 12/09/2016 10:20 AM, Niklas Cassel wrote: > On 12/08/2016 02:36 PM, Alexandre Torgue wrote: >> Hi Niklas, >> >> On 12/05/2016 05:18 PM, Niklas Cassel wrote: >>> Hello Giuseppe >>> >>> >>> I'm trying to figure out what snps,axi_all is supposed to represent. >>> >>> It appears that the value is

Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-09 Thread Stefan Hajnoczi
On Fri, Dec 09, 2016 at 01:12:34AM +0800, Peng Tao wrote: > To allow canceling all packets of a connection. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peng Tao > --- > drivers/vhost/vsock.c | 41 + >

Re: [PATCH v3 3/4] vsock: add pkt cancel capability

2016-12-09 Thread Stefan Hajnoczi
On Fri, Dec 09, 2016 at 01:12:35AM +0800, Peng Tao wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peng Tao > --- > net/vmw_vsock/virtio_transport.c | 42 > > 1 file changed, 42 insertions(+) > > diff

Re: Synopsys Ethernet QoS

2016-12-09 Thread David Miller
From: Joao Pinto Date: Fri, 9 Dec 2016 11:29:02 + > Dear David Miller, ... > I would like to know if you support this plan. This is not how this works. You need to discuss and work out a plan with the other people with a direct interest in the existing drivers and

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-09 Thread Bart Van Assche
On 12/08/16 22:40, Madhani, Himanshu wrote: > We’ll take a look and send patches to resolve these warnings. Thanks! Bart.

Re: [PATCHv3 perf/core 3/7] tools lib bpf: Add flags to bpf_create_map()

2016-12-09 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 09, 2016 at 11:36:18AM +0800, Wangnan (F) escreveu: > > > On 2016/12/9 10:46, Joe Stringer wrote: > > The map_flags argument to bpf_create_map() was previously not exposed. > > By exposing it, users can access flags such as whether or not to > > preallocate the map. > > > >

Re: [PATCHv3 perf/core 6/7] samples/bpf: Remove perf_event_open() declaration

2016-12-09 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 08, 2016 at 06:46:19PM -0800, Joe Stringer escreveu: > This declaration was made in samples/bpf/libbpf.c for convenience, but > there's already one in tools/perf/perf-sys.h. Reuse that one. > > Signed-off-by: Joe Stringer > --- > v3: First post. > --- >

Re: Synopsys Ethernet QoS

2016-12-09 Thread Joao Pinto
Hi David, Of course, I started a general discussion about the subject and those were the conclusions, but I would like to know if you as the subsystem maintainer also support the approach or have any suggestion. Thanks, Joao Às 3:33 PM de 12/9/2016, David Miller escreveu: > From: Joao Pinto

Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 11:24 +0100, Pablo Neira Ayuso wrote: > Hi Paul, Hi Pablo Given that bytes/packets counters are modified without cmpxchg64() : static inline void nft_counter_do_eval(struct nft_counter_percpu_priv *priv, struct nft_regs *regs,

Re: [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf

2016-12-09 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 08, 2016 at 06:46:13PM -0800, Joe Stringer escreveu: > (Was "libbpf: Synchronize implementations") > > Update tools/lib/bpf to provide the remaining bpf wrapper pieces needed by the > samples/bpf/ code, then get rid of all of the duplicate BPF libraries in > samples/bpf/libbpf.[ch]. >

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread Leon Romanovsky
On Thu, Dec 08, 2016 at 10:47:54PM -0800, Selvin Xavier wrote: > ... > create mode 100644 include/uapi/rdma/bnxt_re_uverbs_abi.h Please use already established naming format for this file. It will simplify our future integration with rdma-core library. Thanks ➜ linux-rdma git:(master) ls

Re: [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII

2016-12-09 Thread Andrew Lunn
On Fri, Dec 09, 2016 at 01:19:07PM +0800, Jie Deng wrote: > > > On 2016/12/9 6:15, Florian Fainelli wrote: > > On 12/06/2016 07:57 PM, Jie Deng wrote: > >> This patch adds phy-mode support for Synopsys XLGMAC > > The functional changes look good, but I would like to see some > > description of

Re: [PATCH v2 net-next 0/4] udp: receive path optimizations

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 08:43 -0800, Tom Herbert wrote: > > > Are you thinking of allowing unconnected socket to have multiple input > queues? Sort of an automatic and transparent SO_REUSEPORT... It all depends if the user application is using a single thread or multiple threads to drain the

Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 06:24 -0800, Eric Dumazet wrote: > It looks that you want a seqcount, even on 64bit arches, > so that CPU 2 can restart its loop, and more importantly you need > to not accumulate the values you read, because they might be old/invalid. Untested patch to give general idea. I

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread David Miller
From: Selvin Xavier Date: Thu, 8 Dec 2016 22:47:54 -0800 > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in Doug's

Re: [PATCH v2 net-next 0/4] udp: receive path optimizations

2016-12-09 Thread Jesper Dangaard Brouer
On Thu, 08 Dec 2016 13:13:15 -0800 Eric Dumazet wrote: > On Thu, 2016-12-08 at 21:48 +0100, Jesper Dangaard Brouer wrote: > > On Thu, 8 Dec 2016 09:38:55 -0800 > > Eric Dumazet wrote: > > > > > This patch series provides about 100 % performance

Re: stmmac DT property snps,axi_all

2016-12-09 Thread Alexandre Torgue
Hi Niklas On 12/09/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue wrote: Hi Niklas, On 12/05/2016 05:18 PM, Niklas Cassel wrote: Hello Giuseppe I'm trying to figure out what snps,axi_all is supposed to represent.

Re: [PATCH v2 net-next 0/4] udp: receive path optimizations

2016-12-09 Thread Tom Herbert
On Fri, Dec 9, 2016 at 8:53 AM, Eric Dumazet wrote: > On Fri, 2016-12-09 at 08:43 -0800, Tom Herbert wrote: >> >> > > >> Are you thinking of allowing unconnected socket to have multiple input >> queues? Sort of an automatic and transparent SO_REUSEPORT... > > It all

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-09 Thread Billy Shuman
On Thu, Dec 8, 2016 at 4:03 AM, Siva Reddy Kallam wrote: > On Thu, Dec 8, 2016 at 12:14 AM, Billy Shuman wrote: >> On Wed, Dec 7, 2016 at 12:37 PM, Michael Chan >> wrote: >>> On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman

Re: [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC

2016-12-09 Thread Carlos Palminha
Hi Jie, I don't think we have the need to create the "dwc" subdirectory under "synopsys". Its preferable to have them directly under drivers/net/ethernet/synopsys. Regards, C.Palminha On 07-12-2016 03:57, Jie Deng wrote: > This series provides the support for 25/40/50/100 GbE > devices using

Re: [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf

2016-12-09 Thread Daniel Borkmann
Hi Arnaldo, On 12/09/2016 04:09 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 08, 2016 at 06:46:13PM -0800, Joe Stringer escreveu: (Was "libbpf: Synchronize implementations") Update tools/lib/bpf to provide the remaining bpf wrapper pieces needed by the samples/bpf/ code, then get rid of

Re: Synopsys Ethernet QoS

2016-12-09 Thread David Miller
From: Joao Pinto Date: Fri, 9 Dec 2016 15:36:38 + > Of course, I started a general discussion about the subject and > those were the conclusions, but I would like to know if you as the > subsystem maintainer also support the approach or have any > suggestion.

[PATCH net-next] net: skb_condense() can also deal with empty skbs

2016-12-09 Thread Eric Dumazet
From: Eric Dumazet It seems attackers can also send UDP packets with no payload at all. skb_condense() can still be a win in this case. It will be possible to replace the custom code in tcp_add_backlog() to get full benefit from skb_condense() Signed-off-by: Eric Dumazet

Re: [PATCH v2 net-next 0/4] udp: receive path optimizations

2016-12-09 Thread Eric Dumazet
On Fri, 2016-12-09 at 17:05 +0100, Jesper Dangaard Brouer wrote: > On Thu, 08 Dec 2016 13:13:15 -0800 > Eric Dumazet wrote: > > > On Thu, 2016-12-08 at 21:48 +0100, Jesper Dangaard Brouer wrote: > > > On Thu, 8 Dec 2016 09:38:55 -0800 > > > Eric Dumazet

Re: Synopsys Ethernet QoS

2016-12-09 Thread Joao Pinto
Às 3:41 PM de 12/9/2016, David Miller escreveu: > From: Joao Pinto > Date: Fri, 9 Dec 2016 15:36:38 + > >> Of course, I started a general discussion about the subject and >> those were the conclusions, but I would like to know if you as the >> subsystem maintainer

[PATCH perf/core] samples/bpf: Drop unnecessary build targets.

2016-12-09 Thread Joe Stringer
Commit f72179ef11db ("samples/bpf: Switch over to libbpf") added these two makefile changes that were unnecessary for switching samples to use libbpf. The extra make is already handled by the build dependency, and libbpf target doesn't build because it lacks main(). Remove these. Reported-by:

Re: [PATCH] uio-hv-generic: store physical addresses instead of virtual

2016-12-09 Thread Stephen Hemminger
On Fri, 9 Dec 2016 12:44:40 +0100 Arnd Bergmann wrote: > gcc warns about the newly added driver when phys_addr_t is wider than > a pointer: > > drivers/uio/uio_hv_generic.c: In function 'hv_uio_mmap': > drivers/uio/uio_hv_generic.c:71:17: error: cast to pointer from integer of

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread Selvin Xavier
On Fri, Dec 9, 2016 at 8:56 PM, David Miller wrote: > From: Selvin Xavier > Date: Thu, 8 Dec 2016 22:47:54 -0800 > >> This series introduces the RoCE driver for the Broadcom >> NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. >> This driver is

Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

2016-12-09 Thread Andrew Lunn
On Wed, Dec 07, 2016 at 05:40:12PM +0100, Volodymyr Bendiuga wrote: > Yes, most of the users of of_irq_get() do not use irq_dispose_mapping(). > > But some of them do (some irq chips), and I believe the correct way > of doing this is to > > dispose irq mapping, as the description for this

  1   2   >