Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-05 Thread Sowmini Varadhan
On (01/04/17 16:26), Shuah Khan wrote: > > Could you please split this patch into two. Hardening part in one and > the cleanup in a separate patch. This way I can get the hardening fix > into 4.10 in my next Kselftest update. Cleanup patch can go in later. > > thanks, > -- Shuah I'm a little

[PATCH v4 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Joao Pinto
This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Signed-off-by: Joao Pinto --- changes v3 -> v4: - stmmac_res is now being initialized to 0

Re: [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin

2017-01-05 Thread Andrew Lunn
On Thu, Jan 05, 2017 at 03:25:53PM +0100, Gregory CLEMENT wrote: > Hi David, > > On mer., déc. 21 2016, Romain Perier > wrote: > > > This set of patches adds support for the Marvell ethernet switch 88E6341. > > It also add the devicetree definition of this

[PATCH v4 2/3] stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure

2017-01-05 Thread Joao Pinto
This patch moves stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to the plat_stmmacenet_data structure. It also moves these platform variables initialization to stmmac_platform. This was done for two reasons: a) If PCI is used, platform related code is being executed in stmmac_main resulting in

[PATCH v4 0/3] adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Joao Pinto
This patch set contains the porting of the synopsys/dwc_eth_qos.c driver to the stmmac structure. This operation resulted in the creation of a new platform glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. dwmac-dwc-qos-eth inherited dwc_eth_qos DT bindings, to assure

[PATCH v4 1/3] stmmac: adding DT parameter for LPI tx clock gating

2017-01-05 Thread Joao Pinto
This patch adds a new parameter to the stmmac DT: snps,en-tx-lpi-clockgating. It was ported from synopsys/dwc_eth_qos.c and it is useful if lpi tx clock gating is needed by stmmac users also. Signed-off-by: Joao Pinto --- changes v1 -> v4: - Nothing changed, just to keep up

[PATCH v4 net-next] tools: psock_tpacket: block Rx until socket filter has been added and socket has been bound to loopback.

2017-01-05 Thread Sowmini Varadhan
Packets from any/all interfaces may be queued up on the PF_PACKET socket before it is bound to the loopback interface by psock_tpacket, and when these are passed up by the kernel, they could interfere with the Rx tests. Avoid interference from spurious packet by blocking Rx until the socket

Re: [PATCH v1 1/2] bpf: add a longest prefix match trie map implementation

2017-01-05 Thread Daniel Borkmann
On 01/05/2017 05:25 PM, Daniel Borkmann wrote: On 12/29/2016 06:28 PM, Daniel Mack wrote: This trie implements a longest prefix match algorithm that can be used to match IP addresses to a stored set of ranges. Internally, data is stored in an unbalanced trie of nodes that has a maximum height

[PATCH net-next] net: make ndo_get_stats64 a void function

2017-01-05 Thread Stephen Hemminger
The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to

Re: [PATCH net-next] net: make ndo_get_stats64 a void function

2017-01-05 Thread David Miller
From: Stephen Hemminger Date: Thu, 5 Jan 2017 09:31:36 -0800 > The network device operation for reading statistics is only called > in one place, and it ignores the return value. Having a structure > return value is potentially confusing because some future driver

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-01-05 Thread Eric Dumazet
On Thu, 2017-01-05 at 02:34 +0100, Daniel Borkmann wrote: > When TX timestamping is in use with TPACKET_V3's TX ring, then we'll > hit the BUG() in __packet_set_timestamp() when ring buffer slot is > returned to user space via tpacket_destruct_skb(). This is due to v3 > being assumed as

Re: [PATCH] MIPS: NI 169445 board support

2017-01-05 Thread Joao Pinto
Às 6:44 PM de 1/5/2017, Nathan Sullivan escreveu: > On Thu, Jan 05, 2017 at 06:33:53PM +, Joao Pinto wrote: >> Hi, >> >> Às 6:28 PM de 1/5/2017, Niklas Cassel escreveu: >>> On 01/04/2017 05:38 PM, Nathan Sullivan wrote: On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: >

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Alexandre Torgue
Hi Joao, On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Sorry to come late in the review. I have a basic question.

[net-next PATCH v6 1/3] net: net_device_ops: Introduce ndo_get_vf_count

2017-01-05 Thread Phil Sutter
The idea is to allow drivers to implement this callback in order to provide a custom way to return the number of virtual functions present on the device. Signed-off-by: Phil Sutter --- Changes since v5: - Introduced this patch. --- include/linux/netdevice.h | 5 + 1 file

[net-next PATCH v6 3/3] net: dummy: Introduce dummy virtual functions

2017-01-05 Thread Phil Sutter
The idea for this was born when testing VF support in iproute2 which was impeded by hardware requirements. In fact, not every VF-capable hardware driver implements all netdev ops, so testing the interface is still hard to do even with a well-sorted hardware shelf. To overcome this and allow for

RE: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread KY Srinivasan
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 5, 2017 10:29 AM > To: KY Srinivasan > Cc: Stephen Hemminger ; > da...@davemloft.net; netdev@vger.kernel.org; linux- >

[PATCH net-next v2] net: dsa: b53: Utilize common helpers for u64/MAC

2017-01-05 Thread Florian Fainelli
Utilize the two functions recently introduced: u64_to_ether() and ether_to_u64() instead of our own versions. Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli --- Changes in v2: - include etherdevice.h in b53_priv.h to fix Kbuild reported errors

Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib

2017-01-05 Thread David Miller
From: Saeed Mahameed Date: Tue, 3 Jan 2017 23:55:25 +0200 > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > index ddb4ca4..39505ac 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > +++

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Joao Pinto
Hi Alex, Às 5:19 PM de 1/5/2017, Alexandre Torgue escreveu: > Hi Joao, > > On 01/04/2017 05:22 PM, Joao Pinto wrote: >> This patch adds a new glue driver called dwmac-dwc-qos-eth which >> was based in the dwc_eth_qos as is. To assure retro-compatibility a slight >> tweak was also added to

Re: [PATCH net-next] net: dsa: remove version string

2017-01-05 Thread Florian Fainelli
On 01/05/2017 09:28 AM, Vivien Didelot wrote: > The dsa_driver_version string is irrelevant and has not been bumped > since its introduction about 9 years ago. Kill it. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli

[PATCH net-next] net: dsa: remove version string

2017-01-05 Thread Vivien Didelot
The dsa_driver_version string is irrelevant and has not been bumped since its introduction about 9 years ago. Kill it. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 5 - net/dsa/dsa_priv.h | 1 - net/dsa/slave.c| 1 - 3 files changed, 7

[PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread Stephen Hemminger
Update the Hyper-V MAINTAINERS to include myself. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea11bb03f550..7542341d8155 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5963,6 +5963,7

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-05 Thread Shuah Khan
On 01/05/2017 08:54 AM, Sowmini Varadhan wrote: > On (01/04/17 16:26), Shuah Khan wrote: >> >> Could you please split this patch into two. Hardening part in one and >> the cleanup in a separate patch. This way I can get the hardening fix >> into 4.10 in my next Kselftest update. Cleanup patch can

Re: [PATCH net-next v2] tcp: provide timestamps for partial writes

2017-01-05 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 4 Jan 2017 11:19:34 -0500 > From: Soheil Hassas Yeganeh > > For TCP sockets, TX timestamps are only captured when the user data > is successfully and fully written to the socket. In many cases, > however, TCP

Re: [PATCH] MIPS: NI 169445 board support

2017-01-05 Thread Joao Pinto
Hi, Às 6:28 PM de 1/5/2017, Niklas Cassel escreveu: > On 01/04/2017 05:38 PM, Nathan Sullivan wrote: >> On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: >>> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote: Date: Fri, 2 Dec 2016 09:42:09 -0600 From: Nathan

Re: [PATCH] MIPS: NI 169445 board support

2017-01-05 Thread Nathan Sullivan
On Thu, Jan 05, 2017 at 06:33:53PM +, Joao Pinto wrote: > Hi, > > Às 6:28 PM de 1/5/2017, Niklas Cassel escreveu: > > On 01/04/2017 05:38 PM, Nathan Sullivan wrote: > >> On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: > >>> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan

Re: [PATCH] tg3: Avoid NULL pointer dereference in tg3_get_nstats()

2017-01-05 Thread David Miller
From: Wang Yufen Date: Thu, 5 Jan 2017 22:13:21 +0800 > From: Yufen Wang > > A possible NULL pointer dereference in tg3_get_stats64 while doing > tg3_free_consistent. ... > This patch avoids the NULL pointer dereference by using !tg3_flag(tp, >

Re: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 09:36:26AM -0800, Stephen Hemminger wrote: > Update the Hyper-V MAINTAINERS to include myself. > > Signed-off-by: Stephen Hemminger > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [PATCH net-next 0/3] rxrpc: Update tracing and proc interfaces

2017-01-05 Thread David Miller
org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20170105 Pulled, thanks.

[net-next PATCH v6 0/3] net: dummy: Introduce dummy virtual functions

2017-01-05 Thread Phil Sutter
This series adds VF support to dummy device driver after adding the necessary infrastructure changes: Patch 1 adds a netdevice callback for device-specific VF count retrieval. Patch 2 then changes dev_num_vf() implementation to make use of that new callback (if implemented), falling back to the

[net-next PATCH v6 2/3] net: rtnetlink: Use a local dev_num_vf() implementation

2017-01-05 Thread Phil Sutter
Promote dev_num_vf() to be no longer PCI device specific but use ndo_get_vf_count() if implemented and only fall back to pci_num_vf() like the old dev_num_vf() did. Since this implementation no longer requires a parent device to be present, don't pass the parent but the actual device to it and

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-01-05 Thread Daniel Borkmann
On 01/05/2017 07:27 PM, Eric Dumazet wrote: On Thu, 2017-01-05 at 02:34 +0100, Daniel Borkmann wrote: [...] diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 7e39087..ddbda25 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -481,6 +481,9 @@ static __u32

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-05 Thread Florian Fainelli
On 01/05/2017 01:23 AM, Zefir Kurtisi wrote: > On 01/04/2017 10:44 PM, Florian Fainelli wrote: >> On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: >>> On 01/04/2017 04:30 PM, Florian Fainelli wrote: On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: > On 01/04/2017 04:13 PM, Florian

RE: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread KY Srinivasan
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 5, 2017 9:36 AM > To: da...@davemloft.net; KY Srinivasan > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > gre...@linuxfoundation.org; Stephen

Re: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread gre...@linuxfoundation.org
On Thu, Jan 05, 2017 at 05:43:04PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, January 5, 2017 9:36 AM > > To: da...@davemloft.net; KY Srinivasan > > Cc:

Re: Re: [PATCH] MIPS: NI 169445 board support

2017-01-05 Thread Niklas Cassel
On 01/04/2017 05:38 PM, Nathan Sullivan wrote: > On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: >> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote: >>> Date: Fri, 2 Dec 2016 09:42:09 -0600 >>> From: Nathan Sullivan >>> To:

Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib

2017-01-05 Thread David Miller
From: Eli Cohen Date: Thu, 5 Jan 2017 14:03:18 -0600 > If necessary I can make sure it builds on 32 bits as well. Please do.

Re: [PATCH] tg3: Avoid NULL pointer dereference in tg3_get_nstats()

2017-01-05 Thread David Miller
From: Michael Chan Date: Thu, 5 Jan 2017 12:04:13 -0800 > But it looks like ndo_get_stats() can be called without rtnl lock from > net-procfs.c. So it is possible that we'll read tp->hw_stats after it > has been freed. For example, if we are reading /proc/net/dev and

Re: [PATCH v4] net: ethernet: faraday: To support device tree usage.

2017-01-05 Thread Arnd Bergmann
On Thursday, January 5, 2017 6:23:53 PM CET Greentime Hu wrote: > Signed-off-by: Greentime Hu > --- > Changes in v4: > - Use the same binding document to describe the same faraday ethernet > controller and add faraday to vendor-prefixes.txt. > Changes in v3: > - Nothing

Re: [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Samudrala, Sridhar
On 1/5/2017 3:50 AM, Or Gerlitz wrote: On Thu, Jan 5, 2017 at 12:46 AM, Samudrala, Sridhar wrote: On 1/3/2017 3:03 PM, Or Gerlitz wrote: On Fri, Dec 30, 2016 at 7:04 PM, Samudrala, Sridhar wrote: On 12/30/2016 7:31 AM, Or Gerlitz

Re: [PATCH v1 1/2] bpf: add a longest prefix match trie map implementation

2017-01-05 Thread Daniel Mack
Hi, On 01/05/2017 09:01 PM, Daniel Borkmann wrote: > On 01/05/2017 05:25 PM, Daniel Borkmann wrote: >> On 12/29/2016 06:28 PM, Daniel Mack wrote: > [...] >>> +static struct bpf_map *trie_alloc(union bpf_attr *attr) >>> +{ >>> +struct lpm_trie *trie; >>> + >>> +/* check sanity of

[PATCH] net: phy: dp83867: fix irq generation

2017-01-05 Thread Grygorii Strashko
For proper IRQ generation by DP83867 phy the INT/PWDN pin has to be programmed as an interrupt output instead of a Powerdown input in Configuration Register 3 (CFG3), Address 0x001E, bit 7 INT_OE = 1. The current driver doesn't do this and as result IRQs will not be generated by DP83867 phy even

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2017-01-05 Thread Greg Kroah-Hartman
On Tue, Jan 03, 2017 at 10:19:29PM +0100, Arnd Bergmann wrote: > On Tuesday, January 3, 2017 4:24:36 PM CET Greg Kroah-Hartman wrote: > > On Wed, Mar 02, 2016 at 08:06:46PM +0100, Arnd Bergmann wrote: > > > The icn, act2000 and pcbit drivers are all for very old hardware, > > > and it is highly

[RFC PATCH] tcp: accept RST for rcv_nxt - 1 after receiving a FIN

2017-01-05 Thread Jason Baron
Using a Mac OSX box as a client connecting to a Linux server, we have found that when certain applications (such as 'ab'), are abruptly terminated (via ^C), a FIN is sent followed by a RST packet on tcp connections. The FIN is accepted by the Linux stack but the RST is sent with the same sequence

Re: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread gre...@linuxfoundation.org
On Thu, Jan 05, 2017 at 07:08:23PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, January 5, 2017 10:29 AM > > To: KY Srinivasan > > Cc: Stephen Hemminger

Re: [PATCH] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-05 Thread Andy Shevchenko
On Thu, Jan 5, 2017 at 12:47 PM, Kweh, Hock Leong wrote: > From: "Kweh, Hock Leong" > > There is no checking valid value of maxmtu when getting it from devicetree. 'Device Tree' or 'device tree' ? > This resolution added the checking

Re: [PATCH] tg3: Avoid NULL pointer dereference in tg3_get_nstats()

2017-01-05 Thread Michael Chan
On Thu, Jan 5, 2017 at 12:17 PM, David Miller wrote: > From: Michael Chan > Date: Thu, 5 Jan 2017 12:04:13 -0800 > >> But it looks like ndo_get_stats() can be called without rtnl lock from >> net-procfs.c. So it is possible that we'll read

Re: [PATCH] tg3: Avoid NULL pointer dereference in tg3_get_nstats()

2017-01-05 Thread Michael Chan
On Thu, Jan 5, 2017 at 9:33 AM, David Miller wrote: > From: Wang Yufen > Date: Thu, 5 Jan 2017 22:13:21 +0800 > >> From: Yufen Wang >> >> A possible NULL pointer dereference in tg3_get_stats64 while doing >> tg3_free_consistent. >

Re: [Intel-wired-lan] [net-next PATCH v2 2/6] i40e: Introduce VF Port Representator(VFPR) netdevs.

2017-01-05 Thread Jeff Kirsher
On Tue, 2017-01-03 at 10:07 -0800, Sridhar Samudrala wrote: > VF Port Representator netdevs are created for each VF if the switch mode > is set to 'switchdev'. These netdevs can be used to control and configure > VFs from PFs namespace. They enable exposing VF statistics, configure and > monitor

Re: [PATCH] net: phy: dp83867: fix irq generation

2017-01-05 Thread Florian Fainelli
On 01/05/2017 12:48 PM, Grygorii Strashko wrote: > For proper IRQ generation by DP83867 phy the INT/PWDN pin has to be > programmed as an interrupt output instead of a Powerdown input in > Configuration Register 3 (CFG3), Address 0x001E, bit 7 INT_OE = 1. The > current driver doesn't do this and

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
On 01/05/2017 03:42 PM, Murali Karicheri wrote: > Rob, > > On 12/22/2016 04:24 PM, Rob Herring wrote: >> On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >>> From: WingMan Kwok >>> >>> 10gbe phy driver needs to access the 10gbe subsystem control >>> register

Re: [PATCH v1 1/2] bpf: add a longest prefix match trie map implementation

2017-01-05 Thread Daniel Borkmann
Hi Daniel, On 01/05/2017 09:04 PM, Daniel Mack wrote: On 01/05/2017 05:25 PM, Daniel Borkmann wrote: On 12/29/2016 06:28 PM, Daniel Mack wrote: diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c new file mode 100644 index 000..8b6a61d --- /dev/null +++ b/kernel/bpf/lpm_trie.c

RE: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread KY Srinivasan
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 5, 2017 12:09 PM > To: KY Srinivasan > Cc: Stephen Hemminger ; > da...@davemloft.net; netdev@vger.kernel.org; linux- >

Re: [PATCH v1 1/2] bpf: add a longest prefix match trie map implementation

2017-01-05 Thread Daniel Borkmann
On 01/05/2017 05:25 PM, Daniel Borkmann wrote: On 12/29/2016 06:28 PM, Daniel Mack wrote: This trie implements a longest prefix match algorithm that can be used to match IP addresses to a stored set of ranges. Internally, data is stored in an unbalanced trie of nodes that has a maximum height

Re: [PATCH v4 net-next] tools: psock_tpacket: block Rx until socket filter has been added and socket has been bound to loopback.

2017-01-05 Thread David Miller
From: Sowmini Varadhan Date: Thu, 5 Jan 2017 11:06:22 -0800 > Packets from any/all interfaces may be queued up on the PF_PACKET socket > before it is bound to the loopback interface by psock_tpacket, and > when these are passed up by the kernel, they could interfere

Re: [PATCH v1 1/2] bpf: add a longest prefix match trie map implementation

2017-01-05 Thread Daniel Mack
Hi Daniel, Thanks for your feedback! I agree on all points. Two questions below. On 01/05/2017 05:25 PM, Daniel Borkmann wrote: > On 12/29/2016 06:28 PM, Daniel Mack wrote: >> diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c >> new file mode 100644 >> index 000..8b6a61d >> ---

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
Rob, On 12/22/2016 04:24 PM, Rob Herring wrote: > On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >> From: WingMan Kwok >> >> 10gbe phy driver needs to access the 10gbe subsystem control >> register during phy initialization. To facilitate the shared >> access

TCP using IPv4-mapped IPv6 address as source

2017-01-05 Thread Jonathan T. Leighton
I've observed TCP using an IPv4-mapped IPv6 address as the source address, which I believe contradicts https://tools.ietf.org/html/rfc6890#page-14 (BCP 153). This occurs when an IPv6 TCP socket, bound to a local IPv4-mapped IPv6 address, attempts to connect to a remote IPv6 address. Presumable

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

2017-01-05 Thread Russell King - ARM Linux
On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: > If we start supporting generic "enable", "disable" type of properties > with values that map directly to register definitions of the HW, we > leave too much room for these properties to be utilized to implement a > specific

Re: [PATCH] net:phy fix driver reference count error when attach and detach phy device

2017-01-05 Thread Florian Fainelli
+Andrew, Le 01/05/17 à 18:29, maowenan a écrit : >>> @Florian Fainelli, what's your comments about this patch? >> >> I am trying to reproduce what you are seeing, but at first glance is looks >> like an >> appropriate solution to me. Do you mind giving me a couple more days? >> >> Thanks! >> --

Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-05 Thread Hariprasad S
> On 05-Jan-2017, at 9:35 PM, David Miller wrote: > > From: Hariprasad Shenai > Date: Thu, 5 Jan 2017 11:23:10 +0530 > >> @@ -844,6 +848,10 @@ struct adapter { >>struct work_struct db_drop_task; >>bool tid_release_task_busy; >> >> +

[PATCH 1/2] net: ipv4: Simplify rt_fill_info

2017-01-05 Thread David Ahern
rt_fill_info has only 1 caller and both of the last 2 args -- nowait and flags -- are hardcoded to 0. Given that remove them as input arguments and simplify rt_fill_info accordingly. Signed-off-by: David Ahern --- net/ipv4/route.c | 20 +++- 1 file

Re: [PATCH 1/2] net: ipv4: Simplify rt_fill_info

2017-01-05 Thread David Ahern
On 1/5/17 8:32 PM, David Ahern wrote: > rt_fill_info has only 1 caller and both of the last 2 args -- nowait > and flags -- are hardcoded to 0. Given that remove them as input arguments > and simplify rt_fill_info accordingly. > > Signed-off-by: David Ahern > --- >

[PATCH net-next] net: ipv4: make fib_select_default static

2017-01-05 Thread David Ahern
fib_select_default has a single caller within the same file. Make it static. Signed-off-by: David Ahern --- include/net/ip_fib.h | 1 - net/ipv4/fib_semantics.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/net/ip_fib.h

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Samudrala, Sridhar
On 1/5/2017 4:56 AM, Jiri Pirko wrote: Tue, Jan 03, 2017 at 07:07:53PM CET, sridhar.samudr...@intel.com wrote: In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts and unknown frames from VFs are received by the PF and passed to corresponding VF port representator netdev.

[PATCH iproute2 1/3] ip vrf: Fix run-on error message on mkdir failure

2017-01-05 Thread David Ahern
Andy reported a missing newline if a non-root user attempts to run 'ip vrf exec': $ ./ip/ip vrf exec default /bin/echo asdf mkdir failed for /var/run/cgroup2: Permission deniedFailed to setup vrf cgroup2 directory Reported-by: Andy Lutomirski Signed-off-by: David Ahern

[PATCH iproute2 3/3] ip vrf: Improve bpf error messages

2017-01-05 Thread David Ahern
Next up a non-root user gets various bpf related error messages: $ ip vrf exec mgmt bash Failed to load BPF prog: 'Operation not permitted' Kernel compiled with CGROUP_BPF enabled? Catch the EPERM error and do not show the kernel config option. Signed-off-by: David Ahern

Re: [RFC PATCH] virtio_net: XDP support for adjust_head

2017-01-05 Thread Michael S. Tsirkin
On Thu, Jan 05, 2017 at 02:57:23PM -0800, John Fastabend wrote: > On 17-01-03 02:16 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 03, 2017 at 02:01:27PM +0800, Jason Wang wrote: > >> > >> > >> On 2017年01月03日 03:44, John Fastabend wrote: > >>> Add support for XDP adjust head by allocating a 256B

Re: [RFC PATCH] virtio_net: XDP support for adjust_head

2017-01-05 Thread John Fastabend
On 17-01-03 02:16 PM, Michael S. Tsirkin wrote: > On Tue, Jan 03, 2017 at 02:01:27PM +0800, Jason Wang wrote: >> >> >> On 2017年01月03日 03:44, John Fastabend wrote: >>> Add support for XDP adjust head by allocating a 256B header region >>> that XDP programs can grow into. This is only enabled when a

RE: [PATCH 2/2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-05 Thread Tantilov, Emil S
>-Original Message- >From: Gavin Shan [mailto:gws...@linux.vnet.ibm.com] >Sent: Wednesday, January 04, 2017 3:12 PM >To: Tantilov, Emil S >Cc: Gavin Shan ; linux-...@vger.kernel.org; >intel-wired-...@lists.osuosl.org; Duyck, Alexander

[PATCH v2] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" There is no checking valid value of maxmtu when getting it from device tree. This resolution added the checking condition to ensure the assignment is made within a valid range. Signed-off-by: Kweh, Hock Leong ---

Re: [RFC PATCH] virtio_net: XDP support for adjust_head

2017-01-05 Thread John Fastabend
On 17-01-05 04:39 PM, Michael S. Tsirkin wrote: > On Thu, Jan 05, 2017 at 02:57:23PM -0800, John Fastabend wrote: >> On 17-01-03 02:16 PM, Michael S. Tsirkin wrote: >>> On Tue, Jan 03, 2017 at 02:01:27PM +0800, Jason Wang wrote: On 2017年01月03日 03:44, John Fastabend wrote: > Add

[PATCH net] udp: inuse checks can quit early for reuseport

2017-01-05 Thread Eric Garver
UDP lib inuse checks will walk the entire hash bucket to check if the portaddr is in use. In the case of reuseport we can stop searching when we find a matching reuseport. On a 16-core VM a test program that spawns 16 threads that each bind to 1024 sockets (one per 10ms) takes 1m45s. With this

[PATCH iproute2 0/3] ip vrf: minor error message cleanups

2017-01-05 Thread David Ahern
David Ahern (3): ip vrf: Fix error message when running exec as non-root user ip vrf: Improve error message for non-root user ip vrf: Clean up bpf related error messages ip/ipvrf.c | 6 +- lib/fs.c | 16 2 files changed, 17 insertions(+), 5 deletions(-) -- 2.1.4

[PATCH iproute2 2/3] ip vrf: Improve cgroup2 error messages

2017-01-05 Thread David Ahern
Currently, if a non-root user attempts to run ip vrf exec a non-helpful error is returned: $ ip vrf exec mgmt bash Failed to mount cgroup2. Are CGROUPS enabled in your kernel? Only show the CGROUPS kernel hint for the ENODEV error and for the rest show the strerror for the errno. So now: $

Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area

2017-01-05 Thread kbuild test robot
Hi Florian, [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-skbuff-merge-nfctinfo-bits-and-nfct-pointer/20170105-133727 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-05 Thread Zefir Kurtisi
On 01/04/2017 10:44 PM, Florian Fainelli wrote: > On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: >> On 01/04/2017 04:30 PM, Florian Fainelli wrote: >>> >>> >>> On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: On 01/04/2017 04:13 PM, Florian Fainelli wrote: > > > On 01/04/2017 07:04 AM,

[PATCHv2 1/1] r8169: fix the typo in the comment

2017-01-05 Thread yanjun . zhu
From: Zhu Yanjun >From the realtek data sheet, the PID0 should be bit 0. Signed-off-by: Zhu Yanjun --- Change from v1 to v2: change the commit header. drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] sh_eth: R8A7740 supports packet shecksumming

2017-01-05 Thread Sergei Shtylyov
Hello! Oops, typo in the subject, "shecksumming". David, should I resend? MBR, Sergei

[PATCH v2 net-next] net:dsa: check for EPROBE_DEFER from dsa_dst_parse()

2017-01-05 Thread Volodymyr Bendiuga
Since there can be multiple dsa switches stacked together but not all of devicetree nodes available at the time of calling dsa_dst_parse(), EPROBE_DEFER can be returned by it. When this happens, only the last dsa switch has to be deleted by dsa_dst_del_ds(), but not the whole list, because next

[PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers

2017-01-05 Thread Amir Vadai
Hi Dave, This is a respin of the patchset. V1 was sent and didn't make it for 4.10. You asked me [1] why did I use specific header names instead of layers (L2, L3...), and I explained that it is on purpose, this extra information is planned to be used by hardware drivers to offload the action.

[PATCH net-next V2 2/3] net/act_pedit: Support using offset relative to the conventional network headers

2017-01-05 Thread Amir Vadai
Extend pedit to enable the user setting offset relative to network headers. This change would enable to work with more complex header schemes (vs the simple IPv4 case) where setting a fixed offset relative to the network header is not enough. It is also forward looking to enable hardware

Re: [net PATCH 1/2] virtio_net: cap mtu when XDP programs are running

2017-01-05 Thread Jason Wang
On 2017年01月05日 11:18, Michael S. Tsirkin wrote: On Wed, Jan 04, 2017 at 07:11:18PM -0800, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program load and does not block MTU changes after the

[PATCH net-next V2 1/3] net/skbuff: Introduce skb_mac_offset()

2017-01-05 Thread Amir Vadai
Introduce skb_mac_offset() that could be used to get mac header offset. Signed-off-by: Amir Vadai Reviewed-by: Or Gerlitz --- include/linux/skbuff.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h

Re: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS)

2017-01-05 Thread Joao Pinto
Às 1:37 AM de 1/5/2017, Kweh, Hock Leong escreveu: >> -Original Message- >> From: Joao Pinto [mailto:joao.pi...@synopsys.com] >> Sent: Wednesday, January 04, 2017 10:36 PM >> To: da...@davemloft.net >> Cc: Kweh, Hock Leong ; netdev@vger.kernel.org; >> Joao Pinto

[PATCH] net: ethoc: Remove unused members from struct ethoc

2017-01-05 Thread Tobias Klauser
The io_region_size and dma_alloc members of struct ethoc are only written but never read, so they might as well be removed. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/ethoc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/ethoc.c

Re: [PATCH net-next V2 3/3] tun: rx batching

2017-01-05 Thread Stefan Hajnoczi
On Wed, Jan 04, 2017 at 11:03:32AM +0800, Jason Wang wrote: > On 2017年01月03日 21:33, Stefan Hajnoczi wrote: > > On Wed, Dec 28, 2016 at 04:09:31PM +0800, Jason Wang wrote: > > > +static int tun_rx_batched(struct tun_file *tfile, struct sk_buff *skb, > > > + int more) > > > +{ > >

[PATCH] net: xilinx: emaclite: Remove xemaclite_remove_ndev()

2017-01-05 Thread Tobias Klauser
xemaclite_remove_ndev() is a simple wrapper around free_netdev() checking for NULL before the call. All possible paths calling it are guaranteed to pass a non-NULL argument, so rather call free_netdev() directly. Signed-off-by: Tobias Klauser ---

[PATCH v3 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip

2017-01-05 Thread Volodymyr Bendiuga
This chip needs MV88E6XXX_FLAG_G2_INT Signed-off-by: Volodymyr Bendiuga Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h

[PATCH net-next V2 3/3] net/act_pedit: Introduce 'add' operation

2017-01-05 Thread Amir Vadai
This command could be useful to inc/dec fields. Command type is embedded inside the existing shift field in an unused bits, therefore UAPI backward compatibility is being kept. For example, to forward any TCP packet and decrease its TTL: $ tc filter add dev enp0s9 protocol ip parent : \

[PATCHv2 1/1] r8169: fix the typo in the comment

2017-01-05 Thread Zhu Yanjun
>From the realtek data sheet, the PID0 should be bit 0. Signed-off-by: Zhu Yanjun --- Change from v1 to v2: change the commit header. drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-05 Thread Simon Horman
On Wed, Jan 04, 2017 at 01:45:28PM +0200, Paul Blakey wrote: > On 04/01/2017 12:14, Simon Horman wrote: > >On Tue, Jan 03, 2017 at 02:22:05PM +0200, Paul Blakey wrote: > >> > >>On 03/01/2017 13:44, Jamal Hadi Salim wrote: > >>>On 17-01-02 11:33 PM, John Fastabend wrote: > On 17-01-02 05:22 PM,

Re: [PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers

2017-01-05 Thread Jiri Benc
On Thu, 5 Jan 2017 14:34:58 +0200, Amir Vadai wrote: > This is a simple action. It is not fool proof - it prevents the user > from getting out of packet bounds, but it is the user responsibility to > provide valid rules. I think I can live with that. Just wanted to point that out. Especially with

Re: [net-next PATCH v2 2/6] i40e: Introduce VF Port Representator(VFPR) netdevs.

2017-01-05 Thread Jiri Pirko
Tue, Jan 03, 2017 at 07:07:50PM CET, sridhar.samudr...@intel.com wrote: >VF Port Representator netdevs are created for each VF if the switch mode >is set to 'switchdev'. These netdevs can be used to control and configure >VFs from PFs namespace. They enable exposing VF statistics, configure and

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Jiri Pirko
Tue, Jan 03, 2017 at 07:07:53PM CET, sridhar.samudr...@intel.com wrote: >In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts and >unknown frames from VFs are received by the PF and passed to corresponding VF >port representator netdev. >A host based switching entity like a

[PATCH v4] net: ethernet: faraday: To support device tree usage.

2017-01-05 Thread Greentime Hu
Signed-off-by: Greentime Hu --- Changes in v4: - Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt. Changes in v3: - Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.

[PATCH 0/6] Netfilter fixes for net

2017-01-05 Thread Pablo Neira Ayuso
Hi David, The following patchset contains accumulated Netfilter fixes for your net tree: 1) Ensure quota dump and reset happens iff we can deliver numbers to userspace. 2) Silence splat on incorrect use of smp_processor_id() from nft_queue. 3) Fix an out-of-bound access reported by KASAN in

[PATCH 1/6] netfilter: nft_quota: reset quota after dump

2017-01-05 Thread Pablo Neira Ayuso
Dumping of netlink attributes may fail due to insufficient room in the skbuff, so let's reset consumed quota if we succeed to put netlink attributes into the skbuff. Fixes: 43da04a593d8 ("netfilter: nf_tables: atomic dump and reset for stateful objects") Reported-by: Eric Dumazet

[PATCH 4/6] netfilter: nft_payload: mangle ckecksum if NFT_PAYLOAD_L4CSUM_PSEUDOHDR is set

2017-01-05 Thread Pablo Neira Ayuso
If the NFT_PAYLOAD_L4CSUM_PSEUDOHDR flag is set, then mangle layer 4 checksum. This should not depend on csum_type NFT_PAYLOAD_CSUM_INET since IPv6 header has no checksum field, but still an update of any of the pseudoheader fields may trigger a layer 4 checksum update. Fixes: 1814096980bb

[PATCH 3/6] netfilter: nf_tables: fix oob access

2017-01-05 Thread Pablo Neira Ayuso
From: Florian Westphal BUG: KASAN: slab-out-of-bounds in nf_tables_rule_destroy+0xf1/0x130 at addr 88006a4c35c8 Read of size 8 by task nft/1607 When we've destroyed last valid expr, nft_expr_next() returns an invalid expr. We must not dereference it unless it passes !=

  1   2   >